Retnakaran
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
qapi/migration.json | 127 +++-
1 file changed, 125 insertions(+), 2 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 88ecf86ac8..fd9286ea0f 100644
--- a/qapi
On 21/11/22 6:10 pm, Juan Quintela wrote:
Het Gala wrote:
To prevent double data encoding of uris, instead of passing transport
mechanisms, host address and port all together in form of a single string
and writing different parsing functions, we intend the user to explicitly
mention most of
On 22/11/22 2:53 pm, Daniel P. Berrangé wrote:
On Mon, Nov 21, 2022 at 01:40:27PM +0100, Juan Quintela wrote:
Het Gala wrote:
To prevent double data encoding of uris, instead of passing transport
mechanisms, host address and port all together in form of a single string
and writing different
igrate-incoming' command to be used.
iii) Format for -multi-fd-incoming flag as a comma separated string has been
added with each substring containing listener socket address and number
of sockets to open.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migrati
Pv6 happens before connection is created.
----
Het Gala (7):
multifd: adding more helper functions in util files for live migration
multifd: modifying 'migrate' qmp command to add multifd socket on
particular src and dest pair
multifd: adding multi-interface suppor
parameters' list and length of the
list is stored in 'OutgoingMigrateParams' struct.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/migration.c | 52 +
migration/socket.c| 60 ---
m
i) Dynamically decide appropriate source and destination ip pairs for the
corresponding multifd channel to be connected.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
migration/multifd.c | 6 +++---
migration/socket.c | 37 ++---
migration
i) strList_from_string() shifted from hm-cmds.c -> qapi-util.c
ii) Adding qemu_string_count_delim() helper func. in qapi-util.c and
QAPI_LIST_LENGTH() macro defined func. in util.h
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/qapi/util.h | 12
monitor/
i) hmp_migrate and hmp_migrate_incoming functions are modified
according to the modified qmp monitor commands.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
monitor/hmp-cmds.c | 34 +++---
1 file changed, 31 insertions(+), 3 deletions(-)
diff --git a
destination pairs.
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
include/io/channel-socket.h| 44
include/qemu/sockets.h | 6 ++-
io/channel-socket.c| 93 ++
migration/socket.c | 4 +-
tests/unit
Suggested-by: Manish Mishra
Signed-off-by: Het Gala
---
util/qemu-sockets.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 491e2f2bc9..724c081e6c 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu
On 26/07/22 4:50 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:16PM +, Het Gala wrote:
i) Modified the format of qemu monitor command: 'migrate-incoming' by adding
a list, each element in the list to open socket listeners with a given
number of multifd cha
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list consisting of multifd connection parameters: source
uri, desti
On 26/07/22 4:14 pm, Daniel P. Berrangé wrote:
In $SUBJECT s/multifd:/io:/ as this is not migration related.
On Thu, Jul 21, 2022 at 07:56:18PM +, Het Gala wrote:
i) Binding of the socket to source ip address and port on the non-default
interface has been implemented for multi
On 02/08/22 1:23 pm, Markus Armbruster wrote:
Het Gala writes:
On 26/07/22 4:43 pm, Daniel P. Berrangé wrote:
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote:
i) Modified the format of the qemu monitor command : 'migrate' by adding a list,
each element in the list
in later commits.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Juan Quintela
Reviewed-by: Daniel P. Berrangé
Acked-by: Markus Armbruster
---
qapi/migration.json | 41 +
1 file changed, 41 insertions(+)
diff --git a/qapi/mi
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/migration-hmp-cmds.c | 16 +---
migration/migration.c | 5
ype
Transport-type
Migration parameters based on transport type
--
Het Gala (10):
migration: New QAPI type 'MigrateAddress'
migration: convert migration 'uri' in
-off-by: Het Gala
---
migration/migration.c | 77 ---
1 file changed, 50 insertions(+), 27 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 6e0a8beaf2..acf80b3590 100644
--- a/migration/migration.c
+++ b/migration/migration.c
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retna
ggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 30 ++
migration/socket.c| 39 +--
migration/socket.h| 7 ---
3 files changed, 31 insertions(+), 45 deleti
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-
hannel' to make migration
QAPIs future proof.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Acked-by: Markus Armbruster
---
migration/migration-hmp-cmds.c | 6 +-
migration/migration.c | 34 --
qapi/migration.json| 109 +++
ggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 8
migration/rdma.c | 34 --
migration/rdma.h | 6 --
3 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/mig
eChannel' :
migration_channels_and_uri_compatible() ->
migration_channels_and_transport_compatible() passes object as argument
and check for valid transport mechanism.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 25 ++---
1
On 26/07/23 12:07 am, Daniel P. Berrangé wrote:
On Tue, Jul 25, 2023 at 07:34:09PM +0100, Daniel P. Berrangé wrote:
On Fri, Jul 21, 2023 at 02:49:31PM +, Het Gala wrote:
MigrateChannelList allows to connect accross multiple interfaces.
Add MigrateChannelList struct as argument to
On 26/07/23 12:08 am, Daniel P. Berrangé wrote:
On Fri, Jul 21, 2023 at 02:49:34PM +, Het Gala wrote:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for qmp migration.
For current series, limit the size of
On 26/07/23 12:45 am, Daniel P. Berrangé wrote:
On Fri, Jul 21, 2023 at 02:49:35PM +, Het Gala wrote:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off
:
On Fri, Jul 21, 2023 at 02:49:31PM +, Het Gala wrote:
MigrateChannelList allows to connect accross multiple interfaces.
Add MigrateChannelList struct as argument to migration QAPIs.
We plan to include multiple channels in future, to connnect
multiple interfaces. Hence, we choose
On 26/07/23 2:05 pm, Daniel P. Berrangé wrote:
On Wed, Jul 26, 2023 at 01:24:48AM +0530, Het Gala wrote:
Sorry, last reply on this patch was accidently replied only to Daniel.
Pasting the reply again so it is received by all the active maintianers
here. Apologies for the error 😅
On 26/07/23
Exec transport backend for 'migrate'/'migrate-incoming' QAPIs accept
new wire protocol of MigrateAddress struct.
It is achived by parsing 'uri' string and storing migration parameters
required for exec connection into strList struct.
Suggested-by: Aravind Retna
ggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 8
migration/rdma.c | 34 --
migration/rdma.h | 6 --
3 files changed, 20 insertions(+), 28 deletions(-)
diff --git a/mig
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
---
migration/migration-hmp-cmds.c | 15 +--
migration/migration.c | 5
This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri'
string containing migration connection related information
and stores them inside well defined 'MigrateAddress' struct.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-
hannel' to make migration
QAPIs future proof.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Acked-by: Markus Armbruster
---
migration/migration-hmp-cmds.c | 6 +-
migration/migration.c | 56 +++--
qapi/migration.json| 109 ++
-off-by: Het Gala
---
migration/migration.c | 95 +++
1 file changed, 52 insertions(+), 43 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index 5720c8ed4c..d54ecbb00d 100644
--- a/migration/migration.c
+++ b/migration/migration.c
in later commits.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Juan Quintela
Reviewed-by: Daniel P. Berrangé
Acked-by: Markus Armbruster
---
qapi/migration.json | 41 +
1 file changed, 41 insertions(+)
diff --git a/qapi/mi
rent migration parameters are defined.
(uri) string --> (channel) Channel-type
Transport-type
Migration parameters based on transport type
--
Het Gala (10):
mi
eChannel' :
migration_channels_and_uri_compatible() ->
migration_channels_and_transport_compatible() passes object as argument
and check for valid transport mechanism.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 25 ++---
1
ggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
migration/migration.c | 30 ++
migration/socket.c| 39 +--
migration/socket.h| 7 ---
3 files changed, 31 insertions(+), 45 deleti
modify multifd tcp common test to incorporate the new QAPI
syntax defined.
Suggested-by: Aravind Retnakaran
Signed-off-by: Het Gala
Reviewed-by: Daniel P. Berrangé
---
tests/qtest/migration-test.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/migration
On 26/07/23 8:25 pm, Daniel P. Berrangé wrote:
On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma) for both src and dest migration
endpoints for hmp migration.
Suggested-by: Aravind Retnakaran
Signed-off
On 26/07/23 10:11 pm, Daniel P. Berrangé wrote:
On Wed, Jul 26, 2023 at 10:08:05PM +0530, Het Gala wrote:
On 26/07/23 8:25 pm, Daniel P. Berrangé wrote:
On Wed, Jul 26, 2023 at 02:18:32PM +, Het Gala wrote:
Integrate MigrateChannelList with all transport backends
(socket, exec and rdma
from Daniel on the QAPI
implementation side patches.
On 26/07/23 7:48 pm, Het Gala wrote:
This is v10 patchset of modified 'migrate' and 'migrate-incoming' QAPI design
for upstream review.
Would like to thank all the maintainers that actively participated in the v9
pat
just Part1 of the 4 patchset series. Ultimate goal is to
'introduce multiple interface support on top of existing multifd
capability'.
On 27/07/23 4:59 pm, Het Gala wrote:
This is just a ping for Juan and other migration maintainers, if it's
possible to have a look at the migrat
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted. It won't work because
The final 'migrate' QAPI with channels string would look like
{ "execute": "migr
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted. It won't work because
The final 'migrate' QAPI with channels string would look l
On 29/02/24 6:47 am, Fabiano Rosas wrote:
Het Gala writes:
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted. It won't work because
The
On 01/03/24 2:19 pm, Het Gala wrote:
On 29/02/24 6:47 am, Fabiano Rosas wrote:
Het Gala writes:
On 27/02/24 1:04 am, Het Gala wrote:
On 26/02/24 6:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
this was the same first approach that I attempted
stom function for converting string to MigrationChannelList
5. move calls for migrate_get_socket_address inside migrate_qmp so that
migrate_set_ports can replace the QAPI's port with correct value.
Het Gala (7):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_g
Move the calls to migrate_get_socket_address() into migrate_qmp().
Get rid of connect_uri and replace it with args->connect_uri only
because 'to' object will help to generate connect_uri with the
correct port number.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qt
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 29 ++---
1 file changed
Add the 'to' object into migrate_qmp(), so we can use
migrate_get_socket_address() inside migrate_qmp() to get
the port value. This is not applied to other migrate_qmp*
because they don't need the port.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migr
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
passes more than one channel.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-helpers.c | 26
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
Migration QAPI arguments - uri and channels are mutually exhaustive.
Add negative validation tests, one with both arguments present and
one with none present.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 54
1 file
On 06/03/24 4:19 pm, Het Gala wrote:
Can also find the successful build here:
https://gitlab.com/galahet/Qemu/-/pipelines/1201488612
Het Gala (7):
Add 'to' object into migrate_qmp()
Replace connect_uri and move migrate_get_socket_address inside
migrate_qmp
Add channels
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
passes more than one channel.
Signed-off-by: Het Gala
Suggested-by
On 06/03/24 8:10 pm, Fabiano Rosas wrote:
Het Gala writes:
Alter migrate_qmp_fail() to allow both uri and channels
independently. For channels, convert string to a Dict.
No dealing with migrate_get_socket_address() here because
we will fail before starting the migration anyway.
Signed-off
On 06/03/24 8:12 pm, Fabiano Rosas wrote:
Het Gala writes:
Alter migrate_qmp() to allow use of channels parameter, but only
fill the uri with correct port number if there are no channels.
Here we don't want to allow the wrong cases of having both or
none (ex: migrate_qmp_fail).
Signe
On 06/03/24 8:37 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a positive test to check multifd live migration but this time
using list of channels (restricted to 1) as the starting point
instead of simple uri string.
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest
On 06/03/24 9:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
On 06/03/24 9:31 pm, Fabiano Rosas wrote:
Het Gala writes:
On 06/03/24 8:06 pm, Fabiano Rosas wrote:
Het Gala writes:
Add a migrate_set_ports() function that from each QDict, fills in
the port in case it was 0 in the test.
Handle a list of channels so we can add a negative test that
blished, qmp command will error out with
MIG_TEST_QMP_ERROR.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 83
1 file changed, 83 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 0bc69b1943..9b939
Introduce support for adding a 'channels' argument to migrate_qmp_fail
and migrate_qmp functions within the migration qtest framework, enabling
enhanced control over migration scenarios.
Signed-off-by: Het Gala
---
tests/qtest/dbus-vmstate-test.c | 2 +-
tests/qtest/migration-help
7;channels' arguments
and a conversion function from MigrationChannelList to QList.
2. Add a new field in the MigrateCommon struct to support the 'channels'
argument during migration.
3. Include negative validation tests to disallow both arguments in migration
QAPIs.
Het Gala
migration QAPIs can now work with either 'channels' or 'uri' as their
argument.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index e7f2719dc
Signed-off-by: Het Gala
---
qapi/migration.json | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 5a565d9b8d..5756e650b0 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -1728,6 +1728,7
From: Peter Xu
Date: Tuesday, 20 February 2024 at 11:33 AM
To: Het Gala
Cc: qemu-devel@nongnu.org , arm...@redhat.com
, berra...@redhat.com , faro...@suse.de
Subject: Re: [PATCH 1/3] qtest: migration: Enhance qtest migration functions to
support 'channels' argument
On Fri, Feb 1
On 20/02/24 11:34 am, Peter Xu wrote:
On Fri, Feb 16, 2024 at 09:06:23AM +, Het Gala wrote:
migration QAPIs can now work with either 'channels' or 'uri' as their
argument.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 7 +++
1 file changed, 7
On 20/02/24 11:57 am, Peter Xu wrote:
On Fri, Feb 16, 2024 at 09:06:24AM +, Het Gala wrote:
Ideally QAPI 'migrate' and 'migrate-incoming' does not allow 'uri' and
'channels' both arguments to be present in the arguments list as they
are mutually
, please have a look.
Het Gala writes:
Signed-off-by: Het Gala
---
qapi/migration.json | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 5a565d9b8d..5756e650b0 100644
--- a/qapi/migration.json
+++ b/qapi/migra
On 21/02/24 7:54 am, Peter Xu wrote:
On Tue, Feb 20, 2024 at 06:14:46PM +, Het Gala wrote:
From: Peter Xu
Date: Tuesday, 20 February 2024 at 11:33 AM
To: Het Gala
Cc:qemu-devel@nongnu.org ,arm...@redhat.com
,berra...@redhat.com ,faro...@suse.de
Subject: Re: [PATCH 1/3] qtest
es to validate the same. Even before the migration
connection is established, qmp command should error out with
MIG_TEST_QMP_ERROR.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 91
1 file changed, 91 insertions(+)
diff --git a/tests/qtest/
passed simulatneously to migrate QAPI.
4. The common function do_test_validate_uri_channel() is modified, similar
to test_baddest() - causing thefunction to always fail.
5. Add a new positive qtest to start migration qmp command with 'channels'
argument in place of 'uri' arg
support for 'channels'
as an alternative entrypoint argument. Additionally, validates the
functionality of MigrationChannelList in the context of establishing
migration connection.
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 34 +-
1 file chang
Introduce support for adding a 'channels' argument to migrate_qmp_fail,
migrate_incoming_qmp and migrate_qmp functions within the migration qtest
framework, enabling enhanced control over migration scenarios.
Signed-off-by: Het Gala
---
tests/qtest/dbus-vmstate-test.c | 2 +-
t
CI Run for the whole patchset series:
https://gitlab.com/galahet/Qemu/-/pipelines/1188155391
On 23/02/24 8:55 pm, Het Gala wrote:
Introduce support for adding a 'channels' argument to migrate_qmp_fail,
migrate_incoming_qmp and migrate_qmp functions within the migration qtest
On 24/02/24 1:42 am, Fabiano Rosas wrote:
Het Gala writes:
Introduce support for adding a 'channels' argument to migrate_qmp_fail,
migrate_incoming_qmp and migrate_qmp functions within the migration qtest
framework, enabling enhanced control over migration scenarios.
Can't
On 24/02/24 6:18 pm, Het Gala wrote:
On 24/02/24 1:42 am, Fabiano Rosas wrote:
Het Gala writes:
Introduce support for adding a 'channels' argument to migrate_qmp_fail,
migrate_incoming_qmp and migrate_qmp functions within the migration qtest
framework, enabling enhanced co
Ensure failure occurs while adding validation test for 'uri' and 'channels'
arguments
used simultaneously in the 'migrate' QAPI command.
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 14 ++--
tests/qtest/migration-helpers.h | 5 +--
tests/
ssistance you can provide.
On 09/02/24 1:21 pm, Het Gala wrote:
Ensure failure occurs while adding validation test for 'uri' and 'channels'
arguments
used simultaneously in the 'migrate' QAPI command.
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers
On 09/02/24 1:33 pm, Het Gala wrote:
I wanted to share an update regarding the patch I've been working on.
It seems that the patch is not yet fully ready as it encountered some
issues during the check-qtest builds.
Test fails with error:
55/59 qemu:qtest+qtest-x86_64 / qtest-x
needs to be
addressed. Can be multiple
(more than one applicable, separated by using '-' in between)
O: optional
Signed-off-by: Het Gala
Suggested-by: Fabiano Rosas
---
tests/qtest/migration-test.c | 143 ++-
1 file changed, 72 insertions(+),
, will comply
with that once, we are on a consensus with the design)
On 27/03/24 1:08 am, Het Gala wrote:
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
test-type:: migrate | validate
migration-mode
a. migrate --> :: precopy | postcopy | mul
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes:
Some comments, mostly just thinking out loud...
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
Do we need an optional 'capability' element? I'm not sure how practical
is to leave that
ping !
On 27/03/24 4:18 pm, Het Gala wrote:
On 27/03/24 2:37 am, Fabiano Rosas wrote:
Het Gala writes:
Some comments, mostly just thinking out loud...
For --> migrate
//
//O:/...
For --> validate
///O:/O:/
/O:/O:/...
Do we need an optional 'capability' element?
setting correct migration ports. Fix that.
Fixes: (tests/qtest/migration: Add multifd_tcp_plain test using list of
channels instead of uri)
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 2 --
tests/qtest/migration-test.c| 2 +-
2 files changed, 1 insertion(+), 3 de
ng to introduce
similar qtests in migration.
Fix multifd_tcp_channels_none qtest to actually utilise 'channels' arg
in migrate QAPIs
This patchset is built on top of (tests/qtest/migration: Add tests for
introducing 'channels' argument in migrate QAPIs)
Het Gala (2):
Fix typ
Fixes: (tests/qtest/migration: Add negative tests to validate migration QAPIs)
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d03a655f83..584d7c496f
On 08/04/24 9:05 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
Hey, Het,
On Sun, Apr 07, 2024 at 01:21:24PM +, Het Gala wrote:
Fixes: (tests/qtest
On 08/04/24 9:10 pm, Peter Xu wrote:
!---|
CAUTION: External Email
|---!
On Sun, Apr 07, 2024 at 01:21:25PM +, Het Gala wrote:
Earlier, without args
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index d03a655f83..584d7c496f 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
multifd_tcp_channels_none to actually use 'channels' arg.
2. use 'git commit --fixup' to improve commit message as well as
to inform on which commit is the fix meant to be.
Het Gala (3):
fixup! tests/qtest/migration: Add negative tests to validate migration
QAPIs
fi
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
index 584d7c496f..5d6d8cd634 100644
--- a/tests/qtest/migration-test.c
+++ b/tests/qtest/migration-test.c
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/migration-helpers.c b/tests/qtest/migration-helpers.c
index b2a90469fb..3b72cad6c1 100644
--- a/tests/qtest/migration-helpers.c
+++ b/tests/qtest
Add qtests to perform postcopy live migration by having list of
'channels' argument as the starting point instead of uri string.
(Note: length of the list is restricted to 1 for now)
Signed-off-by: Het Gala
---
tests/qtest/migration-test.c | 38 ++
Already have a migrate_incoming_qmp helper function to initiate
'migrate-incoming' QMP command with some additional checks.
Replace 'migrate-incoming' qtest_qmp_assert_success command with
calling migrate_incoming_qmp helper function for postcopy qtests.
Signed-off-by: Het Ga
1 - 100 of 379 matches
Mail list logo
