With recent migrate QAPI changes enabling direct use of the 'channels' argument, avoiding redundant string parsing of the URI is achieved.
To ensure backward compatibility, both 'uri' and 'channels' arguments are now optional in migration QMP commands. However, they are mutually exclusive, requiring at least one for a successful migration connection. Hence, validating 'uri' and 'channels' becomes crucial to prevent their simultaneous presence in migrate QAPIs. Patch Summary: 1. Introduce migrate_qmp() and migrate_qmp_fail() with 'channels' arguments and a conversion function from MigrationChannelList to QList. 2. Add a new field in the MigrateCommon struct to support the 'channels' argument during migration. 3. Include negative validation tests to disallow both arguments in migration QAPIs. Het Gala (3): qtest: migration: Enhance qtest migration functions to support 'channels' argument qtest: migration: Introduce 'connect_channels' in MigrateCommon struct qtest: migration: Add negative validation test for 'uri' and 'channels' both set tests/qtest/dbus-vmstate-test.c | 2 +- tests/qtest/migration-helpers.c | 93 ++++++++++++++++++++++-- tests/qtest/migration-helpers.h | 11 +-- tests/qtest/migration-test.c | 123 +++++++++++++++++++++++++++----- 4 files changed, 202 insertions(+), 27 deletions(-) -- 2.22.3