Hi,
> Subject: Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more
> idiomatic writing style
>
> On Thu, Jul 31, 2014 at 10:39 PM, Peter Maydell
> wrote:
> > On 31 July 2014 13:28, wrote:
> >> From: Gonglei
> >>
> >> Gonglei (7):
> >> usb: a trivial code change for more idio
Hi,
> Subject: Re: [PATCH v2 for-2.2 0/8] about Yoda conditions
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual
Hi,
> Subject: Re: [PATCH v2 1/8] CODING_STYLE: Section about conditional
> statement
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Yoda conidtions lack of readability, and QEMU have a
>
> s/conidtions/conditions/
> s/of //
> s/have/has/
>
OK.
> > strict
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> On 07/31/2014 08:32 PM, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Signed-off-by: Gonglei
> > ---
> > hw/usb/dev-audio.c | 2 +-
> > hw/usb/dev-mtp.c | 4 ++--
> > hw/usb/hcd-
Hi,
> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
> style
>
> Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> > Hi,
> >
> >> Subject: Re: [PATCH v2 2/8] usb: a trivial code change for more idiomatic
> writing
>
Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more
> idiomatic writing style
>
> Andreas Färber writes:
>
> > Am 01.08.2014 05:32, schrieb Gonglei (Arei):
> >> Hi,
> >>
> >>> Subject: Re: [PATCH v2 2/8] usb: a t
Hi,
> > Yoda conditions lack readability, and QEMU has a
> > strict compiler configuration for checking a common
> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > Signed-off-by: Gonglei
> > ---
> > CODING_STYLE | 14 ++
> > 1 file changed, 14 insertions(+)
> >
> > d
Hi,
> > >
> > > > +del_boot_device_path(dev);
> > >
> > > You can call this from device_finalize() instead of placing it into each
> > > individual device.
> > >
> > Maybe put this call in device_finalize is not a good idea.
> > I have three reasons:
> >
> > 1. the device's some memory have be
Best regards,
-Gonglei
> -Original Message-
> From: Eduardo Habkost [mailto:ehabk...@redhat.com]
> Sent: Friday, August 01, 2014 10:46 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; chenliang (T); Huangweidong (C);
> m...@redhat.com; a...@ozlabs.ru; hu...@cn.
Hi,
> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
>
> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >
> > Example QMP command:
> > -> { "execute": "se
Hi,
>
> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com wrote:
> > [...]
> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev,
> > > + const char *suffix)
> > > +{
> > > +FWBootEntry *i, *old_entry = NULL;
> > > +
> > > +a
Hi,
> >>
> >> > On Thu, Jul 31, 2014 at 05:47:26PM +0800, arei.gong...@huawei.com
> wrote:
> >> > [...]
> >> > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev,
> >> > > + const char *suffix)
> >> > > +{
> >> > > +FWBootEntry *i, *old_entry = NULL
Hi,
> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex command
> >>
> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com wrote:
> >> > From: Gonglei
> >> >
> >> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >> >
> >> > Example QMP command:
Hi, Markus
> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> command
> >> >>
> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com
> wrote:
> >> >> > From: Gonglei
> >> >> >
> >> >> > Adds "set-bootindex id=xx,bootindex=xx,suffix=xx" QMP command.
> >> >
Hi, Markus
> >
> >> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> >> command
> >> >> >>
> >> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800, arei.gong...@huawei.com
> >> wrote:
> >> >> >> > From: Gonglei
> >> >> >> >
> >> >> >> > Adds "set-bootindex id=xx,bootindex=xx,suf
Hi,
I' am so sorry for missing cc'ed Eduardo.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Monday, August 04, 2014 8:46 PM
> To: qemu-devel@nongnu.org
> Subject: [PATCH v5 0/8] modify boot order of guest, and take effect af
Hi,
> >> >> >> >> Subject: Re: [Qemu-devel] [PATCH v2 5/7] qmp: add set-bootindex
> >> >> command
> >> >> >> >>
> >> >> >> >> On Fri, Jul 25, 2014 at 02:52:50PM +0800,
> arei.gong...@huawei.com
> >> >> wrote:
> >> >> >> >> > From: Gonglei
> >> >> >> >> >
> >> >> >> >> > Adds "set-bootindex id=xx,
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
> >
> > v4:
> > - trivial typo for patch 1/8 suggested by Eric, thanks.
>
> Series: Reviewed-by: Eric Blake
>
> Adding qemu-tri
Hi,
> >
> > $WHATEVER: don't use 'Yoda conditions'
> >
> > 'Yoda conditions' are not part of idiomatic QEMU coding
> > style, so rewrite them in the more usual order.
>
>
> OK but why stop at these files? How about this
> instead?
>
I just search c files by using key words like "NULL ==" etc.
Hi,
> > >
> > >> > Yoda conditions lack readability, and QEMU has a
> > >> > strict compiler configuration for checking a common
> > >> > mistake like "if (dev = NULL)". Make it a written rule.
> >
> > >>
> > >> I know this is my suggested text, but now that I'm re-reading it, I'd
> > >> recommen
> Subject: [Qemu-devel] [PATCH v3 02/10] monitor: fix access freed memory
>
> The function monitor_fdset_dup_fd_find_remove() references member of
> 'mon_fdset'
> which may be freed in function monitor_fdset_cleanup()
>
> Signed-off-by: zhanghailiang
> ---
Reviewed-by: Gonglei
Best regards,
-
> Subject: [Qemu-devel] [PATCH v3 05/10] util/path: check return value of
> malloc()
>
> Signed-off-by: zhanghailiang
> ---
Reviewed-by: Gonglei
Best regards,
-Gonglei
> util/path.c | 9 ++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/util/path.c b/util/path.c
> Subject: [Qemu-devel] [PATCH v3 06/10] slirp: check return value of malloc()
>
> Signed-off-by: zhanghailiang
> ---
> slirp/misc.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/slirp/misc.c b/slirp/misc.c
> index b8eb74c..0109c9f 100644
> --- a/slirp/misc.c
> Subject: [Qemu-devel] [PATCH v3 08/10] qtest: check the value returned by
> fopen()
>
> The function fopen() may fail, so check its return value.
>
> Signed-off-by: zhanghailiang
> Signed-off-by: Li Liu
> ---
> qtest.c | 5 +
> tests/bios-tables-test.c | 2 ++
> 2 files
Hi,
Ping... please.
TBH, I am confused which maintainer can maintain the patch serials about
bootindex.
Gerd is seemingly not in maillist later two weeks.
Markus? Paolo? MST? PMM? Eduardo? Thanks for any help.
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Peter Crosthwaite
> Sent: Thursday, August 07, 2014 7:47 PM
> To: Hu Tao
> Cc: Yasunori Goto; Paolo Bonzini; Yasuaki Isimatu; qe
> Subject: Re: [PATCH v5 0/8] modify boot order of guest, and take effect after
> rebooting
>
> Il 07/08/2014 13:50, Gonglei (Arei) ha scritto:
> > Hi,
> >
> > Ping... please.
> >
> > TBH, I am confused which maintainer can maintain the patch serials ab
Hi,
> Subject: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation, add
> client/server tools
>
> Here is a patchset containing an update on ivshmem specs documentation and
> importing ivshmem server and client tools.
> These tools have been written from scratch and are not related to what
Hi,
> Subject: Re: [Qemu-devel] [PATCH v3 0/2] ivshmem: update documentation,
> add client/server tools
>
> Hello Gonglei,
>
> On 08/08/2014 11:30 AM, Gonglei (Arei) wrote:
> > If you can describe the steps of using example about
> > your ivshmem-client and ivs
Hi,
Based on discussions in:
http://lists.gnu.org/archive/html/qemu-devel/2013-11/threads.html#03322
About KVM_SET_GSI_ROUTING ioctl, I tested changing RCU to SRCU, but
unfortunately
it looks like SRCU's grace period is no better than RCU. I haven't got any idea
why this, but I suppose the te
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, March 25, 2014 12:01 AM
> To: Paolo Bonzini; Gonglei (Arei); qemu-devel@nongnu.org
> Cc: quint...@redhat.com; owass...@redhat.com; Yanqiangjun; Zhaoyanbin
> (A); Zengjunliang; libv
Hi,
I also encounter the same problem. When I use the Qemu mainline and with
-machine pc-i440fx-2.0, the win7 guest will show blue screen, and give me
"The BIOS in this system is not fully ACPI compliant. Please contact your system
Vendor for an updated BIOS.
Technical information:
*** STOP: 0x
Hi,
I also encounter the same problem. When I use the Qemu mainline and with
-machine pc-i440fx-2.0, the win7 guest will show blue screen, and give me
"The BIOS in this system is not fully ACPI compliant. Please contact your system
Vendor for an updated BIOS.
Technical information:
*** STOP: 0x
> -Original Message-
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Wednesday, March 26, 2014 3:59 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Huangweidong (C)
> Subject: Re: [PATCH] uhci: Lower uhci timer freq when guest is idle
>
> On Mi, 2
> > Based on discussions in:
> > http://lists.gnu.org/archive/html/qemu-devel/2013-11/threads.html#03322
> >
> > About KVM_SET_GSI_ROUTING ioctl, I tested changing RCU to SRCU, but
> unfortunately
> > it looks like SRCU's grace period is no better than RCU.
>
> Really? This is not what Christian
> On my system I have HZ=100 and lots of CPUs. So RCUs "every cpu has
> scheduled"
> is certainly slower than SRCUs algorithm
> (/*
> * We use an adaptive strategy for synchronize_srcu() and especially for
> * synchronize_srcu_expedited(). We spin for a fixed time period
> * (defined below) to
> > arch_init.c | 25 +
> > 1 file changed, 13 insertions(+), 12 deletions(-)
>
> Should this patch be included in 2.0 as a bug fix? The rest of the
> series is probably better off in 2.1.
>
Yes, it should be, but I am not so clear how to do it.
Eric, Could you give me
> > >> Return error for migrate cancel, when migration status is not
> > >> MIG_STATE_SETUP or MIG_STATE_ACTIVE. Thus, libvirt can can
> > >> perceive the operation fails.
> > >>
> > >> Signed-off-by: zengjunliang
> > >> Signed-off-by: Gonglei
> > >
> > > I think this is done on purpose, because
>
> Hi Gonglei,
>
> I've got a world which has this patch series on, and it's producing some
> XBZRLE
> errors,
> and I suspect that it's down to my original worries of running
> xbzrle_encode_buffer
> on changing data.
>
> My setup is a pair of machines, with a guest with 4GB RAM running SPECj
Hi,
My patch
http://git.qemu.org/?p=qemu.git;a=commitdiff;h=e3c1adf16e38714ebd761dd02517dd07760ba6d2
had been fixed this issue.
Best regards,
-Gonglei
From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
[mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On Behalf Of
Caizhi
> > If the networking break or there's something wrong with rdma
> > device(ib0 with no IP) during rdma migration, the main_loop of
> > qemu will be blocked in rdma_destroy_id. I add rdma_ack_cm_event
> > to fix this bug.
> >
> > Signed-off-by: Mo Yuxiang
> > Signed-off-by: Gonglei
> > ---
> >
Hi,
I'm learning qemu ga from wiki
http://wiki.qemu.org/Features/QAPI/GuestAgent
qemu-ga.exe is running in my windows VM now, and I want to debug it step by
step.
Could anyone specify how to debug in windows ? Thanks.
Best regards,
-Gonglei
Hi,
I have a problem about SR-IOV pass-through.
The PF is Emulex Corporation OneConnect NIC (Lancer)(rev 10),
and the VF pci config is as follow:
LINUX:/sys/bus/pci/devices/:04:00.6 # hexdump config
000 0010 0010 0200 0080
010 0
> > Hi,
> >
> > I have a problem about SR-IOV pass-through.
> >
> > The PF is Emulex Corporation OneConnect NIC (Lancer)(rev 10),
> > and the VF pci config is as follow:
> >
> > LINUX:/sys/bus/pci/devices/:04:00.6 # hexdump config
> > 000 0010 0010 0200 0080
> > 010
> > Hi,
> >
> > I have a problem about SR-IOV pass-through.
> >
> > The PF is Emulex Corporation OneConnect NIC (Lancer)(rev 10),
> > and the VF pci config is as follow:
> >
> > LINUX:/sys/bus/pci/devices/:04:00.6 # hexdump config
> > 000 0010 0010 0200 0080
> > 010
Hi,
> > >
> > Actually I move the judge in function assigned_dev_register_msix_mmio.
> > Because assigned_dev_register_msix_mmio do not address the return value,
> > if dev->msix_table is null, this will result a segfault. Right?
>
> I see the confusion, there is a bug there but I think it should
> Subject: Re: [Qemu-devel] [PATCH v4 5/8] XBZRLE: optimize XBZRLE to
> decrease the cache misses
>
> I've got a world with just patches 1..5 on that's seeing corruptions, but
> I've not seen where the problem is. So far the world with 1..4 on hasn't
> hit those corruption, but maybe I need to te
Hi, mst and alex.
Ping... These two bug fix can be accepted for KVM pci-assign ? Thanks.
BTW, I have finished the testing work of the Emulex Corporation
OneConnect NIC (Lancer) Nic by vfio-pci, and the pass-troughed VF works well.
My environment of testing as follows:
Host: 3.12.16-0.6.6-defa
Hi,
> > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > page memmory to zero, so the rest memory will be random value
> > (maybe etnry.data is not 0). In the assigned_dev_update_msix_mmio()
> > maybe occur the issue o
> On 04/03/14 07:18, arei.gong...@huawei.com wrote:
> > From: Gonglei
> >
> > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > page memmory to zero, so the rest memory will be random value
> > (maybe etnry.data is not
> On Wed, Apr 09, 2014 at 10:56:57AM +0000, Gonglei (Arei) wrote:
> > Hi,
> >
> > > > QEMU only mmap MSIX_PAGE_SIZE memory for all pci devices in
> > > > assigned_dev_register_msix_mmio(), meanwhile the set the one
> > > > page memmo
Hi,
When qemu do live migration with xbzrle, qemu malloc decoded_buf
at destniation end but free it at source end.It will crash qemu
by double free error in some scenarios.
Signed-off-by: chenliang
---
arch_init.c |9 -
include/migration/migration.h |1 +
migra
Hi,
> Just a small addition: The AltGr Keys are not routed correctly through VNC!
> I had a look at the "de" keymap, it looks as if they are described (e.g.
> backslash \) which is placed on the german keyboard on the key right to the
> 0 key (german key ssharp) and accessed via AltGr + this key.
Ping?
> -Original Message-
> From: Gonglei (Arei)
> Sent: Friday, January 10, 2014 4:59 PM
> To: qemu-devel@nongnu.org
> Cc: Luonengjun; Huangweidong (Hardware); chenliang (T)
> Subject: [PATCH] migration: Fix free XBZRLE decoded_buf wrong
>
> Hi,
>
> Wh
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Saturday, January 18, 2014 11:00 PM
> To: Gonglei (Arei)
> Cc: quint...@redhat.com; anth...@codemonkey.ws; pbonz...@redhat.com;
> chenliang (T); qemu-sta...@nongnu.org; Luonengjun;
>
Hi,
This is an update of my patch.
Modifications in v2:
* Removing excess check for g_free
* The structure of XBZRLE is divided into two halves.One is for
* src side, another is for dest side.
Signed-off-by: chenliang
---
arch_init.c | 23 ++-
include/mig
> -Original Message-
> From: Orit Wasserman [mailto:owass...@redhat.com]
> Sent: Tuesday, January 21, 2014 8:24 PM
> To: Gonglei (Arei); qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Peter
> Maydell; anth...@codemonkey.ws; pbonz...@redhat.com
> Cc: chenliang (T); Luonen
Hi all,
we use the command "virsh edit" to modify the VM configuration information
online on KVM Platform(libvirt-1.0.0 and qemu-1.4),
but it does not take effect after reboot. However, it works fine on Xen
Platform.
for an example,a VM is running with the following configuration infor
In the case of physical hard disk's speed which processing IO (when grouping
RAID) is very slow, I encountered a problem.
I dd big file in SUSE virtual machine, the command is
linux:/ # dd if=/dev/zero of=./info bs=1M count=5000;sync
but finally I get those message:
linux:~ # dmesg
[ 174.804114]
Hi, Andreas
> -Original Message-
> From: Andreas Färber [mailto:afaer...@suse.de]
> Sent: Tuesday, May 21, 2013 7:50 PM
> To: Gonglei (Arei)
> Cc: kw...@redhat.com; qemu-devel@nongnu.org; Wangzhenguo; Luonengjun;
> Huangweidong (Hardware); Bo Yang
> Subject: Re:
Hi, all
I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, I get
the below logs:
[2013-05-22 23:25:46] ide: CMD=c8
[2013-05-22 23:25:46] bmdma: readb 0x00 : 0x08
[2013-05-22 23:25:46] bmdma: writeb 0x00 : 0x09
[2013-05-22 23:25:46] bmdma_cmd_writeb: 0x0009
[2013-05-22 23
Hi,
>
> On Thu, 23 May 2013, Gonglei (Arei) wrote:
> > Hi, all
> >
> > I use O_DIRECT to open disk images for IDE, but I'm failed. After debug, I
> > get
> the below logs:
> > [2013-05-22 23:25:46] ide: CMD=c8
> > [2013-05-22 23:25:46] bmdma:
Best regards,
-Gonglei
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Dr. David Alan Gilbert (git)
> Sent: Friday, February 14, 2014 3:45 AM
> To: qemu-devel@nongnu.org
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Friday, February 14, 2014 5:35 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; owass...@redhat.com; quint...@redhat.com
> Subject: Re: [Qemu-devel] [PATCH] Fix two XBZRLE
It is likely to crash qemu when resize the xbzrle cache
during migration. Because the xbzrle cache will be modified
by migration thread and resize thread.
Test scene
step one: set the size of xbzrle cache 1GB.
step two: migrate vm which dirty memory continuously.
step three: set the size of xbzrle
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Wednesday, February 19, 2014 6:54 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Peter Maydell; chenliang (T); Juan Quintela;
> Luonengjun; owass...@redhat.com; Huangweidong (H
Resizing the xbzrle cache during migration causes qemu-crash,
because the main-thread and migration-thread modify the xbzrle
cache size concurrently without lock-protection.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
Changes against the previous version:
*Remove function cache_max_num_
Hi,
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Friday, February 21, 2014 7:04 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Juan Quintela; owass...@redhat.com;
> chenliang (T)
> Subject: Re: [PATCH v2] XBZRLE: Fix q
> -Original Message-
> From: Dr. David Alan Gilbert [mailto:dgilb...@redhat.com]
> Sent: Friday, February 21, 2014 8:10 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Juan Quintela; owass...@redhat.com;
> chenliang (T)
> Subject: Re: [PATCH v2] XBZRLE: Fix qemu
Resizing the xbzrle cache during migration causes qemu-crash,
because the main-thread and migration-thread modify the xbzrle
cache size concurrently without lock-protection.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
Reviewed-by: Dr. David Alan Gilbert
---
Changes against the previous vers
Hi, Juan. Thanks for your review.
> -Original Message-
> From: Juan Quintela [mailto:quint...@redhat.com]
> Sent: Tuesday, February 25, 2014 11:25 PM
> To: Gonglei (Arei)
> Cc: qemu-devel@nongnu.org; Dr. David Alan Gilbert; owass...@redhat.com;
> chenliang (T); Huangwei
Add counters to log the times of updating the dirty bitmap.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 20
1 file changed, 20 insertions(+)
diff --git a/arch_init.c b/arch_init.c
index bc8d0eb..6823c5a 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -1
The page may not be inserted into cache after executing save_xbzrle_page.
In case of failure to insert, the original page should be sent rather
than the page in the cache.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 25 +
1 file changed, 13 insertio
Avoid the hot pages cache replacing by others to remarkable decrease cache
missing. The counter of updating dirty bitmap is used to indicate the cached
page age.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c| 8 +---
include/migration/page_cache.h | 8
It is inaccuracy and complex that using the transfer speed of
migration thread to determine whether the convergence migration.
The dirty page may be compressed by XBZRLE or ZERO_PAGE.The counter
of updating dirty bitmap will be increasing continuously if the
migration can't convergence.
Signed-off
Rebuild the cache_is_cached function.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
page_cache.c | 33 +++--
1 file changed, 15 insertions(+), 18 deletions(-)
diff --git a/page_cache.c b/page_cache.c
index fa58ab2..34ec933 100644
--- a/page_cache.c
+++ b/page_
delete death code.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index cc88875..12fbcea 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -178,13 +178,10 @@ static inline bool is_zero_range
Reducing data copy can reduce cpu overheah.
Signed-off-by: ChenLiang
Signed-off-by: Gonglei
---
arch_init.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 2211e0b..cc88875 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -344,11 +344,8 @
a. Optimization the xbzrle remarkable decrease the cache misses.
The efficiency of compress increases more than fifty times.
Before the patch set, the cache almost totally miss when the
number of cache item less than the dirty page number. Now the
hot pages in the cache will not be
> -Original Message-
> From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org
> [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On
> Behalf Of Jason Wang
> Sent: Friday, February 21, 2014 5:05 PM
> To: aligu...@amazon.com; m...@redhat.com; qemu-devel@nongnu.org
> Cc: Pao
Hi,
Recently I found that when doing migration on a VM with many Virtio NICs,
a lot down time was consuming in vm_state_notify(). Further investigation
shows major consumption is in function memory_region_del_eventfd(). When
deletes an
ioeventfd, in address space transactions commit, it begin
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, January 21, 2014 9:46 PM
> To: Gonglei (Arei); qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Peter
> Maydell; anth...@codemonkey.ws; pbonz...@redhat.com
> Cc: chenliang (T); Luonen
When qemu do live migration with xbzrle, qemu malloc decoded_buf
at destination end but free it at source end. It will crash qemu
by double free error in some scenarios. Splitting the XBZRLE structure
for clear logic distinguishing src/dst side.
Signed-off-by: ChenLiang
Reviewed-by: Peter Maydell
Hi,
When I use RealVNC viewer client (http://www.realvnc.com/) to connect vnc
server,
the client disconnect suddenly, and I click reconnect button immediately, then
the Qemu crashed.
In the function vnc_worker_thread_loop, will call vnc_async_encoding_start
to set the local vs->output buffer b
ginal Message-
> From: Gonglei (Arei)
> Sent: Tuesday, January 14, 2014 4:45 PM
> To: 'erik.r...@rdsoftware.de'; 'Anthony Liguori'; 'Gerd Hoffmann'
> Cc: Luonengjun; Huangweidong (Hardware); qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] Keysymbol interpretat
Hi,
I find a critical problem about pci devices migration
when we configure a pci device not assign the devfn. Qemu will
auto assign the devfn in function do_pci_register_device.
At the migration src end, When we hotplug two pci devices, such as virtio-net.
Qemu will assign devfn 4 (assumed th
Ping...
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, January 23, 2014 9:31 PM
> To: qemu-devel@nongnu.org
> Cc: 'aligu...@amazon.com'; Luonengjun; Huangweidong (Hardware); 'Gerd
> Hoffmann'
> Subjec
Ping...
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, January 23, 2014 3:47 PM
> To: qemu-devel@nongnu.org
> Cc: 'Orit Wasserman'; qemu-devel@nongnu.org; Peter Maydell;
> anth...@codemonkey.ws; pbonz...@redhat.c
Hi
From 3e8c08565cc546b79d720b92e4a46470a57086bc Mon Sep 17 00:00:00 2001
From: Gonglei
Date: Tue, 11 Feb 2014 06:32:45 -0500
Subject: [PATCH] memory: fix warning during make
fix warning during make
include/exec/ram_addr.h:66: warning: implicit declaration of function bitmap_set
,.etc.
Signed-o
ping
Best regards,
-Gonglei
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, January 23, 2014 9:31 PM
> To: qemu-devel@nongnu.org
> Cc: 'aligu...@amazon.com'; Luonengjun; Huangweidong (Hardware); 'Gerd
> Hoffmann'
> Subject: [PAT
Hi,
I'm using qemu-ga.exe in windows server 2008 R2 64.
I want to use it without libraries such as iconv.dll, libglib-2.0-0.dll,
libintl-8.dll and libssp-0.dll
So I use static compilation on fedora 18.
build qemu-1.7.0:
# for Windows using MinGW on linux (Fedora 18)
./configure --enable-gues
Hi, Gerd.
IMHO, the usb-ehci controller as a common PCI device, likes NIC.
If we don't use the multifunction capability of EHCI, we should support to hot
plug / unplug
Usb-ehci controller. And I think the Bug 879096 is just a bug. Am I right?
Thanks.
The patch:
http://lists.gnu.org/arch
Hi,
> -Original Message-
> From: Gonglei (Arei)
> Sent: Thursday, April 17, 2014 9:16 PM
> To: qemu-devel@nongnu.org
> Cc: kra...@redhat.com; aligu...@amazon.com; Huangweidong (C); Gonglei
> (Arei)
> Subject: [PATCH RFC] ps2: set the keybord output buffer size as
>
> > diff --git a/hw/input/ps2.c b/hw/input/ps2.c
> > index 3412079..a754fef 100644
> > --- a/hw/input/ps2.c
> > +++ b/hw/input/ps2.c
> > @@ -71,7 +71,7 @@
> > #define MOUSE_STATUS_ENABLED0x20
> > #define MOUSE_STATUS_SCALE210x10
> >
> > -#define PS2_QUEUE_SIZE 256
> > +#define PS2_QUEU
nglei
> -Original Message-
> From: Juan Quintela [mailto:quint...@redhat.com]
> Sent: Tuesday, April 22, 2014 8:05 PM
> To: Gerd Hoffmann
> Cc: Gonglei (Arei); qemu-devel@nongnu.org; aligu...@amazon.com;
> Huangweidong (C)
> Subject: Re: [PATCH RFC] ps2: set the keybord output buf
>
> Hi, Gerd and Juan.
>
> Thanks for your guides about the confuse live migration about changing the
> keyboard buffer size.
> According your suggestion, I got two solutions to address the issue:
>
> - Keep the data array 256 bytes long, change the rptr/wptr/count/data array at
> post_load(),
> On Mi, 2014-04-23 at 08:06 +0000, Gonglei (Arei) wrote:
> > Hi, Gerd and Juan.
> >
> > Thanks for your guides about the confuse live migration about changing the
> keyboard buffer size.
> > According your suggestion, I got two solutions to address the issue:
>
> Gerd Hoffmann wrote:
> > On Mi, 2014-04-23 at 09:32 +, Gonglei (Arei) wrote:
> >> >
> >> > Hi, Gerd and Juan.
> >> >
> >> > Thanks for your guides about the confuse live migration about changing
> the
> >> > keyboa
> Hi,
>
> > Anything bigger than 16bytes, no? And that is the whole point that we
> > are talking about? Or the 16bytes that we are using can be at any place
> > on the buffer?
>
> Yes. It's a ring buffer, with rptr pointing to the first used element
> and wptr pointing to the first free ele
>
> "Gonglei (Arei)" wrote:
> >> Hi,
> >>
> >> > Anything bigger than 16bytes, no? And that is the whole point that we
> >> > are talking about? Or the 16bytes that we are using can be at any place
> >> > on the buffer?
&g
301 - 400 of 954 matches
Mail list logo
