Hi, > Subject: Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more > idiomatic writing style > > On Thu, Jul 31, 2014 at 10:39 PM, Peter Maydell > <peter.mayd...@linaro.org> wrote: > > On 31 July 2014 13:28, <arei.gong...@huawei.com> wrote: > >> From: Gonglei <arei.gong...@huawei.com> > >> > >> Gonglei (7): > >> usb: a trivial code change for more idiomatic writing style > >> audio: a trivial code change for more idiomatic writing style > >> isa-bus: a trivial code change for more idiomatic writing style > >> a trivial code change for more idiomatic writing style > >> spice: a trivial code change for more idiomatic writing style > >> vl: a trivial code change for more idiomatic writing style > >> vmxnet3: a trivial code change for more idiomatic writing style > > > > Hi. I think we could make the commit messages here > > a bit more specific: > > === > > $WHATEVER: don't use 'Yoda conditions' > > > > 'Yoda conditions' are not part of idiomatic QEMU coding > > style, so rewrite them in the more usual order. > > Should this series include a patch to CODING_STYLE? > Yes, good idea IMHO!
Best regards, -Gonglei
