Re: [Qemu-devel] How to use qtest

2014-05-14 Thread Gonglei (Arei)
> -Original Message- > From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Wednesday, May 14, 2014 3:34 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Andreas Färber > Subject: Re: [Qemu-devel] How to use qtest > > "Gonglei (Arei)" writes:

Re: [Qemu-devel] How to use qtest

2014-05-14 Thread Gonglei (Arei)
Hi, Andreas > -Original Message- > From: Andreas Färber [mailto:afaer...@suse.de] > Sent: Wednesday, May 14, 2014 5:06 PM > To: Gonglei (Arei) > Cc: Markus Armbruster; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] How to use qtest > > Hi, > > Am 14.

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-14 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Wednesday, May 14, 2014 6:26 PM > To: Gonglei (Arei); Gerd Hoffmann > Cc: qemu-devel@nongnu.org; Huangweidong (C); Michael S. Tsirkin > Subject: Re: usb: usb tablet freeze when sav

Re: [Qemu-devel] [PATCH] rdma: Fix block during rdma migration

2014-05-14 Thread Gonglei (Arei)
> -Original Message- > From: Michael R. Hines [mailto:mrhi...@linux.vnet.ibm.com] > Sent: Thursday, May 15, 2014 8:44 AM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); quint...@redhat.com; dgilb...@redhat.com; > owass...@redhat.com; mrhi...

Re: [Qemu-devel] usb: usb tablet freeze when save/restore guest os

2014-05-15 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 15, 2014 2:50 PM > To: Gonglei (Arei) > Cc: Paolo Bonzini; qemu-devel@nongnu.org; Huangweidong (C); Michael S. > Tsirkin > Subject: Re: usb: usb tablet freeze when save/resto

Re: [Qemu-devel] [PATCH] migration: static variables will not be reset at second migration

2014-05-15 Thread Gonglei (Arei)
Hi, Juan Ping... Maybe you forgot to pull this patch, right? Thanks. Best regards, -Gonglei > -Original Message- > From: Juan Quintela [mailto:quint...@redhat.com] > Sent: Friday, March 21, 2014 9:26 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; owass...@re

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-17 Thread Gonglei (Arei)
Hi, From qemu-1.7 release version, the old usb-host(host-linux.c) had been removed, re-implemented by libusbx. So you should build qemu with --enable-libusb, then you can use usb pass-through capacity. BTW, Gerd, should we enable libusb by default now? Thanks. Best regards, -Gonglei > -O

Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working anymore

2014-05-18 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Martin Röh [mailto:mar...@roeh.org] > Sent: Monday, May 19, 2014 4:40 AM > To: Gonglei (Arei); Bug 1320360; qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: Re: [Qemu-devel] [Bug 1320360] [NEW] usb passthrough not working > anymo

[Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gonglei (Arei)
Hi, Gerd The issues has been reported a few months ago. The previous mail: https://lists.gnu.org/archive/html/qemu-devel/2014-01/msg01600.html Any ideas? Thanks! Best regards, -Gonglei

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, May 21, 2014 8:25 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC] How to deal with the conflict between DE keymap and qemu > console ? > > On Mi

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, May 21, 2014 6:53 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann > Subject: [Qemu-devel] [P

Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Gerd Hoffmann > Sent: Wednesday, May 21, 2014 6:54 PM > To: qemu-devel@nongnu.org > Cc: Gerd Hoffmann; Anthony Liguori > Subject

Re: [Qemu-devel] [RFC] How to deal with the conflict between DE keymap and qemu console ?

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 2:00 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [RFC] How to deal with the conflict between DE keymap and qemu > console ? > > Hi, &g

Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking

2014-05-21 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, May 22, 2014 1:44 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] inet_listen_opts: add error checking > > > > /* lookup

Re: [Qemu-devel] [v2][PATCH 4/8] xen, gfx passthrough: reserve 00:02.0 for INTEL IGD

2014-05-22 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Chen, Tiejun > Sent: Thursday, May 22, 2014 6:50 PM > To: Gerd Hoffmann > Cc: peter.mayd...@linaro.org; xen-de...@lists.xensour

Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue

2014-08-29 Thread Gonglei (Arei)
> -Original Message- > From: qemu-devel-bounces+arei.gonglei=huawei@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei@nongnu.org] On > Behalf Of Michael Tokarev > Sent: Saturday, August 30, 2014 1:26 PM > To: Liuli (I) > Cc: qemu-triv...@nongnu.org; qemu-devel@nongnu.org >

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-08-31 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Sunday, August 31, 2014 5:58 PM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > when we rem

Re: [Qemu-devel] [PATCH v2] ioh3420: Remove unused ioh3420_init() declaration

2014-08-31 Thread Gonglei (Arei)
Hi, Michael Do you plan to pick up this patch? Thanks. Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, August 25, 2014 8:21 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); knut.om...@oracle.com; > arm...@r

Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-31 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Tuesday, August 26, 2014 10:25 AM > Subject: Re: [Qemu-devel] [PATCH v2 2/3] qdev: add cleanup logic in > device_set_realized() to avoid resource leak > > On Thu, Aug 21, 2014

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-08-31 Thread Gonglei (Arei)
> -Original Message- > From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Monday, September 01, 2014 2:08 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org Developers; Huangweidong (C);

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-08-31 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, September 01, 2014 2:43 PM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > Importance: High > > Hi, > > > +static bool is_same_fw_dev_path(DeviceState *src, DeviceState *dst) > > +{ > > +bool ret

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-01 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Tuesday, September 02, 2014 6:51 AM > >> On Mon, Sep 1, 2014 at 3:50 PM, wrote: > >> > From: Gonglei > >> > > >> > At present, this function doesn't have partial cleanup impl

Re: [Qemu-devel] [PATCH v3 2/3] qdev: add cleanup logic in device_set_realized() to avoid resource leak

2014-09-02 Thread Gonglei (Arei)
> -Original Message- > From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Tuesday, September 02, 2014 3:00 PM > To: Gonglei (Arei) > Cc: Huangweidong (C); Michael S. Tsirkin; Luonengjun; >

Re: [Qemu-devel] [PATCH v4 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread Gonglei (Arei)
> From: Gonglei (Arei) > Sent: Tuesday, September 02, 2014 4:04 PM > Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err > Importance: High > > From: Gonglei > > This error can not happen normally. If it happens indicates > something very

Re: [Qemu-devel] [PATCH v4 1/4] qdev: using error_abort instead of using local_err

2014-09-02 Thread Gonglei (Arei)
> > > Subject: [PATCH v4 1/4] qdev: using error_abort instead of using local_err > > > Importance: High > > > > > > From: Gonglei > > > > > > This error can not happen normally. If it happens indicates > > > something very wrong, we should abort QEMU. moreover, The > > > user can only refer to /

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Gonglei (Arei)
> > > > Forcefully unrealize all children regardless of early-iteration > > errors(if happened). We should keep going with cleanup operation > > rather than report a error immediately. > > > > Signed-off-by: Gonglei > > --- > > hw/core/qdev.c | 9 +++-- > > 1 file changed, 3 insertions(+), 6

Re: [Qemu-devel] [PATCH v4 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-02 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > >> > > >> > Forcefully unrealize all children regardless of early-iteration > >> > errors(if happened). We should keep going with cleanup operation > >> > rather than report a error immediately. > >> > > >> > Signed-off-by: Gonglei > >> > --- > >> > hw/co

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Wednesday, September 03, 2014 2:00 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > Importance: High > > On Mon, Sep 01, 2014 at 06:47:13AM +0000, Gonglei (Arei) wrote: > &g

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
function > > Importance: High > > > > On Mon, Sep 01, 2014 at 06:47:13AM +, Gonglei (Arei) wrote: > > > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > > > Sent: Monday, September 01, 2014 2:43 PM > > > > Subject: Re: [PATCH

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-02 Thread Gonglei (Arei)
Best regards, -Gonglei > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Wednesday, September 03, 2014 2:25 PM > To: Gonglei (Arei) > Cc: Eduardo Habkost; qemu-devel@nongnu.org; aligu...@amazon.com; > m...@redhat.com; pbonz...@redhat.com

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Saturday, August 30, 2014 6:00 PM > Subject: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > From: Gonglei > > when we remove bootindex form qdev.property to qom.p

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-03 Thread Gonglei (Arei)
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Hi, > > > +void set_bootindex(int32_t *bootindex, Visitor *v, > > > + const char *name, Error **errp) > > > +{ > > > +int32_t boot_index; > > > +Error *local_err = NULL; > > > + > > > +visit_type_int32(v, &boot_i

Re: [Qemu-devel] [PATCH v5 4/4] pcie: don't assert when hotplug a PCIe device with 'function != 0'

2014-09-03 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Wednesday, September 03, 2014 9:48 PM > Subject: Re: [PATCH v5 4/4] pcie: don't assert when hotplug a PCIe device with > 'function != 0' > > On Tue, Sep 02, 2014 at 08:03:08PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > >

Re: [Qemu-devel] [PATCH v5 2/4] qdev: using NULL instead of local_err for qbus_child unrealize

2014-09-03 Thread Gonglei (Arei)
> From: peter.crosthwa...@petalogix.com > [mailto:peter.crosthwa...@petalogix.com] On Behalf Of Peter Crosthwaite > Sent: Wednesday, September 03, 2014 9:09 PM g NULL instead of local_err > for qbus_child unrealize > > On Tue, Sep 2, 2014 at 10:03 PM, wrote: > > From: Gonglei > > > > Forcefully

Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of using local_err

2014-09-03 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] [PATCH v5 1/4] qdev: using error_abort instead of > using local_err > > Am 02.09.2014 14:03, schrieb arei.gong...@huawei.com: > > From: Gonglei > > > > This error can not happen normally. If it happens indicates > > something very wrong, we should abort QEMU. more

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Thursday, September 04, 2014 2:13 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Wed, Sep 03, 2014 at 06:45:56AM +, Gonglei (Arei) wrote: > [...] > > > > 4.

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-03 Thread Gonglei (Arei)
Hi, > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > > > On Wed, Sep 03, 2014 at 06:45:56AM +0000, Gonglei (Arei) wrote: > > [...] > > > > > 4. When we hotplug the virtio-net-pci device, only pass > >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> Subject: RE: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > Hi, > > > > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path > function > > > > > > On Wed, Sep 03, 2014 at 06:45:56AM +, Gonglei (Arei) wrote: >

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
Hi, > > I've confirmed that this is a bug, and have posted a patch fix it. > > Please review, thanks! > > [PATCH] virtio-pci: fix virtio-net child refcount in transports > > Best regards, > -Gonglei So, about Gerd's previous question: > When hot-unplugging virtio-net-pci I'd expect we free b

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-04 Thread Gonglei (Arei)
Ping... Michael? Thanks! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 01, 2014 9:29 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); pbonz...@redhat.com; > afaer...@suse.de; imamm...@redhat.c

Re: [Qemu-devel] [PATCH v6 06/27] bootindex: move setting bootindex on reset() instead of realize/init()

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 06/27] bootindex: move setting bootindex on reset() > instead of realize/init() > > On Sat, Aug 30, 2014 at 06:00:06PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Only in this way, we can assure the new bootindex take effect > > during vm rebooting. >

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Sat, Aug 30, 2014 at 06:00:07PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > when we remove bootindex form qdev.property to qom.property, > > we can use those functions set/get boo

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Thu, Sep 04, 2014 at 03:01:41AM +, Gonglei (Arei) wrote: > > Hi, > > > > > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > > Sent: Thursday, September 04, 2014 2:1

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 9:55 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 12:37:35AM +0000, Gonglei (Arei) wrote: > > > Subject

Re: [Qemu-devel] [PATCH v6 02/27] bootindex: add del_boot_device_path function

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:20 AM > Subject: Re: [PATCH v6 02/27] bootindex: add del_boot_device_path function > > On Fri, Sep 05, 2014 at 12:44:56AM +, Gonglei (Arei) wrote: > [...] > > > can we ha

Re: [Qemu-devel] [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex property

2014-09-04 Thread Gonglei (Arei)
> From: Eduardo Habkost [mailto:ehabk...@redhat.com] > Sent: Friday, September 05, 2014 10:22 AM > Subject: Re: [PATCH v6 07/27] vl.c: add setter/getter functions for bootindex > property > > On Fri, Sep 05, 2014 at 02:07:23AM +0000, Gonglei (Arei) wrote: > [...] > >

Re: [Qemu-devel] [PATCH] virtio-pci: fix virtio-net child refcount in transports

2014-09-05 Thread Gonglei (Arei)
Hi, CC'ing Stefan and qemu-stable@ for more attention. :) Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 04, 2014 7:42 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; Huangweidong (C); Gonglei (Arei) > Subj

Re: [Qemu-devel] [PATCH v7 18/28] host-libusb: remove bootindex property from qdev to qom

2014-09-05 Thread Gonglei (Arei)
Hi, > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, September 05, 2014 5:06 PM > Subject: Re: [PATCH v7 18/28] host-libusb: remove bootindex property from > qdev to qom > > > +static void usb_host_instance_init(Object *obj) > > +{ > > +USBDevice *udev = USB_DEVICE(obj); > > +

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > Subject: RE: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property > > > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom > property > > > > On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom pro

Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > > Subject: Re: [Qemu-devel] [PATCH v7 08/28] virtio-net: add bootindex to qom > > property > > > > On Fri, Sep 05, 2014 at 04:37:16PM +0800, arei.gong...@huawei.com wrote: > > > From: Gonglei > > > > > > Add a qom property with the same name 'bootindex', > > > when we remove it form qdev pr

Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom property

2014-09-09 Thread Gonglei (Arei)
Hi, > From: Eduardo Habkost [mailto:ehabk...@redhat.com] > > > > Subject: Re: [Qemu-devel] [PATCH v7 24/28] ide: add bootindex to qom > > > property > > > > > > > > On Fri, Sep 05, 2014 at 04:37:32PM +0800, arei.gong...@huawei.com > wrote: > > > > > From: Gonglei > > > > > > > > > > Add a qom pro

Re: [Qemu-devel] [PATCH v3 0/3] add check for PCIe root ports and downstream ports

2014-09-09 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Thursday, September 04, 2014 8:10 PM > Subject: RE: [PATCH v3 0/3] add check for PCIe root ports and downstream > ports > > Ping... Michael? Thanks! > Ping... again. Thanks! > > Best regards, >

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-10 Thread Gonglei (Arei)
> > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take > > effect after rebooting > > > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > shutdown > > it. We can call dynamic changing bootindex of a guest, which can be assured > > taki

Re: [Qemu-devel] [PATCH v9 05/30] bootindex: rework add_boot_device_path function

2014-09-11 Thread Gonglei (Arei)
Hi, > Subject: Re: [PATCH v9 05/30] bootindex: rework add_boot_device_path > function > > > +static void del_original_boot_device(DeviceState *dev, const char *suffix) > > Hmm, now we have two simliar delete functions. One which deletes all > entries belonging to a device, and one deleting only

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> > 主题: RE: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take > > effect after rebooting > > > > > > 主题: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > > > > take effect after rebooting > > > > > > > > From: Gonglei > > > > > > > > Sometimes, we want to modify b

Re: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery duringeoi broadcast

2014-09-11 Thread Gonglei (Arei)
> Subject: [Qemu-devel] [PATCH] kvm: ioapic: conditionally delay irq delivery > duringeoi broadcast > > Currently, we call ioapic_service() immediately when we find the irq is still > active during eoi broadcast. But for real hardware, there's some dealy between > the EOI writing and irq delivery

Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and take effect after rebooting

2014-09-11 Thread Gonglei (Arei)
> Subject: Re: [Qemu-devel] [PATCH v8 00/30] modify boot order of guest, and > take effect after rebooting > > Am 11.09.2014 um 07:58 schrieb Gonglei (Arei): > >>> ./qemu-system-x86_64 -enable-kvm -m 4096 -smp 4 -name redhat6.2 > -drive \ > >>> file=/ho

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
Hi, > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Benoît Canet writes: > > >> EOF > >> --- > >> If you have feedback or questions, let us know. The process can be > >> tweaked as time goes on so we can continue to improve. > > > > Great mail. > > Yup

Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 3:11 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Huangweidong (C); kra...@redhat.com > Subject: Re: [Qemu-devel] [PATCH 0/2] usb: Don't use qerror_report > > wr

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:14 PM > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged > > Am 12.09.2014 um 09:02 hat Gonglei (Arei) geschrieben: > > Hi, > > > > > Subjec

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:35 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); kra...@redhat.com; arm...@redhat.com > Subject: Re: [PATCH v2 0/2] usb: Don't us

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Kevin Wolf [mailto:kw...@redhat.com] > Sent: Friday, September 12, 2014 4:46 PM > To: Gonglei (Arei) > Cc: Markus Armbruster; Benoît Canet; qemu-devel@nongnu.org; Stefan > Hajnoczi > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged >

Re: [Qemu-devel] New requirement for getting block layer patches merged

2014-09-12 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Friday, September 12, 2014 5:02 PM > To: Gonglei (Arei) > Cc: Kevin Wolf; Benoît Canet; Stefan Hajnoczi; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] New requirement for getting block layer patches > merged &

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-12 Thread Gonglei (Arei)
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Friday, September 12, 2014 4:59 PM > Subject: Re: [PATCH v2 0/2] usb: Don't use qerror_report > > Il 12/09/2014 10:50, Gonglei (Arei) ha scritto: > >> > Any chance

Re: [Qemu-devel] [PATCH v10 00/30] modify boot order of guest, and take effect after rebooting

2014-09-12 Thread Gonglei (Arei)
> Subject: Re: [PATCH v10 00/30] modify boot order of guest, and take effect > after rebooting > > On Fr, 2014-09-12 at 17:35 +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Sometimes, we want to modify boot order of a guest, but no need to > > shutdown it. We can call dynamic cha

Re: [Qemu-devel] [PATCH v2 0/9] virtio: fix virtio child recount in transports

2014-09-12 Thread Gonglei (Arei)
Ping... Any comments will be appreciated! Best regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Tuesday, September 09, 2014 2:35 PM > To: qemu-devel@nongnu.org > Cc: m...@redhat.com; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> On Tue, Sep 09, 2014 at 02:35:02PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the > > qdev properties of their VirtIONet child. This approach does not work > > well with string or pointer properties since we m

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-14 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 1:36 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 01:03:24AM +0000, Gonglei (Arei) wrote: > > > >

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 2:41 PM > Subject: Re: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev > properties > > On Mon, Sep 15, 2014 at 05:49:42AM +0000, Gonglei (Arei) wrote: > > > From: M

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > I applied your patch, and looked at the property types. > > > > > Could you tell me your method looked at properties type? > > You can use an HMP command, or you can use > -device virtio-net-pci,? OK. Good method. > changes m

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Monday, September 15, 2014 5:06 PM > To: 'Michael S. Tsirkin' > Cc: qemu-devel@nongnu.org; pbonz...@redhat.com; stefa...@redhat.com; > Huangweidong (C); ag...@suse.de; Huangpeng (Peter); r...@twiddle.net

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> > Subject: RE: [PATCH v2 1/9] virtio-net: use aliases instead of duplicate > > qdev > > properties > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > Could you tell me your method lo

Re: [Qemu-devel] [PATCH v2 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Monday, September 15, 2014 5:59 PM > > > > > > > > > > > > > > > > > > > > Sorry, I don't understand your meaning. :( > > > > > > > > > > > > > > I applied your patch, and looked at the property types. > > > > > > > > > > > > > Could you t

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-15 Thread Gonglei (Arei)
> From: Michael S. Tsirkin [mailto:m...@redhat.com] > Subject: Re: [PATCH 0/3] Fix confused output for alias properties > > On Mon, Sep 15, 2014 at 10:44:36PM +0800, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > At present, people have no way to know they should > > have a specific for

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 3:28 PM > Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on > qdev_device_help() > > writes: > > > From: Gonglei > > > > Normally, qmp_device_list_properties() may return NULL when >

Re: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable

2014-09-16 Thread Gonglei (Arei)
Hi, > Subject: [Qemu-devel] [PATCH 0/5] usb: make host adapters hot-pluggable > > Hi, > > This series the usb host adapters hot-pluggable. Problem is that we > can NOT hotplug host adapters which are part of a companion setup. The > way this is tackled now is to split the usb host adapter va

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 3:21 PM > To: Michael S. Tsirkin > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > "Michael S. Tsirkin" writes: > > > On Mon, Sep 15, 2014 at 05:57:51PM +0200, Paolo Bonzin

Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on qdev_device_help()

2014-09-16 Thread Gonglei (Arei)
> From: Markus Armbruster [mailto:arm...@redhat.com] > Sent: Tuesday, September 16, 2014 4:00 PM > To: Gonglei (Arei) > Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: fix segmentation fault on > qdev_device_help() > > "Gonglei (Arei)" writes: > > &

Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties

2014-09-16 Thread Gonglei (Arei)
Hi, > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Tuesday, September 16, 2014 6:46 PM > Subject: Re: [Qemu-devel] [PATCH 0/3] Fix confused output for alias properties > > Il 16/09/2014 12:37, Michael S. Tsirkin ha scritto: > > str really should be for free-form strings. > > It makes

Re: [Qemu-devel] [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias property in ObjectProperty

2014-09-16 Thread Gonglei (Arei)
> From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Tuesday, September 16, 2014 8:23 PM > Subject: Re: [PATCH v2 2/3] qom: add AliasProperty struct poniter for alias > property in ObjectProperty > > On 09/15/2014 11:51 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > s/poniter/poin

Re: [Qemu-devel] [PATCH v2 0/2] usb: Don't use qerror_report

2014-09-16 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Friday, September 12, 2014 3:31 PM > To: qemu-devel@nongnu.org > Cc: kra...@redhat.com; Huangweidong (C); arm...@redhat.com; Gonglei > (Arei) > Subject: [PATCH v2 0/2] usb: Don't use qerror_report > > F

Re: [Qemu-devel] [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os

2014-07-17 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Paolo Bonzini [mailto:pbonz...@redhat.com] > Sent: Thursday, July 17, 2014 9:45 PM > To: Gonglei (Arei); qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun > Subject: Re: [PATCH for-2.1] scsi: fix scsi disk symbol confusion in gues

Re: [Qemu-devel] [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os

2014-07-17 Thread Gonglei (Arei)
> -Original Message- > From: Gonglei (Arei) > Sent: Friday, July 18, 2014 9:32 AM > To: 'Paolo Bonzini'; qemu-devel@nongnu.org > Cc: Huangweidong (C); Luonengjun > Subject: RE: [PATCH for-2.1] scsi: fix scsi disk symbol confusion in guest os > >

Re: [Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread Gonglei (Arei)
Hi, Gerd > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, July 24, 2014 6:09 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; afaer...@suse.de; ag...@suse.de; > stefa...@redhat.com; ak...@redhat.com; a...@ozlabs.ru; > alex.

Re: [Qemu-devel] [PATCH 1/6] bootindex: add {del, modify}_boot_device_path function

2014-07-24 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, July 24, 2014 9:25 PM > Subject: Re: [PATCH 1/6] bootindex: add {del,modify}_boot_device_path > function > > Hi, > > > > Hmm. I think we should simply lookup the device and modify the > > > bootinde

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-25 Thread Gonglei (Arei)
Hi, Gerd > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, July 25, 2014 5:52 PM > Subject: Re: [PATCH v2 4/7] bootindex: delete bootindex when device is > removed > > Hi, > > > +del_boot_device_path(dev); > > You can call this from device_finali

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-25 Thread Gonglei (Arei)
Hi, Gerd > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, July 25, 2014 5:46 PM > > Hi, > > > +void modify_boot_device_path(int32_t bootindex, DeviceState *dev, > > + const char *suffix) > > +{ > > +FWBootEntry *node, *i

Re: [Qemu-devel] [PATCH v3 1/7] bootindex: add modify_boot_device_path function

2014-07-27 Thread Gonglei (Arei)
> -Original Message- > From: 陈梁 [mailto:chenliang0...@icloud.com] > Sent: Sunday, July 27, 2014 11:51 AM > Subject: Re: [Qemu-devel] [PATCH v3 1/7] bootindex: add > modify_boot_device_path function > > Hi > > +if (bootindex >= 0) { > > +node = g_malloc0(sizeof(FWBootEntry)); >

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-27 Thread Gonglei (Arei)
Hi, Should be easy to fix though. Does the following help? (Cc'ing Stefan & Kevin) --> xen_disk: fix possible null-ptr dereference Signed-off-by: Gonglei --- hw/block/xen_disk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index aed5b5b..a221d0b

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, July 28, 2014 4:31 PM > Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function > > Hi, > > > > ... because you can just copy the suffix from the old entry here, > > > instead of ex

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, July 28, 2014 5:28 PM > Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function > > > > I think it is ok to allow only *changing* the bootindex. > > > > > Yes, that's no problem.

Re: [Qemu-devel] Possible null-ptr dereference

2014-07-28 Thread Gonglei (Arei)
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Monday, July 28, 2014 5:49 PM > To: Gonglei (Arei) > Cc: mateusz.krzywi...@windowslive.com; qemu-devel@nongnu.org; > kw...@redhat.com > Subject: Re: [Qemu-devel] Possible null-ptr derefer

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Monday, July 28, 2014 6:02 PM > Subject: Re: [PATCH v2 1/7] bootindex: add modify_boot_device_path function > > Hi, > > > > > > I think it is ok to allow only *changing* the bootindex. > > > > > > > > > Yes, t

Re: [Qemu-devel] [PATCH v2 7/7] spapr: fix possible memory leak

2014-07-28 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Monday, July 28, 2014 6:45 PM > Subject: Re: [PATCH v2 7/7] spapr: fix possible memory leak > > > On 25.07.14 08:52, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > get_boot_devices_list() will mallo

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-28 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gonglei (Arei) > Sent: Monday, July 28, 2014 6:16 PM > Subject: RE: [PATCH v2 1/7] bootindex: add modify_boot_device_path function > > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Se

Re: [Qemu-devel] [PATCH v2 1/7] bootindex: add modify_boot_device_path function

2014-07-29 Thread Gonglei (Arei)
Hi, Gerd > > > > > > > I think it is ok to allow only *changing* the bootindex. > > > > > > > > > > > > > Yes, that's no problem. > > > > > > > > > > But then yoy always will have a old entry where you can take the > > > > > suffix > > > > > from, and you don't need the suffix as parameter for t

Re: [Qemu-devel] [PATCH v2 4/7] bootindex: delete bootindex when device is removed

2014-07-30 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Friday, July 25, 2014 5:52 PM > > > +del_boot_device_path(dev); > > You can call this from device_finalize() instead of placing it into each > individual device. > Maybe put this call in device_finaliz

Re: [Qemu-devel] [PATCH v3 5/7] qmp: add set-bootindex command

2014-07-30 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Eric Blake [mailto:ebl...@redhat.com] > Sent: Thursday, July 31, 2014 6:37 AM > Subject: Re: [PATCH v3 5/7] qmp: add set-bootindex command > > On 07/25/2014 10:45 PM, arei.gong...@huawei.com wrote: > > From: Gonglei > > > > Adds "set-bootindex id=xx,booti

Re: [Qemu-devel] [PATCH v3 2/7] bootindex: add del_boot_device_path function

2014-07-30 Thread Gonglei (Arei)
Hi, > > Introduce a del_boot_device_path() cleanup fw_cfg content > > when hot-unplugging devcie refer to bootindex. > > s/devcie/device/ > > sounds odd; maybe: > > Introduce del_boot_device_path() to clean up fw_cfg content when > hot-unplugging a device that refers to a bootindex. > OK. Than

Re: [Qemu-devel] [PATCH for-2.2 0/7] a trivial code change for more idiomatic writing style

2014-07-31 Thread Gonglei (Arei)
Hi, PMM > -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, July 31, 2014 8:40 PM > Subject: Re: [PATCH for-2.2 0/7] a trivial code change for more idiomatic > writing > style > > On 31 July 2014 13:28, wrote: > > From: Gonglei > > > > Gongle

<    1   2   3   4   5   6   7   8   9   10   >