> -----Original Message----- > From: qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org > [mailto:qemu-devel-bounces+arei.gonglei=huawei....@nongnu.org] On > Behalf Of Michael Tokarev > Sent: Saturday, August 30, 2014 1:26 PM > To: Liuli (I) > Cc: qemu-triv...@nongnu.org; qemu-devel@nongnu.org > Subject: Re: [Qemu-devel] [PATCH] numa: fix qerror_report_err not free issue > > 30.08.2014 07:36, john.liuli wrote: > > From: Li Liu <john.li...@huawei.com> > > > > All qerror_report_err returned none NULL pointers need to > > be freed, otherwise will cause memory leaking. > > > > Although this place did not cause real memory leaking by exit, > > obviously it's not correct to use qerror_report_err > > without error_free it. > > I don't thing there's any good reason to free resources like > this (freeing memory, closing files, etc) right before exit() > (esp. in error path). The OS will do that for us in one go > much faster. > Yes. Agreed.
Best regards, -Gonglei
