Hi, PMM > -----Original Message----- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, July 31, 2014 8:40 PM > Subject: Re: [PATCH for-2.2 0/7] a trivial code change for more idiomatic > writing > style > > On 31 July 2014 13:28, <arei.gong...@huawei.com> wrote: > > From: Gonglei <arei.gong...@huawei.com> > > > > Gonglei (7): > > usb: a trivial code change for more idiomatic writing style > > audio: a trivial code change for more idiomatic writing style > > isa-bus: a trivial code change for more idiomatic writing style > > a trivial code change for more idiomatic writing style > > spice: a trivial code change for more idiomatic writing style > > vl: a trivial code change for more idiomatic writing style > > vmxnet3: a trivial code change for more idiomatic writing style > > Hi. I think we could make the commit messages here > a bit more specific: > === > $WHATEVER: don't use 'Yoda conditions' > > 'Yoda conditions' are not part of idiomatic QEMU coding > style, so rewrite them in the more usual order. > === > > thanks > -- PMM
Hmm...Yes, Thanks! Actually I got the idea from Eric's reviewing comments for my bootindex patch serials. Best regards, -Gonglei
