password = "CHAP password"
> + initiator-name = "iqn.qemu.test:my-initiator"
> + # header digest is one of CRC32C|CRC32C-NONE|NONE-CRC32C|NONE
> + header-digest = "CRC32C"
> +@end example
Can you give an actual command line that uses -readconfig,
dation; either version 2 of the License, or
> -# (at your option) any later version.
especially since you were replacing a more permissive license in the .sh
version?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
lease, note that this only covers guest initiated ejects, that's,
> the QMP/HMP commands 'eject' and 'change' are not covered.
>
> Signed-off-by: Luiz Capitulino
Reviewed-by: Eric Blake
>
> +BLOCK_MEDIUM_EJECT
> +--
> +
> +Emitted w
icular POSIX extension to C, even if it is not portable in practice
to a pure C environment.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
s, the fd: notation of -incoming should be reusable in multiple
contexsts, including any other location where sensitive information must
be passed in.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
the filesystem/stable-storage
>
> Signed-off-by: Ronnie Sahlberg
> ---
> qemu-config.c | 15 +--
> qemu-options.hx |3 ++-
> 2 files changed, 15 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake
>
> diff --git a/qemu-config.c b/qemu-config.c
> in
iscsi]
> + user = "me"
> + password = "my password"
> + initiator-name = "iqn.qemu.test:my-initiator"
> + header-digest = "CRC32C"
> +EOF
> +
> +qemu-system-i386 -drive file=iscsi://127.0.0.1/iqn.qemu.test/1 \
> +-readconfig iscs
or
newer, or if qemu is 0.12 through 0.14 _and_ has hmp passthrough
backported]. In other words, if 'qemu -h' says -qmp-command is
available, and I could run the above as:
qemu-kvm -qmp-command '{"execute":"query-commands"}'
and have qemu automatically fill in
On 01/26/2012 02:41 AM, Paolo Bonzini wrote:
> On 01/26/2012 04:55 AM, Eric Blake wrote:
>>
>> $ /usr/libexec/qemu-kvm -qmp stdio -S -display none
>> qemu-kvm: -display: invalid option
>> $ /usr/libexec/qemu-kvm -qmp stdio -S -nographic
>> chardev: opening backend
he handshake,
then libvirt can never reliably know what version the agent is running at.
I think we really do need a mode where as soon as the qemu-ga process
exists, it sends an event, then the qemu side of the virtio bus responds
to that event by telling the agent what version of qemu is talking to
er instances where you use a comma to separate arguments and also
want to accept commas in arbitrary file names, qemu has used the notion
of a double comma as being the escape sequence for a single comma in the
intended file name, rather than a separator for later arguments.
--
Eric Blake ebl...
itself
does something different based on what it stored into the disk images
before shutting down).
Also, I know there has been talk about a qemu-ga command to resync
clocks after a resume from S3 and/or 'loadvm'; is this command fully in
place yet, and is it another command that libvirt
nce
libvirt to have a dump-to-stream command, and reuse the existing libvirt
ability to stream large amounts of data on side channels, in order to
let management apps directly and atomically query a subset of memory
into a file with the desired formatting, rather than the current
approach of constr
ble to
reliably dump the state of memory of a guest at a given point of time,
all while continuing to let the original guest run past that point in time.
But whether this has to be done right away, or whether it even fits in
with your 'dump' command vs. needing a command of its own, I don&#x
flags (such as O_RDONLY becoming O_RDWR, or adding or subtracting
O_DIRECT), but where SELinux or other isolation means that the
management app (such as libvirt) has to do the open and pass the fd via
'getfd' monitor command.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvir
als correctly, guest-sync exists
in 1.0 guest agents, but not guest-sync-delimited; we can always send
0xff, but we can only expect to receive 0xff if we use
guest-sync-delimited which means we need to probe to see if the guest
agent understands guest-sync-delimited. Is it safe to send a 1.0 guest
emu_malloc
>
> The only option other than abort(), is to use _Exit() which
> doesn't try to run cleanup handlers.
Correct, but in that case, then you need to fflush(stderr) prior to
_Exit(), or else use write() rather than fprintf(), since otherwise your
attempt at a nice oom error mess
On 02/15/2012 07:46 AM, Anthony Liguori wrote:
> Please respond to this note with an '+1', or an Ack, to vote for this icon.
ACK
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 02/15/2012 07:38 AM, Anthony Liguori wrote:
> Please respond to this note with an '+1', or an Ack, to vote for this icon.
ACK
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ll contain.
I cringe any time I see someone using scanf to parse numbers from
arbitrary user input; I barely tolerate it for parsing things generated
by the kernel, but even there, I won't ever use scanf myself. Same goes
for atoi. _Only_ strtol and friends can robustly parse arbitrary input
the fact (see libvirt's qemudDomainCoreDump as a wrapper
around migration to file, for an example). If we do things right in
this new DumpState API, we may want to decide to fix other monitor
commands to use the same mechanism (it won't offload any of the burden
from libvirt, which mu
On 02/17/2012 09:51 AM, Jan Kiszka wrote:
> On 2012-02-17 17:32, Eric Blake wrote:
>> There are other APIs where qemu has ended up pausing the domain and not
>> restoring things back to running when done, and where libvirt has had to
>> track existing state prior to startin
.c | 8 ++--
> 1 file modificato, 6 inserzioni(+), 2 rimozioni(-)
How does this differ from this earlier posting?
https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg00851.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
sig
> +return -1;
>>> +}
>>
>> Wouldn't setfsgid(gid) == gid be also ok?
>
> Of course, it should be < 0. I have no idea how to test this thing...
POSIX states that uid_t and gid_t may be unsigned, so checking for < 0
is not necessarily possibl
TH_MAX];
> +char filename_tmp[PATH_MAX];
That's a LOT of stack space, which risks stack overflow, will mostly be
unused, and still doesn't work if you have super-deep hierarchies larger
than PATH_MAX. Would you be better off using realpath(,NULL) for its
allocating sem
to /dir2/snap2 and find /dir2/base and complain that
the arguments were swapped.
I can live with those semantics.
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
rn over the stack usage, to be safe I can
> manually g_malloc() each array.
g_malloc() would solve the stack size concern, but not the Solaris 10
relative name bug.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
cerns should be addressed in a separate patch series.
I can agree to that. Therefore,
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
d be able to write to the device via the
> +# NBD connection (default false). #optional
Isn't the #optional designation supposed to come first, before 'Whether'?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
an succeed and cause
confusion because of integer wraparound. Arbitrary set ids is not
necessarily bad, but I think you need to add bounds-checking on the
user's requested fdset_id to make sure it is positive.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization l
}
> -}
> -}
Since you maintain mon_fdsets in sorted id order, should you optimize
this loop to abort the QLIST_FOREACH early if fdset_id is less than
mon_fdset->id? [I only noticed this because of code motion, so it is a
pre-existing condition and therefore a separate pat
r of
sets; but a final cleanup loop had better be careful to not call
close(0) unintentionally).
Personally, though, I'm not sure the complexity of using dup() buys us
anything, so I'm happy with the simpler solution of using fd as-is,
coupled with a check for no reuse of an fd already in a set.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/11/2012 07:06 AM, Paolo Bonzini wrote:
> Il 10/10/2012 22:41, Eric Blake ha scritto:
>> On 10/10/2012 08:03 AM, Paolo Bonzini wrote:
>>> Adding an NBD server inside QEMU is trivial, since all the logic is
>>> in nbd.c and can be shared easily between qemu-nbd an
;& has_base) {
Code motion, but won't this order trigger valgrind warnings about
jumping based on a read of uninitialized memory? That is, the canonical
ordering is 'has_base && base' (although the end result is the same,
with the difference only observable in valgrind).
ied name with a bs). Saving this
until a followup patch as part of your phase 2 series to add active
image commit support is fine by me.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
set 2 via monitor
commands. Then, when qemu_close() drops the last reference to set 2, it
steps through and calls close() on all fds in that set, including fd 4.
Oops - now set 1 is invalid, because it is tracking a closed fd. And
worse, if qemu then does something else to open a new fd, it will ge
On 10/10/2012 04:31 PM, Eric Blake wrote:
> Another missing validation check is for duplicate use. With the monitor
> command, you ALWAYS have a unique fd (thanks to SCM_RIGHTS). But with
> the command line, I can type 'qemu -add-fd fd=4,set=1 -add-fd
> fd=4,set=2'. Oop
On 10/11/2012 10:04 AM, Eric Blake wrote:
> Another idea: a hybrid approach - the _first_ -add-fd 4 directly adds 4
> to the set, all other -add-fd 4 end up adding dup(4) instead (well,
> fcntl(F_DUPFD_CLOEXEC), but you get the picture). That is, do the
> duplicate scanning, and if
gt; disk size: 196K
> cluster_size: 65536
> backing file: base.qcow2
> backing file format: qcow2
>
> image: base.qcow2
> file format: qcow2
> virtual size: 100M (104857600 bytes)
> disk size: 136K
> cluster_size: 65536
>
> Signed-off-by: Stefan H
think you need a
followup patch that hashes which files have been opened to date, and
abort the loop once a cycle is detected.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/12/2012 08:27 AM, Kevin Wolf wrote:
> Am 12.10.2012 16:24, schrieb Eric Blake:
>> On 10/12/2012 08:09 AM, Stefan Hajnoczi wrote:
>>> The qemu-img info --backing-chain option enumerates the backing file
>>> chain. For example, for base.qcow2 <- snap1.qcow2
file = backing
At any rate, adding this logic should be a separate patch, and not hold
up Stefan's current patch.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t; they are displayed too. The command can output in the format @var{ofmt}
> which is either @code{human} or @code{json}.
>
> +If a disk image has a backing file chain, information about each disk image
> in
> +the chain can be recursively enumerated by using the option
&
realpath() certainly won't like it (most likely, it won't exist in
the file system, but on the off chance that it does, that file is much
different than the real protocol that we are using as the backing source).
I'm afraid you may need a followup patch that handles the case of
@var{fmt}] [--output=@var{ofmt}] @var{filename}
> +@item info [-f @var{fmt}] [--output=@var{oft}] [--backing-chain]
> @var{filename}
Last time, you added a spurious 'a'; this time, you accidentally nuked
an 'm'. Please, leave @var{ofmt} untouched.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
.
>> +#
>> +# Add a chardev
>> +#
>> +# @id: the chardev's ID, must be unique
>> +# @backend: the chardev backend: "file", "socket", ...
Rather than making this an open-coded string, should it instead be a QMP
enum value?
>> +##
>> +# @chardev_del:
And this should be 'chardev-del' or even 'chardev-remove', as QMP
commands tend to favor legibility over abbreviations.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
sts/041 | 90
>
> tests/qemu-iotests/041.out | 81 +++
Didn't Paolo already request test id 41, and 42 is already claimed,
leaving you at 43?
https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02481.html
--
Eric Blake ebl...@
+
> tests/qemu-iotests/041.out | 81 ++
> tests/qemu-iotests/common.rc | 9
> tests/qemu-iotests/group | 1 +
> 5 files changed, 274 insertions(+), 22 deletions(-)
> create mode 100755 tests/qemu-iotests/041
> create mode 100644 tests/qemu-iote
e ipv6-only (json-bool, optional)
> +- "telnet": telnet negotiation (json-bool, optional)
> +
> +Example:
> +
> +-> { "execute": "chardev_add", "arguments": { "id" : "foo",
> + "backend" : "socket",
> + "path": "/tmp/foo",
> + "server" : "on",
...this line is wrong, since "on" is not a json-bool. It would have to
be "server":true
> + "wait": "off" } }
Similar for "wait":false
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
qemu-img rebase -u -b '' bar
$ qemu-img info bar
image: bar
file format: qcow2
virtual size: 0 (0 bytes)
disk size: 192K
cluster_size: 65536
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/15/2012 12:07 PM, Eric Blake wrote:
> On 10/15/2012 11:29 AM, Alex Bligh wrote:
>> This patch allows qemu-img rebase to rebase an image to
>> have no backing file, as opposed to merely allowing it to
>> rebase to an existing backing file.
>
> You can already do th
On 10/15/2012 12:42 PM, Alex Bligh wrote:
> Eric,
>
> --On 15 October 2012 12:11:02 -0600 Eric Blake wrote:
>
>> On the other hand, if you don't use -u, then qemu-img complains:
>>
>> $ qemu-img rebase -b '' bar
>> qemu-img: Could not open
ips a [] prefix. It might be better as:
qemu-img rebase: use empty string to rebase without backing file
> This patch allows an empty filename to be passed as the new base image name
> for qemu-img rebase to mean base the image on no backing file (i.e.
> independent of any backing file).
On 10/15/2012 02:50 PM, Alex Bligh wrote:
> This patch allows an empty filename to be passed as the new base image name
> for qemu-img rebase to mean base the image on no backing file (i.e.
> independent of any backing file). According to Eric Blake, qemu-img rebase
> already suppor
sely related to
block work, and therefore adding Kevin in cc.
Reviewed-by: Eric Blake
Also, it helps to call out your specific pre-requisite; this only makes
sense after Stefan's patches:
https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02527.html
>
&g
gt; + * compare unmodified paths; otherwise make paths relative */
> +if (is_protocol || path_has_protocol(curr_bs->backing_file)) {
> +if (strcmp(backing_file, curr_bs->backing_file) == 0) {
I guess we are guaranteed that if is_protocol and path_has_protocol()
ing the top image?
[1] https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02067.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
additional pieces in place for committing the active
image. I just wanted to make sure the report wasn't lost.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
en though we are still not at a point where the overall feature is
useful, I can at least review these patches for getting us incrementally
closer to our goal.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
> choose the fd set ID on the first call.
>
> Signed-off-by: Corey Bryant
> ---
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ilures
when running the testsuite? Other than that, series:
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
d Error** parameter back to monitor_fdset_add_fd()
> -Move 'if (!mon_fdset_cur)' change to patch 1 (kw...@redhat.com)
> -Move code that prevents removal of fd from fd set during init
>to it's own patch (ebl...@redhat.com, kw...@redhat.com)
> -Mention code motion in commit
> - This patch was split into it's own patch in v3
> (ebl...@redhat.com, kw...@redhat.com)
>
> monitor.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
>
> diff --git a/monitor.c b/monitor.c
> index 5d5de41..0dae7ac 10064
to open a monitor on the fd I just passed in? And what if so, what then
happens on that monitor if I request that fdset 1 be removed?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
chain.
>>
>
> Thanks applied both to the block branch.
Now we also need the documentation:
https://lists.gnu.org/archive/html/qemu-devel/2012-10/msg02360.html
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/17/2012 08:02 AM, Kevin Wolf wrote:
> Am 17.10.2012 06:16, schrieb Eric Blake:
>> I'm still seeing the corner case of:
>>
>> qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4<&-
>>
>> where the dup(3) will populate fd 4 prior to the point where we
# @wait: wait for connect
> +# @ipv4: force ipv4-only
> +# @ipv6: force ipv6-only
> +# @telnet: telnet negotiation
But this part looks nicer.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ion - what is the format
of the deduplication table, and what do the bits in that table imply
with regards to how the rest of the qcow2 file is used?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/18/2012 01:30 AM, Juan Quintela wrote:
> This avoids having to do two walks over the dirty bitmap, once reading
> the dirty bits, and anthoer cleaning them.
s/anthoer/another/
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvi
s not an even multiple of cluster bytes, bits that correspond
> to
> +bytes beyond the raw file size in add-cow must be written as 0 and must be
> +ignored when reading.
> +
> +Image file name and backing file name must NOT be the same, we prevent this
> +while creating add-cow files.
You prevent it when creating add-cow files via qemu-img, but that
doesn't stop malicious users from creating a file with those properties
and then trying to get you to parse it as add-cow. I think this needs
to instead be a requirement on the consumer of a potentially bad file,
and not a requirement on the producer to avoid bad files, since you
can't control all producers, as in:
If image file name and backing file resolve to the same file, the
add-cow image must be treated as invalid.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
7;, 'nospace' ] }
>
> ##
> +# @BlockDirtyInfo:
> +#
> +# Block dirty bitmap information.
> +#
> +# @count: number of dirty bytes according to the dirty bitmap
> +#
> +# Since: 1.3
> +##
> +{ 'type': 'BlockDirtyInfo',
> + 'data': {'count': 'int'} }
...especially since you aren't consistent on using space before }
However, I can live with it, rather than needing a v4.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
minder that libvirt would still like a followup patch later in
your series but prior to qemu 1.3 that adds a 'type':'str' (or even an
enum, with 'stream', 'commit', and 'mirror'). But we already agreed it
need not hold up this particular patch.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
e file exists, or if it is
> +a device, it will be used as the new destination for writes. If does not
s/If does/If it does/
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ar, while qemu sets FD_CLOEXEC on all other fds opened from command
line arguments */". But I'm not going to require a v5 just for a
comment addition.
Series:
Reviewed-by: Eric Blake
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gt; +}
Thankfully, we only ever call that code in main(), prior to spawning
threads. So my positive review still stands.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/19/2012 10:46 AM, Kevin Wolf wrote:
>> As it happens, we despite what Eric Blake said, we couldn't get an unsafe
>> rebase to no backing file to work with the existing code (with our without
>> our patch). The second option may fix this bug. Reading line 1497, is this
t so that drives
> can be hotplugged.
Unless we enforce the use of add-fd for hot-plugging drives, but that in
turn requires that we have -blockdev semantics for telling qemu how to
open backing chains.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
P command. If you want a machine to be avoided
by libvirt, then perhaps it is best to augment the MachineInfo QMP
datatype to add an optional field that says whether a particular machine
type is stable enough for libvirt's use.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/22/2012 08:23 AM, Michael S. Tsirkin wrote:
> On Mon, Oct 22, 2012 at 07:00:56AM -0600, Eric Blake wrote:
>> On 10/22/2012 07:16 AM, Michael S. Tsirkin wrote:
>>
>>> I worry about need to maintain bug for bug compatibility on the
>>> unlikely chance that the
s/CircularMemoryr/CircularMemory/
> +static int cirmem_chr_write(CharDriverState *chr, const uint8_t *buf, int
> len)
> +{
> +CirMemCharDriver *d = chr->opaque;
> +int i;
> +
> +if (len < 0) {
> +return -1;
> +}
> +
> + /* The size should
/2012-October/msg00403.html
Additionally, there will probably be a release candidate in the next 48
hours, where you can use that tarball (rawhide will most certainly pick
it up), so the pain of using libvirt.git to develop qemu.git will not
last much longer.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
you are using a colon for the underlying name 'img:test.raw'.
> (note the double \\)
You also didn't give an example of comma escaping using typical command
line comma escaping; but at least your example looks okay once you fix
the typo in the lead-in text. The code appear
;opaque;
> +int i;
> +
> +for (i = 0; i < s->total; i++) {
> +bdrv_co_flush(s->bs[i]);
What if any of the individual flush calls return non-zero?
> +}
> +
> +return 0;
Shouldn't you then do likewise?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
> is in
>> + effect
>
> Not all hotplug abilities are disabled. Just network devices. This is
> missing a period too.
And not all network hotplug, just hotplug that requires use of exec
(again, fd passing bypasses the need for exec).
--
Eric Blake ebl...@redhat.com
speed * 10ULL) / slice_ns;
> +limit->slice_quota = ((double)speed * slice_ns)/10ULL;
> }
>
> #endif
>
>
>
>
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
On 10/24/2012 04:10 AM, Dietmar Maurer wrote:
> The formula to compute slice_quota was wrong.
>
> Signed-off-by: Dietmar Maurer
> ---
> include/qemu/ratelimit.h |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Reviewed-by: Eric Blake
However, it might also b
e backing file, then the data
> should
> +be read as all zero bytes instead.
> +
> +If raw image is not an even multiple of cluster bytes, bits that correspond
> to
> +bytes beyond the raw file size in add-cow must be written as 0 and must be
> +ignored when reading
be default 64K if it is not given.
> +
> +@option{maxcapacity} specify the max capacity of the size of circular buffer
> +want to create. Should be power of 2.
Still, this grammar could be improved:
s/specify/specifies/
s/want//
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt
en dimensions.
>
> +@item -chardev memchr ,id=@var{id} ,maxcapacity=@var{maxcapacity}
> +
> +Create a circular buffer with fixed size indicated by optionally
> @option{maxcapacity}
> +which will be default 64K if it is not given.
> +
> +@option{maxcapacity} specify the max
t; +- "chardev": the name of the char device, must be unique (json-string)
> +- "size": the memory size wanted to read in bytes(refer to unencoded
s/bytes(refer/bytes (refers/
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
rectories before opening an add-cow image
in order to interpret it the same way as the creator? You really need
to fix this to be like qcow2 backing files; relative path names there
are interpreted relative to the qcow2 file, not to the current working
directory of the process that opened the qcow2 file.
t;> +#include
>
> Did you check whether this and the macros you're using are available on
> POSIX and mingw32? vl.c is a pretty central file.
POSIX, yes. mingw32, no. Use of preprocessor conditionals is probably
in order.
--
Eric Blake ebl...@redhat.com+1-919-301-32
be aware that the /dev/fd/nn
naming of the reopen will be different.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
t dup2() to move 23 into 21 at
the time of the 'pass-reopen-fd', as that might not be safe.
Unless you have any bright ideas that I'm overlooking, I don't see how
an additional 'pass-reopen-fd' can be made to do what we want. I'm
afraid that the only w
+Example:
> +
> +-> { "execute": "migrate_set_parameters" , "arguments": { "parameters":
> xbzrle on"} }
Also wrong. Given the syntax, this would be:
{ "execute": "migrate-set-parameters", "arguments":
{ "parameters": [ { "capability": "xbzrle", "state": true } ] } }
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
ret;
>
> +params.blk = blk;
...and since blk is only ever a bool to begin with...
>
> +struct MigrationParams {
> +int blk;
> +int shared;
...why not use bool instead of int in this struct to represent the fact
that it really is a binary choice? I think the same
that the cache size is set too low.
> +overflow: the number of overflows in the decoding which where the delta could
> +not be compressed. This can happen if the changes in the pages are too large
> +or there are many short changes for example change every second byte (half a
s/changes fo
qemu
> + * The cache is base on a hash on the page address
> + *
> + * Copyright 2011 Red Hat, Inc. and/or its affiliates
> + *
> + * Authors:
> + * Orit Wasserman
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2. See
> + * the COPYING file
() in the middle of an incoming
migration, or are there more graceful ways to fail when dealing with
invalid user input?
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
gest adding an example to the docs of a 4k page that consists only of
a short string at the beginning of the page (and NUL bytes thereafter),
then show both the before and after version of that page to demonstrate
sparse memory changes, as well as the XBZRLE encoding of that page.
--
Eric Blake ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
101 - 200 of 23401 matches
Mail list logo
