On 10/15/2012 02:23 PM, Alex Bligh wrote: Rather long on the subject line; 'git shortlog -30' will give you a taste for typical commit summary length. Also, you will usually see [PATCHv2] as the prefix, rather than [PATCH]...[attempt 2] as a suffix, since 'git am' only strips a [] prefix. It might be better as:
qemu-img rebase: use empty string to rebase without backing file > This patch allows an empty filename to be passed as the new base image name > for qemu-img rebase to mean base the image on no backing file (i.e. > independent of any backing file). According to Eric Blake, qemu-imag rebase s/qemu-imag/qemu-img/ > already supports this when '-u' is used; this adds support when -u is not > used. > > Signed-off-by: Alex Bligh <a...@alex.org.uk> > --- > @@ -1675,7 +1677,11 @@ static int img_rebase(int argc, char **argv) > * backing file are overwritten in the COW file now, so the visible > content > * doesn't change when we switch the backing file. > */ > - ret = bdrv_change_backing_file(bs, out_baseimg, out_basefmt); > + if (bs_new_backing) > + ret = bdrv_change_backing_file(bs, out_baseimg, out_basefmt); > + else > + ret = bdrv_change_backing_file(bs, NULL, NULL); Should we error out if the user specifies basefmt but gives the empty string, instead of silently ignoring the bogus basefmt? But that's bikeshedding, I can live with what you wrote. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
