Re: secure boot & direct kernel load (was: Re: [PATCH] x86/loader: only patch linux kernels)

2024-04-15 Thread Daniel P . Berrangé
On Mon, Apr 15, 2024 at 03:30:32PM +0200, Gerd Hoffmann wrote: > Hi, > > > > Options I see: > > > > > > (a) Stop using direct kernel boot, let virt-install & other tools > > > create vfat boot media with shim+kernel+initrd instead. > > > > > > (b) Enroll the distro signing keys in th

Re: [PATCH v2 02/13] tests/lcitool/libvirt-ci: Update to the latest master branch

2024-04-15 Thread Daniel P . Berrangé
ertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 03/13] tests/docker/dockerfiles: Run lcitool-refresh after the lcitool update

2024-04-15 Thread Daniel P . Berrangé
buntu2204.docker| 1 + > 17 files changed, 29 insertions(+), 12 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-15 Thread Daniel P . Berrangé
> tests/lcitool/mappings.yml| 20 --- > tests/lcitool/refresh | 2 +- > tests/vm/centos | 4 +-- > 6 files changed, 26 insertions(+), 54 deletions(-) > rename tests/docker/dockerfiles/{centos8.docker =>

Re: [PATCH v2 05/13] .travis.yml: Update the jobs to Ubuntu 22.04

2024-04-15 Thread Daniel P . Berrangé
lyfish") > for future testing. Since all jobs are using this release now, we > can drop the entries from the individual jobs and use the global > setting again. > > Signed-off-by: Thomas Huth > --- > .travis.yml | 13 +++-- > 1 file changed, 3 insertions(+)

Re: [PATCH v2 06/13] ci: move external build environment setups to CentOS Stream 9

2024-04-15 Thread Daniel P . Berrangé
ons(+), 45 deletions(-) > rename scripts/ci/org.centos/stream/{8 => 9}/build-environment.yml (75%) > rename scripts/ci/org.centos/stream/{8 => 9}/x86_64/configure (98%) > rename scripts/ci/org.centos/stream/{8 => 9}/x86_64/test-avocado (100%) Reviewed-by: Daniel P. Berrangé With

Re: [PATCH v2 07/13] Bump minimum glib version to v2.66

2024-04-15 Thread Daniel P . Berrangé
| 16 +--- > include/glib-compat.h| 27 ++- > qga/commands-posix-ssh.c | 4 ++-- > 3 files changed, 5 insertions(+), 42 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dbe

Re: [PATCH v2 08/13] Remove glib compatibility code that is not required anymore

2024-04-15 Thread Daniel P . Berrangé
error-report.c | 10 -- > 2 files changed, 18 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
block/gluster.c | 71 - > 1 file changed, 35 insertions(+), 36 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: [PATCH v2 09/13] block/gluster: Use URI parsing code from glib

2024-04-15 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 09:40:11AM -0500, Eric Blake wrote: > On Fri, Apr 12, 2024 at 03:24:11PM +0200, Thomas Huth wrote: > > Since version 2.66, glib has useful URI parsing functions, too. > > Use those instead of the QEMU-internal ones to be finally able > > to get rid of the latter. > > > > Si

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-15 Thread Daniel P . Berrangé
On Mon, Apr 08, 2024 at 10:49:40PM -0400, Shaoqin Huang wrote: > The KVM_ARM_VCPU_PMU_V3_FILTER provides the ability to let the VMM decide > which PMU events are provided to the guest. Add a new option > `kvm-pmu-filter` as -cpu sub-option to set the PMU Event Filtering. > Without the filter, all P

Re: [PATCH v8] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-04-15 Thread Daniel P . Berrangé
On Tue, Apr 02, 2024 at 03:01:50PM +0200, Kevin Wolf wrote: > Am 29.03.2024 um 04:45 hat Shaoqin Huang geschrieben: > > Hi Daniel, > > > > On 3/25/24 16:55, Daniel P. Berrangé wrote: > > > On Mon, Mar 25, 2024 at 01:35:58PM +0800, Shaoqin Huang wrote: > > &g

Re: [PATCH v2 02/10] backends/confidential-guest-support: Add IGVM file parameter

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 12:11:33PM +0100, Roy Hopkins wrote: > In order to add support for parsing IGVM files for secure virtual > machines, a the path to an IGVM file needs to be specified as > part of the guest configuration. It makes sense to add this to > the ConfidentialGuestSupport object as

Re: [PATCH v2 03/10] backends/confidential-guest-support: Add functions to support IGVM

2024-04-16 Thread Daniel P . Berrangé
On Thu, Apr 04, 2024 at 10:00:53AM +0200, Philippe Mathieu-Daudé wrote: > Hi Roy, > > On 3/4/24 13:11, Roy Hopkins wrote: > > In preparation for supporting the processing of IGVM files to configure > > guests, this adds a set of functions to ConfidentialGuestSupport > > allowing configuration of s

Re: [PATCH v2 04/10] backends/igvm: Implement parsing and processing of IGVM files

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 12:11:35PM +0100, Roy Hopkins wrote: > This commit adds an implementation of an IGVM loader which parses the > file specified as a pararameter to ConfidentialGuestSupport and provides > a function that uses the interface in the same object to configure and > populate guest m

Re: [PATCH v2 01/10] meson: Add optional dependency on IGVM library

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 12:11:32PM +0100, Roy Hopkins wrote: > The IGVM library allows Independent Guest Virtual Machine files to be > parsed and processed. IGVM files are used to configure guest memory > layout, initial processor state and other configuration pertaining to > secure virtual machine

Re: [PATCH v2 05/10] i386/pc: Process IGVM file during PC initialization if present

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 12:11:36PM +0100, Roy Hopkins wrote: > An IGVM file contains configuration of a guest that supports > confidential computing hardware. As part of the PC system > initialisation, the IGVM needs to be processed to apply this > configuration before the guest is started. > > Th

Re: [PATCH v2 08/10] i386/sev: Implement ConfidentialGuestSupport functions for SEV

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 03, 2024 at 12:11:39PM +0100, Roy Hopkins wrote: > The ConfidentialGuestSupport object defines a number of virtual > functions that are called during processing of IGVM directives to query > or configure initial guest state. In order to support processing of IGVM > files, these function

Re: [PATCH] Add zh_TW Traditional Chinese translation

2024-04-16 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 12:41:16AM +0800, Zhao Liu wrote: > Hi Peter, > > On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote: > > Date: Tue, 16 Apr 2024 14:27:45 +0100 > > From: Peter Maydell > > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation > > > > On Tue, 16 Apr 202

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-17 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 04:42:39PM +0200, Maciej S. Szmigiero wrote: > From: "Maciej S. Szmigiero" > > VFIO device state transfer is currently done via the main migration channel. > This means that transfers from multiple VFIO devices are done sequentially > and via just a single common migration

Re: [PATCH v6 1/3] ui/console: Introduce dpy_gl_qemu_dmabuf_get_..() helpers

2024-04-17 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 09:09:52PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > This commit introduces dpy_gl_qemu_dmabuf_get_... helpers to extract > specific fields from the QemuDmaBuf struct. It also updates all instances > where fields within the QemuDmaBuf struct are directly

Re: [PATCH v6 3/3] ui/console: Introduce dpy_gl_qemu_dmabuf_new() and free() helpers

2024-04-17 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 09:09:54PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > This commit introduces utility functions for the creation and deallocation > of QemuDmaBuf instances. Additionally, it updates all relevant sections > of the codebase to utilize these new utility functi

Re: [PATCH v6 0/3] ui/console: Private QemuDmaBuf struct

2024-04-17 Thread Daniel P . Berrangé
On Tue, Apr 16, 2024 at 09:09:51PM -0700, dongwon@intel.com wrote: > From: Dongwon Kim > > This series introduces privacy enhancements to the QemuDmaBuf struct > and its contained data to bolster security. it accomplishes this by > introducing of helper functions for allocating, deallocating,

Re: [PATCH for-9.0 v3 2/2] qtest/virtio-9p-test.c: remove g_test_slow() gate

2024-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 01:52:24PM +0200, Christian Schoenebeck wrote: > On Wednesday, April 17, 2024 1:16:02 AM CEST Daniel Henrique Barboza wrote: > > > > On 4/16/24 16:54, Michael Tokarev wrote: > > > 27.03.2024 17:20, Daniel Henrique Barboza : > > >> Commit 558f5c42ef gated the local tests wit

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 06:07:02PM +0800, Zhao Liu wrote: > Hi Anthony, > > May I ask what your usage scenario is? Is it to measure Guest's energy > consumption and to charged per watt consumed? ;-) > > On Thu, Apr 11, 2024 at 02:14:34PM +0200, Anthony Harivel wrote: > > Date: Thu, 11 Apr 2024 14

Re: [PATCH v2 04/13] tests: Update our CI to use CentOS Stream 9 instead of 8

2024-04-17 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 03:24:06PM +0200, Thomas Huth wrote: > RHEL 9 (and thus also the derivatives) are available since two years > now, so according to QEMU's support policy, we can drop the active > support for the previous major version 8 now. > Thus upgrade our CentOS Stream container to majo

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-17 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 02:11:37PM +0200, Maciej S. Szmigiero wrote: > On 17.04.2024 10:36, Daniel P. Berrangé wrote: > > On Tue, Apr 16, 2024 at 04:42:39PM +0200, Maciej S. Szmigiero wrote: > > > From: "Maciej S. Szmigiero" > > > > > > VFIO device

Re: [PATCH v5 0/3] Add support for the RAPL MSRs series

2024-04-17 Thread Daniel P . Berrangé
On Thu, Apr 11, 2024 at 02:14:31PM +0200, Anthony Harivel wrote: > Dear maintainers, > > First of all, thank you very much for your review of my patch > [1]. > > In this version (v5), I have attempted to address all the problems > addressed by Daniel during the last review. I've been more care

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-17 Thread Daniel P . Berrangé
On Thu, Apr 11, 2024 at 02:14:34PM +0200, Anthony Harivel wrote: > diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h > index fad9a7e8ff30..37f68c496807 100644 > --- a/include/sysemu/kvm.h > +++ b/include/sysemu/kvm.h > @@ -544,4 +544,6 @@ uint32_t kvm_dirty_ring_size(void); > * reported

Re: [PATCH v5 0/3] Add support for the RAPL MSRs series

2024-04-17 Thread Daniel P . Berrangé
On Fri, Apr 12, 2024 at 12:57:11PM +0200, Paolo Bonzini wrote: > On Thu, Apr 11, 2024 at 2:14 PM Anthony Harivel wrote: > > > > Dear maintainers, > > > > First of all, thank you very much for your review of my patch > > [1]. > > > > In this version (v5), I have attempted to address all the problem

Re: Hermetic virtio-vsock in QEMU

2024-04-18 Thread Daniel P . Berrangé
On Wed, Apr 17, 2024 at 12:31:41PM -0700, Roman Kiryanov wrote: > Hi Daniel, > > thank you for looking into this. I checked how VHOST_USER_VSOCK and it > refers to the vhost-user protocol. It is implemented in the > subprojects/libvhost-user library, but this library depends on poll.h > and linux/

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 11:50:12AM +0200, Maciej S. Szmigiero wrote: > On 17.04.2024 18:35, Daniel P. Berrangé wrote: > > On Wed, Apr 17, 2024 at 02:11:37PM +0200, Maciej S. Szmigiero wrote: > > > On 17.04.2024 10:36, Daniel P. Berrangé wrote: > > > > On Tue, Ap

Re: [PATCH 1/2] libvhost-user: Fix pointer arithmetic in indirect read

2024-04-18 Thread Daniel P . Berrangé
On Sat, Jan 13, 2024 at 04:27:40AM +0300, Temir Zharaspayev wrote: > When zero-copy usage of indirect descriptors buffer table isn't > possible, library gather scattered memory chunks in a local copy. > This commit fixes the issue with pointer arithmetic for the local copy > buffer. > > Signed-off

Re: [PATCH 0/2] Fix pointer arithmetic in indirect read for libvhost-user and libvduse

2024-04-18 Thread Daniel P . Berrangé
Adding Michael back to the CC, since he's the designated maintainer for libvhost-user/ Michael, could you give these patches a review since they've been pending for many months now. On Sun, Feb 04, 2024 at 12:41:31PM +0300, Тимур wrote: > Hello, I am very sorry for bothering community on a such m

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy wrote: > We do set MIGRATION_FAILED state, but don't give a chance to > orchestrator to query migration state and get the error. > > Let's report an error through QAPI like we do on outgoing migration. > > migration-test is up

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 18.04.24 17:37, Daniel P. Berrangé wrote: > > On Thu, Apr 18, 2024 at 01:13:29AM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > We do set MIGRATION_FAILED state, but don't give a

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 11, 2024 at 02:14:34PM +0200, Anthony Harivel wrote: > Starting with the "Sandy Bridge" generation, Intel CPUs provide a RAPL > interface (Running Average Power Limit) for advertising the accumulated > energy consumption of various power domains (e.g. CPU packages, DRAM, > etc.). > > T

Re: [PATCH] migration: do not exit on incoming failure

2024-04-18 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 12:43:42PM -0400, Peter Xu wrote: > On Thu, Apr 18, 2024 at 06:47:31PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > On 18.04.24 18:43, Daniel P. Berrangé wrote: > > > On Thu, Apr 18, 2024 at 06:40:38PM +0300, Vladimir Sementsov-Ogievskiy > > >

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-19 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 04:02:49PM -0400, Peter Xu wrote: > On Thu, Apr 18, 2024 at 08:14:15PM +0200, Maciej S. Szmigiero wrote: > > I think one of the reasons for these results is that mixed (RAM + device > > state) multifd channels participate in the RAM sync process > > (MULTIFD_FLAG_SYNC) where

Re: [PATCH RFC 00/26] Multifd 🔀 device state transfer support with VFIO consumer

2024-04-19 Thread Daniel P . Berrangé
On Thu, Apr 18, 2024 at 08:14:15PM +0200, Maciej S. Szmigiero wrote: > On 18.04.2024 12:39, Daniel P. Berrangé wrote: > > On Thu, Apr 18, 2024 at 11:50:12AM +0200, Maciej S. Szmigiero wrote: > > > On 17.04.2024 18:35, Daniel P. Berrangé wrote: > > > > On Wed, Ap

Re: [PATCH 00/12] misc: Remove sprintf() due to macOS deprecation

2024-04-19 Thread Daniel P . Berrangé
On Thu, Apr 11, 2024 at 11:38:41AM +0200, Philippe Mathieu-Daudé wrote: > On 11/4/24 00:27, BALATON Zoltan wrote: > > On Wed, 10 Apr 2024, Richard Henderson wrote: > > > On 4/10/24 06:06, Philippe Mathieu-Daudé wrote: > > > > Hi, > > > > > > > > sprintf() is deprecated on Darwin since macOS 13.0 /

Re: [PATCH v2 02/22] target/arm: Add confidential guest support

2024-04-19 Thread Daniel P . Berrangé
l-guest-support= > -object guest-rme,id=[,options...] How about either "arm-rme" or merely 'rme' as the object name > > This is only the skeleton. Support will be added in following patches. > > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Daniel P.

Re: [PATCH v8 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-22 Thread Daniel P . Berrangé
gested-by: Marc-André Lureau > Cc: Philippe Mathieu-Daudé > Cc: Daniel P. Berrangé > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > include/ui/console.h | 20 + > include/ui/dmabuf.h | 81 + > ui/dmabuf.c | 206

Re: [PATCH 0/3] Remove useless architecture prefix from the CPU list

2024-04-22 Thread Daniel P . Berrangé
On Sat, Apr 20, 2024 at 07:46:03AM +0200, Thomas Huth wrote: > Printing an architecture prefix in front of each CPU name is not helpful > at all: It is confusing for the users since they don't know whether they > have to specify these letters for the "-cpu" parameter, too, and it also > takes some

Re: [PATCH] target/i386/translate.c: always write 32-bits for SGDT and SIDT

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 10:15:57AM +0200, Philippe Mathieu-Daudé wrote: > On 22/4/24 21:03, Volker Rümelin wrote: > > Am 20.04.24 um 07:40 schrieb Mark Cave-Ayland: > > > On 20/04/2024 02:21, Richard Henderson wrote: > > > > > > > On 4/19/24 12:51, Mark Cave-Ayland wrote: > > > > > The various Int

Re: [PATCH v2 02/22] target/arm: Add confidential guest support

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 10:44:56AM +0100, Jean-Philippe Brucker wrote: > On Fri, Apr 19, 2024 at 05:25:12PM +0100, Daniel P. Berrangé wrote: > > On Fri, Apr 19, 2024 at 04:56:50PM +0100, Jean-Philippe Brucker wrote: > > > Add a new RmeGuest object, inheriting from Confidenti

Re: [PATCH v2 14/22] target/arm/kvm-rme: Add Realm Personalization Value parameter

2024-04-23 Thread Daniel P . Berrangé
> > The user provides up to 64 hexadecimal bytes. They are stored into the > > RPV in the same order, zero-padded on the right. > > > > Cc: Eric Blake > > Cc: Markus Armbruster > > Cc: Daniel P. Berrangé > > Cc: Eduardo Habkost > > Signed-off-

Re: [PATCH v10 1/6] ui/gtk: Check if fence_fd is equal to or greater than 0

2024-04-23 Thread Daniel P . Berrangé
gt; > Suggested-by: Marc-André Lureau > Cc: Philippe Mathieu-Daudé > Cc: Daniel P. Berrangé > Cc: Vivek Kasireddy > Signed-off-by: Dongwon Kim > --- > ui/gtk-egl.c | 2 +- > ui/gtk-gl-area.c | 2 +- > ui/gtk.c | 10 ++ > 3 files changed, 8 in

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
0: Change the license type for both dmabuf.h and dmabuf.c from MIT to > GPL to be in line with QEMU's default license > (Daniel P. Berrangé ) FYI, in future, notes about changes made in each version would best go after the '---', since they're not something we n

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
0: Change the license type for both dmabuf.h and dmabuf.c from MIT to > GPL to be in line with QEMU's default license > (Daniel P. Berrangé ) > > Suggested-by: Marc-André Lureau > Cc: Philippe Mathieu-Daudé > Cc: Daniel P. Berrangé > Cc: Vivek Kasireddy &g

Re: [PATCH v10 3/6] ui/console: Use qemu_dmabuf_get_..() helpers instead

2024-04-23 Thread Daniel P . Berrangé
in helper names in ui/spice-display.c > > v7: removed prefix, "dpy_gl_" from all helpers > > v8: Introduction of helpers was removed as those were already added > by the previous commit > > Suggested-by: Marc-André Lureau > Reviewed-by: Marc-André Lureau

Re: hppa-firmware.img missing build-id

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 05:07:17PM +0200, Helge Deller wrote: > On 4/23/24 16:58, Cole Robinson wrote: > > On 4/23/24 10:11 AM, Cole Robinson wrote: > > > Hi, > > > > > > hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF > > > build-id annotations. rpm builds on Fedora will err

Re: [PATCH v10 2/6] ui/console: new dmabuf.h and dmabuf.c for QemuDmaBuf struct and helpers

2024-04-23 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 07:05:20PM +, Kim, Dongwon wrote: > Hi Daniel, > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: Tuesday, April 23, 2024 7:07 AM > > To: Kim, Dongwon > > Cc: qemu-devel@nongnu.org; marcandre.lur...@redhat.co

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-24 Thread Daniel P . Berrangé
On Tue, Apr 23, 2024 at 05:06:53PM -0400, Collin Walling wrote: > This optional parameter for query-cpu-model-expansion enables CPU > model features flagged as deprecated to appear in the resulting > list of properties. > > This commit does not add support beyond adding a new argument > to the que

Re: [PATCH] .gitlab-ci.d/cirrus.yml: Fix the NetBSD and OpenBSD Cirrus-CI KVM jobs

2024-04-24 Thread Daniel P . Berrangé
rrus: switch from 'master' to 'latest'"), but apparently > nobody noticed the KVM jobs so far that need to be triggered manually. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.d/cirrus.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-b

Re: [PATCH] target/i386: Introduce SapphireRapids-v3 to add missing features

2024-04-24 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 04:33:11PM +0800, Zhao Liu wrote: > Hi Lei, > > On Wed, Apr 24, 2024 at 03:29:12AM -0400, Lei Wang wrote: > > Date: Wed, 24 Apr 2024 03:29:12 -0400 > > From: Lei Wang > > Subject: [PATCH] target/i386: Introduce SapphireRapids-v3 to add missing > > features > > X-Mailer: g

Re: Timeouts in CI jobs (was: cross-i686-tci CI job is flaky again (timeouts): can somebody who cares about TCI investigate?)

2024-04-24 Thread Daniel P . Berrangé
b execution time. A lot of our jobs are already quite long, which is bad for the turnaround time of CI testing. Reliable CI though is arguably the #1 priority though, otherwise developers cease trusting it. We need to find the balance between avoiding timeouts, while having the shortest pratical

Re: [PULL 00/17] CI job updates, header cleanups and other misc patches

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 07:11:41AM +0200, Thomas Huth wrote: > On 24/04/2024 18.21, Richard Henderson wrote: > > On 4/24/24 00:57, Thomas Huth wrote: > > > The following changes since commit > > > 13b1e9667737132440f4d500c31cb69320c6b15a: > > > > > >    Merge tag 'for-upstream' of https://gitlab.

Re: [PATCH 01/29] include: move include/qapi/qmp/ to include/qobject/

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 11:34:46AM +0200, Markus Armbruster wrote: > I just realized I dropped this on the floor. I apologize for the delay. > > Daniel P. Berrangé writes: > > > On Mon, Jan 08, 2024 at 06:23:37PM +, Daniel P. Berrangé wrote: > >> The general

Re: Timeouts in CI jobs

2024-04-25 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 08:10:19PM +0200, Stefan Weil wrote: > Am 24.04.24 um 19:09 schrieb Daniel P. Berrangé: > > > On Wed, Apr 24, 2024 at 06:27:58PM +0200, Stefan Weil via wrote: > > > I think the timeouts are caused by running too many parallel processes

Re: Timeouts in CI jobs

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:27:17PM +0100, Daniel P. Berrangé wrote: > On Wed, Apr 24, 2024 at 08:10:19PM +0200, Stefan Weil wrote: > > > > I did not run tests in my GitLab fork because I still have to figure out how > > to do that. > > It is quite simple: > >

Re: [PATCH v2 1/3] cpu-models: add "disable-deprecated-feats" option to cpu model expansion

2024-04-25 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 03:12:42PM -0400, Collin Walling wrote: > On 4/24/24 13:51, Collin Walling wrote: > > On 4/24/24 04:20, Daniel P. Berrangé wrote: > >> On Tue, Apr 23, 2024 at 05:06:53PM -0400, Collin Walling wrote: > >>> This optional parameter for query-c

Re: [PATCH v4 08/14] migration/multifd: Add new migration option for multifd DSA offloading.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:11AM +, Hao Xiang wrote: > Intel DSA offloading is an optional feature that turns on if > proper hardware and software stack is available. To turn on > DSA offloading in multifd live migration: > > multifd-dsa-accel="[dsa_dev_path1] [dsa_dev_path2] ... [dsa_dev_pa

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v4 10/14] migration/multifd: Enable DSA offloading in multifd sender path.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:13AM +, Hao Xiang wrote: > Multifd sender path gets an array of pages queued by the migration > thread. It performs zero page checking on every page in the array. > The pages are classfied as either a zero page or a normal page. This > change uses Intel DSA to offl

Re: [PATCH v4 03/14] util/dsa: Implement DSA device start and stop logic.

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 02:21:06AM +, Hao Xiang wrote: > * DSA device open and close. > * DSA group contains multiple DSA devices. > * DSA group configure/start/stop/clean. > > Signed-off-by: Hao Xiang > Signed-off-by: Bryan Zhang > --- > include/qemu/dsa.h | 72 +++ > util/dsa.c

Re: [PATCH v5 3/3] Add support for RAPL MSRs in KVM/Qemu

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 05:34:52PM +0200, Anthony Harivel wrote: > Hi Daniel, > > Daniel P. Berrangé, Apr 18, 2024 at 18:42: > > > > +if (kvm_is_rapl_feat_enable(cs)) { > > > +if (!IS_INTEL_CPU(env)) { > > > +err

Re: [PATCH] ci: move external build environment setups to CentOS Stream 9

2024-04-25 Thread Daniel P . Berrangé
On Thu, Apr 25, 2024 at 05:03:43PM +0200, Thomas Huth wrote: > On 12/04/2024 12.37, Paolo Bonzini wrote: > > RHEL 9 (and thus also the derivatives) are available since two years > > now, so according to QEMU's support policy, we can drop the active > > support for the previous major version 8 now.

Re: [PATCH v6 02/10] util/bufferiszero: Remove AVX512 variant

2024-04-29 Thread Daniel P . Berrangé
On Wed, Apr 24, 2024 at 03:56:57PM -0700, Richard Henderson wrote: > From: Alexander Monakov > > Thanks to early checks in the inline buffer_is_zero wrapper, the SIMD > routines are invoked much more rarely in normal use when most buffers > are non-zero. This makes use of AVX512 unprofitable, as

Re: QEMU Community Call Agenda Items (April 30th, 2024)

2024-04-29 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 05:06:36PM +0200, Philippe Mathieu-Daudé wrote: > Hi, > > On 29/4/24 00:25, Philippe Mathieu-Daudé wrote: > > Hi, > > > > The KVM/QEMU community call is at: > > > >   https://meet.jit.si/kvmcallmeeting > >   @ > >   30/4/2024 14:00 UTC > > > > Are there any agenda ite

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 09:15:03AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Apr 29, 2024 at 08:08:10AM -0500, Michael Galaxy wrote: > >> Hi All (and Peter), > > > > Hi, Michael, > > > >> > >> My name is Michael Galaxy (formerly Hines). Yes, I changed my last name > >> (hi

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > Old machine types often have bugs or work-arounds that affect our > possibilities to move forward with the QEMU code base (see for example > https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely > cannot be fixed with

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > Old machine types often have bugs or work-arounds that affect our > possibilities to move forward with the QEMU code base (see for example > https://gitlab.com/qemu-project/qemu/-/issues/2213 for a bug that likely > cannot be fixed with

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 11:40:42AM +0200, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 30/4/24 08:45, Thomas Huth wrote: > > Old machine types often have bugs or work-arounds that affect our > > possibilities to move forward with the QEMU code base (see for example > > https://gitlab.com/qemu

Re: QEMU Community Call Agenda Items (April 30th, 2024)

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 10:44:20AM +0100, Peter Maydell wrote: > On Tue, 30 Apr 2024 at 08:36, Markus Armbruster wrote: > > > > Daniel P. Berrangé writes: > > > * /machine to get the rtc-time property value > > > > This is an alias to the RTC devi

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 10:55:38AM +0100, Daniel P. Berrangé wrote: > On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > > Old machine types often have bugs or work-arounds that affect our > > possibilities to move forward with the QEMU code base (see for example > &g

Re: [PATCH] docs/about: Automatically deprecate versioned machine types older than 6 years

2024-04-30 Thread Daniel P . Berrangé
On Tue, Apr 30, 2024 at 12:29:14PM +0200, Thomas Huth wrote: > On 30/04/2024 11.55, Daniel P. Berrangé wrote: > > On Tue, Apr 30, 2024 at 08:45:29AM +0200, Thomas Huth wrote: > > > Old machine types often have bugs or work-arounds that affect our > > > possibilities to

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

2024-05-01 Thread Daniel P . Berrangé
On Wed, May 01, 2024 at 11:31:13AM -0400, Peter Xu wrote: > What I worry more is whether this is really what we want to keep rdma in > qemu, and that's also why I was trying to request for some serious > performance measurements comparing rdma v.s. nics. And here when I said > "we" I mean both QEM

[PATCH 02/14] hw/arm: convert 'virt' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
This changes the DEFINE_VIRT_MACHINE macro to use the common helpers for constructing versioned symbol names and strings, bringing greater consistency across targets. Signed-off-by: Daniel P. Berrangé --- hw/arm/virt.c | 28 +++- 1 file changed, 15 insertions(+), 13

[PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-01 Thread Daniel P . Berrangé
The various targets which define versioned machine types have a bunch of obfuscated macro code for defining unique function and variable names using string concatenation. This addes a couple of helpers to improve the clarity of such code macro. Signed-off-by: Daniel P. Berrangé --- include/hw

[PATCH 00/14] hw: define and enforce a standard lifecycle for versioned machines

2024-05-01 Thread Daniel P . Berrangé
he actual version the release is about to become, rather than the previous release's version. This would make the reported version match the rc tarball naming too which would be nice. Anyway, this isn't a blocker for this machine type versioning proposal, just a thought Daniel P. Berrang

[PATCH 05/14] hw/m68k: convert 'virt' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
al machine type. Signed-off-by: Daniel P. Berrangé --- hw/m68k/virt.c | 51 -- 1 file changed, 29 insertions(+), 22 deletions(-) diff --git a/hw/m68k/virt.c b/hw/m68k/virt.c index 09bc9bdfef..cd6ee692f7 100644 --- a/hw/m68k/virt.c +++ b/hw/m68k/virt.c

[PATCH 09/14] hw: temporarily disable deletion of versioned machine types

2024-05-01 Thread Daniel P . Berrangé
commit should be reverted in the 10.1.0 dev cycle or shortly thereafter. Signed-off-by: Daniel P. Berrangé --- include/hw/boards.h | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/include/hw/boards.h b/include/hw/boards.h index 48b6c98c77..d6214007ce 100644

[PATCH 07/14] hw/i386: convert 'q35' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
DEFINE_Q35_MACHINE. Due to the odd-ball '4.0.1' machine type version, this commit introduces a DEFINE_Q35_BUGFIX helper, to allow defining of "bugfix" machine types which have a three digit version. Signed-off-by: Daniel P. Berrangé --- hw

[PATCH 08/14] include/hw: add macros for deprecation & removal of versioned machines

2024-05-01 Thread Daniel P . Berrangé
most sense. Signed-off-by: Daniel P. Berrangé --- include/hw/boards.h | 84 + 1 file changed, 84 insertions(+) diff --git a/include/hw/boards.h b/include/hw/boards.h index 47ca450fca..48b6c98c77 100644 --- a/include/hw/boards.h +++ b/include/hw/boards.h

[PATCH 04/14] hw/ppc: convert 'spapr' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
defining of "tagged" machine types which have a string suffix. Signed-off-by: Daniel P. Berrangé --- hw/ppc/spapr.c | 93 +++--- 1 file changed, 51 insertions(+), 42 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index d2d1e310a3..

[PATCH 03/14] hw/s390x: convert 'ccw' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
DEFINE_CCW_MACHINE. A DEFINE_CCW_MACHINE_AS_LATEST helper is added so that it is not required to pass 'false' for every single historical machine type. Signed-off-by: Daniel P. Berrangé --- hw/s390x/s390-virtio-ccw.c | 96 +- 1 file changed, 53 inserti

[PATCH 13/14] hw/i386: remove obsolete manual deprecation reason string of i440fx machines

2024-05-01 Thread Daniel P . Berrangé
: Fri Oct 6 09:52:47 2023 +0200 docs/about: Mark the old pc-i440fx-2.0 - 2.3 machine types as deprecated Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9f92504cc4..4137e03f6f 100644 --- a

[PATCH 11/14] hw: skip registration of outdated versioned machine types

2024-05-01 Thread Daniel P . Berrangé
experience shows that can easily be forgotten. By skipping registration the manual code deletion task can be done at any later date. Signed-off-by: Daniel P. Berrangé --- hw/arm/virt.c | 1 + hw/m68k/virt.c | 1 + hw/ppc/spapr.c | 1 + hw/s390x/s390-virtio-ccw.c

[PATCH 14/14] docs: document special exception for machine type deprecation & removal

2024-05-01 Thread Daniel P . Berrangé
This extends the deprecation policy to indicate that versioned machine types will be marked deprecated after 3 years, and then subject to removal after a further 3 years has passed. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 12 1 file changed, 12 insertions

[PATCH 10/14] hw: set deprecation info for all versioned machine types

2024-05-01 Thread Daniel P . Berrangé
This calls the MACHINE_VER_DEPRECATION() macro in the definition of all machine type classes which support versioning. This ensures that they will automatically get deprecation info set when they reach the appropriate point in their lifecycle. Signed-off-by: Daniel P. Berrangé --- hw/arm/virt.c

[PATCH 12/14] hw/ppc: remove obsolete manual deprecation reason string of spapr machines

2024-05-01 Thread Daniel P . Berrangé
Date: Tue Jan 23 16:37:02 2024 +1000 spapr: Tag pseries-2.1 - 2.11 machines as deprecated Signed-off-by: Daniel P. Berrangé --- hw/ppc/spapr.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 2aad99a2f2..1b8fa71eb8 100644 --- a/hw/ppc/spapr.c +++ b/hw

[PATCH 06/14] hw/i386: convert 'i440fx' machine definitions to use new macros

2024-05-01 Thread Daniel P . Berrangé
DEFINE_I440FX_MACHINE. Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_piix.c| 251 +++ include/hw/i386/pc.h | 30 ++ 2 files changed, 138 insertions(+), 143 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8850c49c66..9f92504cc4

Re: QEMU headers in C++

2024-05-02 Thread Daniel P . Berrangé
On Wed, May 01, 2024 at 09:40:16PM -0700, Roman Kiryanov wrote: > Hi QEMU, > > I work in Android Studio Emulator and we would like to develop devices > in C++. Unfortunately, QEMU headers cannot be used with C++ as is > (e.g. they use C++ keywords as variable names or implicitly cast void* > to T*

Re: [PATCH] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 10:22:02AM +0200, Philippe Mathieu-Daudé wrote: > On 2/5/24 10:11, Philippe Mathieu-Daudé wrote: > > We only use Libtasn1 in unit tests. As noted in commit d47b83b118 > > ("tests: add migration tests of TLS with x509 credentials"), having > > GnuTLS without Libtasn1 is a val

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: > On-demand paging support was added in libibverbs v1.2.0 in > commit https://github.com/linux-rdma/rdma-core/commit/e500adc7b1 That is 9 years old, so I'm surprised any distro we target still is so outdated. Can you say what

Re: [PATCH 14/14] docs: document special exception for machine type deprecation & removal

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:47:40AM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > This extends the deprecation policy to indicate that versioned machine > > types will be marked deprecated after 3 years, and then subject to > > removal after

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:21:31AM +0200, Philippe Mathieu-Daudé wrote: > On 2/5/24 11:19, Philippe Mathieu-Daudé wrote: > > On 2/5/24 11:10, Daniel P. Berrangé wrote: > > > On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: > > > > On-dema

Re: [PATCH] migration/rdma: Allow building without on-demand paging support

2024-05-02 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:19:28AM +0200, Philippe Mathieu-Daudé wrote: > On 2/5/24 11:10, Daniel P. Berrangé wrote: > > On Thu, May 02, 2024 at 11:05:47AM +0200, Philippe Mathieu-Daudé wrote: > > > On-demand paging support was added in libibverbs v1.2.0 in > > > comm

<    2   3   4   5   6   7   8   9   10   11   >