On Wed, Apr 17, 2024 at 12:41:16AM +0800, Zhao Liu wrote: > Hi Peter, > > On Tue, Apr 16, 2024 at 02:27:45PM +0100, Peter Maydell wrote: > > Date: Tue, 16 Apr 2024 14:27:45 +0100 > > From: Peter Maydell <peter.mayd...@linaro.org> > > Subject: Re: [PATCH] Add zh_TW Traditional Chinese translation > > > > On Tue, 16 Apr 2024 at 14:00, Peter Dave Hello <h...@peterdavehello.org> > > wrote: > > > > > > From: Peter Dave Hello <h...@peterdavehello.org> > > > Date: Tue, 16 Apr 2024 00:43:29 +0800 > > > Subject: [PATCH] Add a simple zh_TW Traditional Chinese translation > > > > > > This patch adds a basic zh_TW translation file for Taiwan Traditional > > > Chinese users. > > > > > > Signed-off-by: Peter Dave Hello <h...@peterdavehello.org> > > > > This name in your Signed-off-by line doesn't match the > > name you use in the .po file... > > > > > --- > > > po/LINGUAS | 1 + > > > po/zh_TW.po | 93 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > > > 2 files changed, 94 insertions(+) > > > create mode 100644 po/zh_TW.po > > > > > > diff --git a/po/LINGUAS b/po/LINGUAS > > > index 9b33a36..08163e8 100644 > > > --- a/po/LINGUAS > > > +++ b/po/LINGUAS > > > @@ -7,3 +7,4 @@ sv > > > tr > > > uk > > > zh_CN > > > +zh_TW > > > diff --git a/po/zh_TW.po b/po/zh_TW.po > > > new file mode 100644 > > > index 0000000..d25557e > > > --- /dev/null > > > +++ b/po/zh_TW.po > > > @@ -0,0 +1,93 @@ > > > +# Chinese translations for PACKAGE package. > > > +# Copyright (C) 2024 THE PACKAGE'S COPYRIGHT HOLDER > > > +# This file is distributed under the same license as the PACKAGE package. > > > > Can you replace all these placeholder ALLCAPS items > > with the right values, please? > > > > > +# Peter Hsu <h...@peterdavehello.org>, 2024. > > > +# > > Open source license is missing here. > > And I checked the other .po files and found that none of them declare > the open source license, are they missing it? Or does this case default > to "GPL-2.0-or-later"?
Best practice is for every file to mention its license, ideally using the "SPDX-Identifier" tag syntax for new files. If any file is missing a license header statement, then implicitly it falls under the LICENSE file rules, which is GPL-2.0-or-later. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
