On Tue, Apr 23, 2024 at 01:20:20PM +0100, Peter Maydell wrote:
> On Fri, 19 Apr 2024 at 16:59, Jean-Philippe Brucker
> <jean-phili...@linaro.org> wrote:
> >
> > The Realm Personalization Value (RPV) is provided by the user to
> > distinguish Realms that have the same initial measurement.
> >
> > The user provides up to 64 hexadecimal bytes. They are stored into the
> > RPV in the same order, zero-padded on the right.
> >
> > Cc: Eric Blake <ebl...@redhat.com>
> > Cc: Markus Armbruster <arm...@redhat.com>
> > Cc: Daniel P. Berrangé <berra...@redhat.com>
> > Cc: Eduardo Habkost <edua...@habkost.net>
> > Signed-off-by: Jean-Philippe Brucker <jean-phili...@linaro.org>
> > ---
> > v1->v2: Move parsing early, store as-is rather than reverted
> > ---
> > qapi/qom.json | 15 +++++-
> > target/arm/kvm-rme.c | 111 +++++++++++++++++++++++++++++++++++++++++++
> > 2 files changed, 125 insertions(+), 1 deletion(-)
> >
> > diff --git a/qapi/qom.json b/qapi/qom.json
> > index 623ec8071f..91654aa267 100644
> > --- a/qapi/qom.json
> > +++ b/qapi/qom.json
> > @@ -931,6 +931,18 @@
> > 'data': { '*cpu-affinity': ['uint16'],
> > '*node-affinity': ['uint16'] } }
> >
> > +##
> > +# @RmeGuestProperties:
> > +#
> > +# Properties for rme-guest objects.
> > +#
> > +# @personalization-value: Realm personalization value, as a 64-byte hex
> > string
> > +# (default: 0)
> > +#
> > +# Since: FIXME
> > +##
> > +{ 'struct': 'RmeGuestProperties',
> > + 'data': { '*personalization-value': 'str' } }
> >
> > ##
> > # @ObjectType:
> > @@ -1066,7 +1078,8 @@
> > 'tls-creds-x509': 'TlsCredsX509Properties',
> > 'tls-cipher-suites': 'TlsCredsProperties',
> > 'x-remote-object': 'RemoteObjectProperties',
> > - 'x-vfio-user-server': 'VfioUserServerProperties'
> > + 'x-vfio-user-server': 'VfioUserServerProperties',
> > + 'rme-guest': 'RmeGuestProperties'
> > } }
>
> This list is in alphabetical order. Are we obliged to add new
> items to the end for some compatibility reason, or should this new
> item be filed in its correct place with the other 'r's ?
Ordering has no bearing on compatibility, so this should be at the
correct alphbetical position.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
