Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 11:59:31AM +, Peter Maydell wrote: > On Sun, 13 Nov 2022 at 20:10, Michael Tokarev wrote: > > > > The upcoming capstone 5.0 drops support for the old way > > of including its header, due to this change: > > https://github.com/capstone-engine/capstone/commit/6656bcb63ab4

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Sun, Nov 13, 2022 at 11:09:42PM +0300, Michael Tokarev wrote: > The upcoming capstone 5.0 drops support for the old way > of including its header, due to this change: > https://github.com/capstone-engine/capstone/commit/6656bcb63ab4e87dc6079bd6b6b12cc8dd9b2ad8 > The official way is to use > >

Re: [PATCH v2] capstone: use instead of

2022-11-14 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 12:13:48PM +0300, Michael Tokarev wrote: > 14.11.2022 11:58, Daniel P. Berrangé wrote: > .. > > > On current systems, using works > > > now (despite the pkg-config-supplied -I/usr/include/capstone) - > > > since on all systems capst

Re: [PATCH v2] capstone: use instead of

2022-11-15 Thread Daniel P . Berrangé
On Mon, Nov 14, 2022 at 02:49:39PM +0100, Paolo Bonzini wrote: > Queued, thanks. I presume you have unqueued this patch again after the discussion yesterday ? With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

Re: Qemu virtual CPU limitation to 1024

2022-11-15 Thread Daniel P . Berrangé
On Tue, Nov 15, 2022 at 12:19:35AM +0100, Pawel Polawski wrote: > Hi Everyone, > > I am trying to check qemu virtual cpu boundaries when running a custom > edk2 based firmware build. For that purpose I want to run qemu with more > than 1024 vCPU: > $QEMU > -accel kvm > -m 4G > -M q35,kernel-irqchi

Re: [PATCH v4 4/7] target/arm: Enable TTBCR_EAE for ARMv8-R AArch32

2022-11-15 Thread Daniel P . Berrangé
On Tue, Nov 15, 2022 at 12:37:45PM +0100, Philippe Mathieu-Daudé wrote: > On 14/11/22 18:19, Peter Maydell wrote: > > On Sun, 23 Oct 2022 at 16:37, wrote: > > > > > > From: Tobias Röhmel > > > > > > ARMv8-R AArch32 CPUs behave as if TTBCR.EAE is always 1 even > > > tough they don't have the TTB

Re: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-15 Thread Daniel P . Berrangé
On Tue, Nov 15, 2022 at 06:25:27AM -0600, Or Ozeri wrote: > Starting from ceph Reef, RBD has built-in support for layered encryption, > where each ancestor image (in a cloned image setting) can be possibly > encrypted using a unique passphrase. > > A new function, rbd_encryption_load2, was added t

Re: [PULL 00/30] Next patches

2022-11-15 Thread Daniel P . Berrangé
Please don't merge this PULL request, It contains changes to the "io" subsystem in patch 3 that I have not reviewed nor acked yet, and which should be been split as a separate patch from the migration changes too. With regards, Daniel On Tue, Nov 15, 2022 at 04:34:44PM +0100, Juan Quintela wrote

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Daniel P . Berrangé
ntrol stream management remains > un-effected. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: manish.mishra > > v2: > TLS does not support MSG_PEEK, so V1 was broken for tls live > migrations. For tls live migration, while initializing main channel > tls handsha

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-15 Thread Daniel P . Berrangé
On Tue, Nov 15, 2022 at 06:11:30PM +, Daniel P. Berrangé wrote: > On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > > Current logic assumes that channel connections on the destination side are > > always established in the same order as the source and the

Re: biosbits test failing on origin/master

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 08:34:00AM +0530, Ani Sinha wrote: > On Wed, Nov 16, 2022 at 12:18 AM John Snow wrote: > > > > On Tue, Nov 15, 2022 at 9:31 AM Ani Sinha wrote: > > > > > > On Tue, Nov 15, 2022 at 3:36 PM Ani Sinha wrote: > > > > > > > > On Tue, Nov 15, 2022 at 9:07 AM Ani Sinha wrote: >

Re: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 09:03:31AM +, Or Ozeri wrote: > > -Original Message- > > From: Daniel P. Berrangé > > Sent: 15 November 2022 19:47 > > To: Or Ozeri > > Cc: qemu-devel@nongnu.org; qemu-bl...@nongnu.org; Danny Harnik > > ; idryo...@gmail.co

Re: [PATCH 1/2] crypto: TLS: introduce `check_pending`

2022-11-16 Thread Daniel P . Berrangé
igned-off-by: Antoine Damhet > --- > crypto/tlssession.c | 14 ++ > include/crypto/tlssession.h | 11 +++ > 2 files changed, 25 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr

Re: [PATCH 2/2] io/channel-tls: fix handling of bigger read buffers

2022-11-16 Thread Daniel P . Berrangé
; > Signed-off-by: Antoine Damhet > Signed-off-by: Charles Frey > --- > io/channel-tls.c | 66 +++- > 1 file changed, 65 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com

Re: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 10:23:52AM +, Daniel P. Berrangé wrote: > On Wed, Nov 16, 2022 at 09:03:31AM +, Or Ozeri wrote: > > > -Original Message- > > > From: Daniel P. Berrangé > > > Sent: 15 November 2022 19:47 > > > To: Or Ozeri &

Re: [PATCH v2] migration: check magic value for deciding the mapping of channels

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 04:49:18PM +0530, manish.mishra wrote: > > On 16/11/22 12:20 am, Daniel P. Berrangé wrote: > > On Tue, Nov 15, 2022 at 06:11:30PM +0000, Daniel P. Berrangé wrote: > > > On Mon, Nov 07, 2022 at 04:51:59PM +, manish.mishra wrote: > > >

Re: [PATCH] tests/avocado: using several workers while testing

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 04:48:10PM +0300, Pavel Dovgalyuk wrote: > From: bakulinm > > make check-avocado takes a lot of time, and avocado since version 91 has > multithreaded mode for running several tests simultaneously. > This patch allows to run "make check-avocado -j" to use all cores or, > f

Re: [PATCH] tests/avocado: using several workers while testing

2022-11-16 Thread Daniel P . Berrangé
On Wed, Nov 16, 2022 at 02:37:43PM +, bakul...@ispras.ru wrote: > Valid point, thank you. > > I can see three options what to do: > e1) Ignore older version of make and assume that 4.2 or newer is used > (4.1 is in Ubuntu 18.04 that is no longer supported as a build platform > as I was told; 2

[PATCH] ci: replace x86_64 macos-11 with aarch64 macos-12

2022-11-16 Thread Daniel P . Berrangé
aarch64 they only support macOS 12 onwards. At the same time our support policy only guarantees the most recent 2 major versions, so macOS 12 is already technically our min version. https://cirrus-ci.org/blog/2022/11/08/sunsetting-intel-macos-instances/ Signed-off-by: Daniel P. Berrangé

Re: [PATCH] acpi/tests/avocado/bits: don't remove the work directory when V is in env

2022-11-17 Thread Daniel P . Berrangé
On Thu, Nov 17, 2022 at 01:16:29PM +0530, Ani Sinha wrote: > Debugging bits issue often involves running the QEMU command line manually > outside of the avocado environment with the generated ISO. Hence, its > inconvenient if the iso gets cleaned up after the test has finished. This > change > mak

Re: [PATCH v3] block/rbd: Add support for layered encryption

2022-11-17 Thread Daniel P . Berrangé
On Thu, Nov 17, 2022 at 12:42:04PM +, Or Ozeri wrote: > > > > -Original Message- > > From: Daniel P. Berrangé > > Sent: 16 November 2022 13:15 > > To: Or Ozeri ; qemu-devel@nongnu.org; qemu- > > bl...@nongnu.org; Danny Harnik ; > > idr

Re: [PATCH v2] pc: q35: Bump max_cpus to 1024

2022-11-18 Thread Daniel P . Berrangé
On Fri, Nov 18, 2022 at 09:55:35AM +0100, Dario Faggioli wrote: > Keep the old limit of 288 for machine versions 7.2 and earlier. > > Signed-off-by: Dario Faggioli > --- > Cc: Paolo Bonzini > Cc: Richard Henderson > Cc: Eduardo Habkost > Cc: "Michael S. Tsirkin" > Cc: Marcel Apfelbaum > ---

Re: [PATCH v3] disas: recognize either or

2022-11-22 Thread Daniel P . Berrangé
n.build | 21 +++-- > 2 files changed, 16 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
d to io_readv calls to pass extra read flags like > MSG_PEEK. > > Suggested-by: Daniel P. Berrangé Signed-off-by: manish.mishra > --- > chardev/char-socket.c | 4 +- > include/io/channel.h| 83 + > io/channel-bu

Re: [PATCH v3 2/2] migration: check magic value for deciding the mapping of channels

2022-11-22 Thread Daniel P . Berrangé
ntrol stream management remains > un-effected. > > Suggested-by: Daniel P. Berrangé Signed-off-by: manish.mishra > --- > migration/migration.c| 44 +--- > migration/multifd.c | 12 --- > migration/multifd.h | 2 +- >

Re: [PATCH] multifd: Updated QAPI format for 'migrate' qemu monitor command

2022-11-22 Thread Daniel P . Berrangé
On Mon, Nov 21, 2022 at 01:40:27PM +0100, Juan Quintela wrote: > Het Gala wrote: > > To prevent double data encoding of uris, instead of passing transport > > mechanisms, host address and port all together in form of a single string > > and writing different parsing functions, we intend the user t

Re: [PATCH v2 2/7] multifd: modifying 'migrate' qmp command to add multifd socket on particular src and dest pair

2022-11-22 Thread Daniel P . Berrangé
On Mon, Nov 21, 2022 at 01:26:55PM +0100, Juan Quintela wrote: > Markus Armbruster wrote: > > Het Gala writes: > > > > Hi > > # Example: > # > -# -> { "execute": "migrate", "arguments": { "uri": "tcp:0:4446" } } > +# -> { "execute": "migrate", > +# "arguments

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > > > MSG_PEEK reads from the peek of channel, The data is treated as > > > unread

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote: > > On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > > > On Sat, Nov 19, 2022 a

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 03:43:55PM +0530, manish.mishra wrote: > > On 22/11/22 3:23 pm, Daniel P. Berrangé wrote: > > On Tue, Nov 22, 2022 at 03:10:53PM +0530, manish.mishra wrote: > > > On 22/11/22 2:59 pm, Daniel P. Berrangé wrote: > > > > On Tue, Nov 22, 2022 a

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 09:41:01AM -0500, Peter Xu wrote: > On Tue, Nov 22, 2022 at 02:38:53PM +0530, manish.mishra wrote: > > > > On 22/11/22 2:30 pm, Daniel P. Berrangé wrote: > > > On Sat, Nov 19, 2022 at 09:36:14AM +, manish.mishra wrote: > > > > MSG

Re: [PATCH] multifd: Updated QAPI format for 'migrate' qemu monitor command

2022-11-22 Thread Daniel P . Berrangé
On Tue, Nov 22, 2022 at 09:27:52PM +0530, manish.mishra wrote: > > On 22/11/22 2:53 pm, Daniel P. Berrangé wrote: > > For our future sanity I think we need to define a brand new migration > > protocol which is bidirectional from the start. A large number of the > > Migrat

Re: [PATCH v3 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-22 Thread Daniel P . Berrangé
at 11:10:18AM -0500, Peter Xu wrote: > > > > > On Tue, Nov 22, 2022 at 09:01:59PM +0530, manish.mishra wrote: > > > > > > On 22/11/22 8:19 pm, Daniel P. Berrangé wrote: > > > > > > > On Tue, Nov 22, 2022 at 09:41:01AM -0500, Pet

Re: [PATCH] multifd: Updated QAPI format for 'migrate' qemu monitor command

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 01:35:22AM +0530, Het Gala wrote: > > On 21/11/22 6:10 pm, Juan Quintela wrote: > > Het Gala wrote: > > > To prevent double data encoding of uris, instead of passing transport > > > mechanisms, host address and port all together in form of a single string > > > and writing

Re: [PATCH v2] Drop more useless casts from void * to pointer

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 02:51:49PM +0100, BALATON Zoltan wrote: > On Wed, 23 Nov 2022, Markus Armbruster wrote: > > Signed-off-by: Markus Armbruster > > Reviewed-by: Laurent Vivier > > --- > > v2: > > * PATCH 1+2 merged as commit 0a553c12c7 and 3f7febc937 > > * PATCH 3 change to util/coroutine-uc

Re: [PATCH v4 1/2] io: Add support for MSG_PEEK for socket channel

2022-11-23 Thread Daniel P . Berrangé
d to io_readv calls to pass extra read flags like > MSG_PEEK. > > Suggested-by: Daniel P. Berrangé Signed-off-by: manish.mishra > --- > chardev/char-socket.c | 4 ++-- > include/io/channel.h| 6 ++ > io/channel-buffer.c

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Daniel P . Berrangé
ntrol stream management remains > un-effected. > > Reviewed-by: Peter Xu > Reviewed-by: Daniel P. Berrangé Suggested-by: Daniel P. Berrangé Signed-off-by: manish.mishra > --- > migration/channel.c | 46 > mi

Re: [PATCH v4 2/2] migration: check magic value for deciding the mapping of channels

2022-11-23 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 09:34:35PM +0530, manish.mishra wrote: > > On 23/11/22 9:28 pm, Daniel P. Berrangé wrote: > > On Wed, Nov 23, 2022 at 03:05:27PM +, manish.mishra wrote: > > > Current logic assumes that channel connections on the destination side are > >

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-24 Thread Daniel P . Berrangé
On Wed, Nov 23, 2022 at 07:13:09PM +0100, Philippe Mathieu-Daudé wrote: > On 23/11/22 15:12, Alex Bennée wrote: > > Thomas Huth writes: > > > On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: > > > > On 18/11/22 12:33, Alex Bennée wrote: > > > > > The old URL wasn't stable. I suspect the current

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-24 Thread Daniel P . Berrangé
On Thu, Nov 24, 2022 at 09:20:36AM +0100, Thomas Huth wrote: > On 23/11/2022 19.13, Philippe Mathieu-Daudé wrote: > > On 23/11/22 15:12, Alex Bennée wrote: > > > Thomas Huth writes: > > > > On 23/11/2022 12.15, Philippe Mathieu-Daudé wrote: > > > > > On 18/11/22 12:33, Alex Bennée wrote: > > > > >

Re: [RFC PATCH] tests/avocado: use new rootfs for orangepi test

2022-11-24 Thread Daniel P . Berrangé
On Thu, Nov 24, 2022 at 12:06:10AM +0100, Philippe Mathieu-Daudé wrote: > On 23/11/22 19:49, Cédric Le Goater wrote: > > On 11/23/22 19:13, Philippe Mathieu-Daudé wrote: > > > On 23/11/22 15:12, Alex Bennée wrote: > > > > Thomas Huth writes: > > > > > On 23/11/2022 12.15, Philippe Mathieu-Daudé wr

Re: [PULL for 7.2-rc2 0/3] loongarch for 7.2-rc2 patches

2022-11-24 Thread Daniel P . Berrangé
On Thu, Nov 24, 2022 at 08:30:45PM +0800, gaos...@loongson.cn wrote: > > 在 2022/11/23 1:09, Stefan Hajnoczi 写道: > > Applied, thanks. > > > > Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any > > user-visible changes. > Hi,  Where can I register an account? Due to spam a

Re: [PATCH] tests/qtest/migration-test: Fix unlink error and memory leaks

2022-11-25 Thread Daniel P . Berrangé
/qtest/migration-test.c | 20 ++++++++---- > 1 file changed, 16 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https:/

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

2022-11-28 Thread Daniel P . Berrangé
On Mon, Nov 28, 2022 at 10:25:50AM +0100, Thomas Huth wrote: > Our release tarballs are huge - qemu-7.2.0-rc2.tar.xz has a size of 116 > MiB. If you look at the contents, approx. 80% of the size is used for the > firmware sources that we ship along to provide the sources for the ROM > binaries. Thi

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

2022-11-29 Thread Daniel P . Berrangé
On Mon, Nov 28, 2022 at 08:25:24PM +0100, Paolo Bonzini wrote: > Il lun 28 nov 2022, 18:04 Daniel P. Berrangé ha > scritto: > > > With my distro maintainer hat I would rather QEMU ship neither the > > ROM source, nor the ROM binaries. > > > > Annd since Q

Re: Who / what uses QMP command add_client?

2022-11-29 Thread Daniel P . Berrangé
On Tue, Nov 29, 2022 at 03:54:56PM +0100, Markus Armbruster wrote: > QMP command add_client's schema: > > ## > # @add_client: > # > # Allow client connections for VNC, Spice and socket based > # character devices to be passed in to QEMU via SCM_RIGHTS. > # > # @protocol

Re: Monitor commands related to display server passwords

2022-11-30 Thread Daniel P . Berrangé
On Wed, Nov 30, 2022 at 09:02:56AM +0100, Markus Armbruster wrote: > We have a couple of password-related commands, and I'm not sure about > which ones should be used. In order of appearance: > > * HMP change vnc > > Change a VNC server password. Unlike set_password below, there's no > way

Re: [PATCH v2 for-8.0 0/5] scripts/make-release: Decrease size of the release tarballs

2022-11-30 Thread Daniel P . Berrangé
On Wed, Nov 30, 2022 at 11:49:50AM +0100, Thomas Huth wrote: > On 28/11/2022 18.04, Daniel P. Berrangé wrote: > > On Mon, Nov 28, 2022 at 10:25:50AM +0100, Thomas Huth wrote: > > > Our release tarballs are huge - qemu-7.2.0-rc2.tar.xz has a size of 116 > > > MiB.

Re: Who / what uses QMP command add_client?

2022-11-30 Thread Daniel P . Berrangé
On Wed, Nov 30, 2022 at 01:30:43PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Tue, Nov 29, 2022 at 03:54:56PM +0100, Markus Armbruster wrote: > >> QMP command add_client's schema: > >> > >> ## > >> # @add_c

Re: Monitor commands related to display server passwords

2022-11-30 Thread Daniel P . Berrangé
On Wed, Nov 30, 2022 at 02:25:53PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > In 6.0 I introduced support for 'password-secret' to SPICE and VNC > > command line. > > > > I don't know why, but I only deprecated 'password'

Re: [PATCH 2/9] ui: Fix silent truncation of numeric keys in HMP sendkey

2022-12-01 Thread Daniel P . Berrangé
won't complain. > > Signed-off-by: Markus Armbruster > --- > monitor/hmp-cmds.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/

Re: [PATCH 1/9] ui: Check numeric part of expire_password argument @time properly

2022-12-01 Thread Daniel P . Berrangé
gt; > While there, use qemu_strtou64() instead of strtoull() so > checkpatch.pl won't complain. > > Aside: encoding numbers in strings is bad QMP practice. > > Signed-off-by: Markus Armbruster > --- > monitor/qmp-cmds.c | 17 +++-- > 1 file cha

Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV

2022-12-01 Thread Daniel P . Berrangé
On Thu, Dec 01, 2022 at 07:13:05AM +0100, Markus Armbruster wrote: > HMP "info spice" has a bit of code to show channel type > SPICE_CHANNEL_WEBDAV as "webdav", disabled since commit 7c6044a94e > "hmp: info spice: take out webdav" (v2.3.0), because it compiles only > with Spice versions 0.12.7 and

Re: [PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on

2022-12-01 Thread Daniel P . Berrangé
+-- > 2 files changed, 15 insertions(+), 13 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: htt

Re: [PATCH 5/9] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c

2022-12-01 Thread Daniel P . Berrangé
> ui/meson.build | 1 + > 3 files changed, 195 insertions(+), 177 deletions(-) > create mode 100644 ui/ui-qmp-cmds.c Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [PATCH 6/9] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c

2022-12-01 Thread Daniel P . Berrangé
-- > ui/ui-hmp-cmds.c | 360 + > ui/meson.build | 1 + > 3 files changed, 361 insertions(+), 342 deletions(-) > create mode 100644 ui/ui-hmp-cmds.c Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https

Re: [PATCH 7/9] ui: Improve "change vnc" error reporting

2022-12-01 Thread Daniel P . Berrangé
} > } else { > -monitor_printf(mon, "Expected 'password' after 'vnc'\n"); > +error_setg(&err, "Expected 'password' after 'vnc'"); > +goto end; > } > } else > #

Re: [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly

2022-12-01 Thread Daniel P . Berrangé
o stuff > > Signed-off-by: Markus Armbruster > --- > ui/ui-hmp-cmds.c | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dber

Re: [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c

2022-12-01 Thread Daniel P . Berrangé
insertions(+), 31 deletions(-) If you pull in the hmp_change_vnc impl from the previous patch Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fst

Re: Monitor commands related to display server passwords

2022-12-01 Thread Daniel P . Berrangé
On Wed, Nov 30, 2022 at 09:03:03AM +, Daniel P. Berrangé wrote: > On Wed, Nov 30, 2022 at 09:02:56AM +0100, Markus Armbruster wrote: > > Related: QCryptoSecret objects. > > snip > > > Currently used by various block backends and the tls-creds-x509 object. > >

[PATCH 1/3] block: mention 'password-secret' option for -iscsi

2022-12-01 Thread Daniel P . Berrangé
The 'password-secret' option was added commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API but was not mentioned in the command line docs Sig

[PATCH 0/3] More work on deprecation/removal of clear text passwords

2022-12-01 Thread Daniel P . Berrangé
This deprecates the -iscsi clear text 'password' option and deletes the previously deprecated -spice 'password' option. Daniel P. Berrangé (3): block: mention 'password-secret' option for -iscsi block: deprecate iSCSI 'password' in favour of 'passw

[PATCH 3/3] ui: remove deprecated 'password' option for SPICE

2022-12-01 Thread Daniel P . Berrangé
This has been replaced by the 'password-secret' option, which references a 'secret' object instance. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 8 docs/about/removed-features.rst | 7 +++ qemu-options.hx | 9 +-

[PATCH 2/3] block: deprecate iSCSI 'password' in favour of 'password-secret'

2022-12-01 Thread Daniel P . Berrangé
Support for referencing secret objects was added in commit b189346eb1784df95ed6fed610411dbf23d19e1f Author: Daniel P. Berrangé Date: Thu Jan 21 14:19:21 2016 + iscsi: add support for getting CHAP password via QCryptoSecret API The existing 'password' option is o

Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV

2022-12-01 Thread Daniel P . Berrangé
On Thu, Dec 01, 2022 at 01:39:13PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Dec 01, 2022 at 07:13:05AM +0100, Markus Armbruster wrote: > >> HMP "info spice" has a bit of code to show channel type > >> SPICE_CHANNEL_W

Re: [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV

2022-12-01 Thread Daniel P . Berrangé
On Thu, Dec 01, 2022 at 04:49:25PM +0100, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Thu, Dec 01, 2022 at 01:39:13PM +0100, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Thu, Dec 01, 2022 at 07:13:05AM +

Re: [PATCH v2 03/14] ui/spice: Require spice-protocol >= 0.14.0

2022-12-05 Thread Daniel P . Berrangé
>OpenSUSE Leap 15.3: 0.14.3 > > Requiring it lets us drop two version checks in ui/vdagent.c. It also > enables the next commit. > > Signed-off-by: Markus Armbruster > --- > meson.build | 2 +- > ui/vdagent.c | 4 > 2 files changed, 1 insertion(+), 5

Re: [PATCH v2 04/14] Revert "hmp: info spice: take out webdav"

2022-12-05 Thread Daniel P . Berrangé
in. > > Signed-off-by: Markus Armbruster > --- > monitor/hmp-cmds.c | 5 - > 1 file changed, 5 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.or

Re: [PATCH v2 05/14] ui/spice: Require spice-server >= 0.14.0

2022-12-05 Thread Daniel P . Berrangé
; include/ui/qemu-spice.h| 6 +- > include/ui/spice-display.h | 2 -- > chardev/spice.c| 2 -- > hw/display/qxl.c | 7 +-- > 6 files changed, 3 insertions(+), 18 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.c

Re: [PATCH v2 06/14] ui/spice: QXLInterface method set_mm_time() is now dead, drop

2022-12-05 Thread Daniel P . Berrangé
e-display.c | 10 -- > hw/display/trace-events | 1 - > 4 files changed, 32 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-ht

Re: [PATCH 1/2] util/bufferiszero: Use __attribute__((target)) for avx2/avx512

2022-12-05 Thread Daniel P . Berrangé
On Sat, Dec 03, 2022 at 07:51:22PM -0600, Richard Henderson wrote: > Use the attribute, which is supported by clang, instead of > the #pragma, which is not supported and, for some reason, > also not detected by the meson probe, so we fail by -Werror. > > Signed-off-by: Richard Henderson > --- >

Re: [PATCH 1/1] Add AVX512 support for xbzrle_encode_buffer function

2022-07-21 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 04:02:49PM +, Zhao, Zhou wrote: > Hi dainel: > Cause our code depend on intel intrinsics lib implement. And > this lib depend on macro like " AVX512BW ". This macro need > compile time check to enable some machine options . if you only > use that utility to do runtime

Re: [PATCH v2 1/1] python/machine: Fix AF_UNIX path too long on macOS

2022-07-22 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 07:44:21PM -0700, Peter Delevoryas wrote: > On Mon, Jul 18, 2022 at 09:56:17AM +0100, Daniel P. Berrangé wrote: > > On Sat, Jul 16, 2022 at 10:34:34AM -0700, Peter Delevoryas wrote: > > > On macOS, private $TMPDIR's are the default. These $TMPDIR

Re: [PATCH 1/1] Add AVX512 support for xbzrle_encode_buffer function

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 02:23:13AM +, Zhao, Zhou wrote: > 1 we need gcc machined options to tirgger gcc enable SIMD > instructions(https://gcc.gnu.org/onlinedocs/gcc/x86-Options.html). > Or it will trigger a compile error. This is the reason why we > change the config file. Take a look at util

Re: [PATCH 1/3] tests: refresh to latest libvirt-ci module

2022-07-22 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 10:01:28AM +0200, Thomas Huth wrote: > On 20/07/2022 18.51, Daniel P. Berrangé wrote: > > Notable changes: > > > >- libvirt-ci source tree was re-arranged, so script we must > > run now lives in a bin/ sub-dir > > Sentence har

[PATCH v2 0/3] target: RFC: display deprecation flag for '-cpu help'

2022-07-22 Thread Daniel P . Berrangé
endantly though, and unifying that code is not entirely straightforward. Changed in v2: - Just include "deprecated" as a flag, not full description which made the output too verbose and long lines. Daniel P. Berrangé (3): target/i386: display deprecation status in '-cp

[PATCH v2 1/3] target/i386: display deprecation status in '-cpu help'

2022-07-22 Thread Daniel P . Berrangé
When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Signed-off-by: Daniel P. Berrangé --- target/i386/cpu.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/i386/cpu.c b/tar

[PATCH v2 3/3] target/arm: display deprecation status in '-cpu help'

2022-07-22 Thread Daniel P . Berrangé
When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Signed-off-by: Daniel P. Berrangé --- target/arm/helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/t

[PATCH v2 2/3] target/s390x: display deprecation status in '-cpu help'

2022-07-22 Thread Daniel P . Berrangé
When the user queries CPU models via QMP there is a 'deprecated' flag present, however, this is not done for the CLI '-cpu help' command. Signed-off-by: Daniel P. Berrangé --- target/s390x/cpu_models.c | 23 ++- 1 file changed, 18 insertions(+), 5 deleti

[PATCH v2 0/3] ci: refresh packages/containers and misc changes

2022-07-22 Thread Daniel P . Berrangé
Mostly this is to get the latest libvirt-ci content pulled in, but I throw two small fixes on top. Changed in v2: - Reworded various bits of the commit message for first patch Daniel P. Berrangé (3): tests: refresh to latest libvirt-ci module gitlab: show testlog.txt contents when

[PATCH v2 3/3] gitlab: drop 'containers-layer2' stage

2022-07-22 Thread Daniel P . Berrangé
Since we express dependancies via a 'needs' clause, we don't need to split container builds into separate stages. GitLab happily lets jobs depend on other jobs in the same stage and will run them when possible. Acked-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- .gitlab

[PATCH v2 1/3] tests: refresh to latest libvirt-ci module

2022-07-22 Thread Daniel P . Berrangé
glibc on all distros - The cmocka/json-c deps that were manually added to the centos dockerfile and are now consistently added to all targets Acked-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/freebsd-12.vars | 3 +-- .gitlab-ci.d/ci

[PATCH v2 2/3] gitlab: show testlog.txt contents when cirrus/custom-runner jobs fail

2022-07-22 Thread Daniel P . Berrangé
failure, to give maintainers a fighting chance of diagnosing the problem. Reviewed-by: Thomas Huth Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/build.yml| 3 ++- .../custom-runners/centos-stream-8-x86_64.yml| 2 ++ .gitlab-ci.d/custom-runners/ubuntu

Re: [PATCH v2 1/2] migration-test: Use migrate_ensure_converge() for auto-converge

2022-07-22 Thread Daniel P . Berrangé
: Daniel P. Berrange > Reported-by: Thomas Huth > Signed-off-by: Peter Xu > --- > tests/qtest/migration-test.c | 17 + > 1 file changed, 1 insertion(+), 16 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-h

Re: [PATCH] trivial: Fix duplicated words

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 04:58:59PM +0200, Thomas Huth wrote: > Some files wrongly contain the same word twice in a row. > One of them should be removed or replaced. > > Signed-off-by: Thomas Huth > --- > Removing duplicated words seems to be the new hip trend on the > Linux kernel mailing lists

Re: [PATCH v2 2/2] migration-test: Allow test to run without uffd

2022-07-22 Thread Daniel P . Berrangé
u > --- > tests/qtest/migration-test.c | 48 +++- > 1 file changed, 25 insertions(+), 23 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.

Re: [PATCH] trivial: Fix duplicated words

2022-07-22 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 05:07:08PM +0200, Thomas Huth wrote: > On 22/07/2022 17.03, Daniel P. Berrangé wrote: > > On Fri, Jul 22, 2022 at 04:58:59PM +0200, Thomas Huth wrote: > > > Some files wrongly contain the same word twice in a row. > > > One of them sh

Re: [PATCH v3 1/1] python/machine: Fix AF_UNIX path too long on macOS

2022-07-25 Thread Daniel P . Berrangé
nge.com/questions/353832/why-is-mac-osx-temp-directory-in-weird-path > [2] > /Library/Developer/CommandLineTools/SDKs/MacOSX12.3.sdk/usr/include/sys/un.h > > Signed-off-by: Peter Delevoryas > --- > python/qemu/machine/machine.py | 6 +++--- > tests/avocado/avocado_q

Re: [PATCH for-7.2 00/10] add hmp 'save-fdt' and 'info fdt' commands

2022-07-25 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 04:59:57PM -0300, Daniel Henrique Barboza wrote: > Hi, > > After dealing with a FDT element that isn't being shown in the userspace > and having to shutdown the guest, dump the FDT using 'machine -dumpdtb' and > then using 'dtc' to see what was inside the FDT, I thought it

Re: driver type raw-xz supports discard=unmap?

2022-07-25 Thread Daniel P . Berrangé
On Fri, Jul 22, 2022 at 04:03:52PM -0400, Chris Murphy wrote: > Is this valid? > > ` > > > ` > `/> > ` > > I know type="raw" works fine, I'm wondering if there'd be any problem > with type "raw-xz" combined with discards? This is libvirt configuration, so libvirt-us...@redhat.com is the better

Re: [PATCH] linux-user: Don't assume 0 is not a valid host timer_t value

2022-07-25 Thread Daniel P . Berrangé
On Mon, Jul 25, 2022 at 12:00:35PM +0100, Peter Maydell wrote: > For handling guest POSIX timers, we currently use an array > g_posix_timers[], whose entries are a host timer_t value, or 0 for > "this slot is unused". When the guest calls the timer_create syscall > we look through the array for a

Re: [PATCH v2 0/3] python/qemu/machine: fix potential hang in QMP accept

2022-07-25 Thread Daniel P . Berrangé
to https://gitlab.com/qemu-project/python-qemu-qmp ? > > > > > Ok > > > > (I'll review them in the meantime on-list just in the interest of > > moving things along.) > > > > I was waiting for a review before updating the patches / moving to > python-qemu-qmp. This code looks decent to me Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 3/3] python/qemu/machine: use socketpair() for QMP by default

2022-07-25 Thread Daniel P . Berrangé
On Thu, Jun 30, 2022 at 04:34:19PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > When no monitor address is given, establish the QMP communication through > a socketpair() (API is also supported on Windows since Python 3.5) > > Signed-off-by: Marc-André Lureau > --- >

Re: driver type raw-xz supports discard=unmap?

2022-07-25 Thread Daniel P . Berrangé
On Mon, Jul 25, 2022 at 08:51:42AM -0400, Chris Murphy wrote: > > > On Mon, Jul 25, 2022, at 5:13 AM, Daniel P. Berrangé wrote: > > On Fri, Jul 22, 2022 at 04:03:52PM -0400, Chris Murphy wrote: > >> Is this valid? > >> > >> ` > >> > >>

Re: [PATCH for-7.2 00/10] add hmp 'save-fdt' and 'info fdt' commands

2022-07-25 Thread Daniel P . Berrangé
On Mon, Jul 25, 2022 at 10:16:11AM -0300, Daniel Henrique Barboza wrote: > > > On 7/25/22 06:11, Daniel P. Berrangé wrote: > > On Fri, Jul 22, 2022 at 04:59:57PM -0300, Daniel Henrique Barboza wrote: > > > Hi, > > > > > > After dealing with a FDT eleme

Re: [PULL 06/18] vfio-user: build library

2022-07-25 Thread Daniel P . Berrangé
updated. That sounds good, thank you. We should be fine to get the submodule reefreshed even in soft freeze, given that it is fixing a test failure bug. Oh and I just noticed I messed up your name in my message below. I'm very sorry about that. With regards, Daniel > On Jul 21, 2022, a

Re: [PATCH] RFC: char: deprecate usage of bidirectional pipe

2022-07-26 Thread Daniel P . Berrangé
On Tue, Jul 26, 2022 at 12:32:32PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > As Ed Swierk explained back in 2006: > https://lists.nongnu.org/archive/html/qemu-devel/2006-12/msg00160.html > > "When qemu writes into the pipe, it immediately reads back what it just > w

Re: [PATCH v2 5/7] multifd: establishing connection between any non-default src and dest pair

2022-07-26 Thread Daniel P . Berrangé
In $SUBJECT s/multifd:/io:/ as this is not migration related. On Thu, Jul 21, 2022 at 07:56:18PM +, Het Gala wrote: > i) Binding of the socket to source ip address and port on the non-default >interface has been implemented for multi-FD connection, which was not >necessary earlier

Re: [PATCH v2 2/7] multifd: modifying 'migrate' qmp command to add multifd socket on particular src and dest pair

2022-07-26 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 07:56:15PM +, Het Gala wrote: > i) Modified the format of the qemu monitor command : 'migrate' by adding a > list, >each element in the list consisting of multifd connection parameters: > source >uri, destination uri and of the number of multifd channels betwee

Re: [PATCH v2 3/7] multifd: adding multi-interface support for multifd on destination side

2022-07-26 Thread Daniel P . Berrangé
On Thu, Jul 21, 2022 at 07:56:16PM +, Het Gala wrote: > i) Modified the format of qemu monitor command: 'migrate-incoming' by adding >a list, each element in the list to open socket listeners with a given >number of multifd channels. > > ii) Qemu starts with -incoming flag defer and -m

  1   2   3   4   5   6   7   8   9   10   >