On Mon, Jul 25, 2022 at 03:23:26PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Fri, Jul 1, 2022 at 2:51 AM John Snow <js...@redhat.com> wrote:
>
> > On Thu, Jun 30, 2022 at 8:34 AM <marcandre.lur...@redhat.com> wrote:
> > >
> > > From: Marc-André Lureau <marcandre.lur...@redhat.com>
> > >
> > > Hi,
> > >
> > > As reported earlier by Richard Henderson ("virgl avocado hang" thread),
> > avocado
> > > tests may hang when QEMU exits before the QMP connection is established.
> > >
> > > v2:
> > > - use a socketpair() for QMP (instead of async concurrent code from v1)
> > as
> > > suggested by Daniel Berrange.
> > > - should not regress (hopefully)
> > >
> > > Marc-André Lureau (3):
> > > python/qmp/protocol: add open_with_socket()
> > > python/qmp/legacy: make QEMUMonitorProtocol accept a socket
> > > python/qemu/machine: use socketpair() for QMP by default
> > >
> > > python/qemu/machine/machine.py | 24 ++++++++++++++++--------
> > > python/qemu/qmp/legacy.py | 18 +++++++++++++++---
> > > python/qemu/qmp/protocol.py | 25 ++++++++++++++++++++-----
> > > 3 files changed, 51 insertions(+), 16 deletions(-)
> > >
> > > --
> > > 2.37.0.rc0
> > >
> >
> > For anything that touches python/qemu/qmp/*, may I please ask that you
> > submit them to https://gitlab.com/qemu-project/python-qemu-qmp ?
> >
> >
> Ok
>
>
> > (I'll review them in the meantime on-list just in the interest of
> > moving things along.)
> >
>
> I was waiting for a review before updating the patches / moving to
> python-qemu-qmp.
This code looks decent to me
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
