I'm also having issues with libvirt/kvm guests becoming unresponsive and
they were all using cirrus as their video model. I've tried switching
some to vga to see if that helps.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://b
Serge, I asked Alex to escalate this because it has required us to make
a devirtualised PPA for a commercial project that involves libreoffice
builds. This has some risk of being an operational problem, because
it's going to be using Ubuntu build resources rather than the usual PPA
ones. I'd appr
I believe that this is with qemu 1.3.0+dfsg-1~exp3ubuntu8~3.IS.12.04 and
Linux 2.6.24-32-xen.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1129571
Title:
libreoffice armhf FTBFS
Status in QEMU:
** Tags added: qemu-user-ubuntu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1077116
Title:
automoc4 segfaults when building in an armhf pbuilder on an amd64 host
Status in QEMU:
New
Status in
** Tags added: qemu-user-ubuntu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1129571
Title:
libreoffice armhf FTBFS
Status in QEMU:
New
Status in “qemu” package in Ubuntu:
Confirmed
Bug desc
Linux 3.14. Level interrupt
handling hasn't been tested.
Signed-off-by: Colin Leitner
---
hw/gpio/pl061.c | 59 ++-
1 file changed, 45 insertions(+), 14 deletions(-)
diff --git a/hw/gpio/pl061.c b/hw/gpio/pl061.c
index dd4ea29..bd03e99 1
Peter: While this is true, is it actually likely to happen? I thought
in our conversations in the past (when I previously attempted to
escalate this class of problems via Linaro) it had been fairly clear
that this was a very difficult task that isn't likely to be scheduled
for the foreseeable futu
Right, I can absolutely understand that. The question would I suppose
be whether you think this is a completely unreasonable thing to put in a
distro patch; I think SUSE are doing so for basically the same reason we
would be, that is, a setup such as PPAs where virtualisation isn't
available direc
** Tags added: qemu-user-ubuntu
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1084148
Title:
Qt5 Beta 1 QProcess start and execute causes segmentation fault on
armhf
Status in QEMU:
New
Status
Public bug reported:
When launching qemu on OSX (10.8.5), the window comes up in the
background. A bit of googling shows that the addition of [NSApp
activateIgnoringOtherApps:YES]; before the [NSApp run]; in main fixes
this.
** Affects: qemu
Importance: Undecided
Status: New
** T
Reviewed-by: Peter Crosthwaite
Signed-off-by: Colin Leitner
---
hw/arm/xilinx_zynq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 06e6e24..6d8c0d9 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -202,6 +202,8
Hello everyone,
this is the fourth version of the Zynq GPIO model patch. It includes
* removal of unneeded memset in zynq_gpio_realize
* some minor code cleanup
* fixes for all remaining checkpatch warnings (lines too long)
Regards,
Colin
Colin Leitner (2):
zynq_gpio: GPIO model
: Peter Crosthwaite
Signed-off-by: Colin Leitner
---
hw/gpio/Makefile.objs |1 +
hw/gpio/zynq-gpio.c | 413 +++
include/hw/gpio/zynq-gpio.h | 79 +
3 files changed, 493 insertions(+)
create mode 100644 hw/gpio/zynq-gpio.c
create
Hello everyone,
I wrote the Zynq GPIO model a while ago and it proved useful in an internal
project, so maybe others will find it useful too.
Cheers,
Colin
Colin Leitner (2):
zynq_gpio: GPIO model for Zynq SoC
xilinx_zynq: Add zynq_gpio to the machine
hw/arm/xilinx_zynq.c |2
Signed-off-by: Colin Leitner
---
hw/arm/xilinx_zynq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 06e6e24..6d8c0d9 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -202,6 +202,8 @@ static void zynq_init(MachineState
3
Basic I/O tested with the Zynq GPIO driver in Linux 3.12.
Signed-off-by: Colin Leitner
---
hw/gpio/Makefile.objs |1 +
hw/gpio/zynq_gpio.c | 441 +
2 files changed, 442 insertions(+)
create mode 100644 hw/gpio/zynq_gpio.c
diff --git a/hw
nq_gpio_reset(s);
>
> Don't reset in init fns. You shuold use a device-reset function ...
Another 1:1 copy from pl061. I'll take the time to read up how the
device model is meant to be implemented correctly.
Thanks again for the review and you'll hear from me shortly.
Regards,
Colin
to set the opaque data to another
value.
I retested basic I/O on different banks and IRQ handling. Both with the stock
Linux 3.12 driver.
Cheers,
Colin
Colin Leitner (2):
zynq_gpio: GPIO model for Zynq SoC
xilinx_zynq: Add zynq-gpio to the machine
hw/arm/xilinx_zynq.c |2
Signed-off-by: Colin Leitner
---
hw/arm/xilinx_zynq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 06e6e24..6d8c0d9 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -202,6 +202,8 @@ static void zynq_init(MachineState
: Colin Leitner
---
hw/gpio/Makefile.objs |1 +
hw/gpio/zynq-gpio.c | 386 +
hw/gpio/zynq-gpio.h | 79 ++
3 files changed, 466 insertions(+)
create mode 100644 hw/gpio/zynq-gpio.c
create mode 100644 hw/gpio/zynq-gpio.h
diff
sets the IRQ output
lines to 0.
Regards,
Colin
Colin Leitner (2):
zynq_gpio: GPIO model for Zynq SoC
xilinx_zynq: Add zynq-gpio to the machine
hw/arm/xilinx_zynq.c|2 +
hw/gpio/Makefile.objs |1 +
hw/gpio/zynq-gpio.c | 402
Signed-off-by: Colin Leitner
---
hw/arm/xilinx_zynq.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c
index 06e6e24..6d8c0d9 100644
--- a/hw/arm/xilinx_zynq.c
+++ b/hw/arm/xilinx_zynq.c
@@ -202,6 +202,8 @@ static void zynq_init(MachineState
: Colin Leitner
---
hw/gpio/Makefile.objs |1 +
hw/gpio/zynq-gpio.c | 402 +++
include/hw/gpio/zynq-gpio.h | 79 +
3 files changed, 482 insertions(+)
create mode 100644 hw/gpio/zynq-gpio.c
create mode 100644 include/hw/gpio
We're now building armhf/arm64 packages on real arm64 hardware in
Launchpad, so, while this problem may well still exist in qemu, it no
longer applies to Launchpad builds.
** Changed in: launchpad-buildd
Status: Triaged => Won't Fix
--
You received this bug notification because you are a
Returns negative error codes and accompanying error messages in cases where
the device has no tray or the tray is locked and isn't forced open. This
extra information should result in better flexibility in functions that
call do_open_tray.
Signed-off-by: Colin Lord
---
v2: fix fun
Returns negative error codes and accompanying error messages in cases where
the device has no tray or the tray is locked and isn't forced open. This
extra information should result in better flexibility in functions that
call do_open_tray.
Signed-off-by: Colin Lord
Suggested by: M
This commit causes qmp_blockdev_change_medium to report an error if an
attempt is made to open a device with a locked tray.
Signed-off-by: Colin Lord
This is based off my previous patch regarding the do_open_tray function
(currently at v3). Probably should have been submitted as a patch set
but
When opening a device with a locked tray, gives an error explaining the
device tray is locked and that the user should wait and try again. This
is less confusing than the previous error, which simply stated that the
tray was locked.
Signed-off-by: Colin Lord
---
Reworded commit message to
This is a repost of some previous patches written by Marc Marí which
were also reposted by Richard Jones a few months ago. The original
series and reposted series are here:
https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01995.html
https://lists.nongnu.org/archive/html/qemu-devel/2016-04/
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
include/qemu/module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin
been disabled as a module.
All the necessary module information is located in a new structure found in
include/qemu/module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Makefile | 3 --
block.c
On 06/16/2016 12:59 AM, Fam Zheng wrote:
> On Wed, 06/15 14:40, Colin Lord wrote:
>> From: Marc Mari
>>
>> To simplify the addition of new block modules, add a script that generates
>> include/qemu/module_block.h automatically from the modules' source code.
>>
On 06/15/2016 06:50 PM, Paolo Bonzini wrote:
>
>
> On 15/06/2016 20:40, Colin Lord wrote:
>>
>> The only block drivers that can be converted into modules are the drivers
>> that don't perform any init operation except for registering themselves. This
>>
On 06/16/2016 10:05 AM, Paolo Bonzini wrote:
>
>
> On 16/06/2016 16:00, Colin Lord wrote:
>>>>> The only block drivers that can be converted into modules are the drivers
>>>>> that don't perform any init operation except for registering themselves
On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>> 1) Denis Lunev suggested having block_module_load_one return the
>> loaded driver to reduce duplicated for loops in many of the functions
>> in block.c. I'
On 06/21/2016 05:32 AM, Stefan Hajnoczi wrote:
> On Mon, Jun 20, 2016 at 11:32:38AM -0400, Colin Lord wrote:
>> On 06/17/2016 05:54 AM, Stefan Hajnoczi wrote:
>>> On Wed, Jun 15, 2016 at 02:40:53PM -0400, Colin Lord wrote:
>>>> 1) Denis Lunev suggested having bl
en't any messages about the driver not being found.
That hopefully explains some of the issues, and why I'm submitting this
with the duplicated loops still intact. If there are other ideas for
dealing with this my ears are open, but this is what I have for now.
Colin Lord (1):
blockdev:
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
include/qemu/module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Mari
Signed-off-by: Colin
o the main binary.
Signed-off-by: Colin Lord
---
block/iscsi.c | 36
vl.c | 36
2 files changed, 36 insertions(+), 36 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 7e78ade..6193499 100644
--- a/
odule information is located in a new structure found in
include/qemu/module_block.h
Signed-off-by: Marc Mari
Signed-off-by: Colin Lord
---
Makefile | 3 --
block.c | 86 +--
include/qemu/module.h | 3 ++
util/module.c
On 06/22/2016 05:35 PM, Colin Lord wrote:
> This is v2 of the series I sent out last week. These are the changes I
> made based on the feedback I got:
> - Fixed typo and Marc's email address in the python script
> - Moved registration of iscsi_opts into vl.c
>
> What I did
On 06/22/2016 09:22 PM, Fam Zheng wrote:
> On Wed, 06/22 17:35, Colin Lord wrote:
>> This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
>> struct out of block/iscsi.c in order to allow it to be dynamically
>> loaded. Drivers that perform init operations o
cc more.
On 2019-06-10 10:19, Colin Xu wrote:
QEMU tracks whether a vcpu is halted using CPUState::halted. E.g.,
after initialization or reset, halted is 0 for the BSP (vcpu 0)
and 1 for the APs (vcpu 1, 2, ...). A halted vcpu should not be
handed to the hypervisor to run (e.g. hax_vcpu_run
android emulator with Change-Id:
I9c5752cc737fd305d7eace1768ea12a07309d716
Cc: Yu Ning
Cc: Chuanxiao Dong
Signed-off-by: Colin Xu
---
cpus.c| 1 -
target/i386/hax-all.c | 36 ++--
2 files changed, 34 insertions(+), 3 deletions(-)
diff --git a/cpus.c b/cpus.c
index ffc57119ca5e..
HAXM covers below files:
include/sysemu/hax.h
target/i386/hax-*
Cc: Wenchao Wang
Cc: Hang Yuan
Signed-off-by: Colin Xu
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 588c8d947a08..fccae4e7de48 100644
--- a/MAINTAINERS
+++ b
On Tue, Sep 27, 2022, at 1:27 PM, German Maglione wrote:
>
>> > Now all the development has moved to rust virtiofsd.
Oh, awesome!! The code there looks great.
> I could work on this for the next major version and see if anything breaks.
> But I prefer to add this as a compilation feature, ins
On Wed, Sep 28, 2022, at 3:28 PM, Vivek Goyal wrote:
> Sounds reasonable. In fact, we could probably do someting similar
> for "landlock" as well.
Thanks for the discussion all! Can someone (vaguely) commit to look into this
in say the next few months? It's not *urgent*, we can live with the
On Thu, Sep 29, 2022, at 10:10 AM, Vivek Goyal wrote:
> What's your use case. How do you plan to use virtiofs.
At the current time, the Kubernetes that we run does not support user
namespaces. We want to do the production builds of our operating system
(Fedora CoreOS and RHEL CoreOS) today
On Thu, Sep 29, 2022, at 1:03 PM, Vivek Goyal wrote:
>
> So rust version of virtiofsd, already supports running unprivileged
> (inside a user namespace).
I know, but as I already said, the use case here is running inside an OpenShift
unprivileged pod where *we are already in a container*.
>
We previously had a chat here
https://lore.kernel.org/all/348d4774-bd5f-4832-bd7e-a21491fda...@www.fastmail.com/T/
around virtiofsd and privileges and the case of trying to run virtiofsd inside
an unprivileged (Kubernetes) container.
Right now we're still using 9p, and it has bugs (basically it
a new structure found in
module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
block.c | 37 +++--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c | 38 +++---
4 files ch
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (1):
blockdev: prepare iSCSI block driver for dynamic loading
Marc Mari (2):
blockdev: Add dy
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
On 07/23/2016 02:21 PM, Max Reitz wrote:
> On 20.07.2016 16:30, Colin Lord wrote:
>> Here's v5 of the modularization series. Since it seems the concensus is
>> that modularizing the format drivers is unnecessary, this series no
>> longer modularizes those and is thu
Updates the messages displayed in the help option to reflect that GTK is
the default display, not SDL.
---
qemu-options.hx | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 8e0d9a5..5bec1d3 100644
--- a/qemu-options.hx
+++
Removes some superfluous lines from the Makefile which should have been
removed as part of the patch series to add dynamic loading for block
driver modules.
Signed-off-by: Colin Lord
---
Makefile | 3 ---
1 file changed, 3 deletions(-)
diff --git a/Makefile b/Makefile
index 4b9384e..c7aa8cd
protocol block driver that links to external libraries that
has not been modularized (once my last patch set is applied).
Colin Lord (2):
blockdev: Remove unnecessary lines from Makefile
blockdev: Modularize nfs block driver
Makefile| 3 ---
block/Makefile.objs | 1 +
configure
Modularizes the nfs block driver so that it gets dynamically loaded.
Signed-off-by: Colin Lord
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
har *dirs[3];
> int i = 0;
> @@ -181,6 +184,9 @@ static void module_load(module_init_type type)
> case MODULE_INIT_BLOCK:
> mp = block_modules;
> break;
> +case MODULE_INIT_SDL:
> +mp = sdl_modules;
> + break;
> default:
> /* no other types have dynamic modules for now*/
> return;
> diff --git a/vl.c b/vl.c
> index a455947..fdbbe47 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -4221,7 +4221,10 @@ int main(int argc, char **argv, char **envp)
> }
>
> if (display_type == DT_SDL) {
> -sdl_display_early_init(request_opengl);
> +if (!sdl_display_early_init(request_opengl)) {
> +error_report("Failed to initialize SDL");
> +exit(1);
> +}
> }
>
> if (request_opengl == 1 && display_opengl == 0) {
>
Maybe I'm doing something wrong, but when I apply this third patch
(along with the first two) to master it doesn't seem to build when
modules are enabled in the configuration:
LINK x86_64-softmmu/qemu-system-x86_64
../backends/baum.o: In function `chr_baum_init':
/home/bos/clord/Documents/qemu/backends/baum.c:616: undefined reference
to `SDL_GetWMInfo'
collect2: error: ld returned 1 exit status
Makefile:197: recipe for target 'qemu-system-x86_64' failed
make[1]: *** [qemu-system-x86_64] Error 1
Makefile:204: recipe for target 'subdir-x86_64-softmmu' failed
make: *** [subdir-x86_64-softmmu] Error 2
Colin
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Mak
nd
in module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
---
Makefile | 3 ---
block.c | 62 +--
block/Makefile.objs | 3 +--
include/qemu/module.h | 3 +++
util/module.c
Modularizes the nfs block driver so that it gets dynamically loaded.
---
block/Makefile.objs | 1 +
configure | 4 ++--
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/block/Makefile.objs b/block/Makefile.objs
index 595f366..fa4d8b8 100644
--- a/block/Makefile.objs
+++ b/b
On 08/02/2016 10:12 AM, Colin Lord wrote:
> I'm sending one more version of this series. v5 didn't seem to need any
> huge makeovers, but I found a small bug in it so I'm hoping it hasn't
> been committed yet. In v5, if a user explicitly specified the driver to
>
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
ey follow the naming
pattern of format-probe.c
- Renamed crypto probe file to be crypto-probe.c, luks is no longer in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_pro
le loading for
block drivers'.
Colin Lord (1):
gtk: Modularize GTK display
Fam Zheng (1):
rules.mak: Don't extract libs from .mo-libs in link command
Makefile.objs| 1 +
configure| 5 ++--
include/ui/console.h | 6 +
rules.mak| 2
None.
This should give improvements in terms of performance, since much less
libraries will be loaded at startup if GTK is not being used, and in
terms of packaging, since GTK should be able to be packaged separately
in binary package managers now.
Signed-off-by: Colin Lord
---
Makefile.objs
link command incorrectly,
spoiling the purpose of modularization.
Currently we don't have any .mo-libs usage, but it will be used soon
when we modularize more multi-source objects, like sdl and gtk.
Reported-by: Colin Lord
Signed-off-by: Fam Zheng
---
rules.mak | 2 +-
1 file chang
Updates the help messages to reflect that GTK is the default display (if
enabled), not SDL.
Signed-off-by: Colin Lord
---
v2: Update to try to implement Paolo's suggested wordings. It looks to
me like the subsections get wrapped at 72 lines, which mean there was a
bit of a ripple effec
On 07/06/2016 09:17 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> From: Marc Mari
>>
>> To simplify the addition of new block modules, add a script that generates
>> module_block.h automatically from the modules' source code.
>>
>> Th
On 07/06/2016 11:59 AM, Max Reitz wrote:
> On 05.07.2016 17:24, Colin Lord wrote:
>> Modifies the bochs probe to return the format name as well as the
>> score as the final step of separating the probe function from the
>> driver. This keeps the probe completely inde
On 07/06/2016 04:24 AM, Kevin Wolf wrote:
> Am 05.07.2016 um 22:50 hat John Snow geschrieben:
>>
>>
>> On 07/05/2016 11:49 AM, Daniel P. Berrange wrote:
>>> On Tue, Jul 05, 2016 at 11:24:04AM -0400, Colin Lord wrote:
>>>> This puts the bochs probe func
This adds a python equivalent of the _use_sample_img and _rm_sample_img
testing functions.
Signed-off-by: Colin Lord
---
tests/qemu-iotests/iotests.py | 15 +++
1 file changed, 15 insertions(+)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 1687c33
.com/dramborleg/qemu/tree/probe-iotests/tests/qemu-iotests/sample_images
Colin Lord (3):
iotests: Add dmg format option
iotests: Add python functions for using sample images
iotests: Test format probes
tests/qemu-iotests/158| 53 +++
tests/qem
Adds option to test the dmg format.
Signed-off-by: Colin Lord
---
tests/qemu-iotests/common | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qemu-iotests/common b/tests/qemu-iotests/common
index d60ea2c..dc937c7 100644
--- a/tests/qemu-iotests/common
+++ b/tests/qemu-iotests
the given format, and one check is done against a raw image. This is to
ensure that a probe correctly returns a high score when the format is
matched, and does not return a high score when the format should not be
matched, as would be the case with raw images.
Signed-off-by: Colin Lord
---
tests
On 07/12/2016 05:17 PM, John Snow wrote:
>
>
> On 07/11/2016 03:50 PM, Colin Lord wrote:
>> Adds a new iotest for testing that the format probing functions work as
>> expected. This is done by booting up a vm with a disk image without
>> specifying the image format.
Isolates cloop probing function as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/cloop-probe.c | 17 +
block/cloop.c | 16 +---
include/block/probe.h | 1 +
4 files changed
From: Marc Mari
To simplify the addition of new block modules, add a script that generates
module_block.h automatically from the modules' source code.
This script assumes that the QEMU coding style rules are followed.
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Max
Completes the separation of the dmg probe from the dmg driver. The dmg
probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates qcow2 probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qcow2-probe.c | 16
block/qcow2.c | 13 +
include/block/probe.h | 1 +
4 files changed, 19 insertions
This commit moves the initialization of the QemuOptsList qemu_iscsi_opts
struct out of block/iscsi.c in order to allow the iscsi module to be
dynamically loaded.
Signed-off-by: Colin Lord
Reviewed-by: Fam Zheng
---
block/iscsi.c | 36
vl.c | 38
odule information is located in a new structure found in
module_block.h
Signed-off-by: Marc Marí
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c | 110 ++
include/qemu/module.h | 3 ++
util/module.c
Completes the separation of the raw probe from the raw driver. The
raw probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates the luks probe function as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/crypto-probe.c | 23 +++
block/crypto.c| 21 +
include/block/probe.h | 2 ++
4
Isolate qed probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qed-probe.c | 18 ++
block/qed.c | 15 +--
include/block/probe.h | 1 +
4 files changed, 21 insertions
onger in
the filename
- Fixed formatting of parallels_probe() function header
- Enforced consistent naming convention for the probe functions. They
now follow the pattern bdrv_format_probe().
Colin Lord (30):
blockdev: prepare iSCSI block driver for dynamic loading
blockdev: Move bochs
Isolate parallels probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/parallels-probe.c | 21 +
block/parallels.c | 43 ++-
block/parallels.h
Completes the separation of the vhdx probe from the vhdx driver. The
vhdx probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block.c
Isolates qcow probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/qcow-probe.c| 16
block/qcow.c | 31 ++-
block/qcow.h | 21
This puts the bochs probe function into its own separate file as part of
the process of modularizing block drivers. Having the probe functions
separate from the rest of the driver allows us to probe without having
to potentially unnecessarily load the driver.
Signed-off-by: Colin Lord
Reviewed
Isolate raw probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 1 +
block/raw-probe.c | 10 ++
block/raw_bsd.c | 9 +
include/block/probe.h | 1 +
4 files changed, 13 insertions(+), 8 deletions
Isolate dmg probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/dmg-probe.c | 17 +
block/dmg.c | 16 +---
include/block/probe.h | 1 +
4 files changed, 20 insertions
Completes the separation of the luks probe from the crypto driver. The
luks probe now returns the format in addition to the score, allowing
correlation of the score and driver without the probe function being
part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
Isolates vmdk probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vmdk-probe.c| 60 +++
block/vmdk.c | 60
This commit finalizes the separation of the block driver and probe
function by removing the .bdrv_probe field from all BlockDrivers.
Probing is now accomplished solely by iterating over the array of probe
function pointers in the format_probes array.
Signed-off-by: Colin Lord
Reviewed-by: Max
Completes the separation of the parallels probe from the parallels
driver. The parallels probe now returns the format in addition to the
score, allowing correlation of the score and driver without the probe
function being part of the driver itself.
Signed-off-by: Colin Lord
Reviewed-by: Max
allows the score to be correlated to the
driver without the probe function needing to be part of the driver.
Signed-off-by: Colin Lord
---
block.c | 20
block/bochs-probe.c | 25 -
block/bochs.c | 1 -
include/block/probe.h | 3
Isolates vdi probe as part of the modularization process.
Signed-off-by: Colin Lord
Reviewed-by: Max Reitz
---
block/Makefile.objs | 2 +-
block/vdi-probe.c | 26 +++
block/vdi.c | 69 ++-
block/vdi.h
1 - 100 of 196 matches
Mail list logo
