On 07/06/2016 11:59 AM, Max Reitz wrote: > On 05.07.2016 17:24, Colin Lord wrote: >> Modifies the bochs probe to return the format name as well as the >> score as the final step of separating the probe function from the >> driver. This keeps the probe completely independent of the driver, >> making future modularization easier to accomplish. Returning the format >> name as well as the score allows the score to be correlated to the >> driver without the probe function needing to be part of the driver. >> >> Signed-off-by: Colin Lord <cl...@redhat.com> >> --- >> block.c | 19 +++++++++++++++++++ >> block/bochs.c | 1 - >> block/probe/bochs.c | 25 ++++++++++++++++--------- >> include/block/probe.h | 3 ++- >> 4 files changed, 37 insertions(+), 11 deletions(-) > > Oh, and another comment: I think it would be better to split this patch > into a part that modifies block.c (introducing the format_probes array > and using it in bdrv_probe_all()) and another one that actually does the > bochs-specific stuff. > > Max > I could do that, but if I leave the variable i as an unsigned type, I get compiler warnings/errors that the for loop condition of i < ARRAY_SIZE(format_probes) must be false since the size of format_probes will be 0 (and unsigned is always positive). Is it okay to change the type to int? Not sure how strictly this aspect of the coding style gets enforced.
Colin
