Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Eric Auger
Hi Gustavo, On 6/13/25 5:01 AM, Gustavo Romero wrote: > Hi Eric, > > On 6/12/25 09:55, Igor Mammedov wrote: >> On Wed, 11 Jun 2025 10:50:04 +0200 >> Eric Auger wrote: >> >>> Hi Igor, >>> On 6/11/25 10:45 AM, Igor Mammedov wrote: On Wed, 11 Jun 2025 08:53:28 +0200 Eric Auger wrote:

Re: [PATCH v15 0/4] arm/virt: CXL support via pxb_cxl

2025-06-12 Thread Itaru Kitayama
On Thu, Jun 12, 2025 at 02:43:34PM +0100, Jonathan Cameron wrote: > v15: > - Split the address map calculations and mmio setup into separate > functions in patch 2, allowing v14 patch 3 to be dropped as not > x86 and arm make the same calls. Note I felt this was a sufficient > change

Re: Build platform guarantees, docs, tests, and snakes in the garden

2025-06-12 Thread Akihiko Odaki
On 2025/06/06 4:35, John Snow wrote: Hi, I've long been a little confused about the specifics of our build platform guarantee and how it applies to documentation and testing. My *current* understanding is that our build platform guarantee applies to both unit tests and building documentation,

Re: [PATCH preview 0/3] reviving minimal QAPI generation from 2021

2025-06-12 Thread Zhao Liu
On Thu, Jun 12, 2025 at 12:24:44PM +0200, Paolo Bonzini wrote: > Date: Thu, 12 Jun 2025 12:24:44 +0200 > From: Paolo Bonzini > Subject: Re: [PATCH preview 0/3] reviving minimal QAPI generation from 2021 > > On Wed, Jun 11, 2025 at 10:57 AM Paolo Bonzini wrote: > > Yes. If using serde the impleme

Re: [PATCH v13 2/7] hw/core/machine: topology functions capabilities added

2025-06-12 Thread Zhao Liu
On Wed, Jun 11, 2025 at 04:56:13PM +0100, Alireza Sanaee wrote: > Date: Wed, 11 Jun 2025 16:56:13 +0100 > From: Alireza Sanaee > Subject: [PATCH v13 2/7] hw/core/machine: topology functions capabilities > added > X-Mailer: git-send-email 2.34.1 > > Add two functions one of which finds the lowest

Re: [PATCH V1 1/2] hw/rtc: Fixed loongson rtc emulation errors

2025-06-12 Thread Bibo Mao
On 2025/6/13 上午9:31, Xianglai Li wrote: The expire time is sent to the timer only when the expire Time is greater than 0 or greater than now. Otherwise, the timer will trigger interruption continuously. Again, one line of the comments should no more than 75 bytes :) I think it should be spli

RE: [PATCH v2] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly

2025-06-12 Thread Jamin Lin
Hi Tan, > Subject: [PATCH v2] hw/misc/aspeed_scu: Handle AST2600 protection key > registers correctly > > The AST2600 SCU has two protection key registers (0x00 and 0x10) that both > need to be unlocked. Each must be unlocked individually, but locking one will > lock both. > > This commit update

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Gustavo Romero
Hi Eric, On 6/12/25 09:55, Igor Mammedov wrote: On Wed, 11 Jun 2025 10:50:04 +0200 Eric Auger wrote: Hi Igor, On 6/11/25 10:45 AM, Igor Mammedov wrote: On Wed, 11 Jun 2025 08:53:28 +0200 Eric Auger wrote: Hi Gustavo, Alex, On 5/28/25 12:33 PM, Igor Mammedov wrote: On Tue, 27 May 2025

RE: [PATCH v2] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly

2025-06-12 Thread Jamin Lin
> registers correctly > > Hi Tan, > > > Subject: [PATCH v2] hw/misc/aspeed_scu: Handle AST2600 protection key > > registers correctly > > > > The AST2600 SCU has two protection key registers (0x00 and 0x10) that > > both need to be unlocked. Each must be unlocked individually, but > > locking one

Re: [PATCH V1 1/2] hw/rtc: Fixed loongson rtc emulation errors

2025-06-12 Thread Bibo Mao
On 2025/6/13 上午9:31, Xianglai Li wrote: The expire time is sent to the timer only when the expire Time is greater than 0 or greater than now. Otherwise, the timer will trigger interruption continuously. Timer interrupts are sent using pulse functions. Signed-off-by: Xianglai Li --- Cc: Bibo

Re: [PATCH V1 2/2] hw/loongarch: add rtc acpi table

2025-06-12 Thread Bibo Mao
On 2025/6/13 上午9:31, Xianglai Li wrote: Add the acpi table to the loongson rtc hardware so that the virtual machine kernel can use the loongson RTC-related drivers. Signed-off-by: Xianglai Li --- Cc: Bibo Mao Cc: Song Gao Cc: Jiaxun Yang Cc: Xianglai Li hw/loongarch/virt-acpi-build.c

Re: [PATCH V1 2/2] hw/loongarch: add rtc acpi table

2025-06-12 Thread Bibo Mao
Xianglai, On 2025/6/13 上午9:31, Xianglai Li wrote: Add the acpi table to the loongson rtc hardware so that the virtual machine kernel can use the loongson RTC-related drivers. One line of the comments is no more than 75 bytes, it seems that it is far less than 75 bytes. Signed-off-by: Xian

Re: [PATCH v15 2/4] hw/cxl: Make the CXL fixed memory windows devices.

2025-06-12 Thread Zhijian Li (Fujitsu)
On 12/06/2025 21:43, Jonathan Cameron wrote: > Previously these somewhat device like structures were tracked using a list > in the CXLState in each machine. This is proving restrictive in a few > cases where we need to iterate through these without being aware of the > machine type. Just make the

[PATCH] hw/acpi: Fix GPtrArray memory leak in crs_range_merge

2025-06-12 Thread Li Zhijian via
This leak was detected by the valgrind. The crs_range_merge() function unconditionally allocated a GPtrArray 'even when range->len was zero, causing an early return without freeing the allocated array. This resulted in a memory leak when an empty range was processed. Fix this by moving the GPtrAr

Re: [PATCH v2 06/25] hw/pci-host/gpex-acpi: Propagate hotplug type info from virt machine downto gpex

2025-06-12 Thread Igor Mammedov
On Wed, 11 Jun 2025 11:00:02 +0200 Eric Auger wrote: > Hi Igor, > > On 5/27/25 2:33 PM, Igor Mammedov wrote: > > On Tue, 27 May 2025 09:40:08 +0200 > > Eric Auger wrote: > > > >> Propagate the type of pci hotplug mode downto the gpex > >> acpi code. In case machine acpi_pcihp is unset we conf

Re: [PATCH v14 0/5] arm/virt: CXL support via pxb_cxl

2025-06-12 Thread Jonathan Cameron via
On Thu, 29 May 2025 14:13:30 +0900 Itaru Kitayama wrote: > On Wed, May 28, 2025 at 12:07:21PM +0100, Jonathan Cameron wrote: > > v14: Simplifications suggeseted by Itaru (and some extra simplifications > > that became apparent) and gather tags. > > See individual patches for more inform

Re: [PATCH v4 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-12 Thread Steven Sistare
On 6/11/2025 4:56 PM, Jaehoon Kim wrote: When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates

Re: [PATCH v4 2/2] migration: Support fd-based socket address in cpr_transfer_input

2025-06-12 Thread Daniel P . Berrangé
On Wed, Jun 11, 2025 at 03:56:10PM -0500, Jaehoon Kim wrote: > Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside > SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened > socket file descriptors for cpr migration channels. > > This change is particularly useful

[PATCH v15 2/4] hw/cxl: Make the CXL fixed memory windows devices.

2025-06-12 Thread Jonathan Cameron via
Previously these somewhat device like structures were tracked using a list in the CXLState in each machine. This is proving restrictive in a few cases where we need to iterate through these without being aware of the machine type. Just make them sysbus devices. Restrict them to not user created as

[PATCH v15 3/4] hw/arm/virt: Basic CXL enablement on pci_expander_bridge instances pxb-cxl

2025-06-12 Thread Jonathan Cameron via
Code based on i386/pc enablement. The memory layout places space for 16 host bridge register regions after the GIC_REDIST2 in the extended memmap. The CFMWs are placed above the extended memmap. Only create the CEDT table if cxl=on set for the machine. Signed-off-by: Jonathan Cameron --- v15: N

[PATCH v15 0/4] arm/virt: CXL support via pxb_cxl

2025-06-12 Thread Jonathan Cameron via
v15: - Split the address map calculations and mmio setup into separate functions in patch 2, allowing v14 patch 3 to be dropped as not x86 and arm make the same calls. Note I felt this was a sufficient change to trigger dropping tags. (Zhijian Li) - A few other minor tweaks. - TL

[PATCH] i386/tdx: Error and exit when named cpu model is requested

2025-06-12 Thread Xiaoyao Li
Currently, it gets below error when requesting any named cpu model with "-cpu" to boot a TDX VM: qemu-system-x86_64: KVM_TDX_INIT_VM failed: Invalid argument It misleads people to think it's the bug of KVM or QEMU. It is just that current QEMU doesn't support named cpu model for TDX. To suppor

[PATCH v15 1/4] hw/cxl-host: Add an index field to CXLFixedMemoryWindow

2025-06-12 Thread Jonathan Cameron via
To enable these to be found in a fixed order, that order needs to be known. This will later be used to sort a list of these structures so that address map and ACPI table entries are predictable. Reviewed-by: Li Zhijian Reviewed-by: Fan Ni Signed-off-by: Jonathan Cameron --- v14: Picked up tags

[PATCH v15 4/4] qtest/cxl: Add aarch64 virt test for CXL

2025-06-12 Thread Jonathan Cameron via
Add a single complex case for aarch64 virt machine. Given existing much more comprehensive tests for x86 cover the common functionality, a single test should be enough to verify that the aarch64 part continue to work. Signed-off-by: Jonathan Cameron --- v15: Dropped tags due to changes in patche

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-12 Thread Eric Auger
Hi Igor, On 6/12/25 3:00 PM, Igor Mammedov wrote: > On Wed, 11 Jun 2025 10:56:36 +0200 > Eric Auger wrote: > >> On 6/11/25 10:49 AM, Igor Mammedov wrote: >>> On Wed, 11 Jun 2025 08:47:36 +0200 >>> Eric Auger wrote: >>> Hi Igor, On 5/27/25 1:58 PM, Igor Mammedov wrote: > On

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-12 Thread John Levon
On Thu, Jun 12, 2025 at 08:39:17AM +0200, Cédric Le Goater wrote: > > +static void vfio_user_pci_realize(PCIDevice *pdev, Error **errp) > > +{ > > +ERRP_GUARD(); > > +VFIOUserPCIDevice *udev = VFIO_USER_PCI(pdev); > > +VFIOPCIDevice *vdev = VFIO_PCI_BASE(pdev); > > +VFIODevice *vba

Re: [PATCH] hw/misc/aspeed_scu: Handle AST2600 protection key registers correctly

2025-06-12 Thread Tan Siewert
On 12.06.25 08:58, Cédric Le Goater wrote: LGTM, Jamin, Steven, Troy ? On 12.06.25 01:43, Tan Siewert wrote: -    if (reg > PROT_KEY && !s->regs[PROT_KEY]) { +    if ((reg != AST2600_PROT_KEY && reg != AST2600_PROT_KEY2) && ! unlocked) {   qemu_log_mask(LOG_GUEST_ERROR, "%s: SCU is

Re: [PATCH v2 00/11] migration: Some enhancements and cleanups for 10.1

2025-06-12 Thread Peter Xu
On Thu, Jun 12, 2025 at 12:35:46PM +0200, Mario Casquero wrote: > Hello Peter, Hi, Mario, > > Thanks for pointing this out! I retested it with the series you > mentioned and everything works fine. > > Booted up 2 VMs as usual, one in source and one in destination with > -incoming defer. Set the

[PULL 2/2] qga: Add tests for guest-get-load command

2025-06-12 Thread Konstantin Kostiuk
Tested-by: Dehan Meng Reviewed-by: Yan Vugenfirer Signed-off-by: Konstantin Kostiuk --- tests/unit/test-qga.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/unit/test-qga.c b/tests/unit/test-qga.c index 541b08a5e7..587e30c7e4 100644 --- a/tests/unit/test-qga.c +++

[PULL 0/2] QGA patches for 2025-06-12

2025-06-12 Thread Konstantin Kostiuk
The following changes since commit d9ce74873a6a5a7c504379857461e4ae64fcf0cd: Merge tag 'pull-vfio-20250611' of https://github.com/legoater/qemu into staging (2025-06-11 11:39:53 -0400) are available in the Git repository at: https://github.com/kostyanf14/qemu.git tags/qga-pull-2025-06-12 f

RE: [PATCH rfcv3 15/21] intel_iommu: Bind/unbind guest page table to host

2025-06-12 Thread Shameerali Kolothum Thodi via
> -Original Message- > From: Yi Liu > Sent: Thursday, June 12, 2025 1:54 PM > To: Duan, Zhenzhong ; Nicolin Chen > > Cc: Peter Xu ; qemu-devel@nongnu.org; > alex.william...@redhat.com; c...@redhat.com; eric.au...@redhat.com; > m...@redhat.com; jasow...@redhat.com; ddut...@redhat.com; >

[PULL 1/2] qga-win: implement a 'guest-get-load' command

2025-06-12 Thread Konstantin Kostiuk
Windows has no native equivalent API, but it would be possible to simulate it as illustrated here (BSD-3-Clause): https://github.com/giampaolo/psutil/pull/1485 Reviewed-by: Daniel P. Berrangé Tested-by: Dehan Meng Reviewed-by: Yan Vugenfirer Signed-off-by: Konstantin Kostiuk --- qga/comman

Re: [PULL 0/2] Seabios 1.17.0 20250611 patches

2025-06-12 Thread Gerd Hoffmann
Hi, > I didn't fix it. GitLab's mirror operation is still failing. Your > suggestion of force pushing should fix it, but I want to understand > why a commit was lost first. > > The issue is that QEMU's mirror and upstream have diverged. The > following commit is only in QEMU's mirror repo: > >

Re: [PATCH v3 00/23] vfio-user client

2025-06-12 Thread John Levon
On Thu, Jun 12, 2025 at 08:57:54AM +0200, Cédric Le Goater wrote: > On 6/7/25 02:10, John Levon wrote: > > The series contains an implement of a vfio-user client in QEMU, along with > > a few > > more preparatory patches. > > > > The vfio-user protocol allows for implementing (PCI) devices in an

[PATCH] MAINTAINERS: Yoshinori Sato email address has been updated

2025-06-12 Thread Yoshinori Sato
The email address has been suspended. I have prepared a new email address. Signed-off-by: Yoshinori Sato --- MAINTAINERS | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index aa6763077e..f28b908e62 100644 --- a/MAINTAINERS +++ b/MAINTAI

[PATCH] target/i386: Fix CR2 handling for non-canonical addresses

2025-06-12 Thread Mathias Krause
Commit 3563362ddfae ("target/i386: Introduce structures for mmu_translate") accidentally modified CR2 for non-canonical address exceptions while these should lead to a #GP / #SS instead -- without changing CR2. Fix that. A KUT test for this was submitted as [1]. [1] https://lore.kernel.org/kvm/2

Re: [RFC PATCH v1] hw/vfio/ap: attribute constructor for cfg_chg_events_lock

2025-06-12 Thread Rorie Reyes
On 6/12/25 12:44 AM, Thomas Huth wrote: On 11/06/2025 23.12, Rorie Reyes wrote: Created an attribute constructor for cfg_chg_events_lock for locking mechanism when storing event information for an AP configuration change event Fixes: fd03360215 ("Storing event information for an AP configurat

Re: [RFC PATCH v1] hw/vfio/ap: attribute constructor for cfg_chg_events_lock

2025-06-12 Thread Rorie Reyes
On 6/12/25 2:18 AM, Cédric Le Goater wrote: On 6/11/25 23:12, Rorie Reyes wrote: Created an attribute constructor for cfg_chg_events_lock for locking mechanism when storing event information for an AP configuration change event Fixes: fd03360215 ("Storing event information for an AP configura

[RFC PATCH v2 QEMU 0/4] cxl/plugins: Hotness Monitoring Unit with 'real' data.

2025-06-12 Thread Jonathan Cameron via
RFC v2: Think of this as a WIP posting. It is useful for OS driver and use case work but not ready for upstream QEMU. - Integrated the previously separate CXL server with the plugin to avoid one hop. - Many more control features emulated - still a few to go such as transaction type filtering an

[RFC PATCH v2 QEMU 1/4] hw/cxl: Switch to using an array for CXLRegisterLocator base addresses.

2025-06-12 Thread Jonathan Cameron via
Allows for easier looping over entries when adding CHMU and CPMU instances. Signed-off-by: Jonathan Cameron --- CHMU RFC v2: New patch to simplify a few code paths. --- include/hw/cxl/cxl_pci.h | 17 ++--- hw/cxl/switch-mailbox-cci.c| 4 ++-- hw/mem/cxl_type3.c

Re: live-migration performance regression when using pmem

2025-06-12 Thread Peter Xu
On Thu, Jun 12, 2025 at 03:34:35PM +, Chaney, Ben wrote: > On 5/14/25, 9:59 AM, "David Hildenbrand" > wrote: > > > > >Because we need to make sure the pmem kind memory data is synced > >after migration, we choose to call pmem_persist() when the migration > >finish.

Re: [PATCH v15 0/4] arm/virt: CXL support via pxb_cxl

2025-06-12 Thread Jonathan Cameron via
On Thu, 12 Jun 2025 17:04:32 +0100 Peter Maydell wrote: > On Thu, 12 Jun 2025 at 14:43, Jonathan Cameron > wrote: > > > > v15: > > - Split the address map calculations and mmio setup into separate > > functions in patch 2, allowing v14 patch 3 to be dropped as not > > x86 and arm make

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread Stefan Hajnoczi
On Sat, Jun 7, 2025 at 5:47 AM oltolm wrote: > > Sorry, I forgot to cc the maintainers. > > The build failed when run on Windows. I replaced calls to Unix programs > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to > ´os.path.relpath´ in try-except because it can fail when t

[PATCH v4 3/4] qapi: remove trivial "Returns:" sections

2025-06-12 Thread John Snow
The new qapidoc.py can generate "Returns" statements with type information just fine, so we can remove it from the source where it doesn't add anything particularly novel or helpful and just repeats the type info. This patch is fairly "gentle" and doesn't aggressively touch other "Returns" lines t

Re: [PATCH v2 01/20] memory: Adjust event ranges to fit within notifier boundaries

2025-06-12 Thread Alejandro Jimenez
On 6/12/25 2:54 AM, Vasant Hegde wrote: Alejandro, On 5/2/2025 7:45 AM, Alejandro Jimenez wrote: Invalidating the entire address space (i.e. range of [0, ~0ULL]) is a valid and required operation by vIOMMU implementations. However, such invalidations currently trigger an assertion unless th

Re: [PATCH v15 4/4] qtest/cxl: Add aarch64 virt test for CXL

2025-06-12 Thread Itaru Kitayama
On Thu, Jun 12, 2025 at 02:43:38PM +0100, Jonathan Cameron wrote: > Add a single complex case for aarch64 virt machine. > Given existing much more comprehensive tests for x86 cover the > common functionality, a single test should be enough to verify > that the aarch64 part continue to work. > > Si

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread BALATON Zoltan
On Thu, 12 Jun 2025, Oleg Tolmatcev wrote: Am Do., 12. Juni 2025 um 21:35 Uhr schrieb Stefan Hajnoczi : On Sat, Jun 7, 2025 at 5:47 AM oltolm wrote: Sorry, I forgot to cc the maintainers. The build failed when run on Windows. I replaced calls to Unix programs like ´cat´, ´sed´ and ´true´ wi

Re: [PATCH 18/18] hw/i386/x86-iommu: Remove X86IOMMUState::pt_supported field

2025-06-12 Thread Alejandro Jimenez
On 6/6/25 9:42 AM, Igor Mammedov wrote: On Thu, 1 May 2025 23:04:56 +0200 Philippe Mathieu-Daudé wrote: @@ -1486,15 +1485,8 @@ static AddressSpace *amdvi_host_dma_iommu(PCIBus *bus, void *opaque, int devfn) AMDVI_INT_ADDR_FIRST,

[PATCH v4 2/4] docs, qapi: generate undocumented return sections

2025-06-12 Thread John Snow
This patch changes the qapidoc transmogrifier to generate Return value documentation for any command that has a return value but hasn't explicitly documented that return value. Signed-off-by: John Snow --- docs/sphinx/qapidoc.py | 14 -- scripts/qapi/parser.py | 15 +++ s

[PATCH v4 0/4] qapi: add auto-generated return docs

2025-06-12 Thread John Snow
This series adds the ability for the new QAPIDoc system to generate "Returns:" documentation based on the return type declared in the Schema even when no explicit documentation is found in the QAPI source. As a result and as an immediate cleanup, trivial return statements are removed and remaining

[PATCH v4 4/4] qapi: rephrase return docs to avoid type name

2025-06-12 Thread John Snow
Well, I tried. Maybe not very hard. Sorry! Signed-off-by: John Snow --- qapi/block-core.json | 6 +++--- qapi/block-export.json | 2 +- qapi/block.json| 2 +- qapi/control.json | 5 ++--- qapi/dump.json | 5 ++--- qapi/introspect.json | 6 +++--- qapi/job.json |

[PATCH v4 1/4] docs/qapi-domain: add return-nodesc

2025-06-12 Thread John Snow
This form is used to annotate a return type without an accompanying description, for when there is no "Returns:" information in the source doc, but we have a return type we want to generate a cross-reference to. The syntax is: :return-nodesc: TypeName It's primarily necessary because Sphinx alwa

[PATCH v2 1/3] docs: fix errors formatting in tests/qapi-schema/doc-good

2025-06-12 Thread John Snow
If we remove the legacy parser, the doc-good.json formatting begins to fail because the body text is appended directly after the field list entry, which is invalid rST syntax. Without this change, we see this error: /home/jsnow/src/qemu/docs/../tests/qapi-schema/doc-good.json:169: WARNING: Field

[PATCH v2 0/3] docs: remove legacy qapidoc

2025-06-12 Thread John Snow
Remove docs/sphinx/qapidoc_legacy.py, and remove special parsing of freeform QAPI documentation block sections in favor of using standard rST syntax that is included in the final document with no special parsing or post-processing. v2: - rebased on origin/master (2025-06-12) - Revised commit mes

[PATCH v2 2/3] docs: remove legacy QAPI manual generator

2025-06-12 Thread John Snow
Thanks for your service! Remove the old qapidoc and the option to enable the transmogrifier, leaving the "transmogrifier" as the ONLY qapi doc generator. This in effect also converts the QAPI test to use the new documentation generator, too. Signed-off-by: John Snow --- docs/interop/qemu-ga-ref

[PATCH v2 3/3] docs: remove special parsing for freeform sections

2025-06-12 Thread John Snow
This change removes special parsing for freeform sections and allows them to simply be unmodified rST syntax. The existing headings in the QAPI schema are adjusted to reflect the new paradigm. Signed-off-by: John Snow --- docs/devel/qapi-code-gen.rst | 28 ++--- docs/inte

[PATCH v4] meson: fix Windows build

2025-06-12 Thread oltolm
The build fails on Windows. Replace calls to Unix programs like ´cat´, ´sed´ and ´true´ with calls to ´python´ and wrap calls to ´os.path.relpath´ in try-except because it can fail when the two paths are on different drives. Make sure to convert the Windows paths to Unix paths to prevent warnings i

[PULL v2 00/31] Block patches

2025-06-12 Thread Stefan Hajnoczi
The following changes since commit d9ce74873a6a5a7c504379857461e4ae64fcf0cd: Merge tag 'pull-vfio-20250611' of https://github.com/legoater/qemu into staging (2025-06-11 11:39:53 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for

[PULL v2 11/31] hw/audio/marvell_88w8618: skip automatic zero-init of large array

2025-06-12 Thread Stefan Hajnoczi
From: Daniel P. Berrangé The 'mv88w8618_audio_callback' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when read

[PULL v2 1/1] meson: fix Windows build

2025-06-12 Thread Stefan Hajnoczi
From: oltolm The build fails on Windows. Replace calls to Unix programs like ´cat´, ´sed´ and ´true´ with calls to ´python´ and wrap calls to ´os.path.relpath´ in try-except because it can fail when the two paths are on different drives. Make sure to convert the Windows paths to Unix paths to pre

[PULL v2 0/1] Tracing patches

2025-06-12 Thread Stefan Hajnoczi
The following changes since commit d9ce74873a6a5a7c504379857461e4ae64fcf0cd: Merge tag 'pull-vfio-20250611' of https://github.com/legoater/qemu into staging (2025-06-11 11:39:53 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/tracing-pull-request fo

Re: [PATCH v2 0/2] reject qcow2 creation with protocol in data_store

2025-06-12 Thread Eric Blake
On Tue, May 27, 2025 at 09:32:43AM -0500, Eric Blake wrote: > v1 was here: > https://lists.gnu.org/archive/html/qemu-devel/2025-05/msg05581.html > > Since then: > - split into two patches > - also tweak vmdk [Kevin] > - rewrite commit messages for better justification [Kevin] > > Eric Blake (2

Re: [PATCH 2/4] qcow2: Simplify size round-up in co_create_opts

2025-06-12 Thread Eric Blake
On Fri, May 30, 2025 at 10:44:45AM +0200, Hanna Czenczek wrote: > Use the now-existing qcow2_opts pointer to simplify the size rounding up > code. > > Signed-off-by: Hanna Czenczek > --- > block/qcow2.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Reviewed-by: Eric Blake -- Eric

Re: [PATCH 3/4] iotests/common.filter: Sort keep_data_file

2025-06-12 Thread Eric Blake
On Fri, May 30, 2025 at 10:44:46AM +0200, Hanna Czenczek wrote: > Sort the new keep_data_file creation option together with data_file and > data_file_raw. > > Signed-off-by: Hanna Czenczek > --- > tests/qemu-iotests/common.filter | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-

Re: [PATCH v1 1/3] hw/net/can: CTU CAN FD IP core mapping to the platform bus

2025-06-12 Thread Peter Maydell
On Wed, 28 May 2025 at 12:50, Pavel Pisa wrote: > > The system/platform bus mapping alternative to PCI/PCIe mapping. > In this case, the platform bus is used to match FPGA design > for Xilinx Zynq MZ_APO education kit with four CTU CAN FD > cores on branch mz_apo-2x-xcan-4x-ctu of repo > > https

[RFC PATCH v2 QEMU 4/4] plugins: cache: Add a hotness tracker for cache misses with socket connection to device emulation

2025-06-12 Thread Jonathan Cameron via
This adds simple hotness tracker instances suitable for pairing with the CXL HMU emulation with control and data transfer via a socket (port 4443) A typical command line is: -plugin ../qemu/bin/native/contrib/plugins/libcache.so,hotness=1,\ dcachesize=8192,dassoc=4,dblksize=64,icachesize=8192,iass

Re: [PATCH v7 13/14] arm/cpu: switch to a generated cpu-sysregs.h.inc

2025-06-12 Thread Cornelia Huck
On Thu, Jun 12 2025, Peter Maydell wrote: > On Thu, 15 May 2025 at 16:40, Cornelia Huck wrote: >> >> Generated against Linux 6.14-rc1. >> >> Reviewed-by: Sebastian Ott >> Reviewed-by: Eric Auger >> Signed-off-by: Cornelia Huck >> --- > > Does it make sense to include all these extra registers

[RFC PATCH v2 QEMU 2/4] hw/cxl: Add emulation of a CXL Hotness Monitoring Unit (CHMU)

2025-06-12 Thread Jonathan Cameron via
CXL r3.2 defines a CXL Hotness Monitoring Unit. This allows for a CXL device to do on device estimation of which 'granuals' of data are 'hot' - that is accessed a lot. For a typical application hot data on a CXL device both wastes potentially limited bandwidth and many have latency impacts. Access

[RFC PATCH v2 QEMU 3/4] hw/cxl: Provide a means to get the interleave set position for an EP

2025-06-12 Thread Jonathan Cameron via
CXL interleave decoding is hieriarchical in a fashion that means the CXL memory devices only need to know the interleave granularity and interleave ways to figure out which address bits to drop from incoming translactions. Unfortunately to provide the right information to the hotness monitoring plu

Re: [PATCH v15 0/4] arm/virt: CXL support via pxb_cxl

2025-06-12 Thread Peter Maydell
On Thu, 12 Jun 2025 at 14:43, Jonathan Cameron wrote: > > v15: > - Split the address map calculations and mmio setup into separate > functions in patch 2, allowing v14 patch 3 to be dropped as not > x86 and arm make the same calls. Note I felt this was a sufficient > change to trigg

Re: [PATCH v5 1/7] vhost-user: Add VirtIO Shared Memory map request

2025-06-12 Thread Stefan Hajnoczi
On Mon, Jun 09, 2025 at 04:47:23PM +0200, Albert Esteve wrote: > Add SHMEM_MAP/UNMAP requests to vhost-user to > handle VIRTIO Shared Memory mappings. > > This request allows backends to dynamically map > fds into a VIRTIO Shared Memory Region indentified identified > by its `shmid`. The map is

Re: [PATCH 1/2] hw/nvme: fix namespace attachment

2025-06-12 Thread Jesper Devantier
On Tue Jun 3, 2025 at 2:59 PM CEST, Klaus Jensen wrote: > From: Klaus Jensen > > Commit 6ccca4b6bb9f ("hw/nvme: rework csi handling") introduced a bug in > Namespace Attachment, causing it to > > a) not allow a controller to attach namespaces to other controllers > b) assert if a valid non-att

Re: [PATCH 1/4] qcow2: Add keep_data_file command-line option

2025-06-12 Thread Eric Blake
On Fri, May 30, 2025 at 10:44:44AM +0200, Hanna Czenczek wrote: > Add a command-line-only option to prevent overwriting the file specified > as external data file. > > This option is only available on the qemu-img create command line, not > via blockdev-create, as it makes no sense there: That int

Re: [PATCH RESEND v3] meson: fix Windows build

2025-06-12 Thread Oleg Tolmatcev
Am Do., 12. Juni 2025 um 21:35 Uhr schrieb Stefan Hajnoczi : > > On Sat, Jun 7, 2025 at 5:47 AM oltolm wrote: > > > > Sorry, I forgot to cc the maintainers. > > > > The build failed when run on Windows. I replaced calls to Unix programs > > like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wr

Re: [PATCH v7 08/14] arm/cpu: Store id_isar0-7 into the idregs array

2025-06-12 Thread Cornelia Huck
On Thu, Jun 12 2025, Peter Maydell wrote: > On Thu, 12 Jun 2025 at 16:36, Cornelia Huck wrote: >> >> On Thu, Jun 12 2025, Peter Maydell wrote: >> >> > On Thu, 15 May 2025 at 16:40, Cornelia Huck wrote: >> >> >> >> From: Eric Auger >> >> >> >> Reviewed-by: Richard Henderson >> >> Reviewed-by:

Re: [PATCH v1 04/15] intel_iommu: Introduce a new structure VTDHostIOMMUDevice

2025-06-12 Thread CLEMENT MATHIEU--DRIF
Hi, On 06/06/2025 12:04 pm, Zhenzhong Duan wrote: > Caution: External email. Do not open attachments or click links, unless this > email comes from a known sender and you know the content is safe. > > > Introduce a new structure VTDHostIOMMUDevice which replaces > HostIOMMUDevice to be stored i

Re: [PATCH 4/4] iotests/244: Add test cases for keep_data_file

2025-06-12 Thread Eric Blake
On Fri, May 30, 2025 at 10:44:47AM +0200, Hanna Czenczek wrote: > Add various test cases around keep_data_file to the existing data_file > test suite 244. > > Signed-off-by: Hanna Czenczek > --- > tests/qemu-iotests/244 | 71 ++ > tests/qemu-iotests/244.ou

[PATCH v2 02/12] python: update pylint ignores

2025-06-12 Thread John Snow
The next patch will synchronize the qemu.qmp library with the external, standalone version. That synchronization will require an extra ignore for pylint, so do that now. Signed-off-by: John Snow --- python/setup.cfg | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/python/

[PATCH v2 03/12] python: sync changes from external qemu.qmp package

2025-06-12 Thread John Snow
Synchronize changes from the standalone python-qemu-qmp repository for the primary purpose of removing some pre-3.9 compatibility crud that we no longer need or want. My plan for this release cycle is to finally eliminate this duplication so this type of patch will no longer be necessary -- but fo

[PATCH v2 00/12] Python: Fix 'make check-dev' and modernize to 3.9+

2025-06-12 Thread John Snow
This series does a couple things that I'll probably end up splitting out into smaller series if history is any guide, but either way, here it goes: A) Convert qemu.git/python/ to a PEP517/pyproject.toml package. Ultimately this means deleting setup.py and fully migrating to newer python infrastruc

[PATCH v2 01/12] python: convert packages to PEP517/pyproject.toml

2025-06-12 Thread John Snow
Newer versions of setuptools increasingly expect that packages are defined using the pyproject.toml/PEP517 packaging layout format. With 3.9 as our minimum, I believe it's finally appropriate to make the shift away from the legacy packaging format. Update documentation and dependencies that change

Re: [PATCH v3 0/7] amd_iommu: Fixes to align with AMDVi specification

2025-06-12 Thread Alejandro Jimenez
Hi Ethan, On 6/12/25 4:36 AM, Ethan MILON wrote: Hi, Is this series the right place to include the following minor fix? I would defer this change for two reasons: 1) This series has been reviewed and tested already. I was hoping it would be included on the Jun 1st pull but I sent v3 too la

[PATCH v2 07/12] fixup

2025-06-12 Thread John Snow
These are manual fixes that ought be merged into the prior patch, but are here separated for clarity to separate the automated portions of this patch from the non-automated portions. These fixes are only the necessary portions to allow python static checks (and checkpatch.pl) to pass again, and do

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-12 Thread Fabiano Rosas
Fabiano Rosas writes: > Peter Xu writes: > >> On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: >>> QAPI_CLONE_MEMBERS is a better option than copying parameters one by >>> one because it operates on the entire struct and follows pointers. It >>> also avoids the need to alter this f

[PATCH v2 04/12] python: update shebangs to standard, using /usr/bin/env

2025-06-12 Thread John Snow
This is the standard shebang we should always be using, as it plays nicely with virtual environments and our desire to always be using a specific python interpreter in our environments. (It also makes sure I can find all of the python scripts in our tree easily.) Signed-off-by: John Snow --- ro

[PATCH v2 05/12] python: fix illegal escape sequences

2025-06-12 Thread John Snow
\{ is an illegal escape sequence, to get a literal backslash we need to use \\. This is being fixed because of an issue spotted when attempting to use the pyupgrade script. Signed-off-by: John Snow --- scripts/feature_to_c.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/s

[PATCH v2 08/12] python: further 3.9+ syntax upgrades

2025-06-12 Thread John Snow
pyupgrade does not catch absolutely everything - there are still a few deprecated type aliases we need to shift away from using. Signed-off-by: John Snow --- docs/sphinx/compat.py | 8 ++-- docs/sphinx/qapi_domain.py| 6 +++--- python/qemu/machine/console_socket.p

[PATCH v2 11/12] scripts/codeconverter: remove unused code

2025-06-12 Thread John Snow
Remove (select) bits of unused code, as it is not typed correctly and appears to not be in use. The quickest solution is to remove it entirely. 'Match' is not defined, and neither is 'TypeInfoReference'. What these bits of code were meant to do is unclear. Signed-off-by: John Snow --- scripts/c

[PATCH v2 09/12] python: update mkvenv to type-check under different python versions

2025-06-12 Thread John Snow
Currently, we instruct mypy to pretend it is type checking under a specific version of python. For our case, where our scripts may in fact actually be executing under a number of different environments in the build system, we want mypy to remove this restriction. This patch adjusts some of the imp

[PATCH v2 10/12] python: remove version restriction for mypy

2025-06-12 Thread John Snow
Removing this configuration line allows mypy to type check files from the context of whatever version of Python it happens to be running under, which is actually what we want here, so long as we do actually support running these scripts under multiple versions of Python, which we currently do. Sig

[PATCH v2 12/12] scripts/codeconverter: remove * imports

2025-06-12 Thread John Snow
Python static analysis tools generally don't like dealing with asterisk imports as it's tough to deduce what's actually getting used and from where. Replace these imports with explicit imports. This also helps eliminate deprecated imports from the typing module. These files have more style issues

Re: [PATCH 10/21] migration: Use QAPI_CLONE_MEMBERS in query_migrate_parameters

2025-06-12 Thread Peter Xu
On Thu, Jun 12, 2025 at 05:58:14PM -0300, Fabiano Rosas wrote: > Fabiano Rosas writes: > > > Peter Xu writes: > > > >> On Mon, Jun 02, 2025 at 10:37:59PM -0300, Fabiano Rosas wrote: > >>> QAPI_CLONE_MEMBERS is a better option than copying parameters one by > >>> one because it operates on the en

Re: [PATCH 4/5] configure: Add dtc option

2025-06-12 Thread Bernhard Beschow
Am 12. Juni 2025 05:46:03 UTC schrieb Paolo Bonzini : >On 6/12/25 07:12, Paolo Bonzini wrote: >> I'll send a patch to the upstream dtc project and you can add it to QEMU via >> diff_files (see commit 64644bc4eab2f for an example). >This is the patch, backported to QEMU's version of the dtc subp

[PATCH 14/19] hw/i3c/dw-i3c: Add ctrl MMIO handling

2025-06-12 Thread Joe Komlodi
Adds functionality to the CTRL register. Signed-off-by: Joe Komlodi Reviewed-by: Titus Rwantare Reviewed-by: Patrick Venture --- hw/i3c/dw-i3c.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index c5af331ac4..61845c9

[PATCH 06/19] hw/i3c/dw-i3c: Add more reset values

2025-06-12 Thread Joe Komlodi
Adds reset values for the new registers added. Signed-off-by: Joe Komlodi Reviewed-by: Patrick Venture --- hw/i3c/dw-i3c.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index b252903ea4..845fbd5efd 100644 --- a/hw/i3c

[PATCH 19/19] hw/i3c: Add hotplug support

2025-06-12 Thread Joe Komlodi
This adds support for hotplugging in I3C. Conceptually this can be thought of as an I3C target being physically socketed onto a board. It is then the target's responsibility to go through the hot-join and DAA process so it can participate on the bus. Signed-off-by: Joe Komlodi Reviewed-by: Patri

[PATCH 16/19] hw/i3c/aspeed: Add I3C bus get function

2025-06-12 Thread Joe Komlodi
To retrieve the I3C bus object normally, the order is Aspeed I3C -> DW I3C[n] -> bus object, so make a nice wrapper for people to use. Signed-off-by: Joe Komlodi --- hw/i3c/aspeed_i3c.c | 9 + include/hw/i3c/aspeed_i3c.h | 2 ++ 2 files changed, 11 insertions(+) diff --git a/hw/

[PATCH 02/19] hw/i3c: Add bus support

2025-06-12 Thread Joe Komlodi
Adds an I3C bus and a target class. The bus supports: - I3C data transmission and reception - CCCs (including ENTDAA) - IBIs - legacy I2C transactions General usage of the bus is similar to I2C. Users are expected to initialize a bus via i3c_init_bus, and use the bus returned from the init functio

[PATCH 04/19] hw/i3c/dw-i3c: Add more register fields

2025-06-12 Thread Joe Komlodi
Adds the rest of the Designware register fields. Signed-off-by: Joe Komlodi Reviewed-by: Patrick Venture --- hw/i3c/dw-i3c.c | 216 1 file changed, 216 insertions(+) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index 4b1a3f3f07..b252903ea4 10

[PATCH 08/19] hw/i3c/dw-i3c: Add register RO field masks

2025-06-12 Thread Joe Komlodi
Adds read-only register masks for the DwC I3C controller. Signed-off-by: Joe Komlodi Reviewed-by: Patrick Venture --- hw/i3c/dw-i3c.c | 40 1 file changed, 40 insertions(+) diff --git a/hw/i3c/dw-i3c.c b/hw/i3c/dw-i3c.c index 845fbd5efd..4f40f999f4 100

  1   2   3   >