On Fri, May 30, 2025 at 10:44:47AM +0200, Hanna Czenczek wrote: > Add various test cases around keep_data_file to the existing data_file > test suite 244. > > Signed-off-by: Hanna Czenczek <hre...@redhat.com> > --- > tests/qemu-iotests/244 | 71 ++++++++++++++++++++++++++++++++++++++ > tests/qemu-iotests/244.out | 53 ++++++++++++++++++++++++++++ > 2 files changed, 124 insertions(+) > > diff --git a/tests/qemu-iotests/244 b/tests/qemu-iotests/244 > index bb9cc6512f..ec81df8d6a 100755 > --- a/tests/qemu-iotests/244 > +++ b/tests/qemu-iotests/244 > @@ -384,6 +384,77 @@ $QEMU_IMG compare --image-opts \ > "driver=raw,file.filename=$TEST_IMG.data" \ > "file.filename=$TEST_IMG,backing.file.filename=$TEST_IMG.base" >
> + > +# Maybe a matter of taste whether this should fail or create the file, but > +# failing is simpler (= will always skip create) and seems safer (users may > +# expect the file to exist, and the error will warn them when it does not). > +_make_test_img \ > + -o "data_file=$TEST_IMG.doesnotexist,keep_data_file=on,data_file_raw=on" > \ > + 1M I agree with the failure here. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
