Re: [PATCH] hw/arm/npcm7xx_boards: Add support for specifying SPI flash model

2025-06-10 Thread Peter Maydell
On Tue, 10 Jun 2025 at 02:28, Guenter Roeck wrote: > > In some situations it is desirable to be able to specify the flash type > connected to a board. For example, the target operating system may not > support the default flash type, its support may be broken, or the qemu > emulation is insufficie

[PATCH v2 1/1] Add RISCV ZALASR extension

2025-06-10 Thread Roan Richmond
This is based on version v0.8.3 of the ZALASR specification [1]. The specification is listed as in Frozen state [2]. [1]: https://github.com/riscv/riscv-zalasr/tree/v0.8.3 [2]: https://lf-riscv.atlassian.net/wiki/spaces/HOME/pages/16154882/All+RISC-V+Specifications+Under+Active+Development Signe

Re: [PATCH v3 0/2] amd_iommu: Fixes

2025-06-10 Thread Sairaj Kodilkar
On 6/3/2025 2:24 AM, Michael Tokarev wrote: On 16.05.2025 13:05, Sairaj Kodilkar wrote: Fix following two issues in the amd viommu 1. The guest fails to setup the passthrough device when for following setup     because amd iommu enables the no DMA memory region even when guest is     using

[PATCH v2 0/1] Add RISCV ZALASR Extension

2025-06-10 Thread Roan Richmond
Ping, resending as no responses in over week. V2: - rebased patch onto master branch - added check for RV64() for Load Double, as pointed out by Alistair Palmer. In response to Alistair Palmer (https://lists.gnu.org/archive/html/qemu-riscv/2025-06/msg00010.html): "Aren't you missing a check

[PULL 4/7] hw/loongarch/virt: inform guest of kvm

2025-06-10 Thread Song Gao
From: Qiang Ma Commit bab27ea2e3 ("hw/arm/virt: smbios: inform guest of kvm") fixes the same issue on arm. without this patch: [root@localhost ~]# virt-what qemu with this patch: [root@localhost ~]# virt-what kvm Signed-off-by: Qiang Ma Reviewed-by: Bibo Mao Reviewed-by: Song Gao Message-Id

Re: [PATCH V4 43/43] vfio/container: delete old cpr register

2025-06-10 Thread Cédric Le Goater
On 5/29/25 21:24, Steve Sistare wrote: vfio_cpr_[un]register_container is no longer used since they were subsumed by container type-specific registration. Delete them. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater Thanks, C. --- include/hw/vfio/vfio-cpr.h | 4 h

Re: [PULL 13/77] rocker: do not pollute the namespace

2025-06-10 Thread Philippe Mathieu-Daudé
Hi Paolo, On 30/5/25 09:11, Paolo Bonzini wrote: Do not leave the __le* macros defined, in fact do not use them at all. Fixes a build failure on Alpine with the TDX patches: In file included from ../hw/net/rocker/rocker_of_dpa.c:25: ../hw/net/rocker/rocker_hw.h:14:16: error: conflicting types

Re: [PATCH] hw/core/cpu: Move CacheType to general cpu.h

2025-06-10 Thread Philippe Mathieu-Daudé
On 5/6/25 15:27, Zhao Liu wrote: I386 has already defined cache types in target/i386/cpu.h. Move CacheType to hw/core/cpu.h, so that ARM and other architectures could use it. Cc: Alireza Sanaee Signed-off-by: Zhao Liu --- This is for Ali's ARM cache topology support: https://lore.kernel.org/q

Re: [PATCH v2 2/9] target/riscv: Add cpu_set_exception_base

2025-06-10 Thread Philippe Mathieu-Daudé
On 2/6/25 15:12, Djordje Todorovic wrote: Add a new function, so we can change reset vector from platforms. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- target/riscv/cpu.h | 2 ++ target/riscv/translate.c | 8 2 files changed, 10 insertions(+) diff --git

Re: [PATCH v2 8/9] configs/devices: Add MIPS Boston-aia board model to RISC-V

2025-06-10 Thread Philippe Mathieu-Daudé
On 2/6/25 15:12, Djordje Todorovic wrote: The board model supports up to 64 harts with MIPS CPS, MIPS GCR, MIPS CPC, AIA plic, and AIA clint devices. The model can create boot code, if there is no -bios parameter. We can specify -smp x, cores=y,thread=z. Ex: Use 4 cores and 2 threads with each co

Re: [PATCH v3 03/23] vfio: add per-region fd support

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: For vfio-user, each region has its own fd rather than sharing vbasedev's. Add the necessary plumbing to support this, and use the correct fd in vfio_region_mmap(). Signed-off-by: John Levon --- include/hw/vfio/vfio-device.h | 7 +-- hw/vfio/device.c

Re: [PULL 13/77] rocker: do not pollute the namespace

2025-06-10 Thread Philippe Mathieu-Daudé
On 10/6/25 09:53, Philippe Mathieu-Daudé wrote: Hi Paolo, On 30/5/25 09:11, Paolo Bonzini wrote: Do not leave the __le* macros defined, in fact do not use them at all.  Fixes a build failure on Alpine with the TDX patches: In file included from ../hw/net/rocker/rocker_of_dpa.c:25: ../hw/net/r

Re: [PATCH 2/2] target/arm: Implement ID_AA64PFR2_EL1

2025-06-10 Thread Eric Auger
Hi Peter, On 6/9/25 12:41 PM, Peter Maydell wrote: > Currently we define the ID_AA64PFR2_EL1 encoding as reserved (with > the required RAZ behaviour for unassigned system registers in the ID > register encoding space). Newer architecture versions start to > define fields in this ID register, so d

Re: [PATCH v3 01/23] vfio: export PCI helpers needed for vfio-user

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: The vfio-user code will need to re-use various parts of the vfio PCI code. Export them in hw/vfio/pci.h, and rename them to the vfio_pci_* namespace. Signed-off-by: John Levon Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/pci.h| 11 ++

Re: [PATCH] pc-bios: ensure installed ROMs don't have execute permissions

2025-06-10 Thread Philippe Mathieu-Daudé
On 30/5/25 17:21, Daniel P. Berrangé wrote: We have been inconsistent about whether ROMS stored in git have execute permission set, and by default meson will preserve source file permissions when installing files. This has caused periodic problems in RPM packaging as executable binary files get a

Re: [PATCH 01/13] hw/boards: Extend DEFINE_MACHINE macro to cover more use cases

2025-06-10 Thread Philippe Mathieu-Daudé
Hi Zoltan, On 2/5/25 01:20, BALATON Zoltan wrote: Add a more general DEFINE_MACHINE_EXTENDED macro and define simpler versions with less parameters based on that. This is inspired by how the OBJECT_DEFINE macros do this in a similar way to allow using the shortened definition in more complex cas

Re: [PATCH v3 02/23] vfio: enable per-IRQ MSI-X masking

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: If VFIO_IRQ_INFO_MASKABLE is set for VFIO_PCI_MSIX_IRQ_INDEX, record this in ->can_mask_msix, and use it to individually mask MSI-X interrupts as needed. Originally-by: John Johnson Signed-off-by: Elena Ufimtseva Signed-off-by: Jagannathan Raman Signed-off-b

Re: [PATCH 06/13] hw/ppc/pegasos2: Rename mv field in machine state

2025-06-10 Thread Philippe Mathieu-Daudé
On 2/5/25 01:20, BALATON Zoltan wrote: Use more generic name for the field used to store the north bridge in the machine state. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/hw/ppc/pegasos2.c b/h

Re: [PATCH v2 1/9] hw/intc: Allow gaps in hartids for aclint and aplic

2025-06-10 Thread Philippe Mathieu-Daudé
Hi, On 2/6/25 15:12, Djordje Todorovic wrote: This is needed for riscv based CPUs by MIPS. This justification is not really convincing. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- hw/intc/riscv_aclint.c | 33 +++-- hw/intc/riscv_aplic.c

Re: [PATCH 07/13] hw/ppc/pegasos2: Add south bridge pointer in the machine state

2025-06-10 Thread Philippe Mathieu-Daudé
On 2/5/25 01:20, BALATON Zoltan wrote: Add field for the south bridge in machine state to have both north and south bridges in it. Signed-off-by: BALATON Zoltan --- hw/ppc/pegasos2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 3/9] target/riscv: Add MIPS P8700 CPU

2025-06-10 Thread Philippe Mathieu-Daudé
Hi, On 2/6/25 15:12, Djordje Todorovic wrote: Introduce MIPS P8700 CPU and set reset vector to 0x1fc0. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- target/riscv/cpu-qom.h | 1 + target/riscv/cpu.c | 16 2 files changed, 17 insertions(+) diff

Re: [PATCH v2 4/9] target/riscv: Add MIPS P8700 CSRs

2025-06-10 Thread Philippe Mathieu-Daudé
On 2/6/25 15:12, Djordje Todorovic wrote: Define MIPS CSRs used for P8700 CPU. Signed-off-by: Chao-ying Fu Signed-off-by: Djordje Todorovic --- target/riscv/cpu.c | 3 + target/riscv/cpu.h | 7 ++ target/riscv/meson.build | 1 + target/riscv/mips_csr.c | 219 +++

[PULL 7/7] hw/loongarch/virt: Remove global variables about memmap tables

2025-06-10 Thread Song Gao
From: Bibo Mao Global variables memmap_table and memmap_entries stores UEFI memory map table informations. It can be moved into structure LoongArchVirtMachineState. Signed-off-by: Bibo Mao Reviewed-by: Song Gao Message-Id: <20250430094738.1556670-3-maob...@loongson.cn> Signed-off-by: Song Gao

[PULL 5/7] target/loongarch: add check for fcond

2025-06-10 Thread Song Gao
fcond only has 22 types, add a check for fcond. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2972 Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20250603024810.350510-1-gaos...@loongson.cn> --- .../loongarch/tcg/insn_trans/trans_fcmp.c.inc | 25 +

[PULL 6/7] hw/loongarch/virt: Remove global variables about initrd

2025-06-10 Thread Song Gao
From: Bibo Mao Global variables initrd_offset and initrd_size records loading information about initrd, it can be moved to structure loongarch_boot_info. Signed-off-by: Bibo Mao Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20250430094738.1556670-2-maob...@loongson.cn> Signed-off-by: Song G

[PULL 1/7] hw/loongarch/virt: Fix big endian support with MCFG table

2025-06-10 Thread Song Gao
From: Bibo Mao With API build_mcfg(), it is not necessary with parameter structure AcpiMcfgInfo to convert to little endian since it is directly used with host native endian. Here remove endian conversion before calling function build_mcfg(). With this patch, bios-tables-test passes to run on bi

[PULL 2/7] hw/intc/loongarch_pch: Convert to little endian with ID register

2025-06-10 Thread Song Gao
From: Bibo Mao With PCH ID register, it is defined as union type as follows: union LoongArchPIC_ID { struct { uint8_t _reserved_0[3]; uint8_t id; uint8_t version; uint8_t _reserved_1; uint8_t irq_num; uint8_t _reserved_2; } QEMU_PACKED desc;

[PULL 3/7] hw/intc/loongarch_extioi: Fix typo issue about register EXTIOI_COREISR_END

2025-06-10 Thread Song Gao
From: Bibo Mao Interrupt controller extioi supports 256 vectors, register EXTIOI_COREISR records pending interrupt status with bitmap method. Size of EXTIOI_COREISR is 256 / 8 = 0x20 bytes, EXTIOI_COREISR_END should be EXTIOI_COREISR_START + 0x20 rather than 0xB20. Signed-off-by: Bibo Mao Revie

[PULL 0/7] loongarch-to-apply queue

2025-06-10 Thread Song Gao
u.git tags/pull-loongarch-20250610 for you to fetch changes up to ffe89c1762d879fd39ba1be853d154677dbfbc7b: hw/loongarch/virt: Remove global variables about memmap tables (2025-06-10 15:01:41 +0800) pull-loongarc

Re: [PATCH 0/4] system: Forbid alloca()

2025-06-10 Thread Philippe Mathieu-Daudé
On 5/6/25 21:35, Philippe Mathieu-Daudé wrote: Eradicate alloca() uses on system code, then enable -Walloca to prevent new ones to creep back in. Philippe Mathieu-Daudé (4): hw/gpio/pca9552: Avoid using g_newa() backends/tpmL Avoid using g_alloca() tests/unit/test-char: Avoid using g_al

Re: [PATCH v3 05/23] vfio-user: introduce vfio-user protocol specification

2025-06-10 Thread John Levon
On Tue, Jun 10, 2025 at 11:38:29AM +0200, Cédric Le Goater wrote: > > docs/devel/vfio-user.rst | 1522 > > I think this file should be split in several smaller files. The > protocol specification part belongs to "System Emulation Management > and Interopera

Re: [PATCH v3 06/23] vfio-user: add vfio-user class and container

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: Introduce basic plumbing for vfio-user behind a new --enable-vfio-user-client option. We introduce VFIOUserContainer in hw/vfio-user/container.c, which is a container type for the "IOMMU" type "vfio-iommu-user", and share some common container code from hw/vfio

Re: [PATCH v3 05/23] vfio-user: introduce vfio-user protocol specification

2025-06-10 Thread Cédric Le Goater
On 6/7/25 02:10, John Levon wrote: From: Thanos Makatos This patch introduces the vfio-user protocol specification (formerly known as VFIO-over-socket), which is designed to allow devices to be emulated outside QEMU, in a separate process. vfio-user reuses the existing VFIO defines, structs and

Re: Controlling time in QEMU

2025-06-10 Thread Bernhard Beschow
Am 6. Juni 2025 19:03:32 UTC schrieb Pierrick Bouvier : >Hi, > >I recently needed to slow down time within a virtual machine, due to a timeout >being hit because my QEMU binary which was not fast enough (gcov debug build >if you're curious about the use case). > >Currently, people tend to use

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: > On 10.06.2025 20:58, Sertonix wrote: >> >> Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. > > Why do you think -pie causes it to become dynamically linked? > > /mjt The documentation (at least for gcc) states

Re: [PATCH] MAINTAINERS: Drop the defunct mail address from Yoshinori Sato

2025-06-10 Thread Yoshinori Sato
My email is becoming a black hole. This email address cannot be used to send patches, so we will prepare a different email address and update it. 2025年6月10日(火) 21:01 Thomas Huth : > From: Thomas Huth > > The OSDN / sourceforge.jp site ceased to work (according to > https://en.wikipedia.org/wiki/

Re: [PATCH 09/10] target/loongarch: loongarch CPU supoort avec irqs

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h | 1 + target/loongarch/cpu.c | 17 + 2 files changed, 18 insertions(+) diff --git a/target/loongarch/cpu-csr.h b/target/loongarch/cpu-csr.h index 0834e91f30..83f6cb081a 100644

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Michael Tokarev
On 10.06.2025 23:36, Sertonix wrote: On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. Why do you think -pie causes it to become dynamically linked? /mjt The documentat

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
Am 12. Mai 2025 15:32:08 UTC schrieb Paolo Bonzini : >Hi, now that GSoC selection is over I'm back. Sorry for the delay; >Tanish Desai will work mostly on tracing, so logging can remain yours. > >On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: >> >Currently the #defines contain some hol

Re: Embed QEMU terminal into GUI application (Cubic - Custom Ubuntu ISO Creator)

2025-06-10 Thread Bernhard Beschow
Am 9. Juni 2025 17:22:32 UTC schrieb PJ Singh : >Hello Everyone, > >I want to embed a QEMU window directly in my GUI application. Are Python >APIs available to embed QEMU into a GNOME GUI application? > >I am the developer of Cubic (Custom Ubuntu ISO Creator), a tool which >allows users to custo

Re: [PATCH 19/21] migration: Allow migrate commands to provide the migration config

2025-06-10 Thread Peter Xu
On Tue, Jun 10, 2025 at 05:55:31PM -0300, Fabiano Rosas wrote: > I think I caused some confusion here. I wrote migrate_params_override() > last thing on a friday and forgot it did the right thing from the > beginning: > > migrate_params_apply(&s->defaults); > qmp_migrate_set_parameters(new

[PATCH 1/2] qemu/timer: introduce time dilation factor

2025-06-10 Thread Pierrick Bouvier
This factor is applied to time spent since we read clock for the first time. It impacts value returned by get_clock() and get_clock_realtime(). Signed-off-by: Pierrick Bouvier --- include/qemu/timer.h | 22 -- util/qemu-timer-common.c | 1 + 2 files changed, 17 insertion

[PATCH 2/2] system/rtc: introduce -rtc time-dilation option

2025-06-10 Thread Pierrick Bouvier
This option sets a factor on time spent for QEMU clocks since the beginning of execution. It can be used to slow or accelerate time for a guest, without impacting QEMU speed. Signed-off-by: Pierrick Bouvier --- system/rtc.c| 11 +++ system/vl.c | 3 +++ qemu-options.hx | 7

[PATCH 0/2] control guest time using a dilation factor

2025-06-10 Thread Pierrick Bouvier
Depending on host cpu speed, and QEMU optimization level, it may sometimes be needed to slow or accelerate time guest is perceiving. A common scenario is hitting a timeout during a boot process, because some operations were not finished on time. An existing solution for that is -icount shift=X, wi

Re: [PATCH v3 02/23] vfio: enable per-IRQ MSI-X masking

2025-06-10 Thread John Levon
On Fri, Jun 06, 2025 at 05:10:34PM -0700, John Levon wrote: > If VFIO_IRQ_INFO_MASKABLE is set for VFIO_PCI_MSIX_IRQ_INDEX, record > this in ->can_mask_msix, and use it to individually mask MSI-X > interrupts as needed. I'm just going to drop this patch. Neither vfio nor libvfio-user (including q

[PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

2025-06-10 Thread Zhenzhong Duan
Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as base class VFIO_PCI_BASE, so no need to set its instance_size explicitly. This isn't catastrophic only because VFIO_PCI_BASE is an abstract class. Fixes: d4

[PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. By using -static-pie it will be linked statically like other bios. This ensures that the build output doesn't change depending on the default dynamic loader path of the toolchain. Ref d884c86dcd3b s390/bios: Make the s390-

Re: [PATCH 4/5] configure: Add dtc option

2025-06-10 Thread BALATON Zoltan
On Tue, 10 Jun 2025, Bernhard Beschow wrote: The next patch will make dtc mandatory for boards with a bundled DTB, causing these boards to be omitted when dtc is missing. Allow packagers to force the build of those boards by providing an option. I don't like this. This might result in some mach

Re: [PATCH 3/5] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically

2025-06-10 Thread BALATON Zoltan
On Tue, 10 Jun 2025, Bernhard Beschow wrote: When changing meson_options.txt, this script gets updated automatically by QEMU tooling which sorts the choices lexicographically. Fix this in preparation of the ext patch. Typo: next patch Fixes: ccc403ed5844 ("meson: Add wasm build in build scrip

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Xiaoyao Li
Paolo, This one is not supposed to be pulled until we fix KVM as you said: https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ BTW, I have sent the KVM fix: https://lore.kernel.org/all/20250611001018.2179964-1-xiaoyao...@intel.com/ On 6/6/2025 8:34 PM, Paolo Bonz

Re: [PATCH V4 16/43] pci: skip reset during cpr

2025-06-10 Thread Steven Sistare
On 6/10/2025 12:31 PM, Michael S. Tsirkin wrote: On Wed, Jun 04, 2025 at 03:48:40PM +0200, Cédric Le Goater wrote: I don't see any advantage to making this a class attribute.  I looked for examples of using such attributes for vfio to configure pci, and found very little.  It sounds like overki

[PATCH v3 2/2] migration: Support fd-based socket address in cpr_transfer_input

2025-06-10 Thread Jaehoon Kim
Extend cpr_transfer_input to handle SOCKET_ADDRESS_TYPE_FD alongside SOCKET_ADDRESS_TYPE_UNIX. This change supports the use of pre-listened socket file descriptors for cpr migration channels. This change is particularly useful in qtest environments, where the socket may be created externally and p

[PATCH v3 1/2] tests/migration: Setup pre-listened cpr.sock to remove race-condition.

2025-06-10 Thread Jaehoon Kim
When the source VM attempts to connect to the destination VM's Unix domain socket (cpr.sock) during a cpr-transfer test, race conditions can occur if the socket file isn't ready. This can lead to connection failures when running tests. This patch creates and listens on the socket in advance, and p

Re: [PATCH 10/10] target/loongarch: cpu do interrupt support msg interrupt.

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: we use CSR_ESTAT and CSR_ECFG bit 15 for msg interrupt. and loongarch_cpu_do_interrupt support msg interrupts. Signed-off-by: Song Gao --- target/loongarch/cpu-csr.h | 3 ++- target/loongarch/cpu.c | 35 ++- 2 files

Re: Controlling time in QEMU

2025-06-10 Thread Pierrick Bouvier
On 6/6/25 12:03 PM, Pierrick Bouvier wrote: Hi, I recently needed to slow down time within a virtual machine, due to a timeout being hit because my QEMU binary which was not fast enough (gcov debug build if you're curious about the use case). Currently, people tend to use -icount shift=X with l

Fixing my email inbox

2025-06-10 Thread John Snow
My employer, er, switched to a certain mail host some number of years ago and I never really actually acclimated properly. As a result of that and, uh, my laziness, I've accumulated ... quite a backlog of mail I have not really read or dealt with. It's become unmanageable. I'm trying to fix that.

Re: [PATCH] vfio/pci: Fix instance_size of VFIO_PCI_BASE

2025-06-10 Thread Yi Liu
On 2025/6/11 10:42, Zhenzhong Duan wrote: Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). For the people who has a doubt how the size is sizeof(PCIDevice). :) * @instance_size: The size of the object (derivative of #Object). If * @instance_size is 0, then the si

Re: [PATCH 07/10] hw/loongarch: connect pch_msi controller to avec controller

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- hw/loongarch/virt.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 718b5b4f92..6b670e7936 100644 --- a/hw/loongarch/virt.c +++ b/hw/loong

Re: [PATCH 06/10] hw/loongarch: Implement avec controller imput and output pins

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: the AVEC controller supports 256*256 irqs, all the irqs connect CPU INT_AVEC irq Signed-off-by: Song Gao --- hw/intc/loongarch_avec.c | 28 hw/loongarch/virt.c | 11 +-- target/loongarch/cpu.h | 3 ++- 3 fi

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-10 Thread Eric Auger
Hi Igor, On 5/27/25 1:58 PM, Igor Mammedov wrote: > On Tue, 27 May 2025 09:40:04 +0200 > Eric Auger wrote: > >> acpi_pcihp VirtMachineClass state flag will allow >> to opt in for acpi pci hotplug. This is guarded by a >> class no_acpi_pcihp flag to manage compats (<= 10.0 >> machine types will no

Re: [PATCH 02/10] loongarch: add virt feature avecintc support

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: LoongArchVirtMachinState add avecintc features, and it use to check whether virt machine support advance interrupt controller and default is on. Signed-off-by: Song Gao --- hw/loongarch/virt.c | 31 +++ include/hw/lo

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Xiaoyao Li
On 6/11/2025 2:12 PM, Paolo Bonzini wrote: On Wed, Jun 11, 2025 at 4:56 AM Xiaoyao Li wrote: Paolo, This one is not supposed to be pulled until we fix KVM as you said: https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ The bug was understood and fix just a f

Re: [PATCH v2 02/25] hw/arm/virt: Introduce machine state acpi pcihp flags and props

2025-06-10 Thread Eric Auger
Hi Gustavo, Alex, On 5/28/25 12:33 PM, Igor Mammedov wrote: > On Tue, 27 May 2025 15:54:15 +0200 > Eric Auger wrote: > >> Hi Igor, >> >> On 5/27/25 1:58 PM, Igor Mammedov wrote: >>> On Tue, 27 May 2025 09:40:04 +0200 >>> Eric Auger wrote: >>> acpi_pcihp VirtMachineClass state flag will al

Re: [PATCH qemu v7 1/1] target/riscv: Add Zilsd and Zclsd extension support

2025-06-10 Thread Alistair Francis
On Thu, May 15, 2025 at 2:07 PM ~liuxu wrote: > > From: lxx <1733205...@qq.com> > > This patch adds support for the Zilsd and Zclsd extension, > which is documented at https://github.com/riscv/riscv-zilsd/releases/tag/v1.0 > > Co-developed-by: SUN Dongya > Co-developed-by: LIU Xu > Co-developed-

RE: [PATCH v5 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-06-10 Thread Kasireddy, Vivek
Hi Daniel, > Subject: Re: [PATCH v5 2/7] ui/spice: Add an option for users to provide a > preferred codec > > On Tue, Jun 10, 2025 at 03:30:24PM +0400, Marc-André Lureau wrote: > > Hi > > > > On Fri, Jun 6, 2025 at 11:16 AM Daniel P. Berrangé > > wrote: > > > > > On Fri, Jun 06, 2025 at 06:10:31

Re: [PATCH] pc-bios/s390-ccw: link statically

2025-06-10 Thread Sertonix
On Wed Jun 11, 2025 at 6:07 AM CEST, Michael Tokarev wrote: > On 10.06.2025 23:36, Sertonix wrote: >> On Tue Jun 10, 2025 at 10:32 PM CEST, Michael Tokarev wrote: >>> On 10.06.2025 20:58, Sertonix wrote: Adding -pie to LDFLAGS caused s390-ccw.img to become dynamically linked. >>> >>> Why

Re: [PATCH v2 00/11] migration: Some enhancements and cleanups for 10.1

2025-06-10 Thread Mario Casquero
This series has been successfully tested. The information displayed from the HMP info migrate command is more user-friendly, with the possibility of displaying the globals with info migrate -a. (qemu) info migrate -a Status: active Sockets: [ tcp ] Globals: store-global-state: on only-m

Re: [PULL 16/31] i386/kvm: Prefault memory on page state change

2025-06-10 Thread Paolo Bonzini
On Wed, Jun 11, 2025 at 4:56 AM Xiaoyao Li wrote: > > Paolo, > > This one is not supposed to be pulled until we fix KVM as you said: > https://lore.kernel.org/qemu-devel/d0983ba3-383b-4c81-9cfd-b5b0d26a5...@redhat.com/ The bug was understood and fix just a few days away, so I included it. I'll se

Re: [PATCH 08/10] hw/loongarch: Implement avec set_irq

2025-06-10 Thread Bibo Mao
On 2025/6/9 下午6:48, Song Gao wrote: Signed-off-by: Song Gao --- hw/intc/loongarch_avec.c | 37 ++--- 1 file changed, 34 insertions(+), 3 deletions(-) diff --git a/hw/intc/loongarch_avec.c b/hw/intc/loongarch_avec.c index c692fef43c..f609ed9aaa 100644 --- a/

Re: [PATCH v5 3/7] vhost_user.rst: Add SHMEM_MAP/_UNMAP to spec

2025-06-10 Thread Alyssa Ross
Albert Esteve writes: > Add SHMEM_MAP/_UNMAP request to the vhost-user > spec documentation. > > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Albert Esteve > --- > docs/interop/vhost-user.rst | 55 + > 1 file changed, 55 insertions(+) > > diff --git a/docs/

Re: [PATCH v5 7/7] vhost-user-devive: Add shmem BAR

2025-06-10 Thread Alyssa Ross
Subject should say vhost-user-devi*c*e signature.asc Description: PGP signature

Re: [PATCH v5 2/7] ui/spice: Add an option for users to provide a preferred codec

2025-06-10 Thread Marc-André Lureau
Hi On Fri, Jun 6, 2025 at 11:16 AM Daniel P. Berrangé wrote: > On Fri, Jun 06, 2025 at 06:10:31AM +, Kasireddy, Vivek wrote: > > Hi Daniel, > > > > > Subject: Re: [PATCH v5 2/7] ui/spice: Add an option for users to > provide a > > > preferred codec > > > > > > On Wed, May 28, 2025 at 10:11:1

Re: [PATCH v2 2/9] target/riscv: Add cpu_set_exception_base

2025-06-10 Thread Alistair Francis
On Mon, Jun 2, 2025 at 11:15 PM Djordje Todorovic wrote: > > Add a new function, so we can change reset vector from platforms. You can use the "resetvec" property instead, there are a range of RISC-V machines already doing this. Have a look at hw/riscv/opentitan.c or hw/riscv/sifive_u.c for examp

[PULL 17/24] tests/unit/test-char: Avoid using g_alloca()

2025-06-10 Thread Philippe Mathieu-Daudé
Do not use g_alloca(), simply allocate the CharBackend structure on the stack. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Stefan Hajnoczi Message-Id: <20250605193540.59874-4-phi...@linaro.org> --- tests/unit/test-char.c | 3 +-- 1 file changed, 1 insertion

[PULL 20/24] hw/gpio/aspeed: Fix definition of AspeedGPIOClass

2025-06-10 Thread Philippe Mathieu-Daudé
From: Zhenzhong Duan AspeedGPIOClass's parent is SysBusDeviceClass rather than SysBusDevice. This isn't catastrophic only because sizeof(SysBusDevice) > sizeof(SysBusDeviceClass). Fixes: 4b7f956862dc ("hw/gpio: Add basic Aspeed GPIO model for AST2400 and AST2500") Closes: https://lists.gnu.org/

[PULL 04/24] hw/pci-host/raven: Revert "raven: Move BIOS loading from board code to PCI host"

2025-06-10 Thread Philippe Mathieu-Daudé
From: BALATON Zoltan This reverts commit d0b25425749d5525b2ba6d9d966d8800a5643b35. Loading firmware from the PCI host is unusual and raven is only used by one board so this does not simplify anything but rather complicates it. Revert to loading firmware from board code as that is the usual way a

[PULL 10/24] pc-bios: ensure installed ROMs don't have execute permissions

2025-06-10 Thread Philippe Mathieu-Daudé
From: Daniel P. Berrangé We have been inconsistent about whether ROMS stored in git have execute permission set, and by default meson will preserve source file permissions when installing files. This has caused periodic problems in RPM packaging as executable binary files get analysed by various

[PULL 15/24] hw/gpio/pca9552: Avoid using g_newa()

2025-06-10 Thread Philippe Mathieu-Daudé
We have pin_count <= PCA955X_PIN_COUNT_MAX. Having PCA955X_PIN_COUNT_MAX = 16, it is safe to explicitly allocate the char buffer on the stack, without g_newa(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Glenn Miles Reviewed-by: Stefan Hajnoczi Message-Id:

Re: [PATCH 00/31] Skip automatic zero-init of large arrays / structs in I/O paths

2025-06-10 Thread Daniel P . Berrangé
On Tue, Jun 10, 2025 at 02:49:02PM +0200, Philippe Mathieu-Daudé wrote: > On 10/6/25 14:36, Daniel P. Berrangé wrote: > > This series is an extension of Stefan's proposal: > > > >https://lists.nongnu.org/archive/html/qemu-devel/2025-06/msg00736.html > > > > It used '-Wframe-larger-than=4096'

[PULL 19/24] hw/virtio/virtio-pmem: Fix definition of VirtIOPMEMClass

2025-06-10 Thread Philippe Mathieu-Daudé
From: Zhenzhong Duan VirtIOPMEMClass's parent is VirtioDeviceClass rather than VirtIODevice. This isn't catastrophic only because sizeof(VirtIODevice) > sizeof(VirtioDeviceClass). Fixes: 5f503cd9f388 ("virtio-pmem: add virtio device") Closes: https://lists.gnu.org/archive/html/qemu-devel/2025-06

[PULL 24/24] hw/net/i82596: Factor configure function out

2025-06-10 Thread Philippe Mathieu-Daudé
From: Soumyajyotii_Ssarkar Abstract the configure function. Signed-off-by: Soumyajyotii Ssarkar Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20250607152711.108914-2-soumyajyotisarka...@gmail.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/net/i82596.c | 36 +

[PULL 18/24] hw/virtio/virtio-mem: Fix definition of VirtIOMEMClass

2025-06-10 Thread Philippe Mathieu-Daudé
From: Zhenzhong Duan Parent of VirtIOMEMClass is VirtioDeviceClass rather than VirtIODevice. This isn't catastrophic only because sizeof(VirtIODevice) > sizeof(VirtioDeviceClass). Fixes: 910b25766b33 ("virtio-mem: Paravirtualized memory hot(un)plug") Signed-off-by: Zhenzhong Duan Reviewed-by: D

[PULL 13/24] accel/hvf: Fix TYPE_HVF_ACCEL instance size

2025-06-10 Thread Philippe Mathieu-Daudé
Fixes: c97d6d2cdf9 ("i386: hvf: add code base from Google repo") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Message-Id: <20250606164418.98655-7-phi...@linaro.org> --- include/system/hvf_int.h | 1 + accel/hvf/hvf-accel-ops.c | 1 + 2 files changed, 2 insertions(+) dif

[PATCH 10/31] hw/audio/gus: skip automatic zero-init of large array

2025-06-10 Thread Daniel P . Berrangé
The 'GUS_read_DMA' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when reading data from device memory. Signed

[PULL 21/24] hw/riscv/riscv-iommu: Remove definition of RISCVIOMMU[Pci|Sys]Class

2025-06-10 Thread Philippe Mathieu-Daudé
From: Zhenzhong Duan RISCVIOMMUPciClass and RISCVIOMMUSysClass are defined with missed parent class, class_init on them may corrupt their parent class fields. It's lucky that parent_realize and parent_phases are not initialized or used until now, so just remove the definitions. They can be added

[PULL 16/24] backends/tpm: Avoid using g_alloca()

2025-06-10 Thread Philippe Mathieu-Daudé
tpm_emulator_ctrlcmd() is not in hot path. Use the heap instead of the stack, removing the g_alloca() call. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Reviewed-by: Thomas Huth Reviewed-by: Stefan Berger Reviewed-by: Stefan Hajnoczi Message-Id: <20250605193540.59874-3-

[PULL 01/24] hw/char/sh_serial: Delete fifo_timeout_timer in DeviceUnrealize

2025-06-10 Thread Philippe Mathieu-Daudé
fifo_timeout_timer is created in the DeviceRealize handler, not in the instance_init one. For parity, delete it in DeviceUnrealize, rather than instance_finalize. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Peter Maydell Message-Id: <20250124175053.74461-2-phi...@linaro.org> --- hw/char/

[PATCH 21/31] hw/net/virtio-net: skip automatic zero-init of large arrays

2025-06-10 Thread Daniel P . Berrangé
The 'virtio_net_receive_rcu' method has three arrays with VIRTQUEUE_MAX_SIZE elements, which are apprixmately 32k in size used for copying data between guest and host. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path. The three arrays will be s

[PATCH V5 05/38] vfio/container: discard old DMA vaddr

2025-06-10 Thread Steve Sistare
In the container pre_save handler, discard the virtual addresses in DMA mappings with VFIO_DMA_UNMAP_FLAG_VADDR, because guest RAM will be remapped at a different VA after in new QEMU. DMA to already-mapped pages continues. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater --- hw/vfio

[PATCH V5 07/38] vfio/container: mdev cpr blocker

2025-06-10 Thread Steve Sistare
During CPR, after VFIO_DMA_UNMAP_FLAG_VADDR, the vaddr is temporarily invalid, so mediated devices cannot be supported. Add a blocker for them. This restriction will not apply to iommufd containers when CPR is added for them in a future patch. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le

[PATCH V5 30/38] migration: vfio cpr state hook

2025-06-10 Thread Steve Sistare
Define a list of vfio devices in CPR state, in a subsection so that older QEMU can be live updated to this version. However, new QEMU will not be live updateable to old QEMU. This is acceptable because CPR is not yet commonly used, and updates to older versions are unusual. The contents of each

[PATCH 2/2] watchdog: generic name for i6300esb

2025-06-10 Thread Cornelia Huck
The Intel 6300 Enterprise SouthBridge is a south bridge for a more or less obscure embedded Intel system; however, the i6300esb watchdog device we implement in QEMU is a virtual watchdog device that should work well on any PCI-based machine, is well supported by Linux guests, and used in many examp

Re: [PATCH 11/31] hw/audio/gus: skip automatic zero-init of large array

2025-06-10 Thread Daniel P . Berrangé
Mistake in $SUBJECT - should be 'hw/audio/marvell_88w8618:' prefix On Tue, Jun 10, 2025 at 01:36:49PM +0100, Daniel P. Berrangé wrote: > The 'mv88w8618_audio_callback' method has a 4k byte array used for > copying data between the audio backend and device. Skip the automatic > zero-init of this ar

[PATCH V5 00/38] Live update: vfio and iommufd

2025-06-10 Thread Steve Sistare
Support vfio and iommufd devices with the cpr-transfer live migration mode. Devices that do not support live migration can still support cpr-transfer, allowing live update to a new version of QEMU on the same host, with no loss of guest connectivity. No user-visible interfaces are added. For lega

[PATCH V5 22/38] backends/iommufd: iommufd_backend_map_file_dma

2025-06-10 Thread Steve Sistare
Define iommufd_backend_map_file_dma to implement IOMMU_IOAS_MAP_FILE. This will be called as a substitute for iommufd_backend_map_dma, so the error conditions for BARs are copied as-is from that function. Signed-off-by: Steve Sistare Reviewed-by: Zhenzhong Duan --- include/system/iommufd.h | 3

[PATCH V5 31/38] vfio/iommufd: cpr state

2025-06-10 Thread Steve Sistare
VFIO iommufd devices will need access to ioas_id, devid, and hwpt_id in new QEMU at realize time, so add them to CPR state. Define CprVFIODevice as the object which holds the state and is serialized to the vmstate file. Define accessors to copy state between VFIODevice and CprVFIODevice. Signed-o

[PATCH V5 02/38] migration: lower handler priority

2025-06-10 Thread Steve Sistare
Define a vmstate priority that is lower than the default, so its handlers run after all default priority handlers. Since 0 is no longer the default priority, translate an uninitialized priority of 0 to MIG_PRI_DEFAULT. CPR for vfio will use this to install handlers for containers that run after h

[PATCH V5 11/38] vfio-pci: skip reset during cpr

2025-06-10 Thread Steve Sistare
Do not reset a vfio-pci device during CPR, and do not complain if the kernel's PCI config space changes for non-emulated bits between the vmstate save and load, which can happen due to ongoing interrupt activity. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater --- include/hw/vfio/vfi

Re: [PATCH 2/3] hw/cxl: Simplified Identify Switch Device & Get Physical Port State

2025-06-10 Thread Jonathan Cameron via
On Mon, 2 Jun 2025 19:29:41 +0530 Arpit Kumar wrote: > Modified Identify Switch Device (Opcode 5100h) > & Get Physical Port State(Opcode 5101h) > using physical ports info stored during enumeration > > Signed-off-by: Arpit Kumar A few additional comments in here. J > --- > hw/cxl/cxl-mailbox

Re: Controlling time in QEMU

2025-06-10 Thread Pierrick Bouvier
Hi Bernard, On 6/10/25 3:22 AM, Bernhard Beschow wrote: As it seems a bit too good to be true, time for questions: - Has it already been considered? - Any obvious downside I might have skipped? The only downside I can see is that it seems to disturb QEMU's internal timekeeping. The GTK gui fr

  1   2   3   >