Re: [PATCH RFC 00/10] qapi: remove all TARGET_* conditionals from the schema

2025-05-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Fri, May 09, 2025 at 03:43:30PM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> > I think we have to distinguish between what made sense in the context >> > of our original design, from what makes sense for our future design(s) >> > and plans. >>

Re: [PATCH v1 06/22] hw/misc/aspeed_hace: Support accumulative mode for direct access mode

2025-05-09 Thread Cédric Le Goater
On 5/9/25 08:55, Jamin Lin wrote: Hi Cédric Subject: Re: [PATCH v1 06/22] hw/misc/aspeed_hace: Support accumulative mode for direct access mode On 3/21/25 10:26, Jamin Lin wrote: Enable accumulative mode for direct access mode operations. In direct access mode, only a single source buffer is

Re: [PATCH v1 08/22] hw/misc/aspeed_hace: Support DMA 64 bits dram address.

2025-05-09 Thread Cédric Le Goater
On 5/9/25 09:04, Jamin Lin wrote: Hi Cédric Subject: Re: [PATCH v1 08/22] hw/misc/aspeed_hace: Support DMA 64 bits dram address. On 3/21/25 10:26, Jamin Lin wrote: According to the AST2700 design, the data source address is 64-bit, with R_HASH_SRC_HI storing bits [63:32] and R_HASH_SRC storin

[PATCH 2/3] docs: Require sphinx>=6.2

2025-05-09 Thread Akihiko Odaki
This makes docs/sphinx/compat.py unnecessary. The accepted range of the sphinx_rtd_theme version was also changed to >=1.2 for compatibility with sphinx>=6.2. Signed-off-by: Akihiko Odaki --- docs/sphinx/compat.py | 230 - docs/sphinx/qapi_domain.

[PATCH 1/3] docs: Bump sphinx to 6.2.1

2025-05-09 Thread Akihiko Odaki
sphinx 5.3.0 fails with Python 3.13.1: ../docs/meson.build:37: WARNING: /home/me/qemu/build/pyvenv/bin/sphinx-build: Extension error: Could not import extension sphinx.builders.epub3 (exception: No module named 'imghdr') ../docs/meson.build:39:6: ERROR: Problem encountered: Install a Python 3 v

[PATCH 0/3] docs: Bump sphinx to 6.2.1

2025-05-09 Thread Akihiko Odaki
Supersedes: <20250505-sphinx82-v1-0-85f2418b3...@daynix.com> ("[PATCH 0/2] docs: Bump sphinx to 8.2.3") sphinx 5.3.0 fails with Python 3.13.1: ../docs/meson.build:37: WARNING: /home/me/qemu/build/pyvenv/bin/sphinx-build: Extension error: Could not import extension sphinx.builders.epub3 (exception

[PATCH 3/3] MAINTAINERS: Add docs/requirements.txt

2025-05-09 Thread Akihiko Odaki
Add docs/requirements.txt to "Sphinx documentation configuration and build machinery". Signed-off-by: Akihiko Odaki --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d54b5578f883..6ae5d2665e16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4328,6

Re: [PATCH v1] Implement RTC timer for nRF51

2025-05-09 Thread Peter Maydell
On Sun, 4 May 2025 at 11:36, Kaido Kert wrote: > > Implements the RTC timer. Implementation is based on > existing nrf51_timer and other RTCs. > Event signaling through PPI peripheral is not implemented. > Tests added in microbit board. > > Signed-off-by: Kaido Kert Hi; thanks for this patch; ge

Re: [PATCH] s390x: Fix leak in machine_set_loadparm

2025-05-09 Thread Thomas Huth
On 09/05/2025 19.49, Fabiano Rosas wrote: ASAN spotted a leaking string in machine_set_loadparm(): Direct leak of 9 byte(s) in 1 object(s) allocated from: #0 0x560ffb5bb379 in malloc ../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3 #1 0x7f1aca926518 in g_malloc ../glib/gmem

Re: [PATCH RFC 00/10] qapi: remove all TARGET_* conditionals from the schema

2025-05-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, May 08, 2025 at 02:09:37PM -0700, Pierrick Bouvier wrote: >> On 5/8/25 6:58 AM, Daniel P. Berrangé wrote: >> > Pierrick has proposed a series that introduces a concept of runtime >> > conditionals to the QAPI schema, in order to adapt the TARGET_* >> > conditi

[PATCH] tests/functional: Add PCI hotplug test for aarch64

2025-05-09 Thread Gustavo Romero
Add a functional test, aarch64_hotplug_pci, to exercise PCI hotplug and hot-unplug on arm64. Currently, the aarch64 'virt' machine uses the PCIe native controller and does not support ACPI-based hotplugging. However, since support is planned, this test sets 'acpi=force' and specifies an EDK2 firmwa

Re: [PATCH v2 06/14] contrib/plugins: allow setting of instructions per quantum

2025-05-09 Thread Akihiko Odaki
On 2025/05/06 21:57, Alex Bennée wrote: The default is we update time every 1/10th of a second or so. However for some cases we might want to update time more frequently. Allow this to be set via the command line through the ipq argument. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier

Re: [PATCH 1/2] docs: Bump sphinx to 8.2.3

2025-05-09 Thread Akihiko Odaki
On 2025/05/08 3:23, John Snow wrote: On Wed, May 7, 2025 at 1:22 AM Markus Armbruster > wrote: John Snow mailto:js...@redhat.com>> writes: > On Mon, May 5, 2025 at 8:19 AM Akihiko Odaki mailto:akihiko.od...@daynix.com>> > wrote: > >> sphi

[PATCH] Add nRF51 RTC timer

2025-05-09 Thread Kaido Kert
Implements the RTC timer for nRF51. Implementation is based on existing nrf51_timer. Event signaling through PPI peripheral is not implemented. Tests added in microbit board. Signed-off-by: Kaido Kert --- hw/arm/nrf51_soc.c | 13 ++ hw/rtc/Kconfig | 3 + hw/rtc/meson.bui

Re: [PATCH v2 04/14] Running with --enable-ubsan leads to a qtest failure

2025-05-09 Thread Akihiko Odaki
I think the subject should tell what this patch does and perhaps the underlying problem it solves instead of the symptom. It may be nice to have a prefix "tests/qtest/libqos/igb:" to comply the convention. On 2025/05/06 21:57, Alex Bennée wrote: From: Nabih Estefan ../tests/qtest/libqos/i

Re: [PATCH v2 03/14] tests/tcg: make aarch64 boot.S handle different starting modes

2025-05-09 Thread Akihiko Odaki
On 2025/05/06 21:57, Alex Bennée wrote: Currently the boot.S code assumes everything starts at EL1. This will break things like the memory test which will barf on unaligned memory access when run at a higher level. Adapt the boot code to do some basic verification of the starting mode and the mi

Re: [PATCH v2 05/14] contrib/plugins: add a scaling factor to the ips arg

2025-05-09 Thread Akihiko Odaki
On 2025/05/06 21:57, Alex Bennée wrote: It's easy to get lost in zeros while setting the numbers of instructions per second. Add a scaling suffix to make things simpler. Signed-off-by: Alex Bennée Reviewed-by: Pierrick Bouvier --- v2 - normalise the suffix before a full strcmp0 - check

Re: [PATCH v2 12/14] ui/gtk-gl-area: Remove extra draw call in refresh

2025-05-09 Thread Akihiko Odaki
On 2025/05/06 21:57, Alex Bennée wrote: From: Dongwon Kim This partially reverts commit 77bf310084dad38b3a2badf01766c659056f1cf2 which causes some guest display corruption when gtk-gl-area is used for GTK rendering (e.g. Wayland Compositor) possibly due to simulataneous accesses on the guest fr

[PULL 2/3] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-05-09 Thread Fabiano Rosas
From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side). Let's do it in a more obvious way he

Re: [PATCH for-10.1 03/10] ui/clipboard: split out QemuClipboardContent

2025-05-09 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:25PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Allows to use VMSTATE STRUCT in following migration support patch. > > Signed-off-by: Marc-André Lureau > --- > include/ui/clipboard.h | 26 -- > 1 file changed, 2

Re: [PATCH for-10.1 06/10] ui/vdagent: replace Buffer with GByteArray

2025-05-09 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:28PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Buffer is slightly more advanced than GByteArray, since it has a > cursor/position. But vdagent code doesn't need it. This simplify a bit > the code, and migration state. > > Signed-off-by:

Re: [PATCH] hw/audio/cs4231a: fix assertion error in isa_bus_get_irq

2025-05-09 Thread Philippe Mathieu-Daudé
Hi Zheng, On 9/5/25 13:15, Zheng Huang wrote: This patch fixes an assertion error in isa_bus_get_irq() in /hw/isa/isa-bus.c by adding a constraint to the irq property. Can you provide a reproducer to trigger that? Signed-off-by: Zheng Huang --- hw/audio/cs4231a.c | 4 1 file change

Re: [PATCH 03/15] hw/intc/loongarch_extioi: Add irqchip-in-kernel save/restore function

2025-05-09 Thread Jiaxun Yang
在2025年5月9日周五 上午11:07,Bibo Mao写道: > Add save and store funtction if irqchip-in-kernel property is enabled, > it is to get/set ExtIOI irqchip state from KVM kernel. > > Signed-off-by: Bibo Mao > --- > hw/intc/loongarch_extioi.c | 17 + > hw/intc/loongarch_extioi_kvm.c | 100

Re: [CFT PATCH 0/4] target/i386/emulate: cleanups

2025-05-09 Thread Magnus Kulke
Hey Paolo, I applied your patches to the x86 emulator in our MSHV branch. They compile cleanly (some off this we had changed on our branch already). I also performed some manual testing and didn't spot any regressions with the changes in the emulator. magnus already). I also performed some manua

[PULL 20/28] vfio: add strread/writeerror()

2025-05-09 Thread Cédric Le Goater
From: John Levon Add simple helpers to correctly report failures from read/write routines using the return -errno style. Signed-off-by: John Levon Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/20250507152020.1254632-7-john.le...@nutanix.com Signed-off-by: Cédric Le Go

[PULL 13/28] linux-header: update-linux-header script changes

2025-05-09 Thread Cédric Le Goater
From: Rorie Reyes Kernel commit 8a141be3233a changed from using ASSEMBLY to ASSEMBLER Updated the update-linux-header script to match Signed-off-by: Rorie Reyes Reviewed-by: Cédric Le Goater Link: https://lore.kernel.org/qemu-devel/20250425052401.8287-2-rre...@linux.ibm.com Signed-off-by: Céd

Re: [PATCH v4 07/27] hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:30 +0200 Philippe Mathieu-Daudé wrote: > The X86MachineClass::fwcfg_dma_enabled boolean was only used > by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got > removed. Remove it and simplify. > > 'multiboot.bin' isn't used anymore, we'll remove it in the > next commi

Re: [PATCH v4 06/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() -> fw_cfg_init_mem_dma()

2025-05-09 Thread Igor Mammedov
On Fri, 9 May 2025 14:51:07 +0800 Zhao Liu wrote: > On Thu, May 08, 2025 at 03:35:29PM +0200, Philippe Mathieu-Daudé wrote: > > Date: Thu, 8 May 2025 15:35:29 +0200 > > From: Philippe Mathieu-Daudé > > Subject: [PATCH v4 06/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem_wide() -> > > fw_cfg_init_

Re: [PATCH] migration: Fix migration failure when aia is configured as 'aplic-imsic'

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 10:08:26AM +0800, liu.xuem...@zte.com.cn wrote: > From: Xuemei Liu > > Address an error in migration by discarding 'riscv_aplic' and 'riscv_imsic' > in vmstate_register_with_alias_id() when aia is configured as > 'aplic-imsic' in riscv kvm vm. > > Previously, the fields i

Re: [PATCH v4 07/27] hw/i386/x86: Remove X86MachineClass::fwcfg_dma_enabled field

2025-05-09 Thread Igor Mammedov
On Fri, 9 May 2025 17:41:25 +0200 Igor Mammedov wrote: > On Thu, 8 May 2025 15:35:30 +0200 > Philippe Mathieu-Daudé wrote: > > > The X86MachineClass::fwcfg_dma_enabled boolean was only used > > by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got > > removed. Remove it and simplify. > > >

Re: [PATCH v4 05/27] hw/nvram/fw_cfg: Factor fw_cfg_init_mem_internal() out

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:28 +0200 Philippe Mathieu-Daudé wrote: > Factor fw_cfg_init_mem_internal() out of fw_cfg_init_mem_wide(). > In fw_cfg_init_mem_wide(), assert DMA arguments are provided. > Callers without DMA have to use the fw_cfg_init_mem() helper. > > Signed-off-by: Philippe Mathieu-

Re: [PATCH] net/af-xdp: Support pinned map path for AF_XDP sockets

2025-05-09 Thread Daniel Borkmann via
Hi Ilya, On 5/9/25 12:53 AM, Ilya Maximets wrote: On 5/8/25 2:34 PM, Daniel Borkmann wrote: Extend inhibit=on setting with the option to specify a pinned XSK map path along with a starting index (default 0) to push the created XSK sockets into. Example usage: # ./build/qemu-system-x86_64 [.

Re: [PATCH v4 24/27] hw/intc/ioapic: Remove IOAPICCommonState::version field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:47PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:47 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 24/27] hw/intc/ioapic: Remove IOAPICCommonState::version > field > X-Mailer: git-send-email 2.47.1 > > The IOAPICCommonState::versio

Re: [PATCH v2 1/6] hw/arm/smmuv3: Add support to associate a PCIe RC

2025-05-09 Thread Peter Maydell
On Fri, 9 May 2025 at 11:46, Daniel P. Berrangé wrote: > > On Fri, May 09, 2025 at 11:37:14AM +0100, Peter Maydell wrote: > > (I want to start here by saying that I appreciate that I'm > > coming in without having read the previous discussion, so > > this is kind of going back over ground you've a

Re: [PATCH v4 11/27] hw/i386/pc: Remove pc_compat_2_6[] array

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:34PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:34 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 11/27] hw/i386/pc: Remove pc_compat_2_6[] array > X-Mailer: git-send-email 2.47.1 > > The pc_compat_2_6[] array was only used by the

[PATCH v2] hw/audio/cs4231a: fix assertion error in isa_bus_get_irq

2025-05-09 Thread Zheng Huang
This patch fixes an assertion error in isa_bus_get_irq() in /hw/isa/isa-bus.c by adding a constraint to the irq property. Patch v1 misused ISA_NUM_IRQS, pls ignore that. Signed-off-by: Zheng Huang --- hw/audio/cs4231a.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/audio/cs4231a.c b

Re: [PATCH] migration: add FEATURE_SEEKABLE to QIOChannelBlock

2025-05-09 Thread Marco Cavenati
Hello Peter, On Thursday, May 08, 2025 22:23 CEST, Peter Xu wrote: > > The scenarios where zeroing is not required (incoming migration and > > -loadvm) share a common characteristic: the VM has not yet run in the > > current QEMU process. > > To avoid splitting read_ramblock_mapped_ram(), could

Re: [PATCH for-10.1 08/10] ui/vdagent: factor out clipboard peer registration

2025-05-09 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:30PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This allows common code reuse during migration. > > Note that resetting the serial is now done regardless if the clipboard > peer was registered or not. This should still be correct. > > S

[PATCH 00/15] hw/loongarch/virt: Add kvm_irqchip_in_kernel support

2025-05-09 Thread Bibo Mao
To enable kvm_irqchip_in_kernel option on LoongArch virt machine platform, property irqchip-in-kernel is added on irqchips including ExtIOI, IPI, PCH_PCI and PCH_MSI irqchip. If property irqchip-in-kernel is set, there is special operations with irqchips in such fields: 1. During irqchip object

Re: [PATCH v3 12/15] vfio: add read/write to device IO ops vector

2025-05-09 Thread John Levon
On Fri, May 09, 2025 at 12:14:02PM +0200, Cédric Le Goater wrote: > !---| > CAUTION: External Email > > |---! > > On 5/7/25 17:20, John Levon wrote: > > Now we have th

Re: [PATCH for-10.1 09/10] ui/vdagent: add migration support

2025-05-09 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:31PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Signed-off-by: Marc-André Lureau > --- > ui/vdagent.c | 139 +++ > 1 file changed, 139 insertions(+) > > diff --git a/ui/vdagent.c b/ui/vda

Re: [PATCH] hw/audio/cs4231a: fix assertion error in isa_bus_get_irq

2025-05-09 Thread Zheng Huang
Hi Philippe, On 2025/5/9 19:28, Philippe Mathieu-Daudé wrote: > Hi Zheng, > > On 9/5/25 13:15, Zheng Huang wrote: >> This patch fixes an assertion error in isa_bus_get_irq() in >> /hw/isa/isa-bus.c by adding a constraint to the irq property. > > Can you provide a reproducer to trigger that? >

[PATCH v2 2/2] semihosting/uaccess: Compile once

2025-05-09 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- semihosting/meson.build | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/semihosting/meson.build b/semihosting/meson.build index f3d38dda91d..d0819891bc3 100644 --- a/semihosting/meson.build +++ b/semihosting/meson.build @@ -3,9 +3,7

Re: [PATCH 2/2] scripts/checkpatch: reimplement SPDX-License-Identifier detection

2025-05-09 Thread Peter Maydell
On Thu, 8 May 2025 at 18:01, Daniel P. Berrangé wrote: > > The new attempt at detecting missing SPDX-License-Identifier in > new files is using the following logic > > * When seeing a line starting 'diff --git ...' it indicates >the start of a file in the patch. This must trigger reporting >

Re: [PATCH v4 09/27] hw/nvram/fw_cfg: Remove fw_cfg_io_properties::dma_enabled

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:32 +0200 Philippe Mathieu-Daudé wrote: > Now than all calls to fw_cfg_init_io_dma() pass DMA arguments, > the 'dma_enabled' of the TYPE_FW_CFG_IO type is not used anymore. > Remove it, simplifying fw_cfg_init_io_dma() and fw_cfg_io_realize(). > > Note, we can not remove

Re: [PATCH v4 10/27] hw/i386/pc: Remove linuxboot.bin

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:33 +0200 Philippe Mathieu-Daudé wrote: > All PC machines now use the linuxboot_dma.bin binary, > we can remove the non-DMA version (linuxboot.bin). > > Suggested-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc.c | 3 +-

[RFC PATCH v8 4/6] hw/vfio/ap: store object indicating AP config changed in a queue

2025-05-09 Thread Rorie Reyes
Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off-by: Rorie Reyes --- hw/vfio/ap.c | 12 +++

Re: [PATCH v4 10/13] memory: Change NotifyStateClear() definition to return the result

2025-05-09 Thread Baolu Lu
On 4/27/2025 10:26 AM, Chenyi Qiang wrote: Hi David, Any thought on patch 10-12, which is to move the change attribute into a priority listener. A problem is how to handle the error handling of private_to_shared failure. Previously, we thought it would never be able to fail, but right now, it is

Re: [PATCH v4 11/13] KVM: Introduce CVMPrivateSharedListener for attribute changes during page conversions

2025-05-09 Thread Baolu Lu
On 4/7/2025 3:49 PM, Chenyi Qiang wrote: With the introduction of the RamBlockAttribute object to manage RAMBlocks with guest_memfd and the implementation of PrivateSharedManager interface to convey page conversion events, it is more elegant to move attribute changes into a PrivateSharedListener.

[PATCH 06/15] hw/intc/loongson_ipi: Add load and save interface with ipi_common class

2025-05-09 Thread Bibo Mao
Add pre_save and post_load interfaces with ipi_common class, here only framework ipi_common adds these interfaces. The defailed implementation is LoongArchIPI child device in later. Signed-off-by: Bibo Mao --- hw/intc/loongson_ipi_common.c | 28 +++ include/hw/int

Re: [PATCH v4 07/13] ram-block-attribute: Introduce RamBlockAttribute to manage RAMBLock with guest_memfd

2025-05-09 Thread Baolu Lu
On 4/7/25 15:49, Chenyi Qiang wrote: Commit 852f0048f3 ("RAMBlock: make guest_memfd require uncoordinated discard") highlighted that subsystems like VFIO may disable RAM block discard. However, guest_memfd relies on discard operations for page conversion between private and shared memory, potenti

Re: [PATCH v4 10/13] memory: Change NotifyStateClear() definition to return the result

2025-05-09 Thread David Hildenbrand
On 09.05.25 04:38, Chao Gao wrote: On Sun, Apr 27, 2025 at 10:26:52AM +0800, Chenyi Qiang wrote: Hi David, Any thought on patch 10-12, which is to move the change attribute into a priority listener. A problem is how to handle the error handling of private_to_shared failure. Previously, we thoug

Re: [PATCH v10 2/3] tests/qtest/migration: add postcopy tests with multifd

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 10:56:05AM +0530, Prasad Pandit wrote: > On Fri, 9 May 2025 at 00:34, Peter Xu wrote: > > I may not have followed the whole discussions, but have you tried to avoid > > this global? > > -> https://lore.kernel.org/qemu-devel/875xkyyxyy@suse.de/ > > * Yes, it was di

Re: [PULL 22/23] tests/function/aspeed: Add functional test for ast2700fc

2025-05-09 Thread Cédric Le Goater
On 5/6/25 16:22, Peter Maydell wrote: On Mon, 5 May 2025 at 10:12, Cédric Le Goater wrote: From: Steven Lee Introduce a new test suite for ast2700fc machine. Rename the original test_aarch64_aspeed.py to test_aarch64_aspeed_ast2700.py. Signed-off-by: Steven Lee Change-Id: I3855f55c9f6e5cca

Re: [PATCH 1/1] vhost: do not reset used_memslots when destroying vhost dev

2025-05-09 Thread Michael S. Tsirkin
On Mon, Mar 03, 2025 at 01:02:17PM -0500, yuanminghao wrote: > > > Global used_memslots or used_shared_memslots is updated to 0 unexpectly > > > > it shouldn't be 0 in practice, as it comes from number of RAM regions VM > > has. > > It's likely a bug somewhere else. > > > > Please describe a way

[RFC PATCH v8 1/6] linux-header: update-linux-header script changes

2025-05-09 Thread Rorie Reyes
Kernel commit 8a141be3233a changed from using ASSEMBLY to ASSEMBLER Updated the update-linux-header script to match Signed-off-by: Rorie Reyes --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-

Re: [PATCH v2 2/2] semihosting/uaccess: Compile once

2025-05-09 Thread Pierrick Bouvier
Hi Philippe, On 5/9/25 4:07 AM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- semihosting/meson.build | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/semihosting/meson.build b/semihosting/meson.build index f3d38dda91d..d0819891bc3 100644 --- a

[RFC PATCH v8 2/6] linux-headers: Update to Linux v6.15-rc3

2025-05-09 Thread Rorie Reyes
Update headers to retrieve uapi information for vfio-ap Signed-off-by: Rorie Reyes --- include/standard-headers/asm-x86/setup_data.h | 4 +- include/standard-headers/drm/drm_fourcc.h | 41 ++ include/standard-headers/linux/const.h| 2 +- include/standard-headers/linux/ethtoo

Re: [PATCH for-10.1 02/10] ui/clipboard: use int for selection field

2025-05-09 Thread Daniel P . Berrangé
On Tue, Mar 11, 2025 at 07:59:24PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This allows to use a VMSTATE_INT32 field for migration purposes. > > Signed-off-by: Marc-André Lureau > --- > include/ui/clipboard.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-

Re: [PATCH v4 13/27] target/i386/cpu: Remove CPUX86State::fill_mtrr_mask field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:36PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:36 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 13/27] target/i386/cpu: Remove > CPUX86State::fill_mtrr_mask field > X-Mailer: git-send-email 2.47.1 > > The CPUX86State::fill_mtrr_

[PULL 00/28] vfio queue

2025-05-09 Thread Cédric Le Goater
The following changes since commit 4b1f5b73e060971c434e70694d571adfee553027: tests/functional: Use -no-shutdown in the hppa_seabios test (2025-05-08 15:38:40 -0400) are available in the Git repository at: https://github.com/legoater/qemu/ tags/pull-vfio-20250509 for you to fetch changes

Re: [PULL 00/30] Rust, wasm changes for 2025-05-06

2025-05-09 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/10.1 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL v2, part1 00/15] Rust changes for 2025-05-06

2025-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2025 at 05:54:39PM +0200, Paolo Bonzini wrote: > The following changes since commit a9e0c9c0f14e19d23443ac24c8080b4708d2eab8: > > Merge tag 'pull-9p-20250505' of https://github.com/cschoenebeck/qemu into > staging (2025-05-05 11:26:59 -0400) > > are available in the Git reposit

Re: [PATCH v4 02/27] hw/i386/pc: Remove PCMachineClass::legacy_cpu_hotplug field

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:25 +0200 Philippe Mathieu-Daudé wrote: > The PCMachineClass::legacy_cpu_hotplug boolean was only used > by the pc-q35-2.6 and pc-i440fx-2.6 machines, which got > removed. Remove it and simplify build_dsdt(), removing > build_legacy_cpu_hotplug_aml() altogether. > > Note

Re: [PATCH v10 3/3] migration: write zero pages when postcopy enabled

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 11:34:06AM +0530, Prasad Pandit wrote: > > > This patch should come before 1/3, otherwise it'll break bisect. > > We could squash the two together, IMHO. > > * It is adjusting the specific optimisation behaviour for the use case > of when Multifd and Postcopy are enabled to

[PATCH] docs/devel/testing/functional: Fix typo

2025-05-09 Thread Gustavo Romero
Fix the duplication of the word 'run'. Signed-off-by: Gustavo Romero --- docs/devel/testing/functional.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/testing/functional.rst b/docs/devel/testing/functional.rst index 8030cb4299..9e56dd1b11 100644 --- a/docs/dev

Re: [PATCH] system/physmem: Fix UBSan finding in address_space_write_rom_internal

2025-05-09 Thread Peter Xu
On Tue, May 06, 2025 at 02:21:08PM +0100, Peter Maydell wrote: > On Mon, 5 May 2025 at 23:23, Joe Komlodi wrote: > > > > address_space_write_rom_internal can take in a NULL pointer for ptr if > > it's only doing cache flushes instead of populating the ROM. > > > > However, if building with --enabl

Re: [PATCH v4 01/27] hw/i386/pc: Remove deprecated pc-q35-2.6 and pc-i440fx-2.6 machines

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:24 +0200 Philippe Mathieu-Daudé wrote: > These machines has been supported for a period of more than 6 years. > According to our versioned machine support policy (see commit > ce80c4fa6ff "docs: document special exception for machine type > deprecation & removal") they c

Re: [PATCH] docs/devel/testing/functional: Fix typo

2025-05-09 Thread Peter Maydell
On Fri, 9 May 2025 at 16:22, Gustavo Romero wrote: > > Fix the duplication of the word 'run'. > > Signed-off-by: Gustavo Romero > --- > docs/devel/testing/functional.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/testing/functional.rst > b/docs/devel/tes

Re: [PULL 22/23] tests/function/aspeed: Add functional test for ast2700fc

2025-05-09 Thread Peter Maydell
On Fri, 9 May 2025 at 15:32, Cédric Le Goater wrote: > In the ast2700fc machine and the fby35, each SoC has its own memory > region and, since there is no need for the global system memory > region, it's empty. But in some places, like > rom_check_and_register_reset(), it's a problem for the flatt

Re: [PATCH v2 2/2] qtest/migration/rdma: Add test for rdma migration with ipv6

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 09:42:11AM +0800, Li Zhijian wrote: > Recently, we removed ipv6 restriction[0] from RDMA migration, add a > test for it. > > [0] > https://lore.kernel.org/qemu-devel/20250326095224.9918-1-jinpu.w...@ionos.com/ > > Cc: Jack Wang > Cc: Michael R. Galaxy > Cc: Peter Xu >

Re: [PATCH v2 1/2] qtest/migration/rdma: Enforce RLIMIT_MEMLOCK >= 128MB requirement

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 09:42:10AM +0800, Li Zhijian wrote: > Ensure successful migration over RDMA by verifying that RLIMIT_MEMLOCK is > set to at least 128MB. This allocation is necessary due to the requirement > to pin significant portions of guest memory, typically exceeding 100MB > in this tes

Re: [PATCH v4 03/27] hw/nvram/fw_cfg: Rename fw_cfg_init_mem() with '_nodma' suffix

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:26 +0200 Philippe Mathieu-Daudé wrote: > Rename fw_cfg_init_mem() as fw_cfg_init_mem_nodma() > to distinct with the DMA version (currently named > fw_cfg_init_mem_wide). > > Suggested-by: Zhao Liu > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov >

Re: [PATCH v4 04/27] hw/mips/loongson3_virt: Prefer using fw_cfg_init_mem_nodma()

2025-05-09 Thread Igor Mammedov
On Thu, 8 May 2025 15:35:27 +0200 Philippe Mathieu-Daudé wrote: > fw_cfg_init_mem_wide() is prefered to initialize fw_cfg > with DMA support. Without DMA, use fw_cfg_init_mem_nodma(). > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > hw/mips/loongson3_virt.c | 2

Re: [PATCH v2] hw/arm: Replace TABs for spaces

2025-05-09 Thread Peter Maydell
On Mon, 5 May 2025 at 14:11, Santiago Monserrat Campanello wrote: > > replaced all TABs for spaces for arm code > > Signed-off-by: Santiago Monserrat Campanello > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/373 > > --- > replaced all tabs with spaces using vim :retab > used 4 spaces e

Re: [PATCH v3 00/15] vfio: preparation for vfio-user

2025-05-09 Thread Cédric Le Goater
On 5/9/25 12:24, Cédric Le Goater wrote: On 5/7/25 17:20, John Levon wrote: Hi, this series is against the vfio-next tree: https://github.com/legoater/qemu/commits/vfio-next The series contains patches to vfio to prepare for the vfio-user implementation. A previous version of these patches can

Re: [PULL v2 00/21] Trivial patches for 2025-05-07

2025-05-09 Thread Stefan Hajnoczi
On Wed, May 7, 2025 at 2:08 PM Michael Tokarev wrote: > > The following changes since commit c5e2c4042e3c50b96cc5eaa9683325c5a96913b0: > > Merge tag 'pull-loongarch-20250506' of https://github.com/bibo-mao/qemu > into staging (2025-05-06 11:03:45 -0400) > > are available in the Git repository a

[PATCH 0/7] hw/cxl: Update CXL events to rev3.2 and add maintenance support for memory repair features

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose Add updates for the CXL spec rev3.2 changes, in the CXL events reporting and QMP command to inject CXL events. Add maintenance support and emulation support for memory Post Package Repair(PPR) and memory sparing control features. Davidlohr Bueso (1): hw/cxl: Add Maintenance s

[PATCH 7/7] hw/cxl: Add emulation for memory sparing control feature

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose Memory sparing is defined as a repair function that replaces a portion of memory with a portion of functional memory at that same DPA. The subclasses for this operation vary in terms of the scope of the sparing being performed. The Cacheline sparing subclass refers to a sparing a

[PATCH 2/7] hw/cxl/events: Updates for rev3.2 general media event record

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose CXL spec rev3.2 section 8.2.10.2.1.1 Table 8-57, general media event table has updated with following new fields. 1. Advanced Programmable Corrected Memory Error Threshold Event Flags 2. Corrected Memory Error Count at Event 3. Memory Event Sub-Type Add updates for the above spe

[PATCH 4/7] hw/cxl/events: Updates for rev3.2 memory module event record

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose CXL spec rev3.2 section 8.2.10.2.1.3 Table 8-50, memory module event record has updated with following new fields. 1. Validity Flags 2. Component Identifier 3. Device Event Sub-Type Add updates for the above spec changes in the CXL memory module event reporting and QMP command t

[PATCH 6/7] hw/cxl: Add Maintenance support

2025-05-09 Thread shiju . jose--- via
From: Davidlohr Bueso This adds initial support for the Maintenance command, specifically the soft and hard PPR operations on a dpa. The implementation allows to be executed at runtime, therefore semantically, data is retained and CXL.mem requests are correctly processed. Keep track of the reque

[PATCH 3/7] hw/cxl/events: Updates for rev3.2 DRAM event record

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose CXL spec rev3.2 section 8.2.10.2.1.2 Table 8-58, DRAM event record has updated with following new fields. 1. Component Identifier 2. Sub-channel of the memory event location 3. Advanced Programmable Corrected Memory Error Threshold Event Flags 4. Corrected Volatile Memory Error C

[PATCH 5/7] hw/cxl/cxl-mailbox-utils: Move declaration of scrub and ECS feature attributes in cmd_features_set_feature()

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose Move the declaration of scrub and ECS feature attributes in cmd_features_set_feature() to the local scope where they are used. Signed-off-by: Shiju Jose --- hw/cxl/cxl-mailbox-utils.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/cxl/cxl

Re: [PATCH] tests/functional: Use -no-shutdown in the hppa_seabios test

2025-05-09 Thread Philippe Mathieu-Daudé
On 8/5/25 20:09, Thomas Huth wrote: From: Thomas Huth qemu-system-hppa shuts down automatically when the BIOS is unable to boot from any device. So this test currently fails occasionally when QEMU already quit, but the test still expected it to be around (e.g. to shut it down cleanly). Adding a

Re: [PATCH v3 0/5] docs: automated info about machine deprecation/removal info

2025-05-09 Thread Michael S. Tsirkin
On Tue, May 06, 2025 at 05:00:19PM +0100, Daniel P. Berrangé wrote: > Since we deprecate and remove versioned machine types on a fixed > schedule, we can automatically ensure that the docs reflect the > latest version info, rather than requiring manual updates on each > dev cycle. > > The first pa

[PATCH 1/7] hw/cxl/events: Update for rev3.2 common event record format

2025-05-09 Thread shiju . jose--- via
From: Shiju Jose CXL spec 3.2 section 8.2.9.2.1 Table 8-55, Common Event Record format has updated with Maintenance Operation Subclass, LD ID and ID of the device head information. Add updates for the above spec changes in the related CXL events reporting and QMP command to inject CXL events. S

[PATCH] s390x: Fix leak in machine_set_loadparm

2025-05-09 Thread Fabiano Rosas
ASAN spotted a leaking string in machine_set_loadparm(): Direct leak of 9 byte(s) in 1 object(s) allocated from: #0 0x560ffb5bb379 in malloc ../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3 #1 0x7f1aca926518 in g_malloc ../glib/gmem.c:106 #2 0x7f1aca94113e in g_strdup ../gl

[PATCH] tests/qtest/ast2700-smc-test: Fix leak

2025-05-09 Thread Fabiano Rosas
ASAN spotted a leak of the memory used to hold the tmp_path: Direct leak of 35 byte(s) in 1 object(s) allocated from: #0 0x55e29aa96da9 in malloc ../projects/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3 #1 0x7fe0cfb26518 in g_malloc ../glib/gmem.c:106 #2 0x7fe0cfb4146e in g_strconc

Re: [PATCH] migration: add FEATURE_SEEKABLE to QIOChannelBlock

2025-05-09 Thread Peter Xu
On Fri, May 09, 2025 at 02:51:47PM +0200, Marco Cavenati wrote: > Hello Peter, > > On Thursday, May 08, 2025 22:23 CEST, Peter Xu wrote: > > > > The scenarios where zeroing is not required (incoming migration and > > > -loadvm) share a common characteristic: the VM has not yet run in the > > > c

Re: [PATCH v4 16/27] hw/virtio/virtio-mmio: Remove VirtIOMMIOProxy::format_transport_address field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:39PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:39 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 16/27] hw/virtio/virtio-mmio: Remove > VirtIOMMIOProxy::format_transport_address field > X-Mailer: git-send-email 2.47.1 > > The Vir

Re: [PATCH v4 17/27] hw/i386/pc: Remove deprecated pc-q35-2.7 and pc-i440fx-2.7 machines

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:40PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:40 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 17/27] hw/i386/pc: Remove deprecated pc-q35-2.7 and > pc-i440fx-2.7 machines > X-Mailer: git-send-email 2.47.1 > > These machines ha

Re: [PATCH v4 18/27] hw/i386/pc: Remove pc_compat_2_7[] array

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:41PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:41 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 18/27] hw/i386/pc: Remove pc_compat_2_7[] array > X-Mailer: git-send-email 2.47.1 > > The pc_compat_2_7[] array was only used by the

Re: [PATCH v4 26/27] hw/char/virtio-serial: Do not expose the 'emergency-write' property

2025-05-09 Thread Mark Cave-Ayland
On 08/05/2025 14:35, Philippe Mathieu-Daudé wrote: The VIRTIO_CONSOLE_F_EMERG_WRITE feature bit was only set in the hw_compat_2_7[] array, via the 'emergency-write=off' property. We removed all machines using that array, lets remove that property. All instances have this feature bit set and it c

Re: [PATCH v4 19/27] target/i386/cpu: Remove CPUX86State::full_cpuid_auto_level field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:42PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:42 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 19/27] target/i386/cpu: Remove > CPUX86State::full_cpuid_auto_level field > X-Mailer: git-send-email 2.47.1 > > The CPUX86State::ful

Re: [PATCH 1/2] util: fix msan findings in keyval

2025-05-09 Thread Daniel P . Berrangé
On Fri, May 09, 2025 at 07:48:57AM +0200, Markus Armbruster wrote: > Nabih Estefan writes: > > > From: Peter Foley > > > > e.g. > > I 2025-02-28 09:51:05.240071-0800 624 stream.go:47qemu: > > Uninitialized value was created by an allocation of 'key_in_cur.i' in the > > stack

Re: [PATCH v4 22/27] hw/core/machine: Remove hw_compat_2_7[] array

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:45PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:45 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 22/27] hw/core/machine: Remove hw_compat_2_7[] array > X-Mailer: git-send-email 2.47.1 > > The hw_compat_2_7[] array was only used by

Re: [PATCH v4 21/27] hw/audio/pcspk: Remove PCSpkState::migrate field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:44PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:44 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 21/27] hw/audio/pcspk: Remove PCSpkState::migrate field > X-Mailer: git-send-email 2.47.1 > > The PCSpkState::migrate boolean was onl

Re: [PATCH v4 14/27] hw/intc/apic: Remove APICCommonState::legacy_instance_id field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:37PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:37 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 14/27] hw/intc/apic: Remove > APICCommonState::legacy_instance_id field > X-Mailer: git-send-email 2.47.1 > > The APICCommonState::l

Re: [PATCH v4 23/27] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field

2025-05-09 Thread Zhao Liu
On Thu, May 08, 2025 at 03:35:46PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 8 May 2025 15:35:46 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH v4 23/27] hw/i386/intel_iommu: Remove > IntelIOMMUState::buggy_eim field > X-Mailer: git-send-email 2.47.1 > > The IntelIOMMUState::bug

  1   2   3   >