Re: KVM/QEMU Community call 29/04/2025 agenda items?

2025-04-30 Thread Philippe Mathieu-Daudé
On 30/4/25 12:41, Markus Armbruster wrote: Paolo Bonzini writes: Il lun 28 apr 2025, 14:58 Philippe Mathieu-Daudé ha scritto: On 28/4/25 13:05, Alex Bennée wrote: Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 29/04/2025 14:00 UTC Are there any agenda items

Re: [PATCH] docs/devel/build-environment: enhance MSYS2 instructions

2025-04-30 Thread Pierrick Bouvier
On 4/30/25 3:09 AM, Thomas Huth wrote: On 28/04/2025 21.35, Pierrick Bouvier wrote: On 3/24/25 10:47 AM, Pierrick Bouvier wrote: On 3/5/25 13:38, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier ---    docs/devel/build-environment.rst | 4 ++--    1 file changed, 2 insertions(+), 2 de

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Thomas Huth
On 30/04/2025 15.50, Philippe Mathieu-Daudé wrote: On 30/4/25 15:28, Thomas Huth wrote: From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping  in the qtest_read/wri

Re: [PATCH v3 5/5] utils/qemu-sockets: Introduce inet socket options controlling TCP keep-alive

2025-04-30 Thread Juraj Marcin
Hi Daniel On 2025-04-11 16:49, Daniel P. Berrangé wrote: > On Fri, Apr 11, 2025 at 02:54:29PM +0100, Daniel P. Berrangé wrote: > > On Tue, Apr 08, 2025 at 01:25:04PM +0200, Juraj Marcin wrote: > > > From: Juraj Marcin > > > > > > With the default TCP stack configuration, it could be even 2 hours

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Alex Bennée
Thomas Huth writes: > From: Thomas Huth > > The logic in the qvirtio_read/write function is rather a headache, > involving byte-swapping when the target is big endian, just to > maybe involve another byte-swapping in the qtest_read/write > function immediately afterwards (on the QEMU side). Let

Re: [PATCH 0/5] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-04-30 Thread Thomas Huth
On 30/04/2025 16.26, Philippe Mathieu-Daudé wrote: The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can remove them. This series only includes the 2.6 and 2.7 machines removal, as it is

Re: [PATCH 12/13] target/arm/cpu: compile file twice (user, system) only

2025-04-30 Thread Pierrick Bouvier
On 4/30/25 1:32 AM, Philippe Mathieu-Daudé wrote: On 29/4/25 07:00, Pierrick Bouvier wrote: Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index c39ddc4427

[PATCH v2 00/12] single-binary: compile target/arm twice

2025-04-30 Thread Pierrick Bouvier
More work toward single-binary. This series convert target/arm/cpu.c. Built on {linux, windows, macos} x {x86_64, aarch64} Fully tested on linux-x86_64 v2 -- - Remove duplication of kvm struct and constant (Alex) - Use target_big_endian() (Anton) Philippe Mathieu-Daudé (1): target/arm: Replac

[PATCH v2 06/12] target/arm/cpu: move arm_cpu_kvm_set_irq to kvm.c

2025-04-30 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/kvm_arm.h | 2 ++ target/arm/cpu.c | 31 --- target/arm/kvm-stub.c | 5 + target/arm/kvm.c | 29 + 4 files changed, 36 insertions(+), 31 deletions(-) diff --git a/target/arm/kv

[PATCH v2 01/12] target/arm: Replace target_ulong -> uint64_t for HWBreakpoint

2025-04-30 Thread Pierrick Bouvier
From: Philippe Mathieu-Daudé CPUARMState::pc is of type uint64_t. Reviewed-by: Pierrick Bouvier Reviewed-by: Alex Bennée Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Pierrick Bouvier --- target/arm/internals.h | 6 +++--- target/arm/hyp_gdbstub.c | 6 +++--- 2 files changed, 6 ins

Re: [RFC PATCH] target/ppc: Inline most of dcbz helper

2025-04-30 Thread BALATON Zoltan
On Wed, 30 Apr 2025, Alex Bennée wrote: BALATON Zoltan writes: On Wed, 30 Apr 2025, Nicholas Piggin wrote: On Wed Apr 30, 2025 at 7:09 AM AEST, BALATON Zoltan wrote: On Tue, 29 Apr 2025, Alex Bennée wrote: BALATON Zoltan writes: On Tue, 29 Apr 2025, Alex Bennée wrote: BALATON Zoltan writ

Re: [PATCH v2 01/20] mcd: Introduce Multi-Core Debug (MCD) API

2025-04-30 Thread Mario Fleischmann
On 30.04.2025 14:56, Daniel P. Berrangé wrote: > On Wed, Apr 30, 2025 at 02:47:07PM +0200, Mario Fleischmann wrote: >> On 30.04.2025 10:20, Daniel P. Berrangé wrote: >>> On Wed, Apr 30, 2025 at 07:27:22AM +0200, Mario Fleischmann wrote: [...] diff --git a/mcd/mcd_api.h b/mcd/mcd_api.h n

Re: [PATCH v3 0/9] Introduce AST27x0 multi-SoC machine

2025-04-30 Thread Cédric Le Goater
Hello Steven, On 4/29/25 11:18, Steven Lee wrote: This patch series introduces full core support for the AST27x0 SoC, along with necessary updates to the ASPEED AST27x0 SOC. The AST27x0 SoC is a new family of ASPEED SoCs featuring 4 Cortex-A35 cores and 2 Cortex-M4 cores. v1: - Map unimple

Re: [PATCH v3 9/9] docs: Add support for ast2700fc machine

2025-04-30 Thread Cédric Le Goater
On 4/29/25 11:18, Steven Lee wrote: - Updated Aspeed family boards list to include `ast2700fc`. - Added boot instructions for the `ast2700fc` machine. - Detailed the configuration and loading of firmware for the Cortex-A35 and Cortex-M4 processors. Signed-off-by: Steven Lee Change-Id: I48d90

Re: [PATCH v3 8/9] tests/function/aspeed: Add functional test for AST2700FC

2025-04-30 Thread Cédric Le Goater
On 4/29/25 11:18, Steven Lee wrote: Add functional test for AST2700-fc machine. Signed-off-by: Steven Lee Change-Id: Ieced249cf471515a33f8f5f5386a2f58d431f2f9 ---> tests/functional/test_aarch64_ast2700fc.py | 137 + 1 file changed, 137 insertions(+) create mode 100755 t

[PATCH] target/riscv: Fix fcvt.s.bf16 NaN box checking

2025-04-30 Thread Anton Blanchard
fcvt.s.bf16 uses the FP16 check_nanbox_h() which returns an FP16 quiet NaN. Add check_nanbox_bf16() which returns a BF16 quiet NaN. --- target/riscv/fpu_helper.c | 2 +- target/riscv/internals.h | 16 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/target/riscv/fp

Re: [PATCH v5 1/7] new configure option to enable gstreamer

2025-04-30 Thread Thomas Huth
On 30/04/2025 09.25, Dietmar Maurer wrote: GStreamer is required to implement H264 encoding for VNC. Please note that QEMU already depends on this library when you enable Spice. Signed-off-by: Dietmar Maurer --- meson.build | 10 ++ meson_options.txt |

Re: [PATCH 4/9] target/microblaze: Use uint64_t for CPUMBState.ear

2025-04-30 Thread Philippe Mathieu-Daudé
On 12/2/25 23:01, Richard Henderson wrote: Use an explicit 64-bit type for EAR. Signed-off-by: Richard Henderson --- target/microblaze/cpu.h | 2 +- target/microblaze/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/cpu.h b/target/mi

Re: Problem building (docs) with -j1

2025-04-30 Thread Peter Maydell
On Wed, 30 Apr 2025 at 10:14, Dario Faggioli wrote: > > Hello, > > When building both v10.0.0 and master sequentially (like -j1 or > equivalent, e.g., when in a 1 vCPU VM) it fails when we get to docs > (`make man` is also enough to reproduce it), with this error: > > [1/2] /usr/bin/env CONFDIR=

Re: [PATCH v2] Running with `--enable-ubsan` leads to a qtest failure:

2025-04-30 Thread Peter Maydell
On Tue, 29 Apr 2025 at 16:56, Nabih Estefan wrote: > > v2: used ldl_le_p and lduw_l_p instead of memcpy as per upstream > suggestion. > > ``` > ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned address > 0x562040be8e33 for type 'uint32_t', which requires 4 byte alignment > ```

[PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Thomas Huth
From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side). Let's do it in a more obvious way he

Re: [PATCH v2 1/1] system: optimizing info mtree printing for monitors

2025-04-30 Thread Markus Armbruster
Chao Liu writes: > Make the hierarchical relationship between nodes clearer by adding characters > > e.g. > > qemu-system-riscv64 -M virt -monitor stdio -display none > > ``` > (qemu) info mtree > ... > memory-region: system > │ ├── - (prio 0, i/o): system > │ │

Re: [BUG, RFC] Block graph deadlock on job-dismiss

2025-04-30 Thread Andrey Drobyshev
On 4/30/25 11:47 AM, Fiona Ebner wrote: > Am 24.04.25 um 19:32 schrieb Andrey Drobyshev: >> So it looks like main thread is processing job-dismiss request and is >> holding write lock taken in block_job_remove_all_bdrv() (frame #20 >> above). At the same time iothread spawns a coroutine which perf

[PATCH v2 10/12] target/arm/cpu: remove TARGET_AARCH64 in arm_cpu_finalize_features

2025-04-30 Thread Pierrick Bouvier
Need to stub cpu64 finalize functions. Signed-off-by: Pierrick Bouvier --- target/arm/cpu.c | 2 -- target/arm/cpu32-stubs.c | 24 target/arm/meson.build | 11 +++ 3 files changed, 31 insertions(+), 6 deletions(-) create mode 100644 target/arm/cpu32-s

[PATCH v2 11/12] target/arm/cpu: compile file twice (user, system) only

2025-04-30 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/target/arm/meson.build b/target/arm/meson.build index c39ddc4427b..89e305eb56a 100644 --- a/target/arm/meson.build +++ b/target/arm/meson.build @@ -1,6 +1,6 @@ ar

[PATCH v2 09/12] target/arm/cpu: remove TARGET_AARCH64 around aarch64_cpu_dump_state common

2025-04-30 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/cpu.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 37b11e8866f..00ae2778058 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1183,8 +1183,6 @@ static void arm_disas_set_info(CPUStat

[PATCH v2 02/12] include/system/hvf: missing vaddr include

2025-04-30 Thread Pierrick Bouvier
On MacOS x86_64: In file included from ../target/i386/hvf/x86_task.c:13: /Users/runner/work/qemu/qemu/include/system/hvf.h:42:5: error: unknown type name 'vaddr' vaddr pc; ^ /Users/runner/work/qemu/qemu/include/system/hvf.h:43:5: error: unknown type name 'vaddr' vaddr saved_insn;

[PATCH v2 05/12] target/arm/kvm-stub: add kvm_arm_reset_vcpu stub

2025-04-30 Thread Pierrick Bouvier
Needed in target/arm/cpu.c once kvm is possible. Signed-off-by: Pierrick Bouvier --- target/arm/kvm-stub.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/arm/kvm-stub.c b/target/arm/kvm-stub.c index 2b73d0598c1..e34d3f5e6b4 100644 --- a/target/arm/kvm-stub.c +++ b/target/arm/kvm

[PATCH v2 12/12] target/arm/cpu32-stubs.c: compile file twice (user, system)

2025-04-30 Thread Pierrick Bouvier
It could be squashed with commit introducing it, but I would prefer to introduce target/arm/cpu.c first. Signed-off-by: Pierrick Bouvier --- target/arm/meson.build | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/arm/meson.build b/target/arm/meson.build i

[PATCH v2 08/12] target/arm/cpu: remove TARGET_BIG_ENDIAN dependency

2025-04-30 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- target/arm/cpu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index 07f279fec8c..37b11e8866f 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -23,6 +23,7 @@ #include "qemu/timer.h" #include "

[PATCH v2 07/12] accel/hvf: add hvf_enabled() for common code

2025-04-30 Thread Pierrick Bouvier
Other accelerators define a CONFIG_{accel}_IS_POSSIBLE when COMPILING_PER_TARGET is not defined, except hvf. Without this change, target/arm/cpu.c can't find hvf_enabled. Signed-off-by: Pierrick Bouvier --- include/system/hvf.h | 14 +- accel/hvf/hvf-stub.c | 3 +++ accel/hvf/mes

Re: [PATCH v1 1/1] system: optimizing info mtree printing for monitors

2025-04-30 Thread David Hildenbrand
On 30.04.25 06:02, Chao Liu wrote: Make the hierarchical relationship between nodes clearer by adding characters You should probably move most of your cover letter, including the example, in here. Signed-off-by: Chao Liu --- system/memory.c | 34 +++--- 1 file

Re: [PATCH v2 01/20] mcd: Introduce Multi-Core Debug (MCD) API

2025-04-30 Thread Daniel P . Berrangé
On Wed, Apr 30, 2025 at 07:27:22AM +0200, Mario Fleischmann wrote: > Formatting changes to mcd_api.h to compily with QEMU's coding style > guidelines: > > * limit line width to 80 > * convert Doxygen to kernel-doc comments > * avoid architecture specific defines > > The original MCD API version

Re: [PATCH] qtest/migration/rdma: Add test for rdma migration with ipv6

2025-04-30 Thread Zhijian Li (Fujitsu)
On 30/04/2025 16:28, Li Zhijian wrote: > > > On 30/04/2025 05:09, Peter Xu wrote: >> On Thu, Mar 27, 2025 at 10:12:34AM +0800, Li Zhijian wrote: >>> Recently, we removed ipv6 restriction[0] from RDMA migration, add a >>> test for it. >>> >>> [0] >>> https://lore.kernel.org/qemu-devel/202503260

Re: [BUG, RFC] Block graph deadlock on job-dismiss

2025-04-30 Thread Fiona Ebner
Am 24.04.25 um 19:32 schrieb Andrey Drobyshev: > So it looks like main thread is processing job-dismiss request and is > holding write lock taken in block_job_remove_all_bdrv() (frame #20 > above). At the same time iothread spawns a coroutine which performs IO > request. Before the coroutine is s

Re: [PATCH] Drop support for Python 3.8

2025-04-30 Thread Thomas Huth
Hi! On 25/04/2025 17.13, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: On 25/4/25 14:07, Thomas Huth wrote: From: Thomas Huth Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped this version already, so the "python" CI job is currently failing. Thus it's time to dr

[PATCH] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Thomas Huth
From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side). Let's do it in a more obvious way he

[PATCH v3 1/1] system: optimizing info mtree printing for monitors

2025-04-30 Thread Chao Liu
Make the hierarchical relationship between nodes clearer by adding characters e.g. qemu-system-riscv64 -M virt -monitor stdio -display none ``` (qemu) info mtree ... memory-region: system │ ├── - (prio 0, i/o): system │ │ ├── 0300-0300

[PATCH v3 0/1] Optimizing the print format of the QEMU monitor 'info mtree'

2025-04-30 Thread Chao Liu
Hi, all: Thanks to philmd's review, I've made the following improvements in PATCH v3: Use more maintainable c functions instead of macros, as per review comments. PATCH v2 changelog: 1. Enrich the commit message, add 'info mtree' print example. 2. Optimize the code implementation according to th

Re: KVM/QEMU Community call 29/04/2025 agenda items?

2025-04-30 Thread Markus Armbruster
Paolo Bonzini writes: > Il lun 28 apr 2025, 14:58 Philippe Mathieu-Daudé ha > scritto: > >> On 28/4/25 13:05, Alex Bennée wrote: >> > >> > Hi, >> > >> > The KVM/QEMU community call is at: >> > >> > https://meet.jit.si/kvmcallmeeting >> > @ >> > 29/04/2025 14:00 UTC >> > >> > Are there any agenda

Re: [PATCH] Drop support for Python 3.8

2025-04-30 Thread Markus Armbruster
Thomas Huth writes: > Hi! > > On 25/04/2025 17.13, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >>> On 25/4/25 14:07, Thomas Huth wrote: From: Thomas Huth Python 3.8 went "end of life" in October 2024 and Fedora 42 dropped this version already, so the "python" CI j

Re: [PATCH v2] Running with `--enable-ubsan` leads to a qtest failure:

2025-04-30 Thread Alex Bennée
Nabih Estefan writes: > v2: used ldl_le_p and lduw_l_p instead of memcpy as per upstream > suggestion. > > ``` > ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned address > 0x562040be8e33 for type 'uint32_t', which requires 4 byte alignment > ``` > Instead of straight casting

Re: [PATCH 0/9] target/microblaze: Always use TARGET_LONG_BITS == 32

2025-04-30 Thread Edgar E. Iglesias
On Wed, Apr 30, 2025 at 09:29:20AM +0200, Philippe Mathieu-Daudé wrote: > On 30/4/25 08:26, Philippe Mathieu-Daudé wrote: > > Hi, > > > > On 13/2/25 13:37, Philippe Mathieu-Daudé wrote: > > > +AMD folks > > > > > > On 12/2/25 23:01, Richard Henderson wrote: > > > > Use out-of-line helpers to impl

Re: [PATCH 1/4] tests/vmstate-static-checker-data: Remove old dump files

2025-04-30 Thread Thomas Huth
On 30/04/2025 00.13, Peter Xu wrote: On Tue, Apr 29, 2025 at 05:21:38PM +0200, Thomas Huth wrote: From: Thomas Huth These files reference QEMU machine types that have already been removed and thus are of no use anymore. Signed-off-by: Thomas Huth I never noticed these files, but when looki

Re: [PATCH 0/9] target/microblaze: Always use TARGET_LONG_BITS == 32

2025-04-30 Thread Edgar E. Iglesias
On Wed, Feb 12, 2025 at 02:01:46PM -0800, Richard Henderson wrote: > Use out-of-line helpers to implement extended address memory ops. > With this, we can reduce TARGET_LONG_BITS to the more natural 32 > for this 32-bit cpu. Series looks good to me: Reviewed-by: Edgar E. Iglesias > > > r~ >

Re: [PATCH 3/4] tests/data/vmstate-static-checker: Add dump files from QEMU 7.2.17

2025-04-30 Thread Thomas Huth
On 30/04/2025 00.30, Peter Xu wrote: On Tue, Apr 29, 2025 at 05:21:40PM +0200, Thomas Huth wrote: From: Thomas Huth For automatic tests, we need reference files from older QEMU versions. QEMU 7.2 is a long term stable release, so it's a good candidate for checking whether the migration could s

[PATCH 1/5] hw/i386/intel_iommu: Remove IntelIOMMUState::buggy_eim field

2025-04-30 Thread Philippe Mathieu-Daudé
The IntelIOMMUState::buggy_eim boolean was only set in the hw_compat_2_7[] array, via the 'x-buggy-eim=true' property. We removed all machines using that array, lets remove that property, simplifying vtd_decide_config(). Signed-off-by: Philippe Mathieu-Daudé --- include/hw/i386/intel_iommu.h | 1

[PATCH 0/5] hw/i386/pc: Remove deprecated 2.6 and 2.7 PC machines

2025-04-30 Thread Philippe Mathieu-Daudé
The versioned 'pc' and 'q35' machines up to 2.12 been marked as deprecated two releases ago, and are older than 6 years, so according to our support policy we can remove them. This series only includes the 2.6 and 2.7 machines removal, as it is a big enough number of LoC removed. Rest will follow.

[PATCH 5/5] hw/virtio/virtio-pci: Remove VIRTIO_PCI_FLAG_PAGE_PER_VQ definition

2025-04-30 Thread Philippe Mathieu-Daudé
VIRTIO_PCI_FLAG_PAGE_PER_VQ was only used by the hw_compat_2_7[] array, via the 'page-per-vq=on' property. We removed all machines using that array, lets remove all the code around VIRTIO_PCI_FLAG_PAGE_PER_VQ (see commit 9a4c0e220d8 for similar VIRTIO_PCI_FLAG_* enum removal). Signed-off-by: Phili

[PATCH 3/5] hw/virtio/virtio-pci: Remove VirtIOPCIProxy::ignore_backend_features field

2025-04-30 Thread Philippe Mathieu-Daudé
The VirtIOPCIProxy::ignore_backend_features boolean was only set in the hw_compat_2_7[] array, via the 'x-ignore-backend-features=on' property. We removed all machines using that array, lets remove that property, simplify by only using the default version. Signed-off-by: Philippe Mathieu-Daudé --

[PATCH 2/5] hw/intc/ioapic: Remove IOAPICCommonState::version field

2025-04-30 Thread Philippe Mathieu-Daudé
The IOAPICCommonState::version integer was only set in the hw_compat_2_7[] array, via the 'version=0x11' property. We removed all machines using that array, lets remove that property, simplify by only using the default version (defined as IOAPIC_VER_DEF). Signed-off-by: Philippe Mathieu-Daudé ---

Re: [PATCH v3 05/10] arm/cpu: accessors for writable id registers

2025-04-30 Thread Cornelia Huck
On Tue, Apr 29 2025, Sebastian Ott wrote: > On Mon, 14 Apr 2025, Cornelia Huck wrote: >> Also add conversion between the different indices. >> >> Signed-off-by: Cornelia Huck >> --- >> target/arm/cpu.h | 18 ++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/target/arm/cpu.

Re: [RFC PATCH] target/ppc: Inline most of dcbz helper

2025-04-30 Thread Alex Bennée
BALATON Zoltan writes: > On Wed, 30 Apr 2025, Nicholas Piggin wrote: >> On Wed Apr 30, 2025 at 7:09 AM AEST, BALATON Zoltan wrote: >>> On Tue, 29 Apr 2025, Alex Bennée wrote: BALATON Zoltan writes: > On Tue, 29 Apr 2025, Alex Bennée wrote: >> BALATON Zoltan writes: >>> On Mon,

Re: [PATCH v2] tests/qtest/libqos: Avoid double swapping when using modern virtio

2025-04-30 Thread Philippe Mathieu-Daudé
On 30/4/25 15:28, Thomas Huth wrote: From: Thomas Huth The logic in the qvirtio_read/write function is rather a headache, involving byte-swapping when the target is big endian, just to maybe involve another byte-swapping in the qtest_read/write function immediately afterwards (on the QEMU side

[PATCH 4/5] hw/char/virtio-serial: Do not expose the 'emergency-write' property

2025-04-30 Thread Philippe Mathieu-Daudé
The VIRTIO_CONSOLE_F_EMERG_WRITE feature bit was only set in the hw_compat_2_7[] array, via the 'emergency-write=off' property. We removed all machines using that array, lets remove that property. All instances have this feature bit set and it can not be disabled. Signed-off-by: Philippe Mathieu-D

Functional tests precache behaviour

2025-04-30 Thread Pierrick Bouvier
Hi folks, $ ninja -C build precache-functional 2025-04-30 07:23:20,382 - qemu-test - ERROR - Unable to download https://archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/gzimg/armv7.img.gz: HTTP error 503 2025-04-30 07:23:23,131 - qemu-test - ERROR - Unable to download ht

[PATCH v2 04/12] target/arm: move kvm stubs and remove CONFIG_KVM from kvm_arm.h

2025-04-30 Thread Pierrick Bouvier
Add a forward decl for struct kvm_vcpu_init to avoid pulling all kvm headers. Signed-off-by: Pierrick Bouvier --- target/arm/kvm_arm.h | 83 +-- target/arm/kvm-stub.c | 77 +++ 2 files changed, 78 insertions(+), 82 dele

[PATCH v2 03/12] meson: add common libs for target and target_system

2025-04-30 Thread Pierrick Bouvier
Following what we did for hw/, we need target specific common libraries for target. We need 2 different libraries: - code common to a base architecture - system code common to a base architecture For user code, it can stay compiled per target for now. Signed-off-by: Pierrick Bouvier --- meson.b

Re: Functional tests precache behaviour

2025-04-30 Thread Thomas Huth
On 30/04/2025 16.34, Pierrick Bouvier wrote: Hi folks, $ ninja -C build precache-functional 2025-04-30 07:23:20,382 - qemu-test - ERROR - Unable to download https:// archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/ gzimg/armv7.img.gz: HTTP error 503 2025-04-30 07:23:23,

Re: [PATCH] file-posix: Fix crash on discard_granularity == 0

2025-04-30 Thread Stefan Hajnoczi
On Tue, Apr 29, 2025 at 05:56:54PM +0200, Kevin Wolf wrote: > Block devices that don't support discard have a discard_granularity of > 0. Currently, this results in a division by zero when we try to make > sure that it's a multiple of request_alignment. Only try to update > bs->bl.pdiscard_alignmen

Re: [PATCH] file-posix: Fix crash on discard_granularity == 0

2025-04-30 Thread Stefan Hajnoczi
On Tue, Apr 29, 2025 at 05:56:54PM +0200, Kevin Wolf wrote: > Block devices that don't support discard have a discard_granularity of > 0. Currently, this results in a division by zero when we try to make > sure that it's a multiple of request_alignment. Only try to update > bs->bl.pdiscard_alignmen

Re: [PATCH 3/4] tests/data/vmstate-static-checker: Add dump files from QEMU 7.2.17

2025-04-30 Thread Peter Xu
On Wed, Apr 30, 2025 at 01:13:48PM +0200, Thomas Huth wrote: > On 30/04/2025 00.30, Peter Xu wrote: > > On Tue, Apr 29, 2025 at 05:21:40PM +0200, Thomas Huth wrote: > > > From: Thomas Huth > > > > > > For automatic tests, we need reference files from older QEMU versions. > > > QEMU 7.2 is a long

Re: Functional tests precache behaviour

2025-04-30 Thread Pierrick Bouvier
On 4/30/25 8:00 AM, Thomas Huth wrote: On 30/04/2025 16.34, Pierrick Bouvier wrote: Hi folks, $ ninja -C build precache-functional 2025-04-30 07:23:20,382 - qemu-test - ERROR - Unable to download https:// archive.netbsd.org/pub/NetBSD-archive/NetBSD-9.0/evbarm-earmv7hf/binary/ gzimg/armv7.img.g

[PULL 1/1] file-posix: Fix crash on discard_granularity == 0

2025-04-30 Thread Stefan Hajnoczi
From: Kevin Wolf Block devices that don't support discard have a discard_granularity of 0. Currently, this results in a division by zero when we try to make sure that it's a multiple of request_alignment. Only try to update bs->bl.pdiscard_alignment when we got a non-zero discard_granularity from

[PULL 0/1] Block patches

2025-04-30 Thread Stefan Hajnoczi
The following changes since commit 73d29ea2417b58ca55fba1aa468ba38e3607b583: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2025-04-27 12:47:23 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fe

Re: [PATCH] file-posix: Fix crash on discard_granularity == 0

2025-04-30 Thread Kevin Wolf
Am 29.04.2025 um 23:09 hat Eric Blake geschrieben: > On Tue, Apr 29, 2025 at 05:56:54PM +0200, Kevin Wolf wrote: > > Block devices that don't support discard have a discard_granularity of > > 0. Currently, this results in a division by zero when we try to make > > sure that it's a multiple of reque

Re: [PATCH v2 01/20] mcd: Introduce Multi-Core Debug (MCD) API

2025-04-30 Thread Daniel P . Berrangé
On Wed, Apr 30, 2025 at 05:22:37PM +0200, Mario Fleischmann wrote: > On 30.04.2025 14:56, Daniel P. Berrangé wrote: > > On Wed, Apr 30, 2025 at 02:47:07PM +0200, Mario Fleischmann wrote: > >> On 30.04.2025 10:20, Daniel P. Berrangé wrote: > >>> On Wed, Apr 30, 2025 at 07:27:22AM +0200, Mario Fleisc

Re: Functional tests precache behaviour

2025-04-30 Thread Daniel P . Berrangé
On Wed, Apr 30, 2025 at 08:48:59AM -0700, Pierrick Bouvier wrote: > On 4/30/25 8:00 AM, Thomas Huth wrote: > > On 30/04/2025 16.34, Pierrick Bouvier wrote: > > > Hi folks, > > > > > > $ ninja -C build precache-functional > > > 2025-04-30 07:23:20,382 - qemu-test - ERROR - Unable to download https:

[PATCH v5 0/7] Add VNC Open H.264 Encoding

2025-04-30 Thread Dietmar Maurer
https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding The noVNC HTML application recently added support for this encoding. There is also an open pull request to add audio support to noVNC: https://github.com/novnc/noVNC/pull/1952 With that in place, the web based VNC

[PATCH v5 7/7] h264: stop gstreamer pipeline before destroying, cleanup on exit

2025-04-30 Thread Dietmar Maurer
Some encoders can hang indefinitely (i.e. nvh264enc) if the pipeline is not stopped before it is destroyed (Observed on Debian bookworm). Signed-off-by: Dietmar Maurer --- include/system/system.h | 1 + include/ui/console.h| 1 + system/runstate.c | 2 ++ system/vl.c |

[PATCH v5 3/7] vnc: h264: send additional frames after the display is clean

2025-04-30 Thread Dietmar Maurer
The vnc implementation only sends frames when it detects changes in the server's framebuffer. This leads to artifacts when there are no further changes, as the internal H264 encoder may still contain data. This patch modifies the code to send a few additional frames in such situations to flush the

Re: [PATCH 0/9] target/microblaze: Always use TARGET_LONG_BITS == 32

2025-04-30 Thread Philippe Mathieu-Daudé
On 30/4/25 08:26, Philippe Mathieu-Daudé wrote: Hi, On 13/2/25 13:37, Philippe Mathieu-Daudé wrote: +AMD folks On 12/2/25 23:01, Richard Henderson wrote: Use out-of-line helpers to implement extended address memory ops. With this, we can reduce TARGET_LONG_BITS to the more natural 32 for this

[PATCH v5 2/7] add vnc h264 encoder

2025-04-30 Thread Dietmar Maurer
This patch implements H264 support for VNC. The RFB protocol extension is defined in: https://github.com/rfbproto/rfbproto/blob/master/rfbproto.rst#open-h-264-encoding Currently the Gstreamer x264enc plugin (software encoder) is used to encode the video stream. The gstreamer pipe is: appsrc ->

[PATCH v5 5/7] h264: new vnc options to configure h264 at server side

2025-04-30 Thread Dietmar Maurer
h264: on/off (default is on) h264-encoders: A colon separated list of allowed gstreamer encoders. Select the first available encoder from that list (default is "x264enc:openh264enc"). Signed-off-by: Dietmar Maurer --- ui/vnc-enc-h264.c | 40 ++-- ui/vnc.c

[PATCH v5 4/7] h264: search for available h264 encoder

2025-04-30 Thread Dietmar Maurer
The search list is currently hardcoded to: ["x264enc", "openh264enc"] x264enc: is probably the best available software encoder openh264enc: lower quality, but available on more systems. We restrict encoders to a known list because each encoder requires fine tuning to get reasonable/usable results

[PATCH v5 1/7] new configure option to enable gstreamer

2025-04-30 Thread Dietmar Maurer
GStreamer is required to implement H264 encoding for VNC. Please note that QEMU already depends on this library when you enable Spice. Signed-off-by: Dietmar Maurer --- meson.build | 10 ++ meson_options.txt | 2 ++ scripts/meson-buildoptions.sh | 3 +++ 3

[PATCH v5 6/7] h264: add hardware encoders

2025-04-30 Thread Dietmar Maurer
add most common hardware encoders: - nvh264enc: for NVidia hardware - vaapih264enc: for common AMD and Intel cards Signed-off-by: Dietmar Maurer --- ui/vnc-enc-h264.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/ui/vnc-enc-h264.c b/ui/vnc-enc-h264.c inde

Re: Functional tests precache behaviour

2025-04-30 Thread Pierrick Bouvier
On 4/30/25 9:29 AM, Daniel P. Berrangé wrote: On Wed, Apr 30, 2025 at 09:21:41AM -0700, Pierrick Bouvier wrote: On 4/30/25 9:02 AM, Daniel P. Berrangé wrote: On Wed, Apr 30, 2025 at 08:48:59AM -0700, Pierrick Bouvier wrote: On 4/30/25 8:00 AM, Thomas Huth wrote: On 30/04/2025 16.34, Pierrick

[PATCH v2 04/16] target/i386: Split out x86_cpu_exec_reset

2025-04-30 Thread Richard Henderson
Note that target/i386/cpu.h defines CPU_INTERRUPT_INIT as CPU_INTERRUPT_RESET. Therefore we can handle the new TCGCPUOps.cpu_exec_reset hook. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 39 ++- target/i386/t

[PATCH v2 14/16] accel/tcg: Pass TCGTBCPUState to tb_gen_code

2025-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- accel/tcg/internal-common.h | 5 ++--- accel/tcg/cpu-exec.c| 4 ++-- accel/tcg/translate-all.c | 28 +--- 3 files changed, 17 insertions(+), 20 deletions(-) diff --git a/accel/tcg/internal-common.h b/accel/tcg/internal-comm

[PATCH v2 11/16] accel/tcg: Pass TCGTBCPUState to tb_lookup

2025-04-30 Thread Richard Henderson
Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 28 +--- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 4a405d7b56..808983e461 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg/cpu-exec.c @@ -23

Re: Functional tests precache behaviour

2025-04-30 Thread Daniel P . Berrangé
On Wed, Apr 30, 2025 at 09:34:10AM -0700, Pierrick Bouvier wrote: > On 4/30/25 9:29 AM, Daniel P. Berrangé wrote: > > On Wed, Apr 30, 2025 at 09:21:41AM -0700, Pierrick Bouvier wrote: > > > On 4/30/25 9:02 AM, Daniel P. Berrangé wrote: > > > > On Wed, Apr 30, 2025 at 08:48:59AM -0700, Pierrick Bouv

[PATCH v5 0/1] Optimizing the print format of the QEMU monitor 'info mtree'

2025-04-30 Thread Chao Liu
Hi, all: Thanks to Markus, BALATON, and Philippe for their reviews In PATCH v5: Fix one comment, level 0 no longer prints line characters. ``` -/* Level 0 always has a col. */ +/* Level 0 always has not a col. */ if (level == 0 || col_string == NULL) { ``` PATCH v4 changelog: 1. Wh

[PATCH v2 08/16] target/riscv: Move cpu_get_tb_cpu_state to tcg-cpu.c

2025-04-30 Thread Richard Henderson
This function is only relevant to tcg. Move it to a tcg-specific file. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/riscv/cpu_helper.c | 97 - target/riscv/tcg/tcg-cpu.c | 98 +

Re: [PATCH v2 7/7] target/arm: Remove TYPE_AARCH64_CPU

2025-04-30 Thread Richard Henderson
On 4/29/25 06:22, Peter Maydell wrote: The TYPE_AARCH64_CPU class is an abstract type that is the parent of all the AArch64 CPUs. It now has no special behaviour of its own, so we can eliminate it and make the AArch64 CPUs directly inherit from TYPE_ARM_CPU. Signed-off-by: Peter Maydell Reviewe

[PATCH v2 08/15] vfio: add unmap_all flag to DMA unmap callback

2025-04-30 Thread John Levon
We'll use this parameter shortly; this just adds the plumbing. Signed-off-by: John Levon --- hw/vfio/container-base.c | 4 ++-- hw/vfio/container.c | 8 ++-- hw/vfio/iommufd.c | 6 +- hw/vfio/listener.c| 8 i

[PATCH v2 11/15] vfio: add region info cache

2025-04-30 Thread John Levon
Instead of requesting region information on demand with VFIO_DEVICE_GET_REGION_INFO, maintain a cache: this will become necessary for performance for vfio-user, where this call becomes a message over the control socket, so is of higher overhead than the traditional path. We will also need it to ge

[PATCH v2 14/15] vfio/container: pass listener_begin/commit callbacks

2025-04-30 Thread John Levon
The vfio-user container will later need to hook into these callbacks; set up vfio to use them, and optionally pass them through to the container. Signed-off-by: John Levon --- hw/vfio/listener.c| 28 +++ include/hw/vfio/vfio-container-base.h | 2 ++ 2

[PATCH v2 00/15] vfio: preparation for vfio-user

2025-04-30 Thread John Levon
Hi, this series is against the vfio-next tree: https://github.com/legoater/qemu/commits/vfio-next The series contains patches to vfio to prepare for the vfio-user implementation. A previous version of these patches can be found at https://lore.kernel.org/all/20250409134814.478903-1-john.le...@nuta

[PATCH v2 01/15] vfio: add vfio_prepare_device()

2025-04-30 Thread John Levon
Commonize some initialization code shared by the legacy and iommufd vfio implementations. Reviewed-by: Cédric Le Goater Signed-off-by: John Levon --- hw/vfio/container.c | 14 ++ hw/vfio/device.c | 14 ++ hw/vfio/iommufd.c | 9 +---

Re: [PATCH 1/2] block/null: Report DATA if not reading zeroes

2025-04-30 Thread Nir Soffer
> On 29 Apr 2025, at 0:49, Eric Blake wrote: > > On Mon, Apr 28, 2025 at 01:58:59AM +0300, Nir Soffer wrote: >> If read-zeroes is not set, we did not report BDRV_BLOCK_DATA or >> BDRV_BLOCK_ZERO. This is not consistent with other drivers and can >> confuse users or other programs: >> >>%

Re: [PATCH 2/2] block/null: Add read-pattern option

2025-04-30 Thread Nir Soffer
> On 29 Apr 2025, at 9:00, Markus Armbruster wrote: > > Eric Blake writes: > >> On Mon, Apr 28, 2025 at 01:59:00AM +0300, Nir Soffer wrote: >>> When the `read-zeroes` is set, reads produce zeroes, and block status >>> return BDRV_BLOCK_ZERO, emulating a sparse image. >>> >>> If we don't set

Re: [PATCH v5 2/3] include: Add a header to define host PCI MMIO functions

2025-04-30 Thread Farhan Ali
..snip... +static inline uint32_t host_pci_ldl_le_p(const void *ioaddr) +{ +    uint32_t ret = 0; +#ifdef __s390x__ +    ret = le32_to_cpu(s390x_pci_mmio_read_32(ioaddr)); +#else +    ret = (uint32_t)ldl_le_p(ioaddr); This is the only spot where you used a cast. Is it necessary, or could it

[PATCH v2 02/16] accel/tcg: Unconditionally use CPU_DUMP_CCOP in log_cpu_exec

2025-04-30 Thread Richard Henderson
This flag is only tested by target/i386, so including this makes no functional change. This is similar to other places like cpu-target.c which use CPU_DUMP_CCOP unconditionally. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 5 + 1 file changed, 1

[PATCH v2 03/16] accel/tcg: Introduce TCGCPUOps.cpu_exec_reset

2025-04-30 Thread Richard Henderson
Initialize all instances with cpu_reset(), so that there is no functional change. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 2 ++ accel/tcg/cpu-exec.c| 3 ++- target/alpha/cpu.c | 1 + t

Re: [PATCH v2] Running with `--enable-ubsan` leads to a qtest failure:

2025-04-30 Thread Nabih Estefan
On Wed, Apr 30, 2025 at 5:03 AM Peter Maydell wrote: > > On Tue, 29 Apr 2025 at 16:56, Nabih Estefan wrote: > > > > v2: used ldl_le_p and lduw_l_p instead of memcpy as per upstream > > suggestion. > > > > ``` > > ../tests/qtest/libqos/igb.c:106:5: runtime error: load of misaligned > > address 0x

[PATCH v2 01/16] accel/tcg: Generalize fake_user_interrupt test

2025-04-30 Thread Richard Henderson
Test for the hook being present instead of ifdef TARGET_I386. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- accel/tcg/cpu-exec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/c

[PATCH v2 00/16] accel/tcg: Compile cpu-exec.c twice

2025-04-30 Thread Richard Henderson
For v2, changes to TCGTBCPUState and pass it around more within the accel/tcg/ subroutines. r~ Richard Henderson (16): accel/tcg: Generalize fake_user_interrupt test accel/tcg: Unconditionally use CPU_DUMP_CCOP in log_cpu_exec accel/tcg: Introduce TCGCPUOps.cpu_exec_reset target/i386: Spl

[PATCH v2 05/16] accel/tcg: Hoist cpu_get_tb_cpu_state decl to accl/tcg/cpu-ops.h

2025-04-30 Thread Richard Henderson
For some targets, simply remove the local definition. For other targets, move the inline definition out of line. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 3 ++ target/alpha/cpu.h | 11 -- target/arm/cpu.h| 3 --

[PATCH v2 10/16] accel/tcg: Move cpu_get_tb_cpu_state to TCGCPUOps

2025-04-30 Thread Richard Henderson
Move the global function name to a hook on TCGCPUOps. Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- include/accel/tcg/cpu-ops.h | 8 ++-- target/arm/internals.h | 2 ++ target/ppc/internal.h | 3 +++ accel/tcg/cpu-exec.c| 7 --- accel/tcg/translat

  1   2   3   4   >