Re: [PATCH v2 3/3] vhost-user: return failure if backend crash when live migration

2025-03-25 Thread Haoqian He
> 2025年3月24日 22:31,Stefano Garzarella 写道: > > On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote: >> >> >>> 2025年3月19日 23:20,Stefano Garzarella 写道: >>> >>> On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote: Live migration should be terminated if the backend crashes bef

Re: [PATCH] target/loongarch: Fix the cpu unplug resource leak

2025-03-25 Thread bibo mao
On 2025/3/24 下午8:33, Xianglai Li wrote: When the cpu is created, qemu_add_vm_change_state_handler is called in the kvm_arch_init_vcpu function to create the VMChangeStateEntry resource. However, the resource is not released when the cpu is destroyed. This results in a qemu process segment err

[PATCH] tests/functional: Skip the screendump tests if the command is not available

2025-03-25 Thread Thomas Huth
From: Thomas Huth It is possible nowadays to compile QEMU without pixman support - in that case the screendump command is not available and the related tests fail. Thus skip these tests if the screendump command could not be executed. Signed-off-by: Thomas Huth --- tests/functional/test_arm_in

Re: [PATCH 2/4] docs, qapi: generate undocumented return sections

2025-03-25 Thread Markus Armbruster
John Snow writes: > This patch changes the qapidoc transmogrifier to generate Return value > documentation for any command that has a return value but hasn't > explicitly documented that return value. > > Signed-off-by: John Snow A number of commands lack return value documentation before the p

[PATCH v6 10/10] ppc/pnv: Add ChipTOD model for Power11

2025-03-25 Thread Aditya Gupta
Introduce Power11 ChipTod. The code has been copied from Power10 ChipTod code as the Power11 core is same as Power10 core. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c

[PATCH v6 00/10] Power11 support for QEMU [PowerNV]

2025-03-25 Thread Aditya Gupta
Overview Add support for Power11 powernv machine type. As Power11 core is same as Power10, hence much of the code has been reused from Power10. Split Powernv11 chip/machine code into commits introducing: chip,machine,xive,phb This is to try to keep the code smaller in each commit,

[PATCH v6 08/10] ppc/pnv: Add XIVE2 controller to Power11

2025-03-25 Thread Aditya Gupta
Add a XIVE2 controller to Power11 chip and machine. The controller has the same logic as Power10. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c | 132 +

[PATCH v6 01/10] ppc/pnv: Add HOMER for Power11

2025-03-25 Thread Aditya Gupta
Power11 core is same as Power10, declare PNV11_HOMER as a child class of PNV10_HOMER, so it goes through same class init Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta ---

[PATCH v6 05/10] ppc/pnv: Add SBE model for Power11

2025-03-25 Thread Aditya Gupta
Power11 core is same as Power10, reuse PNV10_SBER initialisation, by declaring PNV11_PSI as child class of PNV10_PSI Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta --- hw

[PATCH v6 02/10] ppc/pnv: Add a LPC controller for Power11

2025-03-25 Thread Aditya Gupta
Power11 core is same as Power10 core, declare PNV11_LPC as a child class of PNV10_LPC, so it goes through same class init Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta --

[PATCH v6 09/10] ppc/pnv: Add PHB5 PCIe Host bridge to Power11

2025-03-25 Thread Aditya Gupta
Power11 also uses PHB5, same as Power10. Add Power11 PHBs with similar code as the corresponding Power10 implementation. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya Gupta --- hw/ppc/pnv.c | 57 ++

[PATCH v6 03/10] ppc/pnv: Add OCC for Power11

2025-03-25 Thread Aditya Gupta
Power11 core is same as Power10, reuse PNV10_OCC initialisation, by declaring `PNV11_OCC` as child class of `PNV10_OCC` Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta ---

[PATCH v6 07/10] ppc/pnv: Introduce Power11 PowerNV machine

2025-03-25 Thread Aditya Gupta
The Powernv11 machine doesn't have XIVE & PHBs as of now XIVE2 interface and PHB5 added in later patches to Powernv11 machine Also add mention of Power11 to powernv documentation Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Sig

Re: [PATCH v5 0/8] Power11 support for QEMU [PowerNV]

2025-03-25 Thread Aditya Gupta
Hi Cedric, On 24/03/25 13:11, Cédric Le Goater wrote: Hello Aditya, On 3/8/25 21:51, Aditya Gupta wrote: Overview Add support for Power11 powernv machine type, to emulate PowerNV VMs running on Power11. Could you please consider deprecating the POWER8NVL and POWER8E CPUs and as

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-25 Thread Gerd Hoffman
Hi, > > While digging around in the igvm spec I've seen there is the > > concept of 'parameters'. Can this be used to pass on the memory > > location of kernel + initrd + cmdline? Maybe the kernel hashes too? > > The find the locations of the kernel, initrd, cmdline, ... I thin

Re: [PATCH 02/17] target/avr: Fix buffer read in avr_print_insn

2025-03-25 Thread Pierrick Bouvier
On 3/23/25 10:37, Richard Henderson wrote: Do not unconditionally attempt to read 4 bytes, as there may only be 2 bytes remaining in the translator cache. Cc: qemu-sta...@nongnu.org Signed-off-by: Richard Henderson --- target/avr/disas.c | 21 ++--- 1 file changed, 14 inserti

Re: [PATCH v6] hw/misc/vmfwupdate: Introduce hypervisor fw-cfg interface support

2025-03-25 Thread Alexander Graf
On 24.03.25 18:53, Gerd Hoffman wrote: On Mon, Mar 24, 2025 at 05:31:30PM +0100, Alexander Graf wrote: What does all this mean for the hypervisor interface ? That means we'll go scratch the region list idea and depend on igvm instead. Which means we are back to the single firmware image. So

Questions about vfio-pci

2025-03-25 Thread yangjinqian via
Hi, I'm observing intermittent failures when enabling the HNS3 network port in VM using QEMU with the mainline kernel. HNS3 drive in kernel: static int hns3_nic_net_up(struct net_device *netdev) { .. /* enable the vectors */ for (i = 0; i < vector_num; i++) { napi_enable(napi);

Re: [PATCH 5/5] qapi: delete un-needed python static analysis configs

2025-03-25 Thread Markus Armbruster
John Snow writes: > The pylint config is being left in place because the settings differ > enough from the python/ directory settings that we need a chit-chat on > how to merge them O:-) > > Everything else can go. > > Signed-off-by: John Snow > --- > scripts/qapi/.flake8| 3 --- > scripts/

[PATCH] tests/functional: Skip the screendump tests if the command is not available

2025-03-25 Thread Thomas Huth
From: Thomas Huth It is possible nowadays to compile QEMU without pixman support - in that case the screendump command is not available and the related tests fail. Thus skip these tests if the screendump command could not be executed. Signed-off-by: Thomas Huth --- tests/functional/test_arm_in

Re: [PATCH 3/4] qapi: remove trivial "Returns:" sections

2025-03-25 Thread Markus Armbruster
John Snow writes: > The new qapidoc transmogrifier can generate "Returns" statements with > type information just fine, so we can remove it from the source where it > doesn't add anything particularly novel or helpful and just repeats the > type info. > > This patch does not touch Returns: lines

Re: [PATCH for-10.1 18/32] vfio: Move vfio_get_device_info() to helpers.c

2025-03-25 Thread John Levon
On Tue, Mar 18, 2025 at 10:54:01AM +0100, Cédric Le Goater wrote: > vfio_get_device_info() is a low level routine. Move it with the other > helpers. > > Signed-off-by: Cédric Le Goater Reviewed-by: John Levon regards john

Re: [PATCH 2/4] docs, qapi: generate undocumented return sections

2025-03-25 Thread Markus Armbruster
John Snow writes: > This patch changes the qapidoc transmogrifier to generate Return value > documentation for any command that has a return value but hasn't > explicitly documented that return value. > > Signed-off-by: John Snow [...] > diff --git a/scripts/qapi/parser.py b/scripts/qapi/parse

Re: [PATCH v2 3/3] vhost-user: return failure if backend crash when live migration

2025-03-25 Thread Stefano Garzarella
On Tue, Mar 25, 2025 at 04:39:46PM +0800, Haoqian He wrote: 2025年3月24日 22:31,Stefano Garzarella 写道: On Thu, Mar 20, 2025 at 08:21:30PM +0800, Haoqian He wrote: 2025年3月19日 23:20,Stefano Garzarella 写道: On Fri, Mar 14, 2025 at 06:15:34AM -0400, Haoqian He wrote: [...] diff --git a/include/hw/

Re: [PATCH v8 0/7] Allow to enable multifd and postcopy migration together

2025-03-25 Thread Prasad Pandit
Hello Fabiano, On Tue, 18 Mar 2025 at 18:10, Prasad Pandit wrote: > * This series (v8) splits earlier patch-2 which enabled multifd and > postcopy options together into two separate patches. One modifies > the channel discovery in migration_ioc_process_incoming() function, > and second one

Re: [PATCH v2 2/3] vhost: return failure if stop virtqueue failed in vhost_dev_stop

2025-03-25 Thread Stefano Garzarella
On Tue, Mar 25, 2025 at 04:36:53PM +0800, Haoqian He wrote: 2025年3月24日 22:25,Stefano Garzarella 写道: On Thu, Mar 20, 2025 at 08:21:25PM +0800, Haoqian He wrote: 2025年3月19日 23:11,Stefano Garzarella 写道: On Fri, Mar 14, 2025 at 06:15:33AM -0400, Haoqian He wrote: The backend maybe crash when v

Re: [PATCH 2/5] docs/qapidoc: linting fixes

2025-03-25 Thread Markus Armbruster
John Snow writes: > This restores the linting baseline in qapidoc. The order of some imports > have changed slightly due to configuring isort a little better: isort Changed since when / what? > was having difficulty understanding that "compat" and "qapidoc_legacy" > were local modules because d

Re: [PATCH 4/5] python: add qapi static analysis tests

2025-03-25 Thread Markus Armbruster
John Snow writes: > Update the python tests to also check qapi. No idea why I didn't do this > before. I guess I was counting on moving it under python/ and then just > forgot after that was NACKed. Oops, this turns out to be really easy. > > flake8, isort and mypy use the tool configuration from

Re: [PATCH RFC] target/arm: add bounding a->imm assertion

2025-03-25 Thread Anastasia Belova
Sorry for accidentaly sending this patch twice. My mail system reports that it can't be delivered to Peter Maydell and I am trying to solve it. On 3/25/25 1:17 PM, Anastasia Belova wrote: From: Anastasia Belova Add an assertion similar to that in the do_shr_narrow(). This will make sure th

[Stable-7.2.17 32/34] vdpa: Allow vDPA to work on big-endian machine

2025-03-25 Thread Michael Tokarev
From: Konstantin Shkolnyy Add .set_vnet_le() function that always returns success, assuming that vDPA h/w always implements LE data format. Otherwise, QEMU disables vDPA and outputs the message: "backend does not support LE vnet headers; falling back on userspace virtio" Reviewed-by: Michael S.

[Stable-7.2.17 34/34] hw/misc/aspeed_hace: Fix buffer overflow in has_padding function

2025-03-25 Thread Michael Tokarev
From: Jamin Lin The maximum padding size is either 64 or 128 bytes and should always be smaller than "req_len". If "padding_size" exceeds "req_len", then "req_len - padding_size" underflows due to "uint32_t" data type, leading to a large incorrect value (e.g., `0xFFXX`). This causes an out-of

[Stable-8.2.10 v2 00/51] Patch Round-up for stable 8.2.10, freeze on 2025-03-24 (frozen)

2025-03-25 Thread Michael Tokarev
The following patches are queued for QEMU stable v8.2.10: https://gitlab.com/qemu-project/qemu/-/commits/staging-8.2 Patch freeze is 2025-03-24 (frozen), and the release is planned for 2025-03-26: https://wiki.qemu.org/Planning/8.2 Please respond here or CC qemu-sta...@nongnu.org on any add

[PATCH RFC] target/arm: add bounding a->imm assertion

2025-03-25 Thread Anastasia Belova
From: Anastasia Belova Add an assertion similar to that in the do_shr_narrow(). This will make sure that functions from sshll_ops have correct arguments. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Anastasia Belova --- target/arm/tcg/translate-sve.c | 1 +

Re: [PATCH] tests/functional/test_aarch64_virt_gpu: Skip if "dbus" display isn't available

2025-03-25 Thread Alex Bennée
Thomas Huth writes: > From: Thomas Huth > > This test currently fails if the "dbus" display has not been compiled > into the binary (which can happen when CFI has been enabled, for example). > Check for the error message to skip the test in that case. > > While we're at it, also make sure that t

Re: [PATCH] hw/loongarch/boot: Adjust the loading position of the initrd

2025-03-25 Thread bibo mao
Xianglai, Thanks for your patch, some comments inline. On 2025/3/19 下午4:32, Xianglai Li wrote: When only the -kernel parameter is used to load the elf kernel, the initrd is loaded in the ram. If the initrd size is too large, the loading fails, resulting in a VM startup failure. This patch first

Re: [PATCH 2/2] scsi-disk: Add native FUA support

2025-03-25 Thread Kevin Wolf
Am 06.03.2025 um 11:33 hat Kevin Wolf geschrieben: > Am 04.03.2025 um 16:52 hat Alberto Faria geschrieben: > > Avoid emulating FUA when the driver supports it natively. This should > > provide better performance than a full flush after the write. > > > > Signed-off-by: Alberto Faria > > Did you

[PATCH-for-10.1 4/4] target/sparc: Move hardware fields from CPUSPARCState to SPARCCPU

2025-03-25 Thread Philippe Mathieu-Daudé
Keep CPUSPARCState for architectural fields, move Leon3 hardware specific fields to SPARCCPU. Reset the Leon3 specific 'cache_control' field in leon3_cpu_reset() instead of sparc_cpu_reset_hold(). Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/cpu.h | 10 +- hw/sparc/le

[PATCH-for-10.1 2/4] target/sparc: Restrict SPARC64 specific features

2025-03-25 Thread Philippe Mathieu-Daudé
Following commit 554abe47c7b ("target/sparc: Partition cpu features"), avoid compiling SPARC64 specific code on 32-bit binary. Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/cpu-feature.h.inc | 20 target/sparc/translate.c | 10 -- 2 files changed, 20 i

Re: [PATCH v2 05/11] target/avr: Remove NUMBER_OF_IO_REGISTERS

2025-03-25 Thread Richard Henderson
On 3/25/25 16:03, Philippe Mathieu-Daudé wrote: On 25/3/25 23:43, Richard Henderson wrote: This define isn't used. Signed-off-by: Richard Henderson ---   target/avr/cpu.h | 2 --   1 file changed, 2 deletions(-) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index 84a8f5cc8c..b49e7a7056 1006

Re: [PATCH 05/17] target/avr: Move cpu register accesses into system memory

2025-03-25 Thread Pierrick Bouvier
On 3/25/25 06:48, Richard Henderson wrote: On 3/24/25 18:07, Pierrick Bouvier wrote: A simple nit, maybe we could define constant for register names. This way, it can be used in the two switch for read/access. Which constant? - The absolute address (0x58-0x5f) - The i/o port address

[PATCH 06/15] tests/functional: Convert the 32-bit big endian Wheezy mips test

2025-03-25 Thread Thomas Huth
From: Thomas Huth The test checks some entries in /proc and the output of some commands ... we put these checks into exportable functions now so that they can be reused more easily. Additionally the linux_ssh_mips_malta.py uses SSH to test the networking of the guest. Since we don't have a SSH m

[PATCH 07/15] tests/functional: Convert the 32-bit little endian Wheezy mips test

2025-03-25 Thread Thomas Huth
From: Thomas Huth Reuse the test function from the big endian test to easily convert the 32-bit little endian Wheezy mips test. Signed-off-by: Thomas Huth --- tests/avocado/linux_ssh_mips_malta.py | 8 tests/functional/meson.build | 1 + tests/functional/test_mipsel_malta.p

[PATCH v2 08/30] exec/cpu-all: remove exec/cpu-interrupt include

2025-03-25 Thread Pierrick Bouvier
Signed-off-by: Pierrick Bouvier --- include/exec/cpu-all.h | 1 - target/alpha/cpu.h | 1 + target/arm/cpu.h| 1 + target/avr/cpu.h| 1 + target/hppa/cpu.h | 1 + target/i386/cpu.h | 1 + target/loongarch/cpu.h | 1 + target/m68k/cpu.h | 1 + target/microb

Re: [RFC PATCH v2 10/20] hw/arm/smmuv3-accel: Support nested STE install/uninstall support

2025-03-25 Thread Nicolin Chen
On Tue, Mar 25, 2025 at 07:08:29PM +0100, Eric Auger wrote: > > +static int > > +smmuv3_accel_dev_install_nested_ste(SMMUv3AccelDevice *accel_dev, > > +uint32_t data_type, uint32_t data_len, > > +void *data) > > +{ > > +SMM

Re: [PATCH v2 02/11] target/avr: Improve decode of LDS, STS

2025-03-25 Thread Richard Henderson
On 3/25/25 16:13, Philippe Mathieu-Daudé wrote: On 25/3/25 23:43, Richard Henderson wrote: The comment about not being able to define a field with zero bits is out of date since 94597b6146f3 ("decodetree: Allow !function with no input bits"). This fixes the missing load of imm in the disassembl

[PATCH v2 2/6] ui/spice: Enable gl=on option for non-local or remote clients

2025-03-25 Thread Vivek Kasireddy
Newer versions of Spice server should be able to accept dmabuf fds from Qemu for clients that are connected via the network. In other words, when this option is enabled, Qemu would share a dmabuf fd with Spice which would encode and send the data associated with the fd to a client that could be loc

[PATCH v2 3/6] ui/spice: Submit the gl_draw requests at 60 FPS for remote clients

2025-03-25 Thread Vivek Kasireddy
In the specific case where the display layer (virtio-gpu) is using dmabuf, and if remote clients are enabled (-spice gl=on,port=), it makes sense to limit the maximum (streaming) rate to 60 FPS using the GUI timer. This matches the behavior of GTK UI where the display updates are submitted at 6

[PATCH v2 1/6] ui/spice: Add an option for users to provide a preferred codec

2025-03-25 Thread Vivek Kasireddy
Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 5

[PATCH v2 5/6] ui/spice: Create a new texture with linear layout when gl=on is enabled

2025-03-25 Thread Vivek Kasireddy
Since most encoders/decoders (invoked by Spice) may not work with tiled memory associated with a texture, we need to create another texture that has linear memory layout and use that instead. Note that, there does not seem to be a direct way to indicate to the GL implementation that a texture's ba

[PATCH v2 6/6] ui/spice: Blit the scanout texture if its memory layout is not linear

2025-03-25 Thread Vivek Kasireddy
In cases where the scanout buffer is provided as a texture (e.g. Virgl) we need to check to see if it has a linear memory layout or not. If it doesn't have a linear layout, then blitting it onto the texture associated with the display surface (which already has a linear layout) seems to ensure that

[PATCH v2 4/6] ui/console-gl: Add a helper to create a texture with linear memory layout

2025-03-25 Thread Vivek Kasireddy
There are cases where we do not want the memory layout of a texture to be tiled as the component processing the texture would not know how to de-tile either via software or hardware. Therefore, ensuring that the memory backing the texture has a linear layout is absolutely necessary in these situati

Re: [PATCH 6/6] ui/spice: support multi plane dmabuf scanout

2025-03-25 Thread Qiang Yu
On Mon, Mar 24, 2025 at 10:02 PM Marc-André Lureau wrote: > > On Mon, Mar 24, 2025 at 5:35 PM Qiang Yu wrote: > > > > On Mon, Mar 24, 2025 at 5:30 PM Marc-André Lureau > > wrote: > > > > > > Hi > > > > > > On Mon, Mar 24, 2025 at 12:20 PM wrote: > > > > > > > > From: Qiang Yu > > > > > > > > S

[PATCH-for-10.0 09/12] hw/nvram/xlnx-efuse: Do not expose as user-creatable

2025-03-25 Thread Philippe Mathieu-Daudé
This device is part of SoC components thus can not be created manually. Signed-off-by: Philippe Mathieu-Daudé --- hw/nvram/xlnx-efuse.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/nvram/xlnx-efuse.c b/hw/nvram/xlnx-efuse.c index 29e7dd539ec..176e88fcd17 100644 --- a/hw/nvram/xlnx-ef

Re: [PATCH-for-10.0 06/12] hw/i2c/pca954x: Categorize and add description

2025-03-25 Thread Corey Minyard
On Tue, Mar 25, 2025 at 11:43:04PM +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i2c/i2c_mux_pca954x.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Looks ok to me. Acked-by: Corey Minyard > > diff --git a/hw/i2c/i2c_mux_pca954x.c b/

[PATCH v2 07/11] target/avr: Move cpu register accesses into system memory

2025-03-25 Thread Richard Henderson
Integrate the i/o 0x00-0x1f and 0x38-0x3f loopbacks into the cpu registers with normal address space accesses. We no longer need to trap accesses to the first page within avr_cpu_tlb_fill but can wait until a write occurs. Signed-off-by: Richard Henderson --- target/avr/cpu.h | 7 ++ tar

[PATCH v2 06/11] target/avr: Add defines for i/o port registers

2025-03-25 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/avr/cpu.h| 10 ++ target/avr/helper.c | 36 ++-- 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index b49e7a7056..ebcdda20ac 100644 --- a/target/avr/cpu.h

[PATCH v2 01/11] target/avr: Fix buffer read in avr_print_insn

2025-03-25 Thread Richard Henderson
Do not unconditionally attempt to read 4 bytes, as there may only be 2 bytes remaining in the translator cache. Cc: qemu-sta...@nongnu.org Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/avr/disas.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deleti

[PATCH v2 02/11] target/avr: Improve decode of LDS, STS

2025-03-25 Thread Richard Henderson
The comment about not being able to define a field with zero bits is out of date since 94597b6146f3 ("decodetree: Allow !function with no input bits"). This fixes the missing load of imm in the disassembler. Cc: qemu-sta...@nongnu.org Fixes: 9d8caa67a24 ("target/avr: Add support for disassembling

[PATCH v2 10/11] hw/avr: Prepare for TARGET_PAGE_SIZE > 256

2025-03-25 Thread Richard Henderson
If i/o does not cover the entire first page, allocate a portion of ram as an i/o device, so that the entire first page is i/o. While memory_region_init_ram_device_ptr is happy to allocate the RAMBlock, it does not register the ram for migration. Do this by hand. Signed-off-by: Richard Henderson

Re: [PATCH 2/4] docs, qapi: generate undocumented return sections

2025-03-25 Thread John Snow
On Tue, Mar 25, 2025 at 5:41 AM Markus Armbruster wrote: > John Snow writes: > > > This patch changes the qapidoc transmogrifier to generate Return value > > documentation for any command that has a return value but hasn't > > explicitly documented that return value. > > > > Signed-off-by: John

[Stable-9.2.3 59/69] target/riscv: fixes a bug against `ssamoswap` behavior in M-mode

2025-03-25 Thread Michael Tokarev
From: Deepak Gupta Commit f06bfe3dc38c ("target/riscv: implement zicfiss instructions") adds `ssamoswap` instruction. `ssamoswap` takes the code-point from existing reserved encoding (and not a zimop like other shadow stack instructions). If shadow stack is not enabled (via xenvcfg.SSE) and effec

Re: [PATCH 2/4] docs, qapi: generate undocumented return sections

2025-03-25 Thread John Snow
On Tue, Mar 25, 2025 at 4:54 AM Markus Armbruster wrote: > John Snow writes: > > > This patch changes the qapidoc transmogrifier to generate Return value > > documentation for any command that has a return value but hasn't > > explicitly documented that return value. > > > > Signed-off-by: John

Re: [RFC PATCH v2 10/20] hw/arm/smmuv3-accel: Support nested STE install/uninstall support

2025-03-25 Thread Eric Auger
Hi, On 3/11/25 3:10 PM, Shameer Kolothum wrote: > From: Nicolin Chen > > Allocates a s1 HWPT for the Guest s1 stage and attaches that > to the dev. This will be invoked in a subsequent patch when > Guest issues SMMU_CMD_CFGI_STE. CMD_CFGI_STE ... or CMD_CFGI_STE_RANGE > > While at it, we are also

Re: [RFC PATCH v2 11/20] hw/arm/smmuv3-accel: Allocate a vDEVICE object for device

2025-03-25 Thread Eric Auger
Hi, On 3/11/25 3:10 PM, Shameer Kolothum wrote: > From: Nicolin Chen > > Allocate and associate a vDEVICE object for the Guest device > with the vIOMMU. This will help the kernel to do the > vSID --> sid translation whenever required (eg: device specific s/sid/SID > invalidations). > > Signed-off

[PATCH v6 04/10] ppc/pnv: Add a PSI bridge model for Power11

2025-03-25 Thread Aditya Gupta
Power11 core is same as Power10, reuse PNV10_PSI initialisation, by declaring 'PNV11_PSI' as child class of 'PNV10_PSI' Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Reviewed-by: Cédric Le Goater Signed-off-by: Aditya Gupta ---

Re: [PATCH 15/15] Remove the remainders of the Avocado tests

2025-03-25 Thread Philippe Mathieu-Daudé
On 25/3/25 21:00, Thomas Huth wrote: From: Thomas Huth Now that all Avocado tests have been converted to or been replaced by other functional tests, we can delete the remainders of the Avocado tests from the QEMU source tree. Signed-off-by: Thomas Huth --- MAINTAINERS

Re: [PULL 0/3] aspeed queue

2025-03-25 Thread Cédric Le Goater
On 3/24/25 21:36, Michael Tokarev wrote: 23.03.2025 20:45, Cédric Le Goater wrote: Jamin Lin (1):    hw/misc/aspeed_hace: Fix buffer overflow in has_padding function Steven Lee (1):    hw/intc/aspeed: Fix IRQ handler mask check Troy Lee (1):    aspeed: Fix maximum number of spi con

[PULL 08/10] target/riscv: fix handling of nop for vstart >= vl in some vector instruction

2025-03-25 Thread Alistair Francis
From: Chao Liu Recently, when I was writing a RISCV test, I found that when VL is set to 0, the instruction should be nop, but when I tested it, I found that QEMU will treat all elements as tail elements, and in the case of VTA=1, write all elements to 1. After troubleshooting, it was found that

Re: [PATCH v6 06/10] ppc/pnv: Introduce Pnv11Chip

2025-03-25 Thread Aditya Gupta
On 25/03/25 22:50, Cédric Le Goater wrote: On 3/25/25 12:23, Aditya Gupta wrote: Implement Pnv11Chip, currently without chiptod, xive and phb. Chiptod, XIVE, PHB are implemented in later patches. Since Power11 core is same as Power10, the implementation of Pnv11Chip is a duplicate of correspo

[PATCH 11/15] tests/functional: Use the tuxrun kernel for the x86 replay test

2025-03-25 Thread Thomas Huth
From: Thomas Huth This way we can do a full boot in record-replay mode and should get a similar test coverage compared to the old replay test from tests/avocado/replay_linux.py. Thus remove the x86 avocado replay_linux test now. Signed-off-by: Thomas Huth --- tests/avocado/replay_linux.py

[PATCH 01/15] gitlab-ci: Remove the avocado tests from the CI pipelines

2025-03-25 Thread Thomas Huth
From: Thomas Huth We are going to move the remaining Avocado tests step by step into the functional test framework. Unfortunately, Avocado fails with an error if it cannot determine a test to run, so disable the tests here now to avoid failures in the Gitlab-CI during the next steps. Signed-off-

[PATCH 02/15] tests/functional: Move the check for the parameters from avocado to functional

2025-03-25 Thread Thomas Huth
From: Thomas Huth test_x86_64_pc in tests/avocado/boot_linux_console.py only checks whether the kernel parameters have correctly been passed to the kernel in the guest by looking for them in the console output of the guest. Let's move that to the functional test framework now, but instead of doin

[PATCH 05/15] tests/avocado: Remove the LinuxKernelTest class

2025-03-25 Thread Thomas Huth
From: Thomas Huth All tests that used this class have been converted to the functional framework, so we can remove the boot_linux_console.py file now. Signed-off-by: Thomas Huth --- tests/avocado/boot_linux_console.py | 62 - 1 file changed, 62 deletions(-) delete

[PATCH 15/15] Remove the remainders of the Avocado tests

2025-03-25 Thread Thomas Huth
From: Thomas Huth Now that all Avocado tests have been converted to or been replaced by other functional tests, we can delete the remainders of the Avocado tests from the QEMU source tree. Signed-off-by: Thomas Huth --- MAINTAINERS | 8 +- docs/about/build-platfor

Re: [PATCH v2 20/30] target/arm/cpu: always define kvm related registers

2025-03-25 Thread Richard Henderson
On 3/20/25 15:29, Pierrick Bouvier wrote: This does not hurt, even if they are not used. Signed-off-by: Pierrick Bouvier --- target/arm/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index a8a1a8faf6b..ab7412772bc 100644 --- a/target/arm/cpu.h

Re: [PATCH v2 06/11] target/avr: Add defines for i/o port registers

2025-03-25 Thread Philippe Mathieu-Daudé
On 25/3/25 23:43, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/avr/cpu.h| 10 ++ target/avr/helper.c | 36 ++-- 2 files changed, 28 insertions(+), 18 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 05/11] target/avr: Remove NUMBER_OF_IO_REGISTERS

2025-03-25 Thread Philippe Mathieu-Daudé
On 25/3/25 23:43, Richard Henderson wrote: This define isn't used. Signed-off-by: Richard Henderson --- target/avr/cpu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/target/avr/cpu.h b/target/avr/cpu.h index 84a8f5cc8c..b49e7a7056 100644 --- a/target/avr/cpu.h +++ b/target/avr/cpu.h

Re: [RFC PATCH v2 00/20] hw/arm/virt: Add support for user-creatable accelerated SMMUv3

2025-03-25 Thread Eric Auger
Hi Shameer, Nicolin, On 3/25/25 7:26 PM, Nicolin Chen wrote: > On Tue, Mar 25, 2025 at 03:43:29PM +, Shameerali Kolothum Thodi wrote: >>> For the record I tested the series with host VFIO device and a >>> virtio-blk-pci device put behind the same pxb-pcie/smmu protection and >>> it works just

[PATCH 10/15] tests/avocado: Remove the boot_linux.py tests

2025-03-25 Thread Thomas Huth
From: Thomas Huth These tests are based on the cloudinit functions from Avocado. The cloudinit is very, very slow compared to our other tests, so most of these Avocado tests have either been disabled by default with a decorator, or have been marked to only run with KVM. We won't include this slu

[PATCH for-10.1 00/15] Convert remaining Avocado tests to functional

2025-03-25 Thread Thomas Huth
These patches convert the remaining Avocado tests bit by bit to the functional framework, or replace them with a test that has similar test coverage. This way we are finally able to get rid of the test/avocado folder in the end, everything is then integrated with the meson test runner. It should be

[PATCH 12/15] tests/functional: Use the tuxrun kernel for the aarch64 replay test

2025-03-25 Thread Thomas Huth
From: Thomas Huth This way we can do a full boot in record-replay mode and should get a similar test coverage compared to the old replay test from tests/avocado/replay_linux.py. Since the aarch64 test was the last avocado test in the tests/avocado/replay_linux.py file, we can remove this file no

[PATCH 09/15] tests/functional: Convert the 64-bit big endian Wheezy mips test

2025-03-25 Thread Thomas Huth
From: Thomas Huth Reuse the test function from the 32-bit big endian test to easily convert the 64-bit big endian Wheezy mips test. Since this was the last test in tests/avocado/linux_ssh_mips_malta.py, we can remove this avocado file now, too. Signed-off-by: Thomas Huth --- MAINTAINERS

[PATCH 04/15] tests/functional: Convert the i386 replay avocado test

2025-03-25 Thread Thomas Huth
From: Thomas Huth Since this was the last test in tests/avocado/replay_kernel.py, we can remove that Avocado file now. Signed-off-by: Thomas Huth -# -# This work is licensed under the terms of the GNU GPL, version 2 or -# later. See the COPYING file in the top-level directory. - -import os -im

[PATCH 08/15] tests/functional: Convert the 64-bit little endian Wheezy mips test

2025-03-25 Thread Thomas Huth
From: Thomas Huth Reuse the test function from the 32-bit big endian test to easily convert the 64-bit little endian Wheezy mips test. Signed-off-by: Thomas Huth --- tests/avocado/linux_ssh_mips_malta.py | 8 tests/functional/meson.build| 1 + tests/functional/test_mip

[PATCH 03/15] tests/functional: Convert reverse_debugging tests to the functional framework

2025-03-25 Thread Thomas Huth
From: Thomas Huth These tests are using the gdb-related library functions from the Avocado framework which we don't have in the functional framework yet. So for the time being, keep those imports and skip the test if the Avocado framework is not installed on the host. Signed-off-by: Thomas Huth

[PATCH qemu 0/1] Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance

2025-03-25 Thread ~h0lyalg0rithm
Suggestion by Stefan Hajnoczi to improve io_uring performance Suraj Shirvankar (1): Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance util/fdmon-io_uring.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) -- 2.45.3

[PATCH qemu 1/1] Add IOURING_SETUP_SINGLE_ISSUER flag to improve iouring performance

2025-03-25 Thread ~h0lyalg0rithm
From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- util/fdmon-io_uring.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/util/fdmon-io_uring.c b/util/fdmon-io_uring.c index b0d68bdc44..235837abcb 100644 --- a/util/fdmon-io_uring.c +++ b/util/fdmon-io_uring.c @

[PATCH-for-10.1 6/8] target/mips: Introduce mips_cpu_is_64bit() helper

2025-03-25 Thread Philippe Mathieu-Daudé
mips_cpu_is_64bit() returns whether the CPU is a 32-bit or a 64-bit one. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu-qom.h | 2 ++ target/mips/cpu.c | 6 ++ 2 files changed, 8 insertions(+) diff --git a/target/mips/cpu-qom.h b/target/mips/cpu-qom.h index 9acf647420c..52996

Re: [PATCH v2 02/11] target/avr: Improve decode of LDS, STS

2025-03-25 Thread Philippe Mathieu-Daudé
On 25/3/25 23:43, Richard Henderson wrote: The comment about not being able to define a field with zero bits is out of date since 94597b6146f3 ("decodetree: Allow !function with no input bits"). This fixes the missing load of imm in the disassembler. Cc: qemu-sta...@nongnu.org Fixes: 9d8caa67a2

Re: [PATCH v2 01/11] target/avr: Fix buffer read in avr_print_insn

2025-03-25 Thread Philippe Mathieu-Daudé
On 25/3/25 23:43, Richard Henderson wrote: Do not unconditionally attempt to read 4 bytes, as there may only be 2 bytes remaining in the translator cache. Cc: qemu-sta...@nongnu.org Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/avr/disas.c | 21 ++-

Re: [PATCH-for-10.0 10/12] hw/rtc: Categorize and add description

2025-03-25 Thread BALATON Zoltan
On Tue, 25 Mar 2025, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/rtc/ds1338.c | 2 ++ hw/rtc/m41t80.c | 2 ++ hw/rtc/rs5c372.c | 2 ++ 3 files changed, 6 insertions(+) diff --git a/hw/rtc/ds1338.c b/hw/rtc/ds1338.c index 8dd17fdc07c..56162917c1b 100644 --- a/hw/rtc

Re: [RFC PATCH v2 00/20] hw/arm/virt: Add support for user-creatable accelerated SMMUv3

2025-03-25 Thread Nicolin Chen via
On Tue, Mar 25, 2025 at 03:43:29PM +, Shameerali Kolothum Thodi wrote: > > For the record I tested the series with host VFIO device and a > > virtio-blk-pci device put behind the same pxb-pcie/smmu protection and > > it works just fine > > > > -+-[:0a]-+-01.0-[0b]00.0  Mellanox Technol

Re: [RFC PATCH v2 12/20] hw/arm/smmuv3-accel: Return sysmem if stage-1 is bypassed

2025-03-25 Thread Eric Auger
On 3/11/25 3:10 PM, Shameer Kolothum wrote: > From: Nicolin Chen > > When nested translation is enabled, there are 2-stage translation > occuring to two different address spaces: stage-1 in the iommu as, > while stage-2 in the system as. > > If a device attached to the vSMMU doesn't enable stag

Re: [PATCH v7 52/52] docs: Add TDX documentation

2025-03-25 Thread Daniel P . Berrangé
On Fri, Jan 24, 2025 at 08:20:48AM -0500, Xiaoyao Li wrote: > Add docs/system/i386/tdx.rst for TDX support, and add tdx in > confidential-guest-support.rst > > Signed-off-by: Xiaoyao Li > --- > --- > docs/system/confidential-guest-support.rst | 1 + > docs/system/i386/tdx.rst

Re: [PATCH v6 09/10] ppc/pnv: Add PHB5 PCIe Host bridge to Power11

2025-03-25 Thread Cédric Le Goater
On 3/25/25 12:23, Aditya Gupta wrote: Power11 also uses PHB5, same as Power10. Add Power11 PHBs with similar code as the corresponding Power10 implementation. Cc: Cédric Le Goater Cc: Frédéric Barrat Cc: Mahesh J Salgaonkar Cc: Madhavan Srinivasan Cc: Nicholas Piggin Signed-off-by: Aditya

Re: [PATCH-for-10.1 v2] target/riscv/gdbstub: Replace ldtul_p() -> ldn_p(sizeof(target_ulong))

2025-03-25 Thread Richard Henderson
On 3/25/25 08:49, Philippe Mathieu-Daudé wrote: Replace the few ldtul_p() calls by a generic ldn_p() ones. No logical change. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/gdbstub.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [PATCH-for-10.1] target/i386/gdbstub: Replace ldtul_p() -> ldq_p()

2025-03-25 Thread Richard Henderson
On 3/25/25 08:45, Philippe Mathieu-Daudé wrote: When TARGET_LONG_BITS == 64, ldtul_p() expand to ldq_p(). Directly use the expanded form for clarity. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/gdbstub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richar

Re: [ANNOUNCE] QEMU 10.0.0-rc0 is now available

2025-03-25 Thread Michael Roth
Quoting Michael Roth (2025-03-19 07:08:40) > Hello, > > On behalf of the QEMU Team, I'd like to announce the availability of the > first release candidate for the QEMU 10.0 release. This release is meant > for testing purposes and should not be used in a production environment. > > http://downl

[PATCH-for-10.0 05/12] hw/gpio/pca9552: Categorize and add description

2025-03-25 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/gpio/pca9552.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/gpio/pca9552.c b/hw/gpio/pca9552.c index 1ac0cf6c464..b152872f6c6 100644 --- a/hw/gpio/pca9552.c +++ b/hw/gpio/pca9552.c @@ -459,6 +459,8 @@ static void pca9552_class_init(ObjectCl

[PATCH v2 09/11] target/avr: Use do_stb in avr_cpu_do_interrupt

2025-03-25 Thread Richard Henderson
Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- target/avr/helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target/avr/helper.c b/target/avr/helper.c index 7d6954ec26..f23fa3e8ba 100644 --- a/target/

  1   2   3   >