On 3/25/25 16:13, Philippe Mathieu-Daudé wrote:
On 25/3/25 23:43, Richard Henderson wrote:The comment about not being able to define a field with zero bits is out of date since 94597b6146f3 ("decodetree: Allow !function with no input bits").This fixes the missing load of imm in the disassembler. Cc: qemu-sta...@nongnu.org Fixes: 9d8caa67a24 ("target/avr: Add support for disassembling via option '-d in_asm'")Isn't it: Fixes: 9732b024f79 ("target/avr: Add instruction translation - Data Transfer Instructions") ?
Not really. The trans_FOO for the insn itself does read the immediate. It was only later when we added the disassembler *without* the immediate read that was buggy.
r~
