Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Richard Henderson
On 2/3/25 02:39, Thomas Huth wrote: [...]> diff --git a/configs/targets/hppa-linux-user.mak b/configs/targets/hppa-linux-user.mak index 8e0a80492f..4295cf384e 100644 --- a/configs/targets/hppa-linux-user.mak +++ b/configs/targets/hppa-linux-user.mak @@ -3,3 +3,5 @@ TARGET_ABI32=y   TARGET_SYSTB

Re: [PATCH v1 3/5] hw/vfio/ap: store object indicating AP config changed in a queue

2025-02-03 Thread Anthony Krowiak
On 1/7/25 1:43 PM, Rorie Reyes wrote: Creates an object indicating that an AP configuration change event has been received and stores it in a queue. These objects will later be used to store event information for an AP configuration change when the CHSC instruction is intercepted. Signed-off

Re: [PATCH V1 03/26] vfio: vfio_find_ram_discard_listener

2025-02-03 Thread Cédric Le Goater
On 1/29/25 15:42, Steve Sistare wrote: Define vfio_find_ram_discard_listener as a subroutine so additional calls to it may be added in a subsequent patch. Signed-off-by: Steve Sistare Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/common.c | 35 ++---

Re: [PATCH V1 02/26] migration: lower handler priority

2025-02-03 Thread Peter Xu
On Wed, Jan 29, 2025 at 06:42:58AM -0800, Steve Sistare wrote: > Define a vmstate priority that is lower than the default, so its handlers > run after all default priority handlers. Since 0 is no longer the default > priority, translate an uninitialized priority of 0 to MIG_PRI_DEFAULT. > > CPR f

[PULL 2/6] tests/qtest/libqos: add DMA support for writing and reading fw_cfg files

2025-02-03 Thread Fabiano Rosas
From: Ani Sinha At present, the libqos/fw_cfg.c library does not support the modern DMA interface which is required to write to the fw_cfg files. It only uses the IO interface. Implement read and write methods based on DMA. This will enable developers to add tests that writes to the fw_cfg file(s

[PULL 4/6] tests/qtest: Extract qtest_qom_has_concrete_type() helper

2025-02-03 Thread Fabiano Rosas
From: Philippe Mathieu-Daudé Extract qtest_qom_has_concrete_type() out of qtest_has_device() in order to re-use it in the following commit. Reviewed-by: Thomas Huth Reviewed-by: Akihiko Odaki Signed-off-by: Philippe Mathieu-Daudé Message-ID: <20250130103728.536-2-phi...@linaro.org> Signed-off

[PULL 6/6] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

2025-02-03 Thread Fabiano Rosas
From: Thomas Huth All other vhost-user tests here use modern virtio, too, so let's adjust the vhost-user-net test accordingly. Signed-off-by: Thomas Huth Message-ID: <20250203124346.169607-1-th...@redhat.com> Reviewed-by: Fabiano Rosas Signed-off-by: Fabiano Rosas --- tests/qtest/vhost-user-

[PULL 1/6] libqos/fw_cfg: refactor file directory iteraton to make it more reusable

2025-02-03 Thread Fabiano Rosas
From: Ani Sinha fw-cfg file directory iteration code can be used by other functions that may want to implement fw-cfg file operations. Refactor it into a smaller helper so that it can be reused. No functional change. Signed-off-by: Ani Sinha Reviewed-by: Fabiano Rosas Message-ID: <20250120043

[PULL 0/6] QTest patches for 2025-02-03

2025-02-03 Thread Fabiano Rosas
The following changes since commit 6fccaa2fba391815308a746d68f7fa197bc93586: Merge tag 'block-pull-request' of https://gitlab.com/stefanha/qemu into staging (2025-02-02 11:09:10 -0500) are available in the Git repository at: https://gitlab.com/farosas/qemu.git tags/qtest-202

[PULL 3/6] tests/qtest/vmcoreinfo: add a unit test to exercize basic vmcoreinfo function

2025-02-03 Thread Fabiano Rosas
From: Ani Sinha A new qtest is written that exercizes the fw-cfg DMA based read and write ops to write values into vmcoreinfo fw-cfg file and read them back and verify that they are the same. Signed-off-by: Ani Sinha Message-ID: <20250120043847.954881-4-anisi...@redhat.com> Signed-off-by: Fabia

Re: KVM/QEMU community call 4/2/2025 agenda items

2025-02-03 Thread Brian Cain
On 1/31/2025 7:24 AM, Alex Bennée wrote: Hi, The KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 04/02/2025 14:00 UTC Are there any agenda items for the sync-up? I'd like to discuss the upstreaming of hexagon sysemu - one piece we could use help is the "QTimer." This i

Re: [PATCH 2/2] hw/cxl/cxl-mailbox-utils: Add support for Media operations Sanitize and Write Zeros commands (8.2.9.9.5.3)

2025-02-03 Thread Adam Manzanares
On Mon, Feb 03, 2025 at 11:33:54AM +, Jonathan Cameron wrote: > > > > > > > > +int dpa_range_count = san_info->dpa_range_count; > > > > +int rc = 0; > > > > + > > > > +for (int i = 0; i < dpa_range_count; i++) { > > > > +rc = sanitize_range(ct3d, > > > > san_info->dpa_r

Re: [PATCH V1 04/26] vfio/container: register container for cpr

2025-02-03 Thread Cédric Le Goater
On 1/29/25 15:43, Steve Sistare wrote: Register a legacy container for cpr-transfer. Add a blocker if the kernel does not support VFIO_UPDATE_VADDR or VFIO_UNMAP_ALL. This is mostly boiler plate. The fields to to saved and restored are added in subsequent patches. Signed-off-by: Steve Sistare

[PULL 5/6] tests/qtest: Make qtest_has_accel() generic

2025-02-03 Thread Fabiano Rosas
From: Philippe Mathieu-Daudé Since commit b14a0b7469f ("accel: Use QOM classes for accel types") accelerators are registered as QOM objects. Use QOM as a generic API to query for available accelerators. This is in particular useful to query hardware accelerators such HFV, Xen or WHPX which otherw

Re: [PATCH] target/sparc: Fix register selection for the fdtox and fqtox instructions

2025-02-03 Thread Richard Henderson
On 2/3/25 06:01, Mikael Szreder wrote: A bug was introduced in commit 0bba7572d40d which causes the fdtox and fqtox instructions to incorrectly select the destination registers. More information and a test program can be found in issue #2802. Fixes: 0bba7572d40d ("target/sparc: Perform DFPREG/

Re: [PATCH 0/7] hw/arm/raspi4b: Add models with 4GB and 8GB of DRAM

2025-02-03 Thread Peter Maydell
On Mon, 3 Feb 2025 at 14:50, Daniel P. Berrangé wrote: > > On Mon, Feb 03, 2025 at 02:45:06PM +, Peter Maydell wrote: > > For Arm embedded boards we mostly tend to "restrict the user > > to what you can actually do", except for older boards where > > we tended not to write any kind of sanity c

Re: [PATCH] hw/cxl: Support aborting background commands

2025-02-03 Thread Jonathan Cameron via
On Tue, 22 Oct 2024 18:00:30 +0100 Jonathan Cameron wrote: > On Mon, 21 Oct 2024 20:23:46 -0700 > Davidlohr Bueso wrote: > > > On Tue, 27 Aug 2024, Jonathan Cameron wrote:\n > > >No comments inline and LGTM. I'll queue it on my tree and push > > >that out on gitlab sometime soonish. > >

Re: [PATCH] tests/qtest/vhost-user-test: Use modern virtio for vhost-user tests

2025-02-03 Thread Fabiano Rosas
Thomas Huth writes: > All other vhost-user tests here use modern virtio, too, so let's > adjust the vhost-user-net test accordingly. > > Signed-off-by: Thomas Huth > --- > tests/qtest/vhost-user-test.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tests/qtest/vhost-

Re: [PATCH v2 04/14] meson: Introduce CONFIG_TCG_TARGET

2025-02-03 Thread Richard Henderson
On 2/3/25 02:08, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Use CONFIG_TCG as a project-wide flag to indicate that TCG is enabled for *some* target.  Use CONFIG_TCG_TARGET to indicate that TCG is enabled for a specific target. Within a specific compilation unit, we can rem

Re: [PATCH v5 13/17] aspeed/soc: Add AST2700 support

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 08:43, Jamin Lin wrote: Hi Philippe, From: Jamin Lin Sent: Monday, February 3, 2025 3:29 PM To: Philippe Mathieu-Daudé ; Cédric Le Goater ; Peter Maydell ; Andrew Jeffery ; Joel Stanley ; Alistair Francis ; Cleber Rosa ; Wainer dos Santos Moschetta ; Beraldo Leal ; open list:ASPEED BM

Re: [PATCH v2 07/14] accel/stubs: Expand stubs for TCG

2025-02-03 Thread Richard Henderson
On 2/3/25 02:22, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Add tcg_allowed, qmp_x_query_jit, qmp_x_query_opcount. These are referenced when CONFIG_TCG is enabled globally, but not for a specific target. Signed-off-by: Richard Henderson ---   accel/stubs/tcg-stub.c | 24 +

Re: [PATCH qemu 3/5] hw/mem/cxl_type3: Fix special_ops memory leak on msix_init_exclusive_bar() failure

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 17:19, Jonathan Cameron via wrote: From: Li Zhijian Address a memory leak issue by ensuring `regs->special_ops` is freed when `msix_init_exclusive_bar()` encounters an error during CXL Type3 device initialization. Additionally, this patch renames err_address_space_free to err_msix_un

Re: [PATCH qemu 4/5] hw/mem/cxl_type3: Ensure errp is set on realization failure

2025-02-03 Thread Philippe Mathieu-Daudé
On 3/2/25 17:19, Jonathan Cameron via wrote: From: Li Zhijian Simply pass the errp to its callee which will set errp if needed, to enhance error reporting for CXL Type 3 device initialization by setting the errp when realization functions fail. Previously, failing to set `errp` could result in

Re: [PATCH v2 0/7] physmem: teach cpu_memory_rw_debug() to write to more memory regions

2025-02-03 Thread Peter Xu
On Fri, Jan 24, 2025 at 04:45:25PM +0100, David Hildenbrand wrote: > This is a follow-up to [1], implementing it by avoiding the use of > address_space_write_rom() in cpu_memory_rw_debug() completely, and > teaching address_space_write() about debug access instead, the can also > write to ROM. > >

Re: [PATCH v2 1/1] target/riscv: log guest errors when reserved bits are set in PTEs

2025-02-03 Thread Daniel Henrique Barboza
On 2/3/25 3:18 AM, julia wrote: For instance, QEMUs newer than b6ecc63c569bb88c0fcadf79fb92bf4b88aefea8 would silently treat this akin to an unmapped page (as required by the RISC-V spec, admittedly). However, not all hardware platforms do (e.g. CVA6) which leads to an apparent QEMU bug. Inst

Re: [PATCH 2/2] hw/cxl/cxl-mailbox-utils: Add support for Media operations Sanitize and Write Zeros commands (8.2.9.9.5.3)

2025-02-03 Thread Jonathan Cameron via
> > > > > +int dpa_range_count = san_info->dpa_range_count; > > > +int rc = 0; > > > + > > > +for (int i = 0; i < dpa_range_count; i++) { > > > +rc = sanitize_range(ct3d, > > > san_info->dpa_range_list[i].starting_dpa, > > > +san_info->dpa_range_list[i].len

[PATCH] qom: reverse order of instance_post_init calls

2025-02-03 Thread Paolo Bonzini
Currently, the instance_post_init calls are performed from the leaf class and all the way up to Object. This is incorrect because the leaf class cannot observe property values applied by the superclasses; for example, a compat property will be set on a device *after* the class's post_init callback

Re: [PATCH v2 02/14] tcg: Move stubs in tcg/perf.h to tcg/perf-stubs.c

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > These are not called so frequently as to be > performance sensitive. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

2025-02-03 Thread Alex Bennée
Thomas Huth writes: > On 03/02/2025 04.18, Richard Henderson wrote: >> Define TARGET_LONG_BITS in each target's configure fragment. >> Do this without removing the define in target/*/cpu-param.h >> so that errors are caught like so: >> In file included from .../src/include/exec/cpu-defs.h:26, >>

Re: [PATCH v2 09/14] gitlab: Replace aarch64 with arm in cross-i686-tci build

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > Configuration of 64-bit host on 32-bit guest will shortly > be denied. Use a 32-bit guest instead. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 11/14] target/*: Remove TARGET_LONG_BITS from cpu-param.h

2025-02-03 Thread Alex Bennée
Richard Henderson writes: > This is now handled by the configs/targets/*.mak fragment. > > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PATCH 13/18] user: Introduce host_interrupt_signal

2025-02-03 Thread Alex Bennée
From: Ilya Leoshkevich Attaching to the gdbstub of a running process requires stopping its threads. For threads that run on a CPU, cpu_exit() is enough, but the only way to grab attention of a thread that is stuck in a long-running syscall is to interrupt it with a signal. Reserve a host realtim

[PATCH 00/18] maintainer updates for feb25 (qtest, gdbstub, plugins)

2025-02-03 Thread Alex Bennée
Another month and another set of updates from across my maintainer trees. They include: * qtest set/step clock cleanups It seems the earlier patch to avoid deadlock when shutting down was overly broad. So in this series after a little clean-up to the qtest reply code we tighten up some checks f

[PATCH 02/18] tests/qtest: don't attempt to clock_step while waiting for virtio ISR

2025-02-03 Thread Alex Bennée
This replicates the changes from 92cb8f8bf6 (tests/qtest: remove clock_steps from virtio tests) as there are no timers in the virtio code. We still busy wait and timeout though. Signed-off-by: Alex Bennée --- v2 - fix trailing space --- tests/qtest/libqos/virtio-pci-modern.c | 6 ++ tests

[PATCH 0/3] CXL CCI Log Commands implementation

2025-02-03 Thread Arpit Kumar
CXL CCI log commands implmented as per CXL Specification 3.1 8.2.9.5 1) get_log_capabilities (Opcode 0402h) 2) clear_log (Opcode 0403h) 3) populate_log (Opcode 0404h) The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2024-11-27. Signed-off-by

RE: [PATCH v1 02/18] hw/intc/aspeed: Support different memory region ops

2025-02-03 Thread Jamin Lin
Hi Andrew, > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 11:32 AM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1 02/18]

RE: [PATCH v1 11/18] hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisions

2025-02-03 Thread Jamin Lin
Hi Andrew, > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 12:05 PM > To: Jamin Lin ; Cédric Le Goater ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1 11/18]

Re: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

2025-02-03 Thread Cédric Le Goater
On 2/4/25 07:50, Jamin Lin wrote: Hi Cedric, Andrew From: Andrew Jeffery Sent: Thursday, January 30, 2025 11:22 AM To: Cédric Le Goater ; Jamin Lin ; Peter Maydell ; Steven Lee ; Troy Lee ; Joel Stanley ; open list:ASPEED BMCs ; open list:All patches CC here Cc: Troy Lee ; Yunlin Tang Subjec

Re: [PATCH v3 18/26] hw/arm/boot: Mark all guest memory as RIPAS_RAM.

2025-02-03 Thread Gavin Shan
On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: All Realm IPA states are by default RIPAS_EMPTY, and accessing them in that state causes injection of synchronous exception. Either the loader or the guest needs to set IPA state to RIPAS_RAM before accessing it. Since a Linux guest needs all memo

[PATCH 0/1] CXL CCI Health Information & Alerts Commands implementation

2025-02-03 Thread Sweta Kumari
CXL CCI get/set alert config commands implmented as per CXL Specification 3.1 8.2.9.9.3 1)get alert configuration(Opcode 4201h) 2)set alert configuration(Opcode 4202h) The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2024-11-27. Signed-off

Re: [PATCH-for-10.0 3/3] hw/boards: Rename no_sdcard -> create_default_sdcard_drive

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: Invert the 'no_sdcard' logic, renaming it as the more explicit "create_default_sdcard_drive". Machines are supposed to create a SD Card drive when this flag is set. In many cases it doesn't make much sense (as boards don't expose SD Card host con

Re: [PATCH v1 11/18] hw/misc/aspeed_scu: Add Support for AST2700/AST2750 A1 Silicon Revisions

2025-02-03 Thread Cédric Le Goater
Hello Jamin, --- a/hw/misc/aspeed_scu.c +++ b/hw/misc/aspeed_scu.c @@ -559,6 +559,8 @@ static uint32_t aspeed_silicon_revs[] = { AST2700_A0_SILICON_REV, AST2720_A0_SILICON_REV, AST2750_A0_SILICON_REV, +    AST2700_A1_SILICON_REV, +    AST2750_A1_SILICON_REV,  };  bool is_sup

RE: [PATCH v1 01/18] hw/intc/aspeed: Rename INTC to INTC0

2025-02-03 Thread Jamin Lin
Hi Cedric, Andrew > From: Andrew Jeffery > Sent: Thursday, January 30, 2025 11:22 AM > To: Cédric Le Goater ; Jamin Lin ; > Peter Maydell ; Steven Lee > ; Troy Lee ; Joel Stanley > ; open list:ASPEED BMCs ; open > list:All patches CC here > Cc: Troy Lee ; Yunlin Tang > > Subject: Re: [PATCH v1

Re: [PATCH-for-10.0 1/3] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: MachineClass::no_sdcard is initialized as false by default. To catch all uses, convert it to a tri-state, having the current default (false) becoming AUTO. No logical change intended. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boar

[PATCH 3/3] hw/cxl/cxl-mailbox-utils.c: Added support for Populate Log (Opcode 0404h) as background operation

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 95 + include/hw/cxl/cxl_device.h | 2 + 2 files changed, 97 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-u

Re: [PATCH-for-10.0 0/3] hw/boards: Try to make sense of MachineClass::no_sdcard flag

2025-02-03 Thread Thomas Huth
On 26/11/2024 06.24, Philippe Mathieu-Daudé wrote: On 25/11/24 19:14, Philippe Mathieu-Daudé wrote: Invert MachineClass 'no_sdcard' flag logic and rename it to 'create_default_sdcard_drive' to make sense of this default value applied to all machines. No logical change intended. Philippe Mathieu

[PATCH 1/1] Added support for get/set alert configuration commands

2025-02-03 Thread Sweta Kumari
Signed-off-by: Sweta Kumari Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 91 + hw/mem/cxl_type3.c | 20 include/hw/cxl/cxl_device.h | 24 ++ 3 files changed, 135 insertions(+) diff --g

[PATCH 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 55 include/hw/cxl/cxl_device.h | 31 include/hw/cxl/cxl_mailbox.h | 5 3 files changed, 91 insertions(+) di

Re: [PATCH-for-10.0 2/3] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF

2025-02-03 Thread Thomas Huth
On 25/11/2024 19.14, Philippe Mathieu-Daudé wrote: Update MachineClass::no_sdcard default implicit AUTO initialization to explicit OFF. This flag is consumed in system/vl.c::qemu_disable_default_devices(). Use this place to assert we don't have anymore AUTO state. In hw/ppc/e500.c we add the ppc

[PATCH 2/3] hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 3d66a425a9..5fd7f850c4 100

Re: [PATCH v2 04/14] meson: Introduce CONFIG_TCG_TARGET

2025-02-03 Thread Thomas Huth
On 03/02/2025 17.38, Richard Henderson wrote: On 2/3/25 02:08, Thomas Huth wrote: On 03/02/2025 04.18, Richard Henderson wrote: Use CONFIG_TCG as a project-wide flag to indicate that TCG is enabled for *some* target.  Use CONFIG_TCG_TARGET to indicate that TCG is enabled for a specific target.

Re: [PATCH v1 1/1] aspeed/soc: Support Non-maskable Interrupt for AST2700

2025-02-03 Thread Cédric Le Goater
+ Philippe On 2/4/25 07:09, Jamin Lin wrote: QEMU supports GICv3 Non-maskable Interrupt, adds to support Non-maskable Interrupt for AST2700. Reference: https://github.com/qemu/qemu/commit/b36a32ead Signed-off-by: Jamin Lin --- hw/arm/aspeed_ast27x0.c | 4 1 file changed, 4 insertions(

[PATCH] tests/functional: Add a ppc sam460ex test

2025-02-03 Thread Cédric Le Goater
The test sequence boots from kernel a sam460ex machine with a virtio-net device to check PCI. The buildroot is built with config : BR2_powerpc=y BR2_powerpc_440fp=y and the kernel with the '44x/canyonlands' deconfig and virtio support. Cc: BALATON Zoltan Signed-off-by: Cédric Le Goater --

<    1   2   3