Re: [PATCH v2 10/14] configure: Define TARGET_LONG_BITS in configs/targets/*.mak

[Richard Henderson]

On 2/3/25 02:39, Thomas Huth wrote:

[...]> diff --git a/configs/targets/hppa-linux-user.mak 
b/configs/targets/hppa-linux-user.mak

index 8e0a80492f..4295cf384e 100644
--- a/configs/targets/hppa-linux-user.mak
+++ b/configs/targets/hppa-linux-user.mak
@@ -3,3 +3,5 @@ TARGET_ABI32=y
  TARGET_SYSTBL_ABI=common,32
  TARGET_SYSTBL=syscall.tbl
  TARGET_BIG_ENDIAN=y
+# Compromise to ease maintainence vs system mode

s/maintainence/maintenance/

Oops.

diff --git a/configs/targets/mipsn32-linux-user.mak b/configs/targets/mipsn32-linux- user.mak

index 206095da64..39ae214633 100644
--- a/configs/targets/mipsn32-linux-user.mak
+++ b/configs/targets/mipsn32-linux-user.mak
@@ -5,3 +5,4 @@ TARGET_BASE_ARCH=mips
  TARGET_SYSTBL_ABI=n32
  TARGET_SYSTBL=syscall_n32.tbl
  TARGET_BIG_ENDIAN=y
+TARGET_LONG_BITS=64

Why is this 64 ?

diff --git a/configs/targets/mipsn32el-linux-user.mak b/configs/targets/mipsn32el-linux- user.mak

index ca2a3ed753..d9b61d6990 100644
--- a/configs/targets/mipsn32el-linux-user.mak
+++ b/configs/targets/mipsn32el-linux-user.mak
@@ -4,3 +4,4 @@ TARGET_ABI32=y
  TARGET_BASE_ARCH=mips
  TARGET_SYSTBL_ABI=n32
  TARGET_SYSTBL=syscall_n32.tbl
+TARGET_LONG_BITS=64

dito?

diff --git a/configs/targets/sparc32plus-linux-user.mak b/configs/targets/sparc32plus- linux-user.mak

index 6cc8fa516b..7a16934fd1 100644
--- a/configs/targets/sparc32plus-linux-user.mak
+++ b/configs/targets/sparc32plus-linux-user.mak
@@ -5,3 +5,4 @@ TARGET_ABI_DIR=sparc
  TARGET_SYSTBL_ABI=common,32
  TARGET_SYSTBL=syscall.tbl
  TARGET_BIG_ENDIAN=y
+TARGET_LONG_BITS=64

Same question here: Why 64? If this isn't a mistake, could you maybe add a 
comment?

All three are 64-bit cpus using an ABI with 32-bit pointers.


r~