[PULL 05/13] virtio-gpu: Unrealize GL device

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko Even though GL GPU doesn't support hotplugging today, free virgl resources when GL device is unrealized. For consistency. Signed-off-by: Dmitry Osipenko Message-Id: <20241024210311.118220-6-dmitry.osipe...@collabora.com> Signed-off-by: Alex Bennée diff --git a/hw/display

[PATCH 1/5] qom: remove unused function

2024-10-29 Thread Paolo Bonzini
The function has been unused since commit 4fa28f23906 ("ppc/pnv: Instantiate cores separately", 2019-12-17). The idea was that you could use it to build an array of objects via pointer arithmetic, but no one is doing it anymore. Cc: Dr. David Alan Gilbert Signed-off-by: Paolo Bonzini --- inclu

[PATCH 5/5] qom: allow user-creatable classes to be in modules

2024-10-29 Thread Paolo Bonzini
There is no real reason to make user-creatable classes different from other backends in this respect. This also allows modularized character devices to be treated by qom-list-properties just like builtin ones. Signed-off-by: Paolo Bonzini --- qom/object_interfaces.c | 2 +- qom/qom-qmp-cmds.c

[PATCH 0/5] qom: module loading cleanups

2024-10-29 Thread Paolo Bonzini
While looking at possible Rust APIs for object_new/qdev_new (one of the functions that rust/hw/char/pl011 uses via FFI) I noticed that the support for modules in QOM APIs is quite random. In particular, loading modules is done by object_initialize() and qdev_new(), but not by object_new(); further

[PATCH 4/5] qom: let object_new use a module if the type is not present

2024-10-29 Thread Paolo Bonzini
object_initialize() can use modules (it was added there because virtio-gpu-device is a child device of virtio-gpu-pci; commit 64f7aece8ea, "object_initialize: try module load", 2020-09-15). object_new() cannot; make things consistent. qdev_new() is now just a simple wrapper that returns DeviceStat

Re: [PULL 11/13] ui/console: Remove dpy_cursor_define_supported()

2024-10-29 Thread Michael Tokarev
16.07.2024 21:09, Philippe Mathieu-Daudé wrote: From: Akihiko Odaki Remove dpy_cursor_define_supported() as it brings no benefit today and it has a few inherent problems. All graphical displays except egl-headless support cursor composition without DMA-BUF, and egl-headless is meant to be used

Re: [PATCH] hw/nvme: fix handling of over-committed queues

2024-10-29 Thread Klaus Jensen
On Oct 28 09:15, Keith Busch wrote: > On Mon, Oct 28, 2024 at 10:01:50AM +0100, Klaus Jensen wrote: > > On Oct 25 10:45, Keith Busch wrote: > > > On Fri, Oct 25, 2024 at 12:50:45PM +0200, Klaus Jensen wrote: > > > > @@ -1520,9 +1520,16 @@ static void nvme_post_cqes(void *opaque) > > > > nv

Re: [PATCH V2] crypto: Introduce SM3 hash hmac pbkdf algorithm

2024-10-29 Thread Daniel P . Berrangé
On Tue, Oct 29, 2024 at 08:06:39PM +0800, liequan che wrote: > Introduce the SM3 cryptographic hash algorithm (GB/T 32905-2016). > > SM3 (GB/T 32905-2016) is a cryptographic standard issued by the > Organization of State Commercial Cryptography Administration (OSCCA) > as an authorized cryptograph

Re: [PULL 11/13] ui/console: Remove dpy_cursor_define_supported()

2024-10-29 Thread Phil Dennis-Jordan
On Tue, 29 Oct 2024 at 13:30, Michael Tokarev wrote: > 16.07.2024 21:09, Philippe Mathieu-Daudé wrote: > > From: Akihiko Odaki > > > > Remove dpy_cursor_define_supported() as it brings no benefit today and > > it has a few inherent problems. > > > > All graphical displays except egl-headless sup

[PATCH v2] hw/nvme: fix handling of over-committed queues

2024-10-29 Thread Klaus Jensen
From: Klaus Jensen If a host chooses to use the SQHD "hint" in the CQE to know if there is room in the submission queue for additional commands, it may result in a situation where there are not enough internal resources (struct NvmeRequest) available to process the command. For a lack of a better

Re: [PATCH] target/hppa: Add CPU reset method

2024-10-29 Thread Peter Maydell
On Fri, 25 Oct 2024 at 19:25, Helge Deller wrote: > > Add the missing CPU reset method, which resets all CPU registers and the > TLB to zero. Then the CPU will switch to 32-bit mode (PSW_W bit is not > set) and start execution at address 0xf004. > > Signed-off-by: Helge Deller > > diff --git

Re: [PATCH v2 4/4] hw/loongarch/virt: Enable cpu hotplug feature on virt machine

2024-10-29 Thread Zhao Liu
[snip] > @@ -1382,8 +1384,40 @@ static void virt_cpu_pre_plug(HotplugHandler > *hotplug_dev, > } > > if (cpu->phy_id == UNSET_PHY_ID) { > -error_setg(&local_err, "CPU hotplug not supported"); > -goto out; > +if ((cpu->thread_id < 0) || (cpu->thread_id >= ms->s

Re: QEMU/KVM Community Call (29/10/24) agenda items?

2024-10-29 Thread Alex Bennée
Paolo Bonzini writes: > On 10/29/24 08:24, Alex Bennée wrote: >> Hi, >> After a missing a few weeks due to travel and conferences the >> KVM/QEMU >> community call is at: >> https://meet.jit.si/kvmcallmeeting >> @ >> 29/10/2024 14:00 UTC >> Are there any agenda items for the sync-up? > > I would

Re: [PATCH] target/arm: kvm: require KVM_CAP_DEVICE_CTRL

2024-10-29 Thread Peter Maydell
On Thu, 24 Oct 2024 at 12:32, Paolo Bonzini wrote: > > The device control API was added in 2013, assume that it is present. > > Signed-off-by: Paolo Bonzini > --- > target/arm/kvm_arm.h | 16 +++- > hw/intc/arm_gic_kvm.c | 9 + > target/arm/kvm.c | 17 +

[PATCH 08/16] hw/usb: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/usb/hcd-ehci-pci.c | 2 +- hw/usb/hcd-uhci.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c ind

[PATCH 03/16] hw/net: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/net/e1000.c| 2 +- hw/net/eepro100.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 5012b964640d..ab722

[PATCH 01/16] arm: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/arm/armsse.c| 2 +- hw/arm/smmuv3.c| 4 ++-- target/arm/cpu.c | 2 +- target/arm/cpu64.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a

[PATCH 10/16] i386: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- include/hw/i386/pc.h | 4 ++-- target/i386/cpu.c| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index

[PATCH 02/16] hw/block: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/block/m25p80.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index e2e84f8b5f8d..748594524e3f 100644 --- a/hw

[PATCH 11/16] target/mips: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- target/mips/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/mips/cpu.c b/target/mips/cpu.c index 9724e71a5e0f..80ad4ae1084c 100644 --- a/ta

[PATCH 12/16] target/sparc: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- target/sparc/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index 54cb269e0af1..f784b84ddd91 100644 --- a

[PATCH 09/16] hw/virtio: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/virtio/virtio-pci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 4d832fe8455d..21ff7

[PATCH 00/16] qom/object: Deprecate type_register()

2024-10-29 Thread Zhao Liu
Hi maintainers, This series is trying to deprecate type_register() and just keep type_register_static() to register QOM type. This series chosen to deprecate type_register() since changes required to deprecate type_register() are smaller. (type_register_static() needs 1000+ LOC changes.) The two

[PATCH 15/16] script/codeconverter/qom_type_info: Deprecate MakeTypeRegisterStatic and MakeTypeRegisterNotStatic

2024-10-29 Thread Zhao Liu
Deprecate MakeTypeRegisterStatic and MakeTypeRegisterNotStatic because type_register() will be deprecated, then only type_register_static() is used. Signed-off-by: Zhao Liu --- .../codeconverter/qom_type_info.py| 20 --- 1 file changed, 20 deletions(-) diff --git a/s

[PATCH 16/16] qom/object: Deprecate type_register()

2024-10-29 Thread Zhao Liu
At present, type_register() and type_register_static() are identical, although their documentation expects the *_static variant to accept the Typeinfo with the strings that have the static lifetime. However, the code implementation doesn't have any check or guarantee for static lifetime. In fact,

[PATCH 06/16] hw/scsi: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because\ type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/scsi/megasas.c | 2 +- hw/scsi/mptsas.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index 221b06d6aaf6

Re: [PATCH 1/6] target/i386: Add AVX512 state when AVX10 is supported

2024-10-29 Thread Paolo Bonzini
On 10/28/24 10:25, Tao Su wrote: On Mon, Oct 28, 2024 at 09:41:14AM +0100, Paolo Bonzini wrote: On 10/28/24 03:45, Tao Su wrote: AVX10 state enumeration in CPUID leaf D and enabling in XCR0 register are identical to AVX512 state regardless of the supported vector lengths. Given that some E-cor

[PATCH 05/16] hw/rtc: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- hw/rtc/m48t59-isa.c | 2 +- hw/rtc/m48t59.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/rtc/m48t59-isa.c b/hw/rtc/m48t59-isa.c index 6e972

[PATCH 13/16] target/xtensa: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- target/xtensa/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c index ca214b948a96..2978c471c1fc

[PATCH 14/16] ui: Replace type_register() with type_register_static()

2024-10-29 Thread Zhao Liu
Replace type_register() with type_register_static() because type_register() will be deprecated. Signed-off-by: Zhao Liu --- ui/console-vc.c | 2 +- ui/dbus.c | 2 +- ui/gtk.c| 2 +- ui/spice-app.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/console-vc

[PATCH 0/2] Convert the BananaPi and OrangePi Avacodo tests

2024-10-29 Thread Thomas Huth
Some of the URLs in the Avocado tests stopped working since the original assets have been removed from the servers or moved location, see: https://lore.kernel.org/qemu-devel/CACPK8Xc=jsz5iT_WR7s-rcu1cRzryiK+-0o=6vuk_d_qmmr...@mail.gmail.com/ Since we are currently in progress of converting the

[PATCH 1/2] tests/functional: Convert BananaPi tests to the functional framework

2024-10-29 Thread Thomas Huth
Move the BananaPi tests from tests/avocado/boot_linux_console.py into a new file dedicated for Banana Pi tests in the functional framework. Update the hash sums of the assets to sha256 along the way and fix the broken link for the buildroot image from storage.kernelci.org. (Note: The test_arm_bpim

Re: [PATCH 0/4] QOM: Singleton interface

2024-10-29 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 11:01:56AM -0400, Peter Xu wrote: > On Fri, Oct 25, 2024 at 09:38:31AM +0200, Markus Armbruster wrote: > > Peter Xu writes: > > > > > This patchset introduces the singleton interface for QOM. > > > > > > The singleton interface is as simple as "this class can only create o

Re: [PATCH v3 3/7] qapi: block-job-change: make copy-mode parameter optional

2024-10-29 Thread Vladimir Sementsov-Ogievskiy
On 22.10.24 15:35, Kevin Wolf wrote: Am 02.10.2024 um 16:06 hat Vladimir Sementsov-Ogievskiy geschrieben: We are going to add more parameters to change. We want to make possible to change only one or any subset of available options. So all the options should be optional. Signed-off-by: Vladimir

Re: [PATCH 00/36] next-cube: more tidy-ups and improvements

2024-10-29 Thread Peter Maydell
On Wed, 23 Oct 2024 at 09:59, Mark Cave-Ayland wrote: > > This series contains a number of tidy-ups and improvements to the NeXTCube > machine > which include: > > - Bringing the code up-to-date with our latest coding standards/APIs, in > particular > related to the board configuration and

Re: [PATCH] accel: remove dead statement and useless assertion

2024-10-29 Thread Alex Bennée
Paolo Bonzini writes: > ops is assigned again just below, and the result of the assignment must > be non-NULL. > > Originally, the check for NULL was meant to be a check for the existence > of the ops class: > > ops = ACCEL_OPS_CLASS(object_class_by_name(ops_name)); > ... > g_assert(o

Re: [PATCH v2 1/4] hw/loongarch/virt: Add CPU topology support

2024-10-29 Thread Zhao Liu
Hi Bibo, [snip] > +In the CPU topology relationship, When we know the ``socket_id`` ``core_id`` > +and ``thread_id`` of the CPU, we can calculate its ``arch_id``: > + > +``arch_id = (socket_id * S) + (core_id * C) + (thread_id * T)`` What's the difference between arch_id and CPU index (CPUState.

[PATCH] target/i386/hvf: hide MPX states from XCR0

2024-10-29 Thread Paolo Bonzini
QEMU does not show availability of MPX in CPUID when running under Hypervisor.framework. Therefore, in the unlikely chance that the host has MPX enabled, hide those bits from leaf 0xD as well. Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86_cpuid.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 3/5] qom: centralize module-loading functionality

2024-10-29 Thread Paolo Bonzini
Put together the common code of object_initialize() and module_object_class_by_name() into a function that supports Error **. Rename the existing function type_get_by_name() to clarify that it will only look at defined types; this is often okay within object.c to look at the parents, but not outsi

Re: QEMU/KVM Community Call (29/10/24) agenda items?

2024-10-29 Thread Paolo Bonzini
On 10/29/24 08:24, Alex Bennée wrote: Hi, After a missing a few weeks due to travel and conferences the KVM/QEMU community call is at: https://meet.jit.si/kvmcallmeeting @ 29/10/2024 14:00 UTC Are there any agenda items for the sync-up? I would like to discuss the next steps for Rust bindin

[PULL 01/14] net: fix build when libbpf is disabled, but libxdp is enabled

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé The net/af-xdp.c code is enabled when the libxdp library is present, however, it also has direct API calls to bpf_xdp_query_id & bpf_xdp_detach which are provided by the libbpf library. As a result if building with --disable-libbpf, but libxdp gets auto-detected, we'll f

Re: [PATCH v6 00/15] acpi: NUMA nodes for CXL HB as GP + complex NUMA test

2024-10-29 Thread Jonathan Cameron via
Gentle ping. This series still applied to upstream when I tested it yesterday. On Mon, 16 Sep 2024 18:10:05 +0100 Jonathan Cameron wrote: > v6 changes: > - 2 new patches (11 and 12) to improve things in existing code after > Igor pointed them out in the new code. > - More detailed example pr

Re: [RFC V1 00/14] precreate phase

2024-10-29 Thread Daniel P . Berrangé
On Fri, Oct 25, 2024 at 02:43:06PM +0100, Daniel P. Berrangé wrote: > > The migration QAPI design has always felt rather odd to me, in that we > have perfectly good commands "migrate" & "migrate-incoming" that are able > to accept an arbitrary list of parameters when invoked. Instead of passing >

[PULL 05/14] ebpf: add formal error reporting to all APIs

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé The eBPF code is currently reporting error messages through trace events. Trace events are fine for debugging, but they are not to be considered the primary error reporting mechanism, as their output is inaccessible to callers. This adds an "Error **errp" parameter to al

Re: [PATCH qemu 0/6] hw/cxl: Link speed and width control

2024-10-29 Thread Jonathan Cameron via
Gentle ping. I'm less worried about hitting this cycle for this than the Generic Port work but this is the missing piece for ensuring we can test the kernel code that builds NUMA description for CXL devices. I'd like to have the full solution for that upstream. The bulk of this is a refactor with

Introduce SM3 hash hmac pbkdf algorithm

2024-10-29 Thread 车烈权
crypto: Introduce SM3 hash hmac pbkdf algorithm Introduce the SM3 cryptographic hash algorithm (GB/T 32905-2016). SM3 (GB/T 32905-2016) is a cryptographic standard issued by the Organization of State Commercial Cryptography Administration (OSCCA) as an authorized cryptographic algorithm for

Re: [PATCH v2 2/4] hw/loongarch/virt: Implement cpu plug interface

2024-10-29 Thread Zhao Liu
(CC Igor since I want to refer his comment on hotplug design.) Hi Bibo, I have some comments about your hotplug design. [snip] > +static void virt_cpu_pre_plug(HotplugHandler *hotplug_dev, > + DeviceState *dev, Error **errp) > +{ > +LoongArchVirtMachineState *lv

Re: [RFC V1 00/14] precreate phase

2024-10-29 Thread Fabiano Rosas
Daniel P. Berrangé writes: > On Fri, Oct 25, 2024 at 02:43:06PM +0100, Daniel P. Berrangé wrote: >> >> The migration QAPI design has always felt rather odd to me, in that we >> have perfectly good commands "migrate" & "migrate-incoming" that are able >> to accept an arbitrary list of parameters

[PULL 02/14] hw/net: fix typo s/epbf/ebpf/ in virtio-net

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé Signed-off-by: Jason Wang --- hw/net/virtio-net.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index fb84d142ee..7c050246e

[PULL 03/14] ebpf: drop redundant parameter checks in static methods

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé Various static methods have checks on their parameters which were already checked immediately before the method was invoked. Drop these redundat checks to simplify the following commit which adds formal error reporting. Signed-off-by: Daniel P. Berrangé Signed-off-by: J

[PULL 00/14] Net patches

2024-10-29 Thread Jason Wang
The following changes since commit cea8ac78545a83e1f01c94d89d6f5a3f6b5c05d2: Merge tag 'pull-aspeed-20241024' of https://github.com/legoater/qemu into staging (2024-10-25 13:35:22 +0100) are available in the Git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for

[PULL 07/14] ebpf: improve trace event coverage to all key operations

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé The existing error trace event is renamed to have a name prefix matching its source file & to remove the redundant first arg that adds no useful information. Signed-off-by: Daniel P. Berrangé Signed-off-by: Jason Wang --- ebpf/ebpf_rss.c | 19 +++ eb

[PULL 14/14] virtio-net: Avoid indirection_table_mask overflow

2024-10-29 Thread Jason Wang
From: Akihiko Odaki We computes indirections_len by adding 1 to indirection_table_mask, but it may overflow indirection_table_mask is UINT16_MAX. Check if indirection_table_mask is small enough before adding 1. Fixes: 590790297c0d ("virtio-net: implement RSS configuration command") Signed-off-by

[PULL 06/14] hw/net: report errors from failing to use eBPF RSS FDs

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé If the user/mgmt app passed in a set of pre-opened FDs for eBPF RSS, then it is expecting QEMU to use them. Any failure to do so must be considered a fatal error and propagated back up the stack, otherwise deployment mistakes will not be detectable in a prompt manner. Whe

[PULL 08/14] hw/net: improve tracing of eBPF RSS setup

2024-10-29 Thread Jason Wang
From: Daniel P. Berrangé This adds more trace events to key eBPF RSS setup operations, and also distinguishes events from multiple NIC instances. Signed-off-by: Daniel P. Berrangé Signed-off-by: Jason Wang --- hw/net/trace-events | 8 +--- hw/net/virtio-net.c | 9 ++--- 2 files change

[PULL 13/14] Fix calculation of minimum in colo_compare_tcp

2024-10-29 Thread Jason Wang
From: Stefan Weil GitHub's CodeQL reports a critical error which is fixed by using the MIN macro: Unsigned difference expression compared to zero Signed-off-by: Stefan Weil Cc: qemu-sta...@nongnu.org Reviewed-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 3 +-- 1 fil

[PULL 11/14] net/tap-win32: Fix gcc 14 format truncation errors

2024-10-29 Thread Jason Wang
From: Bernhard Beschow The patch fixes the following errors generated by GCC 14.2: ../src/net/tap-win32.c:343:19: error: '%s' directive output may be truncated writing up to 255 bytes into a region of size 176 [-Werror=format-truncation=] 343 | "%s\\%s\\Connection", |

[PULL 10/14] chardev: finalize 'reconnect' deprecation

2024-10-29 Thread Jason Wang
From: Daniil Tatianin Change all related docs and tests to use the new 'reconnect-ms' option instead of the now deprecated 'reconnect'. Signed-off-by: Daniil Tatianin Reviewed-by: Marc-André Lureau Signed-off-by: Jason Wang --- docs/COLO-FT.txt | 4 ++-- docs/system/ppc/powernv

[PULL 09/14] net/stream: deprecate 'reconnect' in favor of 'reconnect-ms'

2024-10-29 Thread Jason Wang
From: Daniil Tatianin Do the same thing we already did for chardev in c8e2b6b4d7e, and introduce a new 'reconnect-ms' option to make it possible to specify sub-second timeouts. This also changes the related documentaion and tests to use reconnect-ms as well. Signed-off-by: Daniil Tatianin Revie

[PULL 12/14] net: Check if nc is NULL in qemu_get_vnet_hdr_len()

2024-10-29 Thread Jason Wang
From: Akihiko Odaki A netdev may not have a peer specified, resulting in NULL. We should make it behave like /dev/null in such a case instead of letting it cause segmentatin fault. Fixes: 4b52d63249a5 ("tap: Remove qemu_using_vnet_hdr()") Cc: qemu-sta...@nongnu.org Reported-by: Jonathan Cameron

[PATCH v1 2/8] hw/timer/aspeed: Fix coding style

2024-10-29 Thread Jamin Lin via
Fix coding style issues from checkpatch.pl Signed-off-by: Jamin Lin --- hw/timer/aspeed_timer.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/hw/timer/aspeed_timer.c b/hw/timer/aspeed_timer.c index b1f860ecfb..5af268ea9e 100644 --- a/hw/timer/aspeed_timer.c ++

Re: [PATCH 2/4] x86/iommu: Make x86-iommu a singleton object

2024-10-29 Thread Daniel P . Berrangé
On Thu, Oct 24, 2024 at 12:56:25PM -0400, Peter Xu wrote: > X86 IOMMUs cannot be created more than one on a system yet. Make it a > singleton so it guards the system from accidentally create yet another > IOMMU object when one already presents. > > Now if someone tries to create more than one, e.

[PATCH V2] crypto: Introduce SM3 hash hmac pbkdf algorithm

2024-10-29 Thread liequan che
Introduce the SM3 cryptographic hash algorithm (GB/T 32905-2016). SM3 (GB/T 32905-2016) is a cryptographic standard issued by the Organization of State Commercial Cryptography Administration (OSCCA) as an authorized cryptographic algorithm for use within China. Detect the SM3 cryptographic hash a

[PULL 04/13] virtio-gpu: Handle virtio_gpu_virgl_init() failure

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko virtio_gpu_virgl_init() may fail, leading to a further Qemu crash because Qemu assumes it never fails. Check virtio_gpu_virgl_init() return code and don't execute virtio commands on error. Failed virtio_gpu_virgl_init() will result in a timed out virtio commands for a guest

[PULL 00/13] virtio-gpu vulkan support

2024-10-29 Thread Alex Bennée
The following changes since commit fdf250e5a37830615e324017cb3a503e84b3712c: Merge tag 'pull-maintainer-oct-misc-241024-1' of https://gitlab.com/stsquad/qemu into staging (2024-10-25 19:12:06 +0100) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-virtio

[PULL 10/13] virtio-gpu: Support suspension of commands processing

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko Check whether command processing has been finished; otherwise, stop processing commands and retry the command again next time. This allows us to support asynchronous execution of non-fenced commands needed for unmapping host blobs safely. Suggested-by: Akihiko Odaki Signed

[PULL 13/13] virtio-gpu: Support Venus context

2024-10-29 Thread Alex Bennée
From: Antonio Caggiano Request Venus when initializing VirGL and if venus=true flag is set for virtio-gpu-gl device. Signed-off-by: Antonio Caggiano Signed-off-by: Huang Rui Signed-off-by: Dmitry Osipenko Message-Id: <20241024210311.118220-14-dmitry.osipe...@collabora.com> Signed-off-by: Alex

[PULL 01/13] virtio-gpu: Use trace events for tracking number of in-flight fences

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko Replace printf's used for tracking of in-flight fence inc/dec events with tracing, for consistency with the rest of virtio-gpu code that uses tracing. Suggested-by: Marc-André Lureau Signed-off-by: Dmitry Osipenko Message-Id: <20241024210311.118220-2-dmitry.osipe...@colla

[PULL 02/13] virtio-gpu: Move fence_poll timer to VirtIOGPUGL

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko Move fence_poll timer to VirtIOGPUGL for consistency with cmdq_resume_bh that are used only by GL device. Signed-off-by: Dmitry Osipenko Message-Id: <20241024210311.118220-3-dmitry.osipe...@collabora.com> Signed-off-by: Alex Bennée diff --git a/include/hw/virtio/virtio-g

[PULL 12/13] virtio-gpu: Register capsets dynamically

2024-10-29 Thread Alex Bennée
From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid that problem. Reviewed-by: Manos Pitsidianakis

[PULL 09/13] virtio-gpu: Add virgl resource management

2024-10-29 Thread Alex Bennée
From: Huang Rui In a preparation to adding host blobs support to virtio-gpu, add virgl resource management that allows to retrieve resource based on its ID and virgl resource wrapper on top of simple resource that will be contain fields specific to virgl. Signed-off-by: Huang Rui Reviewed-by: A

[PULL 11/13] virtio-gpu: Handle resource blob commands

2024-10-29 Thread Alex Bennée
From: Robert Beckett Support BLOB resources creation, mapping, unmapping and set-scanout by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Caggiano Signed-off-by: Robert Becket

[PULL 06/13] virtio-gpu: Use pkgconfig version to decide which virgl features are available

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko New virglrerenderer features were stabilized with release of v1.0.0. Presence of symbols in virglrenderer.h doesn't guarantee ABI compatibility with pre-release development versions of libvirglerender. Use virglrenderer version to decide reliably which virgl features are ava

[PULL 08/13] virtio-gpu: Don't require udmabuf when blobs and virgl are enabled

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko The udmabuf usage is mandatory when virgl is disabled and blobs feature enabled in the Qemu machine configuration. If virgl and blobs are enabled, then udmabuf requirement is optional. Since udmabuf isn't widely supported by a popular Linux distros today, let's relax the udm

[PULL 07/13] virtio-gpu: Support context-init feature with virglrenderer

2024-10-29 Thread Alex Bennée
From: Huang Rui Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. Expose this feature and support creating virglrenderer context with flags using context_id if libvirglrenderer is new enough. Originally-by: Antonio Caggiano Signed-off-by: Huang Rui Reviewed-by:

[PULL 03/13] virtio-gpu: Move print_stats timer to VirtIOGPUGL

2024-10-29 Thread Alex Bennée
From: Dmitry Osipenko Move print_stats timer to VirtIOGPUGL for consistency with cmdq_resume_bh and fence_poll that are used only by GL device. Signed-off-by: Dmitry Osipenko Message-Id: <20241024210311.118220-4-dmitry.osipe...@collabora.com> Signed-off-by: Alex Bennée diff --git a/include/hw

Re: [PATCH 1/5] qom: remove unused function

2024-10-29 Thread Daniel P . Berrangé
On Tue, Oct 29, 2024 at 01:26:05PM +0100, Paolo Bonzini wrote: > The function has been unused since commit 4fa28f23906 ("ppc/pnv: > Instantiate cores separately", 2019-12-17). The idea was that > you could use it to build an array of objects via pointer > arithmetic, but no one is doing it anymore

Re: [PATCH] ui/sdl: Mouse event optimization

2024-10-29 Thread BALATON Zoltan
On Tue, 29 Oct 2024, Lei Huang wrote: On Fri, 25 Oct 2024, Lei Huang wrote: Use a convergence factor to make the VM's input global coordinates more closely approach the global coordinates of DOM0. Dom0 is some Xen terminology. Do you mean "host" which is more often used in QEMU? Yes, I will

Re: [PATCH qemu.git v2 0/2] docs/devel/reset: add missing words

2024-10-29 Thread Peter Maydell
On Sun, 27 Oct 2024 at 21:14, ~axelheider wrote: > > v1: > - Add missing words in documentation > > v2: > - add plural 's' > > Axel Heider (2): > docs/devel/reset: add missing words > docs/devel/reset: add plural 's' Thanks for this fix to the docs. I've taken it into target-arm.next (squash

[PULL 04/18] target/arm: Don't assert in regime_is_user() for E10 mmuidx values

2024-10-29 Thread Peter Maydell
In regime_is_user() we assert if we're passed an ARMMMUIdx_E10_* mmuidx value. This used to make sense because we only used this function in ptw.c and would never use it on this kind of stage 1+2 mmuidx, only for an individual stage 1 or stage 2 mmuidx. However, when we implemented FEAT_E0PD we ad

Re: [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0

2024-10-29 Thread Daniel Henrique Barboza
Hi Alexey, Do you have plans to post a new version of this series? Aside from a few comments it seems like this was almost there. We might not be able to get it merged in time for this current release (code freeze is Nov 5th) but we can get it in Alistair's tree for the next release. Thanks

Re: [PATCH v3 2/8] migration: Unexport dirty_bitmap_mig_init()

2024-10-29 Thread Fabiano Rosas
Peter Xu writes: > It's only used within migration/, so it shouldn't be exported. > > Reviewed-by: Cédric Le Goater > Signed-off-by: Peter Xu > --- > include/migration/misc.h | 3 --- > migration/migration.h| 4 > 2 files changed, 4 insertions(+), 3 deletions(-) > > diff --git a/inclu

Re: [PATCH 2/2] tests/functional: Add a test for sh4eb

2024-10-29 Thread Thomas Huth
On 29/10/2024 18.58, Rob Landley wrote: On 10/24/24 03:27, Thomas Huth wrote: Now that we are aware of binaries that are available for sh4eb, we should make sure that there are no regressions with this target and test it regularly in our CI. Any progress on restoring this? Didn't see it in "gi

Re: [PATCH 1/2] Revert "Remove the unused sh4eb target"

2024-10-29 Thread Thomas Huth
On 25/10/2024 18.09, Rob Landley wrote: On 10/24/24 03:27, Thomas Huth wrote: This reverts commit 73ceb12960e686b763415f0880cc5171ccce01cf. The "r2d" machine can work in big endian mode, see:   https://lore.kernel.org/qemu-devel/ d6755445-1060-48a8-82b6-2f392c21f...@landley.net/ So the reas

Re: [PATCH v3 3/8] migration: Unexport ram_mig_init()

2024-10-29 Thread Fabiano Rosas
Peter Xu writes: > It's only used within migration/. > > Signed-off-by: Peter Xu > --- > include/migration/misc.h | 1 - > migration/ram.h | 1 + > 2 files changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/migration/misc.h b/include/migration/misc.h > index df57be6b5e..e8

[RFC v4 0/2] target/riscv: add wrapper for target specific macros in atomicity check.

2024-10-29 Thread Paolo Savini
The version 4 of the patch wraps the host specific macros used to check the support for atomic 128 bit memory operations into generic macros. The patch also adjusts the indentation of the if/else clauses and the comment about the above mentioned check for atomic 128b load/store to reflect better th

[PATCH v5 02/15] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-10-29 Thread Phil Dennis-Jordan
MacOS provides a framework (library) that allows any vmm to implement a paravirtualized 3d graphics passthrough to the host metal stack called ParavirtualizedGraphics.Framework (PVG). The library abstracts away almost every aspect of the paravirtualized device model and only provides and receives c

[PATCH v5 08/15] hvf: arm: Ignore writes to CNTP_CTL_EL0

2024-10-29 Thread Phil Dennis-Jordan
From: Alexander Graf MacOS unconditionally disables interrupts of the physical timer on boot and then continues to use the virtual one. We don't really want to support a full physical timer emulation, so let's just ignore those writes. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jo

[PATCH v5 06/15] hw: Add vmapple subdir

2024-10-29 Thread Phil Dennis-Jordan
From: Alexander Graf We will introduce a number of devices that are specific to the vmapple target machine. To keep them all tidily together, let's put them into a single target directory. Signed-off-by: Alexander Graf Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki --- MAINTAIN

[PATCH v5 14/15] hw/block/virtio-blk: Replaces request free function with g_free

2024-10-29 Thread Phil Dennis-Jordan
The virtio_blk_free_request() function has been a 1-liner forwarding to g_free() for a while now. We may as well call g_free on the request pointer directly. Signed-off-by: Phil Dennis-Jordan Reviewed-by: Akihiko Odaki --- hw/block/virtio-blk.c | 43 +++---

[PATCH v5 04/15] hw/display/apple-gfx: Adds configurable mode list

2024-10-29 Thread Phil Dennis-Jordan
This change adds a property 'display_modes' on the graphics device which permits specifying a list of display modes. (screen resolution and refresh rate) The property is an array of a custom type to make the syntax slightly less awkward to use, for example: -device '{"driver":"apple-gfx-pci", "di

[PATCH v5 07/15] hw/misc/pvpanic: Add MMIO interface

2024-10-29 Thread Phil Dennis-Jordan
From: Alexander Graf In addition to the ISA and PCI variants of pvpanic, let's add an MMIO platform device that we can use in embedded arm environments. Signed-off-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Signed-off-by: Phil Dennis-Jordan Revie

[PATCH v5 00/15] macOS PV Graphics and new vmapple machine type

2024-10-29 Thread Phil Dennis-Jordan
This patch set introduces a new ARM and macOS HVF specific machine type called "vmapple", as well as a family of display devices based on the ParavirtualizedGraphics.framework in macOS. One of the display adapter variants, apple-gfx-mmio, is required for the new machine type, while apple-gfx-pci ca

[PATCH v5 09/15] gpex: Allow more than 4 legacy IRQs

2024-10-29 Thread Phil Dennis-Jordan
From: Alexander Graf Some boards such as vmapple don't do real legacy PCI IRQ swizzling. Instead, they just keep allocating more board IRQ lines for each new legacy IRQ. Let's support that mode by giving instantiators a new "nr_irqs" property they can use to support more than 4 legacy IRQ lines.

[PATCH v5 01/15] ui & main loop: Redesign of system-specific main thread event handling

2024-10-29 Thread Phil Dennis-Jordan
macOS's Cocoa event handling must be done on the initial (main) thread of the process. Furthermore, if library or application code uses libdispatch, the main dispatch queue must be handling events on the main thread as well. So far, this has affected Qemu in both the Cocoa and SDL UIs, although in

[PATCH v5 03/15] hw/display/apple-gfx: Adds PCI implementation

2024-10-29 Thread Phil Dennis-Jordan
This change wires up the PCI variant of the paravirtualised graphics device, mainly useful for x86-64 macOS guests, implemented by macOS's ParavirtualizedGraphics.framework. It builds on code shared with the vmapple/mmio variant of the PVG device. Signed-off-by: Phil Dennis-Jordan --- v4: * Th

Re: [PATCH] target/hppa: Add CPU reset method

2024-10-29 Thread Helge Deller
On 10/29/24 13:44, Peter Maydell wrote: On Fri, 25 Oct 2024 at 19:25, Helge Deller wrote: Add the missing CPU reset method, which resets all CPU registers and the TLB to zero. Then the CPU will switch to 32-bit mode (PSW_W bit is not set) and start execution at address 0xf004. Signed-off-

Re: [PATCH v3 0/8] Migration: Make misc.h helpers available for whole VM lifecycle

2024-10-29 Thread Peter Xu
On Thu, Oct 24, 2024 at 05:30:48PM -0400, Peter Xu wrote: > Based-on: <20241024165627.1372621-1-pet...@redhat.com> > CI: https://gitlab.com/peterx/qemu/-/pipelines/1511349805 > > This is a follow up of below patch from Avihai as a replacement: > > https://lore.kernel.org/qemu-devel/20241020

Re: [PATCH v8 0/6] AWS Nitro Enclave emulation support

2024-10-29 Thread Dorjoy Chowdhury
Hi Paolo, On Wed, Oct 30, 2024 at 1:32 AM Paolo Bonzini wrote: > > On 10/23/24 16:27, Dorjoy Chowdhury wrote: > > On Wed, Oct 16, 2024 at 7:58 PM Dorjoy Chowdhury > > wrote: > >> > >> Ping > >> > >> This patch series has been reviewed by Alex. I am not sure if it needs > >> more review. If not,

Re: [PATCH] tests/tcg: Do not use inttypes.h in multiarch/system/memory.c

2024-10-29 Thread Ilya Leoshkevich
On Thu, 2024-10-10 at 11:20 +0200, Paolo Bonzini wrote: > On 10/10/24 10:58, Ilya Leoshkevich wrote: > > make check-tcg fails on Fedora with the following error message: > > > > alpha-linux-gnu-gcc [...] > > qemu/tests/tcg/multiarch/system/memory.c -o memory [...] > > qemu/tests/tcg/mult

  1   2   3   >