16.07.2024 21:09, Philippe Mathieu-Daudé wrote:
From: Akihiko Odaki <akihiko.od...@daynix.com>
Remove dpy_cursor_define_supported() as it brings no benefit today and
it has a few inherent problems.
All graphical displays except egl-headless support cursor composition
without DMA-BUF, and egl-headless is meant to be used in conjunction
with another graphical display, so dpy_cursor_define_supported()
always returns true and meaningless.
Even if we add a new display without cursor composition in the future,
dpy_cursor_define_supported() will be problematic as a cursor display
fix for it because some display devices like virtio-gpu cannot tell the
lack of cursor composition capability to the guest and are unable to
utilize the value the function returns. Therefore, all non-headless
graphical displays must actually implement cursor composition for
correct cursor display.
Another problem with dpy_cursor_define_supported() is that it returns
true even if only some of the display listeners support cursor
composition, which is wrong unless all display listeners that lack
cursor composition is headless.
Apparently this commit made windows10 guest to freeze. There's a rather
hairy bugreport at https://bugs.debian.org/1084199 . Also there's an
interesting bug filed against qemu,
https://gitlab.com/qemu-project/qemu/-/issues/1628 ,
which seems to be relevant.
Can you take a look please?
This user did a great job bisecting qemu with no experience whatsoever..
Thanks,
/mjt
