Hi Paolo,
On Wed, Oct 30, 2024 at 1:32 AM Paolo Bonzini <pbonz...@redhat.com> wrote:
>
> On 10/23/24 16:27, Dorjoy Chowdhury wrote:
> > On Wed, Oct 16, 2024 at 7:58 PM Dorjoy Chowdhury <dorjoychy...@gmail.com>
> > wrote:
> >>
> >> Ping
> >>
> >> This patch series has been reviewed by Alex. I am not sure if it needs
> >> more review. If not, maybe this can be picked up for merging. Thanks!
> >>
> >
> > Gentle ping.
> >
> > This patch series has been reviewed by Alex and there hasn't been any
> > more reviews. it would be great if this could be picked up for
> > merging. Thanks!
>
> Hi,
>
> sorry about the delay -- the patches failed CI and I didn't have much
> time to investigate until now.
>
> The issues are basically:
>
> 1) some rST syntax errors
>
> 2) failures on non-Linux due to lack of VHOST_USER
>
> 3) failures on 32-bit due to uint64_t/long mismatch.
>
>
> While fixing (2) I also moved the dependency on libcbor and gnutls from
> meson to Kconfig, and added --enable-libcbor to configure. I also split
> hw/core/eif.c to a separate symbol, just to simplify reproducing the
> 32-bit failure on the right commit.
>
> And finally, VIRTIO_NSM should default to no (the nitro-enclave machne
> takes care of selecting it).
>
> No big deal; it's easier done than described. See attached patch for
> the differences.
>
Thanks for fixing. The attached patch looks great to me. I just have
one suggestion. Now that the CONFIG_* symbols have the dependencies
listed explicitly in the Kconfig files, maybe we don't need the
explicit dependencies in the meson.build files? For example, the
following line in hw/core/meson.build file:
system_ss.add(when: 'CONFIG_EIF', if_true: [files('eif.c'), zlib,
libcbor, gnutls])
can be changed to:
system_ss.add(when: 'CONFIG_EIF', if_true: [files('eif.c')])
I am not sure if zlib is a required dependency for QEMU, probably not
needed to be listed above as well. I am just guessing.
Same goes for files added in hw/virtio/meson.build.
Thanks!
Regards,
Dorjoy
