Re: [PATCH v1 2/4] accel/kvm: Keep track of the HWPoisonPage page_size

2024-10-23 Thread David Hildenbrand
On 22.10.24 23:35, “William Roche wrote: From: William Roche Add the page size information to the hwpoison_page_list elements. As the kernel doesn't always report the actual poisoned page size, we adjust this size from the backend real page size. We take into account the recorded page size to a

Re: [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing

2024-10-23 Thread Akihiko Odaki
On 2024/10/22 21:44, Dmitry Osipenko wrote: On 10/22/24 15:37, Dmitry Osipenko wrote: On 10/22/24 08:11, Akihiko Odaki wrote: On 2024/10/19 6:31, Dmitry Osipenko wrote: On 10/18/24 08:28, Akihiko Odaki wrote: +static void virgl_write_context_fence(void *opaque, uint32_t ctx_id, + 

[PATCH v4] intel_iommu: Introduce property "stale-tm" to control Transient Mapping (TM) field

2024-10-23 Thread Zhenzhong Duan
VT-d spec removed Transient Mapping (TM) field from second-level page-tables and treat the field as Reserved(0) since revision 3.2. Changing the field as reserved(0) will break backward compatibility, so introduce a property "stale-tm" to allow user to control the setting. Use hw_compat_9_1 to ha

Re: [PATCH v1 3/4] system/physmem: Largepage punch hole before reset of memory pages

2024-10-23 Thread David Hildenbrand
On 22.10.24 23:35, “William Roche wrote: From: William Roche When the VM reboots, a memory reset is performed calling qemu_ram_remap() on all hwpoisoned pages. While we take into account the recorded page sizes to repair the memory locations, a large page also needs to punch a hole in the backe

[PATCH] scripts: remove erroneous file that breaks git clone on Windows

2024-10-23 Thread Pierrick Bouvier
This file was created by mistake in recent ed7667188 (9p: remove 'proxy' filesystem backend driver). When cloning the repository using native git for windows, we see this: Error: error: invalid path 'scripts/meson-buildoptions.' Error: The process 'C:\Program Files\Git\bin\git.exe' failed with exi

Re: [PATCH v2 18/20] meson: build contrib/plugins with meson

2024-10-23 Thread Pierrick Bouvier
On 10/22/24 03:56, Alex Bennée wrote: From: Pierrick Bouvier Tried to unify this meson.build with tests/tcg/plugins/meson.build but the resulting modules are not output in the right directory. Originally proposed by Anton Kochkov, thank you! Solves: https://gitlab.com/qemu-project/qemu/-/issu

Re: [PATCH] virtio-net: Add queues before loading them

2024-10-23 Thread Michael S. Tsirkin
On Tue, Oct 22, 2024 at 03:49:01PM +0900, Akihiko Odaki wrote: > Call virtio_net_set_multiqueue() to add queues before loading their > states. Otherwise the loaded queues will not have handlers and elements > in them will not be processed. > > Cc: qemu-sta...@nongnu.org > Fixes: 8c49756825da ("vir

Re: [PATCH] scripts: remove erroneous file that breaks git clone on Windows

2024-10-23 Thread Daniel P . Berrangé
On Wed, Oct 23, 2024 at 12:39:14AM -0700, Pierrick Bouvier wrote: > This file was created by mistake in recent ed7667188 (9p: remove > 'proxy' filesystem backend driver). > > When cloning the repository using native git for windows, we see this: > Error: error: invalid path 'scripts/meson-buildopt

Re: [PULL 08/17] crypto/hash: Implement and use new hash API

2024-10-23 Thread Daniel P . Berrangé
On Tue, Oct 22, 2024 at 09:10:50PM +0200, Thomas Huth wrote: > On 10/10/2024 18.20, Daniel P. Berrangé wrote: > > From: Alejandro Zeise > > > > Changes the public hash API implementation to support accumulative hashing. > > > > Implementations for the public functions are added to call the new >

Re: [PATCH 1/2] migration: Make all helpers in misc.h safe to use without migration

2024-10-23 Thread Avihai Horon
On 22/10/2024 19:07, Peter Xu wrote: External email: Use caution opening links or attachments Migration object can be freed before some other device codes run, while we do have a bunch of migration helpers exported in migration/misc.h that logically can be invoked at any time of QEMU, even du

Re: [PATCH v5 0/3] Upgrade ACPI SPCR table to support SPCR table revision 4 format

2024-10-23 Thread Michael S. Tsirkin
On Wed, Aug 28, 2024 at 06:59:17PM -0700, Sia Jee Heng wrote: > Update the SPCR table to accommodate the SPCR Table revision 4 [1]. > The SPCR table has been modified to adhere to the revision 4 format [2]. Reviewed-by: Michael S. Tsirkin Pls take through the arm tree. > Meanwhile, the virt SP

RE: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-23 Thread Jamin Lin
Hi Joel and Cedric > Subject: Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing > > On 10/23/24 08:52, Joel Stanley wrote: > > On Wed, 23 Oct 2024 at 02:35, Cédric Le Goater wrote: > >> > >> On 10/22/24 13:54, Joel Stanley wrote: > >>> On Wed, 16 Oct 2024 at 01:23, Jamin Lin > wro

Re: [QEMU PATCH v8] xen/passthrough: use gsi to map pirq when dom0 is PVH

2024-10-23 Thread Chen, Jiqian
On 2024/10/23 07:07, Marek Marczykowski-Górecki wrote: > On Wed, Oct 16, 2024 at 02:28:27PM +0800, Jiqian Chen wrote: >> --- a/hw/xen/xen_pt.h >> +++ b/hw/xen/xen_pt.h >> @@ -36,6 +36,7 @@ void xen_pt_log(const PCIDevice *d, const char *f, ...) >> G_GNUC_PRINTF(2, 3); >> # define XEN_PT_LOG_CONF

Re: [PATCH 36/36] next-cube: replace boiler-plate GPL 2.0 or later license text with SPDX identifier

2024-10-23 Thread Daniel P . Berrangé
On Wed, Oct 23, 2024 at 09:58:52AM +0100, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland > --- > hw/m68k/next-cube.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c > index eefb372dca..c961d5fef6 100644 > --- a/hw/

Re: [PATCH v2 07/20] tests/tcg/x86_64: Add cross-modifying code test

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > On 10/22/24 17:16, Ilya Leoshkevich wrote: >> On Tue, 2024-10-22 at 13:36 -0700, Pierrick Bouvier wrote: >>> On 10/22/24 03:56, Alex Bennée wrote: From: Ilya Leoshkevich commit f025692c992c ("accel/tcg: Clear PAGE_WRITE before translation") fix

[PATCH 34/36] next-cube: rename old_scr2 and scr2_2 in next_scr2_rtc_update()

2024-10-23 Thread Mark Cave-Ayland
Rename them to old_scr2_rtc and scr2_rtc to reflect that they contain the previous and current values of the SCR2 RTC bits. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/ne

[PATCH 20/36] next-cube: rename typedef struct NextRtc to NeXTRTC

2024-10-23 Thread Mark Cave-Ayland
This brings the capitalisation in line with the other NeXTCube definitions. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index c44a1c6f0c..33297f01b

[PATCH 32/36] next-cube: add rtc-power-out named gpio to reset the rtc state machine

2024-10-23 Thread Mark Cave-Ayland
This allows us to decouple the next-pc and next-rtc devices from each other in next_rtc_data_in_irq(). Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 16b16e9956

[PATCH 08/36] next-cube: introduce next-scsi device

2024-10-23 Thread Mark Cave-Ayland
This device is intended to hold the ESP SCSI controller and the NeXT SCSI CSRs. Start by creating the device and moving the ESP SCSI controller to be an embedded child device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 93 - 1 file chang

[PATCH 30/36] next-cube: use named gpio output for next-rtc data

2024-10-23 Thread Mark Cave-Ayland
Add a named gpio output for the next-rtc data and then update next_rtc_data_in_irq() to drive the IRQ directly. This enables the next-rtc to next-pc data to be wired up using the standard qdev gpio APIs. At the same time rename the pc-rtc-data-in gpio to rtc-data-in which is possible now that the

[PATCH 36/36] next-cube: replace boiler-plate GPL 2.0 or later license text with SPDX identifier

2024-10-23 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index eefb372dca..c961d5fef6 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -4,10 +4,7 @@ * Copyright (c) 2011

[PATCH 33/36] next-cube: move next_rtc_cmd_is_write() and next_rtc_data_in_irq() functions

2024-10-23 Thread Mark Cave-Ayland
Move these functions in next-cube.c so that they are with the rest of the next-rtc functions. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 172 ++-- 1 file changed, 86 insertions(+), 86 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/

[PATCH 19/36] next-cube: convert next-pc device to use Resettable interface

2024-10-23 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 9829f49387..c44a1c6f0c 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -1009,9 +1009,9 @@ static const M

[PATCH 10/36] next-cube: move SCSI 4020 logic from next-pc device to next-scsi device

2024-10-23 Thread Mark Cave-Ayland
The SCSI 4020 logic refers to the offset of the SCSI CSRs within the NeXTCube address space. Due to the previously overlapping memory regions, there were duplicate MMIO accessors in the next.scr memory region for these registers but now this has been resolved. This allows us to move the more comple

[PATCH 18/36] next-cube: rearrange NeXTState declarations to improve readability

2024-10-23 Thread Mark Cave-Ayland
Move the NeXTState, next_dma and TYPE_NEXT_MACHINE definition to the same area at the top of next-cube.c. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 64 ++--- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/hw/m68k/next-cube.

[PATCH 28/36] next-cube: move reset of next-rtc fields from next-pc to next-rtc

2024-10-23 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 6b574d39cf..24f59480c5 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -1018,6 +1018,16 @@ s

[PATCH 26/36] next-cube: don't use rtc phase value of -1

2024-10-23 Thread Mark Cave-Ayland
The rtc phase value of -1 is directly equivalent to using a phase value of 0 so simplify the logic to use an initial rtc phase of 0. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-

[PATCH 25/36] next-cube: use named gpio to read RTC data bit in scr2

2024-10-23 Thread Mark Cave-Ayland
This is in preparation for moving NeXTRTC to its own separate device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 169 1 file changed, 92 insertions(+), 77 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 2a2e97

[PATCH 23/36] next-cube: always use retval to return rtc read values

2024-10-23 Thread Mark Cave-Ayland
Instead of shifting out rtc read values from individual rtc registers, change the logic so that rtc read commands are executed when the last bit of the rtc command is received and the result stored in retval. This simplifies the rtc read logic such that the shift out logic can be consolidated for r

Re: [PATCH 1/2] vfio/helpers: Refactor vfio_region_mmap() error handling

2024-10-23 Thread Cédric Le Goater
On 10/22/24 22:08, Alex Williamson wrote: Move error handling code to the end of the function so that it can more easily be shared by new mmap failure conditions. No functional change intended. Signed-off-by: Alex Williamson Reviewed-by: Cédric Le Goater Thanks, C. --- hw/vfio/helpe

Re: [QEMU PATCH v8] xen/passthrough: use gsi to map pirq when dom0 is PVH

2024-10-23 Thread Chen, Jiqian
On 2024/10/22 04:55, Stewart Hildebrand wrote: > On 10/16/24 02:28, Jiqian Chen wrote: >> In PVH dom0, when passthrough a device to domU, QEMU code >> xen_pt_realize->xc_physdev_map_pirq wants to use gsi, but in current codes >> the gsi number is got from file /sys/bus/pci/devices//irq, that is >>

Re: [PATCH 1/2] hw/riscv: Support to load DTB after 3GB memory on 64-bit system.

2024-10-23 Thread Jim Shu
On Mon, Oct 21, 2024 at 9:42 PM Daniel Henrique Barboza wrote: > > > > On 10/21/24 1:09 AM, Jim Shu wrote: > > Larger initrd image will overlap the DTB at 3GB address. Since 64-bit > > system doesn't have 32-bit addressable issue, we just load DTB to the end > > of dram in 64-bit system. > > > > S

Re: [PATCH] arm: Kconfig: disable stellaris if Rust is enabled

2024-10-23 Thread Manos Pitsidianakis
Hello Paolo, On Tue, 22 Oct 2024 at 11:54, Paolo Bonzini wrote: > > The stellaris board requires the pl011-luminary variant of pl011, > which is not supported by the Rust implementation. > > There are at least three possibilities: 1) implement the subclass > (a bit harder in Rust since the langua

Re: [PATCH v5 02/19] pc-bios/s390-ccw: Use the libc from SLOF and remove sclp prints

2024-10-23 Thread Jared Rossi
On 10/23/24 12:51 AM, Thomas Huth wrote: On 22/10/2024 22.12, Jared Rossi wrote: On 10/22/24 1:36 PM, Thomas Huth wrote: On 20/10/2024 03.29, jro...@linux.ibm.com wrote: From: Jared Rossi We are already using the libc from SLOF for the s390-netboot.img, and this libc implementation is w

Re: [PATCH v2 01/13] meson: import rust module into a global variable

2024-10-23 Thread Manos Pitsidianakis
On Mon, 21 Oct 2024 19:35, Paolo Bonzini wrote: >Reviewed-by: Zhao Liu >Signed-off-by: Paolo Bonzini >--- > meson.build | 1 + > rust/qemu-api-macros/meson.build | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > >diff --git a/meson.build b/meson.build >index d26690ce

Re: [PATCH 26/36] next-cube: don't use rtc phase value of -1

2024-10-23 Thread BALATON Zoltan
On Wed, 23 Oct 2024, Mark Cave-Ayland wrote: The rtc phase value of -1 is directly equivalent to using a phase value of 0 so simplify the logic to use an initial rtc phase of 0. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) dif

Re: [PATCH 36/36] next-cube: replace boiler-plate GPL 2.0 or later license text with SPDX identifier

2024-10-23 Thread Mark Cave-Ayland
On 23/10/2024 10:30, Daniel P. Berrangé wrote: On Wed, Oct 23, 2024 at 09:58:52AM +0100, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index ee

[PATCH v3 3/8] ebpf: drop redundant parameter checks in static methods

2024-10-23 Thread Daniel P . Berrangé
Various static methods have checks on their parameters which were already checked immediately before the method was invoked. Drop these redundat checks to simplify the following commit which adds formal error reporting. Signed-off-by: Daniel P. Berrangé --- ebpf/ebpf_rss.c | 32 +

[PATCH v3 1/8] net: fix build when libbpf is disabled, but libxdp is enabled

2024-10-23 Thread Daniel P . Berrangé
The net/af-xdp.c code is enabled when the libxdp library is present, however, it also has direct API calls to bpf_xdp_query_id & bpf_xdp_detach which are provided by the libbpf library. As a result if building with --disable-libbpf, but libxdp gets auto-detected, we'll fail to link QEMU /usr/bi

[PATCH v3 2/8] hw/net: fix typo s/epbf/ebpf/ in virtio-net

2024-10-23 Thread Daniel P . Berrangé
Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- hw/net/virtio-net.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index fb84d142ee..7c050246ea 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio

[PATCH v3 4/8] ebpf: improve error trace events

2024-10-23 Thread Daniel P . Berrangé
A design pattern of trace_foo_error("descriptive string") is undesirable because it does not allow for filtering trace events based on the error scenario. Split eBPF error trace event into three separate events to address this filtering need. Signed-off-by: Daniel P. Berrangé --- ebpf/ebpf_

[PATCH v3 5/8] ebpf: add formal error reporting to all APIs

2024-10-23 Thread Daniel P . Berrangé
The eBPF code is currently reporting error messages through trace events. Trace events are fine for debugging, but they are not to be considered the primary error reporting mechanism, as their output is inaccessible to callers. This adds an "Error **errp" parameter to all methods which have import

[PATCH v3 7/8] ebpf: improve trace event coverage to all key operations

2024-10-23 Thread Daniel P . Berrangé
The existing error trace event is renamed to have a name prefix matching its source file & to remove the redundant first arg that adds no useful information. Signed-off-by: Daniel P. Berrangé --- ebpf/ebpf_rss.c | 19 +++ ebpf/trace-events | 4 2 files changed, 23 inserti

Re: [PATCH v2 4/7] ebpf: add formal error reporting to all APIs

2024-10-23 Thread Daniel P . Berrangé
On Wed, Oct 23, 2024 at 11:55:42AM +0800, Jason Wang wrote: > On Fri, Sep 6, 2024 at 2:13 AM Daniel P. Berrangé wrote: > > > > The eBPF code is currently reporting error messages through trace > > events. Trace events are fine for debugging, but they are not to be > > considered the primary error

[PATCH 31/36] next-cube: add rtc-cmd-reset named gpio to reset the rtc state machine

2024-10-23 Thread Mark Cave-Ayland
This allows us to decouple the next-pc and next-rtc devices from each other in next_scr2_rtc_update(). Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c in

Re: [PATCH v2 18/20] meson: build contrib/plugins with meson

2024-10-23 Thread Alex Bennée
Pierrick Bouvier writes: > On 10/22/24 03:56, Alex Bennée wrote: >> From: Pierrick Bouvier >> Tried to unify this meson.build with tests/tcg/plugins/meson.build >> but >> the resulting modules are not output in the right directory. >> Originally proposed by Anton Kochkov, thank you! >> Solves: h

[PATCH 06/36] next-cube: move next_scsi_init() to next_pc_realize()

2024-10-23 Thread Mark Cave-Ayland
This reflects that the SCSI interface exists within the NeXT Peripheral Controller (PC). Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 9e457fdf12..0c3f8780a1 100644

[PATCH 35/36] next-cube: add my copyright to the top of the file

2024-10-23 Thread Mark Cave-Ayland
This series has involved rewriting and/or updating a considerable part of the next-cube emulation so update the copyright in next-cube.c to reflect this. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next

[PATCH 16/36] next-cube: add empty slots for unknown accesses to next.scr memory region

2024-10-23 Thread Mark Cave-Ayland
The next.scr memory is now effectively unused, however there are 3 separate region accesses still logged that occur when booting a NeXTStep disk image. Use the empty_slot device to capture and ignore memory accesses to these 3 memory regions. Signed-off-by: Mark Cave-Ayland --- hw/m68k/Kconfig

[PATCH v3 6/8] hw/net: report errors from failing to use eBPF RSS FDs

2024-10-23 Thread Daniel P . Berrangé
If the user/mgmt app passed in a set of pre-opened FDs for eBPF RSS, then it is expecting QEMU to use them. Any failure to do so must be considered a fatal error and propagated back up the stack, otherwise deployment mistakes will not be detectable in a prompt manner. When not using pre-opened FDs,

[PATCH v3 8/8] hw/net: improve tracing of eBPF RSS setup

2024-10-23 Thread Daniel P . Berrangé
This adds more trace events to key eBPF RSS setup operations, and also distinguishes events from multiple NIC instances. Signed-off-by: Daniel P. Berrangé --- hw/net/trace-events | 8 +--- hw/net/virtio-net.c | 9 ++--- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/n

[PATCH v3 0/8] Report fatal errors from failure with pre-opened eBPF RSS FDs

2024-10-23 Thread Daniel P . Berrangé
The virtio-net code for eBPF RSS is still ignoring errors when failing to load the eBPF RSS program passed in by the mgmt app via pre-opened FDs. This series re-factors the eBPF common code so that it actually reports using "Error" objects. Then it makes virtio-net treat a failure to load pre-open

[PATCH 00/36] next-cube: more tidy-ups and improvements

2024-10-23 Thread Mark Cave-Ayland
This series contains a number of tidy-ups and improvements to the NeXTCube machine which include: - Bringing the code up-to-date with our latest coding standards/APIs, in particular related to the board configuration and IRQ wiring - Remove the remaining overlapping memory regions and c

[PATCH 03/36] next-cube: remove overlap between next.dma and next.mmio memory regions

2024-10-23 Thread Mark Cave-Ayland
Change the start of the next.mmio memory region so that it follows on directly after the next.dma memory region, adjusting the address offsets in next_mmio_read() and next_mmio_write() accordingly. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 28 ++-- 1 file

[PATCH 13/36] next-cube: move ESCC to be QOM child of next-pc device

2024-10-23 Thread Mark Cave-Ayland
Since the ESCC is part of the next-pc device, move the ESCC to be a QOM child of the next-pc device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 54 ++--- 1 file changed, 26 insertions(+), 28 deletions(-) diff --git a/hw/m68k/next-cube.c b/h

[PATCH 04/36] next-cube: remove cpu parameter from next_scsi_init()

2024-10-23 Thread Mark Cave-Ayland
The parameter is not used. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index e1d94c1ce0..6bdd91c9c6 100644 --- a/hw/m68k/next-cube.c +++ b/hw/m68k/next-cube.c @@ -824,7 +

[PATCH 15/36] next-cube: move en ethernet MMIO to separate memory region on next-pc device

2024-10-23 Thread Mark Cave-Ayland
Move the en ethernet MMIO accesses to a separate memory region on the next-pc device instead of being part of the next.scr MMIO memory region. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 48 + 1 file changed, 40 insertions(+), 8 deletions

[PATCH 17/36] next-cube: remove unused next.scr memory region

2024-10-23 Thread Mark Cave-Ayland
Now that the next.scr memory region is unused it can be removed and the next-pc devices mapped directly within the machine init function. This is the last remaining overlapping memory region within the NeXTCube machine. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 73 +++

[PATCH 05/36] next-cube: create new next.scsi container memory region

2024-10-23 Thread Mark Cave-Ayland
Move the ESP SCSI and SCSI CSR registers to the new next.scsi container memory region. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 6bdd91c9c6..9e457fdf12 100644

[PATCH 01/36] next-cube: fix up compilation when DEBUG_NEXT is enabled

2024-10-23 Thread Mark Cave-Ayland
These were accidentally introduced by my last series. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index 9832213e7e..7a503e0707 100644 --- a/hw/m68k/next-cube.c +++

[PATCH 12/36] next-cube: map ESCC registers as a subregion of the next.scr memory region

2024-10-23 Thread Mark Cave-Ayland
Since the ESCC device exists within the memory range of the next.scr memory region, map the ESCC device registers as a subregion of the next.scr memory region instead of directly to the system address space. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 - 1 file changed, 4 i

[PATCH 02/36] next-cube: remove 0x14020 dummy value from next_mmio_read()

2024-10-23 Thread Mark Cave-Ayland
This is a dummy value for the SCSI CSR which appears to have no effect when removed. Eventually the reads/writes to this register will be directed towards the WIP implementations in next_scr_readfn() and next_scr_writefn(). Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 4 1 file

[PATCH 07/36] next-cube: introduce next_pc_init() object init function

2024-10-23 Thread Mark Cave-Ayland
Move initialisation of the memory regions and GPIOs from next_pc_realize() to the new next_pc_init() function. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c

[PATCH 14/36] next-cube: move timer MMIO to separate memory region on next-pc device

2024-10-23 Thread Mark Cave-Ayland
Move the timer MMIO accesses to a separate memory region on the next-pc device instead of being part of the next.scr MMIO memory region. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 63 +++-- 1 file changed, 50 insertions(+), 13 deletions(-)

[PATCH 24/36] next-cube: use named gpio to set RTC data bit in scr2

2024-10-23 Thread Mark Cave-Ayland
This is in preparation for moving NeXTRTC to its own separate device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 25 + 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-cube.c index bca975065f..2a2e970830 1006

[PATCH 11/36] next-cube: move floppy disk MMIO to separate memory region in next-pc

2024-10-23 Thread Mark Cave-Ayland
The dummy floppy disk device is part of the next-pc device, and not related to the NeXTCube SCRs. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 61 - 1 file changed, 49 insertions(+), 12 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m

[PATCH 09/36] next-cube: move SCSI CSRs from next-pc to the next-scsi device

2024-10-23 Thread Mark Cave-Ayland
The SCSI CSRs are located within the SCSI subsystem of the NeXT PC (Peripheral Contoller) which is now modelled as a separate QEMU device. Add a new VMStateDescription for the next-scsi device to enable the SCSI CSRs to be migrated. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 88 +

[PATCH 29/36] next-cube: move rtc-data-in gpio from next-pc to next-rtc device

2024-10-23 Thread Mark Cave-Ayland
Add a new rtc-data-out gpio to the next-pc device and wire it up to the next-rtc rtc-data-in gpio using the standard qdev gpio APIs. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/hw/m68k/nex

[PATCH 22/36] next-cube: separate rtc read and write shift logic

2024-10-23 Thread Mark Cave-Ayland
Introduce a new next_rtc_cmd_is_write() function to determine if an rtc command is a read or write, and start by using it to avoid shifting the rtc input value if a rtc read command is executed. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 138 ---

[PATCH 21/36] next-cube: use qemu_irq to drive int_status in next_scr2_rtc_update()

2024-10-23 Thread Mark Cave-Ayland
Rather than directly clear bit 3 in int_status in next_scr2_rtc_update(), use a qemu_irq to drive the equivalent NEXT_PWR_I signal. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-c

[PATCH 27/36] next-cube: QOMify NeXTRTC

2024-10-23 Thread Mark Cave-Ayland
This is to allow the RTC functionality to be maintained within its own separate device. Signed-off-by: Mark Cave-Ayland --- hw/m68k/next-cube.c | 66 - 1 file changed, 48 insertions(+), 18 deletions(-) diff --git a/hw/m68k/next-cube.c b/hw/m68k/next-c

Re: [PATCH v2 5/6] virtio-gpu: Support asynchronous fencing

2024-10-23 Thread Akihiko Odaki
On 2024/10/15 13:32, Dmitry Osipenko wrote: Support asynchronous fencing feature of virglrenderer. It allows Qemu to handle fence as soon as it's signalled instead of periodically polling the fence status. This feature is required for enabling DRM context support in Qemu because legacy fencing mo

Re: [PATCH 1/3] vfio/migration: Report only stop-copy size in vfio_state_pending_exact()

2024-10-23 Thread Cédric Le Goater
On 10/20/24 15:01, Avihai Horon wrote: vfio_state_pending_exact() is used to update migration core how much device data is left for the device migration. Currently, the sum of pre-copy and stop-copy sizes of the VFIO device are reported. The pre-copy size is obtained via the VFIO_MIG_GET_PRECOPY

Re: [PATCH 2/2] hw/riscv: Support different address-cells for initrd

2024-10-23 Thread Jim Shu
Compare Linux code to handle "linux,initrd-start" [1] and "linux,usable-memory-range" [2], I think the initrd code doesn't check root #address-cells. Using the origin code of "u64" is okay. I can remove this commit in the next version. [1] https://elixir.bootlin.com/linux/v6.11.4/source/drivers/of

Re: [PATCH v2 05/13] rust: remove uses of #[no_mangle]

2024-10-23 Thread Paolo Bonzini
On 10/21/24 18:35, Paolo Bonzini wrote: @@ -566,7 +563,6 @@ pub fn update(&self) { /// # Safety /// /// We expect the FFI user of this function to pass a valid pointer for `chr`. -#[no_mangle] pub unsafe extern "C" fn pl011_create( addr: u64, irq: qemu_irq, This _needs_ to be

Re: [PATCH v2 09/13] rust: clean up define_property macro

2024-10-23 Thread Manos Pitsidianakis
Hello Paolo, On Mon, 21 Oct 2024 19:35, Paolo Bonzini wrote: >Use the "struct update" syntax to initialize most of the fields to zero, >and simplify the handmade type-checking of $name. Note: It wasn't meant for type checking but for making sure the linker doesn't strip the symbol (hence the #[

Re: [PATCH v6] hw/misc/aspeed_hace: Fix SG Accumulative hashing

2024-10-23 Thread Cédric Le Goater
On 10/23/24 08:52, Joel Stanley wrote: On Wed, 23 Oct 2024 at 02:35, Cédric Le Goater wrote: On 10/22/24 13:54, Joel Stanley wrote: On Wed, 16 Oct 2024 at 01:23, Jamin Lin wrote: 3. Test HACE model with u-boot hash command a. load test file to address 8300 via tftp ast# tftp 8300 j

Re: [PATCH v2 10/13] qdev: make properties array "const"

2024-10-23 Thread Paolo Bonzini
Il mar 22 ott 2024, 23:43 Philippe Mathieu-Daudé ha scritto: > On 22/10/24 02:23, Paolo Bonzini wrote: > > At least keeping the const > > within qdev properties makes things "safer" within that realm. > > Since it is only within qdev-properties.c, it is indeed reasonable to > accept. Maybe make i

Re: [PATCH v2 09/13] rust: clean up define_property macro

2024-10-23 Thread Paolo Bonzini
Il mar 22 ott 2024, 21:46 Kevin Wolf ha scritto: > > info: $prop, > > offset: ::core::mem::offset_of!($state, $field) > > .try_into() > > .expect("Could not fit offset value to type"), > > -bitnr: 0, > > -bitmask:

[PATCH 0/3] hw/loongarch/virt: Add cpu hotplug support

2024-10-23 Thread Bibo Mao
LoongArch cpu hotplug is based on ACPI GED device, there is a little change about ipi device, the value of num-cpu property is maximum cpu number rather than present cpu number. It can be verified with qemu command: qemu-system-loongarch64 -smp 2,maxcpus=16,sockets=4,cores=4,threads=1 and vcpu c

[PATCH 3/3] hw/loongarch/virt: Update the ACPI table for hotplug cpu

2024-10-23 Thread Bibo Mao
On LoongArch virt machine, ACPI GED hardware is used for cpu hotplug, here cpu hotplug support feature is added on GED device, also cpu scan and reject method is added about CPU device in DSDT table. Co-developed-by: Xianglai Li Signed-off-by: Bibo Mao --- hw/loongarch/acpi-build.c | 35 +

[PATCH 2/3] hw/loongarch/virt: Add basic CPU plug support

2024-10-23 Thread Bibo Mao
Implement interface for cpu hotplug function, and enable cpu hotplug feature on virt machine. Co-developed-by: Xianglai Li Signed-off-by: Bibo Mao --- hw/loongarch/Kconfig| 1 + hw/loongarch/virt.c | 191 +++- include/hw/loongarch/virt.h | 2 +

[PATCH 1/3] hw/loongarch/virt: Add CPU topology support

2024-10-23 Thread Bibo Mao
Add topological relationships for Loongarch VCPU and initialize topology member variables. Also physical cpu id calculation method comes from its topo information. Co-developed-by: Xianglai Li Signed-off-by: Bibo Mao --- docs/system/loongarch/virt.rst | 31 + hw/loongarch/virt.c

Re: [PATCH v2 00/13] rust: miscellaneous cleanups + QOM integration tests

2024-10-23 Thread Paolo Bonzini
Il mar 22 ott 2024, 22:46 Kevin Wolf ha scritto: > Am 21.10.2024 um 18:35 hat Paolo Bonzini geschrieben: > > This series integrates some of the observations from the MSRV patches at > > > https://lore.kernel.org/qemu-devel/20241015131735.518771-1-pbonz...@redhat.com/ > . > > > > The main changes

Re: [PATCH v2 08/13] rust: cleanup module_init!, use it from #[derive(Object)]

2024-10-23 Thread Junjie Mao
Kevin Wolf writes: > Am 22.10.2024 um 08:00 hat Junjie Mao geschrieben: >> >> Paolo Bonzini writes: >> >> > On Tue, Oct 22, 2024 at 4:12 AM Junjie Mao wrote: >> >> > +($type:ident => $body:block) => { >> >> > +const _: () = { >> >> > +#[used] >> >> > +#[cfg

[PATCH] tests/vm/openbsd: Remove the "Time appears wrong" workaround

2024-10-23 Thread Thomas Huth
Seems like the server now reports the right time again, so we have to drop the workaround to get the installer working again. Signed-off-by: Thomas Huth --- tests/vm/openbsd | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index dfd11c93f0..5e4f76f398 100755

[PATCH] tests/vm/openbsd: Remove the "Time appears wrong" workaround

2024-10-23 Thread Thomas Huth
Seems like the server now reports the right time again, so we have to drop the workaround to get the installer working again. Signed-off-by: Thomas Huth --- tests/vm/openbsd | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/vm/openbsd b/tests/vm/openbsd index dfd11c93f0..5e4f76f398 100755

Re: [PATCH v2 09/13] rust: clean up define_property macro

2024-10-23 Thread Paolo Bonzini
On 10/23/24 12:38, Manos Pitsidianakis wrote: Hello Paolo, On Mon, 21 Oct 2024 19:35, Paolo Bonzini wrote: Use the "struct update" syntax to initialize most of the fields to zero, and simplify the handmade type-checking of $name. Note: It wasn't meant for type checking but for making sure th

[PATCH v3 01/18] tests/docker: Fix microblaze atomics

2024-10-23 Thread Alex Bennée
From: Ilya Leoshkevich GCC produces invalid code for microblaze atomics. The fix is unfortunately not upstream, so fetch it from an external location and apply it locally. Suggested-by: Peter Maydell Signed-off-by: Ilya Leoshkevich Reviewed-by: Pierrick Bouvier Message-Id: <20241022105614.83

[PATCH v3 08/18] accel/tcg: add tracepoints for cpu_loop_exit_atomic

2024-10-23 Thread Alex Bennée
We try to avoid using cpu_loop_exit_atomic as it brings in an all-core sync point. However on some cpu/kernel/benchmark combinations it is starting to show up in the performance profile. To make it easier to see whats going on add tracepoints for the slow path so we can see what is triggering the w

[PATCH v3 05/18] docs/devel: update tsan build documentation

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier Mention it's now possible to build with gcc, instead of clang, and explain how to build a sanitized glib version. Signed-off-by: Pierrick Bouvier Reviewed-by: Thomas Huth Message-Id: <20240910174013.141-4-pierrick.bouv...@linaro.org> Signed-off-by: Alex Bennée ---

[PATCH v3 02/18] tests/docker: add NOFETCH env variable for testing

2024-10-23 Thread Alex Bennée
Testing non-auto built docker containers (i.e. custom built compilers) is a bit fiddly as you couldn't continue a build with a previously locally built container. While you can play games with REGISTRY its simpler to allow a NOFETCH that will go through the cached build process when you run the tes

[PATCH v3 10/18] gitlab: make check-[dco|patch] a little more verbose

2024-10-23 Thread Alex Bennée
When git fails the rather terse backtrace only indicates it failed without some useful context. Add some to make the log a little more useful. Signed-off-by: Alex Bennée --- v2 - keep check_call, just don't redirect stdout/err --- .gitlab-ci.d/check-dco.py | 5 ++--- .gitlab-ci.d/check-patc

[PATCH v3 13/18] tests/tcg: enable basic testing for aarch64_be-linux-user

2024-10-23 Thread Alex Bennée
We didn't notice breakage of aarch64_be because we don't have any TCG tests for it. However while the existing aarch64 compiler can target big-endian builds no one packages a BE libc. Instead we bang some rocks together to do the most basic of hello world with a nostdlib syscall test. Message-Id:

[PATCH v3 14/18] tests/tcg/aarch64: Use raw strings for regexes in test-mte.py

2024-10-23 Thread Alex Bennée
From: Gustavo Romero Use Python's raw string notation instead of string literals for regex so it's not necessary to double backslashes when regex special forms are used. Raw notation is preferred for regex and easier to read. Signed-off-by: Gustavo Romero Reviewed-by: Philippe Mathieu-Daudé Me

[PATCH v3 03/18] MAINTAINERS: mention my testing/next tree

2024-10-23 Thread Alex Bennée
I put it under my name as there may be other maintainer testing trees as well. Message-Id: <20241022105614.839199-4-alex.ben...@linaro.org> Reviewed-by: Thomas Huth Signed-off-by: Alex Bennée --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index c3b

[PATCH v3 09/18] dockerfiles: fix default targets for debian-loongarch-cross

2024-10-23 Thread Alex Bennée
From: Pierrick Bouvier fix system target name, and remove --disable-system (which deactivates system target). Found using: make docker-test-build@debian-loongarch-cross V=1 Signed-off-by: Pierrick Bouvier Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <2024102021375

[PATCH v3 12/18] config/targets: update aarch64_be-linux-user gdb XML list

2024-10-23 Thread Alex Bennée
Attempting to run the binary asserts when it can't find the XML entry. We can fix it so we don't although I suspect other stuff is broken. Fixes: https://gitlab.com/qemu-project/qemu/-/issues/2580 Message-Id: <20241022105614.839199-13-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-o

[PATCH v3 00/18] maintainer updates (testing, gdbstub, plugins) pre-PR

2024-10-23 Thread Alex Bennée
This is an aggregation of three of my maintainer trees which you can also get from their respective branches (testing/next, gdbstub/next and plugins/next). It is now ready for a pull request. Since last post: - added r-b tags - some minor typo fixes - dropped meson plugin contrib build and

[PATCH v3 06/18] scripts/ci: remove architecture checks for build-environment updates

2024-10-23 Thread Alex Bennée
We were missing s390x here. There isn't much point testing for the architecture here as we will fail anyway if the appropriate package list is missing. Message-Id: <20241022105614.839199-7-alex.ben...@linaro.org> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Bennée --- scripts/ci/setup/ubun

  1   2   3   >