[PATCH] cxl: update kernel config requirement

2024-09-09 Thread luzhixing12345
add CXL_PMEM config dependence LIBNVIDIMM CXL_REGION config is not enabled in 5.18, and it was introduced into kernel in 6.0 by commit 779dd20c for dynamic provisioning of new memory region Signed-off-by: luzhixing12345 --- docs/system/devices/cxl.rst | 5 - 1 file changed, 4 insertions(+

Re: [PATCH v3 02/14] util: Add RISC-V vector extension probe in cpuinfo

2024-09-09 Thread LIU Zhiwei
On 2024/9/5 11:34, Richard Henderson wrote: On 9/4/24 07:27, LIU Zhiwei wrote: +    if (info & CPUINFO_ZVE64X) { +    /* + * Get vlenb for Vector: vsetvli rd, x0, e64. + * VLMAX = LMUL * VLEN / SEW. + * The "vsetvli rd, x0, e64" means "LMUL = 1, SEW = 64, rd = VLMA

Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

2024-09-09 Thread Marc-André Lureau
Hi On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin wrote: > > Windows only: > > The libSDL2 Windows message loop needs the libSDL2 Windows low > level keyboard hook procedure to grab the left and right Windows > keys correctly. Reenable the SDL2 Windows keyboard hook procedure. > > Because the QEM

Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Akihiko Odaki
On 2024/09/09 10:58, Joelle van Dyne wrote: New optional argument for 'blockdev-change-medium' QAPI command to allow the caller to specify if they wish to enable file locking. Signed-off-by: Joelle van Dyne --- qapi/block.json| 23 ++- block/monitor/block-

Re: [RFC PATCH 2/8] usb/uhci: Introduce and use register defines

2024-09-09 Thread Cédric Le Goater
On 9/6/24 14:25, Guenter Roeck wrote: Introduce defines for UHCI registers to simplify adding register access in subsequent patches of the series. No functional change. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Thanks, C. --- hw/usb/hcd-uhci.c | 32

Re: [RFC PATCH 1/8] usb/uhci: checkpatch cleanup

2024-09-09 Thread Cédric Le Goater
On 9/6/24 14:25, Guenter Roeck wrote: Fix reported checkpatch issues to prepare for next patches in the series. No functional change. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Thanks, C. --- hw/usb/hcd-uhci.c | 90 +-- 1

Re: [RFC PATCH 8/8] aspeed: Add uhci support for ast2400 and ast2500

2024-09-09 Thread Cédric Le Goater
On 9/6/24 14:25, Guenter Roeck wrote: Enable UHCI support for ast2400 and ast2500 SoCs. With this patch, the UHCI port is successfully instantiated on the ast2500-evb machine. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed_ast2400.c | 14 +

Re: [RFC PATCH 7/8] aspeed: Add uhci support for ast2600

2024-09-09 Thread Cédric Le Goater
On 9/6/24 14:25, Guenter Roeck wrote: Enable UHCO support for the ast2600 SoC. With this patch, the UHCI port is successfully instantiated on the rainier-bmc and ast2600-evb machines. Signed-off-by: Guenter Roeck Reviewed-by: Cédric Le Goater Thanks, C. --- hw/arm/aspeed_ast2600.c

Re: [PATCH 1/3] ui/sdl2: reenable the SDL2 Windows keyboard hook procedure

2024-09-09 Thread Stefan Weil via
Am 09.09.24 um 09:26 schrieb Marc-André Lureau: Hi On Mon, Sep 9, 2024 at 10:22 AM Volker Rümelin wrote: Windows only: The libSDL2 Windows message loop needs the libSDL2 Windows low level keyboard hook procedure to grab the left and right Windows keys correctly. Reenable the SDL2 Windows key

[PATCH v2] target/riscv32: Fix masking of physical address

2024-09-09 Thread Andrew Jones
C doesn't extend the sign bit for unsigned types since there isn't a sign bit to extend. This means a promotion of a u32 to a u64 results in the upper 32 bits of the u64 being zero. If that result is then used as a mask on another u64 the upper 32 bits will be cleared. rv32 physical addresses may b

Re: [PATCH 2/2] hw/riscv/virt: Introduce strict-dt

2024-09-09 Thread Andrew Jones
On Mon, Sep 09, 2024 at 12:41:24PM GMT, Alistair Francis wrote: > On Mon, Aug 19, 2024 at 5:50 PM Andrew Jones wrote: > > > > On Mon, Aug 19, 2024 at 11:19:18AM GMT, Alistair Francis wrote: > > > On Sat, Aug 17, 2024 at 2:08 AM Andrew Jones > > > wrote: > > > > > > > > Older firmwares and OS ker

RE: [PATCH v4 0/2] intel_iommu minor fixes

2024-09-09 Thread Duan, Zhenzhong
Hi Michael, Kindly ping, seems this small series missed. Thanks Zhenzhong >-Original Message- >From: Duan, Zhenzhong >Subject: [PATCH v4 0/2] intel_iommu minor fixes > >Hi > >Fixes two minor issues in intel iommu. >See patch for details. > >Tested scalable mode and legacy mode with vfi

Re: [PATCH v2 15/17] vfio/migration: Multifd device state transfer support - receive side

2024-09-09 Thread Avihai Horon
On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" The multifd received data needs to be reassembled since device state packets sent via different multifd channels can arrive out-of-order. Therefore, each VFI

Re: [PATCH 1/1] hw/intc/riscv_aplic: Check and update pending when write sourcecfg

2024-09-09 Thread Yong-Xuan Wang
Hi Alistair, On Mon, Sep 9, 2024 at 10:32 AM Alistair Francis wrote: > > On Thu, Aug 8, 2024 at 6:21 PM Yong-Xuan Wang > wrote: > > > > The section 4.5.2 of the RISC-V AIA specification says that any write > > to a sourcecfg register of an APLIC might (or might not) cause the > > corresponding

Re: qemu emulation for USB ports of Allwinner H3

2024-09-09 Thread Gerd Hoffmann
On Sun, Sep 08, 2024 at 11:36:18AM GMT, Guenter Roeck wrote: > Hi, > > the Allwinner H3 USB port qemu emulation creates separate USB ports > for its EHCI and OHCI controllers, resulting in a total of 8 USB ports. > From the orangepi-pc emulation: > > # lsusb > Bus 005 Device 001: ID 1d6b:0002 > B

Re: [PATCH] tcg/i386: Implement vector TST{EQ,NE} for avx512

2024-09-09 Thread Philippe Mathieu-Daudé
On 8/9/24 20:51, Richard Henderson wrote: Signed-off-by: Richard Henderson --- Based-on: <20240908022632.459477-1-richard.hender...@linaro.org> ("tcg: Improve support for cmpsel_vec") --- tcg/i386/tcg-target.h | 2 +- tcg/i386/tcg-target.c.inc | 31 --- 2 f

Re: [PATCH] Remove unnecessary code in the interface accel_system_init_ops_interfaces

2024-09-09 Thread Daniel Henrique Barboza
On 9/9/24 12:17 AM, Andrew.Yuan wrote: The code 'ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));' is unnecessary; And, the following code : 1.has the same functionality; 2.includes error checking; Signed-off-by: Andrew.Yuan --- accel/accel-system.c | 2 +- 1 file changed,

Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Kevin Wolf
Am 09.09.2024 um 03:58 hat Joelle van Dyne geschrieben: > New optional argument for 'blockdev-change-medium' QAPI command to allow > the caller to specify if they wish to enable file locking. > > Signed-off-by: Joelle van Dyne I feel once you need to control such details of the backend, you shou

Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Daniel Henrique Barboza
On 9/8/24 11:13 PM, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to the gue

Re: [PATCH v7 0/6] plugins: access values during a memory read/write

2024-09-09 Thread Alex Bennée
Pierrick Bouvier writes: > On 9/5/24 08:21, Alex Bennée wrote: >> Pierrick Bouvier writes: >> >>> This series allows plugins to know which value is read/written during a >>> memory >>> access. >>> >>> For every memory access, we know copy this value before calling mem >>> callbacks, >>> and t

Re: [RFC PATCH 1/2] hw/arm/sbsa-ref: Enable CXL Host Bridge by pxb-cxl

2024-09-09 Thread Marcin Juszkiewicz
On 30.08.2024 06:15, Yuquan Wang wrote: The memory layout places 1M space for 16 host bridge register regions in the sbsa-ref memmap. In addition, this creates a default pxb-cxl (bus_nr=0xfe) bridge with one cxl-rp on sbsa-ref. With this patchset applied I no longer can add pcie devices to sbsa

Re: [PATCH] Remove unnecessary code in the interface accel_system_init_ops_interfaces

2024-09-09 Thread Claudio Fontana
On 9/9/24 11:54, Daniel Henrique Barboza wrote: > > > On 9/9/24 12:17 AM, Andrew.Yuan wrote: >> The code 'ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));' is >> unnecessary; >> >> And, the following code : >> 1.has the same functionality; >> 2.includes error checking; >> >> Signed-

Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Alistair, On 9/9/24 04:13, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to

Re: [PATCH v3 2/2] hw/char: sifive_uart: Print uart characters async

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Alistair, On 9/9/24 04:13, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped characters [1]. Let's update the SiFive UART to use a async sifive_uart_xmit() function to transmit the characters and apply back pressure to

Re: [PULL 27/34] migration/multifd: Move nocomp code into multifd-nocomp.c

2024-09-09 Thread Peter Maydell
On Wed, 4 Sept 2024 at 13:48, Fabiano Rosas wrote: > > In preparation for adding new payload types to multifd, move most of > the no-compression code into multifd-nocomp.c. Let's try to keep a > semblance of layering by not mixing general multifd control flow with > the details of transmitting pag

Re: [PULL 27/34] migration/multifd: Move nocomp code into multifd-nocomp.c

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 11:28, Peter Maydell wrote: > > On Wed, 4 Sept 2024 at 13:48, Fabiano Rosas wrote: > > > > In preparation for adding new payload types to multifd, move most of > > the no-compression code into multifd-nocomp.c. Let's try to keep a > > semblance of layering by not mixing gen

Re: [PATCH] virtio-9p: remove virtfs-proxy-helper

2024-09-09 Thread Greg Kurz
On Thu, 5 Sep 2024 10:22:59 +0200 Paolo Bonzini wrote: > It has been deprecated since 8.1; remove it and suggest using permission > mapping > or virtiofsd. > > Signed-off-by: Paolo Bonzini > --- Thanks Paolo ! Acked-by: Greg Kurz > MAINTAINERS|8 - > docs/abou

Re: [PATCH v2] aspeed: Deprecate the tacoma-bmc machine

2024-09-09 Thread Joel Stanley
On Sat, 31 Aug 2024 at 05:41, Guenter Roeck wrote: > > On Fri, Aug 30, 2024 at 10:09:25AM +0200, Cédric Le Goater wrote: > > Hello, > > > > > > > > > I solved the problem by adding support for IBM Bonnell (which > > > > > instantiates > > > > > the TPM chip through its devicetree file, similar to

[PATCH v11 00/10] Support persistent reservation operations

2024-09-09 Thread Changqi Lu
Hi, Patch v11 has been modified, thanks to Klaus for the code review. v10->v11: - Before executing the pr operation, check whether it is supported. If it is not supported, return NVME_INVALID_OPCODE directly. v9->v10: - When the driver does not support the pr operation, the error code return

[PATCH v11 01/10] block: add persistent reservation in/out api

2024-09-09 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH v11 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-09-09 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

[PATCH v11 06/10] block/nvme: add reservation command protocol constants

2024-09-09 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h

[PATCH v11 03/10] scsi/constant: add persistent reservation in/out protocol constants

2024-09-09 Thread Changqi Lu
Add constants for the persistent reservation in/out protocol in the scsi/constant module. The constants include the persistent reservation command, type, and scope values defined in sections 6.13 and 6.14 of the SCSI Primary Commands-4 (SPC-4) specification. Signed-off-by: Changqi Lu Signed-off-b

[PATCH v11 02/10] block/raw: add persistent reservation in/out driver

2024-09-09 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v11 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-09-09 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: Stefan Hajnoczi --- include/scsi/utils.h | 8 +

[PATCH v11 09/10] hw/nvme: add reservation protocal command

2024-09-09 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

[PATCH v11 10/10] block/iscsi: add persistent reservation in/out driver

2024-09-09 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

[PATCH v11 07/10] hw/nvme: add helper functions for converting reservation types

2024-09-09 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the reservation types used in the NVME protocol and those used in the block layer. Reviewed-by: Klaus Jensen Reviewed-by: Stefan Hajnoczi Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/nvme.h |

[PATCH v11 08/10] hw/nvme: enable ONCS and rescap function

2024-09-09 Thread Changqi Lu
This commit enables ONCS to support the reservation function at the controller level. Also enables rescap function in the namespace by detecting the supported reservation function in the backend driver. Reviewed-by: Klaus Jensen Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi Reviewed-by: S

Re: [PATCH v2 17/17] vfio/migration: Multifd device state transfer support - send side

2024-09-09 Thread Avihai Horon
On 27/08/2024 20:54, Maciej S. Szmigiero wrote: External email: Use caution opening links or attachments From: "Maciej S. Szmigiero" Implement the multifd device state transfer via additional per-device thread inside save_live_complete_precopy_thread handler. Switch between doing the data

Re: [PATCH v4 1/2] target/loongarch: Add loongson binary translation feature

2024-09-09 Thread gaosong
在 2024/9/4 下午2:18, Bibo Mao 写道: Loongson Binary Translation (LBT) is used to accelerate binary translation, which contains 4 scratch registers (scr0 to scr3), x86/ARM eflags (eflags) and x87 fpu stack pointer (ftop). Now LBT feature is added in kvm mode, not supported in TCG mode since it is

Re: [PATCH v4 2/2] target/loongarch: Implement lbt registers save/restore function

2024-09-09 Thread gaosong
在 2024/9/4 下午2:18, Bibo Mao 写道: Six registers scr0 - scr3, eflags and ftop are added in percpu vmstate. And two functions kvm_loongarch_get_lbt/kvm_loongarch_put_lbt are added to save/restore lbt registers. Signed-off-by: Bibo Mao --- target/loongarch/cpu.h | 12 target/loong

Re: [PATCH v2] virtio: kconfig: memory devices are PCI only

2024-09-09 Thread David Hildenbrand
On 06.09.24 12:16, Paolo Bonzini wrote: Virtio memory devices rely on PCI BARs to expose the contents of memory. Because of this they cannot be used (yet) with virtio-mmio or virtio-ccw. In fact the code that is common to virtio-mem and virtio-pmem, which is in hw/virtio/virtio-md-pci.c, is only

Re: [PULL 0/3] m68k patches

2024-09-09 Thread Peter Maydell
On Sun, 8 Sept 2024 at 14:11, Thomas Huth wrote: > > Hi! > > The following changes since commit 1581a0bc928d61230ed6e43bcb83f2f6737d0bc0: > > Merge tag 'pull-ufs-20240906' of https://gitlab.com/jeuk20.kim/qemu into > staging (2024-09-06 15:27:43 +0100) > > are available in the Git repository a

Re: [PATCH v3 0/4] virtio-mem: Implement support for suspend+wake-up with plugged memory

2024-09-09 Thread David Hildenbrand
On 04.09.24 12:37, Juraj Marcin wrote: Currently, the virtio-mem device would unplug all the memory with any reset request, including when the machine wakes up from a suspended state (deep sleep). This would lead to a loss of the contents of the guest memory and therefore is disabled by the virti

Re: [RFC v3 3/3] vhost: Allocate memory for packed vring

2024-09-09 Thread Eugenio Perez Martin
On Sun, Sep 8, 2024 at 9:47 PM Sahil wrote: > > Hi, > > On Friday, August 30, 2024 4:18:31 PM GMT+5:30 Eugenio Perez Martin wrote: > > On Fri, Aug 30, 2024 at 12:20 PM Sahil wrote: > > > Hi, > > > > > > On Tuesday, August 27, 2024 9:00:36 PM GMT+5:30 Eugenio Perez Martin > > > wrote: > > > > On

Re: [PATCH v11 08/11] vfio/migration: Implement VFIO migration protocol v2

2024-09-09 Thread Avihai Horon
On 05/09/2024 21:31, Peter Xu wrote: External email: Use caution opening links or attachments On Thu, Sep 05, 2024 at 07:45:43PM +0300, Avihai Horon wrote: Does it also mean then that the currently reported stop-size - precopy-size will be very close to the constant non-iterable data size?

Re: [PATCH] hw/loongarch: Add acpi SPCR table support

2024-09-09 Thread gaosong
在 2024/9/7 下午3:30, Bibo Mao 写道: Serial port console redirection table can be used for default serial port selection, like chosen stdout-path selection with FDT method. With acpi SPCR table added, early debug console can be parsed from SPCR table with simple kernel parameter earlycon rather than

Re: [PATCH v4 2/2] target/loongarch: Implement lbt registers save/restore function

2024-09-09 Thread gaosong
在 2024/9/9 下午7:52, gaosong 写道: 在 2024/9/4 下午2:18, Bibo Mao 写道: Six registers scr0 - scr3, eflags and ftop are added in percpu vmstate. And two functions kvm_loongarch_get_lbt/kvm_loongarch_put_lbt are added to save/restore lbt registers. Signed-off-by: Bibo Mao ---   target/loongarch/cpu.h  

Re: [PATCH v2 00/15] target/cris: Remove the deprecated CRIS target

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Edgar, On 4/9/24 16:35, Philippe Mathieu-Daudé wrote: Since v1: - Split in smaller patches (pm215) The CRIS target is deprecated since v9.0 (commit c7bbef40234 "docs: mark CRIS support as deprecated"). Remove: - Buildsys / CI infra - User emulation - System emulation (axis-dev88 machine and

Re: [PATCH v2 0/5] tmp105: Improvements and fixes

2024-09-09 Thread Philippe Mathieu-Daudé
Hi Cédric, On 6/9/24 17:49, Philippe Mathieu-Daudé wrote: Respin of Guenter fixes with: - Use registerfields API - Clear OS bit in WRITE path Since our mails crossed (you reviewed v1 while I was posting v2), do you mind having another look at this v2? At least patch #4 isn't yet reviewed. Tha

Re: [PATCH v5 00/16] hw/char/pl011: Implement TX (async) FIFO to avoid blocking the main loop

2024-09-09 Thread Philippe Mathieu-Daudé
On 7/9/24 12:38, Peter Maydell wrote: On Sat, 7 Sept 2024 at 06:42, Philippe Mathieu-Daudé wrote: Hi Peter, On 19/7/24 20:10, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (16): hw/char/pl011: Remove unused 'readbuff' field hw/char/pl011: Move pl011_put_fifo() earlier

[RFC PATCH] tests/qtest: Don't parallelize migration-test

2024-09-09 Thread Peter Maydell
The migration-test is a long-running test whose subtests all launch at least two QEMU processes. This means that if for example the host has 4 CPUs then 'make check' defaults to a parallelism of 5, and if we launch 5 migration-tests in parallel then we will be running 10 QEMU instances on a 4 CPU

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-09 Thread Philippe Mathieu-Daudé
Hi, On 3/9/24 18:06, Peter Maydell wrote: This patchset removes the various Arm machines which we deprecated for the 9.0 release and are therefore allowed to remove for the 9.2 release: akita, borzoi, cheetah, connex, mainstone, n800, n810, spitz, terrier, tosa, verdex, z2 The series incl

Re: [PATCH for-9.2 00/53] arm: Drop deprecated boards

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 14:41, Philippe Mathieu-Daudé wrote: > > Hi, > > On 3/9/24 18:06, Peter Maydell wrote: > > This patchset removes the various Arm machines which we deprecated > > for the 9.0 release and are therefore allowed to remove for the 9.2 > > release: > > akita, borzoi, cheetah, co

Re: [PATCH v2 00/11] s390: Convert virtio-ccw, cpu to three-phase reset, and followup cleanup

2024-09-09 Thread Nina Schoetterl-Glausch
On Fri, 2024-09-06 at 15:38 +0100, Peter Maydell wrote: > On Fri, 30 Aug 2024 at 15:58, Peter Maydell wrote: > > > > The main aim of this patchseries is to remove the two remaining uses > > of device_class_set_parent_reset() in the tree, which are virtio-ccw > > and the s390 CPU class. Doing that

[PATCH RFC 05/10] migration: Introduce util functions for periodic CPU throttle

2024-09-09 Thread Hyman Huang
Provide useful utilities to manage the periodic_throttle_thread's lifespan. Additionally, to set up sync mode, provide periodic_throttle_setup. Signed-off-by: Hyman Huang --- migration/ram.c| 98 +- migration/ram.h| 4 ++ migration/trace-e

[PATCH RFC 04/10] qapi/migration: Introduce the iteration-count

2024-09-09 Thread Hyman Huang
The original migration information dirty-sync-count could no longer reflect iteration count due to the introduction of periodic synchronization in the next commit; add the iteration count to compensate. Signed-off-by: Hyman Huang --- migration/migration-stats.h | 4 migration/migration.c

[PATCH RFC 08/10] migration: Introduce cpu-responsive-throttle parameter

2024-09-09 Thread Hyman Huang
To enable the responsive throttle that will be implemented in the next commit, introduce the cpu-responsive-throttle parameter. Signed-off-by: Hyman Huang --- migration/migration-hmp-cmds.c | 8 migration/options.c| 20 migration/options.h|

[PATCH RFC 09/10] migration: Support responsive CPU throttle

2024-09-09 Thread Hyman Huang
Currently, the convergence algorithm determines that the migration cannot converge according to the following principle: The dirty pages generated in current iteration exceed a specific percentage (throttle-trigger-threshold, 50 by default) of the number of transmissions. Let's refer to this criter

[PATCH RFC 00/10] migration: auto-converge refinements for huge VM

2024-09-09 Thread Hyman Huang
Currently, a huge VM with high memory overload may take a long time to increase its maximum throttle percentage. The root cause is that the current auto-converge throttle logic doesn't look like it will scale because migration_trigger_throttle() is only called for each iteration, so it won't be inv

[PATCH RFC 01/10] migration: Introduce structs for periodic CPU throttle

2024-09-09 Thread Hyman Huang
shadow_bmap, iter_bmap, iter_dirty_pages and periodic_sync_shown_up are introduced to satisfy the need for periodic CPU throttle. Meanwhile, introduce enumeration of dirty bitmap sync method. Signed-off-by: Hyman Huang --- include/exec/ramblock.h | 45 +

[PATCH RFC 02/10] migration: Refine util functions to support periodic CPU throttle

2024-09-09 Thread Hyman Huang
Supply the migration_bitmap_sync function along with a periodic argument. Introduce the sync_mode global variable to track the sync mode and support periodic throttling while keeping backward compatibility. Signed-off-by: Hyman Huang --- include/exec/ram_addr.h | 117

[PATCH RFC 07/10] tests/migration-tests: Add test case for periodic throttle

2024-09-09 Thread Hyman Huang
To make sure periodic throttle feature doesn't regression any features and functionalities, enable this feature in the auto-converge migration test. Signed-off-by: Hyman Huang --- tests/qtest/migration-test.c | 56 +++- 1 file changed, 55 insertions(+), 1 deletion

[PATCH RFC 03/10] qapi/migration: Introduce periodic CPU throttling parameters

2024-09-09 Thread Hyman Huang
To activate the periodic CPU throttleing feature, introduce the cpu-periodic-throttle. To control the frequency of throttling, introduce the cpu-periodic-throttle-interval. Signed-off-by: Hyman Huang --- migration/migration-hmp-cmds.c | 17 +++ migration/options.c| 54 ++

[PATCH RFC 06/10] migration: Support periodic CPU throttle

2024-09-09 Thread Hyman Huang
When VM is configured with huge memory, the current throttle logic doesn't look like to scale, because migration_trigger_throttle() is only called for each iteration, so it won't be invoked for a long time if one iteration can take a long time. The periodic sync and throttle aims to fix the above

[PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Hyman Huang
Despite the fact that the responsive CPU throttle is enabled, the dirty sync count may not always increase because this is an optimization that might not happen in any situation. This test case just making sure it doesn't interfere with any current functionality. Signed-off-by: Hyman Huang ---

Re: [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes

2024-09-09 Thread Peter Maydell
On Tue, 27 Aug 2024 at 04:51, Doug Brown wrote: > > This series fixes several problems I ran into while trying to simulate > the AMD/Xilinx Versal CANFD controller in the xlnx-versal-virt machine > using Xilinx's v6.6_LTS_2024.1 kernel. With all of these patches > applied, everything works correct

Re: [PATCH v2 00/15] target/cris: Remove the deprecated CRIS target

2024-09-09 Thread Edgar E. Iglesias
On Mon, Sep 9, 2024 at 7:25 AM Philippe Mathieu-Daudé wrote: > Hi Edgar, > > On 4/9/24 16:35, Philippe Mathieu-Daudé wrote: > > Since v1: > > - Split in smaller patches (pm215) > > > > The CRIS target is deprecated since v9.0 (commit > > c7bbef40234 "docs: mark CRIS support as deprecated"). > > >

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 14:51, Hyman Huang wrote: > > Despite the fact that the responsive CPU throttle is enabled, > the dirty sync count may not always increase because this is > an optimization that might not happen in any situation. > > This test case just making sure it doesn't interfere with

Re: [PATCH v2 00/15] target/cris: Remove the deprecated CRIS target

2024-09-09 Thread Philippe Mathieu-Daudé
On 9/9/24 15:59, Edgar E. Iglesias wrote: On Mon, Sep 9, 2024 at 7:25 AM Philippe Mathieu-Daudé > wrote: Hi Edgar, On 4/9/24 16:35, Philippe Mathieu-Daudé wrote: > Since v1: > - Split in smaller patches (pm215) > > The CRIS target is depreca

[PULL 00/10] Crypto fixes patches

2024-09-09 Thread Daniel P . Berrangé
The following changes since commit f2aee60305a1e40374b2fc1093e4d04404e780ee: Merge tag 'pull-request-2024-09-08' of https://gitlab.com/huth/qemu into staging (2024-09-09 10:47:24 +0100) are available in the Git repository at: https://gitlab.com/berrange/qemu tags/crypto-fixes-pull-request

[PULL 09/10] crypto: Support SHA384 hash when using glib

2024-09-09 Thread Daniel P . Berrangé
From: Dorjoy Chowdhury QEMU requires minimum glib version 2.66.0 as per the root meson.build file and per glib documentation[1] G_CHECKSUM_SHA384 is available since 2.51. [1] https://docs.gtk.org/glib/enum.ChecksumType.html Reviewed-by: Daniel P. Berrangé Signed-off-by: Dorjoy Chowdhury Signe

[PULL 05/10] tests/unit: build pbkdf test on macOS

2024-09-09 Thread Daniel P . Berrangé
Add CONFIG_DARWIN to the pbkdf test build condition, since we have a way to measure CPU time on this platform since commit bf98afc75efedf1. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- tests/unit/test-crypto-pbkdf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PULL 08/10] crypto: Define macros for hash algorithm digest lengths

2024-09-09 Thread Daniel P . Berrangé
From: Dorjoy Chowdhury Reviewed-by: Daniel P. Berrangé Signed-off-by: Dorjoy Chowdhury Signed-off-by: Daniel P. Berrangé --- crypto/hash.c | 14 +++--- include/crypto/hash.h | 8 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/crypto/hash.c b/crypto/h

[PULL 03/10] crypto: check gnutls & gcrypt support the requested pbkdf hash

2024-09-09 Thread Daniel P . Berrangé
Both gnutls and gcrypt can be configured to exclude support for certain algorithms via a runtime check against system crypto policies. Thus it is not sufficient to have a compile time test for hash support in their pbkdf implementations. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P

[PULL 06/10] crypto: avoid leak of ctx when bad cipher mode is given

2024-09-09 Thread Daniel P . Berrangé
Fixes: Coverity CID 1546884 Reviewed-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crypto/cipher-nettle.c.inc b/crypto/cipher-nettle.c.inc index 42

[PULL 01/10] iotests: fix expected output from gnutls

2024-09-09 Thread Daniel P . Berrangé
Error reporting from gnutls was improved by: commit 57941c9c86357a6a642f9ee3279d881df4043b6d Author: Daniel P. Berrangé Date: Fri Mar 15 14:07:58 2024 + crypto: push error reporting into TLS session I/O APIs This has the effect of changing the output from one of the NBD tests.

[PULL 02/10] crypto: run qcrypto_pbkdf2_count_iters in a new thread

2024-09-09 Thread Daniel P . Berrangé
From: Tiago Pasqualini CPU time accounting in the kernel has been demonstrated to have a sawtooth pattern[1][2]. This can cause the getrusage system call to not be as accurate as we are expecting, which can cause this calculation to stall. The kernel discussions shows that this inaccuracy happen

[PULL 07/10] crypto: use consistent error reporting pattern for unsupported cipher modes

2024-09-09 Thread Daniel P . Berrangé
Not all paths in qcrypto_cipher_ctx_new() were correctly distinguishing between valid user input for cipher mode (which should report a user facing error), vs program logic errors (which should assert). Reported-by: Peter Maydell Signed-off-by: Daniel P. Berrangé --- crypto/cipher-nettle.c.inc

Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Joelle van Dyne
On Mon, Sep 9, 2024 at 12:36 AM Akihiko Odaki wrote: > > On 2024/09/09 10:58, Joelle van Dyne wrote: > > New optional argument for 'blockdev-change-medium' QAPI command to allow > > the caller to specify if they wish to enable file locking. > > > > Signed-off-by: Joelle van Dyne > > --- > > qap

[PULL 04/10] tests/unit: always build the pbkdf crypto unit test

2024-09-09 Thread Daniel P . Berrangé
The meson rules were excluding the pbkdf crypto test when gnutls was the crypto backend. It was then excluded again in #if statements in the test file. Rather than update these conditions, remove them all, and use the result of the qcrypto_pbkdf_supports() function to determine whether to skip tes

[PULL 10/10] crypto: Introduce x509 utils

2024-09-09 Thread Daniel P . Berrangé
From: Dorjoy Chowdhury An utility function for getting fingerprint from X.509 certificate has been introduced. Implementation only provided using gnutls. Signed-off-by: Dorjoy Chowdhury [DB: fixed missing gnutls_x509_crt_deinit in success path] Reviewed-by: Philippe Mathieu-Daudé Signed-off-by

[Bug Report] smmuv3 event 0x10 report when running virtio-blk-pci

2024-09-09 Thread Zhou Wang via
Hi All, When I tested mainline qemu(commit 7b87a25f49), it reports smmuv3 event 0x10 during kernel booting up. qemu command which I use is as below: qemu-system-aarch64 -machine virt,kernel_irqchip=on,gic-version=3,iommu=smmuv3 \ -kernel Image -initrd minifs.cpio.gz \ -enable-kvm -net none -nogr

Re: [PATCH] block: support locking on change medium

2024-09-09 Thread Joelle van Dyne
On Mon, Sep 9, 2024 at 2:56 AM Kevin Wolf wrote: > > Am 09.09.2024 um 03:58 hat Joelle van Dyne geschrieben: > > New optional argument for 'blockdev-change-medium' QAPI command to allow > > the caller to specify if they wish to enable file locking. > > > > Signed-off-by: Joelle van Dyne > > I fee

[PATCH RESEND RFC 00/10] migration: auto-converge refinements for huge VM

2024-09-09 Thread Hyman Huang
Currently, a huge VM with high memory overload may take a long time to increase its maximum throttle percentage. The root cause is that the current auto-converge throttle logic doesn't look like it will scale because migration_trigger_throttle() is only called for each iteration, so it won't be inv

[PATCH RESEND RFC 07/10] tests/migration-tests: Add test case for periodic throttle

2024-09-09 Thread Hyman Huang
To make sure periodic throttle feature doesn't regression any features and functionalities, enable this feature in the auto-converge migration test. Signed-off-by: Hyman Huang --- tests/qtest/migration-test.c | 56 +++- 1 file changed, 55 insertions(+), 1 deletion

[PATCH RESEND RFC 06/10] migration: Support periodic CPU throttle

2024-09-09 Thread Hyman Huang
When VM is configured with huge memory, the current throttle logic doesn't look like to scale, because migration_trigger_throttle() is only called for each iteration, so it won't be invoked for a long time if one iteration can take a long time. The periodic sync and throttle aims to fix the above

[PATCH RESEND RFC 02/10] migration: Refine util functions to support periodic CPU throttle

2024-09-09 Thread Hyman Huang
Supply the migration_bitmap_sync function along with a periodic argument. Introduce the sync_mode global variable to track the sync mode and support periodic throttling while keeping backward compatibility. Signed-off-by: Hyman Huang --- include/exec/ram_addr.h | 107

[PATCH RESEND RFC 03/10] qapi/migration: Introduce periodic CPU throttling parameters

2024-09-09 Thread Hyman Huang
To activate the periodic CPU throttleing feature, introduce the cpu-periodic-throttle. To control the frequency of throttling, introduce the cpu-periodic-throttle-interval. Signed-off-by: Hyman Huang --- migration/migration-hmp-cmds.c | 17 +++ migration/options.c| 54 ++

[PATCH RESEND RFC 09/10] migration: Support responsive CPU throttle

2024-09-09 Thread Hyman Huang
Currently, the convergence algorithm determines that the migration cannot converge according to the following principle: The dirty pages generated in current iteration exceed a specific percentage (throttle-trigger-threshold, 50 by default) of the number of transmissions. Let's refer to this criter

[PATCH RESEND RFC 05/10] migration: Introduce util functions for periodic CPU throttle

2024-09-09 Thread Hyman Huang
Provide useful utilities to manage the periodic_throttle_thread's lifespan. Additionally, to set up sync mode, provide periodic_throttle_setup. Signed-off-by: Hyman Huang --- migration/ram.c| 98 +- migration/ram.h| 4 ++ migration/trace-e

[PATCH RESEND RFC 01/10] migration: Introduce structs for periodic CPU throttle

2024-09-09 Thread Hyman Huang
shadow_bmap, iter_bmap, iter_dirty_pages and periodic_sync_shown_up are introduced to satisfy the need for periodic CPU throttle. Meanwhile, introduce enumeration of dirty bitmap sync method. Signed-off-by: Hyman Huang --- include/exec/ramblock.h | 45 +

[PATCH RESEND RFC 08/10] migration: Introduce cpu-responsive-throttle parameter

2024-09-09 Thread Hyman Huang
To enable the responsive throttle that will be implemented in the next commit, introduce the cpu-responsive-throttle parameter. Signed-off-by: Hyman Huang --- migration/migration-hmp-cmds.c | 8 migration/options.c| 20 migration/options.h|

[PATCH RESEND RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Hyman Huang
Despite the fact that the responsive CPU throttle is enabled, the dirty sync count may not always increase because this is an optimization that might not happen in any situation. This test case just making sure it doesn't interfere with any current functionality. Signed-off-by: Hyman Huang ---

[PATCH RESEND RFC 04/10] qapi/migration: Introduce the iteration-count

2024-09-09 Thread Hyman Huang
The original migration information dirty-sync-count could no longer reflect iteration count due to the introduction of periodic synchronization in the next commit; add the iteration count to compensate. Signed-off-by: Hyman Huang --- migration/migration-stats.h | 4 migration/migration.c

Re: [Bug Report] smmuv3 event 0x10 report when running virtio-blk-pci

2024-09-09 Thread Peter Maydell
On Mon, 9 Sept 2024 at 15:22, Zhou Wang via wrote: > > Hi All, > > When I tested mainline qemu(commit 7b87a25f49), it reports smmuv3 event 0x10 > during kernel booting up. Does it still do this if you either: (1) use the v9.1.0 release (commit fd1952d814da) (2) use "-machine virt-9.1" instead o

Re: [PULL 27/34] migration/multifd: Move nocomp code into multifd-nocomp.c

2024-09-09 Thread Peter Xu
On Mon, Sep 09, 2024 at 11:28:14AM +0100, Peter Maydell wrote: > On Wed, 4 Sept 2024 at 13:48, Fabiano Rosas wrote: > > > > In preparation for adding new payload types to multifd, move most of > > the no-compression code into multifd-nocomp.c. Let's try to keep a > > semblance of layering by not m

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Peter Xu
On Mon, Sep 09, 2024 at 03:02:57PM +0100, Peter Maydell wrote: > On Mon, 9 Sept 2024 at 14:51, Hyman Huang wrote: > > > > Despite the fact that the responsive CPU throttle is enabled, > > the dirty sync count may not always increase because this is > > an optimization that might not happen in any

Re: [PATCH RFC 10/10] tests/migration-tests: Add test case for responsive CPU throttle

2024-09-09 Thread Yong Huang
On Mon, Sep 9, 2024 at 10:03 PM Peter Maydell wrote: > On Mon, 9 Sept 2024 at 14:51, Hyman Huang wrote: > > > > Despite the fact that the responsive CPU throttle is enabled, > > the dirty sync count may not always increase because this is > > an optimization that might not happen in any situatio

  1   2   3   4   >