Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Thomas Huth
On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in the other context. Add it to meson.build for such. It is not removed from .gitlab-ci.

Re: [RFC] Virtualizing tagged disaggregated memory capacity (app specific, multi host shared)

2024-08-16 Thread Hannes Reinecke
On 8/15/24 18:22, Jonathan Cameron wrote: Introduction If we think application specific memory (including inter-host shared memory) is a thing, it will also be a thing people want to use with virtual machines, potentially nested. So how do we present it at the Host to VM boundary?

Re: [PATCH v4 16/16] target/riscv: add trace-hooks for each case of sw-check exception

2024-08-16 Thread Deepak Gupta
On Fri, Aug 16, 2024 at 03:52:34PM +1000, Richard Henderson wrote: On 8/16/24 11:07, Deepak Gupta wrote: Violations to control flow rules setup by zicfilp and zicfiss lead to software check exceptions. To debug and fix such sw check issues in guest , add trace-hooks for each case. Signed-off-by

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in the other context. Add it to meson.build for

[PULL 4/5] ci: add gtk-vnc to the deps

2024-08-16 Thread Thomas Huth
From: Daniel P. Berrangé The gtk-vnc package is used by the vnc-display-test qtest program. Technically only gvnc is needed, but since we already pull in the gtk3 dep, it is harmless to depend on gtk-vnc. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message-ID: <20240718094159.90

[PULL 1/5] target/s390x: fix build warning (gcc-12 -fsanitize=thread)

2024-08-16 Thread Thomas Huth
From: Pierrick Bouvier Found on debian stable. ../target/s390x/tcg/translate.c: In function ‘get_mem_index’: ../target/s390x/tcg/translate.c:398:1: error: control reaches end of non-void function [-Werror=return-type] 398 | } Signed-off-by: Pierrick Bouvier Acked-by: Ilya Leoshkevich Messa

[PULL 0/5] Some small tests and s390x fixes

2024-08-16 Thread Thomas Huth
Hi Richard! The following changes since commit b0d6c037ea0a825192285f149af72a73a1baaa04: Update version for v9.1.0-rc2 release (2024-08-15 20:32:37 +1000) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-08-16 for you to fetch changes up to

[PULL 5/5] ci: refresh package lists with lcitool

2024-08-16 Thread Thomas Huth
From: Daniel P. Berrangé Refresh with the newly added gtk-vnc package Signed-off-by: Daniel P. Berrangé Message-ID: <20240718094159.902024-3-berra...@redhat.com> [thuth: fixed conflicts in .gitlab-ci.d/cirrus/*.vars] Signed-off-by: Thomas Huth --- .gitlab-ci.d/cirrus/freebsd-13.vars

[PATCH v3 6/6] target/sparc: Add gen_trap_if_nofpu_fpexception

2024-08-16 Thread Richard Henderson
Model fp_exception state, in which only fp stores are allowed until such time as the FQ has been flushed. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 90 +++- 1 file changed, 61 insertions(+), 29 deletions(-) diff --git a/target/sparc/tran

[PULL 3/5] tests/avocado: apply proper skipUnless decorator

2024-08-16 Thread Thomas Huth
From: Cleber Rosa Commit 9b45cc993 added many cases of skipUnless for the sake of organizing flaky tests. But, Python decorators *must* follow what they decorate, so the newlines added should *not* exist there. Signed-off-by: Cleber Rosa Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Thomas

[PATCH for-9.2 v3 0/6] target/sparc: emulate floating point queue when raising fp traps

2024-08-16 Thread Richard Henderson
Hi Carl, While digging through the manual to figure out if we were really doing the right thing raising the fp exception, I found the fpu exception state machine. I'm not sure it's worth emulating the fp_exception_pending state, but it's certainly easy enough to emulate the fp_executing/fp_except

[PATCH v3 4/6] target/sparc: Add FSR_QNE to tb_flags

2024-08-16 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/sparc/cpu.h | 8 +++- target/sparc/translate.c | 10 +++--- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h index 9f2bc44722..f517e5a383 100644 --- a/target/sparc/cpu.h +++ b/target/

[PATCH v3 5/6] target/sparc: Implement STDFQ

2024-08-16 Thread Richard Henderson
Invalid encoding of addr should raise TT_ILL_INSN, so check before supervisor, which might raise TT_PRIV_INSN. Clear QNE after execution. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 24 +++- target/sparc/insns.decode | 4 ++-- 2 files changed, 25 inserti

[PATCH v3 2/6] target/sparc: Add FQ and FSR.QNE

2024-08-16 Thread Richard Henderson
From: Carl Hauser Add support for, and migrate, a single-entry fp instruction queue for sparc32. Signed-off-by: Carl Hauser [rth: Split from a larger patch; adjust representation with union; add migration state] Signed-off-by: Richard Henderson --- target/sparc/cpu.h| 22 +

[PULL 2/5] meson.build: Check for the availability of __attribute__((gcc_struct)) on MSYS2

2024-08-16 Thread Thomas Huth
Since quite a while MSYS2 now supports Clang as a compiler, too. Unfortunately, this compiler is lacking the __attribute__((gcc_struct)) that we need for compiling on Windows. But since the compiler is available now, some people started to use it to compile QEMU on MSYS2, apparently ignoring the co

[PATCH v3 1/6] target/sparc: Restrict STQF to sparcv9

2024-08-16 Thread Richard Henderson
Prior to sparcv9, the same encoding was STDFQ. Cc: qemu-sta...@nongnu.org Fixes: 06c060d9e5b ("target/sparc: Move simple fp load/store to decodetree") Signed-off-by: Richard Henderson --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/sparc/tr

[PATCH v3 3/6] target/sparc: Populate sparc32 FQ when raising fp exception

2024-08-16 Thread Richard Henderson
From: Carl Hauser Implement a single instruction floating point queue, populated while delivering an fp exception. Signed-off-by: Carl Hauser [rth: Split from a larger patch] Signed-off-by: Richard Henderson --- target/sparc/int32_helper.c | 32 +--- 1 file changed

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Thomas Huth
On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function for the CI but doesn't add the flag in t

Re: [PATCH v4 13/16] target/riscv: compressed encodings for sspush and sspopchk

2024-08-16 Thread Richard Henderson
On 8/16/24 16:56, Deepak Gupta wrote: +  c_sspush    011 0  1  0 01 rs2=1 rs1=0 # c.sspush x1 carving out of zcmops +  c_sspopchk  011 0  00101  0 01 rs1=5 rd=0 # c.sspopchk x5 carving out of zcmops ... This indirection is pointless.  Have the decoder invoke the proper insn

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function

[PATCH qemu v4 0/1] target/riscv: Add Zilsd and Zclsd extension support

2024-08-16 Thread ~liuxu
Last reply: https://lists.gnu.org/archive/html/qemu- devel/2024-08/msg01631.html This version no longer separates the implementation of Zilsd and Zclsd extensions. lxx (1): target/riscv: Add Zilsd and Zclsd extension support target/riscv/cpu.c| 4 + target/riscv/cpu_

[PATCH qemu v4 1/1] target/riscv: Add Zilsd and Zclsd extension support

2024-08-16 Thread ~liuxu
From: lxx <1733205...@qq.com> This patch adds support for the Zilsd and Zclsd extension, which is documented at https://github.com/riscv/riscv-zilsd/releases/tag/v0.9.0 Co-developed-by: SUN Dongya Co-developed-by: LIU Xu Co-developed-by: ZHAO Fujin --- target/riscv/cpu.c

Re: [RFC PATCH 0/2] async: rework async event API for replay

2024-08-16 Thread Michael S. Tsirkin
On Fri, Aug 16, 2024 at 12:23:50PM +1000, Nicholas Piggin wrote: > On Fri Aug 16, 2024 at 1:30 AM AEST, Michael S. Tsirkin wrote: > > On Thu, Aug 15, 2024 at 11:28:35PM +1000, Nicholas Piggin wrote: > > > Continuing the conversation from the thread about record/replay > > > virtio fix. Here is a sk

Re: [PATCH] vhost_net: configure all host notifiers in a single MR transaction

2024-08-16 Thread Michael S. Tsirkin
On Fri, Aug 16, 2024 at 03:08:35PM +0800, zuoboqun wrote: > This allows the vhost_net device which has multiple virtqueues to batch > the setup of all its host notifiers. This significantly reduces the > vhost_net device starting and stoping time, e.g. the time spend > on enabling notifiers reduce

Re: [PATCH-for-9.1? v2] hw/pci/pci-hmp-cmds: Avoid displaying bogus size in 'info pci'

2024-08-16 Thread Michael S. Tsirkin
On Fri, Aug 16, 2024 at 08:16:15AM +0200, Philippe Mathieu-Daudé wrote: > ping tagged this now, thanks!

[PATCH v8 04/13] qapi/acpi-hest: add an interface to do generic CPER error injection

2024-08-16 Thread Mauro Carvalho Chehab
Creates a QMP command to be used for generic ACPI APEI hardware error injection (HEST) via GHESv2. The actual GHES code will be added at the followup patch. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Shiju Jose Reviewed-by: Jonathan Cameron --- MAINTAINERS | 7 +++

[PATCH v8 08/13] docs: acpi_hest_ghes: fix documentation for CPER size

2024-08-16 Thread Mauro Carvalho Chehab
While the spec defines a CPER size of 4KiB for each record, currently it is set to 1KiB. Fix the documentation and add a pointer to the macro name there, as this may help to keep it updated. Signed-off-by: Mauro Carvalho Chehab Acked-by: Igor Mammedov --- docs/specs/acpi_hest_ghes.rst | 6 -

[PATCH v8 11/13] scripts/arm_processor_error.py: retrieve mpidr if not filled

2024-08-16 Thread Mauro Carvalho Chehab
Add support to retrieve mpidr value via qom-get. Signed-off-by: Mauro Carvalho Chehab --- scripts/arm_processor_error.py | 27 +++ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/scripts/arm_processor_error.py b/scripts/arm_processor_error.py index 62e0c566

[PATCH v8 03/13] acpi/ghes: Add support for GED error device

2024-08-16 Thread Mauro Carvalho Chehab
From: Jonathan Cameron As a GED error device is now defined, add another type of notification. Add error notification to GHES v2 using a GED error device GED triggered via interrupt. [mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks and rename HEST event to better identify GED interrupt

[PATCH v8 05/13] acpi/ghes: rework the logic to handle HEST source ID

2024-08-16 Thread Mauro Carvalho Chehab
The current logic is based on a lot of duct tape, with offsets calculated based on one define with the number of source IDs and an enum. Rewrite the logic in a way that it would be more resilient of code changes, by moving the source ID count to an enum and make the offset calculus more explicit.

[PATCH v8 00/13] Add ACPI CPER firmware first error injection on ARM emulation

2024-08-16 Thread Mauro Carvalho Chehab
This series add support for injecting generic CPER records. Such records are generated outside QEMU via a provided script. On this version, I added two optional patches at the end: - acpi/ghes: cleanup generic error data logic It drops some obvious comments from some already-existing code. A

[PATCH v8 12/13] acpi/ghes: cleanup generic error data logic

2024-08-16 Thread Mauro Carvalho Chehab
Remove comments that are obvious. No functional changes. Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes.c | 38 +++--- 1 file changed, 15 insertions(+), 23 deletions(-) diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c index 4f7b6c5ad2b6..a822a5eafaa0 100644 -

[PATCH v8 09/13] scripts/ghes_inject: add a script to generate GHES error inject

2024-08-16 Thread Mauro Carvalho Chehab
Using the QMP GHESv2 API requires preparing a raw data array containing a CPER record. Add a helper script with subcommands to prepare such data. Currently, only ARM Processor error CPER record is supported. Signed-off-by: Mauro Carvalho Chehab --- MAINTAINERS| 3 + scrip

[PATCH v8 07/13] acpi/ghes: cleanup the memory error code logic

2024-08-16 Thread Mauro Carvalho Chehab
Better organize the code of the function, making it to use the raw CPER function, thus removing duplicated code. While here, rename the function to actually reflect what it does. Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes-stub.c| 2 +- hw/acpi/ghes.c | 125 +

[PATCH v8 02/13] arm/virt: Wire up a GED error device for ACPI / GHES

2024-08-16 Thread Mauro Carvalho Chehab
Adds support to ARM virtualization to allow handling generic error ACPI Event via GED & error source device. It is aligned with Linux Kernel patch: https://lore.kernel.org/lkml/1272350481-27951-8-git-send-email-ying.hu...@intel.com/ Co-authored-by: Mauro Carvalho Chehab Co-authored-by: Jonathan

[PATCH v8 01/13] acpi/generic_event_device: add an APEI error device

2024-08-16 Thread Mauro Carvalho Chehab
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2: https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources using HID PNP0C33. The PNP0C33 device is used to report hardware

[PATCH v8 10/13] target/arm: add an experimental mpidr arm cpu property object

2024-08-16 Thread Mauro Carvalho Chehab
Accurately injecting an ARM Processor error ACPI/APEI GHES error record requires the value of the ARM Multiprocessor Affinity Register (mpidr). While ARM implements it, this is currently not visible. Add a field at CPU storing it, and place it at arm_cpu_properties as experimental, thus allowing

[PATCH v8 13/13] acpi/ghes: check if the BIOS pointers for HEST are correct

2024-08-16 Thread Mauro Carvalho Chehab
The OS kernels navigate between HEST, error source struct and CPER by the usage of some pointers. Double-check if such pointers were properly initializing, ensuring that they match the right address for CPER. Signed-off-by: Mauro Carvalho Chehab --- hw/acpi/ghes.c | 30 ++

[PATCH v8 06/13] acpi/ghes: add support for generic error injection via QAPI

2024-08-16 Thread Mauro Carvalho Chehab
Provide a generic interface for error injection via GHESv2. This patch is co-authored: - original ghes logic to inject a simple ARM record by Shiju Jose; - generic logic to handle block addresses by Jonathan Cameron; - generic GHESv2 error inject by Mauro Carvalho Chehab; Co-authored-

Re: [PULL 1/5] target/s390x: fix build warning (gcc-12 -fsanitize=thread)

2024-08-16 Thread Philippe Mathieu-Daudé
On 16/8/24 09:22, Thomas Huth wrote: From: Pierrick Bouvier Found on debian stable. ../target/s390x/tcg/translate.c: In function ‘get_mem_index’: ../target/s390x/tcg/translate.c:398:1: error: control reaches end of non-void function [-Werror=return-type] 398 | } Signed-off-by: Pierrick Bo

Re: [PATCH v3 1/6] target/sparc: Restrict STQF to sparcv9

2024-08-16 Thread Philippe Mathieu-Daudé
On 16/8/24 09:23, Richard Henderson wrote: Prior to sparcv9, the same encoding was STDFQ. Cc: qemu-sta...@nongnu.org Fixes: 06c060d9e5b ("target/sparc: Move simple fp load/store to decodetree") Signed-off-by: Richard Henderson --- target/sparc/translate.c | 2 +- 1 file changed, 1 insertion(

Re: [PATCH qemu v4 1/1] target/riscv: Add Zilsd and Zclsd extension support

2024-08-16 Thread Richard Henderson
On 8/16/24 16:41, ~liuxu wrote: From: lxx <1733205...@qq.com> This patch adds support for the Zilsd and Zclsd extension, which is documented at https://github.com/riscv/riscv-zilsd/releases/tag/v0.9.0 Co-developed-by: SUN Dongya Co-developed-by: LIU Xu Co-developed-by: ZHAO Fujin --- targe

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Thomas Huth
On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the cla

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Richard Henderson
On 8/16/24 17:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job") adds -fno-sanitize=function fo

Re: [PATCH v7 0/7] Add Rust build support, ARM PL011 device impl

2024-08-16 Thread Junjie Mao
On 8/15/2024 7:42 PM, Manos Pitsidianakis wrote: Outstanding issues == Outstanding issues that are not blocking for merge are: - Cross-compilation for aarch64 is not possible out-of-the-box because of this bug: in llvm which

Re: [PATCH v2 3/4] target/m68k: Implement packed decimal real stores

2024-08-16 Thread Richard Henderson
On 8/16/24 16:37, Philippe Mathieu-Daudé wrote: Hi Richard, On 12/8/24 02:44, Richard Henderson wrote: Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2488 Signed-off-by: Richard Henderson ---   target/m68k/helper.h |   1 +   target/m68k/fpu_helper.c | 112 +

Re: [PATCH for-9.1] linux-user: Handle short reads in mmap_h_gt_g

2024-08-16 Thread Richard Henderson
On 8/16/24 15:57, Philippe Mathieu-Daudé wrote: On 15/8/24 23:32, Richard Henderson wrote: In particular, if an image has a large bss, we can hit EOF before reading all host_len bytes of the mapping. Cc: qemu-sta...@nongnu.org Fixes: eb5027ac618 ("linux-user: Split out mmap_h_gt_g") Resolves: h

Re: [PATCH v7 0/7] Add Rust build support, ARM PL011 device impl

2024-08-16 Thread Manos Pitsidianakis
On Fri, 16 Aug 2024, 11:06 Junjie Mao, wrote: > On 8/15/2024 7:42 PM, Manos Pitsidianakis wrote: > > Outstanding issues > > == > > > > Outstanding issues that are not blocking for merge are: > > > > - Cross-compilation for aarch64 is not possible out-of-the-box because > of this b

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Commit 23ef50ae2d0c (".gitlab-ci.d/buildtest.y

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Thomas Huth
On 16/08/2024 10.21, Akihiko Odaki wrote: On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16/08/2024 08.22, Akihiko Odaki wrote: Com

Re: [PULL 1/5] target/s390x: fix build warning (gcc-12 -fsanitize=thread)

2024-08-16 Thread Thomas Huth
On 16/08/2024 09.45, Philippe Mathieu-Daudé wrote: On 16/8/24 09:22, Thomas Huth wrote: From: Pierrick Bouvier Found on debian stable. ../target/s390x/tcg/translate.c: In function ‘get_mem_index’: ../target/s390x/tcg/translate.c:398:1: error: control reaches end of non-void function [-Werror

Re: [PATCH v7 6/7] rust: add crate to expose bindings and interfaces

2024-08-16 Thread Junjie Mao
On 8/15/2024 7:42 PM, Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao Co-authored-by: Paolo Bonzini Signed-off-by: Junjie Mao Signed-off-by:

[PATCH] hmp: display qdev canonical path in 'info qtree'

2024-08-16 Thread Jianxian Wen via
It is difficult to identify a specific instance when there are multiple instances of the same type in the output of 'info qom-tree'. However, in 'info qtree', we can find the specific instance using the DeviceState->id or mmio info. To facilitate locating instances in the output of the 'info qom-tr

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
On 2024/08/16 17:24, Thomas Huth wrote: On 16/08/2024 10.21, Akihiko Odaki wrote: On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 2024/08/16 16:03, Thomas Huth wrote: On 16

Re: [PATCH v7 6/7] rust: add crate to expose bindings and interfaces

2024-08-16 Thread Philippe Mathieu-Daudé
On 15/8/24 17:06, Daniel P. Berrangé wrote: On Thu, Aug 15, 2024 at 04:01:17PM +0200, Philippe Mathieu-Daudé wrote: Hi Manos, On 15/8/24 13:42, Manos Pitsidianakis wrote: Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visib

Re: [RFC V1 0/6] Live update: cpr-transfer

2024-08-16 Thread Daniel P . Berrangé
On Thu, Aug 15, 2024 at 04:28:59PM -0400, Peter Xu wrote: > On Sat, Jul 20, 2024 at 04:07:50PM -0400, Steven Sistare wrote: > > > > The new user-visible interfaces are: > > > >* cpr-transfer (MigMode migration parameter) > > > >* cpr-uri (migration parameter) > > > > > > I wonder whether t

Re: [PATCH v2 1/4] meson: hide tsan related warnings

2024-08-16 Thread Daniel P . Berrangé
On Fri, Aug 16, 2024 at 07:44:28AM +0200, Thomas Huth wrote: > On 15/08/2024 19.54, Peter Maydell wrote: > > On Thu, 15 Aug 2024 at 12:05, Daniel P. Berrangé > > wrote: > > > > > > On Thu, Aug 15, 2024 at 11:12:39AM +0100, Peter Maydell wrote: > > > > On Wed, 14 Aug 2024 at 23:42, Pierrick Bouvi

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Richard Henderson
On 8/16/24 18:27, Akihiko Odaki wrote: On 2024/08/16 17:24, Thomas Huth wrote: On 16/08/2024 10.21, Akihiko Odaki wrote: On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On 202

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
On 2024/08/16 17:46, Richard Henderson wrote: On 8/16/24 18:27, Akihiko Odaki wrote: On 2024/08/16 17:24, Thomas Huth wrote: On 16/08/2024 10.21, Akihiko Odaki wrote: On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote:

Re: [PATCH v3] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Thomas Huth
On 16/08/2024 10.27, Akihiko Odaki wrote: On 2024/08/16 17:24, Thomas Huth wrote: On 16/08/2024 10.21, Akihiko Odaki wrote: On 2024/08/16 17:03, Thomas Huth wrote: On 16/08/2024 09.30, Akihiko Odaki wrote: On 2024/08/16 16:27, Thomas Huth wrote: On 16/08/2024 09.12, Akihiko Odaki wrote: On

Re: [PATCH 3/5] hw/ppc/Kconfig: Add missing SERIAL_ISA dependency to POWERNV machine

2024-08-16 Thread Philippe Mathieu-Daudé
On 14/8/24 20:15, Bernhard Beschow wrote: The machine calls serial_hds_isa_init() which is provided by serial-isa.c, guarded by SERIAL_ISA. Signed-off-by: Bernhard Beschow --- hw/ppc/Kconfig | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 1/2] target/i386: Split out gen_prepare_val_nz

2024-08-16 Thread Philippe Mathieu-Daudé
On 1/8/24 09:58, Richard Henderson wrote: Split out the TCG_COND_TSTEQ logic from gen_prepare_eflags_z, and use it for CC_OP_BMILG* as well. Prepare for requiring both zero and non-zero senses. Signed-off-by: Richard Henderson --- target/i386/tcg/translate.c | 22 ++ 1 f

Re: [PATCH 2/2] target/i386: Fix carry flag for BLSI

2024-08-16 Thread Philippe Mathieu-Daudé
On 1/8/24 09:58, Richard Henderson wrote: BLSI has inverted semantics for C as compared to the other two BMI1 instructions, BLSMSK and BLSR. Introduce CC_OP_BLSI* for this purpose. Fixes: 1d0b926150 ("target/i386: move scalar 0F 38 and 0F 3A instruction to new decoder") or even older? Res

Re: [RFC] Virtualizing tagged disaggregated memory capacity (app specific, multi host shared)

2024-08-16 Thread Jonathan Cameron
On Fri, 16 Aug 2024 09:05:46 +0200 Hannes Reinecke wrote: > On 8/15/24 18:22, Jonathan Cameron wrote: > > Introduction > > > > > > If we think application specific memory (including inter-host shared > > memory) is > > a thing, it will also be a thing people want to use with virtua

[PATCH] chardev: allow specifying finer-grained reconnect timeouts

2024-08-16 Thread Daniil Tatianin
The "reconnect" option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live update, but due to this limitation in QEMU, previously the guest disk controller would hang for one second becau

[PATCH v4] meson: Use -fno-sanitize=function when available

2024-08-16 Thread Akihiko Odaki
e -fno-sanitize=function in meson.build does not affect --extra-cflags due to argument ordering. Signed-off-by: Akihiko Odaki --- Changes in v4: - Moved -fno-sanitize=function immediately after -fsanitize=undefined - Link to v3: https://lore.kernel.org/r/20240816-function-v3-1-32ff225e5...@daynix.com

Re: [PATCH 1/1] virtio-pci: return RAM device MR when set host notifier success

2024-08-16 Thread Gao,Shiyuan
ping. When VHOST_USER_PROTOCOL_F_HOST_NOTIFIER this feature negotiated and virtio_queue_set_host_notifier_mr success on system blk device's queue, the VM can't load MBR if the notify region's address above 4GB. Because the vp_notify in seabios maybe cann't notify the hardware accelerator by kickfd

Re: [PATCH 1/1] virtio-pci: return RAM device MR when set host notifier success

2024-08-16 Thread Michael S. Tsirkin
On Mon, Aug 12, 2024 at 08:20:27PM +0800, Gao Shiyuan wrote: > When vhost-user backend register memory region based host notifiers, > we should return RAM device MR of notify region MR's subregion in > virtio_address_space_lookup. > > In seabios, it will use virtio PCI Configration Access Capabili

[PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. Signed-off-by: Cornelia Huck --- hw/arm/virt.c | 9 - hw/core/machine.c | 3 +++ hw/i386/pc.c | 3 +++ hw/i386/pc_piix.c | 15 --- hw/i386/pc_q35.c | 13 ++

Re: [PATCH v1 04/10] hw/arm: xenpvh: Add support for SMP guests

2024-08-16 Thread Edgar E. Iglesias
On Thu, Aug 15, 2024 at 2:30 AM Stefano Stabellini wrote: > On Wed, 14 Aug 2024, Edgar E. Iglesias wrote: > > On Tue, Aug 13, 2024 at 03:52:32PM -0700, Stefano Stabellini wrote: > > > On Tue, 13 Aug 2024, Edgar E. Iglesias wrote: > > > > On Mon, Aug 12, 2024 at 06:47:17PM -0700, Stefano Stabellin

Re: [PATCH v7 01/10] acpi/generic_event_device: add an APEI error device

2024-08-16 Thread Jonathan Cameron via
On Fri, 16 Aug 2024 07:53:24 +0200 Mauro Carvalho Chehab wrote: > Em Wed, 14 Aug 2024 13:33:21 +0100 > Jonathan Cameron escreveu: > > > On Wed, 14 Aug 2024 01:23:23 +0200 > > Mauro Carvalho Chehab wrote: > > > > > Adds a generic error device to handle generic hardware error > > > events as

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Daniel P . Berrangé
On Fri, Aug 16, 2024 at 12:37:23PM +0200, Cornelia Huck wrote: > Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. > > Signed-off-by: Cornelia Huck > --- > hw/arm/virt.c | 9 - > hw/core/machine.c | 3 +++ > hw/i386/pc.c | 3 +++ > hw/i386/

Re: [PATCH v2 2/4] target/i386: fix build warning (gcc-12 -fsanitize=thread)

2024-08-16 Thread Philippe Mathieu-Daudé
On 15/8/24 00:41, Pierrick Bouvier wrote: Found on debian stable. ../target/i386/kvm/kvm.c: In function ‘kvm_handle_rdmsr’: ../target/i386/kvm/kvm.c:5345:1: error: control reaches end of non-void function [-Werror=return-type] 5345 | } | ^ ../target/i386/kvm/kvm.c: In function ‘kvm_han

Re: [PATCH for-9.2] hw: add compat machines for 9.2

2024-08-16 Thread Cornelia Huck
On Fri, Aug 16 2024, Daniel P. Berrangé wrote: > On Fri, Aug 16, 2024 at 12:37:23PM +0200, Cornelia Huck wrote: >> Add 9.2 machine types for arm/i440fx/m68k/q35/s390x/spapr. >> >> Signed-off-by: Cornelia Huck >> --- >> hw/arm/virt.c | 9 - >> hw/core/machine.c |

Re: [PATCH 1/2] hw/char: riscv_htif: Use blocking qemu_chr_fe_write_all

2024-08-16 Thread Daniel Henrique Barboza
On 8/14/24 10:54 PM, Alistair Francis wrote: The current approach of using qemu_chr_fe_write() and ignoring the return values results in dropped charecters [1]. Ideally we want to report FIFO status to the guest, but the HTIF isn't a real UART, so we don't really have a way to do that. Instea

Re: [PULL 0/5] Some small tests and s390x fixes

2024-08-16 Thread Richard Henderson
On 8/16/24 17:22, Thomas Huth wrote: Hi Richard! The following changes since commit b0d6c037ea0a825192285f149af72a73a1baaa04: Update version for v9.1.0-rc2 release (2024-08-15 20:32:37 +1000) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2

Re: [PATCH 1/1] virtio-pci: return RAM device MR when set host notifier success

2024-08-16 Thread Jason Wang
On Fri, Aug 16, 2024 at 6:29 PM Michael S. Tsirkin wrote: > > On Mon, Aug 12, 2024 at 08:20:27PM +0800, Gao Shiyuan wrote: > > When vhost-user backend register memory region based host notifiers, > > we should return RAM device MR of notify region MR's subregion in > > virtio_address_space_lookup.

Re: [PATCH 1/1] virtio-pci: return RAM device MR when set host notifier success

2024-08-16 Thread Gao,Shiyuan
> > When vhost-user backend register memory region based host notifiers, > > we should return RAM device MR of notify region MR's subregion in > > virtio_address_space_lookup. > > > > In seabios, it will use virtio PCI Configration Access Capability > > access notify region when assign notify regio

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Alex Bennée
Richard Henderson writes: > On 8/15/24 21:46, Alex Bennée wrote: >> Thomas Huth writes: >> >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Alex Bennée
Pierrick Bouvier writes: > On 8/15/24 04:46, Alex Bennée wrote: >> Thomas Huth writes: >> >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: Found on debian stable (i386). ../contrib/plugins/cache.c: In function 'vcpu_tb_trans': ../contrib/plugins/cache.c:477:30: error: cast from p

Re: [PATCH v3 4/5] machine/nitro-enclave: Add built-in Nitro Secure Module device

2024-08-16 Thread Dorjoy Chowdhury
Hi Daniel, On Mon, Aug 12, 2024 at 8:07 PM Daniel P. Berrangé wrote: > > On Sat, Aug 10, 2024 at 10:45:01PM +0600, Dorjoy Chowdhury wrote: > > AWS Nitro Enclaves have built-in Nitro Secure Module (NSM) device which > > is used for stripped down TPM functionality like attestation. This commit > >

Re: [PULL for 9.1 00/21] Some fixes for 9.1-rc3 (build, replay, docs, plugins)

2024-08-16 Thread Alex Bennée
Richard Henderson writes: > On 8/16/24 00:48, Alex Bennée wrote: >> The following changes since commit b0d6c037ea0a825192285f149af72a73a1baaa04: >>Update version for v9.1.0-rc2 release (2024-08-15 20:32:37 +1000) >> are available in the Git repository at: >>https://gitlab.com/stsquad/qemu

Re: [PATCH v3 4/5] machine/nitro-enclave: Add built-in Nitro Secure Module device

2024-08-16 Thread Daniel P . Berrangé
On Fri, Aug 16, 2024 at 06:50:34PM +0600, Dorjoy Chowdhury wrote: > Hi Daniel, > > On Mon, Aug 12, 2024 at 8:07 PM Daniel P. Berrangé > wrote: > > > > On Sat, Aug 10, 2024 at 10:45:01PM +0600, Dorjoy Chowdhury wrote: > > > AWS Nitro Enclaves have built-in Nitro Secure Module (NSM) device which >

Re: [PATCH v2 16/21] virtio-net: Use replay_schedule_bh_event for bhs that affect machine state

2024-08-16 Thread Alex Bennée
Jason Wang writes: > On Thu, Aug 15, 2024 at 10:29 PM Michael S. Tsirkin wrote: >> >> On Thu, Aug 15, 2024 at 05:12:32PM +1000, Nicholas Piggin wrote: >> > Could be a good idea. Although I'm not sure what to do with >> > all types, maybe we can restrict what is supported. >> > >> > > Is this wid

[PATCH] vhost_net: configure all host notifiers in a single MR transaction

2024-08-16 Thread zuoboqun via
This allows the vhost_net device which has multiple virtqueues to batch the setup of all its host notifiers. This significantly reduces the vhost_net device starting and stoping time, e.g. the time spend on enabling notifiers reduce from 630ms to 75ms and the time spend on disabling notifiers reduc

Re: [PULL for 9.1 00/21] Some fixes for 9.1-rc3 (build, replay, docs, plugins)

2024-08-16 Thread Thomas Huth
On 16/08/2024 14.54, Alex Bennée wrote: Richard Henderson writes: On 8/16/24 00:48, Alex Bennée wrote: The following changes since commit b0d6c037ea0a825192285f149af72a73a1baaa04: Update version for v9.1.0-rc2 release (2024-08-15 20:32:37 +1000) are available in the Git repository at:

[PULL v2 for 9.1 00/21] Some fixes for 9.1-rc3 (build, replay, docs, plugins)

2024-08-16 Thread Alex Bennée
The following changes since commit ecdfa31beb1f7616091bedba79dfdf9ee525ed9d: Merge tag 'pull-request-2024-08-16' of https://gitlab.com/thuth/qemu into staging (2024-08-16 18:18:27 +1000) are available in the Git repository at: https://gitlab.com/stsquad/qemu.git tags/pull-maintainer-9.1-rc3

[PATCH for-9.2 0/7] docs/devel: Convert txt files to rST

2024-08-16 Thread Peter Maydell
This patchset converts a collection of the remaining txt files in docs/devel to rST format. At this point in the release cycle I'm targeting 9.2 for these. Patches 1-5 are simple conversions. In patch 6 I move the QemuLockCnt APIs to their own header file; this is so that we can include the kerne

[PATCH 2/7] docs/devel/blkverify: Convert to rST format

2024-08-16 Thread Peter Maydell
Convert blkverify.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 1 + docs/devel/{blkverify.txt => blkverify.rst} | 30 - docs/devel/index-build.rst | 1 + 3 files changed, 19 insertions(+), 13 deletions(-)

[PATCH 6/7] include: Move QemuLockCnt APIs to their own header

2024-08-16 Thread Peter Maydell
Currently the QemuLockCnt data structure and associated functions are in the include/qemu/thread.h header. Move them to their own qemu/lockcnt.h. The main reason for doing this is that it means we can autogenerate the documentation comments into the docs/devel documentation. The copyright/author

[PATCH 7/7] docs/devel/lockcnt: Include kernel-doc API documentation

2024-08-16 Thread Peter Maydell
Pull in the kernel-doc API documentation into the lockcnt docs. This requires us to fix one rST markup syntax error in the header file comments. Signed-off-by: Peter Maydell --- docs/devel/lockcnt.rst | 2 +- include/qemu/lockcnt.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH 3/7] docs/devel/lockcnt: Convert to rST format

2024-08-16 Thread Peter Maydell
Convert docs/devel/lockcnt.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 2 +- docs/devel/index-api.rst| 1 + docs/devel/{lockcnt.txt => lockcnt.rst} | 89 + 3 files changed, 47 insertions(+), 45 deletions(

[PATCH 5/7] docs/devel/rcu: Convert to rST format

2024-08-16 Thread Peter Maydell
Convert docs/devel/rcu.txt to rST format. Signed-off-by: Peter Maydell --- MAINTAINERS | 2 +- docs/devel/index-internals.rst | 1 + docs/devel/{rcu.txt => rcu.rst} | 172 +++- 3 files changed, 82 insertions(+), 93 deletions(-) rename docs/de

[PATCH 4/7] docs/devel/multiple-iothreads: Convert to rST format

2024-08-16 Thread Peter Maydell
Convert docs/devel/multiple-iothreads.txt to rST format. Signed-off-by: Peter Maydell --- docs/devel/index-internals.rst| 1 + docs/devel/multiple-iothreads.rst | 139 ++ docs/devel/multiple-iothreads.txt | 130 3 files changed, 140

[PATCH 1/7] docs/devel/blkdebug: Convert to rST format

2024-08-16 Thread Peter Maydell
Convert blkdebug.txt to rST format. We put it into index-build.rst because it falls under the "test" part of "QEMU Build and Test System". Signed-off-by: Peter Maydell --- At least, index-build seemed the most plausible home to me... --- MAINTAINERS| 1 + docs/devel/blkdebug.r

[PATCH for-9.2] docs/devel: Remove nested-papr.txt

2024-08-16 Thread Peter Maydell
docs/devel/nested-papr.txt is entirely (apart from the initial paragraph) a partial copy of the kernel documentation https://docs.kernel.org/arch/powerpc/kvm-nested.html There's no benefit to the QEMU docs to converting this to rST, so instead delete it. Anybody needing to know the API and protoco

Re: [PATCH v3 4/5] machine/nitro-enclave: Add built-in Nitro Secure Module device

2024-08-16 Thread Dorjoy Chowdhury
On Fri, Aug 16, 2024 at 6:58 PM Daniel P. Berrangé wrote: > > On Fri, Aug 16, 2024 at 06:50:34PM +0600, Dorjoy Chowdhury wrote: > > Hi Daniel, > > > > On Mon, Aug 12, 2024 at 8:07 PM Daniel P. Berrangé > > wrote: > > > > > > On Sat, Aug 10, 2024 at 10:45:01PM +0600, Dorjoy Chowdhury wrote: > > >

Re: [PATCH 2/6] contrib/plugins/cache: fix warning when compiling on 32bits host

2024-08-16 Thread Peter Maydell
On Fri, 16 Aug 2024 at 13:48, Alex Bennée wrote: > > Richard Henderson writes: > > > On 8/15/24 21:46, Alex Bennée wrote: > >> Thomas Huth writes: > >> > >>> On 15/08/2024 01.36, Pierrick Bouvier wrote: > Found on debian stable (i386). > ../contrib/plugins/cache.c: In function 'vcpu_tb

Re: [PATCH V2 06/11] migration: fix mismatched GPAs during cpr

2024-08-16 Thread Peter Xu
On Thu, Aug 15, 2024 at 04:54:58PM -0400, Steven Sistare wrote: > On 8/13/2024 4:43 PM, Peter Xu wrote: > > On Wed, Aug 07, 2024 at 05:04:26PM -0400, Steven Sistare wrote: > > > On 7/19/2024 12:28 PM, Peter Xu wrote: > > > > On Sun, Jun 30, 2024 at 12:40:29PM -0700, Steve Sistare wrote: > > > > > F

Re: [PATCH v2 3/9] tests/avocado: add cdrom permission related tests

2024-08-16 Thread Thomas Huth
On 06/08/2024 19.31, Cleber Rosa wrote: The "media=cdrom" parameter is also used on some Avocado tests as a way to protect files from being written. The tests here bring a more fundamental check that this behavior can be trusted. Signed-off-by: Cleber Rosa --- tests/avocado/cdrom.py | 41 +++

  1   2   >