On 15/8/24 17:06, Daniel P. Berrangé wrote:
On Thu, Aug 15, 2024 at 04:01:17PM +0200, Philippe Mathieu-Daudé wrote:Hi Manos,On 15/8/24 13:42, Manos Pitsidianakis wrote:Add rust/qemu-api, which exposes rust-bindgen generated FFI bindings and provides some declaration macros for symbols visible to the rest of QEMU. Co-authored-by: Junjie Mao <junjie....@intel.com> Co-authored-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Junjie Mao <junjie....@intel.com> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> Signed-off-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org> --- MAINTAINERS | 6 ++ rust/meson.build | 9 +++ rust/qemu-api/.gitignore | 2 + rust/qemu-api/Cargo.lock | 7 +++ rust/qemu-api/Cargo.toml | 23 +++++++ rust/qemu-api/README.md | 17 +++++ rust/qemu-api/build.rs | 13 ++++ rust/qemu-api/meson.build | 17 +++++ rust/qemu-api/rustfmt.toml | 1 + rust/qemu-api/src/bindings.rs | 7 +++ rust/qemu-api/src/definitions.rs | 108 ++++++++++++++++++++++++++++++++ rust/qemu-api/src/device_class.rs | 128 ++++++++++++++++++++++++++++++++++++++ rust/qemu-api/src/lib.rs | 100 +++++++++++++++++++++++++++++ rust/qemu-api/src/tests.rs | 48 ++++++++++++++ rust/rustfmt.toml | 7 +++ 15 files changed, 493 insertions(+)diff --git a/rust/qemu-api/Cargo.toml b/rust/qemu-api/Cargo.toml new file mode 100644 index 0000000000..51260cbe42 --- /dev/null +++ b/rust/qemu-api/Cargo.toml @@ -0,0 +1,23 @@ +[package] +name = "qemu_api" +version = "0.1.0" +edition = "2021"+license = "GPL-2.0 OR GPL-3.0-or-later"in particular explaining the license choice.Semantically this is an overly verbose way of saying "GPL-2.0-or-later", so just simplify this.
Indeed. Manos, please use GPL-2.0-or-later to keep it simple.
Should all rust code use it?GPL-2.0-or-later is what we expect all new QEMU contributions to be licensed as, regardless of language[1], so this looks desirable.
Agreed.
With regards,
Daniel
[1] unless they're derived from one of the few pieces of code under
different terms
