On Fri, Aug 16, 2024 at 12:23:50PM +1000, Nicholas Piggin wrote: > On Fri Aug 16, 2024 at 1:30 AM AEST, Michael S. Tsirkin wrote: > > On Thu, Aug 15, 2024 at 11:28:35PM +1000, Nicholas Piggin wrote: > > > Continuing the conversation from the thread about record/replay > > > virtio fix. Here is a sketch of how we could improve the naming > > > convention so users of bh don't have to know about record/replay. > > > > > > Thanks, > > > Nick > > > > The API looks ok to me. > > Thanks for taking a look. In that case let's go with the fixes for > now so we have rr regression tests in a bit better state, and I will > resend for 9.2. > > Thanks, > Nick
No, this is big because you are structuring this wrong. Work, then rework ... I do not really like this kind of thing. Add sane APIs and use them keeping old ones around, reworking old code can wait for 9.2. -- MST