Hi
On Wed, Jun 5, 2024 at 7:30 PM Weifeng Liu wrote:
> The stride is not correctly assigned when copying pixel data, causing
> images being displayed incomplete when using 2d component of rutabaga.
>
> Signed-off-by: Weifeng Liu
> ---
> hw/display/virtio-gpu-rutabaga.c | 3 +++
> 1 file change
On Mon, Jun 10, 2024 at 08:39:24AM +0200, Philippe Mathieu-Daudé wrote:
> hmp_info_roms() was removed in commit dd98234c05 ("qapi:
> introduce x-query-roms QMP command"),
>
> hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce
> x-query-numa QMP command"),
>
> hmp_info_ramblock() in commit ca4
On 6/10/24 8:20 AM, Philippe Mathieu-Daudé wrote:
Hi,
This series remove uses of Monitor in hw/ppc/,
replacing by the more generic HumanReadableText.
Care is taken to keep the commit bisectables by
updating functions one by one, also easing review.
For rationale see previous series from Daniel:
On 6/10/24 8:20 AM, Philippe Mathieu-Daudé wrote:
Hi,
This series remove uses of Monitor in hw/ppc/,
replacing by the more generic HumanReadableText.
Care is taken to keep the commit bisectables by
updating functions one by one, also easing review.
Did you do any testing ? POWER[8-10] CPUs on
On Mon, Jun 10, 2024 at 08:38:47AM +0200, Philippe Mathieu-Daudé wrote:
> This is a counterpart to the HMP "info usbhost" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured da
On Mon, Jun 10, 2024 at 08:35:17AM +0200, Philippe Mathieu-Daudé wrote:
> This is a counterpart to the HMP "info pic" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured data,
On Mon, Jun 10, 2024 at 08:35:16AM +0200, Philippe Mathieu-Daudé wrote:
> Replace Monitor API by HumanReadableText one (see commit f2de406f29
> "docs/devel: document expectations for QAPI data modelling for QMP"
> for rationale).
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/intc/
On Sun, 9 Jun 2024 at 11:00, Akihiko Odaki wrote:
>
> On 2024/06/09 5:20, Phil Dennis-Jordan wrote:
> > Both hw/input/hid.c and hw/usb/dev-wacom.c define identical versions
> > (aside from code formatting) of a clamping function, int_clamp().
> > (marked inline) To avoid duplication and to enable
On 2024/06/10 17:50, Phil Dennis-Jordan wrote:
On Sun, 9 Jun 2024 at 11:00, Akihiko Odaki wrote:
On 2024/06/09 5:20, Phil Dennis-Jordan wrote:
Both hw/input/hid.c and hw/usb/dev-wacom.c define identical versions
(aside from code formatting) of a clamping function, int_clamp().
(marked inline)
On Thu, Jun 06, 2024 at 10:14:18AM +0530, Ani Sinha wrote:
> Added a new test api qtest_has_cpu() in order to check availability of some
> cpu models in the current QEMU binary. The specific architecture of the QEMU
> binary is selected using the QTEST_QEMU_BINARY environment variable. This api
> w
On Thu, Jun 06, 2024 at 10:14:19AM +0530, Ani Sinha wrote:
> It is better to check if some older cpu models like 486, athlon, pentium,
> penryn, phenom, core2duo etc are available before running their corresponding
> tests. Some downstream distributions may no longer support these older cpu
> model
On Fri, Jun 07, 2024 at 08:02:51AM +0200, Philippe Mathieu-Daudé wrote:
> Hi Don,
>
> (Cc'ing Daniel for HumanReadableText)
>
> On 6/6/24 16:02, Don Porter wrote:
> > Signed-off-by: Don Porter
> > ---
> > include/hw/core/sysemu-cpu-ops.h | 7 +
> > monitor/hmp-cmds-target.c| 1 +
>
On Thu, Jun 06, 2024 at 10:02:50AM -0400, Don Porter wrote:
> Signed-off-by: Don Porter
> ---
> include/hw/core/sysemu-cpu-ops.h | 6 +
> include/monitor/monitor.h| 4 +
> monitor/hmp-cmds-target.c| 5 +-
> target/i386/cpu.c| 1 +
> target/i386/cpu.h
On 6/4/24 7:44 AM, Jamin Lin wrote:
Changes from v1:
The patch series supports WDT, SDMC, SMC, SCU, SLI and INTC for AST2700 SoC.
Changes from v2:
- replace is_aarch64 with is_bus64bit for sdmc patch review.
- fix incorrect dram size for AST2700
Changes from v3:
- Add AST2700 Evaluation board i
On 6/5/24 8:03 AM, Jamin Lin wrote:
Add ASPEED members "Steven Lee", "Troy Lee" and "Jamin Lin"
to be reviewers of ASPEED BMCs.
Signed-off-by: Jamin Lin
Signed-off-by: Troy Lee
Signed-off-by: Steven Lee
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
Applied to aspeed-next.
Tha
On 5/27/24 2:43 PM, Cédric Le Goater wrote:
The Aspeed SMC device model use to have a 'sdram_base' property. It
was removed by commit d177892d4a48 ("aspeed/smc: Remove unused
"sdram-base" property") because previous changes simplified the DMA
transaction model to use an offset in RAM and not the
Philippe Mathieu-Daudé writes:
> On 7/6/24 13:08, Anton Johansson wrote:
>> On 30/05/24, Philippe Mathieu-Daudé wrote:
>>> Semihosting currently uses the TCG probe_access API. To prepare for
>>> encoding the TCG dependency in Kconfig, do not enable it unless TCG
>>> is available.
>>>
>>> Suggeste
Daniel P. Berrangé (2):
crypto: avoid leak of ctx when bad cipher mode is given
crypto: use consistent error reporting pattern for unsupported cipher
modes
crypto/cipher-nettle.c.inc | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
--
2.45.1
This fixes Coverity CID-1546884
Signed-off-by: Daniel P. Berrangé
---
crypto/cipher-nettle.c.inc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/crypto/cipher-nettle.c.inc b/crypto/cipher-nettle.c.inc
index 42b39e18a2..766de036ba 100644
--- a/crypto/cipher-nettle.c.inc
Not all paths in qcrypto_cipher_ctx_new() were correctly distinguishing
between valid user input for cipher mode (which should report a user
facing error), vs program logic errors (which should assert).
Reported-by: Peter Maydell
Signed-off-by: Daniel P. Berrangé
---
crypto/cipher-nettle.c.inc
On Mon, 10 Jun 2024 at 10:42, Daniel P. Berrangé wrote:
>
> This fixes Coverity CID-1546884
>
> Signed-off-by: Daniel P. Berrangé
Reviewed-by: Peter Maydell
thanks
-- PMM
On 6/3/24 12:19 PM, Andrey Drobyshev wrote:
> On 5/13/24 9:31 AM, Andrey Drobyshev wrote:
>> v1: https://lists.nongnu.org/archive/html/qemu-devel/2023-10/msg07223.html
>>
>> Andrey Drobyshev (11):
>> qcow2: make function update_refcount_discard() global
>> qcow2: simplify L2 entries accounting
On Mon, 10 Jun 2024 at 06:29, Sebastian Huber
wrote:
>
> Fix the system bus interrupt line to CPU core assignment.
>
> Signed-off-by: Sebastian Huber
> ---
> hw/arm/xilinx_zynq.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zy
Hi,
The KVM/QEMU community call is at:
https://meet.jit.si/kvmcallmeeting
@
11/6/2024 14:00 UTC
Are there any agenda items for the sync-up?
One that has been suggested is looking at the current Rust proposals:
https://wiki.qemu.org/RustInQemu
And discussing what we want to see for s
Ping
Am 21.05.24 um 14:20 schrieb Fiona Ebner:
> Changes from v3 (discussion here [3]):
> * Improve/fix QAPI documentation.
>
> Changes from v2 (discussion here [2]):
> * Cluster size caveats only apply to non-COW diff image, adapt the
> cluster size check and documentation accordingly.
> * In
On Thu, Jun 06, 2024 at 01:22:14PM -0400, John Snow wrote:
> On Thu, Jun 6, 2024 at 6:25 AM Victor Toso wrote:
> > On Wed, Jun 05, 2024 at 11:47:53AM GMT, John Snow wrote:
> Importantly, old versions of the schema aren't contained *entirely* within
> the schema. Here's a timeline:
>
> v0.12.0: QM
Gonglei writes:
> From: Jialin Wang
>
> The new RDMA live migration will be introduced in the upcoming
> few commits.
>
> Signed-off-by: Jialin Wang
> Signed-off-by: Gonglei
[...]
> diff --git a/qapi/migration.json b/qapi/migration.json
> index a351fd3714..4d7d49bfec 100644
> --- a/qapi/migr
Hi Fea,
On 4/6/24 09:15, Fea.Wang wrote:
Due to a description loading failure, adding a trace log makes observing
the DMA behavior easy.
Signed-off-by: Fea.Wang
Reviewed-by: Edgar E. Iglesias
Reviewed-by: Frank Chang
---
hw/dma/trace-events| 3 +++
hw/dma/xilinx_axidma.c | 3 +++
2 f
On 10/6/24 11:40, Daniel P. Berrangé wrote:
This fixes Coverity CID-1546884
Signed-off-by: Daniel P. Berrangé
---
crypto/cipher-nettle.c.inc | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé
Am 05.06.2024 um 02:58 hat Amjad Alsharafi geschrieben:
> Added several tests to verify the implementation of the vvfat driver.
>
> We needed a way to interact with it, so created a basic `fat16.py` driver
> that handled writing correct sectors for us.
>
> Added `vvfat` to the non-generic format
On Fri, Jun 07, 2024 at 10:12:02PM GMT, Michael Tokarev wrote:
> The following patches are queued for QEMU stable v7.2.12:
>
> https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2
>
> Patch freeze is 2024-06-07 (frozen), and the release is planned for
> 2024-06-09:
>
> https://wiki.qe
10.06.2024 15:17, Eric Blake wrote:
01* 690ceb71936f Philippe Mathieu-Daudé:
gitlab-ci: Remove job building EDK2 firmware binaries
02* 7bc1286b81d4 Palmer Dabbelt:
gitlab/opensbi: Move to docker:stable
03* 04f6fb897a5a Michael Tokarev:
linux-user: do_setsockopt: fix SOL_ALG.ALG_SET_KE
On Mon, Jun 10, 2024 at 07:17:53AM GMT, Eric Blake wrote:
> On Fri, Jun 07, 2024 at 10:12:02PM GMT, Michael Tokarev wrote:
> > The following patches are queued for QEMU stable v7.2.12:
> >
> > https://gitlab.com/qemu-project/qemu/-/commits/staging-7.2
> >
> > Patch freeze is 2024-06-07 (frozen)
On Tue, 4 Jun 2024 at 15:59, Peter Maydell wrote:
>
> Since commit 83aa1baa069c we have been running the build for Coverity
> Scan as a Gitlab CI job, rather than the old setup where it was run
> on a local developer's machine. This is working well, but the
> absolute paths of files are different
On Sat, Jun 08, 2024 at 11:36:59AM GMT, Alexander Ivanov wrote:
> There is a bug reproducer in the attachment.
Summarizing the reproducer, you are repeatedly calling QMP
nbd-server-start/nbd-server-stop on qemu as NBD server in one thread,
and repeatedly calling 'qemu-nbd -L' in another, to try an
On Mon, Jun 10, 2024 at 03:20:53PM GMT, Michael Tokarev wrote:
> 10.06.2024 15:17, Eric Blake wrote:
> > > 01* 690ceb71936f Philippe Mathieu-Daudé:
> > > gitlab-ci: Remove job building EDK2 firmware binaries
> > > 02* 7bc1286b81d4 Palmer Dabbelt:
> > > gitlab/opensbi: Move to docker:stable
On 6/10/24 14:33, Eric Blake wrote:
On Sat, Jun 08, 2024 at 11:36:59AM GMT, Alexander Ivanov wrote:
There is a bug reproducer in the attachment.
Summarizing the reproducer, you are repeatedly calling QMP
nbd-server-start/nbd-server-stop on qemu as NBD server in one thread,
and repeatedly cal
* Philippe Mathieu-Daudé (phi...@linaro.org) wrote:
> hmp_info_roms() was removed in commit dd98234c05 ("qapi:
> introduce x-query-roms QMP command"),
>
> hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce
> x-query-numa QMP command"),
>
> hmp_info_ramblock() in commit ca411b7c8a ("qapi: intr
Added a new test api qtest_has_cpu() in order to check availability of some
cpu models in the current QEMU binary. The specific architecture of the QEMU
binary is selected using the QTEST_QEMU_BINARY environment variable. This api
would be useful to run tests against some older cpu models after che
Daniel P. Berrangé writes:
> On Thu, Jun 06, 2024 at 01:22:14PM -0400, John Snow wrote:
>> On Thu, Jun 6, 2024 at 6:25 AM Victor Toso wrote:
>> > On Wed, Jun 05, 2024 at 11:47:53AM GMT, John Snow wrote:
>> Importantly, old versions of the schema aren't contained *entirely* within
>> the schema.
Daniel P. Berrangé writes:
> This fixes Coverity CID-1546884
We usually say
Fixes: Coverity CID 1546884
> Signed-off-by: Daniel P. Berrangé
On Sun, 9 Jun 2024 at 11:06, Akihiko Odaki wrote:
> Thanks for working on ui/cocoa, but I already have submitted a patch for
> this particular problem:
> https://patchew.org/QEMU/20240318-cursor-v1-0-0bbe6c382...@daynix.com/
>
Sorry, I missed this patch set - thanks for bringing it to my attenti
On Mon, Jun 10, 2024 at 02:01:24PM +0200, Kevin Wolf wrote:
> Am 05.06.2024 um 02:58 hat Amjad Alsharafi geschrieben:
> > Added several tests to verify the implementation of the vvfat driver.
> >
> > We needed a way to interact with it, so created a basic `fat16.py` driver
> > that handled writin
Thanks Jason for your review.
On Tue, Jun 4, 2024 at 11:14 AM Jason Chien wrote:
>
>
> Rajnesh Kanwal 於 2024/5/30 上午 12:09 寫道:
>
> This commit adds support for [m|s|vs]ctrcontrol, sctrstatus and
> sctrdepth CSRs handling.
>
> Signed-off-by: Rajnesh Kanwal
> ---
> target/riscv/cpu.h | 5 ++
On Thu, Jun 06, 2024 at 12:26:31PM +0200, Philippe Mathieu-Daudé wrote:
> vcpu.py is pointless since commit 89aafcf2a7 ("trace:
> remove code that depends on setting vcpu"), remote it.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> meson.build | 1 -
> scripts/tracetool/__i
Hi Ani,
On 10/6/24 15:21, Ani Sinha wrote:
Added a new test api qtest_has_cpu() in order to check availability of some
cpu models in the current QEMU binary. The specific architecture of the QEMU
binary is selected using the QTEST_QEMU_BINARY environment variable. This api
would be useful to run
This tool converts a disk image to qcow2, writing the result directly
to stdout. This can be used for example to send the generated file
over the network.
This is equivalent to using qemu-img to convert a file to qcow2 and
then writing the result to stdout, with the difference that this tool
does
On 10/6/24 11:29, Alex Bennée wrote:
Philippe Mathieu-Daudé writes:
On 7/6/24 13:08, Anton Johansson wrote:
On 30/05/24, Philippe Mathieu-Daudé wrote:
Semihosting currently uses the TCG probe_access API. To prepare for
encoding the TCG dependency in Kconfig, do not enable it unless TCG
is av
v3: Address Anton's comment
v2: Address Paolo's comment
Semihosting currently uses the TCG probe_access API,
so it is pointless to have it in the binary when TCG
isn't.
It could be implemented for other accelerators, but
work need to be done. Meanwhile, do not enable it
unless TCG is available.
The semihosting feature depends on TCG (due to the probe_access
API access). Although TCG is the single accelerator currently
available for the m68k target, use the Kconfig "imply" directive
which is more correct (if we were to support a different accel).
Reported-by: Anton Johansson
Signed-off-b
Semihosting currently uses the TCG probe_access API.
It is pointless to have it in the binary when TCG isn't.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
semihosting/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/semihosting/Kconfig b/semihosting/Kconfi
Semihosting currently uses the TCG probe_access API. To prepare for
encoding the TCG dependency in Kconfig, do not enable it unless TCG
is available.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anton Johansson
---
target/riscv/Kconfig | 4 ++--
1 file changed
The semihosting feature depends on TCG (due to the probe_access
API access). Although TCG is the single accelerator currently
available for the xtensa target, use the Kconfig "imply" directive
which is more correct (if we were to support a different accel).
Reported-by: Anton Johansson
Signed-off
Semihosting currently uses the TCG probe_access API. To prepare for
encoding the TCG dependency in Kconfig, do not enable it unless TCG
is available.
Suggested-by: Paolo Bonzini
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Anton Johansson
---
target/mips/Kconfig | 2 +-
1 file changed, 1
Register the command 'info via' using HMPCommand::cmd_info_hrt(),
so it is processed using the generic hmp_info_human_readable_text().
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/misc/mos6522.h| 2 --
include/monitor/hmp-target.h | 1 -
hw/misc/mos6522.c| 13 --
This is a counterpart to the HMP "info via" command. It is being
added with an "x-" prefix because this QMP command is intended as an
adhoc debugging tool and will thus not be modelled in QAPI as fully
structured data, nor will it have long term guaranteed stability.
Signed-off-by: Philippe Mathie
Officialise the QMP command, use the existing
hmp_info_human_readable_text() helper.
Philippe Mathieu-Daudé (2):
hw/misc/mos6522: Expose x-query-mos6522-devices QMP command
hw/misc/mos6522: Do not open-code hmp_info_human_readable_text()
MAINTAINERS | 2 +-
qapi/machine.jso
On Mon, Jun 10, 2024 at 9:39 AM Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Thu, Jun 06, 2024 at 01:22:14PM -0400, John Snow wrote:
> >> On Thu, Jun 6, 2024 at 6:25 AM Victor Toso
> wrote:
> >> > On Wed, Jun 05, 2024 at 11:47:53AM GMT, John Snow wrote:
> >> Importantly, old v
Add a new library api to check for the support of a specific cpu type.
Used the new api to check support for some older x86 cpu models before
running the tests.
CC: th...@redhat.com
CC: imamm...@redhat.com
CC: qemu-devel@nongnu.org
CC: pbonz...@redhat.com
CC: lviv...@redhat.com
CC: m...@redhat.com
'pentium' cpu is old and obsolete and should be avoided for running tests if
its not strictly needed. Use 'max' cpu instead for generic non-cpu specific
numa test.
CC: th...@redhat.com
Reviewed-by: Thomas Huth
Reviewed-by: Igor Mammedov
Signed-off-by: Ani Sinha
---
tests/qtest/numa-test.c | 3
Added a new test api qtest_has_cpu_model() in order to check availability of
some cpu models in the current QEMU binary. The specific architecture of the
QEMU binary is selected using the QTEST_QEMU_BINARY environment variable.
This api would be useful to run tests against some older cpu models aft
It is better to check if some older cpu models like 486, athlon, pentium,
penryn, phenom, core2duo etc are available before running their corresponding
tests. Some downstream distributions may no longer support these older cpu
models.
Signature of add_feature_test() has been modified to return voi
On Fri, Jun 07, 2024 at 03:42:35PM -0300, Fabiano Rosas wrote:
> Peter Xu writes:
>
> > On Thu, May 23, 2024 at 04:05:48PM -0300, Fabiano Rosas wrote:
> >> We've recently added support for direct-io with multifd, which brings
> >> performance benefits, but creates a non-uniform user interface by
This is v2 of a series I posted back in October last year:
https://patchew.org/QEMU/20231023161532.2729084-1-peter.mayd...@linaro.org/
At the time I wanted to wait until EDK2 had been updated so it
didn't behave weirdly in the presence of a second UART. That
happened at the tail end of last year,
For some use-cases, it is helpful to have more than one UART
available to the guest. If the second UART slot is not already used
for a TrustZone Secure-World-only UART, create it as a NonSecure UART
only when the user provides a serial backend (e.g. via a second
-serial command line option).
Thi
We're going to make the second UART not always a secure-only device.
Rename the constants VIRT_UART and VIRT_SECURE_UART to VIRT_UART0
and VIRT_UART1 accordingly.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
include/hw/arm/virt.h| 4 ++--
hw/arm/virt-acpi-build.c |
If there is more than one UART in the DTB, then there is no guarantee
on which order a guest is supposed to initialise them. The standard
solution to this is "serialN" entries in the "/aliases" node of the
dtb which give the nodename of the UARTs.
At the moment we only have two UARTs in the DTB w
On Fri, Jun 07, 2024 at 08:28:29AM +, Gonglei (Arei) wrote:
>
>
> > -Original Message-
> > From: Jinpu Wang [mailto:jinpu.w...@ionos.com]
> > Sent: Friday, June 7, 2024 1:54 PM
> > To: Gonglei (Arei)
> > Cc: qemu-devel@nongnu.org; pet...@redhat.com; yu.zh...@ionos.com;
> > mgal...@ak
On Fri, Jun 07, 2024 at 08:49:01AM +, Gonglei (Arei) wrote:
> Actually we tried this solution, but it didn't work. Pls see patch 3/6
>
> Known limitations:
> For a blocking rsocket fd, if we use io_create_watch to wait for
> POLLIN or POLLOUT events, since the rsocket fd is blocking, we
>
Am 05.06.2024 um 02:58 hat Amjad Alsharafi geschrieben:
> The field is marked as "the offset in the file (in clusters)", but it
> was being used like this
> `cluster_size*(nums)+mapping->info.file.offset`, which is incorrect.
>
> Additionally, removed the `abort` when `first_mapping_index` does no
Am 10.06.2024 um 16:11 hat Amjad Alsharafi geschrieben:
> On Mon, Jun 10, 2024 at 02:01:24PM +0200, Kevin Wolf wrote:
> > With the updated test, I can catch the problems that are fixed by
> > patches 1 and 2, but it still doesn't need patch 3 to pass.
> >
> > Kevin
> >
>
> Thanks for reviewing,
On 6/7/24 5:10 PM, Joao Martins wrote:
On 06/06/2024 16:43, Cédric Le Goater wrote:
Hello Joao,
On 6/22/23 23:48, Joao Martins wrote:
Hey,
This series introduces support for vIOMMU with VFIO device migration,
particurlarly related to how we do the dirty page tracking.
Today vIOMMUs serve two
From: Hyman Huang
For VMs configured with the USB CDROM device:
-drive file=/path/to/local/file,id=drive-usb-disk0,media=cdrom,readonly=on...
-device usb-storage,drive=drive-usb-disk0,id=usb-disk0...
QEMU process may crash after live migration, to reproduce the issue,
configure VM (Guest OS ubu
On Thu, Jun 06, 2024 at 12:39:38PM +0200, Philippe Mathieu-Daudé wrote:
> Trace events aren't designed to be multi-lines.
> Few format use the newline character: remove it
> and forbid further uses.
>
> Philippe Mathieu-Daudé (5):
> backends/tpm: Remove newline character in trace event
> hw/sh
On Mon, Jun 10, 2024 at 05:07:57PM +0200, Philippe Mathieu-Daudé wrote:
> This is a counterpart to the HMP "info via" command. It is being
> added with an "x-" prefix because this QMP command is intended as an
> adhoc debugging tool and will thus not be modelled in QAPI as fully
> structured data,
On Mon, Jun 10, 2024 at 05:07:58PM +0200, Philippe Mathieu-Daudé wrote:
> Register the command 'info via' using HMPCommand::cmd_info_hrt(),
> so it is processed using the generic hmp_info_human_readable_text().
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/misc/mos6522.h| 2 -
On Sat, Jun 8, 2024 at 10:16 PM Richard Henderson
wrote:
>
> On 6/8/24 01:41, Paolo Bonzini wrote:
> > It is already checked before getting there.
> >
> > Signed-off-by: Paolo Bonzini
> > ---
> > target/i386/tcg/translate.c | 26 --
> > 1 file changed, 8 insertions(+), 1
The following changes since commit 80e8f0602168f451a93e71cbb1d59e93d745e62e:
Merge tag 'bsd-user-misc-2024q2-pull-request' of gitlab.com:bsdimp/qemu into
staging (2024-06-09 11:21:55 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/tracing-pull-reques
From: Philippe Mathieu-Daudé
vcpu.py is pointless since commit 89aafcf2a7 ("trace:
remove code that depends on setting vcpu"), remote it.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Zhao Liu
Message-id: 20240606102631.78152-1-phi...@linaro.org
Signed-off
From: Philippe Mathieu-Daudé
Split the 'tpm_util_show_buffer' event in two to avoid
using a newline character.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Mads Ynddal
Reviewed-by: Daniel P. Berrangé
Reviewed-by: Stefan Berger
Message-id: 20240606103943.79116-2-phi...@linaro.org
Signed-of
From: Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines. Remove
the newline character which doesn't bring much value.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Mads Ynddal
Reviewed-by: Daniel P. Berrangé
Message-id: 20240606103943.79116-3-phi...@linaro.org
Signed-off
On Sat, Jun 8, 2024 at 8:46 PM Richard Henderson
wrote:
>
> On 6/8/24 01:40, Paolo Bonzini wrote:
> > All other control registers are stored plainly in CPUX86State.
>
> s/stored/read/
I mean the CPUX86State is their storage and it's plain. :)
Paolo
>
> Reviewed-by: Richard Henderson
>
>
> r~
>
From: Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines.
Remove the newline characters.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Mads Ynddal
Reviewed-by: Daniel P. Berrangé
Message-id: 20240606103943.79116-4-phi...@linaro.org
Signed-off-by: Stefan Hajnoczi
---
hw/
From: Philippe Mathieu-Daudé
Events aren't designed to be multi-lines. Multiple events
can be used instead. Prevent that format using multi-lines
by forbidding the newline character.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Mads Ynddal
Reviewed-by: Daniel P. Berrangé
Message-id: 202406
From: Philippe Mathieu-Daudé
Trace events aren't designed to be multi-lines.
Remove the newline characters.
Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Mads Ynddal
Reviewed-by: Daniel P. Berrangé
Message-id: 20240606103943.79116-5-phi...@linaro.org
Signed-off-by: Stefan Hajnoczi
---
hw/
On Thu, Jun 06, 2024 at 08:24:34PM +0800, Changqi Lu wrote:
> Hi,
>
> patchv5 has been modified.
>
> Sincerely hope that everyone can help review the
> code and provide some suggestions.
>
> v4->v5:
> - Fixed a memory leak bug at hw/nvme/ctrl.c.
>
> v3->v4:
> - At the nvme layer, the two patch
On Thu, Jun 06, 2024 at 08:24:35PM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations
> at the block level. The following operations
> are included:
>
> - read_keys:retrieves the list of registered keys.
> - read_reservation: retrieves the current reservation status.
>
Peter Xu writes:
> On Fri, Jun 07, 2024 at 03:42:35PM -0300, Fabiano Rosas wrote:
>> Peter Xu writes:
>>
>> > On Thu, May 23, 2024 at 04:05:48PM -0300, Fabiano Rosas wrote:
>> >> We've recently added support for direct-io with multifd, which brings
>> >> performance benefits, but creates a non-
Hi Igor,
Some code snippets below to try and see if I'm on the correct track
for what you had in mind.
> >
> > > diff --git a/hw/acpi/acpi_generic_initiator.c
> > > b/hw/acpi/acpi_generic_initiator.c
> > > index 78b80dcf08..f064753b67 100644
> > > --- a/hw/acpi/acpi_generic_initiator.c
> >
Current HMPCommand::cmd_info_hrt() handlers don't allow
passing arguments from the monitor. This series pass them
to the underlying QMP commands as a JSON dictionary,
easily deserialized as QDict, similarly to how current
HMP commands receive their arguments. Thus very few
changes are required to p
This is a counterpart to the HMP "info cmma" command. It is being
added with an "x-" prefix because this QMP command is intended as an
adhoc debugging tool and will thus not be modelled in QAPI as fully
structured data, nor will it have long term guaranteed stability.
The existing HMP command is re
On 10/6/24 19:05, Stefan Hajnoczi wrote:
On Thu, Jun 06, 2024 at 12:39:38PM +0200, Philippe Mathieu-Daudé wrote:
Trace events aren't designed to be multi-lines.
Few format use the newline character: remove it
and forbid further uses.
Philippe Mathieu-Daudé (5):
backends/tpm: Remove newline c
Allow HMP commands implemented using the HumanReadableText API
(via the HMPCommand::cmd_info_hrt handler) to pass arguments
to the QMP equivalent command. The arguments are serialized as
a JSON dictionary.
Signed-off-by: Philippe Mathieu-Daudé
---
docs/devel/writing-monitor-commands.rst | 15 +++
"monitor/hmp-target.h" is meant to hold target-specific commands.
Move s390x specific commands there, slightly simplifying hmp-target.c.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/s390x/storage-attributes.h | 4
include/hw/s390x/storage-keys.h | 4
include/monitor/hmp-t
Hello everyone,
This is an early draft of my work on implementing a very simple device,
in this case the ARM PL011 (which in C code resides in hw/char/pl011.c
and is used in hw/arm/virt.c).
The device is functional, with copied logic from the C code but with
effort not to make a direct C to Ru
Add options for Rust in meson_options.txt, meson.build, configure to
prepare for adding Rust code in the followup commits.
`rust` is a reserved meson name, so we have to use an alternative.
`with_rust` was chosen.
Signed-off-by: Manos Pitsidianakis
---
The cargo wrapper script hardcodes some rus
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 55 +-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 91c57efded..1cd6519506 100644
--- a/.gitlab-ci.d/buildtest.y
Signed-off-by: Manos Pitsidianakis
---
.gitlab-ci.d/buildtest.yml | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 1cd6519506..da882813b8 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buil
Signed-off-by: Manos Pitsidianakis
---
hw/arm/virt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 3c93c0c0a6..153be0f42d 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -912,7 +912,7 @@ static void create_uart(const VirtMachineState *vm
On Mon, Jun 10, 2024 at 07:58:51PM +0200, Philippe Mathieu-Daudé wrote:
> Allow HMP commands implemented using the HumanReadableText API
> (via the HMPCommand::cmd_info_hrt handler) to pass arguments
> to the QMP equivalent command. The arguments are serialized as
> a JSON dictionary.
>
> Signed-o
1 - 100 of 147 matches
Mail list logo
