On Thu, Jun 06, 2024 at 10:14:19AM +0530, Ani Sinha wrote: > It is better to check if some older cpu models like 486, athlon, pentium, > penryn, phenom, core2duo etc are available before running their corresponding > tests. Some downstream distributions may no longer support these older cpu > models. > > Signature of add_feature_test() has been modified to return void as > FeatureTestArgs* was not used by the caller. > > One minor correction. Replaced 'phenom' with '486' in the test > 'x86/cpuid/auto-level/phenom/arat' matching the cpu used. > > CC: th...@redhat.com > CC: imamm...@redhat.com > Signed-off-by: Ani Sinha <anisi...@redhat.com> > --- > tests/qtest/test-x86-cpuid-compat.c | 170 ++++++++++++++++++---------- > 1 file changed, 108 insertions(+), 62 deletions(-) > > changelog: > v2: reworked as per suggestion from danpb. > v3: reworked as_feature_test() same way as add_cpuid_test() >
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
