[PATCH v2 2/2] vhost-user: fix lost reconnect again

When the vhost-user is reconnecting to the backend, and if the vhost-user fails at the get_features in vhost_dev_init(), then the reconnect will fail and it will not be retriggered forever. The reason is: When the vhost-user fail at get_features, the vhost_dev_cleanup will be called immediately.

[PATCH v2 1/2] Revert "vhost-user: fix lost reconnect"

This reverts commit f02a4b8e6431598612466f76aac64ab492849abf. Signed-off-by: Li Feng --- hw/block/vhost-user-blk.c | 2 +- hw/scsi/vhost-user-scsi.c | 3 +-- hw/virtio/vhost-user-base.c| 2 +- hw/virtio/vhost-user.c | 10 ++ include/hw/virtio/vhost-user.h | 3 +-

Re: [PATCH v2 1/2] Revert "vhost-user: fix lost reconnect"

On Mon, May 13, 2024 at 03:10:47PM +0800, Li Feng wrote: > This reverts commit f02a4b8e6431598612466f76aac64ab492849abf. > include subject of reverted commit and motivation for the revert pls. > Signed-off-by: Li Feng > --- > hw/block/vhost-user-blk.c | 2 +- > hw/scsi/vhost-user-scsi.

[PATCH v2 0/4] Fix "virtio-gpu: fix scanout migration post-load"

From: Marc-André Lureau Hi, The aforementioned patch breaks virtio-gpu device migrations for versions pre-9.0/9.0, both forwards and backwards. Versioning of `VMS_STRUCT` is more complex than it may initially appear, as evidenced in the problematic commit dfcf74fa68c ("virtio-gpu: fix scanout mi

[PATCH v2 1/4] migration: add "exists" info to load-state-field trace

From: Marc-André Lureau Signed-off-by: Marc-André Lureau Reviewed-by: Peter Xu --- migration/vmstate.c| 5 +++-- migration/trace-events | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index ef26f26ccd..b51212a75b 100644 --- a

Re: [PATCH RESEND] target/riscv/cpu.c: fix Zvkb extension config

I think this patch also needs to back-port to stable-8.2. I added qemu-sta...@nongnu.org to cc. > On May 11, 2024, at 19:26, Yangyu Chen wrote: > > This code has a typo that writes zvkb to zvkg, causing users can't > enable zvkb through the config. This patch gets this fixed. > > Signed-off-by

[PATCH v2 3/4] virtio-gpu: add x-vmstate-version

From: Marc-André Lureau Machine <= 8.2 use v1. Following patch will adjust to v2 for other machines to fix migration. Signed-off-by: Marc-André Lureau Reviewed-by: Fabiano Rosas --- include/hw/virtio/virtio-gpu.h | 1 + hw/core/machine.c | 1 + hw/display/virtio-gpu.c| 6

[PATCH v2 2/4] migration: fix a typo

From: Marc-André Lureau Signed-off-by: Marc-André Lureau --- migration/vmstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index b51212a75b..ff5d589a6d 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -479,7 +479,7

[PATCH v2 4/4] virtio-gpu: fix v2 migration

From: Peter Xu Commit dfcf74fa ("virtio-gpu: fix scanout migration post-load") broke forward/backward version migration. Versioning of nested VMSD structures is not straightforward, as the wire format doesn't have nested structures versions. Use the x-vmstate-version introduced before and a field

Re: [PATCH] hw/nvme: Add CLI options for PCI vendor/device IDs and IEEE-OUI ID

Saif Abrar writes: > Add CLI options for user specified > - PCI vendor, device, subsystem vendor and subsystem IDs > - IEEE-OUI ID > > e.g. PCI IDs to be specified as follows: > -device > nvme,id_vendor=0xABCD,id_device=0xA0B0,id_subsys_vendor=0xEF00,id_subsys=0xEF01 > > IEEE-OUI ID (Identify Co

Re: [PATCH] fix: correct typo in ext_zvkb configuration variable Signed-off-by: Kaiyao Duan

inspireMeNow writes: > --- > target/riscv/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c > index eb1a2e7d6d..13cd34adbd 100644 > --- a/target/riscv/cpu.c > +++ b/target/riscv/cpu.c > @@ -1535,7 +1535,7 @@ const RISCVCPUMulti

Re: [PATCH-for-9.1 v2 2/3] migration: Remove RDMA protocol handling

Hi Peter, Hi Chuan, On Thu, May 9, 2024 at 4:14 PM Peter Xu wrote: > > On Thu, May 09, 2024 at 04:58:34PM +0800, Zheng Chuan via wrote: > > That's a good news to see the socket abstraction for RDMA! > > When I was developed the series above, the most pain is the RDMA migration > > has no QIOChan

Kubernetes runners down?

Our gitlab ci has fallen over this weekend, not connecting to k8s. https://gitlab.com/qemu-project/qemu/-/pipelines/1287356573 r~

[PATCH v2 16/45] target/hppa: Always make a copy in do_ibranch_priv

This simplifies callers, which might otherwise have to make another copy. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 22935f4645..f267de14c6 100644

[PATCH v2 00/45] target/hppa: Misc improvements

Most of the patches lead up to implementing CF_PCREL. Along the way there is a grab bag of code updates (TCG_COND_TST*), bug fixes (space changes during branch-in-branch-delay-slot), and implementation of features (PSW bits B, X, T, H, L). Sven reported that PSW L tripped up HP/UX, so possibly the

[PATCH v2 17/45] target/hppa: Introduce and use DisasIAQE for branch management

Wrap offset and space together in one structure, ensuring that they're copied together as required. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 378 +--- 1 file changed, 198 insertions(+), 180 deletions(-) diff --git a/target/hppa/translate

[PATCH v2 01/45] target/hppa: Move cpu_get_tb_cpu_state out of line

Signed-off-by: Richard Henderson --- target/hppa/cpu.h | 43 ++- target/hppa/cpu.c | 42 ++ 2 files changed, 44 insertions(+), 41 deletions(-) diff --git a/target/hppa/cpu.h b/target/hppa/cpu.h index fb2e4c4a98..61f1

[PATCH v2 05/45] target/hppa: Allow prior nullification in do_ibranch

Simplify the function by not attempting a conditional move on the branch destination -- just use nullify_over normally. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 73 +++-- 1 file changed, 20 insertions(+), 53 deletions(-) diff --git a/tar

[PATCH v2 02/45] target/hppa: Use hppa_form_gva_psw in hppa_cpu_get_pc

This function is for log_pc(), which needs to produce a similar result to cpu_get_tb_cpu_state(). Signed-off-by: Richard Henderson --- target/hppa/cpu.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 582036b31e..be8c558014

[PATCH v2 19/45] target/hppa: Rename cond_make_* helpers

Use 'v' for a variable that needs copying, 't' for a temp that doesn't need copying, and 'i' for an immediate, and use this naming for both arguments of the comparison. So: cond_make_tmp -> cond_make_tt cond_make_0_tmp -> cond_make_ti cond_make_0 -> cond_make_vi cond_make -> cond_make

[PATCH v2 07/45] target/hppa: Add install_iaq_entries

Instead of two separate cpu_iaoq_entry calls, use one call to update both IAQ_Front and IAQ_Back. Simplify with an argument combination that automatically handles a simple increment from Front to Back. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 64 +--

[PATCH v2 04/45] target/hppa: Pass displacement to do_dbranch

Pass a displacement instead of an absolute value. In trans_be, remove the user-only do_dbranch case. The branch we are attempting to optimize is to the zero page, which is perforce on a different page than the code currently executing, which means that we will *not* use a goto_tb. Use a plain in

[PATCH v2 08/45] target/hppa: Add install_link

Add a common routine for writing the return address. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 54 +++-- 1 file changed, 31 insertions(+), 23 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 08d5e2a4bc..f8

[PATCH v2 06/45] target/hppa: Use CF_BP_PAGE instead of cpu_breakpoint_test

The generic tcg driver will have already checked for breakpoints. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 140dfb747a..d272be0e6e 100644 --- a/targ

[PATCH v2 30/45] target/hppa: Use delay_excp for conditional trap on overflow

Signed-off-by: Richard Henderson --- target/hppa/helper.h | 1 - target/hppa/int_helper.c | 2 +- target/hppa/op_helper.c | 7 --- target/hppa/translate.c | 21 + 4 files changed, 14 insertions(+), 17 deletions(-) diff --git a/target/hppa/helper.h b/target/hppa/h

[PATCH v2 15/45] target/hppa: Use umax in do_ibranch_priv

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index ae66068123..22935f4645 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1981,7 +1981,7 @@

[PATCH v2 03/45] target/hppa: Move constant destination check into use_goto_tb

Share this check between gen_goto_tb and hppa_tr_translate_insn. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6d45611888..398803981c

[PATCH v2 35/45] target/hppa: Split PSW X and B into their own field

Generally, both of these bits are cleared at the end of each instruction. By separating these, we will be able to clear both with a single insn, instead of 2 or 3. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 3 ++- target/hppa/helper.c | 6 +++--- 2 files changed, 5 insertions(+

[PATCH v2 24/45] target/hppa: Use TCG_COND_TST* in trans_bb_imm

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 47f4b23d1b..d8973a63df 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3515,

[PATCH v2 14/45] target/hppa: Add space argument to do_ibranch

This allows unification of BE, BLR, BV, BVE with a common helper. Since we can now track space with IAQ_Next, we can now let the TranslationBlock continue across the delay slot with BE, BVE. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 76 ++-

[PATCH v2 18/45] target/hppa: Use displacements in DisasIAQE

This is a first step in enabling CF_PCREL, but for now we regenerate the absolute address before writeback. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 43 ++--- 1 file changed, 23 insertions(+), 20 deletions(-) diff --git a/target/hppa/tra

[PATCH v2 13/45] target/hppa: Add space arguments to install_iaq_entries

Move space assighments to a central location. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 58 +++-- 1 file changed, 27 insertions(+), 31 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index d24220c60f..05383dcd0

[PATCH v2 38/45] target/hppa: Implement PSW_X

Use PAGE_WRITE_INV to temporarily enable write permission on for a given page, driven by PSW_X being set. Signed-off-by: Richard Henderson --- target/hppa/mem_helper.c | 46 +++- 1 file changed, 27 insertions(+), 19 deletions(-) diff --git a/target/hppa/mem_h

[PATCH v2 09/45] target/hppa: Delay computation of IAQ_Next

We no longer have to allocate a temp and perform an addition before translation of the rest of the insn. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git a/target/hppa/translate.c b/target/

[PATCH v2 29/45] target/hppa: Use delay_excp for conditional traps

Signed-off-by: Richard Henderson --- target/hppa/helper.h | 1 - target/hppa/int_helper.c | 2 +- target/hppa/op_helper.c | 7 --- target/hppa/translate.c | 41 ++-- 4 files changed, 32 insertions(+), 19 deletions(-) diff --git a/target/hppa/helpe

[PATCH v2 21/45] target/hppa: Use TCG_COND_TST* in do_log_cond

We can directly test bits of a 32-bit comparison without zero or sign-extending an intermediate result. We can directly test bit 0 for odd/even. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 78 ++--- 1 file changed, 27 insertions(+), 51 delet

[PATCH v2 43/45] target/hppa: Implement PSW_H, PSW_L

Signed-off-by: Richard Henderson --- target/hppa/cpu.c | 4 +-- target/hppa/translate.c | 68 + 2 files changed, 64 insertions(+), 8 deletions(-) diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c index 2a3b5fc498..f53e5a2788 100644 --- a/target/hpp

[PATCH v2 37/45] target/hppa: Implement PSW_B

PSW_B causes B,GATE to trap as an illegal instruction, removing the sequential execution test that was merely an approximation. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/target/hppa/

[PATCH v2 26/45] target/hppa: Use TCG_COND_TST* in trans_ftest

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 6d76599ea0..ef62cd7e94 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.

[PATCH v2 42/45] target/hppa: Implement PSW_T

PSW_T enables a trap on taken branches, at the very end of the execution of the branch instruction. Signed-off-by: Richard Henderson --- target/hppa/cpu.c | 4 +-- target/hppa/translate.c | 55 +++-- 2 files changed, 44 insertions(+), 15 deletions(-) d

[PATCH v2 36/45] target/hppa: Manage PSW_X and PSW_B in translator

PSW_X is cleared after every instruction, and only set by RFI. PSW_B is cleared after every non-branch, or branch not taken, and only set by taken branches. We can clear both bits with a single store, at most once per TB. Taken branches set PSW_B, at most once per TB. Signed-off-by: Richard Hend

[PATCH v2 25/45] target/hppa: Use registerfields.h for FPSR

Define all of the context dependent field definitions. Use FIELD_EX32 and FIELD_DP32 with named fields instead of extract32 and deposit32 with raw constants. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 25 + target/hppa/fpu_helper.c | 26 +-

[PATCH v2 33/45] target/hppa: Do not mask in copy_iaoq_entry

As with loads and stores, code offsets are kept intact until the full gva is formed. In qemu, this is in cpu_get_tb_cpu_state. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/target/hppa/translate.c b/target/

[PATCH v2 40/45] target/hppa: Adjust priv for B,GATE at runtime

Do not compile in the priv change based on the first translation; look up the PTE at execution time. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 1 - target/hppa/helper.h | 1 + target/hppa/mem_helper.c | 34 +++--- target/hppa/translate.c |

[PATCH v2 31/45] linux-user/hppa: Force all code addresses to PRIV_USER

The kernel does this along the return path to user mode. Signed-off-by: Richard Henderson --- linux-user/hppa/target_cpu.h | 4 ++-- target/hppa/cpu.h| 3 +++ linux-user/elfload.c | 4 ++-- linux-user/hppa/cpu_loop.c | 14 +++--- linux-user/hppa/signal.c | 6

[PATCH v2 22/45] target/hppa: Use TCG_COND_TST* in do_unit_zero_cond

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index e4e8034c5f..50cc6decd8 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1005,9 +1005,8 @

[PATCH v2 41/45] target/hppa: Implement CF_PCREL

Now that the groundwork has been laid, enabling CF_PCREL within the translator proper is a simple matter of updating copy_iaoq_entry and install_iaq_entries. We also need to modify the unwind info, since we no longer have absolute addresses to install. As expected, this reduces the runtime overhe

[PATCH v2 11/45] target/hppa: Simplify TB end

Minimize the amount of code in hppa_tr_translate_insn advancing the insn queue for the next insn. Move the goto_tb path to hppa_tr_tb_stop. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 109 +--- 1 file changed, 57 insertions(+), 52 deletions

[PATCH v2 45/45] target/hppa: Log cpu state on return-from-interrupt

Inverse of the logging on taking an interrupt. Signed-off-by: Richard Henderson --- target/hppa/sys_helper.c | 12 1 file changed, 12 insertions(+) diff --git a/target/hppa/sys_helper.c b/target/hppa/sys_helper.c index 22d6c89964..9b43b556fd 100644 --- a/target/hppa/sys_helper.c ++

[PATCH v2 28/45] target/hppa: Introduce DisasDelayException

Allow an exception to be emitted at the end of the TranslationBlock, leaving only the conditional branch inline. Use it for simple exception instructions like break, which happen to be nullified. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 60 +

[PATCH v2 44/45] target/hppa: Log cpu state at interrupt

This contains all of the information logged before, plus more. Signed-off-by: Richard Henderson --- target/hppa/int_helper.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/target/hppa/int_helper.c b/target/hppa/int_helper.c index b82f32fd12..391

[PATCH v2 12/45] target/hppa: Add IASQ entries to DisasContext

Add variable to track space changes to IAQ. So far, no such changes are introduced, but the new checks vs ctx->iasq_b may eliminate an unnecessary copy to cpu_iasq_f with e.g. BLR. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 39 ++- 1 file

[PATCH v2 10/45] target/hppa: Skip nullified insns in unconditional dbranch path

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index a9196050dc..ca979f4137 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1805,11

[PATCH v2 32/45] target/hppa: Store full iaoq_f and page offset of iaoq_b in TB

In preparation for CF_PCREL. store the iaoq_f in 3 parts: high bits in cs_base, middle bits in pc, and low bits in priv. For iaoq_b, set a bit for either of space or page differing, else the page offset. Install iaq entries before goto_tb. The change to not record the full direct branch difference

[PATCH v2 27/45] target/hppa: Remove cond_free

Now that we do not need to free tcg temporaries, the only thing cond_free does is reset the condition to never. Instead, simply write a new condition over the old, which may be simply cond_make_f() for the never condition. The do_*_cond functions do the right thing with c or cf == 0, so there's no

[PATCH v2 20/45] target/hppa: Use TCG_COND_TST* in do_cond

We can directly test bits of a 32-bit comparison without zero or sign-extending an intermediate result. We can directly test bit 0 for odd/even. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 64 ++--- 1 file changed, 28 insertions(+), 36 delet

[PATCH v2 34/45] target/hppa: Improve hppa_cpu_dump_state

Print both raw IAQ_Front and IAQ_Back as well as the GVAs. Print control registers in system mode. Print floating point register if CPU_DUMP_FPU. Signed-off-by: Richard Henderson --- target/hppa/helper.c | 60 +++- 1 file changed, 54 insertions(+), 6 delet

[PATCH v2 39/45] target/hppa: Drop tlb_entry return from hppa_get_physical_address

The return-by-reference is never used. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 3 +-- target/hppa/int_helper.c | 2 +- target/hppa/mem_helper.c | 19 --- target/hppa/op_helper.c | 3 +-- 4 files changed, 7 insertions(+), 20 deletions(-) diff --git a/t

[PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

Signed-off-by: Richard Henderson --- target/hppa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index 50cc6decd8..47f4b23d1b 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -1419,8 +1419,8

Re: [PATCH v2 1/2] ui/gtk: Add gd_motion_event trace event

On Sun, May 12, 2024 at 3:16 PM hikalium wrote: > > Add gd_motion_event trace event for making it easy to debug > gd_motion_event related issues. > > Signed-off-by: hikalium Acked-by: Marc-André Lureau > --- > ui/gtk.c| 2 ++ > ui/trace-events | 1 + > 2 files changed, 3 insertions(+)

Re: [PATCH v2 2/2] ui/gtk: Fix mouse/motion event scaling issue with GTK display backend

Hi On Sun, May 12, 2024 at 3:16 PM hikalium wrote: > > Remove gtk_widget_get_scale_factor() usage from the calculation of > the motion events in the GTK backend to make it work correctly on > environments that have `gtk_widget_get_scale_factor() != 1`. > > This scale factor usage had been introdu

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

On Mon, May 13, 2024 at 2:28 PM Eugenio Perez Martin wrote: > > On Sat, May 11, 2024 at 6:07 AM Jason Wang wrote: > > > > On Fri, May 10, 2024 at 3:16 PM Eugenio Perez Martin > > wrote: > > > > > > On Fri, May 10, 2024 at 6:29 AM Jason Wang wrote: > > > > > > > > On Thu, May 9, 2024 at 3:10 PM

Re: [PATCH] ui/sdl2: Allow host to power down screen

On Sun, May 12, 2024 at 2:00 PM Bernhard Beschow wrote: > > By default, SDL disables the screen saver which prevents the host from > powering > down the screen even if the screen is locked. This results in draining the > battery needlessly when the host isn't connected to a wall charger. Fix that

Re: [PATCH v11 01/10] virtio-gpu: Unrealize GL device

On 2024/05/12 3:22, Dmitry Osipenko wrote: Even though GL GPU doesn't support hotplugging today, free virgl resources when GL device is unrealized. For consistency. Signed-off-by: Dmitry Osipenko --- hw/display/virtio-gpu-gl.c | 11 +++ hw/display/virtio-gpu-virgl.c | 9 +++

Re: [PATCH v11 08/10] virtio-gpu: Handle resource blob commands

On 2024/05/12 3:22, Dmitry Osipenko wrote: From: Antonio Caggiano Support BLOB resources creation, mapping and unmapping by calling the new stable virglrenderer 0.10 interface. Only enabled when available and via the blob config. E.g. -device virtio-vga-gl,blob=true Signed-off-by: Antonio Cagg

Re: [PATCH v11 09/10] virtio-gpu: Register capsets dynamically

On 2024/05/12 3:22, Dmitry Osipenko wrote: From: Pierre-Eric Pelloux-Prayer virtio_gpu_virgl_get_num_capsets will return "num_capsets", but we can't assume that capset_index 1 is always VIRGL2 once we'll support more capsets, like Venus and DRM capsets. Register capsets dynamically to avoid tha

Re: [PATCH] docs/system: Remove ADC from raspi documentation

On 12/5/24 10:57, Rayhan Faizel wrote: None of the RPi boards have ADC on-board. In real life, an external ADC chip is required to operate on analog signals. Oops. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Rayhan Faizel --- docs/system/arm/raspi.rst | 1 - 1 file changed, 1 del

Re: [PATCH v2 39/45] target/hppa: Drop tlb_entry return from hppa_get_physical_address

On 13/5/24 09:47, Richard Henderson wrote: The return-by-reference is never used. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 3 +-- target/hppa/int_helper.c | 2 +- target/hppa/mem_helper.c | 19 --- target/hppa/op_helper.c | 3 +-- 4 files changed

Re: [PATCH v2 19/45] target/hppa: Rename cond_make_* helpers

On 13/5/24 09:46, Richard Henderson wrote: Use 'v' for a variable that needs copying, 't' for a temp that doesn't need copying, and 'i' for an immediate, and use this naming for both arguments of the comparison. So: cond_make_tmp -> cond_make_tt cond_make_0_tmp -> cond_make_ti cond_

Re: [PATCH v5 01/19] backends: Introduce HostIOMMUDevice abstract

Hello Zhenzhong, On 5/8/24 11:03, Zhenzhong Duan wrote: Introduce HostIOMMUDevice as an abstraction of host IOMMU device. Introduce .realize() to initialize HostIOMMUDevice further after instance init. Introduce a macro CONFIG_HOST_IOMMU_DEVICE to define the usage for VFIO, and VDPA in the fut

Re: [PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

On 13/5/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [RFC 0/2] Identify aliased maps in vdpa SVQ iova_tree

On Mon, May 13, 2024 at 10:28 AM Jason Wang wrote: > > On Mon, May 13, 2024 at 2:28 PM Eugenio Perez Martin > wrote: > > > > On Sat, May 11, 2024 at 6:07 AM Jason Wang wrote: > > > > > > On Fri, May 10, 2024 at 3:16 PM Eugenio Perez Martin > > > wrote: > > > > > > > > On Fri, May 10, 2024 at 6:

[PATCH 1/3] hw/rtc/ds1338: Trace send and receive operations

Signed-off-by: Bernhard Beschow --- hw/rtc/ds1338.c | 6 ++ hw/rtc/trace-events | 4 2 files changed, 10 insertions(+) diff --git a/hw/rtc/ds1338.c b/hw/rtc/ds1338.c index e479661c39..ec1b6c40b1 100644 --- a/hw/rtc/ds1338.c +++ b/hw/rtc/ds1338.c @@ -17,6 +17,7 @@ #include "qemu/mod

[PATCH 0/3] Trivial ARM changes

This series improves the tracing experience in two devices used in ARM context. It also removes a duplicate statement in an IMX watchdog which may indicate a bug (see comment underneath commit message). Best regards, Bernhard Bernhard Beschow (3): hw/rtc/ds1338: Trace send and receive operation

[PATCH 3/3] hw/watchdog/wdt_imx2: Remove redundant assignment

The same statement is executed unconditionally right before the if statement. Cc: Guenter Roeck Signed-off-by: Bernhard Beschow --- The duplicate line may indicate a bug. I'm not familiar with the code, so this patch may go into the wrong direction. Please check! --- hw/watchdog/wdt_imx2.c |

[PATCH 2/3] hw/timer/imx_gpt: Convert DPRINTF to trace events

Signed-off-by: Bernhard Beschow --- hw/timer/imx_gpt.c| 18 +- hw/timer/trace-events | 6 ++ 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/hw/timer/imx_gpt.c b/hw/timer/imx_gpt.c index a8edaec867..3c3b044622 100644 --- a/hw/timer/imx_gpt.c +++ b/hw/time

Re: [PATCH 1/1] tests/fp/meson: don't build fp-bench test if fenv.h is missing

On 11/05/2024 13.09, Dario Binacchi wrote: On Sat, May 11, 2024 at 12:25 PM Richard Henderson wrote: On 5/11/24 12:11, Dario Binacchi wrote: Gentle ping. Gentle reminder that I strongly suspect that your buildroot is corrupt. There *should* be a present. I don't think so. In fact, the pa

Re: [PATCH v2 24/45] target/hppa: Use TCG_COND_TST* in trans_bb_imm

On 13/5/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/translate.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH 0/4] tests: Remove xfsprogs and g++ from the dockerfiles

The xfsprogs package is not necessary anymore since commit a5730b8bd3 and we don't need g++ in any of the containers (except for the mingw cross compiler container which can be handled differently), so this patch series simplifies the dockerfiles a little bit accordingly. Philippe Mathieu-Daudé (1

[PATCH 1/4] tests/lcitool: Remove 'xfsprogs' from QEMU

From: Philippe Mathieu-Daudé QEMU's commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling") removed the need for the 'xfsprogs' package. Signed-off-by: Philippe Mathieu-Daudé [thuth: Adjusted the patch from the lcitools repo to QEMU's repo] Signed-off-by: Thomas Huth ---

[PATCH 4/4] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

Run "make lcitool-refresh" after the previous changes to the lcitool files. This removes the g++ and xfslibs-dev packages from the dockerfiles. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 4 tests/docker/dockerfiles/centos9.docker | 4

[PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

We don't need C++ for the normal QEMU builds anymore, so installing g++ in each and every container seems to be a waste of time and disk space. The only container that still needs it is the Fedora MinGW container that builds the only remaining C++ code in ./qga/vss-win32/ and we can install it here

Re: [PATCH v2 27/45] target/hppa: Remove cond_free

On 13/5/24 09:46, Richard Henderson wrote: Now that we do not need to free tcg temporaries, the only thing cond_free does is reset the condition to never. Instead, simply write a new condition over the old, which may be simply cond_make_f() for the never condition. The do_*_cond functions do the

Re: [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0

On Sun, May 12, 2024 at 12:44 AM liwei wrote: > > > On 2024/5/11 18:10, Alexey Baturo wrote: > > From: Alexey Baturo > > > > Hi, > > > > It looks like Pointer Masking spec has reached v1.0 and been frozen, > > rebasing on riscv-to-apply.next branch and resubmitting patches. > > Hi, any change fro

[PATCH 3/4] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

Let's try to keep the entries in alphabetical order here! Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index b63b6bd850..7520

Re: [PATCH v5] target/riscv: Implement dynamic establishment of custom decoder

On Mon, May 6, 2024 at 12:37 PM Huang Tao wrote: > > In this patch, we modify the decoder to be a freely composable data > structure instead of a hardcoded one. It can be dynamically builded up > according to the extensions. > This approach has several benefits: > 1. Provides support for heterogen

Re: [PATCH v2 26/45] target/hppa: Use TCG_COND_TST* in trans_ftest

On 13/5/24 09:46, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/hppa/translate.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

RE: [PATCH v5 01/19] backends: Introduce HostIOMMUDevice abstract

Hi Cédric, >-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v5 01/19] backends: Introduce HostIOMMUDevice >abstract > >Hello Zhenzhong, > >On 5/8/24 11:03, Zhenzhong Duan wrote: >> Introduce HostIOMMUDevice as an abstraction of host IOMMU device. >> >> Introduce .realize()

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: > We don't need C++ for the normal QEMU builds anymore, so installing > g++ in each and every container seems to be a waste of time and disk > space. The only container that still needs it is the Fedora MinGW > container that builds the o

Re: [PATCH v2 35/45] target/hppa: Split PSW X and B into their own field

On 13/5/24 09:47, Richard Henderson wrote: Generally, both of these bits are cleared at the end of each instruction. By separating these, we will be able to clear both with a single insn, instead of 2 or 3. Signed-off-by: Richard Henderson --- target/hppa/cpu.h| 3 ++- target/hppa/helpe

Re: [PATCH v5] riscv: thead: Add th.sxstatus CSR emulation

On Mon, Apr 29, 2024 at 5:37 PM Christoph Müllner wrote: > > The th.sxstatus CSR can be used to identify available custom extension > on T-Head CPUs. The CSR is documented here: > > https://github.com/T-head-Semi/thead-extension-spec/blob/master/xtheadsxstatus.adoc > > An important property of

Re: [PATCH v2 16/45] target/hppa: Always make a copy in do_ibranch_priv

On 13/5/24 09:46, Richard Henderson wrote: This simplifies callers, which might otherwise have to make another copy. Signed-off-by: Richard Henderson --- target/hppa/translate.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH] target/riscv: Remove experimental prefix from "B" extension

On Tue, May 7, 2024 at 8:28 PM Rob Bradford wrote: > > This extension has now been ratified: > https://jira.riscv.org/browse/RVS-2006 so the "x-" prefix can be > removed. > > Signed-off-by: Rob Bradford Just to be clear, do you mind enabling RVB as part of riscv_init_max_cpu_extensions() as part

Re: [PATCH v2 1/3] qtest: allow SPCR acpi table changes

On Mon, May 13, 2024 at 4:32 PM Michael S. Tsirkin wrote: > > On Mon, May 13, 2024 at 01:55:50PM +1000, Alistair Francis wrote: > > On Tue, May 7, 2024 at 3:24 PM Sia Jee Heng > > wrote: > > > > Can you describe why you are doing this and that it will be reverted > > in the commit message? > > >

Re: [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0

Hi, > Hi, any change from v0.8 to v1.0? Not in the patches that were sent. I'd still suggest applying a step-by-step approach with cleaning up old code and establishing the new mechanisms first and then updating the code to match the spec 100%. Also I heard Martin has some arch compliance tests fo

[PATCH v2] vhost-user-gpu: fix import of DMABUF

From: Marc-André Lureau When using vhost-user-gpu with GL, qemu -display gtk doesn't show output and prints: qemu: eglCreateImageKHR failed Since commit 9ac06df8b ("virtio-gpu-udmabuf: correct naming of QemuDmaBuf size properties"), egl_dmabuf_import_texture() uses backing_{width,height} for the

Re: [PATCH v9 0/6] Pointer Masking update for Zjpm v1.0

On Mon, May 13, 2024 at 9:05 PM Alexey Baturo wrote: > > Hi, > > > Hi, any change from v0.8 to v1.0? > Not in the patches that were sent. I'd still suggest applying a step-by-step > approach with cleaning up old code and establishing the new mechanisms first > and then updating the code to match

[PATCH 1/3] dockerfiles: add 'MAKE' env variable to remaining containers

All the lcitool generated containers define a "MAKE" env. It will be convenient for later patches if all containers do this. Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/debian-all-test-cross.docker| 1 + tests/docker/dockerfiles/debian-hexagon-cross.docker | 1 + tests

[PATCH 2/3] gitlab: use $MAKE instead of 'make'

The lcitool generated containers have '$MAKE' set to the path of the right 'make' binary. Using the env variable makes it possible to override the choice per job. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/buildtest-template.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH 3/3] gitlab: use 'setarch -R' to workaround tsan bug

The TSAN job started failing when gitlab rolled out their latest release. The root cause is a change in the Google COS version used on shared runners. This brings a kernel running with vm.mmap_rnd_bits = 31 which is incompatible with TSAN in LLVM < 18, which only supports upto '28'. LLVM 18 can

  1   2   3   >