Remove the error object from opaque data passed to notifiers.
Use the new error parameter passed to the notifier instead.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
hw/virtio/vhost-user.c | 8
include/migration/misc.h | 1 -
migration/postcopy-ram.c | 1 -
migration/postc
Check the status returned by migration notifiers and report errors.
If notifiers fail, call the notifiers again so they can clean up.
None of the notifiers return an error status at this time.
Signed-off-by: Steve Sistare
---
include/migration/misc.h | 3 ++-
migration/migration.c| 40 +
Keep a separate list of migration notifiers for each migration mode.
Suggested-by: Peter Xu
Signed-off-by: Steve Sistare
---
include/migration/misc.h | 2 ++
migration/migration.c| 22 +-
2 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/include/migration/
Move common code for the error path in migrate_fd_connect to a shared
fail label. No functional change.
Signed-off-by: Steve Sistare
Reviewed-by: Peter Xu
---
migration/migration.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/migration/migration.c b
Clarify qapi for cpr-reboot migration mode, and add vfio support.
Signed-off-by: Steve Sistare
---
qapi/migration.json | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index 8197083..c83e0c0 10064
Allow cpr-reboot for vfio if the guest is in the suspended runstate. The
guest drivers' suspend methods flush outstanding requests and re-initialize
the devices, and thus there is no device state to save and restore. The
user is responsible for suspending the guest before initiating cpr, such as
On Tue, Feb 6, 2024 at 8:25 PM Peter Xu wrote:
>
> On Tue, Feb 06, 2024 at 11:19:05PM +, Hao Xiang wrote:
> > diff --git a/migration/multifd.c b/migration/multifd.c
> > index 25cbc6dc6b..a20d0ed10e 100644
> > --- a/migration/multifd.c
> > +++ b/migration/multifd.c
> > @@ -264,6 +264,7 @@ stati
On Wed, Jan 24, 2024 at 04:50:04PM +, Jonathan Cameron wrote:
> On Tue, 7 Nov 2023 10:07:12 -0800
> nifan@gmail.com wrote:
>
> > From: Fan Ni
> >
> > Since fabric manager emulation is not supported yet, the change implements
> > the functions to add/release dynamic capacity extents as Q
Removing testing for PCS registers since that doesn't exist on 7xx.
Nabih Estefan (1):
tests/qtest: Fixing GMAC test to run in 7xx
obmc-phosphor-image-gsj.static.mtd | Bin 0 -> 33554432 bytes
tests/qtest/meson.build| 4 +-
tests/qtest/npcm_gmac-test.c | 84 +--
On 2/6/24 22:18, Jason Chien wrote:
The original implementation sets $pc to the address read from the jump
vector table first and links $ra with the address of the next instruction
after the updated $pc. After jumping to the updated $pc and executing the
next ret instruction, the program jumps to
Removing testing for PCS registers since that doesn't exist on 7xx.
Nabih Estefan (1):
tests/qtest: Fixing GMAC test to run in 7xx
obmc-phosphor-image-gsj.static.mtd | Bin 0 -> 33554432 bytes
tests/qtest/meson.build| 4 +-
tests/qtest/npcm_gmac-test.c | 84 +--
Accidentally added extra file to v2 that broke email sending (and was
not meant to be upstreamed). Sending our v3 to skip that confusion.
Removing testing for PCS registers since that doesn't exist on 7xx.
Nabih Estefan (1):
tests/qtest: Fixing GMAC test to run in 7xx
tests/qtest/meson.build
Fixing the nocm_gmac-test.c file to run on a nuvoton 7xx machine instead
of 8xx. Also fixing comments referencing this and values expecting 8xx.
Change-Id: Iabd0fba14910c3f1e883c4a9521350f3db9ffab8
Signed-Off-By: Nabih Estefan
Reviewed-by: Tyrone Ting
---
tests/qtest/meson.build | 4 +-
t
Validate that a shutdown via the pvpanic device emits the correct
QMP events.
Signed-off-by: Thomas Weißschuh
Reviewed-by: Thomas Huth
---
tests/qtest/pvpanic-pci-test.c | 39 +++
tests/qtest/pvpanic-test.c | 29 +
2 files chan
Avoid the necessity to update all tests when new events are added
to the device.
Acked-by: Thomas Huth
Reviewed-by: Cornelia Huck
Signed-off-by: Thomas Weißschuh
---
tests/qtest/pvpanic-pci-test.c | 5 +++--
tests/qtest/pvpanic-test.c | 5 +++--
2 files changed, 6 insertions(+), 4 deletion
Shutdown requests are normally hardware dependent.
By extending pvpanic to also handle shutdown requests, guests can
submit such requests with an easily implementable and cross-platform
mechanism.
The background is the usage of minimal Linux kernels with different
architectures for testing purpose
The different components of pvpanic duplicate the list of supported
events. Move it to the shared header file to minimize changes when new
events are added.
Reviewed-by: Thomas Huth
Reviewed-by: Cornelia Huck
Signed-off-by: Thomas Weißschuh
---
hw/misc/pvpanic-isa.c | 2 +-
hw/misc/pvpanic
From: Alejandro Jimenez
Emit a QMP event on receiving a PVPANIC_SHUTDOWN event. Even though a typical
SHUTDOWN event will be sent, it will be indistinguishable from a shutdown
originating from other cases (e.g. KVM exit due to KVM_SYSTEM_EVENT_SHUTDOWN)
that also issue the guest-shutdown cause.
A
Shutdown requests are normally hardware dependent.
By extending pvpanic to also handle shutdown requests, guests can
submit such requests with an easily implementable and cross-platform
mechanism.
Acked-by: Cornelia Huck
Signed-off-by: Thomas Weißschuh
---
docs/specs/pvpanic.rst| 2 ++
hw/m
misc/pvpanic.h from the Linux UAPI does not define a Linux UAPI but a
qemu device API.
This leads to a weird process when updates to the interface are needed:
1) Change to the specification in the qemu tree
2) Change to the header in the Linux tree
3) Re-import of the header into Qemu.
The kernel
On 2/6/24 21:13, Alexander Monakov wrote:
Thank you. I agree we shouldn't penalize non-x86 hosts here, but to be honest
I'd really like to keep this optimization because so many places in Qemu invoke
buffer_is_zero with a constant length, allowing the compiler to optimize out
the length test.
H
On Tue, 6 Feb 2024 at 03:22, Richard Henderson
wrote:
>
> v2: Fix rebase error in patch 38 (tcg/s390x: Support TCG_COND_TST{EQ,NE}).
>
>
> r~
>
>
> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
>
> Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru
On Thu, 8 Feb 2024 at 18:04, Fabiano Rosas wrote:
>
> Peter Maydell writes:
>
> +cc Daniel.
>
> > Random intermittent in migration-test when running the tests
> > in the openbsd VM (i.e. what you get from 'make -C build vm-build-openbsd')
> > Any ideas?
>
> Where's your HEAD at?
03e4bc0bc02 in t
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
Add disassembly of opcodes for "HALT QEMU", "RESET QEMU" and
"RESTORE SHR" (restore shadow registers).
Signed-off-by: Helge Deller
---
disas/hppa.c | 4
1 file changed, 4 insertions(+)
Reviewed-by: Richard Henderson
r~
On 2/7/24 08:20, del...@kernel.org wrote:
@@ -484,3 +486,33 @@ uint64_t HELPER(hshradd)(uint64_t r1, uint64_t r2,
uint32_t sh)
}
return ret;
}
+
+/*
+ * diag_console_output() is a helper function used during the initial bootup
+ * process of the SeaBIOS-hppa firmware. During the b
On 2/7/24 08:20, del...@kernel.org wrote:
#define PSW_E0x0400
+#define PSW_E_BIT37 /* PA2.0 only */
#define PSW_W0x0800 /* PA2.0 only */
+#define PSW_W_BIT36 /* PA2.0 only */
...
+target_ulong HELPER(get_system_mask)(CPUHPPASta
On 2/7/24 08:20, del...@kernel.org wrote:
@@ -610,6 +607,7 @@ static MemTxResult astro_chip_write_with_attrs(void
*opaque, hwaddr addr,
uint64_t val, unsigned size,
MemTxAttrs attrs)
{
+MemTxRes
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
The Astro/Elroy chip can work in either Hard-Fail or Soft-Fail mode.
Hard fail means the system bus will send an HPMC (=crash) to the
processor, soft fail means the system bus will ignore timeouts of
MMIO-reads or MMIO-writes and retu
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
HP-UX 11 and HP ODE tools use the "rsm 0,%reg" instruction in not priviledged
code paths to get the current PSW flags. The constant 0 means that no bits of
the PSW shall be reset, so this is effectively a read-only access to the PSW.
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
CHECK_MOST_PRIVILEGED() should check the privilege level only when the PSW.P
bit is set.
Signed-off-by: Helge Deller
---
target/hppa/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/hppa/tran
On Wed, 7 Feb 2024 at 04:36, Hanna Czenczek wrote:
>
> On 06.02.24 17:53, Stefan Hajnoczi wrote:
>
> On Fri, Feb 02, 2024 at 03:47:53PM +0100, Hanna Czenczek wrote:
>
> Hi,
>
> Without the AioContext lock, a BB's context may kind of change at any
> time (unless it has a root node, and I/O requests
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
The BTLB helper function stores the BTLB info (four 32-bit ints) into
the memory of the guest. They are only available when emulating a 32-bit
CPU in the guest, so use "uint32_t" instead of "target_ulong" here.
Signed-off-by: Helge D
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
Load the 64-bit SeaBIOS-hppa firmware by default when running on a 64-bit
machine. This will enable us to later support more than 4GB of RAM and is
required that the OS (or PALO bootloader) will start or install a 64-bit kernel
instead
On 2/7/24 08:20, del...@kernel.org wrote:
From: Helge Deller
SeaBIOS-hppa version 16 news & enhancements:
- Initial 64-bit firmware release
- Added fault handler to catch and report firmware bugs
- Use Qemu's builtin_console_out() via diag 0x101
- parisc-qemu-install Makefile target to install
On Thu, 1 Feb 2024 at 06:37, Michael Tokarev wrote:
>
> 30.01.2024 03:27, Stefan Hajnoczi wrote:
> > The following expression is incorrect because blk_pread_nonzeroes()
> > deals in units of bytes, not sectors:
> >
> >bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS)
> >
In an attempt to build qemu with hardened gcc compiler options, we specified
the -ftrapv switch rather than the -fwrapv switch. The switches define the
behavior of integer overflows. -ftrapv causes an abort on integer overflow,
-fwrapv causes overflows to simply wrap without any error indicatio
Resolves redundant code in the piix and q35 machines.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/pc.h | 2 --
hw/i386/pc.c | 9 +++--
hw/i386/pc_piix.c| 2 --
hw/i386/pc_q35.c | 2 --
4 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/include/hw/i386/pc.
pc_system_flash_create() checked for pcmc->pci_enabled which is redundant since
its caller already checked it. The method can be turned into just two lines, so
inline and remove it.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_sysfw.c | 15 ++-
1 file changed, 2 insertions(+), 13 d
Rather than taking a QOM name which has to be resolved, let's pass the parent
directly as pointer. This simplifies the code.
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 2 +-
hw/i386/microvm.c | 2 +-
hw/i386/pc_piix.c | 7 +++
hw/i386/pc_q35.c | 4 ++--
hw/i386/
Both invocations are the same and either one is always executed. Avoid this
redundancy.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_piix.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 5ed3d69181..adb3b5ed43 100644
---
There is no advantage in having these local variables which 1/ needlessly have
different identifiers in both machines and 2/ which are redundant to pcms->bus
which is almost as short.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc_piix.c | 14 ++
hw/i386/pc_q35.c | 16 +++---
The series aims to simplify the initialization process of all PC-based machines.
It consists of streamlining redundant code, as well as consolidating the setup
of system flash and generation of smbios data which are currently fairly
distributed.
These changes are expected to make the code easier
The attribute isn't user-changeable and only true for pc-based machines. Turn it
into a class attribute which allows for inlining pc_guest_info_init() into
pc_machine_initfn().
Signed-off-by: Bernhard Beschow
---
include/hw/i386/x86.h | 3 ++-
hw/i386/acpi-common.c | 3 ++-
hw/i386/pc.c
Handling most of smbios data generation in the machine_done notifier is similar
to how the ARM virt machine handles it which also calls smbios_set_defaults()
there. The result is that all pc machines are freed from explicitly worrying
about smbios setup.
Signed-off-by: Bernhard Beschow
---
hw/i3
Both the piix and the q35 machines introduce an rtc_state variable and defer the
initialization of the X86MachineState::rtc attribute to pc_cmos_init(). Resolve
this complication which makes pc_cmos_init() do what it says on the tin.
Signed-off-by: Bernhard Beschow
---
hw/i386/pc.c | 8 ---
Rather than distributing PC system flash handling across three files, let's
confine it to one. Now, pc_system_firmware_init() creates, configures and cleans
up the system flash which makes the code easier to understand. It also avoids
the extra call to pc_system_flash_cleanup_unused() in the Xen ca
This file is only used by system/physmem.c so move them together.
Signed-off-by: BALATON Zoltan
---
memory_ldst.c.inc => system/memory_ldst.c.inc | 0
1 file changed, 0 insertions(+), 0 deletions(-)
rename memory_ldst.c.inc => system/memory_ldst.c.inc (100%)
diff --git a/memory_ldst.c.inc b/sy
The detailed help lists zoom-to-fit as valid option but it is missing
from the short option summary. Add it there too.
Signed-off-by: BALATON Zoltan
---
qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 5adbed1101..c5b82ec
On Fri, Feb 2, 2024 at 2:30 AM wrote:
>
> From: Peter Xu
>
> This array is redundant when p->pages exists. Now we extended the life of
> p->pages to the whole period where pending_job is set, it should be safe to
> always use p->pages->offset[] rather than p->normal[]. Drop the array.
>
> Along
Syrmia LLC has been acquired recently and the syrmia.com domain will
disappear soon, so updating my email in the MAINTAINERS file.
Signed-off-by: Aleksandar Rikalo
---
MAINTAINERS | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2f974
On 8/2/24 19:33, BALATON Zoltan wrote:
On Thu, 8 Feb 2024, Philippe Mathieu-Daudé wrote:
We should not wire IRQs on unrealized device.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/macio/macio.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/misc/macio/macio.
This patch implements the prctl calls to set and get the current memory
consistency model. This patch does not implement any real functionality
but just defines the relevant hooks, where target code take over.
Signed-off-by: Christoph Müllner
---
linux-user/syscall.c | 17 +
1 fi
The upcoming RISC-V Ssdtso specification introduces a bit in the senvcfg
CSR to switch the memory consistency model of user mode at run-time from
RVWMO to TSO. The active consistency model can therefore be switched on a
per-hart base and managed by the kernel on a per-process base.
This patch trea
The Ssdtso extension introduces a DTSO field to the {m,s,h}envcfg
register to enable TSO at run-time. Building on top of Ztso support,
this patch treats Ssdtso just like Ztso (always execute in TSO mode),
which should be fine from a correctness perspective.
Similar like Ztso, this is expected to
This patch implements the dynamic memory consistency model prctl calls
for RISC-V. The implementation introduces a single boolean variable to
keep the DTSO state.
Signed-off-by: Christoph Müllner
---
linux-user/riscv/target_prctl.h | 76 -
target/riscv/cpu.c
This patch exposes Ssdtso via hwprobe in QEMU's user space emulator.
Signed-off-by: Christoph Müllner
---
linux-user/syscall.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 24fa11d946..bf0d66b8a8 100644
--- a/linux-user/syscall.c
+++ b/l
On 08/02/2024 20.23, Richard Schmitt wrote:
In an attempt to build qemu with hardened gcc compiler options, we specified
the -ftrapv switch rather than the -fwrapv switch. The switches define the
behavior of integer overflows. -ftrapv causes an abort on integer overflow,
-fwrapv causes overfl
On 8/2/24 09:26, Paolo Bonzini wrote:
On Wed, Feb 7, 2024 at 8:12 PM Philippe Mathieu-Daudé wrote:
Hi Paolo,
On 7/2/24 12:14, Paolo Bonzini wrote:
itc_reconfigure() is referenced from TCG, provide a stub if needed.
This makes it possible to build a QEMU binary that only includes
boards witho
09.02.2024 00:21, Stefan Hajnoczi wrote:
On Thu, 1 Feb 2024 at 06:37, Michael Tokarev wrote:
for (;;) {
-bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS);
+bytes = MIN(size - offset, BDRV_REQUEST_MAX_BYTES);
Hmm. This smells like a -stable material, but you know
Ensure failure occurs while adding validation test for 'uri' and 'channels'
arguments
used simultaneously in the 'migrate' QAPI command.
Signed-off-by: Het Gala
---
tests/qtest/migration-helpers.c | 14 ++--
tests/qtest/migration-helpers.h | 5 +--
tests/qtest/migration-test.c| 60
101 - 160 of 160 matches
Mail list logo
