[PATCH 2/5] migration/multifd: Move multifd_socket_ops to socket.c

2024-01-26 Thread Fabiano Rosas
Code movement only. Signed-off-by: Fabiano Rosas --- migration/multifd.c | 59 --- migration/multifd.h | 2 ++ migration/socket.c | 61 - 3 files changed, 62 insertions(+), 60 deletions(-) diff --git a/migrati

Re: [PULL 00/17] aspeed queue

2024-01-26 Thread Ninad Palsule
6' of https://repo.or.cz/qemu/armbru into staging (2024-01-26 10:21:27 +) are available in the Git repository at:    https://github.com/legoater/qemu/ tags/pull-aspeed-20240126 for you to fetch changes up to b40769f4b49d15485ffaaa7acade3e3593ee6daa:    hw/fsi: Update MAINTAINER list (

Re: hexagon: modeling a shared lock state

2024-01-26 Thread Richard Henderson
On 1/26/24 02:28, Brian Cain wrote: static void do_hwlock(CPUHexagonState *env, bool *lock) { bql_lock(); if (*lock) { env->hwlock_pending = true; cs->halted = true; cs->exception_index = EXCP_HALTED; bql_unlock(); cpu_loop_exit(cs);

Re: [PATCH v6 0/4] accel/tcg: Move perf and debuginfo support to tcg

2024-01-26 Thread Richard Henderson
On 1/25/24 15:46, Philippe Mathieu-Daudé wrote: Since v5: - Use v4 instead of v3... - Rebased on commit 53e8868d69 ("meson: remove OS definitions from config_targetos") Ilya Leoshkevich (4): accel/tcg: Make use of qemu_target_page_mask() in perf.c tcg: Make tb_cflags() usable from targe

Re: [PATCH v2 1/2] target/s390x: Emulate CVDG

2024-01-26 Thread Richard Henderson
On 1/25/24 22:29, Ilya Leoshkevich wrote: CVDG is the same as CVD, except that it converts 64 bits into 128, rather than 32 into 64. Create a new helper, which uses Int128 wrappers. Reported-by: Ido Plat Signed-off-by: Ilya Leoshkevich --- target/s390x/helper.h| 1 + target/s390x

Re: [PATCH] target/arm: Add ID_AA64ZFR0_EL1.B16B16 to the exposed-to-userspace set

2024-01-26 Thread Richard Henderson
On 1/25/24 23:43, Peter Maydell wrote: In kernel commit 5d5b4e8c2d9ec ("arm64/sve: Report FEAT_SVE_B16B16 to userspace") Linux added ID_AA64ZFR0_el1.B16B16 to the set of ID register fields which it exposes to userspace. Update our exported_bits mask to include this. (This doesn't yet change any

Re: [PATCH 0/2] Enable -Wvla, forbidding use of variable length arrays

2024-01-26 Thread Richard Henderson
On 1/26/24 03:32, Peter Maydell wrote: Peter Maydell (2): tests/qtest/xlnx-versal-trng-test.c: Drop use of variable length array meson: Enable -Wvla Reviewed-by: Richard Henderson r~

Re: [PATCH] {linux,bsd}-user: Fail mmap() if size doesn't fit into host's size_t

2024-01-26 Thread Richard Henderson
On 1/26/24 06:07, Ilya Leoshkevich wrote: s390x's branch-relative-long test fails with the following error message on 32-bit hosts: qemu-s390x: ../accel/tcg/user-exec.c:493: page_set_flags: Assertion `last <= GUEST_ADDR_MAX' failed. The root cause is that the size passed to mmap() by this

Re: [PATCH] target/arm: Reinstate "vfp" property on AArch32 CPUs

2024-01-26 Thread Richard Henderson
On 1/27/24 05:34, Peter Maydell wrote: In commit 4315f7c614743 we restructured the logic for creating the VFP related properties to avoid testing the aa32_simd_r32 feature on AArch64 CPUs. However in the process we accidentally stopped exposing the "vfp" QOM property on AArch32 TCG CPUs. This m

Re: [PATCH v2 01/23] hw/acpi/cpu: Use CPUState typedef

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: QEMU coding style recommend using structure typedefs: https://www.qemu.org/docs/master/devel/style.html#typedefs Signed-off-by: Philippe Mathieu-Daudé --- include/hw/acpi/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [PATCH v2 03/23] bulk: Call in place single use cpu_env()

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Avoid CPUArchState local variable when cpu_env() is used once. Mechanical patch using the following Coccinelle spatch script: @@ type CPUArchState; identifier env; expression cs; @@ { -CPUArchState *env = cpu_env(cs); ...

Re: [PATCH v2 04/23] target/alpha: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/alpha/cpu.c| 31 +++ target/alpha/gdbstub.c|

Re: [PATCH v2 05/23] target/arm: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- hw/intc/arm_gicv3_cpuif_common.c | 5 + target/arm/cpu.c | 19 +-

Re: [PATCH v2 06/23] target/avr: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/avr/cpu.c | 27 +++ target/avr/gdbstub.c | 6 ++ tar

Re: [PATCH v2 07/23] target/cris: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/cris/cpu.c | 5 + target/cris/gdbstub.c | 9 +++-- target/cris/help

Re: [PATCH v2 08/23] target/hppa: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/hppa/cpu.c| 8 ++-- target/hppa/int_helper.c | 8 ++-- target/hppa/me

Re: [PATCH v2 09/23] target/i386/hvf: Use CPUState typedef

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: QEMU coding style recommend using structure typedefs: https://www.qemu.org/docs/master/devel/style.html#typedefs Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/x86.h | 26 +- target/i386/hvf/x86_descr.h |

Re: [PATCH v2 10/23] target/i386: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/vmx.h | 13 +++--- hw/i386/vmmouse.c | 6

Re: [PATCH v2 11/23] target/m68k: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/m68k/cpu.c | 30 ++ target/m68k/gdbstub.c | 6 ++-

Re: [PATCH v2 12/23] target/microblaze: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/microblaze/helper.c| 3 +-- target/microblaze/translate.c | 3 +-- 2 files change

Re: [PATCH v2 13/23] target/mips: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/mips/cpu.c | 11 +++--- target/mips/gdbstub.c

Re: [PATCH v2 14/23] target/nios2: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/nios2/cpu.c| 15 +++ target/nios2/helper.c | 3 +-- target/n

Re: [PATCH v2 15/23] target/openrisc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/openrisc/gdbstub.c | 3 +-- target/openrisc/interrupt.c | 6 ++ target/openrisc

Re: [PATCH v2 16/23] target/ppc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/mpc8544_guts.c | 3 +-- hw/ppc/pnv.c | 3 +-- hw/ppc/pnv_x

Re: [PATCH v2 17/23] target/riscv: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/riscv/arch_dump.c | 6 ++ target/riscv/cpu.c | 17 + t

Re: [PATCH v2 18/23] target/rx: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/rx/gdbstub.c | 6 ++ target/rx/helper.c| 6 ++ target/rx/translate.c |

Re: [PATCH v2 19/23] target/s390x: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/s390x/cpu-dump.c| 3 +-- target/s390x/gdbstub.c | 6 ++ target/

Re: [PATCH v2 20/23] target/sh4: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/sh4/cpu.c | 15 +-- target/sh4/gdbstub.c | 6 ++ target/sh4/

Re: [PATCH v2 21/23] target/tricore: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/tricore/cpu.c | 20 target/tricore/gdbstub.c | 6 ++

Re: [PATCH v2 22/23] target/xtensa: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/xtensa/dbg_helper.c | 3 +-- target/xtensa/exc_helper.c | 3 +-- target/xtensa/gdbstu

Re: [PATCH v2 23/23] target/sparc: Prefer fast cpu_env() over slower CPU QOM cast macro

2024-01-26 Thread Richard Henderson
On 1/27/24 08:04, Philippe Mathieu-Daudé wrote: Mechanical patch produced running the command documented in scripts/coccinelle/cpu_env.cocci_template header. Signed-off-by: Philippe Mathieu-Daudé --- target/sparc/cpu.c | 14 -- target/sparc/gdbstub.c | 3 +-- targe

Re: [PATCH v2 02/23] scripts/coccinelle: Add cpu_env.cocci_template script

2024-01-26 Thread Richard Henderson
On 1/27/24 08:03, Philippe Mathieu-Daudé wrote: Add a Coccinelle script to convert the following slow path (due to the QOM cast macro): &ARCH_CPU(..)->env to the following fast path: cpu_env(..) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 +

Re: [PATCH 02/10] hyperv: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git hyperv hw/hyperv/*.[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including i

Re: [PATCH 03/10] disas/riscv: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git disas/riscv disas/riscv*[ch] All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Includ

Re: [PATCH 04/10] aspeed: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes. All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes

Re: [PATCH 05/10] acpi: Clean up includes

2024-01-26 Thread Richard Henderson
On 1/26/24 02:34, Peter Maydell wrote: This commit was created with scripts/clean-includes: ./scripts/clean-includes --git acpi include/hw/*/*acpi.h hw/*/*acpi.c All .c should include qemu/osdep.h first. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first

Re: [PATCH 00/10] Clean up includes

2024-01-26 Thread Michael Tokarev
25.01.2024 19:33, Peter Maydell : This series makes a bunch of automated edits with the clean-includes script. The script performs three related cleanups: * Ensure .c files include qemu/osdep.h first. * Including it in a .h is redundant, since the .c already includes it. Drop such incl

Re: [PATCH v2] cpu-exec: simplify jump cache management

2024-01-26 Thread Richard Henderson
On 1/23/24 07:57, Richard Henderson wrote: On 1/23/24 01:34, Paolo Bonzini wrote: Unless I'm missing something egregious, the jmp cache is only every populated with a valid entry by the same thread that reads the cache. Therefore, the contents of any valid entry are always consistent and there i

Re: [RFC PATCH 14/34] exec: [CPUTLB] Move PAGE_* macros to common header

2024-01-26 Thread Richard Henderson
On 1/24/24 09:54, Richard Henderson wrote: On 1/20/24 00:40, Anton Johansson wrote: These don't vary across targets and are used in soon-to-be common code (cputlb.c). Signed-off-by: Anton Johansson ---   include/exec/cpu-all.h    | 24   include/exec/cpu-common.h | 30 ++

Re: [PATCH] qapi/migration.json: Fix the member name for MigrationCapability

2024-01-26 Thread Michael Tokarev
19.01.2024 16:53, Han Han: s/@compression/@compress/ Fixes: 864128df46 Please post all patches to qemu-devel@. I'm picking this one up because it is an obvious an trivial fix, but it's still a good idea to let the migration/qapi people to know. Thanks, /mjt Signed-off-by: Han Han --- q

Re: [PATCH v2] qemu-docs: Update options for graphical frontends

2024-01-26 Thread Michael Tokarev
22.01.2024 07:22, Yihuan Pan wrote: The command line options `-ctrl-grab` and `-alt-grab` have been removed in QEMU 7.1. Instead, use the `-display sdl,grab-mod=` option to specify the grab modifiers. Applied to trivial-patches, thanks! /mjt Resolves: https://gitlab.com/qemu-project/qemu/-/i

Re: Why invtsc (CPUID_APM_INVTSC) is unmigratable?

2024-01-26 Thread Xiaoyao Li
On 1/25/2024 6:05 AM, Marcelo Tosatti wrote: On Wed, Jan 24, 2024 at 10:52:46PM +0800, Xiaoyao Li wrote: On 1/23/2024 11:39 PM, Marcelo Tosatti wrote: On Sat, Jan 20, 2024 at 05:44:07PM +0800, Xiaoyao Li wrote: On 1/20/2024 12:14 AM, Marcelo Tosatti wrote: On Fri, Jan 19, 2024 at 02:46:22PM +

Re: [PATCH v2] mailmap: Fix Stefan Weil email

2024-01-26 Thread Michael Tokarev
23.01.2024 11:21, Philippe Mathieu-Daudé: Commit 5204b499a6 ("mailmap: Fix Stefan Weil author email") corrected authorship for patch received at qemu-devel@nongnu.org, correct now for patch received at qemu-triv...@nongnu.org. Update other authorship email for Stefan's commits. Applied to triv

Re: [PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery [ cl

Re: [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers

Re: [PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/fsi/engine-scratchpad.c - d

Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers ap

Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SB

[PATCH 0/3] target/arm: Allow compilation without CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
We've got a switch to disable v7m code since a long time - but it currently cannot be disabled since linking then fails due to missing functions. But thanks to the clean-ups that have been done during the past years, it's not that difficult anymore to finally make it possible to disable CONFIG_ARM_

[PATCH 3/3] target/arm/Kconfig: Stop requiring CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
Now that we made sure that ARM_V7M code only gets compiled if really needed, we can drop the hard requirement for CONFIG_ARM_V7M in the Kconfig file. Signed-off-by: Thomas Huth --- target/arm/Kconfig | 4 1 file changed, 4 deletions(-) diff --git a/target/arm/Kconfig b/target/arm/Kconfig i

[PATCH 2/3] target/arm/tcg/m_helper.c: Include the full helpers only with CONFIG_ARM_V7M

2024-01-26 Thread Thomas Huth
If CONFIG_ARM_V7M is not set, we don't want to include the full-fledged helper functions that require additional functions for linking. The reduced set of the linux-user functions works fine as stubs in this case, so change the #ifdef statement accordingly. Signed-off-by: Thomas Huth --- target/

[PATCH 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-01-26 Thread Thomas Huth
Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth --- target/arm/tcg/cpu-v7m.c | 292 + target/arm/tcg/cpu32.c | 261 - target/arm/tcg/me

Re: [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driv

Re: [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are

Re: [PATCH v11 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedri's signoff. --- docs/specs/fsi.rst | 138 +++ docs/specs/index.rst | 1 + 2 files changed, 139 insertions(+) create m

Re: [PATCH v11 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Cédric Le Goater
On 1/26/24 04:40, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- v11: - Added Cedric as reviewer. Reviewed-by: Cédric Le Goater Thanks, C. --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINE

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Cédric Le Goater
Hello Ninad, On 1/26/24 04:40, Ninad Palsule wrote: Hello, Please review the patch-set version 11. I have incorporated review comments from Cedric. v10: - Moved aspeed-apb2opb to hw/fsi directory - Split some patches. - Fixed crash. - make check Ok: 319

RE: FW: [PATCH] vhost-user: add VIRTIO_F_IN_ORDER and VIRTIO_F_NOTIFICATION_DATA feature

2024-01-26 Thread Wentao Jia
Hi, Eugenio Thanks for you comments, Our team has made new change about the patch, these features in hw/virtio/virtio.h:DEFINE_VIRTIO_COMMON_FEATURES, they are turned off by default , and can be turned on from at qemu command line Do you have comments about this patch? Best Regards Wentao Jia

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: > Le 25/01/2024 à 23:29, Michael Tokarev a écrit : > > Initially in async-teardown.c, but the same construct is used > > elsewhere too. > > > > Signed-off-by: Michael Tokarev > > --- > > include/sysemu/os-posix.h | 1 + > > syste

Re: [PATCH v2 3/4] qapi: blockdev-backup: add discard-source parameter

2024-01-26 Thread Fiona Ebner
Am 25.01.24 um 18:22 schrieb Vladimir Sementsov-Ogievskiy: > > Hmm. Taking maximum is not optimal for usual case without > discard-source: user may want to work in smaller granularity than > source, to save disk space. > > In case with discarding we have two possibilities: > > - either take larg

Re: [PATCH v2 00/14] TCG Plugin inline operation enhancement

2024-01-26 Thread Pierrick Bouvier
A polite ping to request review on this series, especially for scoreboard [02/14] which is the main addition compared to v1. On 1/18/24 07:23, Pierrick Bouvier wrote: This series adds a new thread-safe API to declare inline operation inside plugins. As well, it removes the existing non thread-s

Re: [PATCH v11 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Ninad Palsule
Hello Cedric,     - included an empty hw/fsi/trace-events ] Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Added tag. Thank you for the review. Regards, Ninad

Re: [PATCH v11 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Ninad Palsule
Hello Cedric,   +static uint64_t fsi_scratchpad_read(void *opaque, hwaddr addr, unsigned size) +{ +    FSIScratchPad *s = SCRATCHPAD(opaque); +    int reg = TO_REG(addr); + +    trace_fsi_scratchpad_read(addr, size); + +    if (reg >= FSI_SCRATCHPAD_NR_REGS) { usually, the model logs a GUEST

Re: [PATCH v11 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Ninad Palsule
Hello Cedric, Signed-off-by: Cédric Le Goater Signed-off-by: Ninad Palsule Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad

Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Ninad Palsule
Hello Cedric, + +static void fsi_slave_reset(DeviceState *dev) +{ +    FSISlaveState *s = FSI_SLAVE(dev); +    int i; + +    /* Initialize registers */ +    for (i = 0; i < FSI_SLAVE_CONTROL_NR_REGS; i++) { +    s->regs[i] = 0; +    } memset would be better. Replaced for loop with memset

Re: [PATCH v11 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Ninad Palsule
Hello Cedric, +#include "hw/fsi/fsi.h" + +#include "hw/qdev-properties.h" + +#define ENGINE_CONFIG_NEXT    BE_BIT(0) BE_BIT is not used much. I wonder if we should keep it. Agree. It is only used at couple of places. Removed BE_BIT() Anyhow, Reviewed-by: Cédric Le Goater Added

Re: [PATCH v11 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Ninad Palsule
Hello Cedric, v9:    - Initialized registers.    - Fixed the address check. v11:    - Replaced for loop with memset.    - Removed Joel's review tag as per Cedric. Reviewed-by: Cédric Le Goater Added tag. Thanks for the review. Regards, Ninad

[PATCH] vhost-user: fix the issue of vhost deadlock in nested virtualization

2024-01-26 Thread Hao Chen
I run "dpdk-vdpa" and "qemur-L2" in "qemu-L1". In a nested virtualization environment, "qemu-L2" vhost-user socket sends a "VHOST_USER_IOTLB_MSG" message to "dpdk-vdpa" and blocks waiting for "dpdk-vdpa" to process the message. If "dpdk-vdpa" doesn't complete the processing of the "VHOST_USER_IOTL

Re: [PATCH v11 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Ninad Palsule
Hello Cedric, + +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) +{ +    SysBusDevice *sbd = SYS_BUS_DEVICE(dev); +    AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); +    int i; + Please add a comment regarding the OPBus model here, something like : /*  * TODO: The OPBus

Re: [PATCH] iotests/264: Use iotests.sock_dir for socket creation

2024-01-26 Thread Kevin Wolf
Am 25.01.2024 um 14:52 hat Andrey Drobyshev geschrieben: > If socket path is too long (longer than 108 bytes), socket can't be > opened. This might lead to failure when test dir path is long enough. > Make sure socket is created in iotests.sock_dir to avoid such a case. > > This commit basically

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Kevin Wolf
Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: > There're tests whose logic implies running without O_DIRECT set, > otherwise they fail when running iotests in '-nocache' mode. For these > tests let's add _require_no_o_direct() helper which can be put in the > preabmle and which makes su

Re: [PATCH v11 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Ninad Palsule
Hello Cedric, +QEMU files related to FSI interface: + - ``hw/fsi/aspeed-apb2opb.c`` + - ``include/hw/fsi/aspeed-apb2opb.h`` + - ``hw/fsi/opb.c`` + - ``include/hw/fsi/opb.h`` + - ``hw/fsi/fsi.c`` + - ``include/hw/fsi/fsi.h`` + - ``hw/fsi/fsi-master.c`` + - ``include/hw/fsi/fsi-master.h`` + - ``hw

Re: [PATCH v11 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Ninad Palsule
Hello Cedric, I did some minor comments. v12 should be queued for upstream. I will reorder the Signed-off (mine) trailers. Thanks a lot for detailed review. Regards, Ninad

Re: [PATCH v11 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Ninad Palsule
Hello Cedric, On 1/26/24 02:57, Cédric Le Goater wrote: On 1/26/24 04:40, Ninad Palsule wrote: Added maintainer for IBM FSI model Signed-off-by: Ninad Palsule --- v11:   - Added Cedric as reviewer. Reviewed-by: Cédric Le Goater Added the tag. Thanks for the review. Regards, Ninad

Re: [PATCH 1/2] scripts/coccinelle: Add cpu_env.cocci_template script

2024-01-26 Thread Philippe Mathieu-Daudé
On 25/1/24 17:56, Philippe Mathieu-Daudé wrote: Add a Coccinelle script to convert the following slow path (due to the QOM cast macro): &ARCH_CPU(..)->env to the following fast path: cpu_env(..) Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1

Re: [PATCH 1/3] target/arm: Move v7m-related code from cpu32.c into a separate file

2024-01-26 Thread Philippe Mathieu-Daudé
Hi Thomas, On 26/1/24 09:39, Thomas Huth wrote: Move the code to a separate file so that we do not have to compile it anymore if CONFIG_ARM_V7M is not set. Signed-off-by: Thomas Huth --- target/arm/tcg/cpu-v7m.c | 292 + target/arm/tcg/cpu32.c | 261

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling pci_init_nic_devices() for the rest. Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- hw/i386/pc.c

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Michael Tokarev
26.01.2024 12:06, Daniel P. Berrangé wrote: On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: Le 25/01/2024 à 23:29, Michael Tokarev a écrit : I think the way using sysconf(_SC_OPEN_MAX) is more portable, simpler and cleaner than the one using /proc/self/fd. A fallback that u

[PATCH v12 04/11] hw/fsi: Introduce IBM's fsi-slave model

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The FSI slave: The slave is the terminal point of the FSI bus for FSI symbols addressed to it. Slaves can be cascaded off of one another. The slave's configuration registers appear in address space of the CFAM to whic

[PATCH v12 00/11] Introduce model for IBM's FSI

2024-01-26 Thread Ninad Palsule
Hello, Please review the patch-set version 12. I have incorporated review comments from Cedric. v12: - Minor changes. - Added reviewed by tags. Ninad Palsule (11): hw/fsi: Introduce IBM's Local bus hw/fsi: Introduce IBM's scratchpad device hw/fsi: Introduce IBM's FSI Bus hw/fsi: Intro

[PATCH v12 10/11] hw/fsi: Added FSI documentation

2024-01-26 Thread Ninad Palsule
Documentation for IBM FSI model. Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff. --- docs/specs/fsi.rst | 126 +++ docs/specs/index.rst | 1 + 2 files changed, 127 insertions(+) create mode 100644 docs/specs/fsi.rst diff --git a/d

[PATCH v12 09/11] hw/fsi: Added qtest

2024-01-26 Thread Ninad Palsule
Added basic qtests for FSI model. Acked-by: Thomas Huth Signed-off-by: Ninad Palsule --- v11: - Removed Cedric's signoff --- tests/qtest/aspeed-fsi-test.c | 205 ++ tests/qtest/meson.build | 1 + 2 files changed, 206 insertions(+) create mode 100644 te

[PATCH v12 02/11] hw/fsi: Introduce IBM's scratchpad device

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The scratchpad provides a set of non-functional registers. The firmware is free to use them, hardware does not support any special management support. The scratchpad registers can be read or written from LBUS slave. T

[PATCH v12 11/11] hw/fsi: Update MAINTAINER list

2024-01-26 Thread Ninad Palsule
Added maintainer for IBM FSI model Reviewed-by: Cédric Le Goater Signed-off-by: Ninad Palsule --- v11: - Added Cedric as reviewer. --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dfaca8323e..39deb8ee1f 100644 --- a/MAINTAINERS +++ b/

[PATCH v12 01/11] hw/fsi: Introduce IBM's Local bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The LBUS is modelled to maintain mapped memory for the devices. The memory is mapped after CFAM config, peek table and FSI slave registers. Signed-off-by: Andrew Jeffery [ clg: - removed lbus_add_device() bc unused

[PATCH v12 03/11] hw/fsi: Introduce IBM's FSI Bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where FSI bus is introduced. The FSI bus is a simple bus where FSI master is attached. Signed-off-by: Andrew Jeffery [ clg: - removed include/hw/fsi/engine-scratchpad.h and hw/fsi/engine-scratchpad.c - dropped FSI_SCRATCHPAD - included FSIBus def

[PATCH v12 05/11] hw/fsi: Introduce IBM's cfam

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. The Common FRU Access Macro (CFAM), an address space containing various "engines" that drive accesses on busses internal and external to the POWER chip. Examples include the SBEFIFO and I2C masters. The engines hang o

[PATCH v12 06/11] hw/fsi: Introduce IBM's FSI master

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. This commit models the FSI master. CFAM is hanging out of FSI master which is a bus controller. The FSI master: A controller in the platform service processor (e.g. BMC) driving CFAM engine accesses into the POWER c

[PATCH v12 08/11] hw/arm: Hook up FSI module in AST2600

2024-01-26 Thread Ninad Palsule
This patchset introduces IBM's Flexible Service Interface(FSI). Time for some fun with inter-processor buses. FSI allows a service processor access to the internal buses of a host POWER processor to perform configuration or debugging. FSI has long existed in POWER processes and so comes with some

[PATCH v12 07/11] hw/fsi: Aspeed APB2OPB & On-chip peripheral bus

2024-01-26 Thread Ninad Palsule
This is a part of patchset where IBM's Flexible Service Interface is introduced. An APB-to-OPB bridge enabling access to the OPB from the ARM core in the AST2600. Hardware limitations prevent the OPB from being directly mapped into APB, so all accesses are indirect through the bridge. The On-Chip

Re: [PATCH trivial 1/2] close_all_open_fd(): move to oslib-posix.c

2024-01-26 Thread Daniel P . Berrangé
On Fri, Jan 26, 2024 at 01:45:39PM +0300, Michael Tokarev wrote: > 26.01.2024 12:06, Daniel P. Berrangé wrote: > > On Fri, Jan 26, 2024 at 08:44:13AM +0100, Laurent Vivier wrote: > > > Le 25/01/2024 à 23:29, Michael Tokarev a écrit : > > > > > I think the way using sysconf(_SC_OPEN_MAX) is more p

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Andrey Drobyshev
On 1/26/24 12:24, Kevin Wolf wrote: > Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: >> There're tests whose logic implies running without O_DIRECT set, >> otherwise they fail when running iotests in '-nocache' mode. For these >> tests let's add _require_no_o_direct() helper which can be

Re: [PATCH v3 01/46] net: add qemu_{configure, create}_nic_device(), qemu_find_nic_info()

2024-01-26 Thread Thomas Huth
On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Most code which directly accesses nd_table[] and nb_nics uses them for one of two things. Either "I have created a NIC device and I'd like a configuration for it", or "I will create a NIC device *if* there is a configuration for

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: > On 08/01/2024 21.26, David Woodhouse wrote: > > From: David Woodhouse > > > > Eliminate direct access to nd_table[] and nb_nics by processing the the > > Xen and ISA NICs first and then calling pci_init_nic_devices() for the > > rest. > > >

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread Thomas Huth
On 26/01/2024 12.13, David Woodhouse wrote: On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: On 08/01/2024 21.26, David Woodhouse wrote: From: David Woodhouse Eliminate direct access to nd_table[] and nb_nics by processing the the Xen and ISA NICs first and then calling pci_init_nic_devi

Re: [PATCH 1/2] scripts/coccinelle: Add cpu_env.cocci_template script

2024-01-26 Thread Paolo Bonzini
On Fri, Jan 26, 2024 at 11:38 AM Philippe Mathieu-Daudé wrote: > > On 25/1/24 17:56, Philippe Mathieu-Daudé wrote: > > Add a Coccinelle script to convert the following slow path > > (due to the QOM cast macro): > > > >&ARCH_CPU(..)->env > > > > to the following fast path: > > > >cpu_env(..

Re: [PATCH v3 05/46] hw/i386/pc: use qemu_get_nic_info() and pci_init_nic_devices()

2024-01-26 Thread David Woodhouse
On Fri, 2024-01-26 at 12:20 +0100, Thomas Huth wrote: > On 26/01/2024 12.13, David Woodhouse wrote: > > On Fri, 2024-01-26 at 11:43 +0100, Thomas Huth wrote: > > > On 08/01/2024 21.26, David Woodhouse wrote: > > > > From: David Woodhouse > > > > > > > > Eliminate direct access to nd_table[] and n

Re: [PATCH] iotests: don't run tests requiring cached writes in '-nocache' mode

2024-01-26 Thread Kevin Wolf
Am 26.01.2024 um 12:04 hat Andrey Drobyshev geschrieben: > On 1/26/24 12:24, Kevin Wolf wrote: > > Am 11.12.2023 um 14:32 hat Andrey Drobyshev geschrieben: > >> There're tests whose logic implies running without O_DIRECT set, > >> otherwise they fail when running iotests in '-nocache' mode. For th

Re: [PATCH] iotests/277: Use iotests.sock_dir for socket creation

2024-01-26 Thread Kevin Wolf
Am 24.01.2024 um 17:22 hat Andrey Drobyshev geschrieben: > If socket path is too long (longer than 108 bytes), socket can't be > opened. This might lead to failure when test dir path is long enough. > Make sure socket is created in iotests.sock_dir to avoid such a case. > > This commit basically

Re: [PATCH v4] hw/char/imx_serial: Implement receive FIFO and ageing timer for imx serial.

2024-01-26 Thread Peter Maydell
On Thu, 25 Jan 2024 at 15:22, Rayhan Faizel wrote: > > This patch implements a 32 half word FIFO as per imx serial device > specifications. If a non empty FIFO is below the trigger level, an ageing > timer will tick for a duration of 8 characters. On expiry, AGTIM will be set > triggering an inter

  1   2   3   4   >