Re: [PATCH v11 04/11] hw/fsi: Introduce IBM's fsi-slave model

[Ninad Palsule]

Hello Cedric,

+
+static void fsi_slave_reset(DeviceState *dev)
+{
+    FSISlaveState *s = FSI_SLAVE(dev);
+    int i;
+
+    /* Initialize registers */
+    for (i = 0; i < FSI_SLAVE_CONTROL_NR_REGS; i++) {
+        s->regs[i] = 0;
+    }

memset would be better.

Replaced for loop with memset.

with that fixed,


Reviewed-by: Cédric Le Goater <c...@kaod.org>

Added tag.

Thanks for the review.

Regards,

Ninad