Hello Cedric,
+ +static void fsi_aspeed_apb2opb_realize(DeviceState *dev, Error **errp) +{ + SysBusDevice *sbd = SYS_BUS_DEVICE(dev); + AspeedAPB2OPBState *s = ASPEED_APB2OPB(dev); + int i; +Please add a comment regarding the OPBus model here, something like : /* * TODO: The OPBus model initializes the OPB address space in * the .instance_init handler and this is problematic for test * device-introspect-test. To avoid a memory corruption and a QEMU * crash, qbus_init() should be called from realize(). Something to * improve. Possibly, OPBus could also be removed. */
Added comment.
with that, Reviewed-by: Cédric Le Goater <c...@kaod.org>
Added tag. Thanks for the review. Regards, Ninad
