Re: [PATCH] migration: Simplify initial conditionals in migration for better readability

2024-01-04 Thread Peter Xu
On Thu, Jan 04, 2024 at 01:13:48PM +0530, Het Gala wrote: > Ping. In-case this patch has been missed out. Waiting for other maintainers > to respond. Thanks! > > On 11/12/23 6:43 pm, Het Gala wrote: > > Ping? Waiting for other maintainers to respond on this patch > > On 05/12/23 6:28 pm, Fabiano

Re: [PATCH 0/2] backends/iommufd: Remove mutex

2024-01-04 Thread Cédric Le Goater
On 1/2/24 13:32, Cédric Le Goater wrote: Hello ! Coverity has some reports regarding the IOMMUFDBackend mutex. Since the IOMMUFDBackend routines are called from the QEMU main thread, this series simply suggests removing the mutex and rely on the BQL to handle concurrent access. Thanks, C. Céd

Re: [PATCH v2 10/43] qtest: bump pxe-test timeout to 10 minutes

2024-01-04 Thread Daniel P . Berrangé
On Wed, Jan 03, 2024 at 06:43:52PM +0100, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 3/1/24 18:33, Alex Bennée wrote: > > From: Daniel P. Berrangé > > > > The pxe-test uses the boot_sector_test() function, and that already > > uses a timeout of 600 seconds. So adjust the timeout on the me

Re: [PATCH v6 11/11] virtio-gpu: make blob scanout use dmabuf fd

2024-01-04 Thread Pierre-Eric Pelloux-Prayer
Le 21/12/2023 à 07:25, Akihiko Odaki a écrit : On 2023/12/19 16:53, Huang Rui wrote: From: Robert Beckett This relies on a virglrenderer change to include the dmabuf fd when returning resource info. Signed-off-by: Robert Beckett Signed-off-by: Huang Rui --- Changes in v6: - Add scanout_b

Re: [PATCH] load_elf: fix iterator type in glue

2024-01-04 Thread Peter Maydell
On Tue, 26 Dec 2023 at 12:04, Philippe Mathieu-Daudé wrote: > > Hi, > > On 21/12/23 09:08, Anastasia Belova wrote: > > file_size is uint32_t, so j < file_size should be > > uint32_t too. > > file_size is of elf_word type, which is either uint32_t > or uint64_t. > > Your explanation is not very cle

Re: [PATCH 21/35] target/arm: Add FEAT_NV to max, neoverse-n2, neoverse-v1 CPUs

2024-01-04 Thread Peter Maydell
On Fri, 29 Dec 2023 at 11:37, Marcin Juszkiewicz wrote: > > W dniu 18.12.2023 o 12:32, Peter Maydell pisze: > > > Enable FEAT_NV on the 'max' CPU, and stop filtering it out for the > > Neoverse N2 and Neoverse V1 CPUs. We continue to downgrade FEAT_NV2 > > support to FEAT_NV for the latter two CP

Re: QEMU developers call

2024-01-04 Thread Stefan Hajnoczi
On Tue, 2 Jan 2024 at 20:54, Peter Xu wrote: > If I'd make a list of good candidates, I'll probably be the last one out of > tens, especially considering my current timezone. :-D Does this mean you will handle the community call? Thanks, Stefan

Re: [PATCH v2 38/43] plugins: add an API to read registers

2024-01-04 Thread Akihiko Odaki
On 2024/01/04 2:33, Alex Bennée wrote: We can only request a list of registers once the vCPU has been initialised so the user needs to use either call the get function on vCPU initialisation or during the translation phase. We don't expose the reg number to the plugin instead hiding it behind an

Re: QEMU developers call

2024-01-04 Thread Peter Xu
On Thu, Jan 04, 2024 at 06:46:41AM -0500, Stefan Hajnoczi wrote: > On Tue, 2 Jan 2024 at 20:54, Peter Xu wrote: > > If I'd make a list of good candidates, I'll probably be the last one out of > > tens, especially considering my current timezone. :-D > > Does this mean you will handle the communit

Re: [PATCH v3 0/5] Make Big QEMU Lock naming consistent

2024-01-04 Thread Akihiko Odaki
On 2024/01/03 0:35, Stefan Hajnoczi wrote: v3: - Rebase - Define bql_lock() macro on a single line [Akihiko Odaki] v2: - Rename APIs bql_*() [PeterX] - Spell out "Big QEMU Lock (BQL)" in doc comments [PeterX] - Rename "iolock" variables in hw/remote/mpqemu-link.c [Harsh] - Fix bql_auto_lock() ind

Re: [PATCH v6 03/11] virtio-gpu: Support context init feature with virglrenderer

2024-01-04 Thread Akihiko Odaki
On 2023/12/19 16:53, Huang Rui wrote: Patch "virtio-gpu: CONTEXT_INIT feature" has added the context_init feature flags. We would like to enable the feature with virglrenderer, so add to create virgl renderer context with flags using context_id when valid. Originally-by: Antonio Caggiano Signed

Re: [PATCH v2 38/43] plugins: add an API to read registers

2024-01-04 Thread Alex Bennée
Akihiko Odaki writes: > On 2024/01/04 2:33, Alex Bennée wrote: >> We can only request a list of registers once the vCPU has been >> initialised so the user needs to use either call the get function on >> vCPU initialisation or during the translation phase. >> We don't expose the reg number to the

Re: [PATCH v3 0/4] virtio: Refactor vhost input stub

2024-01-04 Thread Alex Bennée
Leo Yan writes: > This series is to refactor vhost stub vhost-user-input. > > Since vhost input stub requires set_config() callback for communication > event configurations between the backend and the guest, patch 01 is a > preparison for support set_config() callback in vhost-user-base. Queued

Re: [PATCH v6 1/2] qom: new object to associate device to numa node

2024-01-04 Thread Ankit Agrawal
>> However, I'll leave it up to those more familiar with the QEMU numa >> control interface design to comment on whether this approach is preferable >> to making the gi part of the numa node entry or doing it like hmat. >> -numa srat-gi,node-id=10,gi-pci-dev=dev1 > > The current way of acpi-generic

Re: [PATCH v4 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2024-01-04 Thread Philippe Mathieu-Daudé
On 21/12/23 22:32, Inès Varhol wrote: This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mat

Re: [PATCH v4 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2024-01-04 Thread Philippe Mathieu-Daudé
On 21/12/23 22:32, Inès Varhol wrote: This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC as well as a dedicated documentation file. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Phili

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread Philippe Mathieu-Daudé
+Markus for QOM tree On 28/12/23 17:19, Inès Varhol wrote: Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 596 ++ 2 files changed, 601 insertions(+) create mode 100644

Re: [PATCH v4 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2024-01-04 Thread Philippe Mathieu-Daudé
On 21/12/23 22:32, Inès Varhol wrote: This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC as well as a dedicated documentation file. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Phili

Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread Philippe Mathieu-Daudé
On 28/12/23 17:19, Inès Varhol wrote: Although very similar to the STM32F4xx EXTI, STM32L4x5 EXTI generates more than 32 event/interrupt requests and thus uses more registers than STM32F4xx EXTI which generates 23 event/interrupt requests. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol

Re: [PATCH v5 3/3] hw/arm: Connect STM32L4x5 EXTI to STM32L4x5 SoC

2024-01-04 Thread Philippe Mathieu-Daudé
On 28/12/23 17:19, Inès Varhol wrote: Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1 + hw/arm/stm32l4x5_soc.c | 56 -- include/hw/arm/stm32l4x5_soc.h | 3 ++ 3 files changed, 58 insertions(+), 2 dele

Re: [PATCH v3 3/3] hw/arm: Connect STM32L4x5 SYSCFG to STM32L4x5 SoC

2024-01-04 Thread Philippe Mathieu-Daudé
On 29/12/23 17:47, Inès Varhol wrote: The SYSCFG input GPIOs aren't connected yet. When the STM32L4x5 GPIO device will be implemented, its output GPIOs will be connected to the SYSCFG input GPIOs. Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- hw/arm/Kconfig | 1

Re: [PATCH v2 38/43] plugins: add an API to read registers

2024-01-04 Thread Akihiko Odaki
On 2024/01/04 21:22, Alex Bennée wrote: Akihiko Odaki writes: On 2024/01/04 2:33, Alex Bennée wrote: We can only request a list of registers once the vCPU has been initialised so the user needs to use either call the get function on vCPU initialisation or during the translation phase. We don'

Re: [PATCH v3 2/3] tests/qtest: Add STM32L4x5 SYSCFG QTest testcase

2024-01-04 Thread Philippe Mathieu-Daudé
On 29/12/23 17:47, Inès Varhol wrote: Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 3 +- tests/qtest/stm32l4x5_syscfg-test.c | 408 2 files changed, 410 insertions(+), 1 deletion

Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread Samuel Tardieu
Philippe Mathieu-Daudé writes: This doesn't build: ../../hw/misc/stm32l4x5_exti.c:172:9: error: expected expression const uint32_t set1 = value & ~DIRECT_LINE_MASK1; […] I could build using: -case EXTI_SWIER1: +case EXTI_SWIER1: { Out or curiosity, which C compiler or optio

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread Philippe Mathieu-Daudé
On 28/12/23 17:19, Inès Varhol wrote: Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 5 + tests/qtest/stm32l4x5_exti-test.c | 596 ++ 2 files changed, 601 insertions(+) create mode 100644 tests/qtest/stm32l4x5_

Re: [PATCH v3 2/3] tests/qtest: Add STM32L4x5 SYSCFG QTest testcase

2024-01-04 Thread Philippe Mathieu-Daudé
On 29/12/23 17:47, Inès Varhol wrote: Acked-by: Alistair Francis Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol --- tests/qtest/meson.build | 3 +- tests/qtest/stm32l4x5_syscfg-test.c | 408 2 files changed, 410 insertions(+), 1 deletion

Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread Philippe Mathieu-Daudé
On 4/1/24 14:23, Samuel Tardieu wrote: Philippe Mathieu-Daudé writes: This doesn't build: ../../hw/misc/stm32l4x5_exti.c:172:9: error: expected expression     const uint32_t set1 = value & ~DIRECT_LINE_MASK1; […] I could build using: -    case EXTI_SWIER1: +    case EXTI_SWIER1: { Out

[PATCH] target/i386/sev: Fix a segfault in sev_kvm_init

2024-01-04 Thread Srikanth Aithal
Propogate error code using errp in sev_kvm_init. Before fix: qemu-system-x86_64: sev_kvm_init: guest policy requires SEV-ES, but host SEV-ES support unavailable 27747 Segmentation fault (core dumped) After fix: qemu-system-x86_64: sev_kvm_init: guest policy requires SEV-ES, but host SEV-ES s

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:33, Philippe Mathieu-Daudé a écrit : > On 28/12/23 17:19, Inès Varhol wrote: > > > Signed-off-by: Arnaud Minier arnaud.min...@telecom-paris.fr > > Signed-off-by: Inès Varhol ines.var...@telecom-paris.fr > > --- > > tests/qtest/meson.build | 5 + > > tests/qtest/stm32

Re: [PATCH v5 2/3] tests/qtest: Add STM32L4x5 EXTI QTest testcase

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:05, Philippe Mathieu-Daudé a écrit : Hello, > > +static void test_edge_selector(void) > > +{ > > + enable_nvic_irq(EXTI0_IRQ); > > + > > + / Configure EXTI line 0 irq on rising edge */ > > + qtest_set_irq_in(global_qtest, "/machine/unattached/device[0]/exti", > >

Re: [PATCH v3 0/3] Add device STM32L4x5 SYSCFG

2024-01-04 Thread Philippe Mathieu-Daudé
Hi Inès, On 29/12/23 17:47, Inès Varhol wrote: Based-on: <20231228161944.303768-1-ines.var...@telecom-paris.fr> ([PATCH v5 0/3] Add device STM32L4x5 EXTI) Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol Inès Varhol (3): hw/misc: Implement STM32L4x5 SYSCFG tests/qtest: Add STM3

Re: [PATCH] target/i386/sev: Fix a segfault in sev_kvm_init

2024-01-04 Thread Philippe Mathieu-Daudé
On 4/1/24 11:48, Srikanth Aithal wrote: Propogate error code using errp in sev_kvm_init. Before fix: qemu-system-x86_64: sev_kvm_init: guest policy requires SEV-ES, but host SEV-ES support unavailable 27747 Segmentation fault (core dumped) After fix: qemu-system-x86_64: sev_kvm_init: guest

Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread Samuel Tardieu
On 04/01/2024 14:40, Philippe Mathieu-Daudé wrote: On 4/1/24 14:23, Samuel Tardieu wrote: Philippe Mathieu-Daudé writes: This doesn't build: ../../hw/misc/stm32l4x5_exti.c:172:9: error: expected expression     const uint32_t set1 = value & ~DIRECT_LINE_MASK1; […] I could build using: -

Re: [PATCH v5 1/3] hw/misc: Implement STM32L4x5 EXTI

2024-01-04 Thread inesvarhol
Le jeudi 4 janvier 2024 à 14:40, Philippe Mathieu-Daudé a écrit : > If you don't have access to similar compiler, you can fork on GitLab > and push a branch to trigger the CI; I expect it to fail. Thanks for the tip ! Ines Varhol

Re: virtio-pci in qemu-system-arm is broken in 8.2

2024-01-04 Thread Peter Maydell
On Thu, 21 Dec 2023 at 22:00, Alex Bennée wrote: > modified tests/avocado/tuxrun_baselines.py > @@ -168,7 +168,7 @@ def run_tuxtest_tests(self, haltmsg): > def common_tuxrun(self, >csums=None, >dt=None, > - drive="virtio-b

[PATCH] hw/arm: Add missing QOM parent for v7-M SoCs

2024-01-04 Thread Philippe Mathieu-Daudé
QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/msf2-som.c | 1 + hw/arm/netduino2.c | 1 + hw/arm/netduinoplus2.c | 1 + hw/arm/olimex-stm32-h405.c | 1 +

[PATCH v2 0/7] migration cleanups and testing improvements

2024-01-04 Thread Fabiano Rosas
No change, just rebased on latest migration PR: [PULL 00/26] Migration 20240104 patches https://lore.kernel.org/r/20240104043213.431566-1-pet...@redhat.com v1: https://lore.kernel.org/r/20231124161432.3515-1-faro...@suse.de These are some general cleanups and improvements to testing and

[PATCH v2 7/7] tests/qtest/migration: Use the new migration_test_add

2024-01-04 Thread Fabiano Rosas
Replace the tests registration with the new function that prints tests names. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- tests/qtest/migration-test.c | 215 ++- 1 file changed, 112 insertions(+), 103 deletions(-) diff --git a/tests/qtest/migration-te

[PATCH v2 2/7] migration/multifd: Remove QEMUFile from where it is not needed

2024-01-04 Thread Fabiano Rosas
Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/multifd.c | 12 ++-- migration/multifd.h | 4 ++-- migration/ram.c | 15 +++ 3 files changed, 15 insertions(+), 16 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c index 3e650f5da0..2dbc

[PATCH v2 6/7] tests/qtest/migration: Add a wrapper to print test names

2024-01-04 Thread Fabiano Rosas
Our usage of gtest results in us losing the very basic functionality of "knowing which test failed". The issue is that gtest only prints test names ("paths" in gtest parlance) once the test has finished, but we use asserts in the tests and crash gtest itself before it can print anything. We also us

[PATCH v2 1/7] migration/multifd: Remove MultiFDPages_t::packet_num

2024-01-04 Thread Fabiano Rosas
This was introduced by commit 34c55a94b1 ("migration: Create multipage support") and never used. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/multifd.c | 1 - migration/multifd.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/migration/multifd.c b/migration/multifd.c

[PATCH v2 5/7] tests/qtest/migration: Print migration incoming errors

2024-01-04 Thread Fabiano Rosas
We're currently just asserting when incoming migration fails. Let's print the error message from QMP as well. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- tests/qtest/migration-helpers.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qtest/migration-helpers.c b/tests/

[PATCH v2 3/7] migration/multifd: Change multifd_pages_init argument

2024-01-04 Thread Fabiano Rosas
The 'size' argument is actually the number of pages that fit in a multifd packet. Change it to uint32_t and rename. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/multifd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/multifd.c b/migratio

[PATCH v2 4/7] migration: Report error in incoming migration

2024-01-04 Thread Fabiano Rosas
We're not currently reporting the errors set with migrate_set_error() when incoming migration fails. Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu --- migration/migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration/migration.c b/migration/migration.c index 454cd4

Re: virtio-pci in qemu-system-arm is broken in 8.2

2024-01-04 Thread Peter Maydell
On Thu, 4 Jan 2024 at 14:09, Peter Maydell wrote: > > On Thu, 21 Dec 2023 at 22:00, Alex Bennée wrote: > > modified tests/avocado/tuxrun_baselines.py > > @@ -168,7 +168,7 @@ def run_tuxtest_tests(self, haltmsg): > > def common_tuxrun(self, > >csums=None, > >

Re: [PATCH RESEND v3 02/10] crypto: Support generic LUKS encryption

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:04PM +0800, Hyman Huang wrote: > By enhancing the LUKS driver, it is possible to enable > the detachable LUKS header and, as a result, achieve > general encryption for any disk format that QEMU has > supported. > > Take the qcow2 as an example, the usage of the generi

Re: [PATCH RESEND v3 03/10] qapi: Make parameter 'file' optional for BlockdevCreateOptionsLUKS

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:05PM +0800, Hyman Huang wrote: > To support detached LUKS header creation, make the existing 'file' > filed in BlockdevCreateOptionsLUKS optional, while also adding an > extra optional 'header' field in the next commit. > > Signed-off-by: Hyman Huang > --- > block/c

Re: virtio-pci in qemu-system-arm is broken in 8.2

2024-01-04 Thread Peter Maydell
On Thu, 21 Dec 2023 at 11:51, Michael Tokarev wrote: > > It looks like virtio-pci is entirely broke in qemu-system-arm, at least in tcg > mode running on x86. The guest (current linux system) just does not detect > any virtio-pci devices at all. > > When 8.1 is booting, the following messages are

Re: [PATCH RESEND v3 06/10] block: Support detached LUKS header creation using blockdev-create

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:08PM +0800, Hyman Huang wrote: > The LUKS disk with detached header consists of a separate LUKS > header and payload. This LUKS disk type should be formatted > as follows: > > 1. add the secret to lock/unlock the cipher stored in the >detached LUKS header > $ virs

Re: [PATCH RESEND v3 05/10] crypto: Mark the payload_offset_sector invalid for detached LUKS header

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:07PM +0800, Hyman Huang wrote: > Set the payload_offset_sector to a value that is nearly never reached > in order to mark it as invalid and indicate that 0 should be the offset > of the read/write operation on the 'file' protocol blockdev node. > > Signed-off-by: Hyma

Re: [PATCH RESEND v3 04/10] crypto: Introduce creation option and structure for detached LUKS header

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:06PM +0800, Hyman Huang wrote: > Introduce 'header' field in BlockdevCreateOptionsLUKS to support > detached LUKS header creation. Meanwhile, introduce header-related > field in QCryptoBlock. > > Signed-off-by: Hyman Huang > --- > crypto/blockpriv.h | 3 +++ > qap

Re: [PATCH RESEND v3 08/10] crypto: Introduce 'detached-header' field in QCryptoBlockInfoLUKS

2024-01-04 Thread Daniel P . Berrangé
On Mon, Dec 25, 2023 at 01:45:10PM +0800, Hyman Huang wrote: > When querying the LUKS disk with the qemu-img tool or other APIs, > add information about whether the LUKS header is detached. > > Additionally, update the test case with the appropriate > modification. > > Signed-off-by: Hyman Huang

[PATCH v6 7/7] x86: qemu: Enable truetype fonts

2024-01-04 Thread Simon Glass
Enable this feature to provide a larger font choice and more attractive menus. Expand the ROM for x86_64 to 2MB to make space for the font. Signed-off-by: Simon Glass --- Changes in v6: - Move 'Avoid unbinding devices in use by bootflows' to another series Changes in v3: - Add new patch to enab

[PATCH v6 0/7] Resolve issues with booting distros on x86

2024-01-04 Thread Simon Glass
This little series reprises the EFI-video fix, fixes a USB problem and enables a boot script for coreboot. It also moves to truetype fonts for coreboot and qemu-x86, since the menus look much better and there are no strong size constraints. With these changes it is possible to boot a Linux distro

[PATCH v6 6/7] x86: qemu: Expand ROM size

2024-01-04 Thread Simon Glass
Expand the ROM for x86_64 to 2MB to make space for the font, as it is already on the edge. Signed-off-by: Simon Glass --- (no changes since v1) board/emulation/qemu-x86/Kconfig | 3 ++- configs/qemu-x86_64_defconfig| 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/bo

Re: [PATCH 17/35] target/arm: Always use arm_pan_enabled() when checking if PAN is enabled

2024-01-04 Thread Peter Maydell
On Wed, 27 Dec 2023 at 22:50, Richard Henderson wrote: > > On 12/18/23 22:32, Peter Maydell wrote: > > Currently the code in target/arm/helper.c mostly checks the PAN bits > > in env->pstate or env->uncached_cpsr directly when it wants to know > > if PAN is enabled, because in most callsites we kn

Re: [PATCH 24/35] target/arm: Handle FEAT_NV2 changes to when SPSR_EL1.M reports EL2

2024-01-04 Thread Peter Maydell
On Wed, 27 Dec 2023 at 23:06, Richard Henderson wrote: > > On 12/18/23 22:32, Peter Maydell wrote: > > With FEAT_NV2, the condition for when SPSR_EL1.M should report that > > an exception was taken from EL2 changes. > > > > Signed-off-by: Peter Maydell > > --- > > target/arm/helper.c | 16 +

[PATCH 1/9] scripts/ci: Do not enforce gitlab-runner path

2024-01-04 Thread Philippe Mathieu-Daudé
Distributions are not forced to put gitlab-runner binary in /usr/bin (as long as it is in $PATH). Signed-off-by: Philippe Mathieu-Daudé --- FWIW this file seems to use legacy options: TASK [Register the gitlab-runner] *

[PATCH 2/9] scripts/ci: Do not restrict spice package to x86/arm hosts

2024-01-04 Thread Philippe Mathieu-Daudé
Allow installing spice-server-devel package on any non-ppc64le host, as per commit 556ede028d ("scripts/ci/setup: spice-server only on x86 aarch64") describes: "Spice server not available in ppc64le". Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 7 +++

[RFC PATCH 3/9] scripts/ci: Split EL8 specific packages out of Centos8 list

2024-01-04 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml index 32ac0a74f4..60b751018f 100644 --- a/scripts/ci/

Re: [PATCH v2] scripts/checkpatch: Support codespell checking

2024-01-04 Thread Zhao Liu
Hi Samuel, On Wed, Jan 03, 2024 at 03:36:59PM +0100, Samuel Tardieu wrote: > Date: Wed, 03 Jan 2024 15:36:59 +0100 > From: Samuel Tardieu > Subject: Re: [PATCH v2] scripts/checkpatch: Support codespell checking > > > + --codespellUse the codespell dictionary for > > spelling/typ

[RFC PATCH 5/9] scripts/ci: Restrict libpmem-devel package to x86 hosts

2024-01-04 Thread Philippe Mathieu-Daudé
libpmem-devel is not available for all host archs. Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml index 9

[RFC PATCH 6/9] scripts/ci: Install libxdp-devel on x86 hosts

2024-01-04 Thread Philippe Mathieu-Daudé
libxdp is arch-specific, and in use since commit cb039ef3d9 ("net: add initial support for AF_XDP network backend"). Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/ci/setup/build-environ

[RFC PATCH 4/9] scripts/ci: Update Centos8 package list

2024-01-04 Thread Philippe Mathieu-Daudé
Update Centos 8 package list running: $ lcitool variables -f json centos-stream-8 qemu \ | jq -r '.pkgs[]' \ | xargs -n 1 echo " -" On libvirt-ci commit e9e7d3bf ("facts: enable gtk-vnc2-devel on almalinux 8 / centos stream 8"). Signed-off-by: Philippe Mathieu-Daudé --- scripts

[RFC PATCH 7/9] scripts/ci: Install RH packages on RH derivative distros

2024-01-04 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-environment.yml index 8a6855f472..6baa539b46 100644 --- a/scripts/ci/setup/bui

[RFC PATCH 8/9] scripts/ci: Update Ubuntu packages list

2024-01-04 Thread Philippe Mathieu-Daudé
Update Ubuntu 22.04 package list running: $ lcitool variables -f json ubuntu-2204 qemu \ | jq -r '.pkgs[]' \ | xargs -n 1 echo " -" On libvirt-ci commit e9e7d3bf ("facts: enable gtk-vnc2-devel on almalinux 8 / centos stream 8"). Signed-off-by: Philippe Mathieu-Daudé --- scripts

[RFC PATCH 0/9] scripts/ci: Consolidate Ansible playbook rules

2024-01-04 Thread Philippe Mathieu-Daudé
Hi, The CI Ansible playbook scripts failed when trying to provision a openEuler instance. I was going to do a manual installation, but Alex strongly suggested to keep using Ansible, implicitly asking to fix the scripts :) This is what this series does. Note, when libvirt-ci is upgraded, we neglec

[RFC PATCH 9/9] scripts/ci: Restrict libpmem-dev and libxen-dev packages to x86 hosts

2024-01-04 Thread Philippe Mathieu-Daudé
libpmem-dev / libxen-dev are not available for all host archs. Signed-off-by: Philippe Mathieu-Daudé --- scripts/ci/setup/build-environment.yml | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/scripts/ci/setup/build-environment.yml b/scripts/ci/setup/build-envi

Re: [PATCH] target/i386/sev: Fix a segfault in sev_kvm_init

2024-01-04 Thread Zhao Liu
On Thu, Jan 04, 2024 at 04:18:20PM +0530, Srikanth Aithal wrote: > Date: Thu, 4 Jan 2024 16:18:20 +0530 > From: Srikanth Aithal > Subject: [PATCH] target/i386/sev: Fix a segfault in sev_kvm_init > X-Mailer: git-send-email 2.34.1 > > Propogate error code using errp in sev_kvm_init. > > Before fix

Re: [PATCH] docs: use "buses" rather than "busses"

2024-01-04 Thread Zhao Liu
On Wed, Jan 03, 2024 at 06:28:17PM +0100, Samuel Tardieu wrote: > Date: Wed, 3 Jan 2024 18:28:17 +0100 > From: Samuel Tardieu > Subject: [PATCH] docs: use "buses" rather than "busses" > X-Mailer: git-send-email 2.42.0 > > If "busses" might be encountered as a plural of "bus" (5 instances), > the

[PATCH v2 0/2] Adjust the output of x-query-virtio-status

2024-01-04 Thread Hyman Huang
v2: - Changing the hmp_virtio_dump_xxx function signatures to implement the bitmap decoding, suggested by Philippe. Please review, thanks, Yong This patchset is derived from the series: https://lore.kernel.org/qemu-devel/cover.1699793550.git.yong.hu...@smartx.com/ Please go to the link to see

[PATCH v2 2/2] hmp: Drop unknown feature and status bits

2024-01-04 Thread Hyman Huang
The QMP command "x-query-virtio-status" outputs the full feature and status bit information, so there is no need to maintain it in the HMP output; drop it. Signed-off-by: Hyman Huang --- hw/virtio/virtio-hmp-cmds.c | 13 - 1 file changed, 13 deletions(-) diff --git a/hw/virtio/virti

[PATCH v2 1/2] qapi/virtio: Keep feature and status bits in the QMP output

2024-01-04 Thread Hyman Huang
Maintain the feature and status bits in the x-query-virtio-status output and, as usual, add human-readable output only in HMP. Applications may find it useful to compare features and status information directly. An upper application, for example, could use the QMP command x-query-virtio-status to

Re: [PATCH 26/35] target/arm: Implement FEAT_NV2 redirection of sysregs to RAM

2024-01-04 Thread Peter Maydell
On Wed, 27 Dec 2023 at 23:55, Richard Henderson wrote: > > On 12/18/23 22:32, Peter Maydell wrote: > > +if (s->nv && s->nv2 && ri->nv2_redirect_offset) { > > Again, s->nv test is redundant. Fixed, thanks. > > +/* > > + * Some registers always redirect to memory; some only do

Re: [PATCH] qtest: use correct boolean type for failover property

2024-01-04 Thread Zhao Liu
On Wed, Jan 03, 2024 at 12:30:05PM +, Daniel P. Berrangé wrote: > Date: Wed, 3 Jan 2024 12:30:05 + > From: "Daniel P. Berrangé" > Subject: [PATCH] qtest: use correct boolean type for failover property > > QMP device_add does not historically validate the parameter types. > At some point

Re: [PATCH 29/35] target/arm: Mark up VNCR offsets (offsets 0x100..0x160)

2024-01-04 Thread Peter Maydell
On Thu, 28 Dec 2023 at 00:42, Richard Henderson wrote: > > On 12/18/23 22:32, Peter Maydell wrote: > > Mark up the cpreginfo structs to indicate offsets for system > > registers from VNCR_EL2, as defined in table D8-66 in rule R_CSRPQ in > > the Arm ARM. This commit covers offsets 0x100 to 0x160.

Re: virtio-pci in qemu-system-arm is broken in 8.2

2024-01-04 Thread Michael Tokarev
04.01.2024 17:41, Peter Maydell wrote: .. Can you provide a complete repro case including full command line and all image files needed to run it, please? Sure, please excuse me for not doing this at the very beginning. The test is just standard debian kernel+initrd (I used sid/unstable kernel,

Re: [PATCH] util: fix build with musl libc on ppc64le

2024-01-04 Thread Philippe Mathieu-Daudé
Hi Natanael, On 19/12/23 11:51, Natanael Copa wrote: Use PPC_FEATURE2_ISEL and PPC_FEATURE2_VEC_CRYPTO from linux headers instead of the GNU specific PPC_FEATURE2_HAS_ISEL and PPC_FEATURE2_HAS_VEC_CRYPTO. This fixes build with musl libc. Fixes: 623d7e3551a6 (util: Add cpuinfo-ppc.c) Hmm this

[PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest

2024-01-04 Thread Daniel P . Berrangé
We've previously bumped up the timeouts in the netdev-socket qtest to supposedly fix non-deterministic failures, however, the failures are still hitting CI. A simple 'listen()' and 'connect()' pairing across 2 QEMU processes should be very quick to execute, even under high system load, so it was n

[PATCH 2/6] Revert "osdep: add getloadavg"

2024-01-04 Thread Daniel P . Berrangé
This reverts commit dc864d3a3777424187280e50c9bfb84dced54f12. This functionality is not required after the previous revert Signed-off-by: Daniel P. Berrangé --- include/qemu/osdep.h | 10 -- meson.build | 1 - 2 files changed, 11 deletions(-) diff --git a/include/qemu/osdep.h

[PATCH 5/6] net: handle QIOTask completion to report useful error message

2024-01-04 Thread Daniel P . Berrangé
The network stream backend uses the async QIO socket APIs for listening and connecting sockets. It does not check the task object completion status, however, instead just looking at whether the socket FD is -1 or not. By checking the task completion, we can set a useful error message for users ins

[PATCH 6/6] qtest: ensure netdev-socket tests have non-overlapping names

2024-01-04 Thread Daniel P . Berrangé
When naming glib tests if the name of one test is a substring of the name of another test, it is not possible to use the '-p /the/name' option to run a single test. Signed-off-by: Daniel P. Berrangé --- tests/qtest/netdev-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 4/6] net: add explicit info about connecting/listening state

2024-01-04 Thread Daniel P . Berrangé
When running 'info network', if the stream backend is still in the process of connecting, or waiting for an incoming connection, no information is displayed. There is also no way to distinguish whether the server is still in the process of setting up the listener socket, or whether it is ready to

[PATCH 3/6] Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds"

2024-01-04 Thread Daniel P . Berrangé
This reverts commit 0daaf2761f6d268ffaa2d01d450e202e127452b1. The test was not timing out because of slow execution. It was timing out due to a race condition leading to the client QEMU attempting (and fatally failing) to connect before the server QEMU was listening. Signed-off-by: Daniel P. Berr

[PATCH 1/6] Revert "netdev: set timeout depending on loadavg"

2024-01-04 Thread Daniel P . Berrangé
This reverts commit cadfc7293977ecadc2d6c48d7cffc553ed2f85f1. The test was not timing out because of slow execution. It was timing out due to a race condition leading to the client QEMU attempting (and fatally failing) to connect before the server QEMU was listening. Signed-off-by: Daniel P. Berr

Re: [PATCH] hw/arm: add cache controller for Freescale i.MX6

2024-01-04 Thread Philippe Mathieu-Daudé
On 19/12/23 11:55, Nikita Ostrenkov wrote: Per "i.MX 6Dual/6Quad Applications Processor Reference Manual, Rev. 4, 09/2017", Chapter 2 "Memory Maps", 2.2 ARM Platform Memory Map, Table 2-1. System memory map. Signed-off-by: Nikita Ostrenkov --- hw/arm/Kconfig| 1 + hw/arm/fsl-imx6.c |

Re: [PATCH v6 1/2] qom: new object to associate device to numa node

2024-01-04 Thread Ankit Agrawal
Had a discussion with RH folks, summary follows: 1. To align with the current spec description pointed by Jonathan, we first do a separate object instance per GI node as suggested by Jonathan. i.e. a acpi-generic-initiator would only link one node to the device. To associate a set

Re: [RFC PATCH-for-9.0] hw/display/qxl: Directly use VGACommonState::vram_size

2024-01-04 Thread Philippe Mathieu-Daudé
+Paolo On 24/11/23 20:22, Philippe Mathieu-Daudé wrote: PCIQXLDevice::vram_size seems to be some shadow of VGACommonState::vram_size. Just use the latter. Signed-off-by: Philippe Mathieu-Daudé --- RFC: I don't understand this field otherwise. --- hw/display/qxl.h | 1 - hw/display/qxl.c |

Re: [PATCH 0/6] net: fix non-deterministic failures of the 'netdev-socket' qtest

2024-01-04 Thread Stefan Hajnoczi
On Thu, 4 Jan 2024 at 11:30, Daniel P. Berrangé wrote: > > We've previously bumped up the timeouts in the netdev-socket qtest > to supposedly fix non-deterministic failures, however, the failures > are still hitting CI. > > A simple 'listen()' and 'connect()' pairing across 2 QEMU processes > shou

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-04 Thread Philippe Mathieu-Daudé
If there are no objections I'll queue this patch (fixing the typo reported by Zoltan). On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these fields has been converted to qdev properties, so don't need to be migrated: static Property

Re: [PATCH] hw/audio/sb16: Do not migrate qdev properties

2024-01-04 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > If there are no objections I'll queue this patch (fixing > the typo reported by Zoltan). > > On 24/11/23 19:26, Philippe Mathieu-Daudé wrote: >> Since commit f7b4f61f63 ("qdev/isa: convert soundblaster") these >> fields has been converted to qdev properties, so do

Re: virtio-pci in qemu-system-arm is broken in 8.2

2024-01-04 Thread Michael Tokarev
04.01.2024 19:25, Michael Tokarev wrote: ... this archive contains kernel+initrd.  I run it this way: qemu-system-arm -append root=LABEL=debvm -nographic -machine type=virt \  -drive media=disk,format=raw,file=vmlinuz,if=virtio,snapshot=on \  -no-user-config -m 1G -kernel vmlinuz -initrd initr

[PATCH v2 1/4] tests/qtest: Add a helper to query the QEMU version

2024-01-04 Thread Fabiano Rosas
Reviewed-by: Thomas Huth Signed-off-by: Fabiano Rosas --- tests/qtest/libqtest.c | 24 tests/qtest/libqtest.h | 10 ++ 2 files changed, 34 insertions(+) diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c index f33a210861..af779a3248 100644 --- a/tests/

[PATCH v2 0/4] migration & CI: Add a CI job for migration compat testing

2024-01-04 Thread Fabiano Rosas
Here's the second half of adding a migration compatibility test to CI. We've already added support for running the full set of migration tests with two QEMU binaries since commit 5050ad2a380 ("tests/qtest/migration: Support more than one QEMU binary"), now what's left is adding it to the CI. I in

[PATCH v2 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-04 Thread Fabiano Rosas
We can run the migration tests with two different QEMU binaries to test migration compatibility between QEMU versions. This means we'll be running the tests with an older QEMU in either source or destination. We need to avoid trying to test functionality that is unknown to the older QEMU. This cou

[PATCH v2 4/4] ci: Add a migration compatibility test job

2024-01-04 Thread Fabiano Rosas
The migration tests have support for being passed two QEMU binaries to test migration compatibility. Add a CI job that builds the lastest release of QEMU and another job that uses that version plus an already present build of the current version and run the migration tests with the two, both as so

[PATCH v2 3/4] tests/qtest/migration: Adapt tests to use older QEMUs

2024-01-04 Thread Fabiano Rosas
Add the 'since' annotations to recently added tests and adapt the postcopy test to use the older "uri" API when needed. Signed-off-by: Fabiano Rosas --- tests/qtest/migration-test.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/tests/qtes

Re: [PATCH v6 1/2] qom: new object to associate device to numa node

2024-01-04 Thread Alex Williamson
On Thu, 4 Jan 2024 03:36:06 + Ankit Agrawal wrote: > Thanks Jonathan for the review. > > > As per reply to the cover letter I definitely want to see SRAT table dumps > > in here though so we can easily see what this is actually building. > > Ack. > > > I worry that some OS might make the

Re: [PATCH v2 2/4] tests/qtest/migration: Add infrastructure to skip tests on older QEMUs

2024-01-04 Thread Daniel P . Berrangé
On Thu, Jan 04, 2024 at 02:18:55PM -0300, Fabiano Rosas wrote: > We can run the migration tests with two different QEMU binaries to > test migration compatibility between QEMU versions. This means we'll > be running the tests with an older QEMU in either source or > destination. > > We need to avo

Re: [PATCH v6 1/2] qom: new object to associate device to numa node

2024-01-04 Thread Alex Williamson
On Thu, 4 Jan 2024 16:40:39 + Ankit Agrawal wrote: > Had a discussion with RH folks, summary follows: > > 1. To align with the current spec description pointed by Jonathan, we first do > a separate object instance per GI node as suggested by Jonathan. i.e. > a acpi-generic-initiato

  1   2   3   >