Re: [PATCH v3 0/2] Add PowerNV I2C Controller Model

2023-10-17 Thread Cédric Le Goater
On 10/17/23 00:20, Glenn Miles wrote: Upstreams the PowerNV I2C controller model originally authored by Cédric Le Goater with minor changes by myself to split the actual addition of the model from wiring it up to a power processor model. This series only attaches the controller to the powernv9 c

Re: [PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration

2023-10-17 Thread Juan Quintela
Fabiano Rosas wrote: D> Juan Quintela writes: > >> From: Fabiano Rosas >> >> Add basic tests for file-based migration. >> >> Note that we cannot use test_precopy_common because that routine >> expects it to be possible to run the migration live. With the file >> transport there is no live migrat

Re: [PULL 00/38] Migration 20231016 patches

2023-10-17 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Mon, 16 Oct 2023 at 06:11, Juan Quintela wrote: >> >> The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: >> >> Merge tag 'pull-riscv-to-apply-20231012-1' of >> https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400) >> >

[PATCH qemu v2 0/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
Updated to change remaining free to g_free Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++-- 4

[PATCH qemu v2 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed, 15 insertions(+), 15 deletions(-) diff --git a/c

Re: [RFC PATCH 0/5] virtio-net: Introduce LM early load

2023-10-17 Thread Yajun Wu
Ping. On 9/18/2023 12:49 PM, Yajun Wu wrote: This series of patches aims to minimize the downtime during live migration of a virtio-net device with a vhost-user backend. In the case of hardware virtual Data Path Acceleration (vDPA) implementation, the hardware configuration, which includes tasks

Re: [PATCH] guest-agent: improve help for --allow-rpcs and --block-rpcs

2023-10-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 13, 2023 at 6:53 PM Angel M. Villegas wrote: > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1757 > > Updates to qga help output and documentation for --allow-rpcs and > --blocks-rpcs > > Signed-off-by: Angel M. Villegas > --- > docs/inter

Re: [RFC PATCH v3 60/78] qga: add fallthrough pseudo-keyword

2023-10-17 Thread Konstantin Kostiuk
Reviewed-by: Konstantin Kostiuk On Fri, Oct 13, 2023 at 11:50 AM Emmanouil Pitsidianakis < manos.pitsidiana...@linaro.org> wrote: > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanou

Re: [PATCH 1/1] target/arm: Adding a check for the result of calling the CPU information check function

2023-10-17 Thread Миронов Сергей Владимирович
Yes, the warning was initially received in the static analyzer SVACE, the same type as Coverity. In this case, return value of a function 'get_arm_cp_reginfo' is referenced at helper.c without checking for ALL, but it is usually checked for this function (8/9).

Re: [Virtio-fs] (no subject)

2023-10-17 Thread Viresh Kumar
On 13-10-23, 20:02, Hanna Czenczek wrote: > On 10.10.23 16:35, Alex Bennée wrote: > > I was going to say there is also the rust-vmm vhost-user-master crates > > which we've imported: > > > >https://github.com/vireshk/vhost > > > > for the Xen Vhost Frontend: > > > >https://github.com/vir

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Hanna Czenczek
On 17.10.23 07:36, Viresh Kumar wrote: On 16-10-23, 12:40, Alex Bennée wrote: Viresh Kumar writes: On 16-10-23, 11:45, Manos Pitsidianakis wrote: On Mon, 16 Oct 2023 11:32, Hanna Czenczek wrote: diff --git a/include/hw/virtio/vhost-user.h b/include/hw/virtio/vhost-user.h index 9f9ddf878d..

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Viresh Kumar
On 17-10-23, 09:51, Hanna Czenczek wrote: > Not that I’m really opposed to that, but I don’t see the problem with just > doing that in the same work that makes qemu actually use this flag, exactly > because it’s just a -1/+1 change. > > I can send a v2, but should I do the same for libvhost-user a

Re: [PATCH v2 00/10] riscv: RVA22U64 profile support

2023-10-17 Thread Andrew Jones
On Tue, Oct 17, 2023 at 01:55:47PM +1000, Alistair Francis wrote: > On Mon, Oct 16, 2023 at 7:03 PM Andrew Jones wrote: > > > > On Thu, Oct 12, 2023 at 04:07:50PM -0300, Daniel Henrique Barboza wrote: > > > > > > > > > On 10/11/23 00:01, Alistair Francis wrote: > > > > On Sat, Oct 7, 2023 at 12:23

Re: [PATCH qemu v2 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread Michael Tokarev
03.10.2023 15:45, ~h0lyalg0rithm wrote: From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 4 ++-- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 4 ++-- 4 files changed, 15

Re: [Virtio-fs] (no subject)

2023-10-17 Thread Hanna Czenczek
On 17.10.23 09:49, Viresh Kumar wrote: On 13-10-23, 20:02, Hanna Czenczek wrote: On 10.10.23 16:35, Alex Bennée wrote: I was going to say there is also the rust-vmm vhost-user-master crates which we've imported: https://github.com/vireshk/vhost for the Xen Vhost Frontend: https://git

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Hanna Czenczek
On 17.10.23 09:53, Viresh Kumar wrote: On 17-10-23, 09:51, Hanna Czenczek wrote: Not that I’m really opposed to that, but I don’t see the problem with just doing that in the same work that makes qemu actually use this flag, exactly because it’s just a -1/+1 change. I can send a v2, but should I

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Viresh Kumar
On 17-10-23, 10:14, Hanna Czenczek wrote: > On 17.10.23 09:53, Viresh Kumar wrote: > > On 17-10-23, 09:51, Hanna Czenczek wrote: > > > Not that I’m really opposed to that, but I don’t see the problem with just > > > doing that in the same work that makes qemu actually use this flag, > > > exactly

Re: [PULL 00/38] Migration 20231016 patches

2023-10-17 Thread Thomas Huth
On 17/10/2023 09.24, Juan Quintela wrote: Stefan Hajnoczi wrote: On Mon, 16 Oct 2023 at 06:11, Juan Quintela wrote: The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56: Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Albert Esteve
Hi! Thanks for the patch, and sorry for not noticing the flag had already been assigned. The patch looks good to me! BR, Albert On Tue, Oct 17, 2023 at 9:54 AM Viresh Kumar wrote: > On 17-10-23, 09:51, Hanna Czenczek wrote: > > Not that I’m really opposed to that, but I don’t see the problem w

RE: [PATCH v2 17/27] backends/iommufd: Introduce the iommufd object

2023-10-17 Thread Duan, Zhenzhong
Hi Markus, >-Original Message- >From: Markus Armbruster >Sent: Monday, October 16, 2023 6:01 PM >Subject: Re: [PATCH v2 17/27] backends/iommufd: Introduce the iommufd object > >Zhenzhong Duan writes: > >> From: Eric Auger >> >> Introduce an iommufd object which allows the interaction >>

[PULL 13/38] migration: Non multifd migration don't care about multifd flushes

2023-10-17 Thread Juan Quintela
RDMA was having trouble because migrate_multifd_flush_after_each_section() can only be true or false, but we don't want to send any flush when we are not in multifd migration. CC: Fabiano Rosas Reviewed-by: Li Zhijian Reviewed-by: Peter Xu Signed-off-by: Juan Quintela Message-ID: <202310112055

[PULL 04/38] migration: fix RAMBlock add NULL check

2023-10-17 Thread Juan Quintela
From: Dmitry Frolov qemu_ram_block_from_host() may return NULL, which will be dereferenced w/o check. Usualy return value is checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Dmitry Frolov Reviewed-by: Fabiano Rosas Reviewed-by: Peter X

[PULL 03/38] migration: Allow user to specify available switchover bandwidth

2023-10-17 Thread Juan Quintela
From: Peter Xu Migration bandwidth is a very important value to live migration. It's because it's one of the major factors that we'll make decision on when to switchover to destination in a precopy process. This value is currently estimated by QEMU during the whole live migration process by mon

[PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as changes in the ram flags. After code has been merged it becomes way harder to figure out what is causing the script to fail, the person making the change is t

[PULL 00/38] Migration 20231017 patches

2023-10-17 Thread Juan Quintela
The following changes since commit 800485762e6564e04e2ab315132d477069562d91: Merge tag 'python-pull-request' of https://gitlab.com/jsnow/qemu into staging (2023-10-16 12:37:48 -0400) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migratio

[PULL 21/38] migration/rdma: Move rdma constants from qemu-file.h to rdma.h

2023-10-17 Thread Juan Quintela
Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-9-quint...@redhat.com> --- migration/qemu-file.h | 17 - migration/rdma.h | 16 migration/ram.c | 2 +- 3 files changed, 17 insertions(+), 18

[PULL 17/38] migration/rdma: Remove all uses of RAM_CONTROL_HOOK

2023-10-17 Thread Juan Quintela
Instead of going through ram_control_load_hook(), call qemu_rdma_registration_handle() directly. Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-5-quint...@redhat.com> --- migration/qemu-file.h | 1 - migration/rdma.h | 3 +++ migration/ram.c |

[PULL 28/38] migration: check for rate_limit_max for RATE_LIMIT_DISABLED

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva In migration rate limiting atomic operations are used to read the rate limit variables and transferred bytes and they are expensive. Check first if rate_limit_max is equal to RATE_LIMIT_DISABLED and return false immediately if so. Note that with this patch we will also will

[PULL 08/38] migration: Fix analyze-migration.py when ignore-shared is used

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The script is currently broken when the x-ignore-shared capability is used: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 656, in dump.read(dump_memory = args.memory) File "./scripts/analyze-migration.py", line 593, in read sectio

[PULL 27/38] migration: Improve json and formatting

2023-10-17 Thread Juan Quintela
Reviewed-by: Markus Armbruster Signed-off-by: Juan Quintela Message-ID: <20231013104736.31722-2-quint...@redhat.com> --- qapi/migration.json | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 360e609f66..db3df12d6c 100644 --

[PULL 20/38] qemu-file: Remove QEMUFileHooks

2023-10-17 Thread Juan Quintela
The only user was rdma, and its use is gone. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-8-quint...@redhat.com> --- migration/qemu-file.h | 4 migration/qemu-file.c | 6 -- migration/rdma.c | 9 - 3 files cha

[PULL 22/38] migration/rdma: Remove qemu_ prefix from exported functions

2023-10-17 Thread Juan Quintela
Functions are long enough even without this. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-10-quint...@redhat.com> --- migration/rdma.h | 12 ++-- migration/ram.c| 14 +++--- migration/rdma.c | 40

[PULL 32/38] migration/ram: Remove RAMState from xbzrle_cache_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas 'rs' is not used in that function. It's a leftover from commit 9360447d34 ("ram: Use MigrationStats for statistics"). Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231011184604.32364-4-faro...@sus

[PULL 01/38] migration: refactor migration_completion

2023-10-17 Thread Juan Quintela
From: Wei Wang Current migration_completion function is a bit long. Refactor the long implementation into different subfunctions: - migration_completion_precopy: completion code related to precopy - migration_completion_postcopy: completion code related to postcopy Rename await_return_path_close

[PULL 14/38] migration: Create migrate_rdma()

2023-10-17 Thread Juan Quintela
Helper to say if we are doing a migration over rdma. Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-2-quint...@redhat.com> --- migration/migration.h | 2 ++ migration/options.h | 1 + migration/migration.c | 1 + migration/options.

[PULL 09/38] migration: Fix analyze-migration read operation signedness

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The migration code uses unsigned values for 16, 32 and 64-bit operations. Fix the script to do the same. This was causing an issue when parsing the migration stream generated on the ppc64 target because one of instance_ids was larger than the 32bit signed maximum: Traceback

[PULL 06/38] migration: Fix analyze-migration.py 'configuration' parsing

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The 'configuration' state subsections are currently not being parsed and the script fails when analyzing an aarch64 stream: Traceback (most recent call last): File "./scripts/analyze-migration.py", line 625, in dump.read(dump_memory = args.memory) File "./scripts/ana

[PULL 07/38] migration: Add capability parsing to analyze-migration.py

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The script is broken when the configuration/capabilities section is present. Add support for parsing the capabilities so we can fix it in the next patch. Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231009184326.15777-

[PULL 23/38] migration/rdma: Check sooner if we are in postcopy for save_page()

2023-10-17 Thread Juan Quintela
Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-11-quint...@redhat.com> --- migration/rdma.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index c147c94b08..e973579a52 1006

[PULL 26/38] migration/rdma: Remove all "ret" variables that are used only once

2023-10-17 Thread Juan Quintela
Change code that is: int ret; ... ret = foo(); if (ret[ < 0]?) { to: if (foo()[ < 0]) { Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-14-quint...@redhat.com> --- migration/rdma.c | 29 - 1 file c

[PULL 38/38] migration/multifd: Clarify Error usage in multifd_channel_connect

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The function is currently called from two sites, one always gives it a NULL Error and the other always gives it a non-NULL Error. In the non-NULL case, all it does it trace the error and return. One of the callers already have tracing, add a tracepoint to the other and stop p

[PULL 16/38] migration/rdma: Unfold ram_control_after_iterate()

2023-10-17 Thread Juan Quintela
Once there: - Remove unused data parameter - unfold it in its callers - change all callers to call qemu_rdma_registration_stop() - We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma() Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-4-quint...

[PULL 31/38] migration/ram: Refactor precopy ram loading code

2023-10-17 Thread Juan Quintela
From: Nikolay Borisov Extract the ramblock parsing code into a routine that operates on the sequence of headers from the stream and another the parses the individual ramblock. This makes ram_load_precopy() easier to comprehend. Signed-off-by: Nikolay Borisov Reviewed-by: Philippe Mathieu-Daudé

[PULL 35/38] migration/ram: Merge save_zero_page functions

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We don't need to do this in two pieces. One single function makes it easier to grasp, specially since it removes the indirection on the return value handling. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Messag

[PULL 34/38] migration/ram: Move xbzrle zero page handling into save_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas It makes a bit more sense to have the zero page handling of xbzrle right where we save the zero page. Also invert the exit condition to remove one level of indentation which makes the next patch easier to grasp. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-b

[PULL 25/38] migration/rdma: Declare for index variables local

2023-10-17 Thread Juan Quintela
Declare all variables that are only used inside a for loop inside the for statement. This makes clear that they are not used outside of the for loop. Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-13-quint...@redhat.com> --- mi

[PULL 18/38] migration/rdma: Unfold hook_ram_load()

2023-10-17 Thread Juan Quintela
There is only one flag called with: RAM_CONTROL_BLOCK_REG. Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-6-quint...@redhat.com> --- migration/qemu-file.h | 11 --- migration/rdma.h | 3 +++ migration/qemu-file.c | 10 -- migration/ra

[PULL 36/38] migration/multifd: Remove direct "socket" references

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We're about to enable support for other transports in multifd, so remove direct references to sockets. Signed-off-by: Fabiano Rosas Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231012134343.23757-2-faro...@suse

[PULL 12/38] migration: hold the BQL during setup

2023-10-17 Thread Juan Quintela
From: Fiona Ebner This is intended to be a semantic revert of commit 9b09503752 ("migration: run setup callbacks out of big lock"). There have been so many changes since that commit (e.g. a new setup callback dirty_bitmap_save_setup() that also needs to be adapted now), it's easier to do the reve

[PULL 30/38] multifd: reset next_packet_len after sending pages

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva Sometimes multifd sends just sync packet with no pages (normal_num is 0). In this case the old value is being preserved and being accounted for while only packet_len is being transferred. Reset it to 0 after sending and accounting for. Signed-off-by: Elena Ufimtseva Review

[PULL 15/38] migration/rdma: Unfold ram_control_before_iterate()

2023-10-17 Thread Juan Quintela
Once there: - Remove unused data parameter - unfold it in its callers. - change all callers to call qemu_rdma_registration_start() - We need to call QIO_CHANNEL_RDMA() after we check for migrate_rdma() Reviewed-by: Li Zhijian Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <

[PULL 11/38] tests/qtest: migration-test: Add tests for file-based migration

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas Add basic tests for file-based migration. Note that we cannot use test_precopy_common because that routine expects it to be possible to run the migration live. With the file transport there is no live migration because we must wait for the source to finish writing the migrati

[PULL 19/38] migration/rdma: Create rdma_control_save_page()

2023-10-17 Thread Juan Quintela
The only user of ram_control_save_page() and save_page() hook was rdma. Just move the function to rdma.c, rename it to rdma_control_save_page(). Reviewed-by: Peter Xu Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-7-quint...@redhat.com> --- migration/qemu

[PULL 29/38] multifd: fix counters in multifd_send_thread

2023-10-17 Thread Juan Quintela
From: Elena Ufimtseva Previous commit cbec7eb76879d419e7dbf531ee2506ec0722e825 "migration/multifd: Compute transferred bytes correctly" removed accounting for packet_len in non-rdma case, but the next_packet_size only accounts for pages, not for the header packet (normal_pages * PAGE_SIZE) that i

[PULL 05/38] migration: Add the configuration vmstate to the json writer

2023-10-17 Thread Juan Quintela
From: Nikolay Borisov Make the migration json writer part of MigrationState struct, allowing the 'configuration' object be serialized to json. This will facilitate the parsing of the 'configuration' object in the next patch that fixes analyze-migration.py for arm. Signed-off-by: Nikolay Borisov

[PULL 02/38] migration: Use g_autofree to simplify ram_dirty_bitmap_reload()

2023-10-17 Thread Juan Quintela
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Reviewed-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231011023627.86691-1-phi...@linaro.org> --- migration/ram.c | 17 ++--- 1 file chan

[PULL 37/38] migration/multifd: Unify multifd_send_thread error paths

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas The preferred usage of the Error type is to always set both the return code and the error when a failure happens. As all code called from the send thread follows this pattern, we'll always have the return code and the error set at the same time. Aside from the convention, in

[PULL 33/38] migration/ram: Stop passing QEMUFile around in save_zero_page

2023-10-17 Thread Juan Quintela
From: Fabiano Rosas We don't need the QEMUFile when we're already passing the PageSearchStatus. Reviewed-by: Peter Xu Signed-off-by: Fabiano Rosas Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231011184604.32364-5-faro...@suse.de> --- migration/ram.c | 11 ++

[PULL 24/38] migration/rdma: Use i as for index instead of idx

2023-10-17 Thread Juan Quintela
Once there, all the uses are local to the for, so declare the variable inside the for statement. Reviewed-by: Fabiano Rosas Reviewed-by: Li Zhijian Signed-off-by: Juan Quintela Message-ID: <20231011203527.9061-12-quint...@redhat.com> --- migration/rdma.c | 49 ++

Re: [RFC PATCH v3 09/78] hw/acpi/aml-build.c: add fallthrough pseudo-keyword

2023-10-17 Thread Ani Sinha
> On 13-Oct-2023, at 2:15 PM, Emmanouil Pitsidianakis > wrote: > > In preparation of raising -Wimplicit-fallthrough to 5, replace all > fall-through comments with the fallthrough attribute pseudo-keyword. > > Signed-off-by: Emmanouil Pitsidianakis What was wrong with QEMU_FALLTHROUGH? htt

Re: [PATCH 2/2] virtio: Drop out of coroutine context in virtio_load()

2023-10-17 Thread Kevin Wolf
Am 17.10.2023 um 07:19 hat Michael Tokarev geschrieben: > 05.09.2023 17:50, Kevin Wolf wrote: > > virtio_load() as a whole should run in coroutine context because it > > reads from the migration stream and we don't want this to block. > > > > However, it calls virtio_set_features_nocheck() and dev

Re: [PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-17 Thread Fiona Ebner
Am 16.10.23 um 21:40 schrieb Stefan Hajnoczi: > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > index 39e7f23fab..c2d59389cb 100644 > --- a/hw/block/virtio-blk.c > +++ b/hw/block/virtio-blk.c > @@ -1166,7 +1166,7 @@ static void virtio_blk_handle_output(VirtIODevice > *vdev, VirtQueue

Re: [RFC/PATCH v0 12/12] gunyah: Documentation

2023-10-17 Thread Srivatsa Vaddagiri
* Alex Benn?e [2023-10-12 15:55:59]: > > Hi Phil, > > We do want to see Gunyah support merged in Qemu at the earliest (as soon > > as the kernel driver is merged upstream that is), so any dependent change in > > Qemu for Gunyah would be of much interest to us! I am not sure though if > > Qui

Re: [PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-17 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > Clarify roles of different architectures. > Also change things a bit in anticipation of additional members being > added. > > Suggested-by: Markus Armbruster > Signed-off-by: Nina Schoetterl-Glausch > --- > qapi/machine.json | 58 ++

Re: [PATCH v2 1/3] hw/pci: Add all Data Object Types defined in PCIe r6.0

2023-10-17 Thread Jonathan Cameron via
On Tue, 17 Oct 2023 15:21:53 +1000 Alistair Francis wrote: > Add all of the defined protocols/features from the PCIe-SIG r6.0 > "Table 6-32 PCI-SIG defined Data Object Types (Vendor ID = 0001h)" > table. > > Signed-off-by: Alistair Francis Reviewed-by: Jonathan Cameron If you feel like adding

Re: [PATCH] hw/display: fix memleak from virtio_add_resource

2023-10-17 Thread Albert Esteve
On Fri, Oct 6, 2023 at 10:41 PM Matheus Tavares Bernardino < quic_mathb...@quicinc.com> wrote: > When the given uuid is already present in the hash table, > virtio_add_resource() does not add the passed VirtioSharedObject. In > this case, free it in the callers to avoid leaking memory. This fixed

Re: [PULL 1/1] virtio-blk: don't start dataplane during the stop of dataplane

2023-10-17 Thread Kevin Wolf
Am 17.10.2023 um 11:01 hat Fiona Ebner geschrieben: > Am 16.10.23 um 21:40 schrieb Stefan Hajnoczi: > > diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c > > index 39e7f23fab..c2d59389cb 100644 > > --- a/hw/block/virtio-blk.c > > +++ b/hw/block/virtio-blk.c > > @@ -1166,7 +1166,7 @@ static

Re: [PATCH v2 2/3] backends: Initial support for SPDM socket support

2023-10-17 Thread Jonathan Cameron via
On Tue, 17 Oct 2023 15:21:54 +1000 Alistair Francis wrote: > From: Huai-Cheng Kuo > > SPDM enables authentication, attestation and key exchange to assist in > providing infrastructure security enablement. It's a standard published > by the DMTF [1]. > > SPDM supports multiple transports, inclu

Re: [PATCH v2 3/3] hw/nvme: Add SPDM over DOE support

2023-10-17 Thread Jonathan Cameron via
On Tue, 17 Oct 2023 15:21:55 +1000 Alistair Francis wrote: > From: Wilfred Mallawa > > Setup Data Object Exchance (DOE) as an extended capability for the NVME > controller and connect SPDM to it (CMA) to it. > > Signed-off-by: Wilfred Mallawa > Signed-off-by: Alistair Francis > --- > docs/s

Re: deadlock when using iothread during backup_clean()

2023-10-17 Thread Fiona Ebner
Am 06.10.23 um 14:18 schrieb Fiona Ebner: > Am 04.10.23 um 19:08 schrieb Vladimir Sementsov-Ogievskiy: >> On 28.09.23 11:06, Fiona Ebner wrote: >>> For fixing the backup cancel deadlock, I tried the following: >>> diff --git a/blockjob.c b/blockjob.c index 58c5d64539..fd6132ebfe 100644 >>

Re: [PATCH 11/12] hw/xen: automatically assign device index to block devices

2023-10-17 Thread Kevin Wolf
Am 16.10.2023 um 17:19 hat David Woodhouse geschrieben: > From: David Woodhouse > > There's no need to force the user to assign a vdev. We can automatically > assign one, starting at xvda and searching until we find the first disk > name that's unused. > > This means we can now allow '-drive if=

Re: [RFC PATCH v3 64/78] hw/mips: add fallthrough pseudo-keyword

2023-10-17 Thread Philippe Mathieu-Daudé
On 13/10/23 10:46, Emmanouil Pitsidianakis wrote: In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/mips/boston.c | 12 ++-- 1 file changed, 6 insertion

Re: [RFC PATCH v3 40/78] hw/sd/sdhci.c: add fallthrough pseudo-keyword

2023-10-17 Thread Philippe Mathieu-Daudé
On 13/10/23 10:46, Emmanouil Pitsidianakis wrote: In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword. Signed-off-by: Emmanouil Pitsidianakis --- hw/sd/sdhci.c | 8 1 file changed, 4 insertions(+), 4

[PATCH qemu v3 0/1] Elf2dmp: Conversion of conversions of malloc/calloc/free to g_malloc/g_new/g_free

2023-10-17 Thread ~h0lyalg0rithm
Remove NULL check for g_new changes Suraj Shirvankar (1): Switch memory management calls to new coding conventions contrib/elf2dmp/addrspace.c | 7 ++- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 7 ++- 4 f

[PATCH qemu v3 1/1] Switch memory management calls to new coding conventions

2023-10-17 Thread ~h0lyalg0rithm
From: Suraj Shirvankar Signed-off-by: Suraj Shirvankar --- contrib/elf2dmp/addrspace.c | 7 ++- contrib/elf2dmp/main.c | 6 +++--- contrib/elf2dmp/pdb.c | 16 contrib/elf2dmp/qemu_elf.c | 7 ++- 4 files changed, 15 insertions(+), 21 deletions(-) diff --g

Re: [PATCH] vhost-user: Fix protocol feature bit conflict

2023-10-17 Thread Stefan Hajnoczi
On Tue, 17 Oct 2023 at 04:26, Albert Esteve wrote: > > Hi! > > Thanks for the patch, and sorry for not noticing the flag had already been > assigned. The patch looks good to me! Hi Albert, I looked at the shared object code for the first time: - There are memory leaks in virtio_add_dmabuf() and

Re: [PATCH v26 09/21] qapi/s390x/cpu topology: set-cpu-topology qmp command

2023-10-17 Thread Markus Armbruster
Nina Schoetterl-Glausch writes: > From: Pierre Morel > > The modification of the CPU attributes are done through a monitor > command. > > It allows to move the core inside the topology tree to optimize > the cache usage in the case the host's hypervisor previously > moved the CPU. > > The same c

Re: [PULL 00/25] Python patches

2023-10-17 Thread Vladimir Sementsov-Ogievskiy
On 17.10.23 02:44, John Snow wrote: On Mon, Oct 16, 2023 at 3:21 PM Stefan Hajnoczi wrote: Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. Hi Vladimir: all done! Thanks! I've created a MR to backport your changes to the

Re: [PATCH v26 01/21] qapi: machine.json: change docs regarding CPU topology

2023-10-17 Thread Thomas Huth
On 17/10/2023 11.40, Markus Armbruster wrote: Nina Schoetterl-Glausch writes: Clarify roles of different architectures. Also change things a bit in anticipation of additional members being added. Suggested-by: Markus Armbruster Signed-off-by: Nina Schoetterl-Glausch --- qapi/machine.json

[PATCH v3 1/4] target/riscv: Remove misa_mxl validation

2023-10-17 Thread Akihiko Odaki
It is initialized with a simple assignment and there is little room for error. In fact, the validation is even more complex. Signed-off-by: Akihiko Odaki --- target/riscv/tcg/tcg-cpu.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/target/riscv/tcg/tcg-cpu.c b

[PATCH v3 4/4] plugins: Remove an extra parameter

2023-10-17 Thread Akihiko Odaki
copy_call() has an unused parameter so remove it. Signed-off-by: Akihiko Odaki --- accel/tcg/plugin-gen.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/accel/tcg/plugin-gen.c b/accel/tcg/plugin-gen.c index 39b3c9351f..78b331b251 100644 --- a/accel/tcg/plugin-gen.c

[PATCH v3 2/4] target/riscv: Move misa_mxl_max to class

2023-10-17 Thread Akihiko Odaki
misa_mxl_max is common for all instances of a RISC-V CPU class so they are better put into class. Signed-off-by: Akihiko Odaki --- target/riscv/cpu-qom.h | 1 + target/riscv/cpu.h | 3 +- hw/riscv/boot.c| 2 +- target/riscv/cpu.c | 118 +++---

[PATCH v3 0/4] gdbstub and TCG plugin improvements

2023-10-17 Thread Akihiko Odaki
This series extracts fixes and refactorings that can be applied independently from "[PATCH v9 00/23] plugins: Allow to read registers". The patch "target/riscv: Move MISA limits to class" was replaced with patch "target/riscv: Move misa_mxl_max to class" since I found instances may have different

[PATCH v3 3/4] target/riscv: Validate misa_mxl_max only once

2023-10-17 Thread Akihiko Odaki
misa_mxl_max is now a class member and initialized only once for each class. This also moves the initialization of gdb_core_xml_file which will be referenced before realization in the future. Signed-off-by: Akihiko Odaki --- target/riscv/cpu.c | 21 + target/riscv/tcg

Re: [PATCH v26 00/21] s390x: CPU Topology

2023-10-17 Thread Markus Armbruster
QAPI schema looks ready apart from the a few minor things in PATCH 01. Perhaps the maintainer could address them without a respin. Up to you guys. This was a long, hard push, but you persevered. Respect!

[PATCH] gtk: force realization of drawing area

2023-10-17 Thread marcandre . lureau
From: Marc-André Lureau Fixes the GL context creation from a widget that isn't yet realized (in a hidden tab for example). Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1727 Signed-off-by: Marc-André Lureau --- ui/gtk.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a

Re: [PATCH] semihosting/arm-compat: Have TARGET_SYS_EXIT[_EXTENDED] return signed

2023-10-17 Thread Philippe Mathieu-Daudé
Hi Peter, On 16/10/23 18:08, Peter Maydell wrote: On Thu, 5 Oct 2023 at 07:27, Philippe Mathieu-Daudé wrote: Per the "Semihosting for AArch32 and AArch64" spec. v2 (2023Q3) [*]: 6.5 SYS_EXIT (0x18) 6.5.2 Entry (64-bit) On entry, the PARAMETER REGISTER contains a pointer to

[PATCH 1/6] system/dirtylimit: Fix a race situation

2023-10-17 Thread Hyman Huang
Fix a race situation for global variable dirtylimit_state. Also, replace usleep by g_usleep to increase platform accessibility to the sleep function. Signed-off-by: Hyman Huang --- system/dirtylimit.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/syst

[PATCH 0/6] dirtylimit: miscellaneous patches

2023-10-17 Thread Hyman Huang
This is a miscellaneous patchset for dirtylimit that contains the following parts: 1. dirtylimit module: fix for a race situation and replace usleep by g_usleep. 2. migration test: add dirtylimit test case. 3. guestperf for migration: add support for dirtylimit migration. 4. docs for migration:

[PATCH 2/6] system/dirtylimit: Drop the reduplicative check

2023-10-17 Thread Hyman Huang
Checking if dirty limit is in service is done by the dirtylimit_query_all function, drop the reduplicative check in the qmp_query_vcpu_dirty_limit function. Signed-off-by: Hyman Huang --- system/dirtylimit.c | 4 1 file changed, 4 deletions(-) diff --git a/system/dirtylimit.c b/system/dirt

[PATCH 6/6] docs/migration: Add the dirty limit section

2023-10-17 Thread Hyman Huang
The dirty limit feature has been introduced since the 8.1 QEMU release but has not reflected in the document, add a section for that. Signed-off-by: Hyman Huang --- docs/devel/migration.rst | 71 1 file changed, 71 insertions(+) diff --git a/docs/devel/m

[PATCH 3/6] tests: Add migration dirty-limit capability test

2023-10-17 Thread Hyman Huang
Add migration dirty-limit capability test if kernel support dirty ring. Migration dirty-limit capability introduce dirty limit capability, two parameters: x-vcpu-dirty-limit-period and vcpu-dirty-limit are introduced to implement the live migration with dirty limit. The test case does the followi

[PATCH 4/6] tests/migration: Introduce dirty-ring-size option into guestperf

2023-10-17 Thread Hyman Huang
Dirty ring size configuration is not supported by guestperf tool. Introduce dirty-ring-size (ranges in [1024, 65536]) option so developers can play with dirty-ring and dirty-limit feature easier. To set dirty ring size with 4096 during migration test: $ ./tests/migration/guestperf.py --dirty-ring

[PATCH 5/6] tests/migration: Introduce dirty-limit into guestperf

2023-10-17 Thread Hyman Huang
Currently, guestperf does not cover the dirty-limit migration, support this feature. Note that dirty-limit requires 'dirty-ring-size' set. To enable dirty-limit, setting x-vcpu-dirty-limit-period as 500ms and x-vcpu-dirty-limit as 10MB/s: $ ./tests/migration/guestperf.py \ --dirty-ring-size 4

Re: [PATCH v2 1/2] tcg: Add tcg_gen_{ld,st}_i128

2023-10-17 Thread Philippe Mathieu-Daudé
On 13/10/23 19:51, Richard Henderson wrote: Do not require the translators to jump through concat and extract of i64 in order to move values to and from env. (extra space) Signed-off-by: Richard Henderson --- include/tcg/tcg-op-common.h | 3 +++ tcg/tcg-op.c| 22

Re: [PATCH v2 0/2] tcg: Streamline vector load/store

2023-10-17 Thread Philippe Mathieu-Daudé
On 13/10/23 19:51, Richard Henderson wrote: We have tcg_gen_qemu_{ld,st}_i128, which can be used to implement load/store of vectors to guest memory. But at present we have to split into, or concatenated from, two i64 to reference the guest vector register backing store within env. Provide tcg_g

[PATCH v5 3/7] migration: migrate 'blk' command option is deprecated.

2023-10-17 Thread Juan Quintela
Use blocked-mirror with NBD instead. Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Reviewed-by: Thomas Huth --- Improve documentation and style (markus) --- docs/about/deprecated.rst | 10 ++ qapi/migration.json| 6 -- migration/migration-hmp-cmds.c |

[PATCH v5 6/7] [RFC] migration: Make -i/-b an error for hmp and qmp

2023-10-17 Thread Juan Quintela
[DON'T MERGE] Block migration is obsolete, users should use blockdev-mirror instead. Make it one error to set them. Signed-off-by: Juan Quintela --- migration/migration-hmp-cmds.c | 13 +++-- migration/migration.c | 33 ++--- 2 files changed, 13 inse

[PATCH v5 5/7] migration: Deprecate old compression method

2023-10-17 Thread Juan Quintela
Signed-off-by: Juan Quintela Acked-by: Stefan Hajnoczi Acked-by: Peter Xu --- docs/about/deprecated.rst | 8 qapi/migration.json | 79 +-- migration/options.c | 13 +++ 3 files changed, 72 insertions(+), 28 deletions(-) diff --git a/doc

[PATCH v5 0/7] Migration deprecated parts

2023-10-17 Thread Juan Quintela
Based on: Message-ID: <20231017083003.15951-1-quint...@redhat.com> Migration 20231017 patches On this v5: - Rebased on top of last migration pull requesnt: - address markus comments. Basically we recommend always blockdev-mirror + NBD. In deprecated.rst we also put the pos

  1   2   3   4   5   >