Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Sep 15 21:27, Alistair Francis wrote: > From: Wilfred Mallawa > > Setup Data Object Exchance (DOE) as an extended capability for the NVME > controller and connect SPDM to it (CMA) to it. > > Signed-off-by: Wilfred Mallawa > Signed-off-by: Alistair Francis > --- > docs/specs/index.rst

Re: [PATCH v2 1/3] i386/a-b-bootblock: factor test memory addresses out into constants

Ping! :) 19.09.2023, 13:23, "Daniil Tatianin" :So that we have less magic numbers to deal with. This also allows us toreuse these in the following commits.Signed-off-by: Daniil Tatianin Reviewed-by: Peter Xu --- tests/migration/i386/a-b-bootblock.S | 9

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

On 9/7/23 23:53, Denis V. Lunev wrote: Unfortunately 271 IO test is broken if started in non-cached mode. Commits commit a6b257a08e3d72219f03e461a52152672fec0612 Author: Nir Soffer Date: Tue Aug 13 21:21:03 2019 +0300 file-posix: Handle undetectable alignment and comm

[PATCH v2 2/4] target/i386: mark CR4.FRED not reserved

The CR4.FRED bit, i.e., CR4[32], is no longer a reserved bit when FRED is exposed to guests, otherwise it is still a reserved bit. Tested-by: Shan Kang Signed-off-by: Xin Li --- target/i386/cpu.h | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/target/i386/cpu.h

[PATCH v2 1/4] target/i386: add support for FRED in CPUID enumeration

FRED, i.e., the Intel flexible return and event delivery architecture, defines simple new transitions that change privilege level (ring transitions). The new transitions defined by the FRED architecture are FRED event delivery and, for returning from events, two FRED return instructions. FRED even

[PATCH v2 0/4] target/i386: add support for FRED

This patch set adds support for the Intel flexible return and event delivery (FRED) architecture to allow Qemu to run KVM guests with FRED enabled. The FRED architecture defines simple new transitions that change privilege level (ring transitions). The FRED architecture was designed with the follo

[PATCH v2 4/4] target/i386: Add get/set/migrate support for FRED MSRs

FRED CPU states are managed in 9 new FRED MSRs, in addtion to a few existing CPU registers and MSRs, e.g., CR4.FRED and MSR_IA32_PL0_SSP. Save/restore/migrate FRED MSRs if FRED is exposed to the guest. Tested-by: Shan Kang Signed-off-by: Xin Li --- target/i386/cpu.h | 26 ++

[PATCH v2 3/4] target/i386: enumerate VMX nested-exception support

Allow VMX nested-exception support to be exposed in KVM guests, thus nested KVM guests can enumerate it. Tested-by: Shan Kang Signed-off-by: Xin Li --- scripts/kvm/vmxcap | 1 + target/i386/cpu.c | 1 + target/i386/cpu.h | 1 + 3 files changed, 3 insertions(+) diff --git a/scripts/kvm/vmxcap

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Mon, 2 Oct 2023 09:15:58 +0200 Klaus Jensen wrote: > On Sep 15 21:27, Alistair Francis wrote: > > From: Wilfred Mallawa > > > > Setup Data Object Exchance (DOE) as an extended capability for the NVME > > controller and connect SPDM to it (CMA) to it. > > > > Signed-off-by: Wilfred Mallawa

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Fri, Sep 15, 2023 at 09:27:23PM +1000, Alistair Francis wrote: > --- /dev/null > +++ b/docs/specs/spdm.rst > @@ -0,0 +1,56 @@ > +== > +QEMU Security Protocols and Data Models (SPDM) Support > +===

Re: [PATCH v4 16/18] virtio-mem: Expose device memory dynamically via multiple memslots if enabled

On 30.09.23 19:31, Maciej S. Szmigiero wrote: On 26.09.2023 20:57, David Hildenbrand wrote: Having large virtio-mem devices that only expose little memory to a VM is currently a problem: we map the whole sparse memory region into the guest using a single memslot, resulting in one gigantic memslo

[PATCH 08/19] parallels: Make mark_used() and mark_unused() global functions

We will need these functions in parallels-ext.c too. Let them be global functions parallels_mark_used() and parallels_mark_unused(). Signed-off-by: Alexander Ivanov --- block/parallels.c | 22 -- block/parallels.h | 5 + 2 files changed, 17 insertions(+), 10 deletions(-)

[PATCH 03/19] parallels: Move host clusters allocation to a separate function

For parallels images extensions we need to allocate host clusters without any connection to BAT. Move host clusters allocation code to allocate_host_clusters(). Signed-off-by: Alexander Ivanov --- block/parallels.c | 124 -- block/parallels.h | 4 ++

[PATCH 16/19] parallels: Check unused clusters in parallels_check_leak()

Since we have used bitmap, leak check is useless. Transform parallels_truncate_unused_clusters() to parallels_check_unused_clusters() helper and use it in leak check. Signed-off-by: Alexander Ivanov --- block/parallels.c | 112 ++ 1 file changed, 63 in

[PATCH 02/19] parallels: Add mark_unused() helper

Add a helper to set unused areas in used bitmap. Signed-off-by: Alexander Ivanov --- block/parallels.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block/parallels.c b/block/parallels.c index d5b333d5a4..b5e19ff921 100644 --- a/block/parallels.c +++ b/block/parallels.c

[PATCH 11/19] parallels: Handle L1 entries equal to one

If all the bits in a dirty bitmap cluster are ones, the cluster shouldn't be written. Instead the corresponding L1 entry should be set to 1. Check if all bits in a memory region are ones and set 1 to L1 entries corresponding clusters filled with ones. Signed-off-by: Alexander Ivanov --- block/p

[PATCH 14/19] parallels: Truncate images on the last used cluster

On an image closing there can be unused clusters in the end of the image. Truncate these clusters and update data_end field. Signed-off-by: Alexander Ivanov --- block/parallels.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/block/parallels.c b/block/paral

[PATCH 19/19] tests: Add parallels format support to image-fleecing

Use a different bitmap name for parallels images because their has own ID format, and can't contain an arbitrary string. Replace hardcoded 'qcow2' format to iotests.imgfmt. Add 'parallels' to supported formats. Signed-off-by: Alexander Ivanov --- tests/qemu-iotests/tests/image-fleecing | 13 ++

[PATCH 06/19] parallels: Add a note about used bitmap in parallels_check_duplicate()

In parallels_check_duplicate() We use a bitmap for duplication detection. This bitmap is not related to used_bmap field in BDRVParallelsState. Add a comment about it to avoid confusion. Signed-off-by: Alexander Ivanov --- block/parallels.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-

[PATCH 05/19] parallels: Recreate used bitmap in parallels_check_leak()

In parallels_check_leak() file can be truncated. In this case the used bitmap would not comply to the file. Recreate the bitmap after file truncation. Signed-off-by: Alexander Ivanov --- block/parallels.c | 8 1 file changed, 8 insertions(+) diff --git a/block/parallels.c b/block/paral

[PATCH 17/19] tests: Add parallels images support to test 165

Use a different bitmap name for parallels images because their has own ID format, and can't contain an arbitrary string. Replace image reopen by shutdown/launch VM because parallels images doesn't support reopen. Signed-off-by: Alexander Ivanov --- tests/qemu-iotests/165 | 42 ++

[PATCH 00/19] parallels: Add full dirty bitmap support

Parallels format driver: * make some preparation * add dirty bitmap saving * make dirty bitmap RW * fix broken checks * refactor leak check * add parallels format support to several tests Alexander Ivanov (19): parallels: Move inactivation code to a separate function parallels: Add mark_unused

[PATCH 18/19] tests: Turned on 256, 299, 304 and block-status-cache for parallels format

These tests pass with parallels format. Add parallels to supporting formats for these tests. Signed-off-by: Alexander Ivanov --- tests/qemu-iotests/256 | 2 +- tests/qemu-iotests/299 | 2 +- tests/qemu-iotests/304 | 2 +- tests/qemu-

Re: [PATCH v4 00/18] virtio-mem: Expose device memory through multiple memslots

On 26.09.23 20:57, David Hildenbrand wrote: Quoting from patch #16: Having large virtio-mem devices that only expose little memory to a VM is currently a problem: we map the whole sparse memory region into the guest using a single memslot, resulting in one gigantic memslot in KVM.

[PATCH 01/19] parallels: Move inactivation code to a separate function

We are going to add parallels image extensions storage and need a separate function for inactivation code. Signed-off-by: Alexander Ivanov --- block/parallels.c | 22 -- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index

[PATCH 15/19] parallels: Remove unnecessary data_end field

Since we have used bitmap, field data_end in BDRVParallelsState is redundant and can be removed. Add parallels_data_end() helper and remove data_end handling. Signed-off-by: Alexander Ivanov --- block/parallels.c | 33 + block/parallels.h | 1 - 2 files changed,

[PATCH 13/19] parallels: Reverse a conditional in parallels_check_leak() to reduce indents

Let the function return a success code if a file size is not bigger than image_end_offset. Thus we can decrease indents in the next code block. Signed-off-by: Alexander Ivanov --- block/parallels.c | 72 +++ 1 file changed, 36 insertions(+), 36 deletio

[PATCH 04/19] parallels: Set data_end value in parallels_check_leak()

In parallels_check_leak() we change file size but don't correct data_end field of BDRVParallelsState structure. Fix it. Signed-off-by: Alexander Ivanov --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/parallels.c index 3c69afa04b..e8d6d30fa5 100

[PATCH 10/19] parallels: Let image extensions work in RW mode

Now we support extensions saving and can let to work with them in read-write mode. Signed-off-by: Alexander Ivanov --- block/parallels-ext.c | 4 block/parallels.c | 17 - 2 files changed, 4 insertions(+), 17 deletions(-) diff --git a/block/parallels-ext.c b/block/para

[PATCH 09/19] parallels: Add dirty bitmaps saving

Now dirty bitmaps can be loaded but there is no their saving. Add code for dirty bitmap storage. Signed-off-by: Alexander Ivanov --- block/parallels-ext.c | 167 ++ block/parallels.c | 16 +++- block/parallels.h | 5 ++ 3 files changed, 186 inse

[PATCH 12/19] parallels: Make a loaded dirty bitmap persistent

After bitmap loading the bitmap is not persistent and is removed on image saving. Set bitmap persistence to true. Signed-off-by: Alexander Ivanov --- block/parallels-ext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels-ext.c b/block/parallels-ext.c index ebda6b0a01..bb4478c3

[PATCH 07/19] parallels: Create used bitmap even if checks needed

All the checks were fixed to work with used bitmap. Create used bitmap in parallels_open() even if need_check is true. Signed-off-by: Alexander Ivanov --- block/parallels.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/block/parallels.c b/block/parallels.c index

Re: [PATCH 1/1] hw/ide/core: terminate in-flight DMA on IDE bus reset

On Thursday, 28 September 2023 Fiona Ebner wrote: > AFAICT, yes, because the DMA callback is invoked before resetting the > state now. But not 100% sure if it can't be triggered in some other way, > maybe Simon knows more? I don't have a reproducer for the CVE either, > but the second patch after

Re: [PATCH] hw/virtio/vhost: check nvqs at dev_start

On Fri, Sep 01, 2023 at 02:23:23PM +0200, Albert Esteve wrote: > While this is not expected to happen, it could still > be that a vhost_dev did not set its nvqs member. > > Since `vhost_dev_start` access the device's vqs array > later without checking its size, it would cause a > Segmentation faul

Re: [PATCH v3 4/5] hw/char: riscv_htif: replace exit calls with proper shutdown

On Fri, Sep 22, 2023 at 7:20 AM Alistair Francis wrote: > > On Thu, Sep 7, 2023 at 9:26 PM Clément Chigot wrote: > > > > This replaces the exit calls by shutdown requests, ensuring a proper > > cleanup of Qemu. Otherwise, some connections like gdb could be broken > > before its final packet ("Wxx

[PATCH] ui: fix dpy_ui_info_supported(con) assertion

VGA does not support getting the physical video size or refresh rate. This is causing an assertion failure when the GTK+ user interface calls dpy_get_ui_info(). Return NULL from dpy_get_ui_info() if the information is not supported, and just ignore the request to set refresh rate or size in that c

RE: [PATCH RFC V2 01/37] arm/virt,target/arm: Add new ARMCPU {socket,cluster,core,thread}-id property

Hi Gavin, Many thanks for taking pains to review this patch-set. > From: Gavin Shan > Sent: Wednesday, September 27, 2023 12:57 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > pete

[PATCH v2] ui: fix dpy_ui_info_supported(con) assertion

VGA does not support getting the physical video size or refresh rate. This is causing an assertion failure when the GTK+ user interface calls dpy_get_ui_info(). Return NULL from dpy_get_ui_info() if the information is not supported, and just ignore the request to set refresh rate or size in that c

Re: [PATCH v2] ui: fix dpy_ui_info_supported(con) assertion

Hi On Mon, Oct 2, 2023 at 1:54 PM Paolo Bonzini wrote: > > VGA does not support getting the physical video size or refresh rate. > This is causing an assertion failure when the GTK+ user interface > calls dpy_get_ui_info(). Return NULL from dpy_get_ui_info() if the > information is not supported

Re: [PATCH v2] ui: fix dpy_ui_info_supported(con) assertion

02.10.2023 12:54, Paolo Bonzini wrote: VGA does not support getting the physical video size or refresh rate. This is causing an assertion failure when the GTK+ user interface calls dpy_get_ui_info(). Return NULL from dpy_get_ui_info() if the information is not supported, and just ignore the requ

Re: [PATCH v2] ui: fix dpy_ui_info_supported(con) assertion

On Mon, Oct 2, 2023 at 11:58 AM Marc-André Lureau wrote: > > Hi > > On Mon, Oct 2, 2023 at 1:54 PM Paolo Bonzini wrote: > > > > VGA does not support getting the physical video size or refresh rate. > > This is causing an assertion failure when the GTK+ user interface > > calls dpy_get_ui_info().

[PATCH v1] roms: use PYTHON to invoke python

python3 may not be the expected python version. Use PYTHON to invoke python. Fixes: 22e11539e1 ("edk2: replace build scripts") Signed-off-by: Olaf Hering --- roms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/Makefile b/roms/Makefile index 6859685290..67f709b

RE: [PATCH RFC V2 02/37] cpus-common: Add common CPU utility for possible vCPUs

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 4:54 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > im

RE: [PATCH RFC V2 03/37] hw/arm/virt: Move setting of common CPU properties in a function

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 6:17 AM > To: Salil Mehta ; qemu-devel@nongnu.org; > qemu-...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > ima

RE: [PATCH RFC V2 04/37] arm/virt,target/arm: Machine init time change common to vCPU {cold|hot}-plug

Hi Gavin, > From: Gavin Shan > Sent: Wednesday, September 27, 2023 7:30 AM > To: Salil Mehta ; qemu-devel@nongnu.org; qemu- > a...@nongnu.org > Cc: m...@kernel.org; jean-phili...@linaro.org; Jonathan Cameron > ; lpieral...@kernel.org; > peter.mayd...@linaro.org; richard.hender...@linaro.org; > im

Re: [PATCH v2] hw/i386: changes towards enabling -Wshadow=local

On Thu, Sep 28, 2023 at 09:14:07AM +0530, Ani Sinha wrote: > > > > On 27-Sep-2023, at 8:55 PM, Michael S. Tsirkin wrote: > > > > On Tue, Sep 26, 2023 at 11:22:35AM +0530, Ani Sinha wrote: > >> Code changes that addresses all compiler complaints coming from enabling > >> -Wshadow flags. Enabling

Re: [PULL 38/56] hw/acpi: changes towards enabling -Wshadow=local

On Sat, Sep 30, 2023 at 10:41:12AM +0200, Markus Armbruster wrote: > Ani Sinha writes: > > >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster wrote: > >> > >> From: Ani Sinha > >> > >> Code changes in acpi that addresses all compiler complaints coming from > >> enabling > >> -Wshadow flags. En

Re: [PATCH] hw/virtio/vhost: check nvqs at dev_start

Ah I see, I wanted to move the fail check as early as possible, and went a bit too far ahead, before initialisation. But is ok, it needs its own value either way. What about returning -EFAULT? Or maybe -EINVAL? I think they would fit for this error. And then I can use `VHOST_OPS_DEBUG` to make it

RE: [PATCH 07/22] exec/cpu: Introduce the CPU address space destruction function

Hi Phillipe, This patch has been taken as it is from ARM's RFC and the common patch-set mentioned below. So SOBs are all wrong everywhere. Original RFC posted in the year 2020. [1] https://lore.kernel.org/qemu-devel/20200613213629.21984-23-salil.me...@huawei.com/ Recently posted RFC V2 [2] ht

[PATCH v2 3/5] ramfb: implement migration support

From: Marc-André Lureau Implementing RAMFB migration is quite straightforward. One caveat is to treat the whole RAMFBCfg as a blob, since that's what is exposed to the guest directly. This avoid having to fiddle with endianness issues if we were to migrate fields individually as integers. The fo

[PATCH v2 5/5] hw: turn off ramfb migration for machines <= 8.1

From: Marc-André Lureau For compatibility reasons. Signed-off-by: Marc-André Lureau --- hw/core/machine.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index 68cb556197..2fa7647422 100644 --- a/hw/core/machine.c +++ b/hw/core/mach

[PATCH v2 2/5] pc: remove needless includes

From: Marc-André Lureau The include list is gigantic, make it smaller. Signed-off-by: Marc-André Lureau --- hw/i386/pc.c | 41 - 1 file changed, 41 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5d399b6247..c376c5032d 100644 --- a/hw/i386/p

[PATCH v2 1/5] hw: remove needless includes

From: Marc-André Lureau The include list is large, make it smaller. Signed-off-by: Marc-André Lureau --- hw/core/machine.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/core/machine.c b/hw/core/machine.c index cb38b8cf4c..68cb556197 100644 --- a/hw/core/machine.c +++ b/hw/c

[PATCH v2 4/5] ramfb: make migration conditional

From: Marc-André Lureau RAMFB migration was unsupported until now, let's make it conditional. The following patch will prevent machines <= 8.1 to migrate it. Signed-off-by: Marc-André Lureau --- hw/vfio/pci.h | 1 + include/hw/display/ramfb.h| 2 +- hw/display/ramfb-standal

[PATCH v2 0/5] ramfb: migration support

From: Marc-André Lureau Hi, Implement RAMFB migration, and add properties to enable it only on >= 8.2 machines, + a few related cleanups. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1859424 Marc-André Lureau (5): hw: remove needless includes pc: remove needless includes ramfb: imp

Re: MAINTAINERS still leaves more files uncovered than I'd like

On 9/29/23 13:43, Markus Armbruster wrote: Back in 2014 (time flies), I posted Subject: MAINTAINERS leaves too many files uncovered Message-ID: <87mw8rumhb@blackfin.pond.sub.org> https://lore.kernel.org/qemu-devel/87mw8rumhb@blackfin.pond.sub.org/ I updated my findings in

RE: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

Comment on subjectAltName. PCI-SIG realized that it may cause problem for certain device and decided to remove such requirement in future ECN. I don't think that is absolutely needed. > -Original Message- > From: Lukas Wunner > Sent: Monday, October 2, 2023 4:48 PM > To: Alistair Fran

Re: [PATCH] pci: SLT must be RO

W dniu 8.09.2023 o 15:29, Marcin Juszkiewicz pisze: W dniu 31.08.2023 o 12:05, Marcin Juszkiewicz pisze: W dniu 30.08.2023 o 23:48, Michael S. Tsirkin pisze: current code sets PCI_SEC_LATENCY_TIMER to WO, but for pcie to pcie bridges it must be RO 0 according to pci express spec which says:    

Re: [PATCH] Fix compilation when UFFDIO_REGISTER is not set.

28.09.2023 15:56, Pierre Labatut wrote: Signed-off-by: Pierre Labatut --- subprojects/libvhost-user/libvhost-user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) I'm not sure how subprojects are handled here. Should we commit things to a subproject directly? This one does not seem

Re: [PATCH] MAINTAINERS: Add g364fb and ds1225y to the Jazz section

29.09.2023 17:09, Thomas Huth: These devices are only used by the Jazz machine, so they should be listed in the corresponding section in MAINTAINERS. The devices look like git commit IDs :) (at least the first one) Applied to my trivial-patches tree, thanks! /mjt Signed-off-by: Thomas Huth

Re: [PATCH] MAINTAINERS: Add unowned RISC-V related files to the right sections

29.09.2023 15:37, Thomas Huth wrote: There are a bunch of RISC-V files that are currently not covered by the "get_maintainers.pl" script. Add them to the right sections in MAINTAINERS to fix this problem. Applied to my trivial-patches tree, thanks! /mjt

Re: [PATCH v2 3/5] ramfb: implement migration support

Hi On Mon, Oct 2, 2023 at 3:12 PM wrote: > > From: Marc-André Lureau > > Implementing RAMFB migration is quite straightforward. One caveat is to > treat the whole RAMFBCfg as a blob, since that's what is exposed to the > guest directly. This avoid having to fiddle with endianness issues if we >

Re: [PATCH] MAINTAINERS: Add include folder to the hw/char/ section

29.09.2023 15:44, Thomas Huth wrote: The "Character devices" section only covers hw/char/ but misses the corresponding include/hw/char/ folder. Add it now. Signed-off-by: Thomas Huth Applied to my trivial-patches tree, thanks! /mjt

Re: [PATCH] MAINTAINERS: Add the CI-related doc files to the CI section

29.09.2023 16:16, Thomas Huth: The docs/devel/ci* were not covered yet, add them to MAINTAINERS so that the right people are put on CC: for related patches. Signed-off-by: Thomas Huth Applied to my trivial-patches tree, thanks! /mjt

Re: [PATCH] MAINTAINERS: add standard-headers to Hosts/LINUX

29.09.2023 17:30, Cornelia Huck: The files in there are updated via update-linux-headers.sh. Signed-off-by: Cornelia Huck Applied to my trivial-patches tree, thanks! /mjt

Re: [PATCH v1] roms: use PYTHON to invoke python

02.10.2023 13:18, Olaf Hering: python3 may not be the expected python version. Use PYTHON to invoke python. Applied to my trivial-patches tree, thanks! /mjt Fixes: 22e11539e1 ("edk2: replace build scripts") Signed-off-by: Olaf Hering diff --git a/roms/Makefile b/roms/Makefile efi: -

[PULL 01/13] migration-test: Create kvm_opts

So arch_dirty_ring option becomes one option like the others. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-8-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/qtest/m

[PULL 12/13] migration: Remove unused qemu_file_credit_transfer()

After this change, nothing abuses QEMUFile to account for data transferrefd during migration. Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-15-quint...@redhat.com> --- migration/qemu-file.h | 8 migration/qemu-file.c | 5 - 2 files change

[PULL 02/13] migration-test: bootpath is the same for all tests and for all archs

So just make it a global variable. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-9-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/tests/qtest/migration-test.c b

[PULL 06/13] migration: Refactor repeated call of yank_unregister_instance

From: Tejus GK In the function qmp_migrate(), yank_unregister_instance() gets called twice which isn't required. Hence, refactoring it so that it gets called during the local_error cleanup. Reviewed-by: Daniel P. Berrangé Reviewed-by: Juan Quintela Acked-by: Peter Xu Signed-off-by: Tejus GK

[PULL 10/13] migration/rdma: Remove QEMUFile parameter when not used

Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-13-quint...@redhat.com> --- migration/rdma.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index 2a3c784328..9007261b5c 10

[PULL 03/13] migration-test: Add bootfile_create/delete() functions

The bootsector code is read only from the guest (otherwise we are going to have problems with it being read from both source and destination). Create a single copy for all the tests. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-10-quint...@redhat.com> Signed-off-by: Juan Quintela ---

[PULL 11/13] migration/rdma: Don't use imaginary transfers

RDMA protocol is completely asynchronous, so in qemu_rdma_save_page() they "invent" that a byte has been transferred. And then they call qemu_file_credit_transfer() and ram_transferred_add() with that byte. Just remove that calls as nothing has been sent. Reviewed-by: Leonardo Bras Signed-off-by

[PULL 09/13] migration/RDMA: It is accounting for zero/normal pages in two places

Remove the one in control_save_page(). Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-12-quint...@redhat.com> --- migration/ram.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 9040d66e61..f2c5b07919 1

[PULL 00/13] Migration 20231002 patches

The following changes since commit 36e9aab3c569d4c9ad780473596e18479838d1aa: migration: Move return path cleanup to main migration thread (2023-09-27 13:58:02 -0400) are available in the Git repository at: https://gitlab.com/juan.quintela/qemu.git tags/migration-20231002-pull-request for

[PULL 05/13] migration-test: simplify shmem_opts handling

Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 334648ae19..46f

[PULL 13/13] migration/rdma: Simplify the function that saves a page

When we sent a page through QEMUFile hooks (RDMA) there are three posiblities: - We are not using RDMA. return RAM_SAVE_CONTROL_DELAYED and control_save_page() returns false to let anything else to proceed. - There is one error but we are using RDMA. Then we return a negative value, control_sa

[PULL 07/13] migration: Use qemu_file_transferred_noflush() for block migration.

We only care about the amount of bytes transferred. Flushing is done by the system somewhere else. Reviewed-by: Fabiano Rosas Signed-off-by: Juan Quintela Message-ID: <20230530183941.7223-4-quint...@redhat.com> Signed-off-by: Juan Quintela --- migration/block.c | 4 ++-- 1 file changed, 2 ins

[PULL 08/13] migration: Don't abuse qemu_file transferred for RDMA

Just create a variable for it, the same way that multifd does. This way it is safe to use for other thread, etc, etc. Reviewed-by: Leonardo Bras Signed-off-by: Juan Quintela Message-Id: <20230515195709.63843-11-quint...@redhat.com> --- migration/migration-stats.h | 4 migration/migration

[PULL 04/13] migration-test: dirtylimit checks for x86_64 arch before

So no need to assert we are in x86_64. Once there, refactor the function to remove useless variables. Reviewed-by: Peter Xu Message-ID: <20230608224943.3877-11-quint...@redhat.com> Signed-off-by: Juan Quintela --- tests/qtest/migration-test.c | 5 + 1 file changed, 1 insertion(+), 4 deletio

[PATCH 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

Signed-off-by: Cédric Le Goater --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce46..3f90264203cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1345,7 +1345,7 @@ PowerPC Machines 405 (ref405ep) L: qemu-...@nongnu.org

[PATCH 1/8] ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header

Cc: "Edgar E. Iglesias" (odd fixer:virtex_ml507) Signed-off-by: Cédric Le Goater --- hw/ppc/ppc440_bamboo.c | 1 - hw/ppc/virtex_ml507.c | 1 - 2 files changed, 2 deletions(-) diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c index 45f409c83862..a189942de4cf 100644 --- a/hw/ppc/ppc4

[PATCH 3/8] MAINTAINERS: Adjust file list for PPC 4xx CPUs

Signed-off-by: Cédric Le Goater --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 3f90264203cc..2bf7af9bd150 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1960,7 +1960,9 @@ F: docs/specs/acpi_hest_ghes.rst ppc4xx L: qemu-...@

[PATCH 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

The fdt.{c.h} files provide a helper routine used by the pseries and pnv machines. Attached it to the list of the larger one: pseries. Protected Execution Facility (PEF) is the confidential guest support for PPC pseries machines. Signed-off-by: Cédric Le Goater --- MAINTAINERS | 4 1 file

[PATCH 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

Signed-off-by: Cédric Le Goater --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2bf7af9bd150..23ce59995d59 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1357,6 +1357,7 @@ e500 L: qemu-...@nongnu.org S: Orphan F: hw/ppc/e500* +F: hw/ppc/ppc

[PATCH 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

The hw/ppc/fw_cfg.c file contains the implementation of fw_cfg_arch_key_name(), used by the common nvram model. List it under mac99 machine next to the mac_nvram model. Cc: Mark Cave-Ayland Signed-off-by: Cédric Le Goater --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINT

[PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

Hello, All PPC files should now be correctly assigned to some entry. Cheers, C. Cédric Le Goater (8): ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header MAINTAINERS: Adjust file list for PPC ref405ep machine MAINTAINERS: Adjust file list for PPC 4xx CPUs MAINT

[PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

Cc: Richard Henderson Signed-off-by: Cédric Le Goater --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2d00d14ef226..9fe9294eccb9 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3550,6 +3550,7 @@ PPC TCG target M: Richard Henderson S: Odd Fixe

[PATCH 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

Signed-off-by: Cédric Le Goater --- MAINTAINERS | 5 + 1 file changed, 5 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1f72931ac2a4..2d00d14ef226 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -307,6 +307,11 @@ F: target/ppc/ F: hw/ppc/ppc.c F: hw/ppc/ppc_booke.c F: include/hw

Re: [PATCH] MAINTAINERS: Add g364fb and ds1225y to the Jazz section

On 29/9/23 16:09, Thomas Huth wrote: These devices are only used by the Jazz machine, so they should be listed in the corresponding section in MAINTAINERS. Signed-off-by: Thomas Huth --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) Acked-by: Philippe Mathieu-Daudé

Re: [PATCH 2/4] tcg/optimize: Pipe OptContext into reset_ts

On 31/8/23 04:57, Richard Henderson wrote: Will be needed in the next patch. Signed-off-by: Richard Henderson --- tcg/optimize.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

Hi Cédric, On 2/10/23 14:23, Cédric Le Goater wrote: Signed-off-by: Cédric Le Goater --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 355b1960ce46..3f90264203cc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1345,7 +1345,7 @@

Re: [PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

On 2/10/23 14:23, Cédric Le Goater wrote: Cc: Richard Henderson Signed-off-by: Cédric Le Goater --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 0/2] Split out tcg init functions to tcg/startup.h

On 30/9/23 05:11, Richard Henderson wrote: Supercedes: <20230923130843.3708899-1-peter.mayd...@linaro.org> ("[PATCH] tcg.h: Split out runtime-only functions into tcg/runtime.h") I thought "startup.h" was perhaps a better name than "runtime.h", at least for the functions moved, since it's about s

Re: [PATCH 3/3] hw/nvme: Add SPDM over DOE support

On Mon, Oct 02, 2023 at 11:36:25AM +, Yao, Jiewen wrote: > Comment on subjectAltName. > > PCI-SIG realized that it may cause problem for certain device > and decided to remove such requirement in future ECN. > I don't think that is absolutely needed. We have to follow what's in the spec. We

Re: [PATCH v6 04/19] linux-user: Use ImageSource in load_elf_image

On 30/9/23 04:15, Richard Henderson wrote: Change parse_elf_properties as well, as the bprm_buf argument ties the two functions closely. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 128 +-- 1 file changed, 49 insertions(+), 79 deletions

Re: [PATCH v2 4/5] ramfb: make migration conditional

On 10/2/23 13:11, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau RAMFB migration was unsupported until now, let's make it conditional. The following patch will prevent machines <= 8.1 to migrate it. Signed-off-by: Marc-André Lureau Maybe localize the new 'ramfb_migrate' attribute

Re: [PATCH v2 06/12] vfio/pci: Introduce vfio_[attach/detach]_device

Hi Zhenzhong, On 9/27/23 14:32, Duan, Zhenzhong wrote: > >> -Original Message- >> From: Eric Auger >> Sent: Wednesday, September 27, 2023 8:23 PM >> Subject: Re: [PATCH v2 06/12] vfio/pci: Introduce vfio_[attach/detach]_device >> >> >> >> On 9/27/23 12:07, Duan, Zhenzhong wrote: >>> Hi Er

Re: [PATCH 7/7] vhost-user: call VHOST_USER_SET_VRING_ENABLE synchronously

On 10/2/23 08:57, Michael S. Tsirkin wrote: > On Mon, Oct 02, 2023 at 03:56:03AM +0200, Laszlo Ersek wrote: >> On 10/1/23 21:25, Michael S. Tsirkin wrote: >>> Not this actually - v2 of this. >> >> Thank you, but: >> >> - Stefan's question should be answered still IMO (although if you pick >> up thi

Re: [PATCH 0/3] vhost: clean up device reset

QE tested a regression testing on this series with vhost-vdpa device, everything is working fine. Tested-by: Lei Yang On Thu, Sep 28, 2023 at 6:40 PM Eugenio Perez Martin wrote: > > On Wed, Sep 27, 2023 at 9:27 PM Stefan Hajnoczi wrote: > > > > Stateful vhost devices may need to free resources

  1   2   3   >