Hi Phillipe, This patch has been taken as it is from ARM's RFC and the common patch-set mentioned below. So SOBs are all wrong everywhere.
Original RFC posted in the year 2020. [1] https://lore.kernel.org/qemu-devel/20200613213629.21984-23-salil.me...@huawei.com/ Recently posted RFC V2 [2] https://lore.kernel.org/qemu-devel/20230926100436.28284-1-salil.me...@huawei.com/T/#m5f5ae40b091d69d01012880d7500d96874a9d39c Recent common patch-set for Virtual CPU Hotplug [3] https://lore.kernel.org/qemu-devel/20230930001933.2660-9-salil.me...@huawei.com/ [4] https://lore.kernel.org/qemu-devel/20230930001933.2660-10-salil.me...@huawei.com/ Beside my original patch-set had bug which you have inherited in this patch-set. Thanks Salil > From: qemu-arm-bounces+salil.mehta=huawei....@nongnu.org <qemu-arm- > bounces+salil.mehta=huawei....@nongnu.org> On Behalf Of Philippe Mathieu- > Daudé > Sent: Monday, September 18, 2023 5:03 PM > To: qemu-devel@nongnu.org > Cc: Laurent Vivier <laur...@vivier.eu>; Paolo Bonzini > <pbonz...@redhat.com>; Max Filippov <jcmvb...@gmail.com>; David Hildenbrand > <da...@redhat.com>; Peter Xu <pet...@redhat.com>; Anton Johansson > <a...@rev.ng>; Peter Maydell <peter.mayd...@linaro.org>; > k...@vger.kernel.org; Marek Vasut <ma...@denx.de>; David Gibson > <da...@gibson.dropbear.id.au>; Brian Cain <bc...@quicinc.com>; Yoshinori > Sato <ys...@users.sourceforge.jp>; Edgar E . Iglesias > <edgar.igles...@gmail.com>; Claudio Fontana <cfont...@suse.de>; Daniel > Henrique Barboza <dbarb...@ventanamicro.com>; Artyom Tarasenko > <atar4q...@gmail.com>; Marcelo Tosatti <mtosa...@redhat.com>; qemu- > p...@nongnu.org; Liu Zhiwei <zhiwei_...@linux.alibaba.com>; Aurelien Jarno > <aurel...@aurel32.net>; Ilya Leoshkevich <i...@linux.ibm.com>; Daniel > Henrique Barboza <danielhb...@gmail.com>; Bastian Koppelmann > <kbast...@mail.uni-paderborn.de>; Cédric Le Goater <c...@kaod.org>; Alistair > Francis <alistair.fran...@wdc.com>; Alessandro Di Federico <a...@rev.ng>; > Song Gao <gaos...@loongson.cn>; Marcel Apfelbaum > <marcel.apfelb...@gmail.com>; Chris Wulff <crwu...@gmail.com>; Michael S. > Tsirkin <m...@redhat.com>; Alistair Francis <alist...@alistair23.me>; > Fabiano Rosas <faro...@suse.de>; qemu-s3...@nongnu.org; wangyanan (Y) > <wangyana...@huawei.com>; Luc Michel <l...@lmichel.fr>; Weiwei Li > <liwei...@iscas.ac.cn>; Bin Meng <bin.m...@windriver.com>; Stafford Horne > <sho...@gmail.com>; Xiaojuan Yang <yangxiaoj...@loongson.cn>; Daniel P . > Berrange <berra...@redhat.com>; Thomas Huth <th...@redhat.com>; Philippe > Mathieu-Daudé <phi...@linaro.org>; qemu-...@nongnu.org; Jiaxun Yang > <jiaxun.y...@flygoat.com>; Richard Henderson > <richard.hender...@linaro.org>; Aleksandar Rikalo > <aleksandar.rik...@syrmia.com>; Bernhard Beschow <shen...@gmail.com>; Mark > Cave-Ayland <mark.cave-ayl...@ilande.co.uk>; qemu-ri...@nongnu.org; Alex > Bennée <alex.ben...@linaro.org>; Nicholas Piggin <npig...@gmail.com>; Greg > Kurz <gr...@kaod.org>; Michael Rolnik <mrol...@gmail.com>; Eduardo Habkost > <edua...@habkost.net>; Markus Armbruster <arm...@redhat.com>; Palmer > Dabbelt <pal...@dabbelt.com>; xianglai li <lixiang...@loongson.cn>; Salil > Mehta <salil.me...@opnsrc.net>; Igor Mammedov <imamm...@redhat.com>; Ani > Sinha <anisi...@redhat.com>; Bibo Mao <maob...@loongson.cn> > Subject: [PATCH 07/22] exec/cpu: Introduce the CPU address space > destruction function > > From: xianglai li <lixiang...@loongson.cn> > > Introduce new function to destroy CPU address space resources > for cpu hot-(un)plug. > > Co-authored-by: "Salil Mehta" <salil.me...@opnsrc.net> > Cc: "Salil Mehta" <salil.me...@opnsrc.net> > Cc: Xiaojuan Yang <yangxiaoj...@loongson.cn> > Cc: Song Gao <gaos...@loongson.cn> > Cc: "Michael S. Tsirkin" <m...@redhat.com> > Cc: Igor Mammedov <imamm...@redhat.com> > Cc: Ani Sinha <anisi...@redhat.com> > Cc: Paolo Bonzini <pbonz...@redhat.com> > Cc: Richard Henderson <richard.hender...@linaro.org> > Cc: Eduardo Habkost <edua...@habkost.net> > Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com> > Cc: "Philippe Mathieu-Daudé" <phi...@linaro.org> > Cc: Yanan Wang <wangyana...@huawei.com> > Cc: "Daniel P. Berrangé" <berra...@redhat.com> > Cc: Peter Xu <pet...@redhat.com> > Cc: David Hildenbrand <da...@redhat.com> > Cc: Bibo Mao <maob...@loongson.cn> > Signed-off-by: xianglai li <lixiang...@loongson.cn> > Message-ID: > <3a4fc2a3df4b767c3c296a7da3bc15ca9c251316.1694433326.git.lixianglai@loongso > n.cn> > --- > include/exec/cpu-common.h | 8 ++++++++ > include/hw/core/cpu.h | 1 + > softmmu/physmem.c | 24 ++++++++++++++++++++++++ > 3 files changed, 33 insertions(+) > > diff --git a/include/exec/cpu-common.h b/include/exec/cpu-common.h > index 41788c0bdd..eb56a228a2 100644 > --- a/include/exec/cpu-common.h > +++ b/include/exec/cpu-common.h > @@ -120,6 +120,14 @@ size_t qemu_ram_pagesize_largest(void); > */ > void cpu_address_space_init(CPUState *cpu, int asidx, > const char *prefix, MemoryRegion *mr); > +/** > + * cpu_address_space_destroy: > + * @cpu: CPU for which address space needs to be destroyed > + * @asidx: integer index of this address space > + * > + * Note that with KVM only one address space is supported. > + */ > +void cpu_address_space_destroy(CPUState *cpu, int asidx); > > void cpu_physical_memory_rw(hwaddr addr, void *buf, > hwaddr len, bool is_write); > diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h > index 92a4234439..c90cf3a162 100644 > --- a/include/hw/core/cpu.h > +++ b/include/hw/core/cpu.h > @@ -366,6 +366,7 @@ struct CPUState { > QSIMPLEQ_HEAD(, qemu_work_item) work_list; > > CPUAddressSpace *cpu_ases; > + int cpu_ases_ref_count; > int num_ases; > AddressSpace *as; > MemoryRegion *memory; > diff --git a/softmmu/physmem.c b/softmmu/physmem.c > index 18277ddd67..c75e3e8042 100644 > --- a/softmmu/physmem.c > +++ b/softmmu/physmem.c > @@ -761,6 +761,7 @@ void cpu_address_space_init(CPUState *cpu, int asidx, > > if (!cpu->cpu_ases) { > cpu->cpu_ases = g_new0(CPUAddressSpace, cpu->num_ases); > + cpu->cpu_ases_ref_count = cpu->num_ases; > } > > newas = &cpu->cpu_ases[asidx]; > @@ -774,6 +775,29 @@ void cpu_address_space_init(CPUState *cpu, int asidx, > } > } > > +void cpu_address_space_destroy(CPUState *cpu, int asidx) > +{ > + CPUAddressSpace *cpuas; > + > + assert(asidx < cpu->num_ases); > + assert(asidx == 0 || !kvm_enabled()); > + assert(cpu->cpu_ases); > + > + cpuas = &cpu->cpu_ases[asidx]; > + if (tcg_enabled()) { > + memory_listener_unregister(&cpuas->tcg_as_listener); > + } > + > + address_space_destroy(cpuas->as); > + > + cpu->cpu_ases_ref_count--; > + if (cpu->cpu_ases_ref_count == 0) { > + g_free(cpu->cpu_ases); > + cpu->cpu_ases = NULL; > + } > + > +} > + > AddressSpace *cpu_get_address_space(CPUState *cpu, int asidx) > { > /* Return the AddressSpace corresponding to the specified index */ > -- > 2.41.0 > >
