On Sat, Sep 30, 2023 at 10:41:12AM +0200, Markus Armbruster wrote: > Ani Sinha <anisi...@redhat.com> writes: > > >> On 29-Sep-2023, at 2:20 PM, Markus Armbruster <arm...@redhat.com> wrote: > >> > >> From: Ani Sinha <anisi...@redhat.com> > >> > >> Code changes in acpi that addresses all compiler complaints coming from > >> enabling > >> -Wshadow flags. Enabling -Wshadow catches cases of local variables > >> shadowing > >> other local variables or parameters. These makes the code confusing and/or > >> adds > >> bugs that are difficult to catch. See also > >> > >> Subject: Help wanted for enabling -Wshadow=local > >> Message-Id: <87r0mqlf9x....@pond.sub.org> > >> https://lore.kernel.org/qemu-devel/87r0mqlf9x....@pond.sub.org > >> > >> The code is tested to build with and without the flag turned on. > >> > >> CC: Markus Armbruster <arm...@redhat.com> > >> CC: Philippe Mathieu-Daude <phi...@linaro.org> > >> CC: m...@redhat.com > >> CC: imamm...@redhat.com > >> Signed-off-by: Ani Sinha <anisi...@redhat.com> > >> Message-ID: <20230922124203.127110-1-anisi...@redhat.com> > >> Reviewed-by: Michael S. Tsirkin <m...@redhat.com> > >> [Commit message tweaked] > >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > > > Thanks! > > Are you not going to pick up "hw/i386: changes towards enabling > > -Wshadow=local” ? > > Your conversation with Michael looked unfinished to me, so I didn't > include your patch in my pull request. I did add it to shadow-next.
Yes - I clarified what I meant. These patch just always changed the name of the inner scope variable but that is not always the best thing to do. -- MST
