Re: [PATCH v1 00/23] Q35 support for Xen

2023-07-05 Thread Bernhard Beschow
Am 5. Juli 2023 16:50:28 UTC schrieb Joel Upham : >I believe it might have been master unstable branch. Last commit before my >patches was: > >commit 19a720b74fde7e859d19f12c66a72e545947a657 >Merge: c6a5fc2ac7 367189efae >Author: Richard Henderson >Date: Thu Jun 1 08:30:29 2023 -0700 Indeed!

Re: [PATCH v2 6/7] qemufile: Always return a verbose error

2023-07-05 Thread Peter Xu
On Wed, Jul 05, 2023 at 06:54:37PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > There're a lot of cases where we only have an errno set in last_error but > > without a detailed error description. When this happens, try to generate > > an error contains the errno as a descriptive error. >

Re: [PATCH v2 7/7] migration: Provide explicit error message for file shutdowns

2023-07-05 Thread Peter Xu
On Wed, Jul 05, 2023 at 07:05:13PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > Provide an explicit reason for qemu_file_shutdown()s, which can be > > displayed in query-migrate when used. > > > > Can we consider this to cover the TODO: > > * TODO: convert to propagate Error objects in

[PATCH] virtio-gpu-udmabuf: replacing scanout_width/height with backing_width/height

2023-07-05 Thread Dongwon Kim
'backing_width' and 'backing_height' are commonly used to indicate the size of the whole backing region so it makes sense to use those terms for VGAUDMABuf as well in place of 'scanout_width' and 'scanout_height'. Cc: Gerd Hoffmann Cc: Marc-André Lureau Cc: Vivek Kasireddy Signed-off-by: Dongwo

Re: [PATCH] ui/gtk: set the area of the scanout texture correctly

2023-07-05 Thread Kim, Dongwon
On 7/4/2023 9:07 AM, Marc-André Lureau wrote: Hi On Mon, Jun 26, 2023 at 9:49 PM Kim, Dongwon wrote: Hi Marc-André Lureau, On 6/26/2023 4:56 AM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 21, 2023 at 11:53 PM Dongwon Kim > wrote: > >     x and y offse

Re: Reducing vdpa migration downtime because of memory pin / maps

2023-07-05 Thread Si-Wei Liu
On 7/5/2023 11:03 AM, Eugenio Perez Martin wrote: On Tue, Jun 27, 2023 at 8:36 AM Si-Wei Liu wrote: On 6/9/2023 7:32 AM, Eugenio Perez Martin wrote: On Fri, Jun 9, 2023 at 12:39 AM Si-Wei Liu wrote: On 6/7/23 01:08, Eugenio Perez Martin wrote: On Wed, Jun 7, 2023 at 12:43 AM Si-Wei Liu

Re: [PATCH v2 07/14] ppc/sam460ex: Remove address_space_mem local variable

2023-07-05 Thread Daniel Henrique Barboza
On 7/5/23 17:12, BALATON Zoltan wrote: Some places already use get_system_memory() directly so replace the remaining uses and drop the local variable. Signed-off-by: BALATON Zoltan --- Reviewed-by: Daniel Henrique Barboza hw/ppc/sam460ex.c | 8 1 file changed, 4 insertions(

Re: [PATCH v2 00/14] PPC440 devices misc clean up

2023-07-05 Thread Daniel Henrique Barboza
Zoltan, Patches 1-9 are queued. Don't need to re-send those. Thanks, Daniel On 7/5/23 17:12, BALATON Zoltan wrote: These are some small misc clean ups to PPC440 related device models which is all I have ready for now. v2: - Added R-b tags from Philippe - Addressed review comments - Added ne

Re: [PATCH v2 00/14] PPC440 devices misc clean up

2023-07-05 Thread BALATON Zoltan
On Wed, 5 Jul 2023, Daniel Henrique Barboza wrote: Zoltan, Patches 1-9 are queued. Don't need to re-send those. Thanks, the last two patches are also reviewed and they don't depend on the ones before so you could queue those too. The only outstanding patches are those 3 that rename the type

Re: [PATCH v8 5/6] hw/pci: warn when PCIe device is plugged into non-zero slot of downstream port

2023-07-05 Thread Akihiko Odaki
On 2023/07/05 20:59, Ani Sinha wrote: PCIe downstream ports only have a single device 0, so PCI Express devices can only be plugged into slot 0 on a PCIe port. Add a warning to let users know when the invalid configuration is used. We may enforce this more strongly later once we get more clarity

Re: [PATCH] ppc/pnv: Set P10 core xscom region size to match hardware

2023-07-05 Thread Joel Stanley
On Wed, 5 Jul 2023 at 10:02, Cédric Le Goater wrote: > > On 7/5/23 04:05, Joel Stanley wrote: > > On Wed, 5 Jul 2023 at 01:27, Nicholas Piggin wrote: > >> > >> The P10 core xscom memory regions overlap because the size is wrong. > >> The P10 core+L2 xscom region size is allocated as 0x1000 (with

[PATCH] ppc/pnv: Log all unimp warnings with similar message

2023-07-05 Thread Joel Stanley
Add the function name so there's an indication as to where the message is coming from. Change all prints to use the offset instead of the address. Signed-off-by: Joel Stanley --- Happy to use the address instead of the offset (or print both), but I like the idea of being consistent. --- hw/ppc/p

Re: [PATCH qemu v5] aspeed add montblanc bmc reference from fuji

2023-07-05 Thread Sittisak Sinprem
Hi Mike, the FRUID data, it is used to define the BMC Mac address, to able the CIT, test_eeprom, test_bmc_mac on Qemu. On Thu, Jul 6, 2023 at 12:38 AM Mike Choi wrote: > Hi Sittisak, > > > > Minipack3 is not open-sourced yet, and we are unlikely to be able to > upstream detailed data. > > > >

[PATCH v2] riscv: Generate devicetree only after machine initialization is complete

2023-07-05 Thread Guenter Roeck
If the devicetree is created before machine initialization is complete, it misses dynamic devices. Specifically, the tpm device is not added to the devicetree file and is therefore not instantiated in Linux. Load/create devicetree in virt_machine_done() to solve the problem. Cc: Daniel Henrique Ba

Re: [PATCH 1/1] pcie: Add hotplug detect state register to w1cmask

2023-07-05 Thread Leonardo Bras Soares Passos
On Wed, Jul 5, 2023 at 3:40 AM Leonardo Bras Soares Passos wrote: > > On Tue, Jul 4, 2023 at 3:43 AM Michael S. Tsirkin wrote: > > > > On Tue, Jul 04, 2023 at 03:20:36AM -0300, Leonardo Brás wrote: > > > Hello Peter and Michael, I have a few updates on this: > > > > > > On Mon, 2023-07-03 at 02:2

[PATCH v2 1/1] pcie: Add hotplug detect state register to cmask

2023-07-05 Thread Leonardo Bras
When trying to migrate a machine type pc-q35-6.0 or lower, with this cmdline options, -device driver=pcie-root-port,port=18,chassis=19,id=pcie-root-port18,bus=pcie.0,addr=0x12 \ -device driver=nec-usb-xhci,p2=4,p3=4,id=nex-usb-xhci0,bus=pcie-root-port18,addr=0x12.0x1 the following bug happens

[PATCH v2 1/2] ppc/pnv: Set P10 core xscom region size to match hardware

2023-07-05 Thread Nicholas Piggin
The P10 core xscom memory regions overlap because the size is wrong. The P10 core+L2 xscom region size is allocated as 0x1000 (with some unused ranges). "EC" is used as a closer match, as "EX" includes L3 which has a disjoint xscom range that would require a different region if it were implemented.

[PATCH v2 2/2] tests/qtest: Add xscom tests for powernv10 machine

2023-07-05 Thread Nicholas Piggin
Add basic chip and core xscom tests for powernv10 machine, equivalent to tests for powernv8 and 9. Signed-off-by: Nicholas Piggin --- tests/qtest/pnv-xscom-test.c | 44 1 file changed, 35 insertions(+), 9 deletions(-) diff --git a/tests/qtest/pnv-xscom-test.

[PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

2023-07-05 Thread Nicholas Piggin
Sorry about the paper bag bug in the first version of the patch - I broke powernv8 and 9. This adds a xsom_size core class field to change the P10 size without changing the others. Also added a P10 xscom test, and passes make check. Thanks, Nick Nicholas Piggin (2): ppc/pnv: Set P10 core xsco

Re: Reducing vdpa migration downtime because of memory pin / maps

2023-07-05 Thread Eugenio Perez Martin
On Thu, Jul 6, 2023 at 2:13 AM Si-Wei Liu wrote: > > > > On 7/5/2023 11:03 AM, Eugenio Perez Martin wrote: > > On Tue, Jun 27, 2023 at 8:36 AM Si-Wei Liu wrote: > >> > >> > >> On 6/9/2023 7:32 AM, Eugenio Perez Martin wrote: > >>> On Fri, Jun 9, 2023 at 12:39 AM Si-Wei Liu wrote: > On 6/7/2

[PATCH v2 5/6] target/i386: Add few security fix bits in ARCH_CAPABILITIES into SapphireRapids CPU model

2023-07-05 Thread Tao Su
From: Lei Wang SapphireRapids has bit 13, 14 and 15 of MSR_IA32_ARCH_CAPABILITIES enabled, which are related to some security fixes. Add version 2 of SapphireRapids CPU model with those bits enabled also. Signed-off-by: Lei Wang Signed-off-by: Tao Su --- target/i386/cpu.c | 13 +++--

[PATCH v2 1/6] target/i386: Add FEAT_7_1_EDX to adjust feature level

2023-07-05 Thread Tao Su
Considering the case of FEAT_7_1_EAX being 0 and FEAT_7_1_EDX being non-zero. Such as starting a VM on GraniteRapids using '-cpu host', we can see two leafs CPUID_7_0 and CPUID_7_1 in VM, because both CPUID_7_1_EAX and CPUID_7_1_EDX have non-zero value, but if minus all FEAT_7_1_EAX features using

[PATCH v2 2/6] target/i386: Add support for MCDT_NO in CPUID enumeration

2023-07-05 Thread Tao Su
CPUID.(EAX=7,ECX=2):EDX[bit 5] enumerates MCDT_NO. Processors enumerate this bit as 1 do not exhibit MXCSR Configuration Dependent Timing (MCDT) behavior and do not need to be mitigated to avoid data-dependent behavior for certain instructions. Since MCDT_NO is in a new sub-leaf, add a new CPUID f

[PATCH v2 6/6] target/i386: Add new CPU model GraniteRapids

2023-07-05 Thread Tao Su
The GraniteRapids CPU model mainly adds the following new features based on SapphireRapids: - PREFETCHITI CPUID.(EAX=7,ECX=1):EDX[bit 14] - AMX-FP16 CPUID.(EAX=7,ECX=1):EAX[bit 21] And adds the following security fix for corresponding vulnerabilities: - MCDT_NO CPUID.(EAX=7,ECX=2):EDX[bit 5] - SBD

[PATCH v2 3/6] target/i386: Allow MCDT_NO if host supports

2023-07-05 Thread Tao Su
MCDT_NO bit indicates HW contains the security fix and doesn't need to be mitigated to avoid data-dependent behaviour for certain instructions. It needs no hypervisor support. Treat it as supported regardless of what KVM reports. Signed-off-by: Tao Su Reviewed-by: Xiaoyao Li --- target/i386/kvm

[PATCH v2 4/6] target/i386: Add new bit definitions of MSR_IA32_ARCH_CAPABILITIES

2023-07-05 Thread Tao Su
Currently, bit 13, 14, 15 and 24 of MSR_IA32_ARCH_CAPABILITIES are disclosed for fixing security issues, so add those bit definitions. Signed-off-by: Tao Su Reviewed-by: Igor Mammedov --- target/i386/cpu.h | 4 1 file changed, 4 insertions(+) diff --git a/target/i386/cpu.h b/target/i386/c

[PATCH v2 0/6] Add new CPU model GraniteRapids

2023-07-05 Thread Tao Su
This patch series mainly updates SapphireRapids CPU model and adds new CPU model GraniteRapids. Bit 13 (ARCH_CAP_SBDR_SSDP_NO), bit 14 (ARCH_CAP_FBSDP_NO) and bit 15 (ARCH_CAP_PSDP_NO) of MSR_IA32_ARCH_CAPABILITIES are enumerated starting from SapphireRapids, which are missed in current SapphireRa

Re: [PATCH v3 1/1] target/riscv: Add disas support for BF16 extensions

2023-07-05 Thread Alistair Francis
On Mon, Jul 3, 2023 at 5:20 PM Weiwei Li wrote: > > Signed-off-by: Weiwei Li > Signed-off-by: Junqiang Wang Acked-by: Alistair Francis Alistair > --- > disas/riscv.c | 44 > 1 file changed, 44 insertions(+) > > diff --git a/disas/riscv.c b/disas/

Re: [PATCH v1 0/4] virtio-mem: Support "x-ignore-shared" migration

2023-07-05 Thread Mario Casquero
This series has been tested successfully by QE. Start a VM with a 8G virtio-mem device and start memtester on it. Enable x-ignore-shared capability and then do migration. Migration was successful and virtio-mem can be resized as usual. Tested-by: Mario Casquero BR, Mario On Tue, Jun 20, 2023

Re: [PULL 0/1] Block patches

2023-07-05 Thread Richard Henderson
On 7/4/23 16:29, Stefan Hajnoczi wrote: The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75: Merge tag 'pull-tcg-20230701' ofhttps://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200) are available in the Git repository at: https://gitlab.com/stefa

Re: [PATCH] ppc/pnv: Set P10 core xscom region size to match hardware

2023-07-05 Thread Cédric Le Goater
On 7/6/23 04:33, Joel Stanley wrote: On Wed, 5 Jul 2023 at 10:02, Cédric Le Goater wrote: On 7/5/23 04:05, Joel Stanley wrote: On Wed, 5 Jul 2023 at 01:27, Nicholas Piggin wrote: The P10 core xscom memory regions overlap because the size is wrong. The P10 core+L2 xscom region size is alloc

Re: [PATCH v2 0/2] ppc/pnv: Set P10 core xscom region size to match hardware

2023-07-05 Thread Cédric Le Goater
On 7/6/23 07:39, Nicholas Piggin wrote: Sorry about the paper bag bug in the first version of the patch - I broke powernv8 and 9. This adds a xsom_size core class field to change the P10 size without changing the others. Also added a P10 xscom test, and passes make check. Now, you know there

Re: [PATCH] ppc/pnv: Log all unimp warnings with similar message

2023-07-05 Thread Cédric Le Goater
On 7/6/23 04:45, Joel Stanley wrote: Add the function name so there's an indication as to where the message is coming from. Change all prints to use the offset instead of the address. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Thanks, C. --- Happy to use the address inst

Re: [PATCH qemu v5] aspeed add montblanc bmc reference from fuji

2023-07-05 Thread Cédric Le Goater
On 7/6/23 05:14, Sittisak Sinprem wrote: Hi Mike, the FRUID data, it is used to define the BMC Mac address, to able the CIT, test_eeprom, test_bmc_mac on Qemu. That's enough for the commit log and the comment. Adding the EEPROM contents in QEMU enables more tests to be performed on the FW side

Re: [PATCH v2] Hexagon: move GETPC() calls to top level helpers

2023-07-05 Thread Richard Henderson
On 7/5/23 23:17, ltaylorsimp...@gmail.com wrote: -Original Message- From: Matheus Tavares Bernardino Sent: Wednesday, July 5, 2023 12:35 PM To: qemu-devel@nongnu.org Cc: quic_mathb...@quicinc.com; bc...@quicinc.com; ltaylorsimp...@gmail.com; quic_mlie...@quicinc.com; richard.hender...

[PATCH] meson.build: Remove the logic to link C code with the C++ linker

2023-07-05 Thread Thomas Huth
We are not mixing C++ with C code anymore, the only remaining C++ code in qga/vss-win32/ is used for a plain C++ executable. Thus we can remove the hacks for linking C code with the C++ linker now to simplify meson.build a little bit, and also to avoid that some C++ code sneaks in by accident again

Re: [PATCH RFC v2 2/4] vdpa: Restore MAC address filtering state

2023-07-05 Thread Hawkins Jiawei
On 2023/7/5 14:29, Eugenio Perez Martin wrote: > On Wed, Jul 5, 2023 at 3:43 AM Hawkins Jiawei wrote: >> >> On 2023/7/4 22:53, Eugenio Perez Martin wrote: >>> On Thu, Jun 29, 2023 at 5:26 PM Hawkins Jiawei wrote: This patch refactors vhost_vdpa_net_load_mac() to restore the MAC add

[PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"

2023-07-05 Thread Stefano Garzarella
This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2. That commit causes several problems in Linux as described in the BZ. In particular, after a while, other devices on the bus are no longer usable even if those devices are not affected by the hotunplug. This may be a problem in Linux, bu

Re: [PATCH] Revert "virtio-scsi: Send "REPORTED LUNS CHANGED" sense data upon disk hotplug events"

2023-07-05 Thread Thomas Huth
On 05/07/2023 09.15, Stefano Garzarella wrote: This reverts commit 8cc5583abe6419e7faaebc9fbd109f34f4c850f2. That commit causes several problems in Linux as described in the BZ. In particular, after a while, other devices on the bus are no longer usable even if those devices are not affected by

Re: [PATCH 06/21] q800: allow accesses to RAM area even if less memory is available

2023-07-05 Thread Laurent Vivier
Le 02/07/2023 à 17:48, Mark Cave-Ayland a écrit : MacOS attempts a series of writes and reads over the entire RAM area in order to determine the amount of RAM within the machine. Allow accesses to the entire RAM area ignoring writes and always reading zero for areas where there is no physical RAM

Re: [PATCH v2 1/1] vhost-vdpa: mute unaligned memory error report

2023-07-05 Thread Jason Wang
On Tue, Jul 4, 2023 at 3:19 PM Laurent Vivier wrote: > > With TPM CRM device, vhost-vdpa reports an error when it tries > to register a listener for a non aligned memory region: > > qemu-system-x86_64: vhost_vdpa_listener_region_add received unaligned region > qemu-system-x86_64: vhost_vdpa_li

Re: [PATCH v21 12/20] qapi/s390x/cpu topology: query-cpu-polarization qmp command

2023-07-05 Thread Thomas Huth
On 30/06/2023 11.17, Pierre Morel wrote: The query-cpu-polarization qmp command returns the current CPU polarization of the machine. Signed-off-by: Pierre Morel --- qapi/machine-target.json | 29 + hw/s390x/cpu-topology.c | 8 2 files changed, 37 inser

Re: [PATCH v3 0/3] vdpa: Return -EIO if device ack is VIRTIO_NET_ERR

2023-07-05 Thread Lei Yang
Hello Hawkins QE can help test this series before it is merged into master, I would like to know what test steps can cover this series related scenario? Thanks Lei On Tue, Jul 4, 2023 at 11:36 AM Hawkins Jiawei wrote: > > According to VirtIO standard, "The class, command and > command-specific

RE: [PATCH 1/2] virtio-iommu: Fix 64kB host page size VFIO device assignment

2023-07-05 Thread Duan, Zhenzhong
>-Original Message- >From: Eric Auger >Sent: Wednesday, July 5, 2023 2:20 PM >Subject: Re: [PATCH 1/2] virtio-iommu: Fix 64kB host page size VFIO device >assignment > >Hi Zhenzhong, >On 7/5/23 06:52, Duan, Zhenzhong wrote: >> Hi Eric, >> >>> -Original Message- >>> From: Eric Auger

x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

2023-07-05 Thread Claudio Fontana
Hi all, partially resurrecting an old thread. I've seen how for Epyc something special was done in the past in terms of apicid assignments based on topology, which was then reverted apparently, but I wonder if something more general would be useful to all? The QEMU apicid assignments first of al

[PATCH] pnv/xive2: Always pass a presenter object when accessing the TIMA

2023-07-05 Thread Frederic Barrat
The low-level functions to access the TIMA take a presenter object as a first argument. When accessing the TIMA from the IC BAR, i.e. indirect calls, we currently pass a NULL pointer for the presenter argument. While it appears ok with the current usage, it's dangerous. And it's pretty easy to figu

Re: [PATCH v4 0/6] Add RISC-V KVM AIA Support

2023-07-05 Thread Andrew Jones
On Wed, Jun 21, 2023 at 02:54:50PM +, Yong-Xuan Wang wrote: > This series adds support for KVM AIA in RISC-V architecture. > > In order to test these patches, we require Linux with KVM AIA support which > can > be found in the riscv_kvm_aia_hwaccel_v1 branch at > https://github.com/avpatel/li

RE: [PATCH 2/2] virtio-iommu: Rework the trace in virtio_iommu_set_page_size_mask()

2023-07-05 Thread Duan, Zhenzhong
>-Original Message- >From: Duan, Zhenzhong >Sent: Wednesday, July 5, 2023 12:56 PM >Subject: RE: [PATCH 2/2] virtio-iommu: Rework the trace in >virtio_iommu_set_page_size_mask() > > > >>-Original Message- >>From: Eric Auger >>Sent: Tuesday, July 4, 2023 7:15 PM >>To: eric.auger.

[PATCH v2] virtio: add a new vcpu watchdog

2023-07-05 Thread zhanghao1
Each vcpu creates a corresponding timer task. The watchdog is driven by a timer according to a certain period. Each time the timer expires, the counter is decremented. When the counter is "0", the watchdog considers the vcpu to be stalling and resets the VM. To avoid watchdog expiration, the guest

Re: [PATCH 1/2] virtio-iommu: Fix 64kB host page size VFIO device assignment

2023-07-05 Thread Jean-Philippe Brucker
On Wed, Jul 05, 2023 at 04:52:09AM +, Duan, Zhenzhong wrote: > Hi Eric, > > >-Original Message- > >From: Eric Auger > >Sent: Tuesday, July 4, 2023 7:15 PM > >Subject: [PATCH 1/2] virtio-iommu: Fix 64kB host page size VFIO device > >assignment > > > >When running on a 64kB page size ho

Re: [PATCH] ppc/pegasos2: Add support for -initrd command line option

2023-07-05 Thread Daniel Henrique Barboza
On 7/4/23 15:19, BALATON Zoltan wrote: Signed-off-by: BALATON Zoltan --- Reviewed-by: Daniel Henrique Barboza And pushed to ppc-next after amending the commit msg. Daniel hw/ppc/pegasos2.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff

Re: [PATCH v21 13/20] docs/s390x/cpu topology: document s390x cpu topology

2023-07-05 Thread Thomas Huth
On 30/06/2023 11.17, Pierre Morel wrote: Add some basic examples for the definition of cpu topology in s390x. Signed-off-by: Pierre Morel --- MAINTAINERS| 2 + docs/devel/index-internals.rst | 1 + docs/devel/s390-cpu-topology.rst | 170

Re: [PATCH v21 15/20] tests/avocado: s390x cpu topology polarisation

2023-07-05 Thread Thomas Huth
On 30/06/2023 11.17, Pierre Morel wrote: Polarization is changed on a request from the guest. Let's verify the polarization is accordingly set by QEMU. Signed-off-by: Pierre Morel --- tests/avocado/s390_topology.py | 46 ++ 1 file changed, 46 insertions(+) di

Re: [PATCH V9 32/46] vfio-pci: cpr part 2 (msi)

2023-07-05 Thread Kunkun Jiang via
Hi Steve, I have a few questions about the msi part of the vfio device. In the reboot mode, you mentioned "The guest drivers' suspend methods flush outstanding requests and re-initialize the devices". This means, during the downtime,the vfio device dose not generate interrupts. So no special proc

<    1   2   3