On 6/1/2023 9:18 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> From: "Vanderson M. do Rosario"
>>
>> -d tb_stats[[,level=(+all+jit+exec+time)][,dump_limit=]]
>>
>> "dump_limit" is used to limit the number of dumped TBStats in
>> linux-user mode.
>
> Why is user-mode special?
On 5/31/23 03:23, Nicholas Piggin wrote:
Doorbells in SMT need to coordinate msgsnd/msgclr and DPDES access from
multiple threads that affect the same state.
Signed-off-by: Nicholas Piggin
---
hw/ppc/ppc.c | 6 ++
include/hw/ppc/ppc.h
On 1/6/23 05:18, Akihiko Odaki wrote:
Recently MemReentrancyGuard was added to DeviceState to record that the
device is engaging in I/O. The network device backend needs to update it
when delivering a packet to a device.
This implementation follows what bottom half does, but it does not add
a tr
On 5/31/23 03:23, Nicholas Piggin wrote:
TCG now supports multi-threaded configuration at least enough for
pseries to be functional enough to boot Linux.
This requires PIR and TIR be set, because that's how sibling thread
matching is done.
Signed-off-by: Nicholas Piggin
---
hw/ppc/spapr.c
On 6/1/2023 9:23 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> From: "Vanderson M. do Rosario"
>>
>> Adding tb_stats [start|pause|stop|filter] command to hmp.
>> This allows controlling the collection of statistics.
>> It is also possible to set the level of collection:
>> all,
On 6/1/2023 9:30 AM, Richard Henderson wrote:
> On 5/30/23 01:35, Fei Wu wrote:
>> diff --git a/accel/tcg/tb-stats.c b/accel/tcg/tb-stats.c
>> index 805e1fc74d..139f049ffc 100644
>> --- a/accel/tcg/tb-stats.c
>> +++ b/accel/tcg/tb-stats.c
>> @@ -267,6 +267,25 @@ void do_hmp_tbstats_safe(CPUState *c
On Wed, May 31, 2023 at 10:09:05PM +0200, Philippe Mathieu-Daudé wrote:
> The 'lcitool variables $OS qemu' command produces a file containing
> consistent environment variables helpful to build QEMU on $OS.
> In particular the $PKGS variable contains the packages required to
> build QEMU.
>
> Sinc
On 2023/06/01 16:16, Philippe Mathieu-Daudé wrote:
On 1/6/23 05:18, Akihiko Odaki wrote:
Recently MemReentrancyGuard was added to DeviceState to record that the
device is engaging in I/O. The network device backend needs to update it
when delivering a packet to a device.
This implementation fol
Hello Nick,
On 5/31/23 03:23, Nicholas Piggin wrote:
Hi,
I'm posting this now just to get some first thoughts. I wouldn't say
it's ready but it does actually work with some basic tests including
pseries booting a Linux distro. I have powernv booting too, it just
requires some more SPRs converte
On 31/05/2023 16:00, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
On 31/5/23 14:53, Mark Cave-Ayland wrote:
Also change the instantiation of the CPU to use object_initialize_child()
followed by a separate realisation.
Signed-off-by: Mark Cave-Ayland
---
hw/m68k/q800.c
On Wed, May 31, 2023 at 10:09:03PM +0200, Philippe Mathieu-Daudé wrote:
> Inspired by this patch from Thomas:
> https://lore.kernel.org/qemu-devel/20230531090415.40421-1-th...@redhat.com/
>
> Instead of updating the package list manually, use lcitool vars file.
>
> Philippe Mathieu-Daudé (3):
>
On 31.05.23 21:09, Stefan Hajnoczi wrote:
Another issue is that 145 uses $TEST_IMG as follows:
SYSEMU_DRIVE_ARG=if=none,file="$TEST_IMG",driver=$IMGFMT
That doesn't work when json: contains a comma, since commas need to be
doubled up to escape them. This fails:
$ qemu-system-x86_64 -driv
On 6/1/23 00:24, Alex Williamson wrote:
> On Wed, 31 May 2023 23:55:41 +0200
> Robin Voetter wrote:
>> Something that I have been thinking about, are there any implications
>> involved with enabling this feature automatically with no possibility of
>> turning it off? I have no use case for that
On Wed, May 31, 2023 at 04:22:34PM +0200, Thomas Huth wrote:
> On 23/05/2023 15.31, Kashyap Chamarthy wrote:
> > Commit 812b31d3f9 (configs: rename default-configs to configs and
> > reorganise, 2021-07-07) did the rename.
> >
> > Reflect that update also in the documentation.
> >
> > Signed-off-
On 5/31/23 18:55, Jingbo Wu wrote:
From: Felix Wu
Hello Felix,
Thanks for the extension. It could be useful in some situations but
it seems also dangerous to set all lines controlled by a register
at once. The same comment applies to Nuvoton [1].
C.
[1]
https://lore.kernel.org/qemu-devel/C
On Wed, May 31, 2023 at 11:03:23PM +0200, Juan Quintela wrote:
> Richard Henderson wrote:
> > On 5/30/23 11:25, Juan Quintela wrote:
> >> The following changes since commit
> >> aa9bbd865502ed517624ab6fe7d4b5d89ca95e43:
> >>Merge tag 'pull-ppc-20230528' of https://gitlab.com/danielhb/qemu
> >
This series enables shadowed CVQ to intercept Offloads commands
through shadowed CVQ, update the virtio NIC device model so qemu
send it in a migration, and the restore of that Offloads state
in the destination.
Changelog
=
v2:
- make some function arguments const
- reuse virtio_vdev_h
Am 31.05.2023 um 21:00 hat Stefan Hajnoczi geschrieben:
> Hi Hanna,
> I'm adding the io_uring block driver (block/blkio.c) to qemu-iotests
> and hit a syntax issue with json:.
>
> In tests/qemu-iotests/common.rc where TEST_IMG_FILE and TEST_IMG are
> defined for each IMGPROTO, I'm unable to come u
Am 31.05.2023 um 21:50 hat Stefan Hajnoczi geschrieben:
> Hi Kevin,
> Do you want to review the thread-local blk_io_plug() patch series or
> should I merge it?
I haven't reviewed it in detail, but on the high level it looks good to
me, and you already got reviews for the details.
Acked-by: Kevin
On 5/30/23 15:28, BALATON Zoltan wrote:
The get_physical_address() function is a trivial wrapper of
get_physical_address_wtlb() that is only used once. Remove it and call
get_physical_address_wtlb() directly instead.
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
On 5/30/23 15:28, BALATON Zoltan wrote:
This function is the only reason why ppcemb_tlb_check() is not static
to mmu_common.c but it also better fits in mmu_common.c so move it
there.
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
target/ppc/cpu.h|
On 5/30/23 15:28, BALATON Zoltan wrote:
Make lines shorter and fix indentation in some functions prototypes.
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
target/ppc/cpu.h| 8 +++-
target/ppc/mmu_common.c | 8 +++-
2 files changed, 6 inse
On 5/30/23 15:28, BALATON Zoltan wrote:
This is only used by one caller so simplify function by removing this
parameter and move the operation to the single place where it's used.
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
target/ppc/cpu.h| 3 +
On 5/30/23 15:28, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
target/ppc/mmu_common.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/target/ppc/mmu_common.c b/target/ppc/mmu_common.
On 5/30/23 15:28, BALATON Zoltan wrote:
No nead to store return value and break from loop when we can return
directly.
Signed-off-by: BALATON Zoltan
Reviewed-by: Cédric Le Goater
Thanks,
C.
---
target/ppc/mmu_common.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
On 31.05.23 23:26, Eric Blake wrote:
On Wed, May 31, 2023 at 09:33:20PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 31.05.23 20:54, Eric Blake wrote:
On Wed, May 31, 2023 at 08:39:53PM +0300, Vladimir Sementsov-Ogievskiy wrote:
On 15.05.23 22:53, Eric Blake wrote:
All the pieces are in plac
To support restoring offloads state in vdpa, need to expose
the function virtio_net_supported_guest_offloads(), then vdpa
uses this function to get the guest supported offloads.
Signed-off-by: Hawkins Jiawei
---
hw/net/virtio-net.c| 2 +-
include/hw/virtio/virtio-net.h | 1 +
2 files
The VirtIODevice structure is not modified in
virtio_vdev_has_feature(). Therefore, make it const
to allow this function to accept const variables.
Signed-off-by: Hawkins Jiawei
---
include/hw/virtio/virtio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/hw/virtio/v
The VirtIONet structure is not modified in
virtio_net_supported_guest_offloads().
Therefore, make it const to allow this function to
accept const variables.
Signed-off-by: Hawkins Jiawei
---
hw/net/virtio-net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/virtio-net
This patch introduces vhost_vdpa_net_load_offloads() to
restore offloads state at device's startup.
Signed-off-by: Hawkins Jiawei
---
net/vhost-vdpa.c | 38 ++
1 file changed, 38 insertions(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index e907a3c792.
Enable SVQ with VIRTIO_NET_F_CTRL_GUEST_OFFLOADS feature.
Signed-off-by: Hawkins Jiawei
Acked-by: Jason Wang
---
net/vhost-vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 0e647886d1..4cc24a2997 100644
--- a/net/vhost-vdpa.c
+++ b/net/vhost-vd
We can use virtio_vdev_has_feature() instead of manually
accessing the features.
Signed-off-by: Hawkins Jiawei
---
net/vhost-vdpa.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c
index 37cdc84562..e907a3c792 100644
--- a/net/vhost-vd
On 30/05/23 5:40 pm, Daniel P. Berrangé wrote:
On Tue, May 30, 2023 at 01:02:27PM +0530, Het Gala wrote:
On 30/05/23 12:28 pm, Markus Armbruster wrote:
Het Gala writes:
[...]
+##
+{ 'enum': 'MigrateTransport',
+ 'data': ['socket', 'exec', 'rdma'] }
+
+##
+# @MigrateExecCommand:
Documen
On 1/6/23 09:41, Akihiko Odaki wrote:
On 2023/06/01 16:16, Philippe Mathieu-Daudé wrote:
On 1/6/23 05:18, Akihiko Odaki wrote:
Recently MemReentrancyGuard was added to DeviceState to record that the
device is engaging in I/O. The network device backend needs to update it
when delivering a packe
On Tue, May 30, 2023 at 08:25:23PM +0200, Juan Quintela wrote:
> Once there:
> - Remove unused data parameter
> - unfold it in its callers.
> - change all callers to call qemu_rdma_registration_start()
>
> Reviewed-by: Peter Xu
> Signed-off-by: Juan Quintela
> Message-Id: <20230509120700.78359-3
On 1/6/23 07:59, Markus Armbruster wrote:
Philippe Mathieu-Daudé writes:
Audit the sysbus_init_irq() calls and manually convert
to sysbus_init_irqs() when a loop is involved.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/loongarch_extioi.c | 3 +--
hw/intc/omap_intc.c| 3 +--
On Tue, May 30, 2023 at 08:25:24PM +0200, Juan Quintela wrote:
> Once there:
> - Remove unused data parameter
> - unfold it in its callers
> - change all callers to call qemu_rdma_registration_stop()
>
> Reviewed-by: Peter Xu
> Signed-off-by: Juan Quintela
> Message-Id: <20230509120700.78359-4-q
Mark Cave-Ayland writes:
> On 31/05/2023 16:00, Markus Armbruster wrote:
>
>> Philippe Mathieu-Daudé writes:
>>
>>> On 31/5/23 14:53, Mark Cave-Ayland wrote:
Also change the instantiation of the CPU to use object_initialize_child()
followed by a separate realisation.
Signed-off-b
On Tue, May 30, 2023 at 08:25:26PM +0200, Juan Quintela wrote:
> There is only one flag called with: RAM_CONTROL_BLOCK_REG.
>
> Reviewed-by: Peter Xu
> Signed-off-by: Juan Quintela
> Message-Id: <20230509120700.78359-6-quint...@redhat.com>
> ---
> migration/qemu-file.h | 11 ---
> migra
On Thu, 1 Jun 2023 at 16:48, Hawkins Jiawei wrote:
>
> To support restoring offloads state in vdpa, need to expose
> the function virtio_net_supported_guest_offloads(), then vdpa
> uses this function to get the guest supported offloads.
Here it should be changed to "then QEMU uses this function
t
On Thu, Jun 01, 2023 at 09:27:09AM +0100, Daniel P. Berrangé wrote:
> On Wed, May 31, 2023 at 11:03:23PM +0200, Juan Quintela wrote:
> > Richard Henderson wrote:
> > > On 5/30/23 11:25, Juan Quintela wrote:
> > >> The following changes since commit
> > >> aa9bbd865502ed517624ab6fe7d4b5d89ca95e43:
On Tue, May 30, 2023 at 08:25:25PM +0200, Juan Quintela wrote:
> Instead of going trhough ram_control_load_hook(), call
> qemu_rdma_registration_handle() directly.
>
> Reviewed-by: Peter Xu
> Signed-off-by: Juan Quintela
> Message-Id: <20230509120700.78359-5-quint...@redhat.com>
> ---
> migrati
On Wednesday, May 31, 2023 8:58 PM, Peter Xu wrote:
> > > Hmm.. so we used to do socket_start_incoming_migration_internal()
> > > before setting the right num for the preempt test, then I'm curious
> > > why it wasn't failing before this patch when trying to connect with the
> preempt channel..
> >
On 01/06/2023 10.17, Kashyap Chamarthy wrote:
On Wed, May 31, 2023 at 04:22:34PM +0200, Thomas Huth wrote:
On 23/05/2023 15.31, Kashyap Chamarthy wrote:
Commit 812b31d3f9 (configs: rename default-configs to configs and
reorganise, 2021-07-07) did the rename.
Reflect that update also in the doc
From: Zhao Liu
Hi all,
This is my v2 patch series based on c76e7652c786 ("Revert 'python/qmp/
protocol: add open_with_socket()'").
Compared with v1 [1], v2 uses the different ways to calculate
threads_per_socket and cores_per_socket, and add the sanity check to
ensure consistency of results bet
From: Zhao Liu
>From SMBIOS 3.0 specification, core count field means:
Core Count is the number of cores detected by the BIOS for this
processor socket. [1]
Before 003f230e37d7 ("machine: Tweak the order of topology members in
struct CpuTopology"), MachineState.smp.cores means "the number of co
From: Zhao Liu
>From SMBIOS 3.0 specification, thread count field means:
Thread Count is the total number of threads detected by the BIOS for
this processor socket. It is a processor-wide count, not a
thread-per-core count. [1]
So here we should use threads per socket other than threads per cor
From: Zhao Liu
Here're 2 mistakes:
1. 003f230e37d7 ("machine: Tweak the order of topology members in struct
CpuTopology") changes the meaning of smp.cores but doesn't fix
original smp.cores uses. And because of the introduction of cluster,
now smp.cores means the number of cores in one c
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
Add several counterparts of qtest_qmp_assert_success() that can
* Use va_list instead of ...
* Accept a list of FDs to send
* Return the response data
Signed-off-by: Daniel P. Berrangé
---
tests/qtest/libqtest.c | 99 +
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
This function duplicates logic of qtest_qmp_assert_success_ref
Signed-off-by: Daniel P. Berrangé
---
tests/qtest/migration-helpers.c | 22 --
tests/qtest/migration-helpers.h | 3 ---
tests/qtest/migration-test.c| 29 +++
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
Some of the usage is just a verbose way of re-inventing the
qtest_qmp_assert_success(_ref) methods.
Signed-off-by: Daniel P. Berrangé
---
tests/qtest/migration-helpers.c | 8 ++---
tests/qtest/migration-test.c| 52 --
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
Change the migration test to use the new qtest event callback to watch
for the stop event. This ensures that we only watch for the STOP event
on the source QEMU. The previous code would set the single 'got_stop'
flag when either source or dest QEMU g
On Thu, Jun 01, 2023 at 11:26:46AM +0200, Thomas Huth wrote:
> On 31/05/2023 15.23, Daniel P. Berrangé wrote:
> > This function duplicates logic of qtest_qmp_assert_success_ref
> >
> > Signed-off-by: Daniel P. Berrangé
> > ---
> > tests/qtest/migration-helpers.c | 22 --
> >
Add a script to generate Coccinelle semantic patch
removing all pointless QOM cast macro uses.
Suggested-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
scripts/qom-cast-macro-clean-cocci-gen.py | 49 +++
2 fi
As per Markus suggestion in [*], use Coccinelle to remove
pointless QOM cast macro uses. Since we have more than 1000
QOM types, add a script to generate the semantic patch.
[*] https://lore.kernel.org/qemu-devel/87mt1jafjt@pond.sub.org/
Philippe Mathieu-Daudé (2):
scripts: Add qom-cast-mac
Mechanical change running Coccinelle spatch with content
generated from the qom-cast-macro-clean-cocci-gen.py added
in the previous commit.
Suggested-by: Markus Armbruster
Signed-off-by: Philippe Mathieu-Daudé
---
block/nbd.c | 4 ++--
chardev/char-pty.c | 2 +-
hw/ar
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
Most usage of wait_command() is followed by qobject_unref(), which
is just a verbose re-implementation of qtest_qmp_assert_success().
Signed-off-by: Daniel P. Berrangé
---
tests/qtest/migration-helpers.c | 53 +-
tests/qtest/migration-h
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
When running migration tests we monitor for a STOP event so we can skip
redundant waits. This will be needed for the RESUME event too shortly.
Signed-off-by: Daniel P. Berrangé
---
tests/qtest/migration-helpers.c | 12
tests/qtest/m
Thanks, Hanna and Kevin!
I didn't implement bdrv_parse_filename() because I didn't want to invent
more legacy syntax. But maybe that legacy syntax does have a use and I just
didn't realize it :).
It's easy for io_uring, we can just take the filename and not worry about
other parameters (they can
The SYSBUS_DEVICE_GPIO_IRQ definition should be internal to
the SysBus API. Here we simply open-coded sysbus_pass_irq().
Replace to use the proper API.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/usb/xlnx-usb-subsystem.c | 2 +-
1 file changed, 1 insertion(+), 1
The SYSBUS_DEVICE_GPIO_IRQ definition should be internal to
the SysBus API. Here we simply open-coded sysbus_connect_irq().
Replace to use the proper API.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/arm/xlnx-versal.c | 4 +---
1 file changed, 1 insertion(+), 3 de
The SysBus API currently only provides a method to initialize
a single IRQ: sysbus_init_irq(). When we want to initialize
multiple SysBus IRQs, we have to call this function multiple
times. In order to allow further simplifications, introduce
the sysbus_init_irqs() method.
Signed-off-by: Philippe
Audit the sysbus_init_irq() calls and manually convert
to sysbus_init_irqs() when a loop is involved.
In omap2_intc_init(), the parent_intr[] array contains
2 elements: use ARRAY_SIZE() to iterate over.
Reviewed-by: Richard Henderson
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/omap_intc.
Since v1:
- Removed pointless QOM casts on a preliminary series [*] (Markus)
- Added Richard R-b tags
This series:
- Remove uses (out of sysbus.c) to the SYSBUS_DEVICE_GPIO_IRQ
definition, using proper SysBus API methods,
- Reduce SYSBUS_DEVICE_GPIO_IRQ scope, making it SysBus API
internal,
-
Change created mechanically using the following coccinelle
semantic patch:
@@
expression array;
identifier i;
expression sbd, count;
@@
-for (i = 0; i < count; i++) {
-sysbus_init_irq(sbd, &array[i]);
-}
+sysbus_init_irqs(sbd, array, count);
Since we don't have any use of the SYSBUS_DEVICE_GPIO_IRQ definition
outside of sysbus.c, we can reduce its scope, making it internal to
the API.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
include/hw/sysbus.h | 2 --
hw/core/sysbus.c| 2 ++
2 files changed, 2 i
The SYSBUS_DEVICE_GPIO_IRQ definition should be internal to
the SysBus API. Use the recently introduced sysbus_init_irqs()
method to avoid using this internal definition.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Richard Henderson
---
hw/usb/hcd-xhci-sysbus.c | 5 ++---
1 file changed,
On 31/05/2023 15.23, Daniel P. Berrangé wrote:
There are 27 pre-copy live migration scenarios being tested. In all of
these we force non-convergance and run for one iteration, then let it
converge and wait for completion during the second (or following)
iterations. At 3 mbps bandwidth limit the f
On Wed, May 31, 2023 at 10:09:06PM +0200, Philippe Mathieu-Daudé wrote:
> See previous commit for rationale on using lcitool vars file to
> get an up-to-date package list. Since there is a such file generated
> for FreeBSD 13 available in the repository, use it. That way we
> don't need to manually
I'm a QE responsible for vhost_vdpa parts. Could you please provide me
with the test steps for this series? I can test it in my environment
and update the test results.
On Thu, Jun 1, 2023 at 4:29 PM Hawkins Jiawei wrote:
>
> This series enables shadowed CVQ to intercept Offloads commands
> t
On Thu, Jun 01, 2023 at 09:36:27AM +0200, Erik Skultety wrote:
> On Wed, May 31, 2023 at 10:09:05PM +0200, Philippe Mathieu-Daudé wrote:
> > The 'lcitool variables $OS qemu' command produces a file containing
> > consistent environment variables helpful to build QEMU on $OS.
> > In particular the $
On 15.05.23 22:53, Eric Blake wrote:
The next commit will add support for the new addition of
NBD_CMD_FLAG_PAYLOAD during NBD_CMD_BLOCK_STATUS, where the client can
request that the server only return a subset of negotiated contexts,
rather than all contexts. To make that task easier, this patch
Erik Skultety writes:
> Alpine 3.16 -> 3.18
> Fedora 37 -> 38
>
> Signed-off-by: Erik Skultety
I've cherry picked this (minus alpine) into testing/next as I've got a
slightly newer lcitool refresh patch in my tree already.
Thanks.
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
On 31/05/2023 15.24, Daniel P. Berrangé wrote:
The migration test cases that actually exercise live migration want to
ensure there is a minimum of two iterations of pre-copy, in order to
exercise the dirty tracking code.
Historically we've queried the migration status, looking for the
'dirty-syn
On 31/05/2023 23:51, Suravee Suthikulpanit wrote:
> Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in
> arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number.
>
> In case KVM could not support the specified number of vcpus, QEMU would
> return the following e
On Thu, Jun 01, 2023 at 11:09:45AM +0100, Joao Martins wrote:
>
>
> On 31/05/2023 23:51, Suravee Suthikulpanit wrote:
> > Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in
> > arch/x86/include/asm/kvm_host.h, update QEMU limits to the same number.
> >
> > In case KVM could not
On Thu, 1 Jun 2023 at 10:48, Philippe Mathieu-Daudé wrote:
>
> Audit the sysbus_init_irq() calls and manually convert
> to sysbus_init_irqs() when a loop is involved.
>
> In omap2_intc_init(), the parent_intr[] array contains
> 2 elements: use ARRAY_SIZE() to iterate over.
>
> Reviewed-by: Richard
On 1/6/23 12:19, Peter Maydell wrote:
On Thu, 1 Jun 2023 at 10:48, Philippe Mathieu-Daudé wrote:
Audit the sysbus_init_irq() calls and manually convert
to sysbus_init_irqs() when a loop is involved.
In omap2_intc_init(), the parent_intr[] array contains
2 elements: use ARRAY_SIZE() to iterate
On 31/05/2023 17:12, Thomas Huth wrote:
On 31/05/2023 03.08, Richard Henderson wrote:
On 5/30/23 11:59, Richard Henderson wrote:
The following changes since commit 7fe6cb68117ac856e03c93d18aca09de015392b0:
Merge tag 'pull-target-arm-20230530-1'
ofhttps://git.linaro.org/people/pmaydell/qem
Hi,
> > I suspect smbios 3.0 (64-bit entry point) is already supported.
> >
> > With current qemu and all the smbios fixes in the last cycle, perhaps this
> > is
> > mainly just setting smbios_entry_point_type to SMBIOS_ENTRY_POINT_TYPE_64 if
> > MachineState::smp::max_cpus is bigger than 720
On Thu, Jun 01, 2023 at 11:17:30AM +0100, Daniel P. Berrangé wrote:
> On Thu, Jun 01, 2023 at 11:09:45AM +0100, Joao Martins wrote:
> >
> >
> > On 31/05/2023 23:51, Suravee Suthikulpanit wrote:
> > > Since KVM_MAX_VCPUS is currently defined to 1024 for x86 as shown in
> > > arch/x86/include/asm/k
On 31/5/23 06:02, Richard Henderson wrote:
Disconnect the layout of ArchCPU from TCG compilation.
Pass the relative offset of 'env' and 'neg.tlb.f' as a parameter.
Signed-off-by: Richard Henderson
---
include/exec/cpu-defs.h | 39 +-
include/exec/tlb-common.h
On 31/5/23 06:02, Richard Henderson wrote:
This had been pulled in from tcg/tcg.h, via exec/cpu_ldst.h,
via exec/exec-all.h, but the include of tcg.h will be removed.
Signed-off-by: Richard Henderson
---
target/avr/helper.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/avr/helpe
On 31/5/23 06:02, Richard Henderson wrote:
These two items are the last uses of TARGET_LONG_BITS within tcg.h,
and are more in common with the other "_tl" definitions within that file.
Signed-off-by: Richard Henderson
---
include/tcg/tcg-op.h| 15 ++-
include/tcg/tcg.h
On 31/5/23 06:03, Richard Henderson wrote:
This replaces of TCG_GUEST_DEFAULT_MO in tcg-op-ldst.c.
Signed-off-by: Richard Henderson
---
include/tcg/tcg.h | 1 +
accel/tcg/translate-all.c | 5 +
tcg/tcg-op-ldst.c | 4 +---
3 files changed, 7 insertions(+), 3 deletions(-)
On 31/5/23 06:02, Richard Henderson wrote:
This had been pulled in from tcg/tcg.h, via exec/cpu_ldst.h,
via exec/exec-all.h, but the include of tcg.h will be removed.
Signed-off-by: Richard Henderson
---
target/avr/cpu.c | 1 +
target/rx/cpu.c | 1 +
target/rx/op_helper.c | 1 +
Am 25. Mai 2023 16:03:15 UTC schrieb Mark Cave-Ayland
:
>On 23/05/2023 20:56, Bernhard Beschow wrote:
>
>> This series:
>> * Removes dead code from omap_uart and i82378
>> * Resolves redundant code in the i8254 timer devices
>>
>> v3:
>> * Drop TYPE_ISA_PARALLEL since they became obsolete by
>
Daniel P. Berrangé wrote:
> On Thu, Jun 01, 2023 at 09:27:09AM +0100, Daniel P. Berrangé wrote:
>> On Wed, May 31, 2023 at 11:03:23PM +0200, Juan Quintela wrote:
>> > Richard Henderson wrote:
>> > > On 5/30/23 11:25, Juan Quintela wrote:
>> > >> The following changes since commit
>> > >> aa9bbd8
The set of BlockDrivers that have .bdrv_file_open coincides with those
that have .protocol_name and guess what---checking drv->bdrv_file_open
is done to see if the driver is a protocol. So check drv->protocol_name
instead.
Signed-off-by: Paolo Bonzini
---
block.c | 11 +--
1 file change
.bdrv_needs_filename is only set for drivers that also set bdrv_file_open,
i.e. protocol drivers.
So we can make the assertion always, it will always pass for those drivers
that use bdrv_open.
Signed-off-by: Paolo Bonzini
---
block.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -
Mark functions as coroutine_fn when they are only called by other coroutine_fns
and they can suspend. Change calls to co_wrappers to use the non-wrapped
functions, which in turn requires adding GRAPH_RDLOCK annotations.
Signed-off-by: Paolo Bonzini
---
block/qed-check.c | 5 +++--
block/qed.c
Mark functions as coroutine_fn when they are only called by other coroutine_fns
and they can suspend. Because this function operates on a BlockBackend, mark it
GRAPH_UNLOCKED.
Signed-off-by: Paolo Bonzini
---
block.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git
Mark functions as coroutine_fn when they are only called by other coroutine_fns
and they can suspend. Change calls to co_wrappers to use the non-wrapped
functions, which in turn requires adding GRAPH_RDLOCK annotations.
Signed-off-by: Paolo Bonzini
---
block/bochs.c | 7 ---
1 file changed,
The value of the bdrv_file_open is sometimes checked to distinguish
protocol and format drivers, but apart from that there is no difference
between bdrv_file_open and bdrv_open.
However, they can all be distinguished by the non-NULL .protocol_name
member. Change the checks to use .protocol_name i
bdrv_block_status exists as a wrapper for bdrv_block_status_above,
but the name of the (hypothetical) coroutine version, bdrv_co_block_status,
is squatted by a random static function. Rename it to bdrv_do_block_status.
Signed-off-by: Paolo Bonzini
---
block/io.c | 19 +--
1 file
Provide coroutine versions of bdrv_is_allocated* and bdrv_block_status*,
since the underlying BlockDriver API is coroutine-based, and use
automatically-generated wrappers for the "mixed" versions.
Paolo
v1->v2: rename the old bdrv_co_block_status to bdrv_co_do_block_status
Paolo Bonzini (4):
"Wu, Fei" writes:
> On 5/30/2023 6:08 PM, Alex Bennée wrote:
>>
>> "Wu, Fei" writes:
>>
>>> On 5/30/2023 1:01 PM, Wu, Fei wrote:
On 5/30/2023 12:07 PM, Richard Henderson wrote:
> On 5/29/23 04:49, Fei Wu wrote:
>
> IN:
> Priv: 1; Virt: 0
>
> 0x800abe14: 86
Mark functions as coroutine_fn when they are only called by other coroutine_fns
and they can suspend. Change calls to co_wrappers to use the non-wrapped
functions, which in turn requires adding GRAPH_RDLOCK annotations.
Signed-off-by: Paolo Bonzini
---
block/qcow2-bitmap.c | 26 +
bl
Mark functions as coroutine_fn when they are only called by other coroutine_fns
and they can suspend. Change calls to co_wrappers to use the non-wrapped
functions, which in turn requires adding GRAPH_RDLOCK annotations.
Signed-off-by: Paolo Bonzini
---
block/dmg.c | 21 +++--
1
Reviewed-by: Eric Blake
Signed-off-by: Paolo Bonzini
---
block/copy-before-write.c | 2 +-
block/copy-on-read.c | 8
block/io.c| 6 +++---
block/mirror.c| 10 +-
block/qcow2.c | 5 +++--
block/replication.c | 8
bl
1 - 100 of 413 matches
Mail list logo