On 6/1/2023 9:30 AM, Richard Henderson wrote: > On 5/30/23 01:35, Fei Wu wrote: >> diff --git a/accel/tcg/tb-stats.c b/accel/tcg/tb-stats.c >> index 805e1fc74d..139f049ffc 100644 >> --- a/accel/tcg/tb-stats.c >> +++ b/accel/tcg/tb-stats.c >> @@ -267,6 +267,25 @@ void do_hmp_tbstats_safe(CPUState *cpu, >> run_on_cpu_data icmd) >> g_free(cmdinfo); >> } >> +/* >> + * We have to reset the tbs array on a tb_flush as those >> + * TranslationBlocks no longer exist and we no loner know if the >> + * current mapping is still valid. >> + */ > > The "and we no longer..." part is irrelevant: that's what phys_pc checks. > But the TranslationBlocks no longer exist, so that is sufficient. > Will remove this part from comment.
Thanks, Fei. > > r~
