[PATCH v2 10/16] migration/rdma: Unfold hook_ram_load()

2023-05-03 Thread Juan Quintela
There is only one flag called with: RAM_CONTROL_BLOCK_REG. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 10 -- migration/qemu-file.h | 11 --- migration/ram.c | 6 -- migration/rdma.c | 29 + migration/rdma.h | 2 ++ 5

[PATCH v2 06/16] migration/rdma: We can calculate the rioc from the QEMUFile

2023-05-03 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index c37fcab88a..11815d1c11 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -3811,9 +3811,10 @@ out: * the source. */ stati

[PATCH v2 14/16] migration/rdma: Move rdma constants from qemu-file.h to rdma.h

2023-05-03 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/qemu-file.h | 17 - migration/ram.c | 2 +- migration/rdma.h | 16 3 files changed, 17 insertions(+), 18 deletions(-) diff --git a/migration/qemu-file.h b/migration/qemu-file.h index 9c99914b21..5129b6f196 10

[PATCH v2 13/16] qemu-file: Remove QEMUFileHooks

2023-05-03 Thread Juan Quintela
The only user was rdma, and its use is gone. Signed-off-by: Juan Quintela --- migration/qemu-file.c | 6 -- migration/qemu-file.h | 4 migration/rdma.c | 9 - 3 files changed, 19 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 8d3f33fe41..c0c2

[PATCH v2 04/16] migration/rdma: simplify ram_control_load_hook()

2023-05-03 Thread Juan Quintela
Signed-off-by: Juan Quintela --- migration/qemu-file.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c index 22af45a5db..9b5e14a2ef 100644 --- a/migration/qemu-file.c +++ b/migration/qemu-file.c @@ -317,10 +317,8 @@ void qemu

[PATCH v2 05/16] migration/rdma: Don't pass the QIOChannelRDMA as an opaque

2023-05-03 Thread Juan Quintela
We can calculate it from the QEMUFile like the caller. Signed-off-by: Juan Quintela --- migration/rdma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca893c0bba..c37fcab88a 100644 --- a/migration/rdma.c +++ b/migration/rdma.c

[PATCH v2 15/16] migration/rdma: Remove qemu_ prefix from exported functions

2023-05-03 Thread Juan Quintela
Functions are long enough even without this. Signed-off-by: Juan Quintela --- migration/ram.c| 14 +++--- migration/rdma.c | 40 +++- migration/rdma.h | 12 ++-- migration/trace-events | 28 ++-- 4 fi

Re: [PATCH v20 03/21] target/s390x/cpu topology: handle STSI(15) and build the SYSIB

2023-05-03 Thread Nina Schoetterl-Glausch
On Wed, 2023-05-03 at 10:43 +0200, Pierre Morel wrote: > On 5/2/23 19:22, Nina Schoetterl-Glausch wrote: > > On Tue, 2023-04-25 at 18:14 +0200, Pierre Morel wrote: > > > On interception of STSI(15.1.x) the System Information Block > > > (SYSIB) is built from the list of pre-ordered topology entries

Re: [PULL 00/21] Migration 20230428 patches

2023-05-03 Thread Juan Quintela
Peter Maydell wrote: > On Wed, 3 May 2023 at 10:17, Juan Quintela wrote: >> >> Peter Maydell wrote: >> > On Tue, 2 May 2023 at 11:39, Juan Quintela wrote: >> >> Richard, once that we are here, one of the problem that we are having is >> >> that the test is exiting with an abort, so we have no c

Re: [PATCH v2 01/16] migration: Create migrate_rdma()

2023-05-03 Thread Daniel P . Berrangé
On Wed, May 03, 2023 at 03:18:32PM +0200, Juan Quintela wrote: > Helper to say if we are doing a migration over rdma. > > Signed-off-by: Juan Quintela > --- > migration/migration.h | 3 +++ > migration/options.c | 7 +++ > migration/options.h | 1 + > migration/rdma.c | 4 +++- > 4

Re: [PATCH v2 05/16] migration/rdma: Don't pass the QIOChannelRDMA as an opaque

2023-05-03 Thread Daniel P . Berrangé
On Wed, May 03, 2023 at 03:18:36PM +0200, Juan Quintela wrote: > We can calculate it from the QEMUFile like the caller. > > Signed-off-by: Juan Quintela > --- > migration/rdma.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel

Re: [PATCH v5] hostmem-file: add offset option

2023-05-03 Thread David Hildenbrand
On 04.04.23 00:14, Alexander Graf wrote: Add an option for hostmem-file to start the memory object at an offset into the target file. This is useful if multiple memory objects reside inside the same target file, such as a device node. In particular, it's useful to map guest memory directly into

Re: [PATCH v4 07/20] block/export: stop using is_external in vhost-user-blk server

2023-05-03 Thread Kevin Wolf
Am 03.05.2023 um 15:11 hat Stefan Hajnoczi geschrieben: > On Wed, May 03, 2023 at 10:08:46AM +0200, Kevin Wolf wrote: > > Am 02.05.2023 um 22:06 hat Stefan Hajnoczi geschrieben: > > > On Tue, May 02, 2023 at 06:04:24PM +0200, Kevin Wolf wrote: > > > > Am 25.04.2023 um 19:27 hat Stefan Hajnoczi gesc

Re: [PATCH v2 00/12] simpletrace: refactor and general improvements

2023-05-03 Thread John Snow
On Tue, May 2, 2023, 5:24 AM Mads Ynddal wrote: > From: Mads Ynddal > > I wanted to use simpletrace.py for an internal project, so I tried to > update > and polish the code. Some of the commits resolve specific issues, while > some > are more subjective. > > I've tried to divide it into commits

Re: [PULL 00/21] Migration 20230428 patches

2023-05-03 Thread Peter Maydell
On Wed, 3 May 2023 at 14:29, Juan Quintela wrote: > So now we are between a rock and a hard place. > > We have slowed down the bandwidth for migration test because on non > loaded machines, migration was too fast to need more than one pass. > > And we slowed it so much than now we hit the timer th

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas The 'virt' machine uses virtio-net-pci as a fallback when no other network driver has been selected via command line. Select VIRTIO_NET and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-d

Re: [PATCH v2 01/16] migration: Create migrate_rdma()

2023-05-03 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Wed, May 03, 2023 at 03:18:32PM +0200, Juan Quintela wrote: >> Helper to say if we are doing a migration over rdma. > > Is the "MigrationState" allocated freshly for every incoming > or outgoing migration ? If it is reused, then something > needs to set 's->rdma_mig

[PATCH] block: Fix use after free in blockdev_mark_auto_del()

2023-05-03 Thread Kevin Wolf
job_cancel_locked() drops the job list lock temporarily and it may call aio_poll(). We must assume that the list has changed after this call. Also, with unlucky timing, it can end up freeing the job during job_completed_txn_abort_locked(), making the job pointer invalid, too. For both reasons, we

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Max Filippov
On Wed, May 3, 2023 at 2:12 AM Alex Bennée wrote: > > These are needed for board creation so fail under "make check" with a > --without-default-devices build. > > Signed-off-by: Alex Bennée > --- > hw/xtensa/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Max Filippov -- Thank

Re: [PATCH v2 0/3] vhost: memslot handling improvements

2023-05-03 Thread David Hildenbrand
On 20.04.23 16:28, Igor Mammedov wrote: On Thu, 16 Mar 2023 16:36:55 +0100 David Hildenbrand wrote: Following up on my previous work to make virtio-mem consume multiple memslots dynamically [1] that requires precise accounting between used vs. reserved memslots, I realized that vhost makes thi

Re: [PATCH v2 0/3] vhost: memslot handling improvements

2023-05-03 Thread Michael S. Tsirkin
On Wed, May 03, 2023 at 04:16:10PM +0200, David Hildenbrand wrote: > On 20.04.23 16:28, Igor Mammedov wrote: > > On Thu, 16 Mar 2023 16:36:55 +0100 > > David Hildenbrand wrote: > > > > > Following up on my previous work to make virtio-mem consume multiple > > > memslots dynamically [1] that requi

Re: [PATCH 0/2] tcg: ppc64: Fix mask generation for vextractdm

2023-05-03 Thread Daniel Henrique Barboza
Shiva, I just queued patch 1 adding this line in the commit msg: Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1536 This was mentioned by Cedric in patch 2. Also, speaking of patch 2, take a look on Cedric's review and see if it's applicable or not. I plan to send a ppc pull request

Re: [PATCH v3 0/2] Cleanup ppc cr get/set with helper routines

2023-05-03 Thread Daniel Henrique Barboza
Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks, Daniel On 5/3/23 06:36, Harsh Prateek Bora wrote: This patchset introduces helper routines to get/set cr reg for better code readability / maintenance. No functional changes intended with this patchset. Changelog: changes from v2: -

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Kevin Wolf
Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: > Notice that we changed the test of ->has_block_bitmap_mapping > for the test that block_bitmap_mapping is not NULL. > > Signed-off-by: Juan Quintela > Reviewed-by: Vladimir Sementsov-Ogievskiy > > --- > > Make it return const (vladimir)

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Juan Quintela
Kevin Wolf wrote: > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: >> Notice that we changed the test of ->has_block_bitmap_mapping >> for the test that block_bitmap_mapping is not NULL. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> >> --- >> >> Mak

[PATCH 1/2] gitlab: explicit set artifacts publishing criteria

2023-05-03 Thread Daniel P . Berrangé
If not set explicitly, gitlab assumes 'when: on_success" as the publishing criteria for artifacts. This is reasonable if the artifact is an output deliverable of the job. This is useless if the artifact is a log file to be used for debugging job failures. This change makes the desired criteria exp

[PATCH 0/2] gitlab: improve artifact handling

2023-05-03 Thread Daniel P . Berrangé
We are missing test log artifacts from various check jobs on failure, and also missing test logs from the coverage job Daniel P. Berrangé (2): gitlab: explicit set artifacts publishing criteria gitlab: ensure coverage job also publishes meson log .gitlab-ci.d/buildtest-template.yml | 4 +++-

[PATCH 2/2] tests/lcitool: Add mtools and xorriso as dependency for bios bits avocado tests

2023-05-03 Thread Ani Sinha
Bios bits avocado tests need mformat (provided by the mtools package) and xorriso tools in order to run within gitlab CI containers. Add those dependencies within the Dockerfiles so that containers can be built with those tools present. CC: m...@redhat.com CC: berra...@redhat.com Signed-off-by: An

[PATCH 0/2] Add mformat and xorriso dependencies in containers

2023-05-03 Thread Ani Sinha
mformat and xorriso tools are needed by biosbits avocado tests. This patchset adds those two tools in the docker container images. Patch 1 pulls in the latest changes in lcitool in order to add mappings for these packages in various distros. Patch 2 updates all Dockerfiles in QEMU repository to add

[PATCH 1/2] tests: libvirt-ci: Update to commit 'c8971e90ac' to pull in mformat and xorriso

2023-05-03 Thread Ani Sinha
Pull in the following changes from lcitool: * tests/lcitool/libvirt-ci 85487e1...c8971e9 (18): > mappings: add new package mappings for mformat and xorriso > docs: testing: Update contents with tox > .gitlab-ci.yml: Always test against installed lcitool > gitlab-ci.yml: Start using tox for

[PATCH 2/2] gitlab: ensure coverage job also publishes meson log

2023-05-03 Thread Daniel P . Berrangé
The coverage job wants to publish a coverage report on success, but the tests might fail and in that case we need the meson logs for debugging. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/buildtest.yml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.d/bu

Re: [PATCH] linux-user: Add /proc/cpuinfo handler for RISC-V

2023-05-03 Thread Palmer Dabbelt
On Wed, 03 May 2023 04:13:55 PDT (-0700), sch...@suse.de wrote: On Mai 02 2023, Andreas Schwab wrote: None of the currently defined cpus are non-GC cpus (except sifive_e, but that is not suitable for user-space anyway), and there doesn't appear to be any properties defined for changing the supp

Re: [PULL 0/8] Migration 20230428 patches

2023-05-03 Thread Richard Henderson
On 5/3/23 10:25, Juan Quintela wrote: The following changes since commit 4ebc33f3f3b656ebf62112daca6aa0f8019b4891: Merge tag 'pull-tcg-20230502-2' ofhttps://gitlab.com/rth7680/qemu into staging (2023-05-02 21:18:45 +0100) are available in the Git repository at: https://gitlab.com/juan.

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Fabiano Rosas
Paolo Bonzini writes: > On 5/3/23 11:12, Alex Bennée wrote: >> From: Fabiano Rosas >> >> The 'virt' machine uses virtio-net-pci as a fallback when no other >> network driver has been selected via command line. Select VIRTIO_NET >> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEV

Re: [PATCH v2] linux-user: Add /proc/cpuinfo handler for RISC-V

2023-05-03 Thread Palmer Dabbelt
On Wed, 03 May 2023 04:20:09 PDT (-0700), sch...@suse.de wrote: Signed-off-by: Andreas Schwab --- v2: dynmically compute the isa string linux-user/syscall.c | 55 ++-- 1 file changed, 53 insertions(+), 2 deletions(-) diff --git a/linux-user/syscall.c b/

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Peter Xu
On Tue, May 02, 2023 at 09:27:02PM -0300, Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config dat

Re: [PATCH v3 1/2] igb: RX descriptors handling cleanup

2023-05-03 Thread Akihiko Odaki
On 2023/05/03 16:46, Sriram Yagnaraman wrote: -Original Message- From: Tomasz Dzieciol/VIM Integration (NC) /SRPOL/Engineer/Samsung Electronics Sent: Tuesday, 2 May 2023 16:01 To: Sriram Yagnaraman ; qemu- de...@nongnu.org; akihiko.od...@daynix.com Cc: jasow...@redhat.com; k.kwiec...@

Re: [RFC PATCH 0/3] QEMU ACPI generic port support

2023-05-03 Thread Dave Jiang
On 5/3/23 3:42 AM, Jonathan Cameron wrote: On Tue, 18 Apr 2023 15:21:36 -0700 Dave Jiang wrote: s small RFC patch series is really a hack on what I need from qemu rather than a proper implementation. I'm hoping to get some guidance from the list on how to implement this correctly for qemu u

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

2023-05-03 Thread Avihai Horon
On 03/05/2023 1:49, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, May 01, 2023 at 05:01:33PM +0300, Avihai Horon wrote: Hello everyone, Hi, Avihai, === Flow of operation === To use precopy initial data, the capability must be enabled in the source. As

[PATCH v3] linux-user: Add /proc/cpuinfo handler for RISC-V

2023-05-03 Thread Andreas Schwab
>From 912af433fa5d93ce81d2054135ed475ab7462d2d Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Tue, 18 Apr 2023 11:54:01 +0200 Signed-off-by: Andreas Schwab --- v3: fix isa order linux-user/syscall.c | 55 ++-- 1 file changed, 53 insertions(+), 2 del

[PATCH] Add information how to fix common build error on Windows in symlink-install-tree

2023-05-03 Thread Mateusz Krawczuk
By default, Windows doesn't allow to create soft links for user account and only administrator is allowed to do this. To fix this problem you have to raise your permissions or enable Developer Mode, which available since Windows 10. Additional explanation when build fails will allow developer to

Re: [PATCH 2/8] migration: Add precopy initial data handshake

2023-05-03 Thread Avihai Horon
On 03/05/2023 1:54, Peter Xu wrote: External email: Use caution opening links or attachments (I've left high level comment in cover letter, but still some quick comments I noticed when reading) On Mon, May 01, 2023 at 05:01:35PM +0300, Avihai Horon wrote: Add precopy initial data handshake

Re: [PATCH v3] linux-user: Add /proc/cpuinfo handler for RISC-V

2023-05-03 Thread Palmer Dabbelt
On Wed, 03 May 2023 08:30:12 PDT (-0700), sch...@suse.de wrote: From 912af433fa5d93ce81d2054135ed475ab7462d2d Mon Sep 17 00:00:00 2001 From: Andreas Schwab Date: Tue, 18 Apr 2023 11:54:01 +0200 Signed-off-by: Andreas Schwab --- v3: fix isa order linux-user/syscall.c | 55

Re: [PATCH 3/8] migration: Add precopy initial data loaded ACK functionality

2023-05-03 Thread Avihai Horon
On 03/05/2023 1:56, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, May 01, 2023 at 05:01:36PM +0300, Avihai Horon wrote: Add the core functionality of precopy initial data, which allows the destination to ACK that initial data has been loaded and the source

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Alex Bennée
Paolo Bonzini writes: > On 5/3/23 11:12, Alex Bennée wrote: >> From: Fabiano Rosas >> The 'virt' machine uses virtio-net-pci as a fallback when no other >> network driver has been selected via command line. Select VIRTIO_NET >> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVIC

Re: [PATCH] block/export: call blk_set_dev_ops(blk, NULL, NULL)

2023-05-03 Thread Eric Blake
On Tue, May 02, 2023 at 05:11:19PM -0400, Stefan Hajnoczi wrote: > Most export types install BlockDeviceOps pointers. It is easy to forget > to remove them because that happens automatically via the "drive" qdev > property in hw/ but not block/export/. > > Put blk_set_dev_ops(blk, NULL, NULL) call

Re: [PATCH 0/8] migration: Add precopy initial data capability and VFIO precopy support

2023-05-03 Thread Peter Xu
On Wed, May 03, 2023 at 06:22:59PM +0300, Avihai Horon wrote: > > On 03/05/2023 1:49, Peter Xu wrote: > > External email: Use caution opening links or attachments > > > > > > On Mon, May 01, 2023 at 05:01:33PM +0300, Avihai Horon wrote: > > > Hello everyone, > > Hi, Avihai, > > > > > === Flow o

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Leonardo Bras Soares Passos
On Wed, May 3, 2023 at 6:49 AM Jonathan Cameron wrote: > > On Tue, 2 May 2023 21:27:02 -0300 > Leonardo Bras wrote: > > > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > > set for machine types < 8.0 will cause migration to fail if the target > > QEMU version is < 8.0.0

Re: [PATCH] block/blkio: add 'fd' option to virtio-blk-vhost-vdpa driver

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 11:15:56AM +0200, Stefano Garzarella wrote: > On Tue, May 02, 2023 at 03:02:32PM -0400, Stefan Hajnoczi wrote: > > On Tue, May 02, 2023 at 04:50:50PM +0200, Stefano Garzarella wrote: > > > The virtio-blk-vhost-vdpa driver in libblkio 1.3.0 supports the new > > > 'fd' propert

Re: [PATCH] block/export: call blk_set_dev_ops(blk, NULL, NULL)

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 10:43:16AM -0500, Eric Blake wrote: > On Tue, May 02, 2023 at 05:11:19PM -0400, Stefan Hajnoczi wrote: > > Most export types install BlockDeviceOps pointers. It is easy to forget > > to remove them because that happens automatically via the "drive" qdev > > property in hw/ b

Re: [PATCH] block: Fix use after free in blockdev_mark_auto_del()

2023-05-03 Thread Stefan Hajnoczi
On Wed, May 03, 2023 at 04:01:42PM +0200, Kevin Wolf wrote: > job_cancel_locked() drops the job list lock temporarily and it may call > aio_poll(). We must assume that the list has changed after this call. > Also, with unlucky timing, it can end up freeing the job during > job_completed_txn_abort_l

[PATCH risu] use time() as random seed and introduce --randseed option

2023-05-03 Thread Jun Sun
By default, risu currently does not generate random instruction sequences because it uses 0 as the random seed. This patch uses time() as random seed and also introduces --randomseed option for deterministic sequence generation. 0008-add-randseed-option-and-use-time-as-default-seed.patch Descrip

Re: [PATCH 3/3] target/openrisc: Setup FPU for detecting tininess before rounding

2023-05-03 Thread Stafford Horne
On Wed, May 03, 2023 at 10:41:42AM +0100, Richard Henderson wrote: > On 5/3/23 10:14, Stafford Horne wrote: > > > > +set_default_nan_mode(1, &cpu->env.fp_status); > > > > +set_float_detect_tininess(float_tininess_before_rounding, > > > > + &cpu->env.fp_status);

[PATCH risu] --group option to allow all instructions in the specified groups.

2023-05-03 Thread Jun Sun
Current semantic is a little strange when multiple --group options are specified. In this case, only instructions in *all* these groups (i.e., intersection) are used for generation, which is not very useful at all. This patch changes the semantic to include all instructions in these groups (i.e.,

[PATCH risu] Add "--not-group" option to exclude groups of instructions.

2023-05-03 Thread Jun Sun
This mirrors the "--not-pattern" option and gives complete control over group-based instruction selection rules. Signed-off-by: Jun Sun --- risugen | 10 ++ 1 file changed, 10 insertions(+) diff --git a/risugen b/risugen index f88c22a..f441f06 100755 --- a/risugen +++ b/risugen @@ -39,6

RE: [PATCH v3] Hexagon (target/hexagon) Additional instructions handled by idef-parser

2023-05-03 Thread Taylor Simpson
> -Original Message- > From: Anton Johansson > Sent: Tuesday, May 2, 2023 6:12 AM > To: Taylor Simpson ; qemu-devel@nongnu.org > Cc: richard.hender...@linaro.org; phi...@linaro.org; a...@rev.ng; Brian Cain > ; Matheus Bernardino (QUIC) > > Subject: Re: [PATCH v3] Hexagon (target/hexagon

[PATCH] iotests/nbd-reconnect-on-open: Fix NBD socket path

2023-05-03 Thread Kevin Wolf
Socket paths need to be short to avoid failures. This is why there is a iotests.sock_dir (defaulting to /tmp) separate from the disk image base directory. Make use of it to fix failures in too deeply nested test directories. Fixes: ab7f7e67a7e7b49964109501dfcde4ec29bae60e Signed-off-by: Kevin Wol

Re: [PATCH v1 1/1] hw/pci: Disable PCI_ERR_UNCOR_MASK register for machine type < 8.0

2023-05-03 Thread Juan Quintela
Leonardo Bras wrote: > Since it's implementation on v8.0.0-rc0, having the PCI_ERR_UNCOR_MASK > set for machine types < 8.0 will cause migration to fail if the target > QEMU version is < 8.0.0 : > > qemu-system-x86_64: get_pci_config_device: Bad config data: i=0x10a read: 40 > device: 0 cmask: ff

Re: [PATCH risu] use time() as random seed and introduce --randseed option

2023-05-03 Thread Alex Bennée
Jun Sun writes: > By default, risu currently does not generate random instruction sequences > because it uses 0 as the random seed. > This patch uses time() as random seed and also introduces --randomseed option > for deterministic sequence > generation. I can see the benefit for being able

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 17:35, Alex Bennée wrote: You should select a device only if you cannot even start the machine without --nodefaults. Which is the case here right? We could skip tests that explicitly instantiate a device but these are tests failing with default devices the machine tries to instantiate

Re: [PATCH 07/22] hw/arm: Select XLNX_USB_SUBSYS for xlnx-zcu102 machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas This machine hardcodes initialization of the USB device, so select the corresponding Kconfig. It is not enough to have it as "default y if XLNX_VERSAL" at usb/Kconfig because building --without-default-devices disables the default selectio

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Kevin Wolf
Am 03.05.2023 um 16:53 hat Juan Quintela geschrieben: > Kevin Wolf wrote: > > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: > >> Notice that we changed the test of ->has_block_bitmap_mapping > >> for the test that block_bitmap_mapping is not NULL. > >> > >> Signed-off-by: Juan Quintela >

Re: [PATCH 09/22] hw/arm: Select e1000e for sbsa-ref machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas This machine explicitly selects the e1000e network adapter if no other option was given in the command line. Make sure e1000e is present in the build. Signed-off-by: Fabiano Rosas Signed-off-by: Alex Bennée Message-Id: <20230208192654.8

Re: [PATCH 11/22] hw/alpha: make E1000_PCI a hard dependency for clipper

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: We can't just imply it as the board will fail to create otherwise. This shows up as a "make check" failure with a --without-default-devices build. Not needed and a test bug. Paolo

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Juan Quintela
Kevin Wolf wrote: > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: >> Notice that we changed the test of ->has_block_bitmap_mapping >> for the test that block_bitmap_mapping is not NULL. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Vladimir Sementsov-Ogievskiy >> >> --- >> >> Mak

Re: [PATCH 12/22] hw/hppa: add TULIP as a dependency for HPPA_B160L

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: These are needed for board creation so fail under "make check" with a --without-default-devices build. Signed-off-by: Alex Bennée Not needed. Selecting "LSI_SCSI_PCI" however is correct: bus: main-system-bus type System dev: ps2-mouse, id "" dev: ps

Re: [PATCH 13/22] hw/sparc: add a TCX dependency for SUN4M machines

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: This is the fallback VGA devices needed for board creation so will otherwise fail under "make check" with a --without-default-devices build. Signed-off-by: Alex Bennée Not needed: info qtree bus: main-system-bus dev: apc, id "" dev: empty_slot, id ""

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Juan Quintela
Kevin Wolf wrote: > Am 03.05.2023 um 16:53 hat Juan Quintela geschrieben: >> Kevin Wolf wrote: >> > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: >> >> Notice that we changed the test of ->has_block_bitmap_mapping >> >> for the test that block_bitmap_mapping is not NULL. >> >> >> >> Sign

Re: [PATCH 14/22] hw/loongarch: add VIRTIO as a dependency for LOONGARCH_VIRT

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: These are needed for board creation so fail under "make check" with a --without-default-devices build. Signed-off-by: Alex Bennée Also not needed: bus: main-system-bus type System dev: platform-bus-device, id "platform-bus-device" dev: acpi-ged, id ""

Re: [PATCH 15/22] hw/sh4: make RTL8139 a hard dependency for RD2

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: We can't just imply it as the board will fail to create otherwise. This shows up as a "make check" failure with a --without-default-devices build. Not needed, also typo in subject (should be R2D rather than RD2). Paolo

Re: [PATCH 16/22] hw/mips: add VIRTIO and USB dependencies for LOONGSON3V

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: These are hardwired into the board so must be selected. This shows up as a "make check" failure with a --without-default-devices build. Signed-off-by: Alex Bennée --- hw/mips/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/mips/Kconfig b/h

Re: [PATCH 17/22] hw/xtensa: add VIRTIO as dependencies for XTENSA_VIRT

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: These are needed for board creation so fail under "make check" with a --without-default-devices build. Signed-off-by: Alex Bennée --- hw/xtensa/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/xtensa/Kconfig b/hw/xtensa/Kconfig index 0740657

[PATCH v3 0/3] vhost: memslot handling improvements

2023-05-03 Thread David Hildenbrand
Following up on my previous work to make virtio-mem consume multiple memslots dynamically [1] that requires precise accounting between used vs. reserved memslots, I realized that vhost makes this extra hard by filtering out some memory region sections (so they don't consume a memslot) in the vhost-

[PATCH v3 3/3] softmmu/physmem: Fixup qemu_ram_block_from_host() documentation

2023-05-03 Thread David Hildenbrand
Let's fixup the documentation (e.g., removing traces of the ram_addr parameter that no longer exists) and move it to the header file while at it. Suggested-by: Igor Mammedov Acked-by: Igor Mammedov Signed-off-by: David Hildenbrand --- include/exec/cpu-common.h | 15 +++ softmmu/phy

[PATCH v3 1/3] vhost: Rework memslot filtering and fix "used_memslot" tracking

2023-05-03 Thread David Hildenbrand
Having multiple vhost devices, some filtering out fd-less memslots and some not, can mess up the "used_memslot" accounting. Consequently our "free memslot" checks become unreliable and we might run out of free memslots at runtime later. An example sequence which can trigger a potential issue that

[PATCH v3 2/3] vhost: Remove vhost_backend_can_merge() callback

2023-05-03 Thread David Hildenbrand
Checking whether the memory regions are equal is sufficient: if they are equal, then most certainly the contained fd is equal. The whole vhost-user memslot handling is suboptimal and overly complicated. We shouldn't have to lookup a RAM memory regions we got notified about in vhost_user_get_mr_dat

Re: [PATCH 06/22] hw/arm: Select VIRTIO_BLK for virt machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas The virt machine has IF_VIRTIO as block_default_type, which causes the generic code to try to create a virtio-blk-pci device pair at configure_blockdev()/qemu_create_cli_devices(). Select VIRTIO_BLK and VIRTIO_PCI from CONFIG_ARM_VIRT to a

Re: [PATCH 08/22] hw/arm: Select GICV3_TCG for sbsa-ref machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas This machine hardcodes the creation of the interrupt controller, so make sure the dependency is explicitly described in the Kconfig. gicv3_init_cpuif is used unconditionally by arm_gic_realize in hw/intc/arm_gicv3.c, so right now the sep

[PATCH] docs: clarify --without-default-devices

2023-05-03 Thread Paolo Bonzini
--without-default-devices is a specialized option that should only be used when configs/devices/ is changed manually. Explain the model towards which we should tend, with respect to failures to start guests and to run "make check". Signed-off-by: Paolo Bonzini --- docs/devel/kconfig.rst | 16 ++

[PATCH] migration: Fix block_bitmap_mapping migration

2023-05-03 Thread Juan Quintela
It is valid that params->has_block_bitmap_mapping is true and params->block_bitmap_mapping is NULL. So we can't use the trick of having a single function. Move to two functions one for each value and the tests are fixed. Fixes: b804b35b1c8a0edfd127ac20819c234be55ac7fc migration: Create mi

[PATCH v1] virtio-mem: Default to "unplugged-inaccessible=on" with 8.1 on x86-64

2023-05-03 Thread David Hildenbrand
Allowing guests to read unplugged memory simplified the bring-up of virtio-mem in Linux guests -- which was limited to x86-64 only. On arm64 (which was added later), we never had legacy guests and don't even allow to configure it, essentially always having "unplugged-inaccessible=on". At this poin

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Peter Maydell
On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: > > On 5/3/23 17:35, Alex Bennée wrote: > >> You should select a device only if you cannot even start > >> the machine without --nodefaults. > > > > Which is the case here right? We could skip tests that explicitly > > instantiate a device but thes

[PATCH v1] vhost-user: Remove acpi-specific memslot limit

2023-05-03 Thread David Hildenbrand
Let's just support 512 memslots on x86-64 and aarch64 as well. The maximum number of ACPI slots (256) is no longer completely expressive ever since we supported virtio-based memory devices. Further, we're completely ignoring other memslots used outside of memory device context, such as memslots use

Re: [PULL 11/18] migration: Create migrate_block_bitmap_mapping() function

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 03.05.23 20:15, Juan Quintela wrote: Kevin Wolf wrote: Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: Notice that we changed the test of ->has_block_bitmap_mapping for the test that block_bitmap_mapping is not NULL. Signed-off-by: Juan Quintela Reviewed-by: Vladimir Sementsov-Ogiev

[PULL 0/2] NBD pull request for 2023-05-03

2023-05-03 Thread Eric Blake
The following changes since commit 044f8cf70a2fdf3b9e4c4d849c66e7855d2c446a: Merge tag 'migration-20230428-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-05-03 10:29:30 +0100) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-

[PULL 1/2] systemd: Also clear LISTEN_FDNAMES during systemd socket activation

2023-05-03 Thread Eric Blake
Some time after systemd documented LISTEN_PID and LISTEN_FDS for socket activation, they later added LISTEN_FDNAMES; now documented at: https://www.freedesktop.org/software/systemd/man/sd_listen_fds.html In particular, look at the implementation of sd_listen_fds_with_names(): https://github.com/sy

[PULL 2/2] block/export: call blk_set_dev_ops(blk, NULL, NULL)

2023-05-03 Thread Eric Blake
From: Stefan Hajnoczi Most export types install BlockDeviceOps pointers. It is easy to forget to remove them because that happens automatically via the "drive" qdev property in hw/ but not block/export/. Put blk_set_dev_ops(blk, NULL, NULL) calls in the core export.c code so the export types don

Re: [PATCH] migration: Fix block_bitmap_mapping migration

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 03.05.23 21:10, Juan Quintela wrote: It is valid that params->has_block_bitmap_mapping is true and params->block_bitmap_mapping is NULL. So we can't use the trick of having a single function. Move to two functions one for each value and the tests are fixed. Fixes: b804b35b1c8a0edfd127ac2081

Re: [PATCH] iotests/nbd-reconnect-on-open: Fix NBD socket path

2023-05-03 Thread Eric Blake
On Wed, May 03, 2023 at 06:50:19PM +0200, Kevin Wolf wrote: > Socket paths need to be short to avoid failures. This is why there is a > iotests.sock_dir (defaulting to /tmp) separate from the disk image base > directory. > > Make use of it to fix failures in too deeply nested test directories. >

Re: [PATCH] iotests/nbd-reconnect-on-open: Fix NBD socket path

2023-05-03 Thread Vladimir Sementsov-Ogievskiy
On 03.05.23 19:50, Kevin Wolf wrote: Socket paths need to be short to avoid failures. This is why there is a iotests.sock_dir (defaulting to /tmp) separate from the disk image base directory. Make use of it to fix failures in too deeply nested test directories. Fixes: ab7f7e67a7e7b49964109501df

[PATCH 1/3] target/arm: Use CONFIG_SEMIHOSTING instead of TCG for semihosting

2023-05-03 Thread Fabiano Rosas
When building --without-default-devices, the semihosting code will not be available, so check the proper config. Fixes: 29d9efca16 ("arm/Kconfig: Do not build TCG-only boards on a KVM-only build") Signed-off-by: Fabiano Rosas --- target/arm/helper.c | 4 ++-- target/arm/tcg/m_helper.c | 2

[PATCH 0/3] target/arm: disable-tcg and without-default-devices fixes

2023-05-03 Thread Fabiano Rosas
Here's the fix for the cdrom test failure that we discussed in the list, plus 2 fixes for the ---without-default-devices build. When I moved the boards CONFIGs from default.mak to Kconfig, it became possible (due to --without-default-devices) to disable the CONFIGs for all the boards that require

[PATCH 2/3] target/arm: Add CONFIG_ARM_V7M back to default.mak

2023-05-03 Thread Fabiano Rosas
We cannot allow this config to be disabled at the moment as not all of the relevant code is protected by it. Commit 29d9efca16 ("arm/Kconfig: Do not build TCG-only boards on a KVM-only build") moved the CONFIGs of several boards to Kconfig, so it is now possible that nothing selects ARM_V7M (e.g.

[PATCH 3/3] tests/qtest: Don't run cdrom tests if no accelerator is present

2023-05-03 Thread Fabiano Rosas
On a build configured with: --disable-tcg --enable-xen it is possible to produce a QEMU binary with no TCG nor KVM support. Skip the test if that's the case. Fixes: 0c1ae3ff9d ("tests/qtest: Fix tests when no KVM or TCG are present") Signed-off-by: Fabiano Rosas --- tests/qtest/cdrom-test.c | 5

Re: [PATCH 10/13] hw/ide/piix: Reuse PCIIDEState::{cmd,data}_ops

2023-05-03 Thread Mark Cave-Ayland
On 27/04/2023 19:15, Bernhard Beschow wrote: Am 27. April 2023 10:52:17 UTC schrieb Mark Cave-Ayland : On 26/04/2023 21:14, Bernhard Beschow wrote: Am 26. April 2023 18:18:35 UTC schrieb Bernhard Beschow : Am 26. April 2023 11:37:48 UTC schrieb Mark Cave-Ayland : On 22/04/2023 16:07, Be

Re: [PATCH 7/9] target/sparc: Finish conversion to tcg_gen_qemu_{ld, st}_*

2023-05-03 Thread Mark Cave-Ayland
On 02/05/2023 14:57, Richard Henderson wrote: Convert away from the old interface with the implicit MemOp argument. Signed-off-by: Richard Henderson --- target/sparc/translate.c | 43 ++-- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/ta

Re: [PATCH 11/13] hw/ide/sii3112: Reuse PCIIDEState::{cmd,data}_ops

2023-05-03 Thread Mark Cave-Ayland
On 27/04/2023 13:55, BALATON Zoltan wrote: On Thu, 27 Apr 2023, Mark Cave-Ayland wrote: On 27/04/2023 00:24, BALATON Zoltan wrote: On Wed, 26 Apr 2023, Bernhard Beschow wrote: Am 26. April 2023 11:41:54 UTC schrieb Mark Cave-Ayland : On 22/04/2023 16:07, Bernhard Beschow wrote: Allows to u

Re: [PATCH 13/16] target/sparc: Use MO_ALIGN where required

2023-05-03 Thread Mark Cave-Ayland
On 02/05/2023 17:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- target/sparc/translate.c | 66 +--- 1 file changed, 34 insertions(+), 32 deletions(-) diff --git a/target/sparc/translate.c b/target/sparc/translate.c index bc71e44e66..414

Re: [PATCH 14/16] target/sparc: Use cpu_ld*_code_mmu

2023-05-03 Thread Mark Cave-Ayland
On 02/05/2023 17:08, Richard Henderson wrote: This passes on the memop as given as argument to helper_ld_asi to the ultimate load primitive. Signed-off-by: Richard Henderson --- target/sparc/ldst_helper.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/target/

Re: [PATCH 15/16] target/sparc: Remove TARGET_ALIGNED_ONLY

2023-05-03 Thread Mark Cave-Ayland
On 02/05/2023 17:08, Richard Henderson wrote: Signed-off-by: Richard Henderson --- configs/targets/sparc-linux-user.mak | 1 - configs/targets/sparc-softmmu.mak | 1 - configs/targets/sparc32plus-linux-user.mak | 1 - configs/targets/sparc64-linux-user.mak | 1 - config

<    1   2   3   4   5   6   >