Kevin Wolf <kw...@redhat.com> wrote:
> Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben:
>> Notice that we changed the test of ->has_block_bitmap_mapping
>> for the test that block_bitmap_mapping is not NULL.
>>
>> Signed-off-by: Juan Quintela <quint...@redhat.com>
>> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
>>
>> ---
>>
>> Make it return const (vladimir)
>
> (I don't think this part was actually meant for the commit message)
yeap. My understandig has always been that this is the way to put
commenst for the email.
> This commit broke qemu-iotests 300 on master. Please have a look.
if (s->parameters.has_block_bitmap_mapping)
return s->parameters.block_bitmap_mapping;
The test has a case where s->parameters.has_block_bitmap_mapping is true
but s->parameters.block_bitmap_mapping is false.
If that combination is right, then we need two functions becase the
asumtion that I did is false.
Vladimir?
Later, Juan.
> Kevin
